Re: [PATCH v2 2/2] misc: Replace zero-length arrays with flexible array member (manual)

On Wed, Mar 04, 2020 at 04:38:16PM +0100, Philippe Mathieu-Daudé wrote: > Description copied from Linux kernel commit from Gustavo A. R. Silva > (see [3]): > > --v-- description start --v-- > > The current codebase makes use of the zero-length array language > extension to the C90 standard, b

Re: [PATCH v2 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

On Wed, Mar 04, 2020 at 04:38:15PM +0100, Philippe Mathieu-Daudé wrote: > Description copied from Linux kernel commit from Gustavo A. R. Silva > (see [3]): > > --v-- description start --v-- > > The current codebase makes use of the zero-length array language > extension to the C90 standard, b

Re: [PATCH v32 22/22] qemu-doc.texi: Add RX section.

On Sun, 08 Mar 2020 02:38:08 +0900, Philippe Mathieu-Daudé wrote: > > Hi, > > On 2/24/20 3:19 PM, Yoshinori Sato wrote: > > Describe emulated target specification. And two examples. > > > > Signed-off-by: Yoshinori Sato > > --- > > qemu-doc.texi | 44 ++

Re: TCG global variable aliasing/optimization question

On 3/6/20 7:55 AM, Taylor Simpson wrote: > Does the TCG optimizer assume all global variables are unique? Yes. > If so, is there a method to indicate that two global variables alias? No. This is why combined fpu+vector register sets, such as ARM NEON, are modeled as a block of memory within CPU

[PATCH v3 1/2] target/arm: Check addresses for disabled regimes

We fail to validate the upper bits of a virtual address on a translation disabled regime, as per AArch64.TranslateAddressS1Off. Signed-off-by: Richard Henderson --- target/arm/helper.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/target/

[PATCH v3 2/2] target/arm: Disable clean_data_tbi for system mode

We must include the tag in the FAR_ELx register when raising an addressing exception. Which means that we should not clear out the tag during translation. We cannot at present comply with this for user mode, so we retain the clean_data_tbi function for the moment, though it no longer does what it

[PATCH v3 0/2] target/arm: Misc cleanups surrounding TBI

Changes for v3: * All but 2 patches are now merged. * Use regime_el to determine aa64-ness of physical memory addressing. r~ Richard Henderson (2): target/arm: Check addresses for disabled regimes target/arm: Disable clean_data_tbi for system mode target/arm/helper.c| 35 +

Re: [PATCH] riscv: Add semihosting support [v4]

Palmer Dabbelt writes: > I think, more concretely, the issues here are: > > * The only mention of "semihosting" in the RISC-V specification is in the > commentary, which is not considered a normative part of the > specification. Ok, we're starting the process of creating a 'real' RISC-V semiho

Re: [PATCH v8 0/9] qemu-binfmt-conf.sh

Patchew URL: https://patchew.org/QEMU/20200307170251.GA7@dd5f6ec33fb0/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v8 0/9] qemu-binfmt-conf.sh

Patchew URL: https://patchew.org/QEMU/20200307170251.GA7@dd5f6ec33fb0/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v8 0/9] qemu-binfmt-conf.sh Message-id: 20200307170251.GA7@dd5f6ec33fb0 Type: series === TEST SCRIPT BEGIN ==

[PATCH v8 8/9] qemu-binfmt-conf.sh: add option --clear

This is a partial implementation. Allows to remove a single or a list of already registered binfmt interpreters. Valid values are those in qemu_target_list. If TARGETS is empty, all the existing 'qemu-*' interpreters are removed. This is partial because 'debian' and 'systemd' configurations are n

[PATCH v8 9/9] qemu-binfmt-conf.sh: add --test

Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 9685456747..4635871e6d 100755 --- a/scripts/qe

[PATCH v8 7/9] qemu-binfmt-conf.sh: generalize to positional [TARGETS]

This breaks brackward compatibility. Option '--systemd CPU' allows to register binfmt interpreters for a single target architecture or for 'ALL' (of them). This patch generalizes the approach to support it in any mode (default, '--debian' or '--systemd'). To do so, option 'systemd' is changed to b

[PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options

This breaks backward compatibility. Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is not present in other option names ('debian', 'systemd', 'persistent', 'credential'...). In order to keep consistency, the prefix is removed. Signed-off-by: Unai Martinez-Corral Reviewed-by

[PATCH v8 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX

Allow to set 'path' or 'suffix' through environment variables, consistently with 'persistent' and 'credential'. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/qe

[PATCH v8 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*

Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 63 +++-- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 347cddf698..251a78a2ce 10075

Re: [Qemu-devel] [PATCH] some remarks to build last version of qemu in MSYS2 (from user)

Hi Youry, On 6/20/19 2:38 AM, Метлицкий Юрий wrote: Hello! Today I tried to build qemu from git in the current version of MSYS2 for Windows 10 (X64). As a result, got the file qemu-setup-4.0.50.exe But on the way to this I met several problems that I want to share. Sorry to be newbie and writ

[PATCH v8 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT

Allow to set options '--persistent' and/or '--credential' through environment variables. If not defined, defaults are used ('no'). Anyway, command-line arguments have priority over environment variables. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-con

[PATCH v8 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean

This patch breaks backward compatibility. Both '--persistent' and '--credential' default to 'no'. Hence, '-p no' or '-c no' are redundant. Overall, accepting an argument might be misleading because options are, indeed, boolean. This patch makes both options boolean in getopt, so if any of them is

[PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency

Spaces are added before '; then', for consistency. All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 14 +++-

[PATCH v8 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*

Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 63 +++-- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 347cddf698..251a78a2ce 10075

Re: [PATCH 0/3] buildsys: Fix building with SASL on Windows

Patchew URL: https://patchew.org/QEMU/2020030717.14764-1-phi...@redhat.com/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[PATCH v8 9/9] qemu-binfmt-conf.sh: add --test

Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 9685456747..4635871e6d 100755 --- a/scripts/qe

Re: [PATCH v4 1/5] target/riscv: add vector unit stride load and store instructions

On 3/6/20 8:36 PM, LIU Zhiwei wrote: > I define fields shared between vector helpers and decode code. > FIELD(VDATA, MLEN, 0, 8) > FIELD(VDATA, VM, 8, 1) > FIELD(VDATA, LMUL, 9, 2) > FIELD(VDATA, NF， 11， 4） > > But I can't find a  good place to place the fields. There is not a > "translate.h" in t

[PATCH v8 8/9] qemu-binfmt-conf.sh: add option --clear

This is a partial implementation. Allows to remove a single or a list of already registered binfmt interpreters. Valid values are those in qemu_target_list. If TARGETS is empty, all the existing 'qemu-*' interpreters are removed. This is partial because 'debian' and 'systemd' configurations are n

[PATCH v8 7/9] qemu-binfmt-conf.sh: generalize to positional [TARGETS]

This breaks brackward compatibility. Option '--systemd CPU' allows to register binfmt interpreters for a single target architecture or for 'ALL' (of them). This patch generalizes the approach to support it in any mode (default, '--debian' or '--systemd'). To do so, option 'systemd' is changed to b

Re: [PATCH v32 22/22] qemu-doc.texi: Add RX section.

Hi, On 2/24/20 3:19 PM, Yoshinori Sato wrote: Describe emulated target specification. And two examples. Signed-off-by: Yoshinori Sato --- qemu-doc.texi | 44 1 file changed, 44 insertions(+) diff --git a/qemu-doc.texi b/qemu-doc.texi index 33b95

[PATCH v8 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX

Allow to set 'path' or 'suffix' through environment variables, consistently with 'persistent' and 'credential'. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/qe

[PATCH 6/9] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX

Allow to set 'path' or 'suffix' through environment variables, consistently with 'persistent' and 'credential'. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/qe

[PATCH v8 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options

This breaks backward compatibility. Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is not present in other option names ('debian', 'systemd', 'persistent', 'credential'...). In order to keep consistency, the prefix is removed. Signed-off-by: Unai Martinez-Corral Reviewed-by

[PATCH v8 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*

Signed-off-by: Unai Martinez-Corral --- scripts/qemu-binfmt-conf.sh | 63 +++-- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 347cddf698..251a78a2ce 100755 --- a/scripts/qemu-binfmt-c

[PATCH v8 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT

Allow to set options '--persistent' and/or '--credential' through environment variables. If not defined, defaults are used ('no'). Anyway, command-line arguments have priority over environment variables. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-con

Re: [PATCH v3 2/2] cmd646: remove unused pci_cmd646_ide_init() function

On 3/7/20 10:13 AM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- hw/ide/cmd646.c | 12 include/hw/ide.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 335c060673..d953932104 100644 -

[PATCH v8 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean

This patch breaks backward compatibility. Both '--persistent' and '--credential' default to 'no'. Hence, '-p no' or '-c no' are redundant. Overall, accepting an argument might be misleading because options are, indeed, boolean. This patch makes both options boolean in getopt, so if any of them is

Re: [PATCH 1/2] cmd646: register cmd646_reset() function in DeviceClass

On 3/7/20 4:15 PM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- hw/ide/cmd646.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 335c060673..2f11d8de24 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -207,9

Re: [PATCH 2/2] cmd646: register vmstate_ide_pci VMStateDescription in DeviceClass

On 3/7/20 4:15 PM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- hw/ide/cmd646.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 2f11d8de24..3c4f765bd6 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -301,8 +301

[PATCH 2/3] configure: Fix building with SASL on Windows

The Simple Authentication and Security Layer (SASL) library re-defines the struct iovec on Win32 [*]. QEMU also re-defines it in "qemu/osdep.h". The two definitions then clash on a MinGW build. We can avoid the SASL definition by defining STRUCT_IOVEC_DEFINED. Add the definition to vnc_sasl_cflags

[PATCH 1/3] configure: Check for header before external libraries

In the next commit we will add a definition to the SASL CFLAGS, depending whether the scatter/gather I/O include is present. Move the header check before the external libraries checks. Signed-off-by: Philippe Mathieu-Daudé --- configure | 52 ++--

[PATCH v8 1/9] qemu-binfmt-conf.sh: enforce safe style consistency

Spaces are added before '; then', for consistency. All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 14 +++-

[PATCH 3/3] tests/docker: Install SASL library to extend code coverage on amd64

Install the SASL library to build the VNC SASL auth protocol code. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian-amd64.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.dock

[PATCH 0/3] buildsys: Fix building with SASL on Windows

Fix a bug reported by Youry few months ago: https://www.mail-archive.com/qemu-devel@nongnu.org/msg625606.html The Fedora docker image already uses the libsasl since commit 8ea5962f286. Add the similar package to the Debian (host) image. Philippe Mathieu-Daudé (3): configure: Check for header b

[PATCH v8 0/9] qemu-binfmt-conf.sh

Hi, This series reworks qemu-binfmt-conf.sh: * Argument from option '--systemd' is generalized to , and it is accepted for any mode (default, debian or systemd). It can be a single target arch or a list of them. * Option '-r|--clear' is added, which allows to remove an already registered t

Re: [PATCH v2] virtio-serial-bus: do cleanup on the error path in realize() to avoid memleaks

On Fri, Mar 06, 2020 at 05:35:06PM +0800, Pan Nengyuan wrote: > > > On 3/6/2020 4:51 PM, Markus Armbruster wrote: > > Pan Nengyuan writes: > > > >> port->bh forgot to delete on the error path, this patch add it to fix > >> memleaks. It's easy to reproduce as follow(add a same nr port): > > >

Re: [PATCH 2/2] via-ide: Also emulate non 100% native mode

On Sat, 7 Mar 2020, Mark Cave-Ayland wrote: On 06/03/2020 22:59, BALATON Zoltan wrote: I've done a quick grep of the source tree and AFAICT the only IDE controller that tries to use the PCI_INTERRUPT_LINE register is via-ide, which means this should be fairly easy. In short: 1) Add qemu_irq l

[PATCH 0/2] cmd646: use DeviceClass for reset and VMStateDescription

Another couple of improvements that update the cmd646 device class to avoid having to manually register the reset function and VMStateDescription at realize time. Signed-off-by: Mark Cave-Ayland Mark Cave-Ayland (2): cmd646: register cmd646_reset() function in DeviceClass cmd646: register v

[PATCH 2/2] cmd646: register vmstate_ide_pci VMStateDescription in DeviceClass

Signed-off-by: Mark Cave-Ayland --- hw/ide/cmd646.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 2f11d8de24..3c4f765bd6 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -301,8 +301,6 @@ static void pci_cmd646_ide_realize(PCIDev

[PATCH 1/2] cmd646: register cmd646_reset() function in DeviceClass

Signed-off-by: Mark Cave-Ayland --- hw/ide/cmd646.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 335c060673..2f11d8de24 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -207,9 +207,9 @@ static void cmd646_set_irq(void *opaq

Re: [PATCH] hw/riscv: Generate correct "mmu-type" for 32-bit machines

Patchew URL: https://patchew.org/QEMU/1583585319-26603-1-git-send-email-bmeng...@gmail.com/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

[PATCH 1/2] hw/rdma: Cosmetic change - no need for two sge arrays

The function build_host_sge_array uses two sge arrays, one for input and one for output. Since the size of the two arrays is the same, the function can write directly to the given source array (i.e. input/output argument). Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 40 ++

[PATCH 0/2] hw/rdma: Last step in eliminating data-path processing

With emulated device we have the luxury of doing things in data-path. Considering a future virtio-rdma device we no longer have this luxury. The driver will directly post WQEs to HW queues, bypassing the device emulator in qemu. These WQEs will consist of addresses known to the device (even if it i

[PATCH 2/2] hw/rdma: Skip data-path mr_id translation

With the change made in commit 68b89aee71 ("Utilize ibv_reg_mr_iova for memory registration") the MR emulation is no longer needed in order to translate the guest addresses into host addresses. With that, the next obvious step is to skip entirely the processing in data-path. To accomplish this, ret

[PATCH] hw/riscv: Generate correct "mmu-type" for 32-bit machines

32-bit machine should have its CPU's "mmu-type" set to "riscv,sv32". Signed-off-by: Bin Meng --- hw/riscv/sifive_u.c | 4 hw/riscv/spike.c| 4 hw/riscv/virt.c | 4 3 files changed, 12 insertions(+) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index d318988..26e

Re: [PATCH 2/2] via-ide: Also emulate non 100% native mode

On 06/03/2020 22:59, BALATON Zoltan wrote: I've done a quick grep of the source tree and AFAICT the only IDE controller that tries to use the PCI_INTERRUPT_LINE register is via-ide, which means this should be fairly easy. In short: 1) Add qemu_irq legacy_irqs[2

Re: [PATCH] core/qdev: fix memleak in qdev_get_gpio_out_connector()

Hi On Sat, Mar 7, 2020 at 3:53 AM Pan Nengyuan wrote: > > Fix a memory leak in qdev_get_gpio_out_connector(). > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan good catch, Reviewed-by: Marc-André Lureau > --- > hw/core/qdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

make test failure for iotest 267 on qemu-system-sparc64

Hi all, After a recent rebase I've started seeing iotest 267 after running "make check" on qemu-system-sparc64. The diff output looks similar to this: --- /home/build/src/qemu/git/qemu/tests/qemu-iotests/267.out2020-01-22 17:57:54.246650995 + +++ /home/build/src/qemu/git/qemu/tests/qemu-

[PATCH v3 2/2] cmd646: remove unused pci_cmd646_ide_init() function

Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- hw/ide/cmd646.c | 12 include/hw/ide.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 335c060673..d953932104 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -31

[PATCH v3 0/2] cmd646: remove pci_cmd646_ide_init() function

The recent cmd646 discussions reminded me of this patch I've had sitting in an old branch for a while. The DP264 machine is the last remaining user of the deprecated pci_cmd646_ide_init() init function. Switch it over to using qdev via pci_create() and then remove the now-unused pci_cmd646_ide_in

[PATCH v3 1/2] dp264: use pci_create_simple() to initialise the cmd646 device

Remove the call to pci_cmd646_ide_init() since global device init functions are deprecated in preference of using qdev directly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- hw/alpha/dp264.c | 6 +- 1 file changed, 5 insertions(+),