[PATCH 6/9] ossaudio: prevent SIGSEGV in oss_enable_out

2020-01-22 Thread Volker Rümelin
With audiodev parameter out.mixing-engine=off hw->mix_buf is NULL. This patch reverts a small part of dc88e38fa7 "audio: unify input and output mixeng buffer management". To reproduce the problem start qemu with -audiodev oss,id=audio0,try-mmap=on,out.mixing-engine=off Signed-off-by: Volker Rümel

[PATCH 7/9] ossaudio: prevent SIGPFE in oss_write

2020-01-22 Thread Volker Rümelin
The new buffer write position is modulo the buffer size. To reproduce start qemu with: -audiodev oss,id=audio0,try-mmap=on,out.mixing-engine=off Signed-off-by: Volker Rümelin --- audio/ossaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/ossaudio.c b/audio/ossaud

[PATCH 4/9] audio: prevent SIGSEGV in AUD_get_buffer_size_out

2020-01-22 Thread Volker Rümelin
With audiodev parameter out.mixing-engine=off hw->mix_buf is NULL. This leads to a segmentation fault in AUD_get_buffer_size_out. This patch reverts a small part of dc88e38fa7 "audio: unify input and output mixeng buffer management". To reproduce the problem start qemu with -soundhw adlib -audiode

Re: [PATCH] target/s390x/translate: Do not leak stack address in translate_one()

2020-01-22 Thread David Hildenbrand
> Am 23.01.2020 um 08:05 schrieb Thomas Huth : > > The code in translate_one() leaks a stack address via "s->field" parameter: > > static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) > { > DisasJumpType ret = DISAS_NEXT; > DisasFields f; > [...] > s->fields

[PATCH 3/9] paaudio: remove unused variables

2020-01-22 Thread Volker Rümelin
The unused variables were last used before commit 49ddd7e122 "paaudio: port to the new audio backend api". Signed-off-by: Volker Rümelin --- audio/paaudio.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index dbfe48c03a..8f37c61851 10

[PATCH 5/9] audio: fix bug 1858488

2020-01-22 Thread Volker Rümelin
The combined generic buffer management code and buffer run out code in function audio_generic_put_buffer_out has a problematic behaviour. A few hundred milliseconds after playback starts the mixing buffer and the generic buffer are nearly full and the following pattern can be seen. On first call o

[PATCH 8/9] ossaudio: disable poll mode can't be reached

2020-01-22 Thread Volker Rümelin
Currently there is no way to disable poll mode in oss_enable_out and oss_enable_in when it was enabled before. The enable code path always resets the poll mode state variable. Fixes: b027a538c6 "oss: Remove unused error handling of qemu_set_fd_handler" Signed-off-by: Volker Rümelin --- audio/os

[PATCH 9/9] audio: audio_generic_get_buffer_in should honor *size

2020-01-22 Thread Volker Rümelin
The function generic_get_buffer_in currently ignores the *size parameter and may return a buffer larger than *size. As a result the variable samples in function audio_pcm_hw_run_in may underflow. The while loop then most likely will never termiate. This bug was reported at http://bugs.debian.org/

[PATCH 1/9] audio: fix audio_generic_write

2020-01-22 Thread Volker Rümelin
The pcm_ops function put_buffer_out expects the returned pointer of function get_buffer_out as argument. Fix this. Signed-off-by: Volker Rümelin --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/audio.c b/audio/audio.c index abea027fdf..db44482342 100644

[PATCH 2/9] audio: fix audio_generic_read

2020-01-22 Thread Volker Rümelin
It seems the function audio_generic_read started as a copy of function audio_generic_write and some necessary changes were forgotten. Fix the mixed up source and destination pointers and rename misnamed variables. Signed-off-by: Volker Rümelin --- audio/audio.c | 10 +- 1 file changed, 5

Re: [PULL v3 00/18] virtio, pc: fixes, features

2020-01-22 Thread Michael S. Tsirkin
On Wed, Jan 22, 2020 at 11:45:33PM -0800, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200123070913.626488-1-...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. yes but they are fixed by a follow up patch :) > See output below for > m

Re: [PULL v3 00/18] virtio, pc: fixes, features

2020-01-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200123070913.626488-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200123070913.626488-1-...@redhat.com Subject: [PULL v3 00/18] virtio, pc: fixes, features =

[PATCH 0/9] more audio fixes and improvements

2020-01-22 Thread Volker Rümelin
The first two patches "audio: fix audio_generic_write" and "audio: fix audio_generic_read" are only compile tested. The code is only reachable from the DirectSound backend with the mixing-engine off. I don't know if it is reachable at all. I can't test because I don't have a Windows computer. Volk

Re: Integrating QOM into QAPI

2020-01-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Jan 22, 2020 at 4:25 PM Markus Armbruster wrote: >> >> Alex Bennée writes: >> >> > Marc-André Lureau writes: >> >> Actually, we are not that far off from being able to use GObject >> >> altogether (I hacked something like that to play with), but I >>

[PULL v3 17/18] i386:acpi: Remove _HID from the SMBus ACPI entry

2020-01-22 Thread Michael S. Tsirkin
From: Corey Minyard Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required on enumerated buses (like PCI in this case), _ADR is required (and is already there). And the _HID value is wrong. Linux appears to ignore the _HID entry, but Windows 10 detects it as 'Unknown Device' and

[PULL v3 16/18] vhost: Only align sections for vhost-user

2020-01-22 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" I added hugepage alignment code in c1ece84e7c9 to deal with vhost-user + postcopy which needs aligned pages when using userfault. However, on x86 the lower 2MB of address space tends to be shotgun'd with small fragments around the 512-640k range - e.g. video RAM, an

[PULL v3 18/18] vhost: coding style fix

2020-01-22 Thread Michael S. Tsirkin
Drop a trailing whitespace. Make line shorter. Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user") Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 25fd4691

Re: Making QEMU easier for management tools and applications

2020-01-22 Thread Markus Armbruster
John Snow writes: > On 12/24/19 8:41 AM, Daniel P. Berrangé wrote: >>> * scripts/qmp/qmp-shell >>> >>> Half-hearted attempt at a human-friendly wrapper around the JSON >>> syntax. I have no use for this myself. >> I use this fairly often as its a useful debugging / experimentation >> / troub

Re: Making QEMU easier for management tools and applications

2020-01-22 Thread Markus Armbruster
John Snow writes: > On 12/24/19 8:00 AM, Daniel P. Berrangé wrote: >> Based on experiance in libvirt, this is an even larger job than (4), >> as the feature set here is huge. Much of it directly ties into the >> config problem, as to deal with SELinux / namespace setup the code >> needs to under

[PULL v3 14/18] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks

2020-01-22 Thread Michael S. Tsirkin
From: Pan Nengyuan Receive/transmit/event vqs forgot to cleanup in vhost_vsock_unrealize. This patch save receive/transmit vq pointer in realize() and cleanup vqs through those vq pointers in unrealize(). The leak stack is as follow: Direct leak of 21504 byte(s) in 3 object(s) allocated from:

[PULL v3 15/18] vhost: Add names to section rounded warning

2020-01-22 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Add the memory region names to section rounding/alignment warnings. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20200116202414.157959-2-dgilb...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 7 -

[PULL v3 08/18] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov Firmware can enumerate present at boot APs by broadcasting wakeup IPI, so that woken up secondary CPUs could register them-selves. However in CPU hotplug case, it would need to know architecture specific CPU IDs for possible and hotplugged CPUs so it could prepare environment

[PULL v3 12/18] virtio-scsi: delete vqs in unrealize to avoid memleaks

2020-01-22 Thread Michael S. Tsirkin
From: Pan Nengyuan This patch fix memleaks when attaching/detaching virtio-scsi device, the memory leak stack is as follow: Direct leak of 21504 byte(s) in 3 object(s) allocated from: #0 0x7f491f2f2970 (/lib64/libasan.so.5+0xef970) ??:? #1 0x7f491e94649d (/lib64/libglib-2.0.so.0+0x5249d) ?

[PULL v3 10/18] virtio-9p-device: fix memleak in virtio_9p_device_unrealize

2020-01-22 Thread Michael S. Tsirkin
From: Pan Nengyuan v->vq forgot to cleanup in virtio_9p_device_unrealize, the memory leak stack is as follow: Direct leak of 14336 byte(s) in 2 object(s) allocated from: #0 0x7f819ae43970 (/lib64/libasan.so.5+0xef970) ??:? #1 0x7f819872f49d (/lib64/libglib-2.0.so.0+0x5249d) ??:? #2 0x55a

[PULL v3 13/18] virtio-scsi: convert to new virtio_delete_queue

2020-01-22 Thread Michael S. Tsirkin
From: Pan Nengyuan Use virtio_delete_queue to make it more clear. Signed-off-by: Pan Nengyuan Message-Id: <20200117075547.60864-3-pannengy...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 6 +++--- 1 fi

[PULL v3 07/18] acpi: cpuhp: spec: add typical usecases

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov Document work-flows for * enabling/detecting modern CPU hotplug interface * finding a CPU with pending 'insert/remove' event * enumerating present and possible CPUs Signed-off-by: Igor Mammedov Message-Id: <1575896942-331151-9-git-send-email-imamm...@redhat.com> Review

[PULL v3 09/18] bios-tables-test: document expected file update

2020-01-22 Thread Michael S. Tsirkin
Document the flow for the case where contributor updates the expected files. Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-

[PULL v3 11/18] virtio-9p-device: convert to new virtio_delete_queue

2020-01-22 Thread Michael S. Tsirkin
From: Pan Nengyuan Use virtio_delete_queue to make it more clear. Signed-off-by: Pan Nengyuan Message-Id: <20200117060927.51996-3-pannengy...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Christian Schoenebeck --- hw/9pfs/virtio-9p-device.c | 2 +-

[PULL v3 04/18] acpi: cpuhp: spec: fix 'Command data' description

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov Correct returned value description in case 'Command field' == 0x0, it's not PXM but CPU selector value with pending event In addition describe 0 blanket value in case of not supported 'Command field' value. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek Message-Id:

[PULL v3 06/18] acpi: cpuhp: introduce 'Command data 2' field

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov No functional change in practice, patch only aims to properly document (in spec and code) intended usage of the reserved space. The new field is to be used for 2 purposes: - detection of modern CPU hotplug interface using CPHP_GET_NEXT_CPU_WITH_EVENT_CMD command. pr

[PULL v3 05/18] acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov Write section of 'Command data' register should describe what happens when it's written into. Correct description in case the last stored 'Command field' value is equal to 0, to reflect that currently it's not supported. Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek

[PULL v3 02/18] tests: q35: MCH: add default SMBASE SMRAM lock test

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov test lockable SMRAM at default SMBASE feature, introduced by patch "q35: implement 128K SMRAM at default SMBASE address" Signed-off-by: Igor Mammedov Message-Id: <1575899217-333105-1-git-send-email-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[PULL v3 03/18] acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov * Move reserved registers to the top of the section, so reader would be aware of effects when reading registers description. * State registers endianness explicitly at the beginning of the section * Describe registers behavior in case of 'CPU selector' register contains va

[PULL v3 01/18] q35: implement 128K SMRAM at default SMBASE address

2020-01-22 Thread Michael S. Tsirkin
From: Igor Mammedov It's not what real HW does, implementing which would be overkill [**] and would require complex cross stack changes (QEMU+firmware) to make it work. So considering that SMRAM is owned by MCH, for simplicity (ab)use reserved Q35 register, which allows QEMU and firmware easily i

[PULL v3 00/18] virtio, pc: fixes, features

2020-01-22 Thread Michael S. Tsirkin
Changes from v2: - add a coding style fix Changes from v1: - add a missing expected file The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +)

[PATCH] target/s390x/translate: Do not leak stack address in translate_one()

2020-01-22 Thread Thomas Huth
The code in translate_one() leaks a stack address via "s->field" parameter: static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s) { DisasJumpType ret = DISAS_NEXT; DisasFields f; [...] s->fields = &f; [...] return ret; } It's currently harmless s

Re: [PATCH v4 06/11] tests/virtio-9p: added splitted readdir test

2020-01-22 Thread Greg Kurz
On Wed, 22 Jan 2020 22:29:12 +0100 Christian Schoenebeck wrote: > On Mittwoch, 22. Januar 2020 22:14:39 CET Eric Blake wrote: > > On 1/20/20 6:16 PM, Christian Schoenebeck wrote: > > > The previous, already existing readdir test simply used a 'count' > > > parameter big enough to retrieve all dir

[PATCH] hw/bt: Remove empty Kconfig file

2020-01-22 Thread Thomas Huth
While removing the bluetooth code some weeks ago, I had to leave the hw/bt/Kconfig file around. Otherwise some of the builds would have been broken since the generated dependency files tried to include it before they were rebuilt. Meanwhile, all those dependency files should have been updated, so w

[Bug 1592336] Re: mouse is defunct when grabbed

2020-01-22 Thread Thomas Huth
Can you still reproduce the issue with the latest version of QEMU (currently v4.2)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1592336 Title:

[Bug 1592351] Re: mouse pointer offset with gtk,gl=on

2020-01-22 Thread Thomas Huth
FWIW: Commit f1aba960cc40 has been released with v3.1.0. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1592351 Title: mouse pointer off

[Bug 1859656] Re: [2.6] Unable to reboot s390x KVM machine after initial deploy

2020-01-22 Thread Frank Heimes
** Tags added: s390x -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859656 Title: [2.6] Unable to reboot s390x KVM machine after initial deploy Status in MAAS: New Status in QEMU: Incomplete S

[Bug 1639394] Re: Unable to boot Solaris 8/9 x86 under Fedora 24

2020-01-22 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1639394 Title: Unable to boot Solaris 8/9 x86 under Fedora 24 Status in QEMU: Incomplete Bug d

[Bug 1659901] Re: Regression: SIGSEGV running Java

2020-01-22 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete ** Bug watch removed: Linaro Bug Tracking System #3259 https://bugs.linaro.org/show_bug.cgi?id=3259 ** Bug watch removed: github.com/multiarch/qemu-user-static/issues #18 https://github.com/multiarch/qemu-user-static/issues/18 -- You re

[Bug 1659267] Re: It's not possible to start a VM with a network cable unplugged

2020-01-22 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1659267 Title: It's not possible to start a VM with a network cable unplugged Status in QEMU:

[Bug 1661176] Re: [2.8.0] Under VNC CTRL-ALT-2 doesn't get to the monitor

2020-01-22 Thread Thomas Huth
Can you still reproduce your issue with the latest version of QEMU (currently v4.2.0)? Please also always add the way how you launched QEMU (ie. the command line parameters) ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qem

[Bug 1812861] Re: QEMU in user-mode emulation mode crashes when the user program jumps to an invalid address

2020-01-22 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1812861 Title: QEMU in user-mode emulation mode crashes when the user program jumps

[Bug 1660010] Re: AArch64 system emulation cannot execute virt uefi in 2.7 or 2.8

2020-01-22 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1660010 Title: AArch64 system emulation cannot execute virt uefi in 2.7 or 2.8 Status in QEMU:

[Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2020-01-22 Thread Thomas Huth
I assume David's fixes have been released with QEMU v4.2, so I'm closing this ticket now. ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

Re: [PATCH] stm32f4xx_syscfg: remove redundant code to fix coverity warning

2020-01-22 Thread Thomas Huth
On 23/01/2020 03.38, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Fixes the coverity warning: > CID 91708242: (EVALUATION_ORDER) > 50. write_write_typo: In "config = config = irq / 16", "config" is > written twice with the same value. > 50uint8_t config = config = irq /

[PATCH v3 7/8] hw/char/exynos4210_uart: Add receive DMA support

2020-01-22 Thread Guenter Roeck
To support receive DMA, we need to inform the DMA controller if receive data is available. Otherwise the DMA controller keeps requesting data, causing receive errors. Implement this using an interrupt line. The instantiating code then needs to connect the interrupt with the matching DMA controller

[PATCH v3 6/8] hw/char/exynos4210_uart: Implement Rx FIFO level triggers and timeouts

2020-01-22 Thread Guenter Roeck
The driver already implements a receive FIFO, but it does not handle receive FIFO trigger levels and timeout. Implement the missing functionality. Signed-off-by: Guenter Roeck --- v3: Dropped VMSTATE_TIMER_PTR Don't call exynos4210_uart_rx_timeout_set() and exynos4210_uart_update_irq() af

[PATCH v3 3/8] hw/arm/exynos4210: Fix DMA initialization

2020-01-22 Thread Guenter Roeck
First parameter to exynos4210_get_irq() is not the SPI port number, but the interrupt group number. Interrupt groups are 20 for mdma and 21 for pdma. Interrupts are not inverted. Controllers support 32 events (pdma) or 31 events (mdma). Events must all be routed to a single interrupt line. Set othe

[PATCH v3 8/8] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330

2020-01-22 Thread Guenter Roeck
The Exynos4210 serial driver uses an interrupt line to signal if receive data is available. Connect that interrupt with the DMA controller's 'peripheral busy' gpio pin to stop the DMA if there is no more receive data available. Without this patch, receive DMA runs wild and fills the entire receive

[PATCH v3 1/8] dma/pl330: Convert to support tracing

2020-01-22 Thread Guenter Roeck
Replace debug logging code with tracing. Reviewed-by: Peter Maydell Signed-off-by: Guenter Roeck --- v3: Added Reviewed-by: tag v2: Make call to pl330_hexdump() conditional hw/dma/pl330.c | 88 - hw/dma/trace-events | 24 + 2 files

[PATCH v3 5/8] hw/char/exynos4210_uart: Implement post_load function

2020-01-22 Thread Guenter Roeck
After restoring a VM, serial parameters need to be updated to reflect restored register values. Implement a post_load function to handle this situation. Reviewed-by: Peter Maydell Signed-off-by: Guenter Roeck --- v3: Added Reviewed-by: tag. v2: Additional patch to implement post-load functional

[PATCH v3 0/8] Fix Exynos4210 DMA support

2020-01-22 Thread Guenter Roeck
Commit 59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210") introduced DMA support for Exynos4210. Unfortunately, it never really worked. DMA interrupt line and polarity was wrong, and the serial port needs extra code to support DMA. This patch series fixes the problem. The series

[PATCH v3 4/8] hw/char/exynos4210_uart: Convert to support tracing

2020-01-22 Thread Guenter Roeck
Replace debug code with tracing to aid debugging. Reviewed-by: Peter Maydell Signed-off-by: Guenter Roeck --- v3: No change v2: Added Reviewed-by: tag hw/char/exynos4210_uart.c | 96 --- hw/char/trace-events | 17 +++ 2 files changed, 47 insertions

[PATCH v3 2/8] hw/core/or-irq: Increase limit of or-lines to 48

2020-01-22 Thread Guenter Roeck
Exynos DMA requires up to 33 interrupt lines (32 event interrupts plus abort interrupt), which all need to be wired together. Increase the maximum number of or-irq lines to 48 to support this configuration. Signed-off-by: Guenter Roeck --- v3: Added patch include/hw/or-irq.h | 2 +- 1 file chan

Re: [PATCH rc1 00/24] target/avr merger

2020-01-22 Thread Thomas Huth
On 23/01/2020 01.02, Richard Henderson wrote: > This is a merger of Michael's v41 of the base avr architecture, > and v4 of Phil's arduino target boards. Call this release, or > merge, candidate 1. > > Has all commentary been addressed? How much more, if anything, > does anyone require before al

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-22 Thread David Gibson
On Wed, Jan 22, 2020 at 11:06:18AM +0100, Greg Kurz wrote: > On Wed, 22 Jan 2020 17:50:28 +1100 > David Gibson wrote: > > > On Tue, Jan 21, 2020 at 10:32:55AM +0100, Greg Kurz wrote: > > > On Tue, 21 Jan 2020 14:43:32 +1100 > > > David Gibson wrote: > > > > > > > On Mon, Jan 20, 2020 at 09:04:3

Re: [PATCH qemu v5] spapr: Kill SLOF

2020-01-22 Thread David Gibson
On Wed, Jan 22, 2020 at 06:14:37PM +1100, Alexey Kardashevskiy wrote: > > > On 22/01/2020 17:32, David Gibson wrote: > > On Tue, Jan 21, 2020 at 06:25:36PM +1100, Alexey Kardashevskiy wrote: > >> > >> > >> On 21/01/2020 16:11, David Gibson wrote: > >>> On Fri, Jan 10, 2020 at 01:09:25PM +1100, Al

Re: [PATCH] spapr: Don't allow multiple active vCPUs at CAS

2020-01-22 Thread David Gibson
On Wed, Jan 22, 2020 at 02:11:12PM +0100, Greg Kurz wrote: > According to the description of "ibm,client-architecture-support" that > can found in LoPAPR "B.6.2.3 Root Node Methods": > > If multiple partition processors or threads are active at the time of > the ibm,client-architecture-support met

Re: [PATCH rc1 18/24] hw/avr: Introduce ATMEL_ATMEGA_MCU config

2020-01-22 Thread Thomas Huth
On 23/01/2020 01.03, Richard Henderson wrote: > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > Message-Id: <20200120220107.17825-13-f4...@amsat.org> > Signed-off-by: Richard Henderson > --- > hw/avr/Kconfig | 5 + > 1 file changed, 5 insertions(+) > create mode 1

Re: [PATCH rc1 16/24] target/avr: Add machine none test

2020-01-22 Thread Thomas Huth
On 23/01/2020 01.02, Richard Henderson wrote: > From: Michael Rolnik > > Signed-off-by: Michael Rolnik > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Aleksandar Markovic > Message-Id: <20200118191416.19934-18-mrol...@gmail.com> > Signed-off-by: Richard Henderson > --- > tests/qtest/machi

Re: [PATCH rc1 14/24] target/avr: Add section about AVR into QEMU documentation

2020-01-22 Thread Thomas Huth
On 23/01/2020 01.02, Richard Henderson wrote: > From: Michael Rolnik > > Signed-off-by: Michael Rolnik > Message-Id: <20200118191416.19934-16-mrol...@gmail.com> > Signed-off-by: Richard Henderson > --- > qemu-doc.texi | 51 +++ > 1 file changed,

Re: [PATCH rc1 12/24] hw/timer: Add limited support for Atmel 16 bit timer peripheral

2020-01-22 Thread Thomas Huth
On 23/01/2020 01.02, Richard Henderson wrote: > From: Michael Rolnik > > These were designed to facilitate testing but should provide enough > function to be useful in other contexts. Only a subset of the functions > of each peripheral is implemented, mainly due to the lack of a standard > way t

Re: [PATCH] tests/boot-serial-test: Allow the HPPA machine to shudown

2020-01-22 Thread Thomas Huth
On 23/01/2020 01.36, Philippe Mathieu-Daudé wrote: > The boot-serial test uses SeaBIOS on HPPA, and expects to read the > "SeaBIOS wants SYSTEM HALT" string, see [*]: > > 122 void __VISIBLE __noreturn hlt(void) > 123 { > 124 if (pdc_debug) > 125 printf("HALT initiated from %p\n",

Re: [PATCH] riscv: Format Rd of FMV.W.X with NoN-boxing

2020-01-22 Thread Ian Jiang
Richard Henderson 于2020年1月23日周四 上午11:07写道: > > On 1/22/20 2:48 PM, Ian Jiang wrote: > > Richard Henderson 于2020年1月23日周四 上午1:11写道: > >> > >> On 1/21/20 11:53 PM, Ian Jiang wrote: > >>> -- > >>> Ian Jiang > >>> > >>> Richard Henderson 于2020年1月22日周三 下午4:53写道: > > On 1/21/20 9:24 PM, Ian J

Re: [PATCH] tests/boot-serial-test: Allow the HPPA machine to shudown

2020-01-22 Thread Richard Henderson
On 1/22/20 2:36 PM, Philippe Mathieu-Daudé wrote: > The boot-serial test uses SeaBIOS on HPPA, and expects to read the > "SeaBIOS wants SYSTEM HALT" string, see [*]: > > 122 void __VISIBLE __noreturn hlt(void) > 123 { > 124 if (pdc_debug) > 125 printf("HALT initiated from %p\n", _

Re: [PATCH] riscv: Format Rd of FMV.W.X with NoN-boxing

2020-01-22 Thread Richard Henderson
On 1/22/20 2:48 PM, Ian Jiang wrote: > Richard Henderson 于2020年1月23日周四 上午1:11写道: >> >> On 1/21/20 11:53 PM, Ian Jiang wrote: >>> -- >>> Ian Jiang >>> >>> Richard Henderson 于2020年1月22日周三 下午4:53写道: On 1/21/20 9:24 PM, Ian Jiang wrote: > For FMV.W.X that moves the lower 32 bits of an i

[PATCH] stm32f4xx_syscfg: remove redundant code to fix coverity warning

2020-01-22 Thread pannengyuan
From: Pan Nengyuan Fixes the coverity warning: CID 91708242: (EVALUATION_ORDER) 50. write_write_typo: In "config = config = irq / 16", "config" is written twice with the same value. 50uint8_t config = config = irq / 16; Reported-by: Euler Robot Signed-off-by: Pan Nengyuan ---

[PATCH] qemu_set_log_filename: filename argument may be NULL

2020-01-22 Thread salvador
From: Salvador Fandino NULL is a valid log filename used to indicate we want to use stderr but qemu_set_log_filename (which is called by bsd-user/main.c) was not handling it correctly. Signed-off-by: Salvador Fandino --- util/log.c | 27 +++ 1 file changed, 15 insertion

[PATCH] qemu_set_log_filename: filename argument may be NULL

2020-01-22 Thread salvador
From: Salvador Fandino NULL is a valid log filename used to indicate we want to use stderr but qemu_set_log_filename (which is called by bsd-user/main.c) was not handling it correctly. Signed-off-by: Salvador Fandino --- util/log.c | 27 +++ 1 file changed, 15 insertion

Re: [PATCH] riscv: Format Rd of FMV.W.X with NoN-boxing

2020-01-22 Thread Ian Jiang
Richard Henderson 于2020年1月23日周四 上午1:11写道: > > On 1/21/20 11:53 PM, Ian Jiang wrote: > > -- > > Ian Jiang > > > > Richard Henderson 于2020年1月22日周三 下午4:53写道: > >> > >> On 1/21/20 9:24 PM, Ian Jiang wrote: > >>> For FMV.W.X that moves the lower 32 bits of an integer register to a > >>> floating-point

[PATCH] tests/boot-serial-test: Allow the HPPA machine to shudown

2020-01-22 Thread Philippe Mathieu-Daudé
The boot-serial test uses SeaBIOS on HPPA, and expects to read the "SeaBIOS wants SYSTEM HALT" string, see [*]: 122 void __VISIBLE __noreturn hlt(void) 123 { 124 if (pdc_debug) 125 printf("HALT initiated from %p\n", __builtin_return_address(0)); 126 printf("SeaBIOS wants SYST

[PATCH rc1 22/24] tests/boot-serial-test: Test some Arduino boards (AVR based)

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Print out 'T' through serial port The Arduino Duemilanove is based on a AVR5 CPU, while the Arduino MEGA2560 on a AVR6 CPU. Signed-off-by: Michael Rolnik Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Acked-by: Thomas Huth Signed-off-by: Philippe

[PATCH rc1 20/24] hw/avr: Add some Arduino boards

2020-01-22 Thread Richard Henderson
From: Philippe Mathieu-Daudé Arduino boards are build with AVR chipsets. Add some of the popular boards: - Arduino Duemilanove - Arduino Uno - Arduino Mega For more information: https://www.arduino.cc/en/Main/Products https://store.arduino.cc/arduino-genuino/most-popular Reviewed-by: Igor

[PATCH rc1 24/24] .travis.yml: Run the AVR acceptance tests

2020-01-22 Thread Richard Henderson
From: Philippe Mathieu-Daudé We have one test so far, and it is very fast: $ avocado --show=app run -t arch:avr tests/acceptance/ (1/1) tests/acceptance/machine_avr6.py:AVR6Machine.test_freertos: PASS (2.13 s) RESULTS: PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCE

[PATCH rc1 18/24] hw/avr: Introduce ATMEL_ATMEGA_MCU config

2020-01-22 Thread Richard Henderson
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200120220107.17825-13-f4...@amsat.org> Signed-off-by: Richard Henderson --- hw/avr/Kconfig | 5 + 1 file changed, 5 insertions(+) create mode 100644 hw/avr/Kconfig diff --git a/hw/avr/Kconfig b/hw/avr/Kconf

[PATCH rc1 23/24] tests/acceptance: Test the Arduino MEGA2560 board

2020-01-22 Thread Richard Henderson
From: Michael Rolnik The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. it also demostrates that timer and IRQ are working As the path name demonstrates, the FreeRTOS tests target a b

[PATCH rc1 17/24] target/avr: Update MAINTAINERS file

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Include AVR maintaners in MAINTAINERS file Signed-off-by: Michael Rolnik Message-Id: <20200118191416.19934-22-mrol...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé [rth: Squash ordering fixes from f4bug] Signed-off-by: Richard Henderson --- MAINTAINERS | 26 ++

[PATCH rc1 15/24] target/avr: Register AVR support with the rest of QEMU

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Add AVR related definitions into QEMU Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <20200118191416.19934-17-mrol...@gmail.com> Signed-off-by: Richard Henderson --- qapi/machine.json | 3 ++- inclu

[PATCH rc1 21/24] target/avr: Update build system

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Make AVR support buildable Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <20200118191416.19934-19-mrol...@gmail.com> Signed-off-by: Richard Henderson --- configure | 7 +++ default

[PATCH rc1 13/24] hw/misc: Add Atmel power device

2020-01-22 Thread Richard Henderson
From: Michael Rolnik This is a simple device of just one register, whenver this register is written it calls qemu_set_irq function for each of 8 bits/IRQs.. It is used to implement AVR Power Reduction Signed-off-by: Michael Rolnik Message-Id: <20200118191416.19934-14-mrol...@gmail.com> Signed-o

[PATCH rc1 19/24] hw/avr: Add some ATmega microcontrollers

2020-01-22 Thread Richard Henderson
From: Philippe Mathieu-Daudé Add some microcontrollers from the megaAVR family (ATmega series): - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and ATmega2560 For product comparison: https://www.microchip.com/wwwproducts/ProductCompare/ATmega168P/ATmega328P https://www.micr

[PATCH rc1 14/24] target/avr: Add section about AVR into QEMU documentation

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Signed-off-by: Michael Rolnik Message-Id: <20200118191416.19934-16-mrol...@gmail.com> Signed-off-by: Richard Henderson --- qemu-doc.texi | 51 +++ 1 file changed, 51 insertions(+) diff --git a/qemu-doc.texi b/qemu-doc.texi i

[PATCH rc1 11/24] hw/char: Add limited support for Atmel USART peripheral

2020-01-22 Thread Richard Henderson
From: Michael Rolnik These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). Signed-

[PATCH rc1 16/24] target/avr: Add machine none test

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <20200118191416.19934-18-mrol...@gmail.com> Signed-off-by: Richard Henderson --- tests/qtest/machine-none-test.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH rc1 10/24] target/avr: Add instruction disassembly function

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Provide function disassembles executed instruction when `-d in_asm` is provided Example: `./avr-softmmu/qemu-system-avr -bios free-rtos/Demo/AVR_ATMega2560_GCC/demo.elf -d in_asm` will produce something like the following ``` ... IN: 0x014a: CALL 0x38

[PATCH rc1 09/24] target/avr: Add instruction translation - CPU main translation function

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Co-developed-by: Richard Henderson Co-developed-by: Michael Rolnik Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé Message-Id: <20200118191416.19934-10-mrol...@gmail.com> Signed-off-by: Richard Henderson --- target/avr/translate.c | 234

[PATCH rc1 12/24] hw/timer: Add limited support for Atmel 16 bit timer peripheral

2020-01-22 Thread Richard Henderson
From: Michael Rolnik These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). Signed-

[PATCH rc1 07/24] target/avr: Add instruction translation - Bit and Bit-test Instructions

2020-01-22 Thread Richard Henderson
From: Michael Rolnik This includes: - LSR, ROR - ASR - SWAP - SBI, CBI - BST, BLD - BSET, BCLR Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé Message-Id: <20200118191416.19934-8-mrol...@gmail.com> Signed-off-by: Richard Henderson --- target/avr/transl

[PATCH rc1 04/24] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2020-01-22 Thread Richard Henderson
From: Michael Rolnik This includes: - ADD, ADC, ADIW - SBIW, SUB, SUBI, SBC, SBCI - AND, ANDI - OR, ORI, EOR - COM, NEG - INC, DEC - MUL, MULS, MULSU - FMUL, FMULS, FMULSU - DES Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé Message-Id: <20200118191416.19934-5-mrol...@gmail.co

[PATCH rc1 01/24] target/avr: Add outward facing interfaces and core CPU logic

2020-01-22 Thread Richard Henderson
From: Michael Rolnik This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik Acked-by: Ig

[PATCH rc1 06/24] target/avr: Add instruction translation - Data Transfer Instructions

2020-01-22 Thread Richard Henderson
From: Michael Rolnik This includes: - MOV, MOVW - LDI, LDS LDX LDY LDZ - LDDY, LDDZ - STS, STX STY STZ - STDY, STDZ - LPM, LPMX - ELPM, ELPMX - SPM, SPMX - IN, OUT - PUSH, POP - XCH - LAS, LAC LAT Signed-off-by: Michael Rolnik Tested-by: Philippe

[PATCH rc1 08/24] target/avr: Add instruction translation - MCU Control Instructions

2020-01-22 Thread Richard Henderson
From: Michael Rolnik This includes: - BREAK - NOP - SLEEP - WDR Signed-off-by: Michael Rolnik Message-Id: <20200118191416.19934-9-mrol...@gmail.com> Signed-off-by: Richard Henderson --- target/avr/translate.c | 68 ++ target/avr/insn.dec

[PATCH rc1 05/24] target/avr: Add instruction translation - Branch Instructions

2020-01-22 Thread Richard Henderson
From: Michael Rolnik This includes: - RJMP, IJMP, EIJMP, JMP - RCALL, ICALL, EICALL, CALL - RET, RETI - CPSE, CP, CPC, CPI - SBRC, SBRS, SBIC, SBIS - BRBC, BRBS Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé Message-Id: <20200118191416.19934-6-mrol...@g

[PATCH rc1 00/24] target/avr merger

2020-01-22 Thread Richard Henderson
This is a merger of Michael's v41 of the base avr architecture, and v4 of Phil's arduino target boards. Call this release, or merge, candidate 1. Has all commentary been addressed? How much more, if anything, does anyone require before allowing normal development in tree? r~ Michael Rolnik (

[PATCH rc1 03/24] target/avr: Add instruction translation - Registers definition

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Signed-off-by: Michael Rolnik Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200118191416.19934-4-mrol...@gmail.com> Signed-off-by: Richard Henderson --- target/avr/translate.c | 171 + 1 file

[PATCH rc1 02/24] target/avr: Add instruction helpers

2020-01-22 Thread Richard Henderson
From: Michael Rolnik Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate wak

  1   2   3   >