[PATCH] plugins/core: add missing break in cb_to_tcg_flags

Reported-by: Robert Henry Signed-off-by: Emilio G. Cota --- plugins/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/core.c b/plugins/core.c index 9e1b9e7a91..ed863011ba 100644 --- a/plugins/core.c +++ b/plugins/core.c @@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags(

Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine type

I found the patch that breaks Screamer sound support for qemu-system-ppc. It is this: commit 2ceb8240fa4e4e30fb853565eb2bed3032d74f62 Author: Kővágó, Zoltán Date: Thu Sep 19 23:24:11 2019 +0200 coreaudio: port to the new audio backend api Signed-off-by: Kővágó, Zoltán Messag

Re: [Qemu-devel] What should a virtual board emulate?

Hi Paolo, On 3/20/19 11:35 AM, Paolo Bonzini wrote: On 20/03/19 11:03, Philippe Mathieu-Daudé wrote: -display/-vga options suffers same clarity problems than -net. Is it a card device or a cable linking to a network? Here is it a card device or a cable connecting a monitor display? -display

Re: [RFC] Implementing vhost-user-blk device backend

Hi Stefan, Thank you for reviewing my work! All the improvements have been applied except for a small issue regarding object_add. > (qemu) object_add vhost-user-server,id=ID,chardev=CHARDEV,writable=on|off Currently I implement object_add feature in the following syntax which use unix_socket di

Re: [PATCH v2] hppa: allow max ram size upto 4Gb

On 1/3/20 10:54 AM, Igor Mammedov wrote: On Thu, 2 Jan 2020 21:22:12 +0100 Helge Deller wrote: On 02.01.20 18:46, Igor Mammedov wrote: Previous patch drops silent ram_size fixup and makes QEMU error out with: "RAM size more than 3840m is not supported" when user specified -m X more than s

Re: [PATCH v3 00/29] cputlb: Remove support for MMU_MODE*_SUFFIX

On 12/29/19 12:10 AM, Richard Henderson wrote: This is part of a project to raise the limit on NB_MMU_MODES. One of those is in cpu_ldst.h, in support of MMU_MODE*_SUFFIX. While this could be extended, it's not the best interface for such things. Better is a single interface that allows a varia

Re: [PATCH v3 09/29] plugins: Include trace/mem.h in api.c

On 1/3/20 10:59 PM, Richard Henderson wrote: On 1/3/20 5:22 PM, Philippe Mathieu-Daudé wrote: Hi Richard, On 12/29/19 12:11 AM, Richard Henderson wrote: Code movement in an upcoming patch will show that this file was implicitly depending on trace/mem.h being included beforehand. Ah, it uses

Re: [PATCH 3/3] capstone: Add skipdata hook for s390x

On 1/3/20 10:25 PM, Richard Henderson wrote: Capstone assumes any s390x unknown instruction is 2 bytes. Instead, use the ilen field in the first two bits of the instruction to stay in sync with the insn stream. Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson Reviewed-by: Philippe M

Re: [PATCH 2/3] capstone: Enable disassembly for s390x

On 1/3/20 10:24 PM, Richard Henderson wrote: Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Signed-off-by: Richard Henderson I'm fine with this patch because I don't use the s390 disas often. For the S390 experts, my previous ana

Re: [PATCH 1/3] capstone: Update to next

On 1/3/20 10:24 PM, Richard Henderson wrote: Update to aaffb38c44fa. Choose this over the "current" 4.0.1 tag because next now includes the s390x z13 vector opcodes, and also the insn tables are now read-only. As Thomas suggested, Fixes: https://bugs.launchpad.net/qemu/+bug/1826175 With GCC

[PATCH v2 2/5] hda-codec: fix recording rate control

Apply previous commit to hda_audio_input_cb for the same reasons. Signed-off-by: Volker Rümelin --- hw/audio/hda-codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c index 768ba31e79..e711a99a41 100644 --- a/hw/audio/hda-code

[PATCH v2 3/5] paaudio: drop recording stream in qpa_fini_in

Every call to pa_stream_peek which returns a data length > 0 should have a corresponding pa_stream_drop. A call to qpa_read does not necessarily call pa_stream_drop immediately after a call to pa_stream_peek. Test in qpa_fini_in if a last pa_stream_drop is needed. This prevents following messages

[PATCH v2 5/5] paaudio: wait until the recording stream is ready

Don't call pa_stream_peek before the recording stream is ready. Information to reproduce the problem. Start and stop Audacity in the guest several times because the problem is racy. libvirt log file: -audiodev pa,id=audio0,server=localhost,out.latency=3, out.mixing-engine=off,in.mixing-engi

[PATCH v2 1/5] hda-codec: fix playback rate control

Since commit 1930616b98 "audio: make mixeng optional" the function hda_audio_output_cb can no longer assume the function parameter avail contains the free buffer size. With the playback mixing-engine turned off this leads to a broken playback rate control and playback buffer drops in regular interv

[PATCH v2 4/5] paaudio: try to drain the recording stream

There is no guarantee a single call to pa_stream_peek every timer_period microseconds can read a recording stream faster than the data gets produced at the source. Let qpa_read try to drain the recording stream. To reproduce the problem: Start qemu with -audiodev pa,id=audio0,in.mixing-engine=off

[PATCH v2 0/5] audio fixes

Here are five patches to fix PulseAudio playback/recording with the mixing engine off. v2: - Patch 3/5: Corrected error log message. Volker Rümelin (5): hda-codec: fix playback rate control hda-codec: fix recording rate control paaudio: drop recording stream in qpa_fini_in paaudio: try to

Re: [PATCH 2/5] hda-codec: fix recording rate control

> This mail is multipart text+html and "git am" can't process it (the > others are text only). Can you please resend the patches, preferably > with "git send-email" to avoid them being sent as multipart? They all > look good to me (this series and the 6th patch sent as separate mail). > > Sorry,