On Tuesday, December 17, 2019, Philippe Mathieu-Daudé
wrote:
> GCC9 is confused by this comment when building with
> CFLAG -Wimplicit-fallthrough=2:
>
> hw/display/tcx.c: In function ‘tcx_dac_writel’:
> hw/display/tcx.c:453:26: error: this statement may fall through
> [-Werror=implicit-fallth
Peter Maydell writes:
> On Tue, 17 Dec 2019 at 06:33, Markus Armbruster wrote:
>>
>> The following changes since commit cb88904a54903ef6ba21a68a61d9cd51e2166304:
>>
>> Merge remote-tracking branch
>> 'remotes/amarkovic/tags/mips-queue-dec-16-2019' into staging (2019-12-16
>> 14:07:56 +)
Eric Blake writes:
> On 12/17/19 12:26 AM, Markus Armbruster wrote:
>> From: Vladimir Sementsov-Ogievskiy
>>
>> All callers of nbd_iter_channel_error() pass the address of a
>> local_err variable, and only call this function if an error has
>> already occurred, using this function to propagate t
On 2019-12-17, Richard Henderson wrote:
This begins by dropping the -Ttext-segment stuff, which Fangrui Song
correctly points out does not work with lld. But it's also obsolete,
so instead of adding support for lld's --image-base, remove it all.
Then, remove some other legacy random addresses t
On 18/12/2019 04.19, Richard Henderson wrote:
> PIE is supported on many other hosts besides x86.
>
> The default for non-x86 is now the same as x86: pie is used
> if supported, and may be forced via --enable/--disable-pie.
The original commit that introduce this code (40d6444e91c) said:
"Non-x
On 18/12/2019 04.19, Richard Henderson wrote:
> The commentary talks about "in concert with the addresses
> assigned in the relevant linker script", except there is no
> linker script for softmmu, nor has there been for some time.
>
> (Do not confuse the user-only linker script editing that was
>
On 18/12/2019 04.19, Richard Henderson wrote:
> This adjustment was random and unnecessary. The user mode
> startup code in probe_guest_base() will choose a value for
> guest_base that allows the host qemu binary to not conflict
> with the guest binary.
>
> With modern distributions, this isn't e
On 18/12/2019 02.30, Paolo Bonzini wrote:
> We are using tap-driver.pl, do not require anymore gtester to be installed
> to run the testsuite in docker-based tests.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/docker/common.rc | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>
"Chubb, Peter (Data61, Kensington NSW)"
writes:
>> "Philippe" == Philippe Mathieu-Daudé writes:
>
> Philippe> Fix some trivial warnings when building with -O3.
>
> For compatibility with lint and other older checkers, it'd be good to keep
> this as /* FALLTHROUGH */ (which gcc should accept
On Wed, Dec 18, 2019 at 04:19:57PM +1100, Alexey Kardashevskiy wrote:
>
>
> On 13/12/2019 19:36, Michael S. Tsirkin wrote:
> > On Fri, Dec 13, 2019 at 07:29:40PM +1100, Alexey Kardashevskiy wrote:
> >>
> >>
> >> On 13/12/2019 18:24, Michael S. Tsirkin wrote:
> >>> On Fri, Dec 13, 2019 at 05:05:05
On 12/18/2019 9:33 AM, Tao Xu wrote:
On 12/17/2019 6:25 PM, Markus Armbruster wrote:
Tao Xu writes:
On 12/5/19 11:29 PM, Markus Armbruster wrote:
Tao Xu writes:
Parse input string both as a double and as a uint64_t, then use the
method which consumes more characters. Update the related te
On 13/12/2019 19:36, Michael S. Tsirkin wrote:
> On Fri, Dec 13, 2019 at 07:29:40PM +1100, Alexey Kardashevskiy wrote:
>>
>>
>> On 13/12/2019 18:24, Michael S. Tsirkin wrote:
>>> On Fri, Dec 13, 2019 at 05:05:05PM +1100, Alexey Kardashevskiy wrote:
Hi!
I am having an issue with ca
Be sure that we are not doing neither read/write after shutdown of the
QEMUFile.
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 26fb25ddc1..1e5543a279 100644
--- a/migra
Test that this sequerce works:
- launch source
- launch target
- start migration
- cancel migration
- relaunch target
- do migration again
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 108 -
1 file changed, 107 insertions(+), 1 deletion(-)
d
Hi
This series:
- create a test that does:
launch multifd on target
migrate to target
cancel on source
create another target
migrate again
- And fixes the cases that made it fail:
* Make sure that we don't try ever IO after shutdown/error
Please, review.
Juan Quintela (4):
qemu-file
Signed-off-by: Juan Quintela
---
migration/ram.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index db90237977..4b44578e57 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4132,7 +4132,7 @@ static int ram_save_
If we are exiting due to an error/finish/ Just don't try to even
touch the channel with one IO operation.
Signed-off-by: Juan Quintela
---
migration/ram.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 4b44578e57..909ef6d237 1
Update to mainline commit: d1eef1c61974 ("Linux 5.5-rc2")
Signed-off-by: Bharata B Rao
---
include/standard-headers/asm-x86/bootparam.h | 7 +-
.../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h | 15 +++-
include/standard-headers/drm/drm_fourcc.h | 28 ++-
.../linux/input-event-codes.h
A pseries guest can be run as a secure guest on Ultravisor-enabled
POWER platforms. When such a secure guest is reset, we need to
release/reset a few resources both on ultravisor and hypervisor side.
This is achieved by invoking this new ioctl KVM_PPC_SVM_OFF from the
machine reset path.
As part o
This patchset adds KVM_PPC_SVM_OFF ioctl which is required to support
reset of secure guest. This includes linux-headers update so that we get
the newly introduced ioctl.
v2: https://lists.gnu.org/archive/html/qemu-ppc/2019-12/msg00162.html
Changes in v3:
-
- Use of error_fatal as Dav
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused when building with CFLAG -O3:
>
> In function ‘help_oneline’,
> inlined from ‘help_all’ at qemu-io-cmds.c:2414:9,
> inlined from ‘help_f’ at qemu-io-cmds.c:2424:9:
> qemu-io-cmds.c:2389:9: error: ‘%s’ directive a
On Tue, Dec 17, 2019 at 8:03 AM Peter Maydell wrote:
>
> On Sat, 14 Dec 2019 at 02:44, Alistair Francis wrote:
> >
> > Signed-off-by: Alistair Francis
> > ---
> > MAINTAINERS| 6 +
> > hw/arm/Kconfig | 3 +++
> > hw/arm/Makefile.objs | 1 +
> > hw/arm/netduinoplus2.
On Sat, Dec 14, 2019 at 5:49 AM Philippe Mathieu-Daudé
wrote:
>
> Hi Alistair,
>
> On 12/14/19 3:44 AM, Alistair Francis wrote:
> > Signed-off-by: Alistair Francis
> > Reviewed-by: Peter Maydell
> > ---
> > hw/arm/Kconfig | 1 +
> > hw/misc/Kconfig | 3 +
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused when building with CFLAG -O3:
>
> hw/scsi/megasas.c: In function ‘megasas_scsi_realize’:
> hw/scsi/megasas.c:2387:26: error: duplicated ‘if’ condition
> [-Werror=duplicated-cond]
>2387 | } else if (s->fw_sge >= 128
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with
> CFLAG -Wimplicit-fallthrough=2:
>
> hw/display/tcx.c: In function ‘tcx_dac_writel’:
> hw/display/tcx.c:453:26: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
>
Hi Eric,
I have to admit that this is the first time I've looked into
the kvm-unit-tests code, so only some minor comments inline :)
On 2019/12/16 22:02, Eric Auger wrote:
Detect the presence of an ITS as part of the GICv3 init
routine, initialize its base address and read few registers
the IID
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with CFLAG
> -Wimplicit-fallthrough=2:
>
> hw/net/imx_fec.c: In function ‘imx_eth_write’:
> hw/net/imx_fec.c:906:12: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
>
On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with
> CFLAG -Wimplicit-fallthrough=2:
>
> audio/audio.c: In function ‘audio_pcm_init_info’:
> audio/audio.c:306:14: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
>
On Tue, Dec 17, 2019 at 10:46:16PM -0300, Fabiano Rosas wrote:
> They were added in "16415335be Use correct input constant" with a
> single use in kvm_arch_pre_run but that function's implementation was
> removed by "1e8f51e856 ppc: remove idle_timer logic".
>
> Signed-off-by: Fabiano Rosas
Appl
On Tue, Dec 17, 2019 at 11:25:12AM -0300, Fabiano Rosas wrote:
> The exception vector offset calculation was moved into a function but
> the case when AIL=0 was not checked.
>
> The reason we got away with this is that the sole caller of
> ppc_excp_vector_offset checks the AIL before calling the f
On Tue, Dec 17, 2019 at 07:32:15AM +0100, Markus Armbruster wrote:
> David Gibson writes:
>
> > From: Vladimir Sementsov-Ogievskiy
> >
> > Make kvmppc_hint_smt_possible hint append helper well formed:
> > rename errp to errp_in, as it is IN-parameter here (which is unusual
> > for errp), rename
The commentary talks about "in concert with the addresses
assigned in the relevant linker script", except there is no
linker script for softmmu, nor has there been for some time.
(Do not confuse the user-only linker script editing that was
removed in the previous patch, because user-only does not
Some distributions, e.g. Ubuntu 19.10, enable PIE by default.
If for some reason one wishes to build a non-pie binary, we
must provide additional options to override.
At the same time, reorg the code to an elif chain.
Signed-off-by: Richard Henderson
---
configure | 25 -
There is nothing about these options that is related to PIE.
Nor is there anything that specifically ties them to each other.
Use them unconditionally.
Signed-off-by: Richard Henderson
---
configure | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/configure b/co
This adjustment was random and unnecessary. The user mode
startup code in probe_guest_base() will choose a value for
guest_base that allows the host qemu binary to not conflict
with the guest binary.
With modern distributions, this isn't even used, as the default
is PIE, which does the same job i
This begins by dropping the -Ttext-segment stuff, which Fangrui Song
correctly points out does not work with lld. But it's also obsolete,
so instead of adding support for lld's --image-base, remove it all.
Then, remove some other legacy random addresses that were supposed
to apply to softmmu, but
Recent toolchains support static and pie at the same time.
As with normal dynamic builds, allow --static to default to PIE
if supported by the toolchain. Allow --enable/--disable-pie to
override the default.
Signed-off-by: Richard Henderson
---
configure | 17 +++--
1 file changed,
PIE is supported on many other hosts besides x86.
The default for non-x86 is now the same as x86: pie is used
if supported, and may be forced via --enable/--disable-pie.
Signed-off-by: Richard Henderson
---
configure | 10 --
1 file changed, 10 deletions(-)
diff --git a/configure b/con
The CFLAGS_NOPIE and LDFLAGS_NOPIE variables are used
in pc-bios/optionrom/Makefile, which has nothing to do
with the PIE setting of the main qemu executables.
This overrides any operating system default to build
all executables as PIE, which is important for ROMs.
Signed-off-by: Richard Henderso
Hello Fred,
Based on Dann's feedback on testing, I'm failing to see where your patch
fixes the "root" cause (despite being able to mitigate the issue by
changing the aio notification mechanism).
I think the root cause is best described in this 2 emails from the
thread:
https://lore.kernel.org/qe
On 2019/12/12 下午1:47, Yan Zhao wrote:
On Thu, Dec 12, 2019 at 11:48:25AM +0800, Jason Wang wrote:
On 2019/12/6 下午8:49, Yan Zhao wrote:
On Fri, Dec 06, 2019 at 05:40:02PM +0800, Jason Wang wrote:
On 2019/12/6 下午4:22, Yan Zhao wrote:
On Thu, Dec 05, 2019 at 09:05:54PM +0800, Jason Wang wrote:
On 12/17/2019 11:01 PM, Markus Armbruster wrote:
Christophe de Dinechin writes:
On 17 Dec 2019, at 15:08, Markus Armbruster wrote:
Christophe de Dinechin writes:
On 5 Dec 2019, at 16:29, Markus Armbruster wrote:
Tao Xu writes:
Parse input string both as a double and as a uint64_t, th
Signed-off-by: Guoyi Tu
---
block/qcow2.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 7c18721..ce3db29 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1705,14 +1705,14 @@ static int coroutine_fn qcow2_do_open(BlockDriverSt
Signed-off-by: Juan Quintela
---
hw/core/qdev-properties.c | 2 +-
migration/ram.c | 288 ++
qapi/migration.json | 2 +-
tests/migration-test.c| 6 +
4 files changed, 296 insertions(+), 2 deletions(-)
diff --git a/hw/core/qdev-propert
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 1c9f2c4e6a..fc221f172a 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -460,
Signed-off-by: Juan Quintela
---
configure | 30 ++
1 file changed, 30 insertions(+)
diff --git a/configure b/configure
index 84b413dbfc..a8f3027c67 100755
--- a/configure
+++ b/configure
@@ -447,6 +447,7 @@ lzo=""
snappy=""
bzip2=""
lzfse=""
+zstd=""
guest_agent=
Signed-off-by: Juan Quintela
---
Rename it to NONE
Fix typos (dave)
We don't need to chek values returned by visit_type_MultifdCompress (markus)
Fix yet more typos (wei)
---
hw/core/qdev-properties.c| 13 +
include/hw/qdev-properties.h | 3 +++
migration/migration.c| 13
We can scale much better with 16, so we can scale to higher numbers.
Signed-off-by: Juan Quintela
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 354ad072fa..e7f707e033 100644
--- a/migration/migrat
It will be used later.
Signed-off-by: Juan Quintela
---
Move setup of ->ops helper to proper place (wei)
Rename s/none/nocomp/ (dave)
Introduce MULTIFD_FLAG_NOCOMP
---
migration/migration.c | 9 ++
migration/migration.h | 1 +
migration/ram.c | 194
We need to change the full chain to pass the Error parameter.
Signed-off-by: Juan Quintela
---
migration/migration.c | 10 +-
migration/migration.h | 2 +-
migration/ram.c | 2 +-
migration/ram.h | 2 +-
migration/rdma.c | 2 +-
5 files changed, 9 insertions(+), 9 de
We set multifd-channels.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Thomas Huth
Tested-by: Wei Yang
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/tests
It has two bools and two strings, it is very difficult to remember
which does what. And it makes very difficult to add new parameters as
we need to modify all the callers.
Signed-off-by: Juan Quintela
---
Move the free after last use.
---
tests/migration-test.c | 118 +
Signed-off-by: Juan Quintela
---
migration/migration.c | 2 +-
migration/ram.c | 2 +-
migration/ram.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index e7f707e033..5a56bd0c91 100644
--- a/migration/migration.c
+
[v2]
- rebase on top of previous arguments posted to the list
- introduces zlib compression
- introduces zstd compression
Please help if you know anything about zstd/zlib compression.
This puts compression on top of multifd. Advantages about current
compression:
- We copy all pages in a single p
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index e1304d70fc..14f2ce30fb 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -58
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 41 -
1 file changed, 16 insertions(+), 25 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 6e828fbc6c..e1304d70fc 100644
--- a/tests/migration-test.c
+++ b/tests/migr
Signed-off-by: Juan Quintela
---
hw/core/qdev-properties.c | 2 +-
migration/ram.c | 264 ++
qapi/migration.json | 2 +-
tests/migration-test.c| 6 +
4 files changed, 272 insertions(+), 2 deletions(-)
diff --git a/hw/core/qdev-propert
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 44 --
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 5a63158872..9d40f2d30c 100644
--- a/tests/migration-test.c
+++ b/tests/mig
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index e17d432043..6e828fbc6c 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -579
This explains better what they do and avoid confussino with
command_src/target.
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
i
We are repeating almost everything for each machine while creating the
command line for migration. And once for source and another for
destination. We start putting there opts_src and opts_dst.
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 44 ---
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index fbddcf2317..0c01ed3543 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -558,6
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 51 +-
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 0c01ed3543..5a63158872 100644
--- a/tests/migration-test.c
+++ b/tests/mig
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 76 +++---
1 file changed, 34 insertions(+), 42 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 9d40f2d30c..e17d432043 100644
--- a/tests/migration-test.c
+++ b/tests/mig
[v2]
- fix use-after-free (thanks peter)
[v1]
This series simplify test_migrate_start() in two ways:
- simplify the command line creation, so everything that is common between
architectures don't have to be repeated (DRY).
Note that this bit remove lines of code.
- test_migrate_start() has two
They were added in "16415335be Use correct input constant" with a
single use in kvm_arch_pre_run but that function's implementation was
removed by "1e8f51e856 ppc: remove idle_timer logic".
Signed-off-by: Fabiano Rosas
---
target/ppc/kvm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a
On 12/17/2019 7:44 PM, Christophe de Dinechin wrote:
On 9 Dec 2019, at 09:30, Tao Xu wrote:
Parse input string both as a double and as a uint64_t, then use the
method which consumes more characters. Update the related test cases.
Signed-off-by: Tao Xu
---
Changes in v2:
- Resend to us
On 12/17/2019 6:25 PM, Markus Armbruster wrote:
Tao Xu writes:
On 12/5/19 11:29 PM, Markus Armbruster wrote:
Tao Xu writes:
Parse input string both as a double and as a uint64_t, then use the
method which consumes more characters. Update the related test cases.
Signed-off-by: Tao Xu
---
We are using tap-driver.pl, do not require anymore gtester to be installed
to run the testsuite in docker-based tests.
Signed-off-by: Paolo Bonzini
---
tests/docker/common.rc | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
On Tue, Dec 17, 2019 at 07:47:05PM +0800, Kirti Wankhede wrote:
>
>
> On 12/17/2019 3:21 PM, Yan Zhao wrote:
> > On Tue, Dec 17, 2019 at 05:24:14PM +0800, Kirti Wankhede wrote:
> >>
> >>
> >> On 12/17/2019 10:45 AM, Yan Zhao wrote:
> >>> On Tue, Dec 17, 2019 at 04:21:39AM +0800, Kirti Wankhede wr
On 12/17/19 11:02 AM, Jeff Kubascik wrote:
> diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c
> index 5feb312941..e63f8bda29 100644
> --- a/target/arm/tlb_helper.c
> +++ b/target/arm/tlb_helper.c
> @@ -44,7 +44,7 @@ static inline uint32_t merge_syn_data_abort(uint32_t
> template_syn,
This first READDIR test simply checks the amount of directory
entries returned, according to the created amount on 9p synth
driver side.
Signed-off-by: Christian Schoenebeck
---
tests/virtio-9p-test.c | 125 +
1 file changed, 125 insertions(+)
diff --git
As previously mentioned, I was investigating performance issues with 9pfs.
Raw file read/write of 9pfs is actually quite good, provided that client
picked a reasonable high msize (maximum message size). I would recommend
to log a warning on 9p server side if a client attached with a small msize
tha
This patch is not intended to be merged. It just provides a
temporary benchmark foundation for coneniently A/B comparison
of the subsequent 9p READDIR optimization patches:
* hw/9pfs/9p-synth: increase amount of simulated files for
READDIR test to 2000 files.
* tests/virtio-9p: measure wall tim
This will provide the following virtual directories by the 9p
synth backend:
- /ReadDirDir/ReadDirFile99
- /ReadDirDir/ReadDirFile98
...
- /ReadDirDir/ReadDirFile1
- /ReadDirDir/ReadDirFile0
These virtual directories will be used by the upcoming
9pfs READDIR tests.
Signed-off-by: Chris
This patch is just a temporary benchmark hack, not intended
to be merged!
synth driver's readdir() implementation has a severe n-square
performance problem. This patch is a quick and dirty hack to
prevent that performance problem from tainting the readdir()
benchmark results.
Signed-off-by: Chris
Additionally to the already existing check for expected amount
of directory entries returned by R_readdir response, also check
whether all entries have the expected file names, ignoring
their precise order in result list though.
Signed-off-by: Christian Schoenebeck
---
tests/virtio-9p-test.c | 2
This patch is not intended to be merged, it measures
and prints the time the 9p server spends on handling
a T_readdir request. It prints the total time it spent
on handling the request, and also the time it spent
on IO (driver) only.
Signed-off-by: Christian Schoenebeck
---
hw/9pfs/9p.c | 18 +++
Make top half really top half and bottom half really bottom half:
Each T_readdir request is hopping between threads (main IO thread
and background IO driver threads) several times for every individual
directory entry, which sums up to huge latencies for just a single
T_readdir request.
Instead of
A good 9p client sends T_readdir with "count" parameter that's
sufficiently smaller than client's initially negotiated msize
(maximum message size). We perform a check for that though to
avoid the server to be interrupted with a "Failed to encode
VirtFS reply type 41" error message by bad clients.
Signed-off-by: Christian Schoenebeck
---
tests/virtio-9p-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c
index e7b58e3a0c..880b4ff567 100644
--- a/tests/virtio-9p-test.c
+++ b/tests/virtio-9p-test.c
@@ -130,8 +130,9 @@ s
On 18/12/2019 09:19, Felipe Franciosi wrote:
> Hi Alexey,
>
> I don't know how, but somehow I didn't receive your reply:
> https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg02127.html
>
> (I was about to follow up, then I decided to look at the archives to
> make sure your response didn
On Tue, 17 Dec 2019 22:40:51 +0530
Kirti Wankhede wrote:
> Track dirty pages reporting capability for each vfio_device by setting the
> capability flag on calling vfio_pin_pages() for that device.
>
> In vfio_iommu_type1 module, while creating dirty pages bitmap, check if
> IOMMU backed device i
On 17/12/19 23:57, Felipe Franciosi wrote:
> Doing it in userspace was the flow we proposed back in last year's KVM
> Forum (Edinburgh), but it got turned down.
I think the time since then has shown that essentially the cat is out of
the bag. I didn't really like the idea of devices outside QEMU-
> On Dec 17, 2019, at 5:33 PM, Stefan Hajnoczi wrote:
>
> On Mon, Dec 16, 2019 at 07:57:32PM +, Felipe Franciosi wrote:
>>> On 16 Dec 2019, at 20:47, Elena Ufimtseva
>>> wrote:
>>> On Fri, Dec 13, 2019 at 10:41:16AM +, Stefan Hajnoczi wrote:
Is there a work-in-progress muser pat
On Tue, 17 Dec 2019 22:40:49 +0530
Kirti Wankhede wrote:
> Pages, pinned by external interface for requested IO virtual address
> range, might get unpinned and unmapped while migration is active and
> device is still running, that is, in pre-copy phase while guest driver
> still could access th
On Wed, 18 Dec 2019, at 01:55, Peter Maydell wrote:
> On Fri, 13 Dec 2019 at 05:48, Andrew Jeffery wrote:
> >
> > Hello,
> >
> > This is a v3 of the belated follow-up from a few of my earlier attempts to
> > fix
> > up the ARM generic timer for correct behaviour on the ASPEED AST2600 SoC.
> >
On Tuesday, December 17, 2019, Michael Rolnik wrote:
> Aleksandar.
>
> 1. inst.decode file
> 2. avr features are not accessible from avr_print_insn as it does not
> receive a pointer to CPU context. So, there is not way to inform the user
> that some instructions are not supported unless I define
The Instruction Length bit of the Exception Syndrome Register was fixed to 1
for data aborts. This bit is used by the Xen hypervisor to determine how to
increment the program counter after a mmio handler is successful and returns
control back to the guest virtual machine. With this value fixed to 1
Hi Alexey,
I don't know how, but somehow I didn't receive your reply:
https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg02127.html
(I was about to follow up, then I decided to look at the archives to
make sure your response didn't get lost in my client somehow...)
Still not sure of what h
On Tue, 17 Dec 2019 22:40:48 +0530
Kirti Wankhede wrote:
> VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations:
> - Start unpinned pages dirty pages tracking while migration is active and
> device is running, i.e. during pre-copy phase.
> - Stop unpinned pages dirty pages tracking. This is r
> "Philippe" == Philippe Mathieu-Daudé writes:
Philippe> Fix some trivial warnings when building with -O3.
For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its
manual).
Fixing the comments' placement i
Aleksandar.
1. inst.decode file
2. avr features are not accessible from avr_print_insn as it does not
receive a pointer to CPU context. So, there is not way to inform the user
that some instructions are not supported unless I define several
different avr_print_insn functions.
Regards,
Michael Rol
On 12/16/19 7:29 PM, David Gibson wrote:
On Fri, Dec 13, 2019 at 08:03:36AM -0500, Stefan Berger wrote:
On 12/13/19 12:34 AM, David Gibson wrote:
The existing one looks like this:
typedef struct SpaprVioCrq {
uint64_t qladdr;
uint32_t qsize;
uint32_t qnext;
int(*SendFunc)(s
I tested the patch in Comment #34, and it was able to pass 500
iterations.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1805256
Title:
qemu-img hangs on rcu_call_ready_event logic in Aarch64 when
On 12/17/19 7:52 PM, Alex Williamson wrote:
On Tue, 17 Dec 2019 19:31:41 +0100
Paolo Bonzini wrote:
On 17/12/19 19:17, Peter Maydell wrote:
On Tue, 17 Dec 2019 at 16:57, Richard Henderson
wrote:
On 12/17/19 1:58 AM, Christophe de Dinechin wrote:
On 17 Dec 2019, at 11:51, Paolo Bonzin
On Tue, 17 Dec 2019 19:31:41 +0100
Paolo Bonzini wrote:
> On 17/12/19 19:17, Peter Maydell wrote:
> > On Tue, 17 Dec 2019 at 16:57, Richard Henderson
> > wrote:
> >>
> >> On 12/17/19 1:58 AM, Christophe de Dinechin wrote:
> >>>
> >>>
> On 17 Dec 2019, at 11:51, Paolo Bonzini wrote:
>
On Tue, Dec 17, 2019 at 7:41 PM Philippe Mathieu-Daudé
wrote:
>
> On 12/17/19 7:21 PM, Peter Maydell wrote:
> > On Tue, 17 Dec 2019 at 18:16, Taylor Simpson wrote:
> >> Question 2:
> >> What is the best source of guidance on breaking down support for a new
> >> target into a patch series?
> >
>
From: Thomas Huth
Sent: Tuesday, December 17, 2019 7:10 PM
To: Philippe Mathieu-Daudé; qemu-devel@nongnu.org
Cc: libvir-l...@redhat.com; Hervé Poussineau; Aleksandar Markovic; Aleksandar
Rikalo; Aurelien Jarno
Subject: [EXTERNAL]Re: [PATCH-for-4.2] hw/mi
On Tue, 17 Dec 2019 11:58:44 +0530
Kirti Wankhede wrote:
> On 12/17/2019 4:14 AM, Alex Williamson wrote:
> > On Tue, 17 Dec 2019 01:51:36 +0530
> > Kirti Wankhede wrote:
> >
> >> - Defined MIGRATION region type and sub-type.
> >>
> >> - Defined vfio_device_migration_info structure which will
1 - 100 of 258 matches
Mail list logo
