On Tue, Dec 17, 2019 at 8:03 AM Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Sat, 14 Dec 2019 at 02:44, Alistair Francis <alist...@alistair23.me> wrote: > > > > Signed-off-by: Alistair Francis <alist...@alistair23.me> > > --- > > MAINTAINERS | 6 +++++ > > hw/arm/Kconfig | 3 +++ > > hw/arm/Makefile.objs | 1 + > > hw/arm/netduinoplus2.c | 52 ++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 62 insertions(+) > > create mode 100644 hw/arm/netduinoplus2.c > > > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > > index 7bfdc3a7ac..881e7f56e7 100644 > > --- a/hw/arm/Kconfig > > +++ b/hw/arm/Kconfig > > @@ -105,6 +105,9 @@ config NETDUINOPLUS2 > > bool > > select STM32F405_SOC > > > > +config NETDUINOPLUS2 > > + bool > > + > > config NSERIES > > bool > > select OMAP > > Something odd has happened here -- your patch 1/4 already > had a stanza: > > +config NETDUINOPLUS2 > + bool > + select STM32F405_SOC > > so either that should be in this patch or this fragment here > should just be deleted.
Good catch. It kind of makes sense to have that fragment in this patch, but then I don't see a nice way to build the flies as they are added, so I removed the fragment from this patch. > > Assuming you sort that out, > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Thanks Peter Alistair > > thanks > -- PMM