On 12/5/19 11:15 PM, Niek Linnenbank wrote:
Hello Philippe,
On Tue, Dec 3, 2019 at 10:18 AM Philippe Mathieu-Daudé
mailto:phi...@redhat.com>> wrote:
On 12/2/19 10:09 PM, Niek Linnenbank wrote:
> The Xunlong Orange Pi PC is an Allwinner H3 System on Chip
> based embedded computer
It's time to remove the deprecated "name" parameter from -net.
Please have a closer look at the second patch ... I think it should be
fine, but I'm not 100% sure whether it's ok for all cases to drop NetLegacy,
so please double-check.
Thomas Huth (2):
net: Drop the legacy "name" parameter from
It's been deprecated since QEMU v3.1, so it's time to finally
remove it. The "id" parameter can simply be used instead.
Signed-off-by: Thomas Huth
---
net/net.c| 10 +-
qapi/net.json| 4 +---
qemu-deprecated.texi | 12 +++-
3 files changed, 9 insertions(+), 1
Now that the "name" parameter is gone, there is hardly any difference
between NetLegacy and Netdev anymore. Drop NetLegacy and always use
Netdev to simplify the code quite a bit.
Signed-off-by: Thomas Huth
---
net/net.c | 74 ---
qapi/net.json
On 12/6/19 1:19 AM, Laszlo Ersek wrote:
On 12/05/19 20:00, Philippe Mathieu-Daudé wrote:
The Debian (based) distributions currently provides 2 ARM
toolchains, documented as [1]:
* The ARM EABI (armel) port targets a range of older 32-bit ARM
devices, particularly those used in NAS hardware a
On 11/29/19 1:36 PM, Philippe Mathieu-Daudé wrote:
On Fri, Nov 29, 2019 at 1:10 PM Laszlo Ersek wrote:
On 11/29/19 11:44, Philippe Mathieu-Daudé wrote:
I had this commit ready for when the next EDK2 release were go out,
which just happened: https://edk2.groups.io/g/devel/message/51502
Laszlo
On 12/5/19 8:56 PM, Laszlo Ersek wrote:
On 12/05/19 19:17, Ard Biesheuvel wrote:
On Thu, 5 Dec 2019 at 18:09, Philippe Mathieu-Daudé wrote:
The Debian (based) distributions historically provides 2 ARM
toolchains, documented as [1]:
* The ARM EABI (armel) port targets a range of older 32-bit
On 12/5/19 8:35 PM, Laszlo Ersek wrote:
On 12/05/19 17:50, Ard Biesheuvel wrote:
On Thu, 5 Dec 2019 at 16:27, Philippe Mathieu-Daudé wrote:
On 12/5/19 5:13 PM, Laszlo Ersek wrote:
Hi Phil,
(+Ard)
On 12/04/19 23:12, Philippe Mathieu-Daudé wrote:
Centos 7.7 only provides cross GCC 4.8.5, bu
On 05/12/2019 23.00, Eric Blake wrote:
> On 12/5/19 10:06 AM, Thomas Huth wrote:
>> They can't be used reliable for live-migration anymore (see
>> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04516.html
>> for details) and have been marked as deprecated since QEMU v4.0,
>> so time to re
On 05/12/2019 21.35, Markus Armbruster wrote:
> Devices "ivshmem-plain" and "ivshmem-doorbell" support only MSI-X.
> Config space register Interrupt Pin is zero. Device "ivshmem"
> additionally supported legacy INTx, but it was removed in commit
> 5a0e75f0a9 "hw/misc/ivshmem: Remove deprecated "iv
The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e:
Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +)
are available in the Git repository at:
git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206
for you to fetch changes up to d887a8cfc083bcf38
On Wed, Nov 27, 2019 at 09:50:54AM +0530, Bharata B Rao wrote:
> On Fri, Nov 22, 2019 at 10:42 AM David Gibson
> wrote:
> >
> > Ok. A number of queries about this.
> >
> > 1) The PAPR spec for ibm,dynamic-memory-v2 says that the first word in
> > each entry is the number of LMBs, but for NVDIMMs
On Fri, Dec 06, 2019 at 12:25:29PM +1100, Alexey Kardashevskiy wrote:
> The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e:
>
> Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +)
>
> are available in the Git repository at:
>
> g...@github.com:aik/qemu.
qemu sparc64 also failed to boot Oracle Linux
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1670175
Title:
qemu-system-sparc64 with tribblix-sparc-0m16.iso ends with "panic -
kernel: no nucleus h
On 2019/12/6 0:45, Amit Shah wrote:
> On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote:
>> From: Pan Nengyuan
>
> Shouldn't this be From: mst?
>
> I didn't find a ref to the original patch to confirm if you had to
> adapt it in any way, though.
>
Here is the original
patch: ht
On Thu, Dec 05, 2019 at 10:39:29AM +0530, Ganesh wrote:
>
> On 11/19/19 8:15 AM, David Gibson wrote:
> > On Thu, Oct 24, 2019 at 01:13:06PM +0530, Ganesh Goudar wrote:
> > > From: Aravinda Prasad
> > >
> > > This patch includes migration support for machine check
> > > handling. Especially this
The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e:
Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +)
are available in the Git repository at:
g...@github.com:aik/qemu.git tags/qemu-slof-20191206
for you to fetch changes up to e53a5569a27066a4f2f36ae3
On Thu, Dec 05, 2019 at 06:20:05PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Make kvmppc_hint_smt_possible hint append helper well formed:
> rename errp to errp_in, as it is IN-parameter here (which is unusual
> for errp), rename function to be kvmppc_error_append_*_hint.
>
> Signed-off-by: Vla
On Thu, Dec 05, 2019 at 08:46:21PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Make kvmppc_hint_smt_possible hint append helper well formed:
> switch errp paramter to Error *const * type, as it has uncommon
> behavior: not change the pointer to return error, but operate on
> already existent error
On 12/05/19 20:00, Philippe Mathieu-Daudé wrote:
> The Debian (based) distributions currently provides 2 ARM
> toolchains, documented as [1]:
>
> * The ARM EABI (armel) port targets a range of older 32-bit ARM
> devices, particularly those used in NAS hardware and a variety
> of *plug computer
On Wed, 4 Dec 2019 22:26:50 -0500
Yan Zhao wrote:
> Dynamic trap bar info region is a channel for QEMU and vendor driver to
> communicate dynamic trap info. It is of type
> VFIO_REGION_TYPE_DYNAMIC_TRAP_BAR_INFO and subtype
> VFIO_REGION_SUBTYPE_DYNAMIC_TRAP_BAR_INFO.
>
> This region has two fi
On Wed, 4 Dec 2019 22:25:36 -0500
Yan Zhao wrote:
> when vfio-pci is bound to a physical device, almost all the hardware
> resources are passthroughed.
> Sometimes, vendor driver of this physcial device may want to mediate some
> hardware resource access for a short period of time, e.g. dirty pa
On Wed, 4 Dec 2019 22:26:38 -0500
Yan Zhao wrote:
> Vendor driver specifies when to support a migration region through cap
> VFIO_PCI_DEVICE_CAP_MIGRATION in vfio_pci_mediate_ops->open().
>
> If vfio-pci detects this cap, it creates a default migration region on
> behalf of vendor driver with r
This has come up in the past, and I believe we discussed this at KVM
Forum, too:
There have been requests from oVirt (via Nir Soffer) to add some offline
bitmap manipulation functionality. In the past, our stance has generally
been "Use QEMU without an accelerator, and use QMP to manipulate the
im
When using `query-cpu-definitions` using `-machine none`,
QEMU is resolving all CPU models to their latest versions. The
actual CPU model version being used by another machine type (e.g.
`pc-q35-4.0`) might be different.
In theory, this was OK because the correct CPU model
version is returned whe
Hello Philippe,
On Tue, Dec 3, 2019 at 10:18 AM Philippe Mathieu-Daudé
wrote:
> On 12/2/19 10:09 PM, Niek Linnenbank wrote:
> > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip
> > based embedded computer with mainline support in both U-Boot
> > and Linux. The board comes with a Quad C
Hello Eric,
On 05/12/2019 09:42, Auger Eric wrote:
> Not related to this patch but I noticed SMMU_BASE_ADDR_MASK should be
> 0xffc0 and not 0xffe0. I can fix it separately or if you
> respin, you may fix it as well?
Good catch, thank you. I'll fix it in the next version.
Looking
On 12/5/19 10:06 AM, Thomas Huth wrote:
They can't be used reliable for live-migration anymore (see
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04516.html
for details) and have been marked as deprecated since QEMU v4.0,
so time to remove them now.
And while we're at it, mark the rem
On 12/5/19 4:53 PM, Eric Blake wrote:
> On 12/5/19 2:16 PM, John Snow wrote:
>
Last minute edit: hmm, actually, transaction action introduced in
4.2, so crash is not a regression, only broken
block-dirty-bitmap-remove
command is a regression... Maybe it's OK for stable.
>>>
On 12/5/19 2:16 PM, John Snow wrote:
Last minute edit: hmm, actually, transaction action introduced in
4.2, so crash is not a regression, only broken block-dirty-bitmap-remove
command is a regression... Maybe it's OK for stable.
Libvirt REALLY wants to use transaction bitmap management (and re
On 05.12.19 12:14, Markus Armbruster wrote:
> This has been on the list for more than three weeks already. I
> apologize for the delay.
No problem! Your feedback is highly appreciated.
>
> Jan Kiszka writes:
>
>> From: Jan Kiszka
>>
>> This imports the ivshmem v2 specification draft from Jai
On Mon, Dec 02, 2019 at 05:49:58PM -0300, Eduardo Habkost wrote:
> On Sun, Dec 01, 2019 at 12:46:12AM +0100, Aleksandar Markovic wrote:
> > On Monday, November 25, 2019, Filip Bozuta wrote:
> >
> > > The script checkpatch.pl located in scripts folder was
> > > used to detect all errors and warrni
On Wed, Nov 27, 2019 at 09:42:50AM +0100, Geert Uytterhoeven wrote:
> Add Device Tree bindings for a GPIO repeater, with optional translation
> of physical signal properties. This is useful for describing explicitly
> the presence of e.g. an inverter on a GPIO line, and was inspired by the
> non-Y
On Wed, Dec 04, 2019 at 04:46:17PM +0100, Thomas Huth wrote:
> From: Alex Bennée
>
> Our docker infrastructure isn't quite as multiarch as we would wish so
> let's allow the user to disable it if they want. This will allow us to
> use still run check-tcg on non-x86 CI setups.
>
> Signed-off-by:
On 12/4/19 3:39 PM, Philippe Mathieu-Daudé wrote:
> Commit 34ea023d4b9 introduced the Tulip PCI NIC.
> Since this better models the DP264 hardware, use it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/alpha/dp264.c | 4 ++--
> hw/alpha/Kconfig | 2 +-
> 2 files changed, 3 insertions(+),
On Wed, Dec 04, 2019 at 04:46:16PM +0100, Thomas Huth wrote:
> test-util-filemonitor fails in restricted non-x86 Travis containers
> since they apparently blacklisted some required system calls there.
> Let's simply skip the test if we detect such an environment.
>
> Reviewed-by: Philippe Mathieu-
Devices "ivshmem-plain" and "ivshmem-doorbell" support only MSI-X.
Config space register Interrupt Pin is zero. Device "ivshmem"
additionally supported legacy INTx, but it was removed in commit
5a0e75f0a9 "hw/misc/ivshmem: Remove deprecated "ivshmem" legacy
device". The commit left ivshmem_update
On Wed, Dec 04, 2019 at 04:46:15PM +0100, Thomas Huth wrote:
> In certain environments like restricted containers, we can not create
> huge test images. To be able to use "make check" in such container
> environments, too, let's skip the hd-geo-test instead of failing when
> the test images could n
On 12/5/19 3:09 PM, Eric Blake wrote:
> On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote:
>> Here is double bug:
>>
>> First, return error but not set errp. This may lead to:
>> qmp block-dirty-bitmap-remove may report success when actually failed
>>
>> block-dirty-bitmap-remove used in a
On 12/05/19 19:17, Ard Biesheuvel wrote:
> On Thu, 5 Dec 2019 at 18:09, Philippe Mathieu-Daudé wrote:
>>
>> The Debian (based) distributions historically provides 2 ARM
>> toolchains, documented as [1]:
>>
>> * The ARM EABI (armel) port targets a range of older 32-bit ARM
>> devices, particularl
On 12/5/19 1:30 PM, Vladimir Sementsov-Ogievskiy wrote:
Here is double bug:
First, return error but not set errp. This may lead to:
qmp block-dirty-bitmap-remove may report success when actually failed
block-dirty-bitmap-remove used in a transaction will crash, as
qmp_transaction will think tha
On 12/5/19 12:09 PM, Vladimir Sementsov-Ogievskiy wrote:
All callers of nbd_iter_channel_error() pass the address of a local_err
variable, and only call this function if an error has already occurred, using
this function
to append details to that error.
Hmm, not to append details but to
Ok, understood.
On Thu, Dec 5, 2019 at 8:45 PM Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Tuesday, October 29, 2019, Michael Rolnik wrote:
>
>> From: Sarah Harris
>>
>> These were designed to facilitate testing but should provide enough
>> function to be useful in other
On 12/5/19 2:30 PM, Vladimir Sementsov-Ogievskiy wrote:
> Here is double bug:
>
> First, return error but not set errp. This may lead to:
> qmp block-dirty-bitmap-remove may report success when actually failed
>
> block-dirty-bitmap-remove used in a transaction will crash, as
> qmp_transaction
On 12/5/19 9:31 AM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 11/30/19 8:45 AM, Alex Bennée wrote:
>>> The Linux kernel chooses the default of 64 bytes for SVE registers on
>>> the basis that it is the largest size that won't grow the signal
>>> frame. When debugging larger sizes
On 12/05/19 17:50, Ard Biesheuvel wrote:
> On Thu, 5 Dec 2019 at 16:27, Philippe Mathieu-Daudé wrote:
>>
>> On 12/5/19 5:13 PM, Laszlo Ersek wrote:
>>> Hi Phil,
>>>
>>> (+Ard)
>>>
>>> On 12/04/19 23:12, Philippe Mathieu-Daudé wrote:
Centos 7.7 only provides cross GCC 4.8.5, but the script for
Here is double bug:
First, return error but not set errp. This may lead to:
qmp block-dirty-bitmap-remove may report success when actually failed
block-dirty-bitmap-remove used in a transaction will crash, as
qmp_transaction will think that it returned success and will cal
block_dirty_bitmap_remo
On 12/5/19 10:40 AM, Peter Maydell wrote:
>> + * If it is, we must allocate the ram to back that up.
>> + */
>> +if (object_property_find(cpuobj, "tag-memory", NULL)) {
>> +if (!tag_sysmem) {
>> +tag_sysmem = g_new(MemoryRegion, 1);
>> +
On Mon, Oct 28, 2019 at 7:08 PM Kyle Evans wrote:
>
> Hi,
>
> We're working on improving bsd-user in a local tree and rebasing forward
> to get our work suitable for upstreaming. I'm porting the safe_syscall stuff
> over to bsd-user, and would like to get some design guidance as it may best
> be i
The Debian (based) distributions currently provides 2 ARM
toolchains, documented as [1]:
* The ARM EABI (armel) port targets a range of older 32-bit ARM
devices, particularly those used in NAS hardware and a variety
of *plug computers.
* The newer ARM hard-float (armhf) port supports newer, mo
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> This data access was forgotten in the previous patch.
>
> Fixes: 3a471103ac1823ba
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/t
Same a POWER9, only the MMIO window changes.
Signed-off-by: Cédric Le Goater
---
include/hw/ppc/pnv.h | 4
include/hw/ppc/pnv_lpc.h | 6 +-
hw/ppc/pnv.c | 25 ++---
hw/ppc/pnv_lpc.c | 30 ++
4 files changed, 53 in
This is an empty shell with the XSCOM bus and cores. The chip controllers
will come later.
Signed-off-by: Cédric Le Goater
---
include/hw/ppc/pnv.h | 33
include/hw/ppc/pnv_xscom.h | 19 +
hw/ppc/pnv.c | 158 +++--
hw/ppc/pnv_cor
The POWER10 PSIHB controller is very similar to the one on POWER9. We
should probably introduce a common PnvPsiXive object.
The ESB page size should be changed to 64k when P10 support is ready.
Signed-off-by: Cédric Le Goater
---
include/hw/ppc/pnv.h | 9 +
include/hw/ppc/pnv_psi
Signed-off-by: Cédric Le Goater
---
hw/ppc/pnv_psi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c
index a360515a86f8..f15aaa5c9cc0 100644
--- a/hw/ppc/pnv_psi.c
+++ b/hw/ppc/pnv_psi.c
@@ -609,9 +609,12 @@ static const TypeInfo pnv_
This includes in QEMU a new CPU model for the POWER10 processor with
the same capabilities of a POWER9 process. The model will be extended
when support is completed.
Signed-off-by: Cédric Le Goater
---
target/ppc/cpu-models.h | 3 +
target/ppc/cpu.h| 1 +
target/ppc/c
Hello,
The POWER10 and POWER9 processors are very similar and this series
adds the basic framework for a POWER10 chip and a machine using this
chip. The PSI and LPC models are provided first because there are no
changes. XIVE needs some adaptation and will come later.
Thanks,
C.
Cédric Le Goate
On Tuesday, October 29, 2019, Michael Rolnik wrote:
> From: Sarah Harris
>
> These were designed to facilitate testing but should provide enough
> function to be useful in other contexts.
> Only a subset of the functions of each peripheral is implemented, mainly
> due to the lack of a standard w
On Wed, Dec 04, 2019 at 04:46:13PM +0100, Thomas Huth wrote:
> Test 060 fails in the arm64, s390x and ppc64le LXD containers on Travis
> (which we will hopefully enable in our CI soon). These containers
> apparently do not allow large files to be created. The repair process
> in test 060 creates a
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> v5: Assign cs->num_ases to the final value first.
> Downgrade to ID_AA64PFR1.MTE=1 if tag memory is not available.
> v6: Add secure tag memory for EL3.
> ---
> target/arm/cpu.h | 6 ++
>
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> This "bit" is a particular value of the page's MemAttr.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/helper.c | 25 +++--
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/target/arm/help
On Thu, 5 Dec 2019 at 18:09, Philippe Mathieu-Daudé wrote:
>
> The Debian (based) distributions historically provides 2 ARM
> toolchains, documented as [1]:
>
> * The ARM EABI (armel) port targets a range of older 32-bit ARM
> devices, particularly those used in NAS hardware and a variety
> of
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> We now implement all of the components of MTE, without actually
> supporting any tagged memory. All MTE instructions will work,
> trivially, so we can enable support.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/cpu.c | 10
On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote:
Make qbus_list_bus and qbus_list_dev hint append helpers well formed:
switch errp paramter to Error *const * type, as it has uncommon
behavior: not change the pointer to return error, but operate on
already existent error object.
Rename fun
On 12/5/19 12:17 PM, Eric Blake wrote:
On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote:
Make qbus_list_bus and qbus_list_dev hint append helpers well formed:
switch errp paramter to Error *const * type, as it has uncommon
behavior: not change the pointer to return error, but operate on
a
05.12.2019 20:49, Eric Blake wrote:
> On 12/5/19 11:39 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 05.12.2019 20:14, Eric Blake wrote:
>>> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote:
The local_err parameter is not here to return information about
nbd_iter_channel_error failure.
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> This is DC GVA and DC GZVA.
>
> Signed-off-by: Richard Henderson
> ---
> v2: Use allocation_tag_mem + memset.
> v3: Require pre-cleaned addresses.
> ---
> diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c
> index f1315bae37.
The Debian (based) distributions historically provides 2 ARM
toolchains, documented as [1]:
* The ARM EABI (armel) port targets a range of older 32-bit ARM
devices, particularly those used in NAS hardware and a variety
of *plug computers.
* The newer ARM hard-float (armhf) port supports newer,
Hi all!
This is the first part of the bit series, which contains mostly simple
cleanups.
v6 was sent in separate (I'm sorry for inconvenience)
v7: by Markus review (and with his prepared fixups, thanks a lot!):
- don't rename Error** paramters
- switch to Error *const * where appropriate
l
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> This data access was forgotten in the previous patch.
Do you mean "in the patch where we added support for cleaning
addresses of TBI information"? As written it sounds like you're
referring to the previous patch in this patchseries.
> Fi
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/i386/amd_iommu.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index d55dbf07fc..b1175e52c7 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1533,7 +1533
Alan Hayward writes:
>> On 1 Dec 2019, at 20:05, Philippe Mathieu-Daudé wrote:
>>
>> On 11/30/19 9:45 AM, Alex Bennée wrote:
>>> This is cleaner than poking memory directly and will make later
>>> clean-ups easier.
>>> Signed-off-by: Alex Bennée
>>> ---
>>> v2
>>> - make sure we pass hi/lo
On 12/5/19 11:39 AM, Vladimir Sementsov-Ogievskiy wrote:
05.12.2019 20:14, Eric Blake wrote:
On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote:
The local_err parameter is not here to return information about
nbd_iter_channel_error failure. Instead it's assumed to be filled when
passed to t
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qga/commands-posix.c | 2 +-
qga/commands-win32.c | 2 +-
qga/commands.c | 12 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 1c1a165dae..3bd7b54c08 100644
--- a/
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Cornelia Huck
---
hw/s390x/event-facility.c | 2 +-
hw/s390x/s390-stattrib.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index 66205697ae..dc733ee2af 100644
On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote:
The local_err parameter is not here to return information about
nbd_iter_channel_error failure. Instead it's assumed to be filled when
passed to the function. This is already stressed by its name
(local_err, instead of classic errp). Stress
No reason for local_err here, use errp directly instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Reviewed-by: Gonglei
---
backends/cryptodev.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a
Make kvmppc_hint_smt_possible hint append helper well formed:
switch errp paramter to Error *const * type, as it has uncommon
behavior: not change the pointer to return error, but operate on
already existent error object.
Rename function to be kvmppc_error_append_*_hint.
Signed-off-by: Vladimir Se
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Stefan Berger
---
hw/tpm/tpm_emulator.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 22f9113432..10d587ed40 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/
fit_load_fdt forget to check that errp is not NULL and to zero it after
freeing. Fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
hw/core/loader-fit.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/core/loader-fit.c b/hw/core/loader-fit
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> Like the regular data cache flushes, these are nops within qemu.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/helper.c | 48 +
> 1 file changed, 48 insertions(+)
>
> diff --git a/tar
On Thu, 5 Dec 2019 18:34:32 +0100
Janosch Frank wrote:
> On 12/5/19 6:15 PM, Cornelia Huck wrote:
> > On Fri, 29 Nov 2019 04:48:02 -0500
> > Janosch Frank wrote:
> >
> >> Secure guests no longer intercept with code 4 for an instruction
> >> interception. Instead they have codes 104 and 108 fo
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
include/block/snapshot.h | 2 +-
block/snapshot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/block/snapshot.h b/include/block/snapshot.h
index b5d5084a12..2bfcd57578 100644
--- a
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/usb/dev-network.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index 5de6213cc4..b81a8abe83 100644
--- a/hw/usb/dev-network.c
+++ b/hw/usb/dev-network.c
@@ -1342,7 +1342,7 @@ stat
No reason for local_err here, use errp directly instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Markus Armbruster
Reviewed-by: Cornelia Huck
---
hw/vfio/ap.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index da6a206
Variable int err in inner scope shadows Error *err in outer scope.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
---
net/net.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/net/net.c b/net/net.c
Mostly, Error ** is for returning error from the function, so the
callee sets it. However these three functions get already filled errp
parameter. They dont change the pointer itself, only change the
internal state of referenced Error object. So we can make it
Error *const * errp, to stress the beh
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
hw/sd/sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 88404d0e9d..18c0c052ce 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -1459,7 +1459,7 @@ static void sd
We don't need Error **, as all callers pass local Error object, which
isn't used after the call. Use Error * instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Dr. David Alan Gilbert
Reviewed-by: Markus Armbruster
---
include/monitor/hmp.h | 2 +-
dump/dump-hmp-cmds.c
Make qbus_list_bus and qbus_list_dev hint append helpers well formed:
switch errp paramter to Error *const * type, as it has uncommon
behavior: not change the pointer to return error, but operate on
already existent error object.
Rename functions to be error_append_*_hint.
Signed-off-by: Vladimir
Make error_append_security_model_hint and
error_append_socket_sockfd_hint hint append helpers well formed:
switch errp paramter to Error *const * type, as it has uncommon
behavior: not change the pointer to return error, but operate on
already existent error object.
Signed-off-by: Vladimir Sements
Rename Error ** parameter in check_only_migratable to common errp.
In device_set_realized:
- Move "if (local_err != NULL)" closer to error setters.
- Drop 'Error **local_errp': it doesn't save any LoCs, but it's very
unusual.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric B
The local_err parameter is not here to return information about
nbd_iter_channel_error failure. Instead it's assumed to be filled when
passed to the function. This is already stressed by its name
(local_err, instead of classic errp). Stress it additionally by
assertion.
Signed-off-by: Vladimir Sem
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
---
include/qom/object.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 128d00c77f..716f6f655d 100644
--- a/include/qom/object.h
+++ b/includ
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
monitor/qmp-cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index 0880341a2d..c6faa3eaf0 100644
--- a/monitor/qmp-cmds.c
+++ b/monitor/qmp-cmds.c
@@ -109,7 +109,7 @@ void qmp_system_
We don't need Error **, as all callers pass local Error object, which
isn't used after the call, or NULL. Use Error * instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Markus Armbruster
---
ui/vnc.h | 2 +-
ui/vnc.c | 20 +++-
2 files changed, 8 insertions(+), 1
On Fri, 29 Nov 2019 04:48:08 -0500
Janosch Frank wrote:
> IO instruction data is routed through SIDAD for protected guests, so
> adresses do not need to be checked, as this is kernel memory.
>
> Signed-off-by: Janosch Frank
> ---
> target/s390x/ioinst.c | 26 +++---
> 1 fil
On Fri, 11 Oct 2019 at 14:50, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> v3: Require pre-cleaned addresses.
> ---
> target/arm/helper-a64.h| 3 ++
> target/arm/mte_helper.c| 96 ++
> target/arm/translate-a64.c | 42 +
05.12.2019 20:14, Eric Blake wrote:
> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote:
>> The local_err parameter is not here to return information about
>> nbd_iter_channel_error failure. Instead it's assumed to be filled when
>> passed to the function. This is already stressed by its name
On 12/5/19 6:15 PM, Cornelia Huck wrote:
> On Fri, 29 Nov 2019 04:48:02 -0500
> Janosch Frank wrote:
>
>> Secure guests no longer intercept with code 4 for an instruction
>> interception. Instead they have codes 104 and 108 for secure
>> instruction interception and secure instruction notificatio
1 - 100 of 249 matches
Mail list logo
