[PULL v2 19/73] cpu: introduce cpu_in_exclusive_context()

2019-10-24 Thread Alex Bennée
From: "Emilio G. Cota" Suggested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [AJB: moved inside start/end_exclusive fns + cleanup] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 48272c781b7.

[PULL v2 52/73] configure: add --enable-plugins

2019-10-24 Thread Alex Bennée
This adds the basic boilerplate feature enable option for the build. We shall expand it later. [AJB: split from larger patch] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/configure b/configure index d6fbcf45e4f..2995559ed21 100755 --- a/configure +++ b/configure @@ -49

[PULL v2 22/73] plugin: add user-facing API

2019-10-24 Thread Alex Bennée
From: "Emilio G. Cota" Add the API first to ease review. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h new file mode 100644 index 000..d9c1ca3b4cf --- /dev/null +++ b/includ

[PULL v2 59/73] tests/plugin: add sample plugins

2019-10-24 Thread Alex Bennée
From: "Emilio G. Cota" Pass arguments with -plugin=libfoo.so,arg=bar,arg=baz Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/configure b/configure index eabe84af6ed..f77c4dc09a6 100755 --- a/configure +++ b/configure @@ -7903,6 +7903,7 @@

[PULL v2 54/73] plugin: expand the plugin_init function to include an info block

2019-10-24 Thread Alex Bennée
This provides a limited amount of info to plugins about the guest system that will allow them to make some additional decisions on setup. Signed-off-by: Alex Bennée diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index c213d1dd19f..784f1dfc3da 100644 --- a/include/qemu/qemu-

[PULL v2 56/73] plugin: add qemu_plugin_outs helper

2019-10-24 Thread Alex Bennée
Having the plugins grab stdout and spew stuff there is a bit ugly and certainly makes the tests look ugly. Provide a hook back into QEMU which can be redirected as needed. Signed-off-by: Alex Bennée Reviewed-by: Aaron Lindsay diff --git a/include/qemu/log.h b/include/qemu/log.h index b097a6cae1

[PULL v2 65/73] tests/plugin: add a hotblocks plugin

2019-10-24 Thread Alex Bennée
This is a simple plugin to track which translation blocks are call most often. As we don't have a view of the internals of TCG we can only work by the address of the start of the block so we also need to tracks how often the address is translated. As there will be multiple blocks starting at the s

[PULL v2 11/73] tests/vm/netbsd: Disable IPv6

2019-10-24 Thread Alex Bennée
From: Eduardo Habkost Workaround for issues when the host has no IPv6 connectivity. Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Message-Id: <20191018181705.17957-4-ehabk...@redhat.com> Signed-off-by: Alex Bennée diff --git a/tests/vm/netbsd b/tests/vm/netbsd index 9558a672efa..d4

[PULL v2 53/73] plugin: add API symbols to qemu-plugins.symbols

2019-10-24 Thread Alex Bennée
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota [AJB: moved into plugins] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/Makefile b/Makefile index 94d25185511..bd6376d295f 100644 --- a/Makefile +++ b/Makefile @@ -74,6 +74,12 @@ CONFIG_ALL=y config-host.mak: $(SRC

[PULL v2 21/73] docs/devel: add plugins.rst design document

2019-10-24 Thread Alex Bennée
This is mostly extracted from Emilio's more verbose commit comments with some additional verbiage from me. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/docs/devel/index.rst b/docs/devel/index.rst index 1ec61fcfed9..2ff058bae38 100644 --- a/docs/devel/index.rst +++ b/do

[PULL v2 12/73] travis.yml: cache the clang sanitizer build

2019-10-24 Thread Alex Bennée
Hopefully we'll see the same benefits as the other builds. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/.travis.yml b/.travis.yml index da6a2063fca..c43597f1331 100644 --- a/.travis.yml +++ b/.travis.yml @@ -189,6 +189,7 @@ matrix: - env: - CONFIG=

[PULL v2 06/73] travis.yml: Test the release tarball

2019-10-24 Thread Alex Bennée
From: Philippe Mathieu-Daudé Add a job to generate the release tarball and build/install few QEMU targets from it. Ideally we should build the 'efi' target from the 'roms' directory, but it is too time consuming. This job is only triggered when a tag starting with 'v' is pushed, which is the ca

[PULL v2 09/73] tests/vm: netbsd autoinstall, using serial console

2019-10-24 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann Reviewed-by:

[PULL v2 13/73] gitlab-ci.yml: Use libvdeplug-dev to compile-test the VDE network backend

2019-10-24 Thread Alex Bennée
From: Thomas Huth The libvdeplug-dev package is required to compile-test net/vde.c. Signed-off-by: Thomas Huth Message-Id: <20191016131002.29663-1-th...@redhat.com> Signed-off-by: Alex Bennée diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ed8067f5cf9..be57c6a454a 100644 --- a/.gitlab-ci.y

[PULL v2 00/73] tcg plugins and testing updates

2019-10-24 Thread Alex Bennée
The following changes since commit 81c1f71eeb874c4cbbb9c5c4d1a1dc0ba7391dff: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2019-10-24 10:43:20 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing

[PULL v2 08/73] cirrus.yml: add latest Xcode build target

2019-10-24 Thread Alex Bennée
CirrusCI provides a mojave-xcode alias for the latest Xcode available. Let's use it to make sure we track the latest releases. Signed-off-by: Alex Bennée diff --git a/.cirrus.yml b/.cirrus.yml index 8326a3a4b16..27efc48619b 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -25,3 +25,14 @@ macos_task

[PULL v2 01/73] travis.yml: reduce scope of the --enable-debug build

2019-10-24 Thread Alex Bennée
Adding debug makes things run a bit slower so lets not hammer all the targets. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/.travis.yml b/.travis.yml index d0b9e099b9c..7d90b87540f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -124,12 +124,13 @@ matrix: -

[PULL v2 03/73] travis.yml: Use libsdl2 instead of libsdl1.2, and install libsdl2-image

2019-10-24 Thread Alex Bennée
From: Thomas Huth We've removed support for SDL 1.2 quite a while ago already, so let's use SDL 2 now in Travis to get test coverage for SDL again. And while we're at it, also add libsdl2-image-dev which can be used by QEMU nowadays, too. Signed-off-by: Thomas Huth Message-Id: <20191009170701.1

[PULL v2 07/73] travis.yml: bump Xcode 10 to latest dot release

2019-10-24 Thread Alex Bennée
According to: https://docs.travis-ci.com/user/reference/osx/#macos-version we have 10.3 available so lets use it. I don't know what Apple's deprecation policy is for Xcode because it requires an AppleID to find out. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a

[PULL v2 10/73] tests/vm: Let subclasses disable IPv6

2019-10-24 Thread Alex Bennée
From: Eduardo Habkost The mechanism will be used to work around issues related to IPv6 on the netbsd image builder. Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191018181705.17957-3-ehabk...@redhat.com> Signed-off-by: Alex Bennée

Re: [PATCH 7/7] cpu: Add `machine` parameter to query-cpu-definitions

2019-10-24 Thread Markus Armbruster
Eduardo Habkost writes: > The new parameter can be used by management software to query for > CPU model alias information for multiple machines without > restarting QEMU. > > Signed-off-by: Eduardo Habkost > --- > qapi/machine-target.json | 14 +++- > target/arm/helper.c

[PULL v2 04/73] travis.yml: Use newer version of libgnutls and libpng

2019-10-24 Thread Alex Bennée
From: Thomas Huth libgnutls-dev and libpng12-dev are not available in newer versions of Ubuntu anymore, so installing these packages fails e.g. in the new arm64 containers on Travis. Let's use newer versions of these packages by default instead. (The old versions still get tested in the "gcc-9" b

[PULL v2 02/73] travis.yml: Add libvdeplug-dev to compile-test net/vde.c

2019-10-24 Thread Alex Bennée
From: Thomas Huth This library is needed to compile the VDE network backend. Signed-off-by: Thomas Huth Message-Id: <20191009170701.14756-2-th...@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/.travis.yml b/.travis.yml index 7d90b87540f..7be2a9949f5 1

[PULL v2 05/73] travis.yml: Fix the ccache lines

2019-10-24 Thread Alex Bennée
From: Thomas Huth The "command -v ccache && ccache ..." likely were supposed to test the availability of ccache before running the program. But this shell construct causes Travis to abort if ccache is not available. Use an if-statement instead to fix this problem. Signed-off-by: Thomas Huth Rev

Re: [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information

2019-10-24 Thread Tao Xu
On 10/23/2019 11:28 PM, Igor Mammedov wrote: On Sun, 20 Oct 2019 19:11:19 +0800 Tao Xu wrote: [...] +# +# @access-bandwidth: access bandwidth (MB/s) +# +# @read-bandwidth: read bandwidth (MB/s) +# +# @write-bandwidth: write bandwidth (MB/s) I think units here are not appropriate, values store

Re: [RFC v2 00/22] intel_iommu: expose Shared Virtual Addressing to VM

2019-10-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1571920483-3382-1-git-send-email-yi.l@intel.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [RFC v2 00/22] intel_iommu: expose Shared Virtual Addressing to VM

2019-10-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1571920483-3382-1-git-send-email-yi.l@intel.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH v5 06/11] qapi: add failover negotiated event

2019-10-24 Thread Markus Armbruster
We ask patch submitters to cc: subject matter experts for review. You did. When such patches touch the QAPI schema, it's best to cc the qapi schema maintainers (Eric Blake and me) as well, because we can't require all subject matter experts to be fluent in the QAPI schema language and conventions

[PATCH v5] ssi: xilinx_spips: Skip spi bus update for a few register writes

2019-10-24 Thread Sai Pavan Boddu
A few configuration register writes need not update the spi bus state, so just return after register write. Signed-off-by: Sai Pavan Boddu --- Changes for V2: Just skip update of spips cs and fifos Update commit message accordingly Changes for V4: Avoid checking for zynqm

Re: QMP netdev_add multiple dnssearch values

2019-10-24 Thread Markus Armbruster
Alex Kirillov writes: > Hi, > > I'm trying to create a user (slirp) interface with several `dnssearch` values > using QMP. > But every variant I pass can't do that. What exactly goes wrong? Does the QMP command fail? Does it succeed but the network backend incorrectly? > According to the QAP

Re: [PULL 00/11] MIPS queue for October 24th, 2019

2019-10-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1571915195-4381-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/11] MIPS queue for October 24th, 2019 Type: series Message-id: 1571915195-43

[PATCH v5 1/2] hw: rtc: Add Goldfish RTC device

2019-10-24 Thread Anup Patel
This patch adds model for Google Goldfish virtual platform RTC device. We will be adding Goldfish RTC device to the QEMU RISC-V virt machine for providing real date-time to Guest Linux. The corresponding Linux driver for Goldfish RTC device is already available in upstream Linux. For now, VM migr

[PATCH v5 2/2] riscv: virt: Use Goldfish RTC device

2019-10-24 Thread Anup Patel
We extend QEMU RISC-V virt machine by adding Goldfish RTC device to it. This will allow Guest Linux to sync it's local date/time with Host date/time via RTC device. Signed-off-by: Anup Patel Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- hw/riscv/Kconfi

[PATCH v5 0/2] RTC support for QEMU RISC-V virt machine

2019-10-24 Thread Anup Patel
This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency external clock. The driver for Goldfish RTC is already available in Linux so we just need to enable it in Kco

RE: [PATCH v4 1/2] hw: rtc: Add Goldfish RTC device

2019-10-24 Thread Anup Patel
> -Original Message- > From: Alistair Francis > Sent: Friday, October 25, 2019 5:40 AM > To: Anup Patel > Cc: Peter Maydell ; Palmer Dabbelt > ; Alistair Francis ; Sagar > Karandikar ; Bastian Koppelmann > ; Atish Patra ; > qemu-ri...@nongnu.org; qemu-devel@nongnu.org; Anup Patel > > S

Re: [PATCH v6 0/9] Packed virtqueue for virtio

2019-10-24 Thread Jason Wang
On 2019/10/25 上午1:13, Eugenio Pérez wrote: Hi: This is an updated version of packed virtqueue support based on Wei and Jason's V5, mainly solving the clang leak detector error CI gave. Please review. Changes from V5: - Fix qemu's CI asan error. - Move/copy rcu comments. - Merge duplicated vd

[PATCH] i386: Use g_autofree in a few places

2019-10-24 Thread Eduardo Habkost
Get rid of 12 explicit g_free() calls. Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 41 + 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 0de8a22e1e..59b7aaf580 100644 --- a/target/i386/

[PATCH 6/7] i386: Don't use default_cpu_version() inside query-cpu-definitions

2019-10-24 Thread Eduardo Habkost
We will change query-cpu-definitions to have a new `machine` parameter. Make the machine-specific parts of that code explicit instead of calling default_cpu_version(), so we can change it to use the new parameter later. As the code now has a dependency on MachineClass, wrap it inside a !CONFIG_US

[PATCH 5/7] i386: Remove x86_cpu_set_default_version() function

2019-10-24 Thread Eduardo Habkost
We will introduce code that will return machine-type-specific from other machines (not the current one), so we'll need a helper for getting the default CPU version from a machine class. With the new helper, we don't need the machine init function to call x86_cpu_set_default_version() anymore: we c

[PATCH 2/7] i386: Add default_version parameter to CPU version functions

2019-10-24 Thread Eduardo Habkost
Not all CPU version lookup code will use default_cpu_version: we'll change query-cpu-definitions to optionally get a machine type argument. Make CPU version resolving functions get an explicit default_version argument. All callers are being changed to use default_cpu_version as argument, so no be

[PATCH 4/7] machine: machine_find_class() function

2019-10-24 Thread Eduardo Habkost
Move find_machine() from vl.c to core/machine.c and rename it to machine_find_class(), so it can be reused by other code. The function won't reuse the results of the previous object_class_get_list() call like it did in vl.c, but this shouldn't be a problem because the function is expected to be ca

[PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-24 Thread Eduardo Habkost
We had introduced versioned CPU models in QEMU 4.1, including a method for querying for CPU model versions using query-cpu-definitions. This only has one problem: fetching CPU alias information for multiple machine types required restarting QEMU for each machine being queried. This series adds a

[PATCH 3/7] i386: Don't use default_cpu_version at "-cpu help"

2019-10-24 Thread Eduardo Habkost
The output of "-cpu help" doesn't change depending on the machine type, already. We can remove usage of default_cpu_version and keep output exactly the same. Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/i3

[PATCH 1/7] i386: Use g_autofree at x86_cpu_list_entry()

2019-10-24 Thread Eduardo Habkost
Make the code shorter and simpler. Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 0de8a22e1e..5b7c5b1177 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -3976,

[PATCH 7/7] cpu: Add `machine` parameter to query-cpu-definitions

2019-10-24 Thread Eduardo Habkost
The new parameter can be used by management software to query for CPU model alias information for multiple machines without restarting QEMU. Signed-off-by: Eduardo Habkost --- qapi/machine-target.json | 14 +++- target/arm/helper.c| 4 ++- target/i3

Re: [PATCH v4 2/2] virtio-net: prevent offloads reset on migration

2019-10-24 Thread Jason Wang
On 2019/10/24 下午9:53, Mikhail Sennikovsky wrote: Hi Guys, Sorry I was on vacation last week, so did not track it much. Seems like the patch has not been applied yet. Is this because there are still some concerns about the way of fixing the problem? Regards, Mikhail Applied. Thanks

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu

2019-10-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1571905346.git.jag.ra...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC v4 PATCH 00/49] Initial support of multi-process qemu Type: series Message-id: cover.1571905346.git.ja

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu

2019-10-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1571905346.git.jag.ra...@oracle.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-24 Thread Zhenyu Ye
On 2019/10/24 22:38, Dr. David Alan Gilbert wrote: > * Zhenyu Ye (yezhen...@huawei.com) wrote: >> >> >> On 2019/10/24 21:56, Dr. David Alan Gilbert wrote: >>> * Zhenyu Ye (yezhen...@huawei.com) wrote: On 2019/10/23 23:19, Stefan Hajnoczi wrote: > On Tue, Oct 22, 2019 at 04:12:

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu

2019-10-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1571905346.git.jag.ra...@oracle.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-24 Thread Tao Xu
On 10/24/2019 9:20 PM, Eduardo Habkost wrote: On Thu, Oct 24, 2019 at 10:54:57AM +0100, Daniel P. Berrangé wrote: On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for mi

Re: [PATCH v4 1/2] hw: rtc: Add Goldfish RTC device

2019-10-24 Thread Alistair Francis
On Tue, Oct 22, 2019 at 11:37 PM Anup Patel wrote: > > This patch adds model for Google Goldfish virtual platform RTC device. > > We will be adding Goldfish RTC device to the QEMU RISC-V virt machine > for providing real date-time to Guest Linux. The corresponding Linux > driver for Goldfish RTC d

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-24 Thread Peter Xu
On Thu, Oct 24, 2019 at 01:49:11PM -0400, John Snow wrote: > > > On 10/23/19 4:17 AM, Kevin Wolf wrote: > > The important difference here is legacy IDE (which works) vs. AHCI > > (which doesn't work). If you add a -device ahci to the -M pc case, it > > starts failing, too. > > > > Not sure why A

[PATCH] Semihost SYS_READC implementation (v4)

2019-10-24 Thread Keith Packard
Provides a blocking call to read a character from the console using semihosting.chardev, if specified. This takes some careful command line options to use stdio successfully as the serial ports, monitor and semihost all want to use stdio. Here's a sample set of command line options which share stdi

Re: qemu crashing when attaching an ISO file to a virtio-scsi CD-ROM device through libvirt

2019-10-24 Thread Fernando Casas Schössow
BTW just to be clear, qemu is crashing in this scenario *only* if iothread is enabled for the guest. Without iothread enabled the operation is completed without any problems. On jue, oct 24, 2019 at 11:07 PM, Fernando Casas Schössow wrote: > Today I updated to qemu 4.0.1 since this was the lat

Re: [PATCH 3/3] Acceptance Tests: use avocado tags for machine type

2019-10-24 Thread Wainer dos Santos Moschetta
Hello, On 9/24/19 4:45 PM, Cleber Rosa wrote: The same way the arch tag is being used as a fallback for the arch parameter, let's do the same for QEMU's machine and avoid some boiler plate code. This requires a bump in the Avocado version, as starting with 72.0, the characters supported in tags

Re: [PATCH 2/3] Acceptance tests: introduce utility method for tags unique vals

2019-10-24 Thread Wainer dos Santos Moschetta
Hi Cleber, On 9/24/19 4:45 PM, Cleber Rosa wrote: Currently a test can describe the target architecture binary that it should primarily be run with, be setting a single tag value. The same approach is expected to be done with other QEMU aspects to be tested, for instance, the machine type and a

Re: [PATCH qemu] spapr: Add /choses to FDT only at reset time to preserve kernel and initramdisk

2019-10-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191024041308.5673-1-...@ozlabs.ru/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin

Re: qemu crashing when attaching an ISO file to a virtio-scsi CD-ROM device through libvirt

2019-10-24 Thread Fernando Casas Schössow
Today I updated to qemu 4.0.1 since this was the latest version available for Alpine and I can confirm that I can repro the issue with this version as well. Not sure if relevant but I can also confirm that the problem happens with Windows Server 2012 R2 but also with Linux guests (it doesn't ma

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-24 Thread Eric Blake
On 10/24/19 1:11 PM, Laurent Vivier wrote: Le 24/10/2019 à 20:03, Eric Blake a écrit : On 10/24/19 12:31 PM, Laurent Vivier wrote: Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : Signed-off-by: Frediano Ziglio ---   util/qemu-timer.c | 6 +-   1 file changed, 1 insertion(+), 5 deletions

Re: [PATCH v3 5/6] hppa: Add emulation of Artist graphics

2019-10-24 Thread Mark Cave-Ayland
On 22/10/2019 21:59, Sven Schnelle wrote: > This adds emulation of Artist graphics good enough > to get a Text console on both Linux and HP-UX. The > X11 server from HP-UX also works. > > Signed-off-by: Sven Schnelle > --- > hw/display/Kconfig |3 + > hw/display/Makefile.objs |1 +

Re: [PULL 03/39] Updated Bulgarian translation (19) - 4.1.0

2019-10-24 Thread Paolo Bonzini
On 24/10/19 21:54, Aleksandar Markovic wrote: > > 24.10.2019. 16.26, "Paolo Bonzini" > је написао/ла: >> >> From: Alexander Shopov mailto:a...@kambanaria.org>> >> >> Signed-off-by: Alexander Shopov > >> Message-Id: <20191019120534.27479-2-.

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Jens Freimann
On Thu, Oct 24, 2019 at 10:52:36AM -0600, Alex Williamson wrote: On Thu, 24 Oct 2019 11:37:54 +0200 Jens Freimann wrote: [...] > >While reviewing, I realized that we shouldn't have this check for below reasons. > >1. It is user's responsibility to pass networking device. >But its ok to check

Re: [PATCH v5 06/11] qapi: add failover negotiated event

2019-10-24 Thread Jens Freimann
On Thu, Oct 24, 2019 at 06:32:45PM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature was not negotiated during virtio feature negotiation. If this event is received it means any primary devi

Re: [Qemu-devel] [PATCH] Acceptance tests: refactor wait_for_console_pattern

2019-10-24 Thread Wainer dos Santos Moschetta
Hi Cleber, On 9/16/19 1:40 PM, Cleber Rosa wrote: The same utility method is already present in two different test files, so let's consolidate it into a single utility function. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 26 + tests/acceptance/boo

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Jens Freimann
On Thu, Oct 24, 2019 at 06:22:27PM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: This patch adds a net_failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device. It on

Re: [libvirt] [RFC PATCH 19/19] qapi: Implement -compat deprecated-output=hide for events

2019-10-24 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Oct 24, 2019 at 02:34:58PM +0200, Markus Armbruster wrote: >> This policy suppresses deprecated events, and thus permits "testing >> the future". > > One thing that occurs to me is that this is a fairly passive impact > on libvirt. eg it may well be not at all

Re: [PATCH v2 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-24 Thread Aleksandar Markovic
On Friday, October 18, 2019, Philippe Mathieu-Daudé wrote: > Changes since v1 [0]: > - Removed patch reintroducing DO_UPCAST() use (thuth) > - Took various patches out to reduce series (thuth) > - Added review tags (thanks all for reviewing!) > > Philippe, Do you intend to submit v3? The softfre

Re: [PULL 03/39] Updated Bulgarian translation (19) - 4.1.0

2019-10-24 Thread Aleksandar Markovic
24.10.2019. 16.26, "Paolo Bonzini" је написао/ла: > > From: Alexander Shopov > > Signed-off-by: Alexander Shopov > Message-Id: <20191019120534.27479-2-...@kambanaria.org> > Signed-off-by: Paolo Bonzini > --- > po/bg.po | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > How c

Re: [PATCH v3 00/16] hw/arm/raspi: Add thermal/timer, improve address space, run U-boot

2019-10-24 Thread Philippe Mathieu-Daudé
On 10/24/19 5:31 PM, Peter Maydell wrote: On Thu, 24 Oct 2019 at 14:42, Peter Maydell wrote: On Sun, 20 Oct 2019 at 00:47, Philippe Mathieu-Daudé wrote: Since v2: - fixed issue in videocore address space - allow to start with some cores OFF (to boot firmwares) - add proof-of-concept test fo

Re: [libvirt] [RFC PATCH 18/19] qapi: Include a warning in the response to a deprecated command

2019-10-24 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Oct 24, 2019 at 02:34:57PM +0200, Markus Armbruster wrote: >> Looks like this >> >> ---> {"execute": "query-cpus"} >> <--- {"return": [...], "warnings": [{"class": "CommandNotFound", "desc": >> "command is deprecated"}]} >> >> Management application

Re: [PULL 00/51] target-arm queue

2019-10-24 Thread Mark Cave-Ayland
branch 'remotes/dgibson/tags/ppc-for-4.2-20191024' >> into >> staging (2019-10-24 16:22:58 +0100) >> >> are available in the Git repository at: >> >>    https://git.linaro.org/people/pmaydell/qemu-arm.git >> tags/pull-target-arm-20191024 >>

Re: [PATCH v2 12/14] hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:04, Philippe Mathieu-Daudé a écrit : > Only 2 source files require the "mc146818rtc_regs.h" header. > Instead of having it processed 12 times, by all objects > using "mc146818rtc.h", include it directly where used. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mat

Re: [PATCH] Semihost SYS_READC implementation (v3)

2019-10-24 Thread Paolo Bonzini
On 24/10/19 19:33, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20191023192640.13125-1-kei...@keithp.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker installed,

Re: [PATCH v2 10/14] hw: Move Exynos4210 RTC from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:04, Philippe Mathieu-Daudé a écrit : > Move RTC devices under the hw/rtc/ subdirectory. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/exynos4210_rtc.c | 0 > hw/timer/Makefile.ob

Re: [PATCH v2 14/14] hw/rtc/aspeed_rtc: Remove unused includes

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:04, Philippe Mathieu-Daudé a écrit : > The system include is already provided by "osdep.h" > (the scripts/clean-includes file clean such headers). > > Commit 64552b6be47 suggests we don't need to include "hw/irq.h": > > Move the qemu_irq and qemu_irq_handler typedefs from

Re: [PATCH v2 13/14] hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:04, Philippe Mathieu-Daudé a écrit : > The "hw/ptimer.h" header is not used, remove it. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/xlnx-zynqmp-rtc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/rtc/xlnx-zynqmp-rtc.c

Re: [PATCH v2 11/14] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:04, Philippe Mathieu-Daudé a écrit : > Move RTC devices under the hw/rtc/ subdirectory. > > Reviewed-by: Cédric Le Goater > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/aspeed_

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-24 Thread Laurent Vivier
Le 24/10/2019 à 20:03, Eric Blake a écrit : > On 10/24/19 12:31 PM, Laurent Vivier wrote: >> Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : >>> Signed-off-by: Frediano Ziglio >>> --- >>>   util/qemu-timer.c | 6 +- >>>   1 file changed, 1 insertion(+), 5 deletions(-) >>> > >>> >> >> Applied

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-24 Thread Eduardo Habkost
On Thu, Oct 24, 2019 at 12:52:28PM +0100, Peter Maydell wrote: > On Thu, 24 Oct 2019 at 12:48, Philippe Mathieu-Daudé > wrote: > > Just wondering, if we had a "bus_address" property to the abstract > > SysBus class (and eventually "bus_name" for later) we could create/map > > sysbus devices from

Re: [PATCH v2 05/14] hw: Move M41T80 device from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > The M41T80 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS| 2 +- > hw/rtc/Kconfig | 4

Re: [PATCH v2 09/14] hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > Move RTC devices under the hw/rtc/ subdirectory. > > Remove Alistair outdated email address (see commit c22e580c2ad). > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Makefile.objs

Re: [PULL 00/51] target-arm queue

2019-10-24 Thread Philippe Mathieu-Daudé
On 10/24/19 6:26 PM, Peter Maydell wrote: Probably the last arm pullreq before softfreeze... The following changes since commit 58560ad254fbda71d4daa6622d71683190070ee2: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20191024' into staging (2019-10-24 16:22:58 +

Re: [PATCH v2 08/14] hw: Move DS1338 device from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > The DS1338 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Kconfig | 4 > hw/rtc/Makefile.objs |

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-24 Thread Laurent Vivier
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > Signed-off-by: Frediano Ziglio > --- > util/qemu-timer.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/util/qemu-timer.c b/util/qemu-timer.c > index d428fec567..094a20a05a 100644 > --- a/util/qemu-timer.c > +++ b/

Re: [PATCH v2 07/14] hw: Move TWL92230 device from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > The TWL92230 is an "energy management device" companion with > a RTC. Since we mostly model the RTC, move it under the hw/rtc/ > subdirectory. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS

Re: [PATCH 2/3] event_notifier: avoid dandling file descriptor in event_notifier_cleanup

2019-10-24 Thread Laurent Vivier
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > If rfd is equal to wfd the file descriptor is closed but > rfd will still have the closed value. > The EventNotifier structure should not be used again after calling > event_notifier_cleanup or should be initialized again but make > sure to not hav

Re: [PATCH v2 06/14] hw: Move sun4v hypervisor RTC from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > Move RTC devices under the hw/rtc/ subdirectory. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 4 ++-- > hw/rtc/Kconfig| 3 +++ > hw/rtc/Makefile.objs

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Laine Stump
On 10/23/19 5:15 PM, Alex Williamson wrote: On Wed, 23 Oct 2019 22:31:37 +0200 Jens Freimann wrote: On Wed, Oct 23, 2019 at 02:02:11PM -0600, Alex Williamson wrote: On Wed, 23 Oct 2019 21:30:35 +0200 Jens Freimann wrote: On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote: O

Re: [PATCH 1/3] util/async: avoid useless cast

2019-10-24 Thread Laurent Vivier
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > event_notifier_dummy_cb is already compatible with EventNotifierHandler. > > Signed-off-by: Frediano Ziglio > --- > util/async.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/async.c b/util/async.c > index ca83e32c7f..b1fa5319e5

Re: [PATCH v2 0/3] Convert sparc devices to new ptimer API

2019-10-24 Thread Philippe Mathieu-Daudé
On 10/24/19 8:04 PM, Mark Cave-Ayland wrote: On 24/10/2019 13:19, Peter Maydell wrote: On Mon, 21 Oct 2019 at 14:43, Peter Maydell wrote: This patchset converts the devices used by sparc machines to the new ptimer API. Currently the ptimer design uses a QEMU bottom-half as its mechanism for

Re: [PATCH v2 04/14] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > The M48T59 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: delete include/hw/timer/m48t59.h (dgibson) > --- > MAINTAINERS

[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol

2019-10-24 Thread Daniel Berrange
It isn't mandatory to use a standardized subprotocol, all that's required is that the client & server agree https://developer.mozilla.org/en- US/docs/Web/HTTP/Protocol_upgrade_mechanism "The subprotocols may be selected from the IANA WebSocket Subprotocol Name Registry or may be a custom name

Re: [PATCH v2 00/14] hw: Split RTC devices from hw/timer/ to hw/rtc/

2019-10-24 Thread Philippe Mathieu-Daudé
On 10/24/19 7:36 PM, Laurent Vivier wrote: On 24/10/2019 17:51, Peter Maydell wrote: On Fri, 4 Oct 2019 at 00:04, Philippe Mathieu-Daudé wrote: Since v1: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03334.html - addressed review comments (described in patches 3 and 4) - added R-b/

Re: [PATCH v2 03/14] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > The MC146818 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Use copyright statement from 80cabfad163 for "hw/rtc/mc146818rtc.h". > > Reviewed-by: Alistair Francis > Acked-by: David Gibson > Signed-off-by

[PATCH v6 7/9] virtio: add property to enable packed virtqueue

2019-10-24 Thread Eugenio Pérez
From: Jason Wang Signed-off-by: Jason Wang Reviewed-by: Jens Freimann --- include/hw/virtio/virtio.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index d123d5b181..40ddeafadb 100644 --- a/include/hw/virtio/virtio

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-24 Thread John Snow
On 10/23/19 4:17 AM, Kevin Wolf wrote: > The important difference here is legacy IDE (which works) vs. AHCI > (which doesn't work). If you add a -device ahci to the -M pc case, it > starts failing, too. > > Not sure why AHCI fails, but I'll just CC John who is the lucky > maintainer of this dev

Re: [PATCH v2 02/14] hw: Move PL031 device from hw/timer/ to hw/rtc/ subdirectory

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > The PL031 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 4 ++-- > Makefile.objs

[PATCH v6 4/9] virtio: basic packed virtqueue support

2019-10-24 Thread Eugenio Pérez
From: Jason Wang This patch implements basic support for the packed virtqueue. Compare the split virtqueue which has three rings, packed virtqueue only have one which is supposed to have better cache utilization and more hardware friendly. Please refer virtio specification for more information.

Re: [PATCH v2 01/14] hw/timer: Compile devices not target-dependent as common object

2019-10-24 Thread Laurent Vivier
Le 04/10/2019 à 01:03, Philippe Mathieu-Daudé a écrit : > All these devices do not contain any target-specific. While most > of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > endianess, ...). > Put them into common-obj-

  1   2   3   4   5   6   7   >