[Qemu-devel] [PULL 36/38] spapr/irq: initialize the IRQ device only once

2019-05-20 Thread David Gibson
From: Cédric Le Goater Add a check to make sure that the routine initializing the emulated IRQ device is called once. We don't have much to test on the XICS side, so we introduce a 'init' boolean under ICSState. Signed-off-by: Cédric Le Goater Message-Id: <20190513084245.25755-13-...@kaod.org>

[Qemu-devel] [PULL 31/38] spapr/xive: activate KVM support

2019-05-20 Thread David Gibson
From: Cédric Le Goater All is in place for KVM now. State synchronization and migration will come next. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson Message-Id: <20190513084245.25755-8-...@kaod.org> Signed-off-by: David Gibson --- hw/ppc/spapr_irq.c | 9 - 1 file changed

[Qemu-devel] [PULL 35/38] spapr/irq: introduce a spapr_irq_init_device() helper

2019-05-20 Thread David Gibson
From: Cédric Le Goater The way the XICS and the XIVE devices are initialized follows the same pattern. First, try to connect to the KVM device and if not possible fallback on the emulated device, unless a kernel_irqchip is required. The spapr_irq_init_device() routine implements this sequence in

[Qemu-devel] [PULL 38/38] spapr/irq: add KVM support to the 'dual' machine

2019-05-20 Thread David Gibson
From: Cédric Le Goater The interrupt mode is chosen by the CAS negotiation process and activated after a reset to take into account the required changes in the machine. This brings new constraints on how the associated KVM IRQ device is initialized. Currently, each model takes care of the initia

[Qemu-devel] [PATCH v6 2/2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-20 Thread Wei Yang
build_append_foo() API doesn't need explicit endianness conversions which eliminates a source of errors and it makes build_mcfg() look like declarative definition of MCFG table in ACPI spec, which makes it easy to review. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mamm

[Qemu-devel] [PULL 23/38] spapr: Fix phb_placement backwards compatibility

2019-05-20 Thread David Gibson
When we added support for NVLink2 passthrough devices, we changed the phb_placement hook to handle the placement of NVLink2 bridges' specific resources. For compatibility we use a version that doesn't do this allocation for old machine types. However, because of the delay between when the patch

[Qemu-devel] [PULL 37/38] ppc/xics: fix irq priority in ics_set_irq_type()

2019-05-20 Thread David Gibson
From: Cédric Le Goater Recent commits changed the behavior of ics_set_irq_type() to initialize correctly LSIs at the KVM level. ics_set_irq_type() is also called by the realize routine of the different devices of the machine when initial interrupts are claimed, before the ICSState device is reset

[Qemu-devel] [PULL 32/38] sysbus: add a sysbus_mmio_unmap() helper

2019-05-20 Thread David Gibson
From: Cédric Le Goater This will be used to remove the MMIO regions of the POWER9 XIVE interrupt controller when the sPAPR machine is reseted. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson Message-Id: <20190513084245.25755-9-...@kaod.org> Signed-off-by: David Gibson --- hw/core/s

[Qemu-devel] [PULL 16/38] Fix typo on "info pic" monitor cmd output for xive

2019-05-20 Thread David Gibson
From: Satheesh Rajendran Instead of LISN i.e "Logical Interrupt Source Number" as per Xive PAPR document "info pic" prints as LSIN, let's fix it. Signed-off-by: Satheesh Rajendran Message-Id: <20190509080750.21999-1-sathn...@linux.vnet.ibm.com> Reviewed-by: Greg Kurz Reviewed-by: Cédric Le Goa

[Qemu-devel] [PULL 22/38] target/ppc: Use vector variable shifts for VSL, VSR, VSRA

2019-05-20 Thread David Gibson
From: Richard Henderson The gvec expanders take care of masking the shift amount against the element width. Signed-off-by: Richard Henderson Message-Id: <20190518191430.21686-2-richard.hender...@linaro.org> Signed-off-by: David Gibson --- target/ppc/helper.h | 12 -- t

[Qemu-devel] [PULL 33/38] spapr: introduce routines to delete the KVM IRQ device

2019-05-20 Thread David Gibson
From: Cédric Le Goater If a new interrupt mode is chosen by CAS, the machine generates a reset to reconfigure. At this point, the connection with the previous KVM device needs to be closed and a new connection needs to opened with the KVM device operating the chosen interrupt mode. New routines

[Qemu-devel] [PULL 28/38] spapr/xive: add state synchronization with KVM

2019-05-20 Thread David Gibson
From: Cédric Le Goater This extends the KVM XIVE device backend with 'synchronize_state' methods used to retrieve the state from KVM. The HW state of the sources, the KVM device and the thread interrupt contexts are collected for the monitor usage and also migration. These get operations rely on

[Qemu-devel] [PATCH v6 1/2] hw/acpi: Consolidate build_mcfg to pci.c

2019-05-20 Thread Wei Yang
Now we have two identical build_mcfg functions. Consolidate them in acpi/pci.c. Signed-off-by: Wei Yang v4: * ACPI_PCI depends on both ACPI and PCI * rebase on latest master, adjust arm Kconfig v3: * adjust changelog based on Igor's suggestion --- default-configs/i386-softmmu.mak | 1 +

[Qemu-devel] [PULL 27/38] spapr/xive: add hcall support when under KVM

2019-05-20 Thread David Gibson
From: Cédric Le Goater XIVE hcalls are all redirected to QEMU as none are on a fast path. When necessary, QEMU invokes KVM through specific ioctls to perform host operations. QEMU should have done the necessary checks before calling KVM and, in case of failure, H_HARDWARE is simply returned. H_I

[Qemu-devel] [PULL 30/38] spapr/xive: add migration support for KVM

2019-05-20 Thread David Gibson
From: Cédric Le Goater When the VM is stopped, the VM state handler stabilizes the XIVE IC and marks the EQ pages dirty. These are then transferred to destination before the transfer of the device vmstates starts. The SpaprXive interrupt controller model captures the XIVE internal tables, EAT an

[Qemu-devel] [PULL 24/38] spapr: Print out extra hints when CAS negotiation of interrupt mode fails

2019-05-20 Thread David Gibson
From: Greg Kurz Let's suggest to the user how the machine should be configured to allow the guest to boot successfully. Suggested-by: Satheesh Rajendran Signed-off-by: Greg Kurz Message-Id: <155799221739.527449.14907564571096243745.st...@bahia.lan> Reviewed-by: Satheesh Rajendran Tested-by: S

[Qemu-devel] [PULL 11/38] target/ppc: Fix vsum2sws

2019-05-20 Thread David Gibson
From: Anton Blanchard A recent cleanup changed the pre zeroing of the result from 64 bit to 32 bit operations: -result.u64[i] = 0; +result.VsrW(i) = 0; This corrupts the result. Fixes: 60594fea298d ("target/ppc: remove various HOST_WORDS_BIGENDIAN hacks in int_helper.c") Signe

[Qemu-devel] [PATCH v6 0/2] Extract build_mcfg Part 2

2019-05-20 Thread Wei Yang
This patch set tries to generalize MCFG table build process. Several patches are already merged and these two are left for the following reasons: * conflict with latest upstream * ACPI_PCI dependency fix * missed reserved[8] in MCFG v4->v5: * ACPI_PCI depends on both ACPI and PCI *

[Qemu-devel] [PULL 14/38] spapr/xive: fix EQ page addresses above 64GB

2019-05-20 Thread David Gibson
From: Cédric Le Goater The high order bits of the address of the OS event queue is stored in bits [4-31] of word2 of the XIVE END internal structures and the low order bits in word3. This structure is using Big Endian ordering and computing the value requires some simple arithmetic which happens

[Qemu-devel] [PULL 29/38] spapr/xive: introduce a VM state change handler

2019-05-20 Thread David Gibson
From: Cédric Le Goater This handler is in charge of stabilizing the flow of event notifications in the XIVE controller before migrating a guest. This is a requirement before transferring the guest EQ pages to a destination. When the VM is stopped, the handler sets the source PQs to PENDING to st

[Qemu-devel] [PULL 09/38] target/ppc: Fix xxbrq, xxbrw

2019-05-20 Thread David Gibson
From: Anton Blanchard Fix a typo in xxbrq and xxbrw where we put both results into the lower doubleword. Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() helpers for VSR register access") Signed-off-by: Anton Blanchard Message-Id: <20190507004811.29968-3-an...@ozlabs.o

[Qemu-devel] [PULL 10/38] target/ppc: Fix vslv and vsrv

2019-05-20 Thread David Gibson
From: Anton Blanchard vslv and vsrv are broken on little endian, we append 00 to the high byte not the low byte. Fix it by using the VsrB() accessor. Signed-off-by: Anton Blanchard Message-Id: <20190507004811.29968-6-an...@ozlabs.org> Signed-off-by: David Gibson --- target/ppc/int_helper.c |

[Qemu-devel] [PULL 15/38] spapr/xive: print out the EQ page address in the monitor

2019-05-20 Thread David Gibson
From: Cédric Le Goater This proved to be a useful information when debugging issues with OS event queues allocated above 64GB. Signed-off-by: Cédric Le Goater Message-Id: <20190508171946.657-4-...@kaod.org> Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/intc/spapr_xive.c | 5 +++--

[Qemu-devel] [PULL 17/38] target/ppc: Optimise VSX_LOAD_SCALAR_DS and VSX_VECTOR_LOAD_STORE

2019-05-20 Thread David Gibson
From: Anton Blanchard A few small optimisations: In VSX_LOAD_SCALAR_DS() we can don't need to read the VSR via get_cpu_vsrh(). Split VSX_VECTOR_LOAD_STORE() into two functions. Loads only need to write the VSRs (set_cpu_vsr*()) and stores only need to read the VSRs (get_cpu_vsr*()) Thanks to M

[Qemu-devel] [PULL 07/38] target/ppc: Add ibm, purr and ibm, spurr device-tree properties

2019-05-20 Thread David Gibson
From: Suraj Jitindar Singh The ibm,purr and ibm,spurr device tree properties are used to indicate that the processor implements the Processor Utilisation of Resources Register (PURR) and Scaled Processor Utilisation of Resources Registers (SPURR), respectively. Each property has a single value wh

[Qemu-devel] [PULL 13/38] spapr/xive: EQ page should be naturally aligned

2019-05-20 Thread David Gibson
From: Cédric Le Goater When the OS configures the EQ page in which to receive event notifications from the XIVE interrupt controller, the page should be naturally aligned. Add this check. Signed-off-by: Cédric Le Goater Message-Id: <20190508171946.657-2-...@kaod.org> Reviewed-by: Greg Kurz [dw

[Qemu-devel] [PULL 20/38] target/ppc: Set PSSCR_EC on cpu halt to prevent spurious wakeup

2019-05-20 Thread David Gibson
From: Suraj Jitindar Singh The processor stop status and control register (PSSCR) is used to control the power saving facilities of the thread. The exit criterion bit (EC) is used to specify whether the thread should be woken by any interrupt (EC == 0) or only an interrupt enabled in the LPCR to

[Qemu-devel] [PULL 19/38] spapr/xive: Sanity checks of OV5 during CAS

2019-05-20 Thread David Gibson
From: Greg Kurz If a machine is started with ic-mode=xive but the guest only knows about XICS, eg. an RHEL 7.6 guest, the kernel panics. This is expected but a bit unfortunate since the crash doesn't provide much information for the end user to guess what's happening. Detect that during CAS and

[Qemu-devel] [PULL 12/38] target/ppc: Fix xxspltib

2019-05-20 Thread David Gibson
From: Anton Blanchard xxspltib raises a VMX or a VSX exception depending on the register set it is operating on. We had a check, but it was backwards. Fixes: f113283525a4 ("target-ppc: add xxspltib instruction") Signed-off-by: Anton Blanchard Message-Id: <20190509061713.69490488@kryten> Signed-

[Qemu-devel] [PULL 08/38] target/ppc: Fix xvxsigdp

2019-05-20 Thread David Gibson
From: Anton Blanchard Fix a typo in xvxsigdp where we put both results into the lower doubleword. Fixes: dd977e4f45cb ("target/ppc: Optimize x[sv]xsigdp using deposit_i64()") Signed-off-by: Anton Blanchard Message-Id: <20190507004811.29968-1-an...@ozlabs.org> Signed-off-by: David Gibson --- t

[Qemu-devel] [PULL 18/38] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p

2019-05-20 Thread David Gibson
From: Anton Blanchard We were using set_cpu_vsr*() when we should have used get_cpu_vsr*(). Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() helpers for VSR register access") Signed-off-by: Anton Blanchard Message-Id: <20190509104912.6b754dff@kryten> Reviewed-by: Mark

[Qemu-devel] [PULL 06/38] hw/ppc/40p: use 1900 as a base year

2019-05-20 Thread David Gibson
From: Artyom Tarasenko AIX 5.1 expects the base year to be 1900. Adjust accordingly. Signed-off-by: Artyom Tarasenko Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190505152839.18650-4-phi...@redhat.com> Signed-off-by: David Gibson --- hw/ppc/prep.c | 4 +++- 1 file changed, 3 insertio

[Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190521

2019-05-20 Thread David Gibson
The following changes since commit 2259637b95bef3116cc262459271de08e038cc66: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-05-20 17:22:05 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190521 for you t

[Qemu-devel] [PULL 02/38] configure: Distinguish ppc64 and ppc64le hosts

2019-05-20 Thread David Gibson
From: Richard Henderson We cannot use the ppc64le host compiler to build ppc64(be) guest code. Clean up confusion between cross_cc_powerpc and cross_cc_ppc; make use of the cflags variable as well. Signed-off-by: Richard Henderson Message-Id: <20190501223819.8584-2-richard.hender...@linaro.org>

[Qemu-devel] [PULL 04/38] hw/ppc/prep: use TYPE_MC146818_RTC instead of a hardcoded string

2019-05-20 Thread David Gibson
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190505152839.18650-2-phi...@redhat.com> Signed-off-by: David Gibson --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index b7f459d475..ebee321148

[Qemu-devel] [PULL 05/38] hw/ppc/40p: Move the MC146818 RTC to the board where it belongs

2019-05-20 Thread David Gibson
From: Philippe Mathieu-Daudé The MC146818 RTC was incorrectly added to the i82378 chipset in commit a04ff940974a. In the next commit (506b7ddf8893) the PReP machine use the i82378. Since the MC146818 is specific to the PReP machine, move its use there. Fixes: a04ff940974a Signed-off-by: Philippe

[Qemu-devel] [PULL 03/38] configure: Use quotes around uses of $CPU_CFLAGS

2019-05-20 Thread David Gibson
From: Richard Henderson About half of the values to which CPU_CFLAGS is set have multiple space separated arguments. Signed-off-by: Richard Henderson Message-Id: <20190501223819.8584-3-richard.hender...@linaro.org> Signed-off-by: David Gibson --- configure | 16 1 file change

[Qemu-devel] [PULL 01/38] target/ppc/kvm: Fix trace typo

2019-05-20 Thread David Gibson
From: Boxuan Li Signed-off-by: Boxuan Li Message-Id: <20190430172842.27369-1-libox...@connect.hku.hk> Signed-off-by: David Gibson --- target/ppc/kvm.c| 2 +- target/ppc/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm

Re: [Qemu-devel] [PATCH v5 2/2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-20 Thread Wei Yang
On Mon, May 20, 2019 at 11:44:28PM -0400, Michael S. Tsirkin wrote: >On Tue, May 21, 2019 at 11:32:49AM +0800, Wei Yang wrote: >> build_append_foo() API doesn't need explicit endianness conversions >> which eliminates a source of errors and it makes build_mcfg() look like >> declarative definition

[Qemu-devel] [PATCH] kvm: support guest access CORE cstate

2019-05-20 Thread Wanpeng Li
From: Wanpeng Li Allow guest reads CORE cstate when exposing host CPU power management capabilities to the guest. PKG cstate is restricted to avoid a guest to get the whole package information in multi-tenant scenario. Cc: Eduardo Habkost Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by:

[Qemu-devel] [Bug 1829498] Re: window 8 stuck during boot on Qemu

2019-05-20 Thread arseniy
My host kernel is 4.15.0-47. Windows 8 version is 6.3.9600. About KVM, i've got same problem in TCG mode. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1829498 Title: window 8 stuck during boot on

Re: [Qemu-devel] [PATCH v9 02/27] gdbstub: Implement deatch (D pkt) with new infra

2019-05-20 Thread Jon Doron
Hi Alex, I implemented this change but i'm having second guesses on this, basically a NULL packet means the command is not supported (as far as i understand from the protocol documentation and implementation of GDB) That being said I think it's correct to send back a NULL packet if process_string_c

Re: [Qemu-devel] [PATCH v5 2/2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-20 Thread Michael S. Tsirkin
On Tue, May 21, 2019 at 11:32:49AM +0800, Wei Yang wrote: > build_append_foo() API doesn't need explicit endianness conversions > which eliminates a source of errors and it makes build_mcfg() look like > declarative definition of MCFG table in ACPI spec, which makes it easy > to review. > > Signed

Re: [Qemu-devel] [PATCH v5 2/2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-20 Thread Michael S. Tsirkin
On Tue, May 21, 2019 at 11:32:49AM +0800, Wei Yang wrote: > build_append_foo() API doesn't need explicit endianness conversions > which eliminates a source of errors and it makes build_mcfg() look like > declarative definition of MCFG table in ACPI spec, which makes it easy > to review. > > Signed

Re: [Qemu-devel] [PATCH v5 1/2] hw/acpi: Consolidate build_mcfg to pci.c

2019-05-20 Thread Michael S. Tsirkin
On Tue, May 21, 2019 at 11:32:48AM +0800, Wei Yang wrote: > Now we have two identical build_mcfg functions. > > Consolidate them in acpi/pci.c. > > Signed-off-by: Wei Yang > > --- > v5: > * ACPI_PCI depends on both ACPI and PCI > * rebase on latest master, adjust arm Kconfig > v3: > * adj

[Qemu-devel] [PATCH v5 2/2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-20 Thread Wei Yang
build_append_foo() API doesn't need explicit endianness conversions which eliminates a source of errors and it makes build_mcfg() look like declarative definition of MCFG table in ACPI spec, which makes it easy to review. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mamm

[Qemu-devel] [PATCH v5 1/2] hw/acpi: Consolidate build_mcfg to pci.c

2019-05-20 Thread Wei Yang
Now we have two identical build_mcfg functions. Consolidate them in acpi/pci.c. Signed-off-by: Wei Yang --- v5: * ACPI_PCI depends on both ACPI and PCI * rebase on latest master, adjust arm Kconfig v3: * adjust changelog based on Igor's suggestion --- default-configs/i386-softmmu.mak |

[Qemu-devel] [PATCH v5 0/2] Extract build_mcfg Part 2

2019-05-20 Thread Wei Yang
This patch set tries to generalize MCFG table build process. Several patches are already merged and these two are left for the following reasons: * conflict with latest upstream * ACPI_PCI dependency fix * missed reserved[8] in MCFG v4->v5: * ACPI_PCI depends on both ACPI and PCI *

Re: [Qemu-devel] [PATCH] ftgmac100: do not link to netdev

2019-05-20 Thread Jason Wang
On 2019/5/21 上午2:11, Cédric Le Goater wrote: qdev_set_nic_properties() is already used in the Aspeed SoC level to bind the ftgmac100 device to the netdev. This is fixing support for multiple net devices. Signed-off-by: Cédric Le Goater --- hw/net/ftgmac100.c | 2 -- 1 file changed, 2 dele

Re: [Qemu-devel] [PATCH v5 0/6] Extract build_mcfg

2019-05-20 Thread Wei Yang
On Mon, May 20, 2019 at 06:55:53PM -0400, Michael S. Tsirkin wrote: >On Mon, May 20, 2019 at 08:59:51AM +0800, Wei Yang wrote: >> This patch set tries to generalize MCFG table build process. And it is >> based on one un-merged patch from Igor, which is included in this serials. >> >> v4->v5: >>

Re: [Qemu-devel] [PATCH v3 8/8] multifd: rest of zlib compression

2019-05-20 Thread Wei Yang
On Wed, May 15, 2019 at 02:15:44PM +0200, Juan Quintela wrote: >This is still a work in progress, but get everything sent as expected >and it is faster than the code that is already there. Generally, I prefer to merge this one with previous one. > >Signed-off-by: Juan Quintela >--- > migration/r

Re: [Qemu-devel] [PATCH v3 7/8] multifd: Add zlib compression support

2019-05-20 Thread Wei Yang
On Wed, May 15, 2019 at 02:15:43PM +0200, Juan Quintela wrote: >Signed-off-by: Juan Quintela >--- > hw/core/qdev-properties.c | 2 +- > migration/migration.c | 9 > migration/migration.h | 1 + > migration/ram.c | 47 +++ > qapi/migrati

Re: [Qemu-devel] [PATCH v3 6/8] migration: Make none operations into its own structure

2019-05-20 Thread Wei Yang
On Wed, May 15, 2019 at 02:15:42PM +0200, Juan Quintela wrote: >+ >+MultifdMethods multifd_none_ops = { >+.send_prepare = none_send_prepare, >+.send_write = none_send_write, >+.recv_pages = none_recv_pages >+}; >+ > static int multifd_send_initial_packet(MultiFDSendParams *p, Error **er

Re: [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm"

2019-05-20 Thread Peter Xu
On Mon, May 20, 2019 at 11:30:01AM -0500, Eric Blake wrote: > On 5/19/19 10:08 PM, Peter Xu wrote: > > Expose the new capability via "query-kvm" QMP command too so we know > > whether that's turned on on the source VM when we want. > > > > Signed-off-by: Peter Xu > > --- > > accel/kvm/kvm-all.c

Re: [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG

2019-05-20 Thread Peter Xu
On Mon, May 20, 2019 at 12:50:24PM +0200, Paolo Bonzini wrote: > On 20/05/19 05:08, Peter Xu wrote: > > +s->manual_dirty_log_protect = > > +kvm_check_extension(s, KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2); > > +if (s->manual_dirty_log_protect) { > > +ret = kvm_vm_enable_cap(s, KVM_

Re: [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener

2019-05-20 Thread Peter Xu
On Mon, May 20, 2019 at 12:49:39PM +0200, Paolo Bonzini wrote: > On 20/05/19 05:08, Peter Xu wrote: > > +/* Must be with slots_lock held */ > > Perhaps "Called with KVMMemoryListener slots_lock held."? Yes sounds better. I'm replacing the old comments with "Called with KVMMemoryListener.slots_lo

Re: [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap

2019-05-20 Thread Peter Xu
On Mon, May 20, 2019 at 12:48:01PM +0200, Paolo Bonzini wrote: > On 20/05/19 05:08, Peter Xu wrote: > > cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as > > parameter, which means that it must be with RCU read lock held > > already. Taking it again inside seems redundant. Removing it.

Re: [Qemu-devel] [PATCH v2 0/5] fw_cfg_test refactor and add two test cases

2019-05-20 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年5月21日周二 上午5:29写道: > Hi Li, > > On 5/17/19 4:28 AM, Li Qiang wrote: > > Ping. > > > > Li Qiang mailto:liq...@gmail.com>> 于2019年5月9日周四 > > 下午5:57写道: > > > > Ping this serials. > > I apologize I hold this series for too long. > With your v1 I wanted to clarif

Re: [Qemu-devel] [PATCH 1/2] target/ppc: Use vector variable shifts for VSL, VSR, VSRA

2019-05-20 Thread Richard Henderson
On 5/20/19 2:49 AM, Aleksandar Markovic wrote: > > On May 18, 2019 9:21 PM, "Richard Henderson" > wrote: >> >> The gvec expanders take care of masking the shift amount >> against the element width. >> >> Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v4 00/14] spapr: add KVM support to the XIVE interrupt mode

2019-05-20 Thread David Gibson
On Mon, May 13, 2019 at 10:42:31AM +0200, Cédric Le Goater wrote: > Hello, > > This is the v4 of the QEMU/KVM patchset. > > The first patches introduce the XIVE KVM device, state synchronization > and migration support under KVM. The second part of the patchset > modifies the XICS and XIVE interr

Re: [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm"

2019-05-20 Thread Peter Xu
On Mon, May 20, 2019 at 12:44:29PM +0200, Paolo Bonzini wrote: > On 20/05/19 05:08, Peter Xu wrote: > > Expose the new capability via "query-kvm" QMP command too so we know > > whether that's turned on on the source VM when we want. > > > > Signed-off-by: Peter Xu > > Is this useful? We could I

[Qemu-devel] [PATCH 2/4] BootLinuxConsoleTest: Test nanoMIPS kernels on the I7200 CPU

2019-05-20 Thread Philippe Mathieu-Daudé
Similar to the x86_64/pc test, it boots a Linux kernel on a Malta machine and verify the serial is working. Use the documentation added in commit f7d257cb4a17 to test nanoMIPS kernels and the I7200 CPU. This test can be run using: $ avocado --show=console run -t arch:mipsel tests/acceptance/b

[Qemu-devel] [PATCH 3/4] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta

2019-05-20 Thread Philippe Mathieu-Daudé
This tests boots a Linux kernel on a Malta machine up to a busybox shell on the serial console. Few commands are executed before halting the machine (via reboot). We use the initrd cpio image from the kerneltests project: https://kerneltests.org/ If MIPS is a target being built, "make check-accep

[Qemu-devel] [PATCH 4/4] BootLinuxSshTest: Test some userspace commands on Malta

2019-05-20 Thread Philippe Mathieu-Daudé
This tests boot a full VM and check the serial console until the SSH daemon is running, then start a SSH session and run some commands. This test can be run using: $ avocado --show=ssh run -t arch:mips tests/acceptance/linux_ssh_mips_malta.py ssh: Entering interactive session. ssh: # uname

[Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-20 Thread Philippe Mathieu-Daudé
Hi, It was a rainy week-end here, so I invested it to automatize some of my MIPS tests. The BootLinuxSshTest is not Global warming friendly, it is not meant to run on a CI system but rather on a workstation previous to post a pull request. It can surely be improved, but it is a good starting poin

[Qemu-devel] [PATCH 1/4] BootLinuxConsoleTest: Let extract_from_deb handle various compressions

2019-05-20 Thread Philippe Mathieu-Daudé
Debian binary package format supports various compressions. Per man deb(5): NAME deb - Debian binary package format FORMAT ... The third, last required member is named data.tar. It contains the filesystem as a tar archive, either not compressed (supported since dpkg 1.10

[Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-20 Thread Michael S. Tsirkin
The following changes since commit 2259637b95bef3116cc262459271de08e038cc66: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-05-20 17:22:05 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

Re: [Qemu-devel] QMP Example Formatting in ReST, Sphinx, and Pygments (was: Re: [Bug] Docs build fails at interop.rst)

2019-05-20 Thread Eduardo Habkost
On Mon, May 20, 2019 at 05:25:28PM -0400, John Snow wrote: > > > On 5/20/19 12:37 PM, John Snow wrote: > > > > > > On 5/20/19 7:30 AM, Aarushi Mehta wrote: > >> https://paste.fedoraproject.org/paste/kOPx4jhtUli---TmxSLrlw > >> running python3-sphinx-2.0.1-1.fc31.noarch on Fedora release 31 > >>

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-20 Thread Michael S. Tsirkin
On Thu, May 16, 2019 at 07:00:33PM +0200, Igor Mammedov wrote: > On Thu, 16 May 2019 13:01:31 +0200 > Philippe Mathieu-Daudé wrote: > > > On Thu, May 16, 2019 at 9:41 AM Wei Yang > > wrote: > > > > > > On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: > > > > > > > >Than

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-20 Thread Michael S. Tsirkin
On Thu, May 16, 2019 at 08:33:13PM +0200, Philippe Mathieu-Daudé wrote: > On 5/16/19 6:04 PM, Peter Maydell wrote: > > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin wrote: > >> > >> The following changes since commit > >> efb4f3b62c69383a7308d7b739a3193e7c0ccae8: > >> > >> Merge remote-track

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-20 Thread Michael S. Tsirkin
On Thu, May 16, 2019 at 05:04:42PM +0100, Peter Maydell wrote: > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin wrote: > > > > The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: > > > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > > into

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-05-20 Thread Alex Williamson
On Fri, 17 May 2019 14:58:16 +0200 Jens Freimann wrote: > This is another attempt at implementing the host side of the > net_failover concept > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) > > Changes since last RFC: > - work around circular dependency of commandline opt

Re: [Qemu-devel] [PATCH v5 0/6] Extract build_mcfg

2019-05-20 Thread Michael S. Tsirkin
On Mon, May 20, 2019 at 08:59:51AM +0800, Wei Yang wrote: > This patch set tries to generalize MCFG table build process. And it is > based on one un-merged patch from Igor, which is included in this serials. > > v4->v5: > * ACPI_PCI depends on both ACPI and PCI > * rebase on latest master,

Re: [Qemu-devel] [PATCH v2 2/2] iotests: test external snapshot with bitmap copying

2019-05-20 Thread John Snow
On 5/20/19 3:47 AM, Vladimir Sementsov-Ogievskiy wrote: > 18.05.2019 4:31, John Snow wrote: >> >> >> On 5/17/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >>> This test shows that external snapshots and incremental backups are >>> friends. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas

2019-05-20 Thread Richard Henderson
On Mon, May 20, 2019, 08:17 Alex Bennée wrote: > > Jan Bobek writes: > > > This allows us to drop dependency on NASM and build the test image > > with GCC only. Adds support for x86_64, too. > > ./risu --master -t run.out test_i386.bin > > and then: > > ./risu -t run.out test_i386.bin > > Gi

Re: [Qemu-devel] [PATCH] blockdev: loosen restrictions on drive-backup source node

2019-05-20 Thread John Snow
On 5/10/19 5:11 PM, John Snow wrote: > We mandate that the source node must be a root node; but there's no reason > I am aware of that it needs to be restricted to such. In some cases, we need > to make sure that there's a medium present, but in the general case we can > allow the backup job its

Re: [Qemu-devel] [PATCH 2/2] BootLinuxConsoleTest: Test the SmartFusion2 board

2019-05-20 Thread Alistair Francis
On Mon, May 20, 2019 at 3:09 PM Philippe Mathieu-Daudé wrote: > > Similar to the x86_64/pc test, it boots a Linux kernel on an > Emcraft board and verify the serial is working. > > If ARM is a target being built, "make check-acceptance" will > automatically include this test by the use of the "arc

Re: [Qemu-devel] [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines

2019-05-20 Thread Alistair Francis
On Mon, May 20, 2019 at 3:07 PM Philippe Mathieu-Daudé wrote: > > Avoid to log empty lines in console debug logs. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > tests/acceptance/boot_linux_console.py | 6 -- > 1 file changed, 4 insertions(+), 2 d

Re: [Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup

2019-05-20 Thread John Snow
On 5/13/19 11:06 AM, John Snow wrote: > If the bitmap can't be used for whatever reason, we skip putting down > the reference. Fix that. > > In practice, this means that if you attempt to gracefully exit QEMU > after a backup command being rejected, bdrv_close_all will fail and > tell you some

[Qemu-devel] [Bug 1829498] Re: window 8 stuck during boot on Qemu

2019-05-20 Thread John Snow
What host kernel are you using? This sounds like a bug we used to have in KVM a while ago. Maybe it's back. The same problem was also alleviated by a guest driver update, are you using the initial release of Windows 8? -- You received this bug notification because you are a member of qemu- devel

[Qemu-devel] [PATCH 2/2] BootLinuxConsoleTest: Test the SmartFusion2 board

2019-05-20 Thread Philippe Mathieu-Daudé
Similar to the x86_64/pc test, it boots a Linux kernel on an Emcraft board and verify the serial is working. If ARM is a target being built, "make check-acceptance" will automatically include this test by the use of the "arch:arm" tags. Alternatively, this test can be run using: $ avocado run

[Qemu-devel] [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines

2019-05-20 Thread Philippe Mathieu-Daudé
Avoid to log empty lines in console debug logs. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index d5c500

[Qemu-devel] [PATCH 0/2] tests: Avocado-test for the SmartFusion2 board

2019-05-20 Thread Philippe Mathieu-Daudé
Hi, I added test guide lines from Subbaraya Sundeep [*] to avoid this board to bitrot. Regards, Phil. [*] https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg03810.html Philippe Mathieu-Daudé (2): BootLinuxConsoleTest: Do not log empty lines BootLinuxConsoleTest: Test the SmartFusion2

Re: [Qemu-devel] [PATCHv2 2/3] RISC-V: Only Check PMP if MMU translation succeeds

2019-05-20 Thread Alistair Francis
On Sat, May 18, 2019 at 6:36 PM Hesham Almatary wrote: > > The current implementation unnecessarily checks for PMP even if MMU > translation > failed. This may trigger a wrong PMP access exception instead of > a page exception. > > For example, the very first instruction fetched after the first s

Re: [Qemu-devel] [PATCHv2 1/3] RISC-V: Raise access fault exceptions on PMP violations

2019-05-20 Thread Alistair Francis
On Sat, May 18, 2019 at 6:35 PM Hesham Almatary wrote: > > Section 3.6 in RISC-V v1.10 privilege specification states that PMP violations > report "access exceptions." The current PMP implementation has > a bug which wrongly reports "page exceptions" on PMP violations. > > This patch fixes this bu

Re: [Qemu-devel] [PATCH v3 05/10] hw/riscv: Replace global smp variables with machine smp properties

2019-05-20 Thread Alistair Francis
On Sun, May 19, 2019 at 5:56 AM Like Xu wrote: > > The global smp variables in riscv are replaced with smp machine properties. > > A local variable of the same name would be introduced in the declaration > phase if it's used widely in the context OR replace it on the spot if it's > only used once.

Re: [Qemu-devel] [PATCH 2/4] hw/arm/exynos4: Use the IEC binary prefix definitions

2019-05-20 Thread Alistair Francis
On Mon, May 20, 2019 at 2:48 PM Philippe Mathieu-Daudé wrote: > > It eases code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/exynos4_boards.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH 1/4] hw/arm/exynos4: Remove unuseful debug code

2019-05-20 Thread Alistair Francis
On Mon, May 20, 2019 at 2:45 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/exynos4_boards.c | 24 > 1 file changed, 24 deletions(-) > > diff --git a/hw/arm/exynos4_boards.c b/hw/arm/ex

[Qemu-devel] [PATCH 4/4] hw/arm/exynos4210: QOM'ify the Exynos4210 SoC

2019-05-20 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 26 +++--- hw/arm/exynos4_boards.c | 9 ++--- include/hw/arm/exynos4210.h | 9 +++-- 3 files changed, 36 insertions(+), 8 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c

[Qemu-devel] [PATCH 2/4] hw/arm/exynos4: Use the IEC binary prefix definitions

2019-05-20 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4_boards.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c index f0c24b7992e..f824eef0d36 100644 --- a/hw/arm/exynos4_boards.c

[Qemu-devel] [PATCH 0/4] arm: exynos4: Add dma support for smdkc210

2019-05-20 Thread Philippe Mathieu-Daudé
Another intent to salvage previous work from Guenter Roeck: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06302.html Since v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06674.html - rebased - QOM'ify the SoC code Since v2: https://lists.gnu.org/archive/html/qemu-devel/20

[Qemu-devel] [PATCH v3 5/7] hw/nvram/fw_cfg: Store 'reboot-timeout' as little endian

2019-05-20 Thread Philippe Mathieu-Daudé
From: Li Qiang The current codebase is not specific about the endianess of the fw_cfg 'file' entry 'reboot-timeout'. Per docs/specs/fw_cfg.txt: === All Other Data Items === Please consult the QEMU source for the most up-to-date and authoritative list of selector keys and their respective

[Qemu-devel] [PATCH 1/4] hw/arm/exynos4: Remove unuseful debug code

2019-05-20 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4_boards.c | 24 1 file changed, 24 deletions(-) diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c index ea8100f65a8..f0c24b7992e 100644 --- a/hw/arm/exynos4_boards.c +++ b/hw/arm/exynos4_boards.c @@ -35

[Qemu-devel] [PATCH 3/4] hw/arm/exynos4210: Add DMA support for the Exynos4210

2019-05-20 Thread Philippe Mathieu-Daudé
From: Guenter Roeck QEMU already supports pl330. Instantiate it for Exynos4210. Relevant part of Linux arch/arm/boot/dts/exynos4.dtsi: / { soc: soc { amba { pdma0: pdma@1268 { compatible = "arm,pl330", "arm,primecell"; reg = <0x1268000

[Qemu-devel] [PATCH v3 3/7] tests: refactor fw_cfg_test

2019-05-20 Thread Philippe Mathieu-Daudé
From: Li Qiang Currently, fw_cfg_test uses one QTestState for every test case. This will add all command lines for every test case and this is unnecessary. This patch split the test cases and for every test case it uses his own QTestState. This patch does following things: 1. Get rid of the glob

[Qemu-devel] [PATCH v3 7/7] tests: fw_cfg: add 'splash-time' test case

2019-05-20 Thread Philippe Mathieu-Daudé
From: Li Qiang Signed-off-by: Li Qiang Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190424140643.62457-6-liq...@163.com> Signed-off-by: Philippe Mathieu-Daudé --- tests/fw_cfg-test.c | 20 1 file changed, 20

[Qemu-devel] [PATCH v3 6/7] tests: fw_cfg: add 'reboot-timeout' test case

2019-05-20 Thread Philippe Mathieu-Daudé
From: Li Qiang Signed-off-by: Li Qiang Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190424140643.62457-5-liq...@163.com> Signed-off-by: Philippe Mathieu-Daudé --- tests/fw_cfg-test.c | 21 + 1 file changed, 2

[Qemu-devel] [PATCH v3 2/7] tests/libqos: Add pc_fw_cfg_uninit() and use it

2019-05-20 Thread Philippe Mathieu-Daudé
The pc_fw_cfg_init() function allocates an IO QFWCFG object. Add the pc_fw_cfg_uninit() function to deallocate it (and use it). Signed-off-by: Li Qiang Tested-by: Thomas Huth Message-Id: <20190424140643.62457-2-liq...@163.com> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daud

[Qemu-devel] [PATCH v3 4/7] tests: fw_cfg: add a function to get the fw_cfg file

2019-05-20 Thread Philippe Mathieu-Daudé
From: Li Qiang This is useful to write qtest about fw_cfg file entry. Signed-off-by: Li Qiang Acked-by: Thomas Huth Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190424140643.62457-3-liq...@163.com> Signed-off-by: Philippe Mathie

[Qemu-devel] [PATCH v3 1/7] tests/libqos: Add io_fw_cfg_uninit() and mm_fw_cfg_uninit()

2019-05-20 Thread Philippe Mathieu-Daudé
The mm_fw_cfg_init() allocates a QFWCFG object, add mm_fw_cfg_uninit() to deallocate it. Similarly with io_fw_cfg_init(), add io_fw_cfg_uninit(). Signed-off-by: Li Qiang Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190424140643.624

  1   2   3   4   >