On Mon, May 20, 2019 at 12:50:24PM +0200, Paolo Bonzini wrote: > On 20/05/19 05:08, Peter Xu wrote: > > + s->manual_dirty_log_protect = > > + kvm_check_extension(s, KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2); > > + if (s->manual_dirty_log_protect) { > > + ret = kvm_vm_enable_cap(s, KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2, 0, > > 1); > > + if (ret) { > > + warn_report("Trying to enable KVM_CAP_MANUAL_DIRTY_LOG_PROTECT > > " > > Please use KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 in the error too (and in > the commit message).
Oops I did miss these, actually I also noticed some commit messages that mentioned the wrong capability name and I'll change them too (e.g., in patch 8 where the new memory API is introduced). Thanks, -- Peter Xu