Re: [Qemu-devel] [PATCH 1/4] ptr_ring: port ptr_ring from linux kernel to QEMU

2018-10-17 Thread Xiao Guangrong
On 10/17/2018 04:14 PM, Paolo Bonzini wrote: On 16/10/2018 18:40, Emilio G. Cota wrote: +#define SMP_CACHE_BYTES 64 +#define cacheline_aligned_in_smp \ +__attribute__((__aligned__(SMP_CACHE_BYTES))) You could use QEMU_ALIGNED() here. Yes, you are right. + +#define WRIT

[Qemu-devel] [PATCH] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read return type demotion

2018-10-17 Thread Dayeol Lee
There is a data type demotion bug in target/riscv/pmp.c When the target_ulong is 8 bytes, pmpcfg_csr_read returns only lower 4 bytes. --- target/riscv/pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index c828950..4b6c20e 100644 ---

[Qemu-devel] [PATCH] replay: don't process events at virtual clock checkpoint

2018-10-17 Thread Pavel Dovgalyuk
As QEMU becomes more multi-threaded and non-synchronized, checkpoints move from thread to thread. And the event queue that processed at checkpoints should belong to the same thread in both record and replay executions. This patch disables asynchronous event processing at virtual clock checkpoint, b

Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call"

2018-10-17 Thread Pavel Dovgalyuk
I made a fix to ensure that QBox patch doesn’t break the replay. Now I tried it on couple of tests and didn’t see any regression. Pavel Dovgalyuk From: Artem Pisarenko [mailto:artem.k.pisare...@gmail.com] Sent: Wednesday, October 17, 2018 4:32 PM To: Pavel Dovgalyuk Cc: Paolo Bonzini; Cle

[Qemu-devel] [Bug 1798434] Re: [Feature Request] Automatic device configuration discovery

2018-10-17 Thread Thomas Huth
Right, and since QEMU also only supports a limited set of devices, there is no chance that you can mirror an arbitrary host this way. But if you want to convert a host into a VM and do not care whether each and every detail can be mirrored, have a look at http://libguestfs.org/virt- p2v.1.html - th

Re: [Qemu-devel] [PULL 2/7] tests/migration: Enable the migration test on s390x, too

2018-10-17 Thread Thomas Huth
On 2018-10-17 21:28, Emilio G. Cota wrote: > On Thu, Oct 11, 2018 at 20:25:08 +0100, Dr. David Alan Gilbert (git) wrote: >> From: Thomas Huth >> >> We can re-use the s390-ccw bios code to implement a small firmware >> for a s390x guest which prints out the "A" and "B" characters and >> modifies th

Re: [Qemu-devel] [PATCH v2 1/3] qemu-iotests: Modern shellscripting (use $() instead of ``)

2018-10-17 Thread Eric Blake
On 10/17/18 10:17 PM, Mao Zhongyi wrote: Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. `pwd` and `basename $0` are in 231 files under directory tests/qemu-iotests, so replaced it with the following: sed -i 's/`pwd`/$(p

Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call"

2018-10-17 Thread Clement Deschamps
Hi all, I'm traveling right now, but as soon as I get home, I'll send my patch with the signed-off. Best, Clément On 10/17/18 7:43 AM, Paolo Bonzini wrote: > On 17/10/2018 15:20, Pavel Dovgalyuk wrote: >> I found the source of the bug. As QEMU becomes more multi-threaded >> and non-synchronize

[Qemu-devel] [PATCH v2 0/3] Modern shell scripting (use $() instead of ``)

2018-10-17 Thread Mao Zhongyi
Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. On https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02920.html I just replaced `` in scripts dir, so this series is a thorough cleanup of all obsolete `` in the sou

[Qemu-devel] [PATCH v2 1/3] qemu-iotests: Modern shellscripting (use $() instead of ``)

2018-10-17 Thread Mao Zhongyi
Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. `pwd` and `basename $0` are in 231 files under directory tests/qemu-iotests, so replaced it with the following: sed -i 's/`pwd`/$(pwd)/g' $(git grep -l "\`pwd\`") sed -i 's/`

[Qemu-devel] [PATCH v2 3/3] po/Makefile: Modern shell scripting (use $() instead of ``)

2018-10-17 Thread Mao Zhongyi
Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. Cc: phi...@redhat.com Cc: peter.mayd...@linaro.org Cc: th...@redhat.com Cc: s...@weilnetz.de Signed-off-by: Mao Zhongyi Signed-off-by: Thomas Huth --- po/Makefile | 2 +-

[Qemu-devel] [PATCH v2 2/3] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``)

2018-10-17 Thread Mao Zhongyi
Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. Cc: alex.ben...@linaro.org Cc: f...@redhat.com Cc: phi...@redhat.com Signed-off-by: Mao Zhongyi --- tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++-- 1 file changed,

Re: [Qemu-devel] [RFC PATCH v1 0/4] Add migration support for VFIO device

2018-10-17 Thread Tian, Kevin
> From: Kirti Wankhede > Sent: Wednesday, October 17, 2018 2:13 AM > > Add migration support for VFIO device > > This Patch set include patches as below: > - Define KABI for VFIO device for migration support. > - Generic migration functionality for VFIO device. > * This patch set adds functiona

Re: [Qemu-devel] [PATCH 3/3] po/Makefile: Modern shell scripting (use $() insteadof ``)

2018-10-17 Thread maozy
On 10/17/18 5:54 PM, Thomas Huth wrote: On 2018-10-17 11:44, Mao Zhongyi wrote: Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. Cc: phi...@redhat.com Cc: peter.mayd...@linaro.org Cc: th...@redhat.com Cc: s...@weilnetz

[Qemu-devel] [PATCH] qga: fix an off-by-one issue

2018-10-17 Thread Li Qiang
Signed-off-by: Li Qiang --- qga/commands-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 98d9735..e3842d1 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -465,7 +465,7 @@ static STORAGE_BUS_TYPE win2qemu

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 07:17:25PM -0400, Cleber Rosa wrote: > > > On 10/17/18 6:12 PM, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 04:54:52PM -0400, Cleber Rosa wrote: > >> > >> > >> On 10/17/18 3:48 PM, Eduardo Habkost wrote: > >>> On Wed, Oct 17, 2018 at 03:25:34PM -0400, Cleber Rosa wr

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 06:47:41PM -0400, Cleber Rosa wrote: > > > On 10/17/18 6:15 PM, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 04:59:25PM -0400, Cleber Rosa wrote: > >> On 10/17/18 4:46 PM, Murilo Opsfelder Araujo wrote: > > [...] > >>> Then avocado could multiplex these variants file

Re: [Qemu-devel] [RFC PATCH v1 1/4] VFIO KABI for migration interface

2018-10-17 Thread Gonglei (Arei)
> -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On > Behalf Of Kirti Wankhede > Sent: Thursday, October 18, 2018 4:47 AM > To: Alex Williamson > Cc: c...@nvidia.com; qemu-devel@nongnu.org; k...@vger.kernel.org; Yulei > Zhang ; Dr. David Alan Gilbe

Re: [Qemu-devel] [PATCH v2 2/2] virtio-pmem: Add virtio pmem driver

2018-10-17 Thread Pankaj Gupta
> > > > > > > On Fri, Oct 12, 2018 at 10:01 PM Pankaj Gupta wrote: > > > > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > > > Guest reads the persistent memory range information from > > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > > > creates a nd_regi

Re: [Qemu-devel] [PATCH] target/arm : add pvpanic mmio device

2018-10-17 Thread peng.hao2
>Hi Peng, > >On 17/10/2018 11:23, Peng Hao wrote: >> Add pvpanic mmio device that is similar to x86's pvpanic device. > >> >> Signed-off-by: Peng Hao >> --- >> default-configs/arm-softmmu.mak | 2 +- >> hw/arm/virt.c | 21 >> hw/misc/Makefile.objs | 1 +

Re: [Qemu-devel] [PULL] First RISC-V Patch Set for the 3.1 Soft Freeze

2018-10-17 Thread Palmer Dabbelt
On Wed, 17 Oct 2018 16:32:10 PDT (-0700), ebl...@redhat.com wrote: On 10/17/18 4:54 PM, Palmer Dabbelt wrote: The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into staging (2018-10-16

Re: [Qemu-devel] [PULL] First RISC-V Patch Set for the 3.1 Soft Freeze

2018-10-17 Thread Eric Blake
On 10/17/18 4:54 PM, Palmer Dabbelt wrote: The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into staging (2018-10-16 17:42:56 +0100) are available in the Git repository at: git:/

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 6:12 PM, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 04:54:52PM -0400, Cleber Rosa wrote: >> >> >> On 10/17/18 3:48 PM, Eduardo Habkost wrote: >>> On Wed, Oct 17, 2018 at 03:25:34PM -0400, Cleber Rosa wrote: On 10/17/18 3:09 PM, Eduardo Habkost wrote: > On Wed

Re: [Qemu-devel] [RFC PATCH v1 1/4] VFIO KABI for migration interface

2018-10-17 Thread Alex Williamson
On Thu, 18 Oct 2018 02:17:19 +0530 Kirti Wankhede wrote: > On 10/17/2018 4:04 AM, Alex Williamson wrote: > > On Tue, 16 Oct 2018 23:42:35 +0530 > > Kirti Wankhede wrote: > > > >> - Added vfio_device_migration_info structure to use interact with vendor > >> driver. > >> - Different flags are

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 6:15 PM, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 04:59:25PM -0400, Cleber Rosa wrote: >> On 10/17/18 4:46 PM, Murilo Opsfelder Araujo wrote: > [...] >>> Then avocado could multiplex these variants file and call >>> ./tests/acceptance/run >>> for each value of qemu_bin. `ru

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 04:59:25PM -0400, Cleber Rosa wrote: > On 10/17/18 4:46 PM, Murilo Opsfelder Araujo wrote: [...] > > Then avocado could multiplex these variants file and call > > ./tests/acceptance/run > > for each value of qemu_bin. `run` script could skip and return if $qemu_bin > > doe

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 04:54:52PM -0400, Cleber Rosa wrote: > > > On 10/17/18 3:48 PM, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 03:25:34PM -0400, Cleber Rosa wrote: > >> > >> > >> On 10/17/18 3:09 PM, Eduardo Habkost wrote: > >>> On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell

[Qemu-devel] [PULL 3/5] RISC-V: Update CSR and interrupt definitions

2018-10-17 Thread Palmer Dabbelt
From: Michael Clark * Add user-mode CSR defininitions. * Reorder CSR definitions to match the specification. * Change H mode interrupt comment to 'reserved'. * Remove unused X_COP interrupt. * Add user-mode interrupts. * Remove erroneous until comments on machine mode interrupts. * Move together

[Qemu-devel] [PULL 5/5] RISC-V: Don't add NULL bootargs to device-tree

2018-10-17 Thread Palmer Dabbelt
From: Michael Clark Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Palmer Dabbelt Signed-off-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- hw/riscv/sifive_u.c | 4 +++- hw/riscv/spike.c| 6 -- hw/riscv/virt.c

[Qemu-devel] [PULL 1/5] RISC-V: Allow setting and clearing multiple irqs

2018-10-17 Thread Palmer Dabbelt
From: Michael Clark Change the API of riscv_set_local_interrupt to take a write mask and value to allow setting and clearing of multiple local interrupts atomically in a single call. Rename the new function to riscv_cpu_update_mip. Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Rev

[Qemu-devel] [PULL 2/5] RISC-V: Move non-ops from op_helper to cpu_helper

2018-10-17 Thread Palmer Dabbelt
From: Michael Clark This patch makes op_helper.c contain only instruction operation helpers used by translate.c and moves any unrelated cpu helpers into cpu_helper.c. No logic is changed by this patch. Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Dau

[Qemu-devel] [PULL] First RISC-V Patch Set for the 3.1 Soft Freeze

2018-10-17 Thread Palmer Dabbelt
The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into staging (2018-10-16 17:42:56 +0100) are available in the Git repository at: git://github.com/riscv/riscv-qemu.git tags/riscv-for

[Qemu-devel] [PULL 4/5] RISC-V: Add missing free for plic_hart_config

2018-10-17 Thread Palmer Dabbelt
From: Michael Clark Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Palmer Dabbelt Signed-off-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/riscv/vi

[Qemu-devel] [PATCH v3 4/4] hw/arm: versal: Add a virtual Xilinx Versal board

2018-10-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a virtual Xilinx Versal board. This board is based on the Xilinx Versal SoC. The exact details of what peripherals are attached to this board will remain in control of QEMU. QEMU will generate an FDT on the fly for Linux and other software to auto-discover periphera

[Qemu-devel] [PATCH v3 3/4] hw/arm: versal: Add a model of Xilinx Versal SoC

2018-10-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a model of Xilinx Versal SoC. Signed-off-by: Edgar E. Iglesias --- default-configs/aarch64-softmmu.mak | 1 + hw/arm/Makefile.objs| 1 + hw/arm/xlnx-versal.c| 324 include/hw/arm/xlnx-versal.h

[Qemu-devel] [PATCH v3 2/4] net: cadence_gem: Announce 64bit addressing support

2018-10-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Announce 64bit addressing support. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 16a8455128..d95cc27f58 1

[Qemu-devel] [PATCH v3 1/4] net: cadence_gem: Announce availability of priority queues

2018-10-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Announce the availability of the various priority queues. This fixes an issue where guest kernels would miss to configure secondary queues due to inproper feature bits. Signed-off-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 8 +++- 1 file changed, 7 insertion

[Qemu-devel] [PATCH v3 0/4] arm: Add first models of Xilinx Versal SoC

2018-10-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This patch series adds initial support for Xilinx's Versal SoC. Xilinx is introducing Versal, an adaptive compute acceleration platform (ACAP), built on 7nm FinFET process technology. Versal ACAPs combine Scalar Processing Engines, Adaptable Hardware Engines, and Intelli

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 5:16 PM, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 05:33:30PM -0300, Wainer dos Santos Moschetta wrote: >> >> On 10/17/2018 05:05 PM, Eduardo Habkost wrote: >>> On Wed, Oct 17, 2018 at 04:43:15PM -0300, Murilo Opsfelder Araujo wrote: On Wed, Oct 17, 2018 at 07:40:51PM +01

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 05:10:18PM -0400, Cleber Rosa wrote: > > > On 10/17/18 4:33 PM, Wainer dos Santos Moschetta wrote: > > > > On 10/17/2018 05:05 PM, Eduardo Habkost wrote: > >> On Wed, Oct 17, 2018 at 04:43:15PM -0300, Murilo Opsfelder Araujo wrote: > >>> On Wed, Oct 17, 2018 at 07:40:51PM

Re: [Qemu-devel] [RFC PATCH v1 1/4] VFIO KABI for migration interface

2018-10-17 Thread Kirti Wankhede
On 10/17/2018 3:39 PM, Dr. David Alan Gilbert wrote: > * Kirti Wankhede (kwankh...@nvidia.com) wrote: >> - Added vfio_device_migration_info structure to use interact with vendor >> driver. >> - Different flags are used to get or set migration related information >> from/to vendor driver. >>

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 05:33:30PM -0300, Wainer dos Santos Moschetta wrote: > > On 10/17/2018 05:05 PM, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 04:43:15PM -0300, Murilo Opsfelder Araujo wrote: > > > On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: > > > > On 17 October 20

Re: [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4

2018-10-17 Thread Richard Henderson
On 10/17/18 1:25 PM, Aaron Lindsay wrote: > I suppose pmcrn (the local variable) should've been set to 0 before this > patch and updated here to be 4. That's plausible. > Anyway, by splitting these patches apart, my intention was to separate > the plumbing work from turning on the water. If you b

Re: [Qemu-devel] [PATCH v6 11/14] target/arm: PMU: Add instruction and cycle events

2018-10-17 Thread Richard Henderson
On 10/17/18 12:47 PM, Aaron Lindsay wrote: > On Oct 16 17:04, Richard Henderson wrote: >> On 10/10/18 1:37 PM, Aaron Lindsay wrote: >>> + * Return the underlying cycle count for the PMU cycle counters. If we're >>> in >>> + * usermode, simply return 0. >>> + */ >>> +static uint64_t cycles_get_coun

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 4:33 PM, Wainer dos Santos Moschetta wrote: > > On 10/17/2018 05:05 PM, Eduardo Habkost wrote: >> On Wed, Oct 17, 2018 at 04:43:15PM -0300, Murilo Opsfelder Araujo wrote: >>> On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: On 17 October 2018 at 18:38, Cleber Rosa

Re: [Qemu-devel] [RFC PATCH v1 2/4] Add migration functions for VFIO devices

2018-10-17 Thread Kirti Wankhede
On 10/17/2018 2:30 PM, Cornelia Huck wrote: > On Tue, 16 Oct 2018 23:42:36 +0530 > Kirti Wankhede wrote: > >> - Migration function are implemented for VFIO_DEVICE_TYPE_PCI device. >> - Added SaveVMHandlers and implemented all basic functions required for live >> migration. >> - Added VM stat

[Qemu-devel] [PATCH] bt: use size_t type for length parameters instead of signed int

2018-10-17 Thread P J P
From: Prasad J Pandit The length parameter values are not negative, thus use an unsigned type 'size_t' for them. Many routines pass 'len' values to memcpy(3) calls. If it was negative, it could lead to memory corruption issues. Reported-by: Arash TC Signed-off-by: Prasad J Pandit --- bt-host.

Re: [Qemu-devel] [RFC PATCH v1 0/4] Add migration support for VFIO device

2018-10-17 Thread Kirti Wankhede
On 10/17/2018 2:19 PM, Cornelia Huck wrote: > On Tue, 16 Oct 2018 23:42:34 +0530 > Kirti Wankhede wrote: > >> Add migration support for VFIO device > > I'd love to take a deeper look at this; but sadly, I'm currently low on > spare time, and therefore will only add some general remarks. > T

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 4:46 PM, Murilo Opsfelder Araujo wrote: > On Wed, Oct 17, 2018 at 04:09:51PM -0300, Eduardo Habkost wrote: >> On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: >>> On 17 October 2018 at 18:38, Cleber Rosa wrote: On 10/17/18 12:29 PM, Eduardo Habkost wrote

Re: [Qemu-devel] [PATCH] macio/pmu: Fix missing vmsd terminator

2018-10-17 Thread Mark Cave-Ayland
On 17/10/2018 01:34, David Gibson wrote: > On Tue, Oct 16, 2018 at 12:30:45PM +0100, Dr. David Alan Gilbert wrote: >> >> I noticed this hadn't got merged - who wants it? > > I think that's one for my tree, but I'm afraid I completely missed it > before. It's generally best to CC me on ppc relate

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 3:48 PM, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 03:25:34PM -0400, Cleber Rosa wrote: >> >> >> On 10/17/18 3:09 PM, Eduardo Habkost wrote: >>> On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: On 17 October 2018 at 18:38, Cleber Rosa wrote: > > >>>

[Qemu-devel] [Bug 1793275] Re: Hosts fail to start after update to QEMU 3.0

2018-10-17 Thread Neil Darlow
Archlinux have released qemu-headless-3.0.0-3 which includes a backported patch for virtio. I have tested this version and the problem still persists. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/179

Re: [Qemu-devel] [RFC PATCH v1 1/4] VFIO KABI for migration interface

2018-10-17 Thread Kirti Wankhede
On 10/17/2018 4:04 AM, Alex Williamson wrote: > On Tue, 16 Oct 2018 23:42:35 +0530 > Kirti Wankhede wrote: > >> - Added vfio_device_migration_info structure to use interact with vendor >> driver. >> - Different flags are used to get or set migration related information >> from/to vendor dr

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Murilo Opsfelder Araujo
On Wed, Oct 17, 2018 at 04:09:51PM -0300, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: > > On 17 October 2018 at 18:38, Cleber Rosa wrote: > > > > > > > > > On 10/17/18 12:29 PM, Eduardo Habkost wrote: > > >> On Wed, Oct 17, 2018 at 01:34:41PM +0100, Pete

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Wainer dos Santos Moschetta
On 10/17/2018 05:05 PM, Eduardo Habkost wrote: On Wed, Oct 17, 2018 at 04:43:15PM -0300, Murilo Opsfelder Araujo wrote: On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: On 17 October 2018 at 18:38, Cleber Rosa wrote: On 10/17/18 12:29 PM, Eduardo Habkost wrote: On Wed, Oct 1

Re: [Qemu-devel] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions

2018-10-17 Thread Eric Blake
On 10/2/18 6:08 PM, John Snow wrote: John Snow (6): block/dirty-bitmaps: add user_locked status checker block/dirty-bitmaps: fix merge permissions block/dirty-bitmaps: allow clear on disabled bitmaps block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps block/backu

Re: [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4

2018-10-17 Thread Aaron Lindsay
On Oct 17 12:34, Richard Henderson wrote: > On 10/17/18 12:20 PM, Aaron Lindsay wrote: > > On Oct 16 17:09, Richard Henderson wrote: > >> On 10/10/18 1:37 PM, Aaron Lindsay wrote: > >>> This both advertises that we support four counters and enables them > >>> because the pmu_num_counters() reads th

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 04:43:15PM -0300, Murilo Opsfelder Araujo wrote: > On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: > > On 17 October 2018 at 18:38, Cleber Rosa wrote: > > > > > > > > > On 10/17/18 12:29 PM, Eduardo Habkost wrote: > > >> On Wed, Oct 17, 2018 at 01:34:41PM +01

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 03:25:34PM -0400, Cleber Rosa wrote: > > > On 10/17/18 3:09 PM, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: > >> On 17 October 2018 at 18:38, Cleber Rosa wrote: > >>> > >>> > >>> On 10/17/18 12:29 PM, Eduardo Habkost wrote: >

Re: [Qemu-devel] [PATCH v6 11/14] target/arm: PMU: Add instruction and cycle events

2018-10-17 Thread Aaron Lindsay
On Oct 16 17:04, Richard Henderson wrote: > On 10/10/18 1:37 PM, Aaron Lindsay wrote: > > + * Return the underlying cycle count for the PMU cycle counters. If we're > > in > > + * usermode, simply return 0. > > + */ > > +static uint64_t cycles_get_count(CPUARMState *env) > > +{ > > +#ifndef CONFIG

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Murilo Opsfelder Araujo
On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: > On 17 October 2018 at 18:38, Cleber Rosa wrote: > > > > > > On 10/17/18 12:29 PM, Eduardo Habkost wrote: > >> On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote: > >>> So, why does the test code need to care? It's not clea

Re: [Qemu-devel] [PATCH v2 2/2] virtio-pmem: Add virtio pmem driver

2018-10-17 Thread Dan Williams
On Wed, Oct 17, 2018 at 12:11 PM Pankaj Gupta wrote: > > > > > On Fri, Oct 12, 2018 at 10:01 PM Pankaj Gupta wrote: > > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > Guest reads the persistent memory range information from > > > Qemu over VIRTIO and registers it on nvdimm_

Re: [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4

2018-10-17 Thread Richard Henderson
On 10/17/18 12:20 PM, Aaron Lindsay wrote: > On Oct 16 17:09, Richard Henderson wrote: >> On 10/10/18 1:37 PM, Aaron Lindsay wrote: >>> This both advertises that we support four counters and enables them >>> because the pmu_num_counters() reads this value from PMCR. >>> >>> Signed-off-by: Aaron Lin

Re: [Qemu-devel] [PATCH v6 1/3] Bootstrap Python venv for tests

2018-10-17 Thread Wainer dos Santos Moschetta
On 10/17/2018 01:05 PM, Cleber Rosa wrote: A number of QEMU tests are written in Python, and may benefit from an untainted Python venv. By using make rules, tests that depend on specific Python libs can set that rule as a requirement, along with rules that require the presence or installation

Re: [Qemu-devel] [PULL 2/7] tests/migration: Enable the migration test on s390x, too

2018-10-17 Thread Emilio G. Cota
On Thu, Oct 11, 2018 at 20:25:08 +0100, Dr. David Alan Gilbert (git) wrote: > From: Thomas Huth > > We can re-use the s390-ccw bios code to implement a small firmware > for a s390x guest which prints out the "A" and "B" characters and > modifies the memory, as required for the migration test. >

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 3:09 PM, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: >> On 17 October 2018 at 18:38, Cleber Rosa wrote: >>> >>> >>> On 10/17/18 12:29 PM, Eduardo Habkost wrote: On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote: > So,

[Qemu-devel] [Bug 1798451] [NEW] HVF linux on OSX hangs 2nd time started after adding socket

2018-10-17 Thread Rob Maskell
Public bug reported: Robs-MacBook-Pro-2:~ robmaskell$ qemu-system-x86_64 --version QEMU emulator version 3.0.0 Host: MacOS - 10.13.6 Model Name: MacBook Pro Model Identifier: MacBookPro14,3 Processor Name: Intel Core i7 Processor Speed: 2.8 GHz Number of Processors: 1

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Peter Maydell
On 17 October 2018 at 20:05, Cleber Rosa wrote: > > > On 10/17/18 2:40 PM, Peter Maydell wrote: >> At that level, I think the right answer is "tell the user >> they need to specify the qemu executable they are trying to test". >> In particular, there is no guarantee that the user has actually >> b

Re: [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4

2018-10-17 Thread Aaron Lindsay
On Oct 16 17:09, Richard Henderson wrote: > On 10/10/18 1:37 PM, Aaron Lindsay wrote: > > This both advertises that we support four counters and enables them > > because the pmu_num_counters() reads this value from PMCR. > > > > Signed-off-by: Aaron Lindsay > > --- > > target/arm/helper.c | 8 ++

Re: [Qemu-devel] No more chameleon devices (was: [PATCH] virtio: Provide version-specific variants of virtio PCI devices)

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 12:38:29PM -0400, Michael S. Tsirkin wrote: > On Wed, Oct 17, 2018 at 12:56:37PM -0300, Eduardo Habkost wrote: > > (CCing Marcel, in case he has extra details on the complex > > Conventional/Express bus/device plugging rules) > > > > On Wed, Oct 17, 2018 at 07:57:39AM +0200

Re: [Qemu-devel] [PATCH v2 2/2] virtio-pmem: Add virtio pmem driver

2018-10-17 Thread Pankaj Gupta
> On Fri, Oct 12, 2018 at 10:01 PM Pankaj Gupta wrote: > > > > This patch adds virtio-pmem driver for KVM guest. > > > > Guest reads the persistent memory range information from > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > creates a nd_region object with the persistent memor

Re: [Qemu-devel] [PATCH v3 9/9] block: Make auto-read-only=on default for -drive

2018-10-17 Thread Eric Blake
On 10/17/18 11:42 AM, Kevin Wolf wrote: While we want machine interfaces like -blockdev and QMP blockdev-add to add as little auto-detection as possible so that management tools are explicit about their needs, -drive is a convenience option for human users. Enabling auto-read-only=on by default t

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 07:40:51PM +0100, Peter Maydell wrote: > On 17 October 2018 at 18:38, Cleber Rosa wrote: > > > > > > On 10/17/18 12:29 PM, Eduardo Habkost wrote: > >> On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote: > >>> So, why does the test code need to care? It's not clea

Re: [Qemu-devel] [PATCH v3 5/9] file-posix: Support auto-read-only option

2018-10-17 Thread Eric Blake
On 10/17/18 11:41 AM, Kevin Wolf wrote: If read-only=off, but auto-read-only=on is given, open the file read-write if we have the permissions, but instead of erroring out for read-only files, just degrade to read-only. Signed-off-by: Kevin Wolf --- block/file-posix.c | 19 ---

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 2:40 PM, Peter Maydell wrote: > On 17 October 2018 at 18:38, Cleber Rosa wrote: >> >> >> On 10/17/18 12:29 PM, Eduardo Habkost wrote: >>> On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote: So, why does the test code need to care? It's not clear from the patch..

Re: [Qemu-devel] [PATCH v3 3/9] block: Require auto-read-only for existing fallbacks

2018-10-17 Thread Eric Blake
On 10/17/18 11:41 AM, Kevin Wolf wrote: Some block drivers have traditionally changed their node to read-only mode without asking the user. This behaviour has been marked deprecated since 2.11, expecting users to provide an explicit read-only=on option. Now that we have auto-read-only=on, enable

[Qemu-devel] [Bug 1798434] Re: [Feature Request] Automatic device configuration discovery

2018-10-17 Thread Peter Maydell
This is occasionally asked for but unfortunately not in the general case possible. Device trees contain enough information for a guest OS to use the hardware; they do not contain a full description of how the hardware is actually configured and connected together, and they don't say anything about

Re: [Qemu-devel] [PATCH v3 2/9] block: Add auto-read-only option

2018-10-17 Thread Eric Blake
On 10/17/18 11:41 AM, Kevin Wolf wrote: If a management application builds the block graph node by node, the protocol layer doesn't inherit its read-only option from the format layer any more, so it must be set explicitly. The documentation for this option is consciously phrased in a way that

Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd)

2018-10-17 Thread Sebastian Andrzej Siewior
On 2018-10-17 20:40:17 [+0200], Paolo Bonzini wrote: > It's queued for my next pull request. thanks. > Paolo Sebastian

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Peter Maydell
On 17 October 2018 at 18:38, Cleber Rosa wrote: > > > On 10/17/18 12:29 PM, Eduardo Habkost wrote: >> On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote: >>> So, why does the test code need to care? It's not clear >>> from the patch... My expectation would be that you'd >>> just test al

Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd)

2018-10-17 Thread Paolo Bonzini
On 17/10/2018 20:12, Sebastian Andrzej Siewior wrote: > On 2018-09-28 11:54:11 [-0300], Eduardo Habkost wrote: >> On Fri, Sep 28, 2018 at 12:43:19PM +0200, Sebastian Andrzej Siewior wrote: >>> Intel SDM says for CPUID function 0DH, sub-function 0: >>> >>> | • ECX enumerates the size (in bytes) requ

Re: [Qemu-devel] [Qemu-block] [PATCH v3 7/9] gluster: Support auto-read-only option

2018-10-17 Thread Niels de Vos
On Wed, Oct 17, 2018 at 06:41:58PM +0200, Kevin Wolf wrote: > If read-only=off, but auto-read-only=on is given, open the file > read-write if we have the permissions, but instead of erroring out for > read-only files, just degrade to read-only. > > Signed-off-by: Kevin Wolf > --- > block/gluster

[Qemu-devel] [Bug 1798434] [NEW] [Feature Request] Automatic device configuration discovery

2018-10-17 Thread Ryan Govostes
Public bug reported: Would it be possible to have a script that enumerates the device tree of a Linux host and generates a qemu command line that would recreate it under emulation? The user would have to customize the arguments (for instance to point to disk image files), but it would take a lot o

Re: [Qemu-devel] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions

2018-10-17 Thread John Snow
On 10/17/2018 02:24 PM, Eric Blake wrote: > On 10/2/18 6:02 PM, John Snow wrote: >> based on: jsnow/bitmaps staging branch >> >> This series builds on a previous standalone patch and adjusts >> the permission for all (or most) of the QMP bitmap commands. >> >> V4: >>   - Replace "in-use" with "i

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 10:54 AM, Wainer dos Santos Moschetta wrote: > Hello Cleber! > > On 10/16/2018 08:22 PM, Cleber Rosa wrote: >> The host arch name is not always the target arch name, so it's >> necessary to have a mapping. >> >> The configure scripts contains what is the authoritative and failproof

Re: [Qemu-devel] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions

2018-10-17 Thread Eric Blake
On 10/2/18 6:02 PM, John Snow wrote: based on: jsnow/bitmaps staging branch This series builds on a previous standalone patch and adjusts the permission for all (or most) of the QMP bitmap commands. V4: - Replace "in-use" with "in use" - Replace "user_modifiable" version with "user_locked"

Re: [Qemu-devel] [PATCH] i386: correct cpu_x86_cpuid(0xd)

2018-10-17 Thread Sebastian Andrzej Siewior
On 2018-09-28 11:54:11 [-0300], Eduardo Habkost wrote: > On Fri, Sep 28, 2018 at 12:43:19PM +0200, Sebastian Andrzej Siewior wrote: > > Intel SDM says for CPUID function 0DH, sub-function 0: > > > > | • ECX enumerates the size (in bytes) required by the XSAVE instruction > > for an > > | XSAVE

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 12:51 PM, Daniel P. Berrangé wrote: > On Wed, Oct 17, 2018 at 12:31:56PM -0400, Cleber Rosa wrote: >> >> >> On 10/17/18 8:34 AM, Peter Maydell wrote: >>> On 17 October 2018 at 00:22, Cleber Rosa wrote: The host arch name is not always the target arch name, so it's necessar

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Cleber Rosa
On 10/17/18 12:29 PM, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote: >> On 17 October 2018 at 00:22, Cleber Rosa wrote: >>> The host arch name is not always the target arch name, so it's >>> necessary to have a mapping. >>> >>> The configure scripts cont

Re: [Qemu-devel] [RFC PATCH 17/21] hmp: expose status of plugins to the monitor

2018-10-17 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Alex Bennée (alex.ben...@linaro.org) wrote: >> Signed-off-by: Alex Bennée >> --- >> hmp-commands-info.hx | 17 + >> include/qemu/plugins.h | 1 + >> monitor.c | 14 ++ >> trace/plugins.c| 15 +++

Re: [Qemu-devel] [PATCH v4 38/38] vpc: Fail open on bad header checksum

2018-10-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.10.2018 um 10:27 hat Markus Armbruster geschrieben: >> vpc_open() merely prints a warning when it finds a bad header >> checksum. Turn that into a hard error. >> >> Cc: Kevin Wolf >> Signed-off-by: Markus Armbruster >> --- >> block/vpc.c | 8 +--- >> 1 file cha

Re: [Qemu-devel] [PATCH v4 37/38] raw: Convert a warning to warn_report()

2018-10-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.10.2018 um 10:27 hat Markus Armbruster geschrieben: >> Convert the warning about dangerous automatic probing of raw images to >> warn_report(). Split its text to conform to conventions spelled out >> in warn_report()'s contract. > > One of the things the warn_report()

Re: [Qemu-devel] [PATCH v4 03/38] block: Use warn_report() & friends to report warnings

2018-10-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.10.2018 um 10:26 hat Markus Armbruster geschrieben: >> Calling error_report() in a function that takes an Error ** argument >> is suspicious. Convert a few that are actually warnings to >> warn_report(). >> >> While there, split warnings consisting of multiple sentenc

Re: [Qemu-devel] [PATCH] scripts: Remove check-qerror.sh

2018-10-17 Thread Markus Armbruster
Alberto Garcia writes: > qerror.h contains leftovers from the now-defunct QError API. > > There's only a handful of string macros left, and no one is supposed > to add anything else. The check-qerror.sh script was used to make sure > that all definitions on the qerror.c and qerror.h files were so

Re: [Qemu-devel] [PATCH V6 1/5] target/i386 : add coalesced pio support

2018-10-17 Thread Paolo Bonzini
On 17/10/2018 17:04, Vitaly Kuznetsov wrote: >> +union { >> +__u32 pad; >> +__u32 pio; >> +}; >> }; > I was just passing by, but what's the point in keeping 'pad'? > Backwards compatibility. QEMU does have a couple instances of "x.pad = 0", so... Paolo

Re: [Qemu-devel] [PATCH v6 0/3] Bootstrap Python venv and acceptance/functional tests

2018-10-17 Thread Caio Carrara
On 17-10-2018 13:05, Cleber Rosa wrote: > TL;DR > = > > Allow acceptance tests to be run with `make check-acceptance`. > > Details > === > > This introduces a Python virtual environment that will be setup within > the QEMU build directory, that will contain the exact environment that > t

Re: [Qemu-devel] QEMU hangs in main_loop_wait

2018-10-17 Thread Paolo Bonzini
On 17/10/2018 17:44, Frank Yang wrote: > > we are not seeing hangs in flatview_do_translate, but are still getting > hangs in main-loop: > >     qemu_mutex_unlock_iothread(); >     replay_mutex_unlock(); > >     ret = qemu_poll_ns((GPollFD *)gpollfds->data, gpollfds->len, > timeout); <--

[Qemu-devel] [PATCH v2 15/15] arm/xlnx-zynqmp: put APUs and RPUs in separate GDB groups

2018-10-17 Thread Luc Michel
On 10/5/18 8:49 PM, Eduardo Habkost wrote: > On Fri, Oct 05, 2018 at 03:50:01PM +0200, Philippe Mathieu-Daudé wrote: >> On 04/10/2018 23:53, Eduardo Habkost wrote: >>> On Thu, Oct 04, 2018 at 09:01:09PM +0100, Peter Maydell wrote: On 4 October 2018 at 20:52, Eduardo Habkost wrote: > Ch

Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping

2018-10-17 Thread Daniel P . Berrangé
On Wed, Oct 17, 2018 at 12:31:56PM -0400, Cleber Rosa wrote: > > > On 10/17/18 8:34 AM, Peter Maydell wrote: > > On 17 October 2018 at 00:22, Cleber Rosa wrote: > >> The host arch name is not always the target arch name, so it's > >> necessary to have a mapping. > >> > >> The configure scripts c

[Qemu-devel] [PATCH v3 1/9] block: Update flags in bdrv_set_read_only()

2018-10-17 Thread Kevin Wolf
To fully change the read-only state of a node, we must not only change bs->read_only, but also update bs->open_flags. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block.c b/block.c index 0d6

  1   2   3   4   >