On Wed, Oct 17, 2018 at 12:31:56PM -0400, Cleber Rosa wrote: > > > On 10/17/18 8:34 AM, Peter Maydell wrote: > > On 17 October 2018 at 00:22, Cleber Rosa <cr...@redhat.com> wrote: > >> The host arch name is not always the target arch name, so it's > >> necessary to have a mapping. > >> > >> The configure scripts contains what is the authoritative and failproof > >> mapping, but, reusing it is not straightforward, so it's replicated in > >> the acceptance tests supporting code. > > > > So, why does the test code need to care? It's not clear > > from the patch... My expectation would be that you'd > > just test all the testable target architectures, > > regardless of what the host architecture is. > > > > That's a good question, and now I realize that I could have given more > information on the commit message (fixing it). > > The core issue is that when running tests and a QEMU binary is not > explicitly chosen, we pick one first from the build tree (then from > system) that matches the host architecture. > > Without such a mapping, when running tests say on a host arch ppc64le, a > QEMU binary will not be found. This was first mentioned here: > > https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00865.html
The configure script knows what the matching target for this host arch is. Can you just make it set a makefile variable you can then pick up ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
