Re: [Qemu-devel] [PATCH 18/22] hw/ssi/pl022: Use DeviceState::realize rather than SysBusDevice::init

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 11:11 AM, Peter Maydell wrote: > Move from the legacy SysBusDevice::init method to using > DeviceState::realize. It would be nice to have a wiki page where each maintainer list his deprecated/legacy API and which current API to use instead (and why, some examples how to use or port,

[Qemu-devel] [Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

2018-08-20 Thread Thomas Huth
** Changed in: qemu Assignee: John Snow (jnsnow) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1681439 Title: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assert

Re: [Qemu-devel] [PATCH 16/22] hw/ssi/pl022: Set up reset function in class init

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 11:11 AM, Peter Maydell wrote: > Currently the PL022 calls pl022_reset() from its class init > function. Make it register a DeviceState reset method instead, > so that we reset the device on system reset. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > ---

Re: [Qemu-devel] [PATCH 10/22] hw/misc/iotkit: Wire up the sysctl and sysinfo register blocks

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 11:11 AM, Peter Maydell wrote: > Wire up the system control element's register banks > (sysctl and sysinfo). > > This is the last of the previously completely unimplemented > components in the IoTKit. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH 15/22] hw/ssi/pl022: Allow use as embedded-struct device

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 11:11 AM, Peter Maydell wrote: > Create a new include file for the pl022's device struct, > type macros, etc, so that it can be instantiated using > the "embedded struct" coding style. > > While we're adding the new file to MAINTAINERS, add > also the .c file, which was missing an en

[Qemu-devel] [Bug 1614521] Re: -display accepts "none[a-z, 0-9]*" instead of 'none'

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1614521 Title: -display accepts "none[a-z,0-9]*" instead of 'none' Status in QEMU:

[Qemu-devel] [PATCH] job: Fix nested aio_poll() hanging in job_txn_apply

2018-08-20 Thread Fam Zheng
All callers have acquired ctx already. Doing that again results in aio_poll() hang. This fixes the problem that a BDRV_POLL_WHILE() in the callback cannot make progress because ctx is recursively locked, for example, when drive-backup finishes. Cc: qemu-sta...@nongnu.org Reported-by: Gu Nini Sign

Re: [Qemu-devel] [PATCH 09/22] hw/misc/iotkit-sysinfo: Implement IoTKit system information block

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 11:11 AM, Peter Maydell wrote: > Implement the IoTKit system control element's system information > block; this is just a pair of read-only version/config registers, > plus the usual PID/CID ID registers. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > ---

[Qemu-devel] [Bug 1773753] Re: virsh start, after virsh managed save hangs and vm goes to paused state with qemu version v2.12.0-813-g5a5c383b13-dirty on powerpc

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1773753 Title: virsh start, after virsh managed save hangs and vm goes to paused sta

Re: [Qemu-devel] [PATCH 04/22] hw/arm/iotkit: Wire up the dualtimer

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 11:10 AM, Peter Maydell wrote: > Now we have a model of the CMSDK dual timer, we can wire it > up in the IoTKit. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > include/hw/arm/iotkit.h | 3 ++- > hw/arm/iotkit.c | 8 +--- > 2 files change

Re: [Qemu-devel] [Qemu-arm] [PATCH 05/22] hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 11:10 AM, Peter Maydell wrote: > The MPS2 FPGA images for the Cortex-M3 (mps2-an385 and mps2-511) > both include a CMSDK dual-timer module. Wire this up. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > hw/arm/mps2.c | 11 +++ > 1 file changed

[Qemu-devel] [Bug 1777969] Re: Crash with UEFI, q35, AHCI, and <= SystemRescueCD 4.3.0

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777969 Title: Crash with UEFI, q35, AHCI, and <= SystemRescueCD 4.3.0 Status in QEMU

[Qemu-devel] [Bug 1780928] Re: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780928 Title: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1755912 Title: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl Sta

[Qemu-devel] [Bug 1767176] Re: GTK build fails with qemu 2.12.0

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1767176 Title: GTK build fails with qemu 2.12.0 Status in QEMU: Fix Released Bug d

[Qemu-devel] [Bug 1781280] Re: QEMU ignores all but the first control message sent over a Unix socket

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1781280 Title: QEMU ignores all but the first control message sent over a Unix socket

[Qemu-devel] Live Migration between machines with different processor ids

2018-08-20 Thread Mjaggi Oss
Live Migration between machines with different processorIds VM Migration between machines with different processorId values throws an error in qemu/kvm. Though this check is appropriate but is overkill in cases where the two machines are of same SoC/arch family and have exactly similar core/gic bu

[Qemu-devel] [Bug 1720969] Re: qemu/memory.c:206: pointless copies of large structs ?

2018-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1720969 Title: qemu/memory.c:206: pointless copies of large structs ? Status in QEMU

Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-20 Thread Peter Xu
On Mon, Aug 20, 2018 at 05:37:55PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Aug 20, 2018 at 4:48 AM Peter Xu wrote: > > > > On Fri, Aug 17, 2018 at 03:52:20PM +0200, Marc-André Lureau wrote: > > > Hi, > > > > > > In commit 25679e5d58e "chardev: tcp: postpone async connection setup" > > >

Re: [Qemu-devel] [PATCH v2 08/10] i2c:pm_smbus: Add the ability to force block transfer enable

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 05:26 PM, miny...@acm.org wrote: > From: Corey Minyard > > The PIIX4 hardware has block transfer buffer always enabled in > the hardware, but the i801 does not. Add a parameter to pm_smbus_init > to force on the block transfer so the PIIX4 handler can enable this > by default, as i

Re: [Qemu-devel] [PATCH v2 07/10] Don't delay host status register busy bit when interrupts are enabled

2018-08-20 Thread Philippe Mathieu-Daudé
On 08/20/2018 05:26 PM, miny...@acm.org wrote: > From: Corey Minyard > > Change 880b1ffe6ec2f0ae "smbus: do not immediately complete commands" > changed pm_smbus to delay setting the host busy bit until the status > register was read, to work around a bug in AMIBIOS. Unfortunately, > when interr

Re: [Qemu-devel] [PATCH v4 04/29] dmabuf: add y0_top, pass it to spice

2018-08-20 Thread Gerd Hoffmann
On Fri, Jul 13, 2018 at 03:08:51PM +0200, Marc-André Lureau wrote: > Some scanouts during boot are top-down without it. > > y0_top is set from VHOST_USER_GPU_DMABUF_SCANOUT code path in the last > patch of this series. > > In current QEMU code base, only vfio/display uses dmabuf API. But the > VF

Re: [Qemu-devel] [PATCH v2 01/10] i2c:pm_smbus: Clean up some style issues

2018-08-20 Thread Philippe Mathieu-Daudé
Hi Corey, On 08/20/2018 05:26 PM, miny...@acm.org wrote: > From: Corey Minyard > > Fix some spacing issues, remove extraneous comments, add some > defines instead of hard-coding numbers. > > Signed-off-by: Corey Minyard > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > --- > hw/i2c/pm_smbus.c

Re: [Qemu-devel] [Bug 1787754] [NEW] qemu sparc -cpu help does not generate correct display

2018-08-20 Thread Artyom Tarasenko
On Sat, Aug 18, 2018 at 8:56 PM Donald R Laster Jr <1787...@bugs.launchpad.net> wrote: > > Public bug reported: > > The output for the "-cpu help" on the Sparc executables is not > generating accurate information. > > Running > > ./qemu-sparc64 -cpu help > > produces: > > Sparc Fujitsu Sparc64 IU

Re: [Qemu-devel] [RFC PATCH 0/5] Fix some jobs/drain/aio_poll related hangs

2018-08-20 Thread Fam Zheng
On Fri, 08/17 19:02, Kevin Wolf wrote: > I'm running out of time and will be offline for the next two weeks, so > I'm just sending out what I have right now. This is probably not ready > to be merged yet, but if need be, someone else can pick it up. Otherwise > I'll do that myself when I return. I

Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy()

2018-08-20 Thread Thomas Huth
On 2018-08-20 21:59, David Hildenbrand wrote: > On 20.08.2018 21:48, Eric Blake wrote: >> On 08/20/2018 12:16 PM, Thomas Huth wrote: >> Maybe really set it to zero (memset) before using the g_strlcpy? I am not a fan of disabling warnings, but if you think this is easier/cleaner,

Re: [Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro

2018-08-20 Thread Gerd Hoffmann
On Wed, Jul 04, 2018 at 12:39:17PM -0300, Philippe Mathieu-Daudé wrote: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/round.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir . --in-place > > Signed-off-by: Philippe Mathie

Re: [Qemu-devel] [PATCH] ui/sdl2: Fix broken -full-screen CLI option

2018-08-20 Thread Gerd Hoffmann
On Mon, Jul 09, 2018 at 08:44:10PM +0200, Thomas Huth wrote: > We've got to set the gui_fullscreen variable before creating the > SDL2 window, otherwise the initial window will not be created in > fullscreen mode. Added to ui queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 0/2] vnc: remove deprecated TLS related features

2018-08-20 Thread Gerd Hoffmann
Hi, > doc: switch to modern syntax for VNC TLS setup > vnc: remove support for deprecated tls, x509, x509verify options Added to ui queue. thanks, Gerd

Re: [Qemu-devel] [RFC/RFT PATCH 0/2] spice-display locking fixes (cursors)?

2018-08-20 Thread Gerd Hoffmann
On Fri, Jul 20, 2018 at 08:31:07AM +0200, Paolo Bonzini wrote: > The first issue was found by Coverity and should be trivial. The second > however made me wonder how to test the code and whether it has ever > worked, because in theory it should be an instant deadlock whenever > qemu_spice_cursor_r

Re: [Qemu-devel] [PATCH] sdl2: redraw correctly when scanout_mode enabled.

2018-08-20 Thread Gerd Hoffmann
On Thu, Jul 26, 2018 at 03:59:00PM -0700, Tao Wu wrote: > When scanout_mode enabled, surface is out of sync with actual screen. > In such case, we just call sdl2_gl_scanout_flush to do redraw. This > fixes bug reported in > https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330

Re: [Qemu-devel] [PATCH] editorconfig: set emacs mode

2018-08-20 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Aug 20, 2018 at 9:55 PM Eric Blake wrote: >> >> On 08/20/2018 01:00 PM, Peter Maydell wrote: >> > On 20 August 2018 at 18:43, Marc-André Lureau >> > wrote: >> >> Some time ago, I proposed to use an (eval) in .dir-locals.el to set >> >> the mode for all

Re: [Qemu-devel] [PATCH] ui: use enum to string helpers

2018-08-20 Thread Gerd Hoffmann
On Wed, Aug 01, 2018 at 11:25:08AM +0200, Marc-André Lureau wrote: > Minor code simplification. Added to ui queue. thanks, Gerd

Re: [Qemu-devel] Bugs when cross-compiling qemu for Windows with mingw 8.1, executable doesn't run

2018-08-20 Thread Stefan Weil
Am 20.08.2018 um 22:39 schrieb Howard Spoelstra: > Confirmed, adding --disable-stack-protector to configure results in a > working binary. > > Great, thanks, > Howard There is already a bug report for gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86832 It looks like not only Windows but also

Re: [Qemu-devel] [PATCH for-3.1] ui/sdl2: Remove the obsolete SDL_INIT_NOPARACHUTE flag

2018-08-20 Thread Gerd Hoffmann
On Wed, Aug 08, 2018 at 11:46:42AM +0200, Thomas Huth wrote: > SDL_INIT_NOPARACHUTE is not used in SDL2 anymore, and the define is just > a dummy (see https://wiki.libsdl.org/MigrationGuide#Some_general_truths > for example). So we can remove it and get rid of the "flags" variable > nowadays. Adde

Re: [Qemu-devel] [PATCH] vnc: fix memleak of the "vnc-worker-output" name

2018-08-20 Thread Gerd Hoffmann
On Wed, Aug 08, 2018 at 12:18:30AM +0200, Peter Wu wrote: > Fixes repeated memory leaks of 18 bytes when using VNC: > > Direct leak of 831024 byte(s) in 46168 object(s) allocated from: > ... > #4 0x7f6d2f919bdd in g_strdup_vprintf glib/gstrfuncs.c:514 > #5 0x56085cdcf66

Re: [Qemu-devel] [PATCH v2 41/60] json: Nicer recovery from invalid leading zero

2018-08-20 Thread Markus Armbruster
Eric Blake writes: > On 08/20/2018 06:39 AM, Markus Armbruster wrote: > >> In review of v1, we discussed whether to try matching non-integer >> numbers with redundant leading zero. Doing that tightly in the lexer >> requires duplicating six states. A simpler alternative is to have the >> lexer

Re: [Qemu-devel] [PATCH] monitor: avoid potential dead-lock when cleaning up

2018-08-20 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Aug 20, 2018 at 8:57 AM Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> > Hi >> > On Wed, Aug 1, 2018 at 5:09 PM Markus Armbruster wrote: >> >> >> >> Marc-André Lureau writes: >> >> >> >> > Hi >> >> > >> >> > On Wed, Aug 1, 2018 at 3:1

[Qemu-devel] [PULL 15/26] spapr: introduce a fixed IRQ number space

2018-08-20 Thread David Gibson
From: Cédric Le Goater This proposal introduces a new IRQ number space layout using static numbers for all devices, depending on a device index, and a bitmap allocator for the MSI IRQ numbers which are negotiated by the guest at runtime. As the VIO device model does not have a device index but a

[Qemu-devel] [PULL 16/26] hw/ppc/prep: Remove ifdeffed-out stub of XCSR code

2018-08-20 Thread David Gibson
From: Peter Maydell The prep machine has some code which is stubs of accessors for XCSR registers. This has been disabled via #if 0 since commit b6b8bd1819ff in 2004, and doesn't have any actual interesting content. It also uses the deprecated old_mmio accessor functions. Remove it entirely. Sig

[Qemu-devel] [PULL 19/26] spapr: introduce a IRQ controller backend to the machine

2018-08-20 Thread David Gibson
From: Cédric Le Goater This proposal moves all the related IRQ routines of the sPAPR machine behind a sPAPR IRQ backend interface 'spapr_irq' to prepare for future changes. First of which will be to increase the size of the IRQ number space, then, will follow a new backend for the POWER9 XIVE IRQ

[Qemu-devel] [PULL 17/26] hw/ppc/ppc_boards: Don't use old_mmio for ref405ep_fpga

2018-08-20 Thread David Gibson
From: Peter Maydell Switch the ref405ep_fpga device away from using the old_mmio MemoryRegion accessors. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/ppc405_boards.c | 60 +++--- 1 file changed, 10

[Qemu-devel] [PULL 21/26] qemu-doc: mark ppc/prep machine as deprecated

2018-08-20 Thread David Gibson
From: Hervé Poussineau 40p machine type should be used instead. Signed-off-by: Hervé Poussineau Acked-by: Mark Cave-Ayland Signed-off-by: David Gibson --- qemu-deprecated.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 67b72115

[Qemu-devel] [PULL 22/26] 40p: don't use legacy fw_cfg_init_mem() function

2018-08-20 Thread David Gibson
From: Mark Cave-Ayland Instead initialise the device via qdev to allow us to set device properties directly as required. Signed-off-by: Mark Cave-Ayland Acked-by: Hervé Poussineau Signed-off-by: David Gibson --- hw/ppc/prep.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(

[Qemu-devel] [PULL 20/26] hw/ppc: deprecate the machine type 'prep', replaced by '40p'

2018-08-20 Thread David Gibson
From: Hervé Poussineau - prep machine is a fictional machine, so has no specifications. Which devices can be changed/added/removed without impact? Are interrupts correctly mapped? - prep firmware (OHW) has support only for IDE drives (no SCSI). Booting from IDE has been broken approximative

[Qemu-devel] [PULL 23/26] mac_oldworld: don't use legacy fw_cfg_init_mem() function

2018-08-20 Thread David Gibson
From: Mark Cave-Ayland Instead initialise the device via qdev to allow us to set device properties directly as required. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/ppc/mac_oldworld.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/pp

[Qemu-devel] [PULL 18/26] hw/ppc/ppc405_uc: Convert away from old_mmio

2018-08-20 Thread David Gibson
From: Peter Maydell Convert the devices in ppc405_uc away from using the old_mmio MemoryRegion accessors: * opba's 32-bit and 16-bit accessors were just calling the 8-bit accessors and assembling a big-endian order number, which we can do by setting the .impl.max_access_size to 1 and t

[Qemu-devel] [PULL 26/26] ppc: add DBCR based debugging

2018-08-20 Thread David Gibson
From: Roman Kapl Add support for DBCR (debug control register) based debugging as used on BookE ppc. So far supports only branch and single-step events, but these are the important ones. GDB in Linux guest can now do single-stepping. Signed-off-by: Roman Kapl Signed-off-by: David Gibson --- t

[Qemu-devel] [PULL 09/26] target/ppc: Use non-arithmetic conversions for fp load/store

2018-08-20 Thread David Gibson
From: Richard Henderson Memory operations have no side effects on fp state. The use of a "real" conversions between float64 and float32 would raise exceptions for SNaN and out-of-range inputs. Signed-off-by: Richard Henderson Signed-off-by: David Gibson --- target/ppc/fpu_helper.c

[Qemu-devel] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-20 Thread David Gibson
From: Cédric Le Goater It should save us some CPU cycles as these routines perform a lot of checks. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/sp

[Qemu-devel] [PULL 05/26] target/ppc: Tidy helper_fmul

2018-08-20 Thread David Gibson
From: Richard Henderson Tidy the invalid exception checking so that we rely on softfloat for initial argument validation, and select the kind of invalid operand exception only when we know we must. Pass and return float64 values directly rather than bounce through the CPU_DoubleU union. Signed-

[Qemu-devel] [PULL 14/26] spapr: Add a pseries-3.1 machine type

2018-08-20 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index e5d825374e..a732f59205 100644 --- a/h

[Qemu-devel] [PULL 06/26] target/ppc: Tidy helper_fadd, helper_fsub

2018-08-20 Thread David Gibson
From: Richard Henderson Tidy the invalid exception checking so that we rely on softfloat for initial argument validation, and select the kind of invalid operand exception only when we know we must. Pass and return float64 values directly rather than bounce through the CPU_DoubleU union. Note th

[Qemu-devel] [PULL 24/26] mac_newworld: don't use legacy fw_cfg_init_mem() function

2018-08-20 Thread David Gibson
From: Mark Cave-Ayland Instead initialise the device via qdev to allow us to set device properties directly as required. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/ppc/mac_newworld.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/pp

[Qemu-devel] [PULL 13/26] target/ppc: simplify bcdadd/sub functions

2018-08-20 Thread David Gibson
From: Yasmin Beatriz After solving a corner case in bcdsub, this patch simplifies the logic of both bcdadd/sub instructions by removing some unnecessary local flags. This commit also rearranges some if-else conditions in bcdadd to make it easier to read. Signed-off-by: Yasmin Beatriz Signed-off

[Qemu-devel] [PULL 00/26] ppc-for-3.1 queue 20180821

2018-08-20 Thread David Gibson
The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into staging (2018-08-20 17:41:18 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-3.1-201

[Qemu-devel] [PULL 08/26] target/ppc: Honor fpscr_ze semantics and tidy fre, fresqrt

2018-08-20 Thread David Gibson
From: Richard Henderson Divide by zero, exception taken, leaves the destination register unmodified. Therefore we must raise the exception before returning from the respective helpers. >From helper_fre, divide by zero exception not taken, return the documented +/- 0.5. At the same time, tidy t

[Qemu-devel] [PULL 12/26] xics: don't include "target/ppc/cpu-qom.h" in "hw/ppc/xics.h"

2018-08-20 Thread David Gibson
From: Greg Kurz The last user of the PowerPCCPU typedef in "hw/ppc/xics.h" vanished with commit b1fd36c363d73969841468146ebfb9fd84a5ee52. It isn't necessary to include "target/ppc/cpu-qom.h" there anymore. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- include/hw/ppc/xics.h | 1 - 1

[Qemu-devel] [PULL 10/26] target/ppc: bcdsub fix sign when result is zero

2018-08-20 Thread David Gibson
From: Yasmin Beatriz When the result of bcdsub is equal to zero, the result sign may be set to negative in some cases, and this does not follow the Power ISA specifications as to decimal integer arithmetic instructions. Signed-off-by: Yasmin Beatriz Signed-off-by: David Gibson --- target/ppc/

[Qemu-devel] [PULL 11/26] vfio/spapr: Allow backing bigger guest IOMMU pages with smaller physical pages

2018-08-20 Thread David Gibson
From: Alexey Kardashevskiy At the moment the PPC64/pseries guest only supports 4K/64K/16M IOMMU pages and POWER8 CPU supports the exact same set of page size so so far things worked fine. However POWER9 supports different set of sizes - 4K/64K/2M/1G and the last two - 2M and 1G - are not even al

[Qemu-devel] [PULL 04/26] target/ppc: Honor fpscr_ze semantics and tidy fdiv

2018-08-20 Thread David Gibson
From: Richard Henderson Divide by zero, exception taken, leaves the destination register unmodified. Therefore we must raise the exception before returning from helper_fdiv. Move the check from do_float_check_status into helper_fdiv. At the same time, tidy the invalid exception checking so tha

[Qemu-devel] [PULL 03/26] target/ppc: Enable fp exceptions for user-only

2018-08-20 Thread David Gibson
From: Richard Henderson While just setting the MSR bits is sufficient, we can tidy the helper code by extracting the MSR test to a helper and then forcing it true for user-only. Signed-off-by: Richard Henderson Signed-off-by: David Gibson --- target/ppc/fpu_helper.c | 15 -

[Qemu-devel] [PULL 01/26] spapr_cpu_core: vmstate_[un]register per-CPU data from (un)realizefn

2018-08-20 Thread David Gibson
From: Bharata B Rao VMStateDescription vmstate_spapr_cpu_state was added by commit b94020268e0b6 (spapr_cpu_core: migrate per-CPU data) to migrate per-CPU data with the required vmstate registration and unregistration calls. However the unregistration is being done only from vcpu creation error p

[Qemu-devel] [PULL 07/26] target/ppc: Tidy helper_fsqrt

2018-08-20 Thread David Gibson
From: Richard Henderson Tidy the invalid exception checking so that we rely on softfloat for initial argument validation, and select the kind of invalid operand exception only when we know we must. Pass and return float64 values directly rather than bounce through the CPU_DoubleU union. Signed-

[Qemu-devel] [Bug 1470720] Re: high IRQ-TLB generates network interruptions

2018-08-20 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1470720 Title: high IRQ-TL

[Qemu-devel] [Bug 1471583] Re: QCA988X Wifi Card Not PCI Passing Through

2018-08-20 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1471583 Title: QCA988X Wif

[Qemu-devel] [Bug 1314293] Re: screendump with qxl + spice shows stale data

2018-08-20 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1314293 Title: screendump

[Qemu-devel] [Bug 1472083] Re: Qemu 2.1.2 hang when stop command

2018-08-20 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1472083 Title: Qemu 2.1.2

Re: [Qemu-devel] [PATCH V11 17/20] filter-rewriter: handle checkpoint and failover event

2018-08-20 Thread Jason Wang
On 2018年08月12日 04:59, Zhang Chen wrote: After one round of checkpoint, the states between PVM and SVM become consistent, so it is unnecessary to adjust the sequence of net packets for old connections, besides, while failover happens, filter-rewriter will into failover mode that needn't handle

Re: [Qemu-devel] [PATCH V11 15/20] net/net.c: Add net client type check function for COLO

2018-08-20 Thread Jason Wang
On 2018年08月12日 04:59, Zhang Chen wrote: From: Zhang Chen We add is_colo_support_client_type() to check the net client type for COLO-compare. Currently we just support TAP. Suggested by Jason. Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen --- This needs more works: - Forbid vhost

Re: [Qemu-devel] [PATCH V11 16/20] filter: Add handle_event method for NetFilterClass

2018-08-20 Thread Jason Wang
On 2018年08月12日 04:59, Zhang Chen wrote: Filter needs to process the event of checkpoint/failover or other event passed by COLO frame. Signed-off-by: zhanghailiang --- include/net/filter.h | 5 + net/filter.c | 17 + net/net.c| 28 +

[Qemu-devel] [PATCH v3 2/2] hw/pci: add PCI resource reserve capability to legacy PCI bridge

2018-08-20 Thread Jing Liu
Add hint to firmware (e.g. SeaBIOS) to reserve addtional BUS/IO/MEM/PREF resource for legacy pci-pci bridge. Add the resource reserve capability deleting in pci_bridge_dev_exitfn. Signed-off-by: Jing Liu --- hw/pci-bridge/pci_bridge_dev.c | 24 1 file changed, 24 inserti

[Qemu-devel] [PATCH v3 0/2] hw/pci: PCI resource reserve capability

2018-08-20 Thread Jing Liu
This patch serial is about PCI resource reserve capability. First patch refactors the resource reserve fields in GenPCIERoorPort structure out to another new structure, called "PCIResReserve". Modify the parameter list of pci_bridge_qemu_reserve_cap_init(). Second patch enables the resource reser

[Qemu-devel] [PATCH v3 1/2] hw/pci: factor PCI reserve resources to a separate structure

2018-08-20 Thread Jing Liu
Factor "bus_reserve", "io_reserve", "mem_reserve", "pref32_reserve" and "pref64_reserve" fields of the "GenPCIERootPort" structure out to "PCIResReserve" structure, so that other PCI bridges can reuse it to add resource reserve capability. Signed-off-by: Jing Liu --- hw/pci-bridge/gen_pcie_root_

Re: [Qemu-devel] [PATCH V11 00/20] COLO: integrate colo frame with block replication and COLO proxy

2018-08-20 Thread Zhang Chen
Hi Jason and Markus, Ping... Do you have time to review this series? Thanks Zhang Chen On Sun, Aug 12, 2018 at 4:59 AM Zhang Chen wrote: > Hi~ All~ > > COLO Frame, block replication and COLO proxy(colo-compare,filter-mirror, > filter-redirector,filter-rewriter) have been exist in qemu > for lo

[Qemu-devel] [PATCH 6/7] target/s390x: fix PACK reading 1 byte less and writing 1 byte more

2018-08-20 Thread Pavel Zbitskiy
PACK fails on the test from the Principles of Operation: F1F2F3F4 becomes 234C instead of 0001234C due to an off-by-one error. Furthermore, it overwrites one extra byte to the left of F1. If len_dest is 0, then we only want to flip the 1st byte and never loop over the rest. Therefore, the loop

[Qemu-devel] [PATCH 4/7] target/s390x: fix IPM polluting irrelevant bits

2018-08-20 Thread Pavel Zbitskiy
Suppose psw.mask=0x8000, cc=2, r1=0 and we do "ipm 1". This command must touch only bits 32-39, so the expected output is r1=0x2000. However, currently qemu yields r1=0x20008000, because irrelevant parts of PSW leak into r1 during program mask transfer. Signed-off-by: Pavel Zbitski

[Qemu-devel] [PATCH 7/7] target/s390x: implement CVB, CVBY and CVBG

2018-08-20 Thread Pavel Zbitskiy
Convert to Binary - counterparts of the already implemented Convert to Decimal (CVD*) instructions. Example from the Principles of Operation: 25594C becomes 63FA. Signed-off-by: Pavel Zbitskiy --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 +++ target/s390x/int_

[Qemu-devel] [PATCH 3/7] target/s390x: fix CSST decoding and runtime alignment check

2018-08-20 Thread Pavel Zbitskiy
CSST is defined as: C(0xc802, CSST,SSF, CASS, la1, a2, 0, 0, csst, 0) It means that the first parameter is handled by in1_la1(). in1_la1() fills addr1 field, and not in1. Furthermore, when extract32() is used for the alignment check, the third parameter should specify the number of tra

[Qemu-devel] [PATCH 2/7] target/s390x: add BAL and BALR instructions

2018-08-20 Thread Pavel Zbitskiy
These instructions are provided for compatibility purposes and are used only by old software, in the new code BAS and BASR are preferred. The difference between the old and new instruction exists only in the 24-bit mode. In addition, fix BAS polluting high 32 bits of the first operand in 24- and 3

[Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support

2018-08-20 Thread Pavel Zbitskiy
Found while attempting to run an old tool in qemu. * BAL and BALR:Added. * CSST:Qemu crashed after an accidental jump to garbage. * IPM: A tool produced an incorrect output. * EX TRT/TRTR: A tool ran quite slow. * PACK:A tool produced an incorrect output

[Qemu-devel] [PATCH 5/7] target/s390x: add EX support for TRT and TRTR

2018-08-20 Thread Pavel Zbitskiy
Improves "b213c9f5: target/s390x: Implement TRTR" by introducing the intermediate functions, which are compatible with dx_helper type. Signed-off-by: Pavel Zbitskiy --- target/s390x/mem_helper.c | 16 +++ tests/tcg/s390x/Makefile.target | 2 ++ tests/tcg/s390x/exrl-trt.c | 48

[Qemu-devel] [PATCH 1/7] tests/tcg: add a simple s390x test

2018-08-20 Thread Pavel Zbitskiy
Copied from alpha. Signed-off-by: Pavel Zbitskiy --- MAINTAINERS | 1 + tests/tcg/s390x/Makefile.target | 3 +++ tests/tcg/s390x/hello-s390x.c | 7 +++ 3 files changed, 11 insertions(+) create mode 100644 tests/tcg/s390x/Makefile.target create mode 100644 tests/tcg/s3

Re: [Qemu-devel] [PATCH v2 2/3] hw/pci: add teardown function for PCI resource reserve capability

2018-08-20 Thread Liu, Jing2
Hi Marcel, On 8/20/2018 9:38 PM, Marcel Apfelbaum wrote: Hi Jing, On 08/20/2018 05:58 AM, Liu, Jing2 wrote: Hi Marcel, On 8/18/2018 12:10 AM, Marcel Apfelbaum wrote: Hi Jing, On 08/16/2018 12:28 PM, Jing Liu wrote: Clean up the PCI config space of resource reserve capability. Signed-off

Re: [Qemu-devel] [PATCH v3 0/3] file-posix: Simplifications on image locking

2018-08-20 Thread Fam Zheng
On Fri, 08/17 17:35, no-re...@patchew.org wrote: > ERROR:/tmp/qemu-test/src/tests/test-image-locking.c:69:check_locked_bytes: > assertion failed (perm_expected == !!qemu_lock_fd_test(fd, 100 + i, 1, > true)): (1 == 0) This image doesn't have OFD locking support in its glibc. Will add a check in

[Qemu-devel] [PATCH v4 0/3] file-posix: Simplifications on image locking

2018-08-20 Thread Fam Zheng
v4: Fix test on systems without OFD. [Patchew] The first patch reduces chances of QEMU crash in unusual (but not unlikely) cases especially when used by Libvirt (see commit message). The second patch halves fd for images. The third adds some more test for patch one (would have caught the regress

[Qemu-devel] [PATCH v4 1/3] file-posix: Skip effectiveless OFD lock operations

2018-08-20 Thread Fam Zheng
If we know we've already locked the bytes, don't do it again; similarly don't unlock a byte if we haven't locked it. This doesn't change the behavior, but fixes a corner case explained below. Libvirt had an error handling bug that an image can get its (ownership, file mode, SELinux) permissions ch

[Qemu-devel] [PATCH v4 2/3] file-posix: Drop s->lock_fd

2018-08-20 Thread Fam Zheng
The lock_fd field is not strictly necessary because transferring locked bytes from old fd to the new one shouldn't fail anyway. This spares the user one fd per image. Signed-off-by: Fam Zheng --- block/file-posix.c | 37 + 1 file changed, 13 insertions(+), 24

Re: [Qemu-devel] [PATCH 0/4] docker: Sort packages

2018-08-20 Thread Fam Zheng
On Fri, 08/17 22:53, Philippe Mathieu-Daudé wrote: > Trivial cleanup patches. > > Per the Docker recommendation, "this helps to avoid duplication of > packages and make the list much easier to update. This also makes PRs > a lot easier to read and review." > > Regards, > > Phil. > > Philippe Ma

Re: [Qemu-devel] [PATCH] docker: Clean dangling tarball files

2018-08-20 Thread Fam Zheng
On Sat, 08/18 00:03, Philippe Mathieu-Daudé wrote: > When a container fails, it leaves a dangling tarball which name is > based on a timestamp. Further uses of make won't clean those files, > neither calling the 'docker-clean' target. > > Use the .DELETE_ON_ERROR built-in target to let make remove

[Qemu-devel] [PATCH v4 3/3] tests: Add unit tests for image locking

2018-08-20 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile.include | 2 + tests/test-image-locking.c | 154 + 2 files changed, 156 insertions(+) create mode 100644 tests/test-image-locking.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 760a0f18b6

Re: [Qemu-devel] [PULL 0/7] Linux user for 3.1 patches

2018-08-20 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180820202604.14218-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 0/7] Linux user for 3.1 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --on

Re: [Qemu-devel] [PATCH 2/7] jobs: canonize Error object

2018-08-20 Thread John Snow
On 08/17/2018 03:04 PM, John Snow wrote: > +error_setg_errno(&job->err, -job->ret, "job failed"); Kevin specifically asked for me to change this, and I lost it in the shuffle. I'll send a v3 now, since there are enough nits to warrant it, and I think I want to adjust a few things to

Re: [Qemu-devel] [PATCH v3 4/6] hw/riscv/virt: Connect a VGA PCIe device

2018-08-20 Thread Alistair Francis
On Thu, Aug 16, 2018 at 11:36 PM, Gerd Hoffmann wrote: > Hi, > >> +pci_bus = PCI_HOST_BRIDGE(dev)->bus; >> + >> +pci_vga_init(pci_bus); > > I'd suggest to use "-device bochs-display" instead, unless you need all > the legacy vga cruft (text mode, ...). The bochs-drm kms driver can > han

Re: [Qemu-devel] [PATCH v2 2/2] block: iotest to catch abort on forced blockjob cancel

2018-08-20 Thread John Snow
On 08/16/2018 02:46 PM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > tests/qemu-iotests/229 | 95 ++ > tests/qemu-iotests/229.out | 23 + > tests/qemu-iotests/group | 1 + > 3 files changed, 119 insertions(+) > create mode 100755 tests

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

2018-08-20 Thread Eric Blake
On 08/17/2018 02:04 PM, John Snow wrote: All jobs do the same thing when they leave their running loop: - Store the return code in a structure - wait to receive this structure in the main thread - signal job completion via job_completed Few jobs do anything beyond exactly this. Consolidate this

Re: [Qemu-devel] Simulating a composite machine

2018-08-20 Thread Martin Schroeder via Qemu-devel
Is it that I need to add emulation for CP10 and CP11? On Mon, Aug 20, 2018 at 8:29 PM Martin Schroeder wrote: > > Sent it off as reply instead of reply all.. my bad. > > I was also surprised that it was mid into an instruction. The code > works fine on STM32 but if FPU is not enabled on the STM32

[Qemu-devel] [PATCH v2] ipmi: Use proper struct reference for BT vmstate

2018-08-20 Thread minyard
From: Corey Minyard The vmstate for isa_ipmi_bt was referencing into the bt structure, instead create a bt structure separate and use that. The version 1 of the BT transfer was fairly broken, if a migration occured during an IPMI operation, it is likely the migration would be corrupted because I

Re: [Qemu-devel] [PATCH] editorconfig: set emacs mode

2018-08-20 Thread Marc-André Lureau
Hi On Mon, Aug 20, 2018 at 9:55 PM Eric Blake wrote: > > On 08/20/2018 01:00 PM, Peter Maydell wrote: > > On 20 August 2018 at 18:43, Marc-André Lureau > > wrote: > >> Some time ago, I proposed to use an (eval) in .dir-locals.el to set > >> the mode for all json files and Makefile. Unfortunately

[Qemu-devel] [PATCH v2 07/10] Don't delay host status register busy bit when interrupts are enabled

2018-08-20 Thread minyard
From: Corey Minyard Change 880b1ffe6ec2f0ae "smbus: do not immediately complete commands" changed pm_smbus to delay setting the host busy bit until the status register was read, to work around a bug in AMIBIOS. Unfortunately, when interrupts are enabled, the status register will never get read a

  1   2   3   4   5   >