Re: [Qemu-devel] [PATCH] tests: Simplify .gitignore

2018-06-19 Thread Markus Armbruster
Eric Blake writes: > Commit 0bcc8e5b was yet another instance of 'git status' reporting > dirty files after an in-tree build, thanks to the new binary > tests/check-block-qdict. > > Instead of piecemeal exemptions of each new binary as they are > added, let's use git's negative globbing feature t

Re: [Qemu-devel] [PATCH 10/12] migration: introduce lockless multithreads model

2018-06-19 Thread Peter Xu
On Mon, Jun 04, 2018 at 05:55:18PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Current implementation of compression and decompression are very > hard to be enabled on productions. We noticed that too many wait-wakes > go to kernel space and CPU usages are very low even if t

Re: [Qemu-devel] [RFC v2 1/3] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-06-19 Thread Marcel Apfelbaum
On 06/12/2018 12:13 PM, Zihan Yang wrote: The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, add a new type TYPE_PXB_PCIE_HOST to better utilize the ECAM of PCIe Signed-off-by: Zihan Yang --- hw/pci-bridge/pci_expander_bridge.c | 118

[Qemu-devel] [Bug 1777777] [NEW] arm9 clock pending (SP804)

2018-06-19 Thread RTOS Pharos
Public bug reported: Hello all, I'm using the versatilepb board and the timer Interrupt Mask Status register (offset 0x14 of the SP804) does not seem to be working properly on the latest qemu-2.12. I tried on the 2.5 (i believe this is the mainstream version that comes with Linux) and it works pe

Re: [Qemu-devel] [PATCH 09/12] ring: introduce lockless ring buffer

2018-06-19 Thread Peter Xu
On Mon, Jun 04, 2018 at 05:55:17PM +0800, guangrong.x...@gmail.com wrote: [...] (Some more comments/questions for the MP implementation...) > +static inline int ring_mp_put(Ring *ring, void *data) > +{ > +unsigned int index, in, in_next, out; > + > +do { > +in = atomic_read(&ring

Re: [Qemu-devel] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models

2018-06-19 Thread Cédric Le Goater
On 06/20/2018 02:56 AM, David Gibson wrote: > On Tue, Jun 19, 2018 at 07:24:44AM +0200, Cédric Le Goater wrote: >> > typedef struct PnvChipClass { > /*< private >*/ > @@ -75,6 +95,7 @@ typedef struct PnvChipClass { > > hwaddr xscom_base; > > +voi

Re: [Qemu-devel] [PATCH v2 3/3] spapr: introduce a fixed IRQ number space

2018-06-19 Thread Cédric Le Goater
>> diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c >> index e4f5946a2188..c82dc40be0d5 100644 >> --- a/hw/ppc/spapr_events.c >> +++ b/hw/ppc/spapr_events.c >> @@ -709,7 +709,11 @@ void spapr_events_init(sPAPRMachineState *spapr) >> { >> int epow_irq; >> >> -epow_irq = spapr_i

Re: [Qemu-devel] [PATCH 09/12] ring: introduce lockless ring buffer

2018-06-19 Thread Peter Xu
On Mon, Jun 04, 2018 at 05:55:17PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > It's the simple lockless ring buffer implement which supports both > single producer vs. single consumer and multiple producers vs. > single consumer. > > Many lessons were learned from Linux Ker

Re: [Qemu-devel] [RFC v2 1/3] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-06-19 Thread Marcel Apfelbaum
On 06/13/2018 11:23 AM, Zihan Yang wrote: Michael S. Tsirkin 于2018年6月12日周二 下午9:43写道: On Tue, Jun 12, 2018 at 05:13:22PM +0800, Zihan Yang wrote: The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, add a new type TYPE_PXB_PCIE_HOST to better utilize the ECAM of PCIe S

[Qemu-devel] [PATCH 0/2] ide/hw/core: fix bug# 1777315, crash on short PRDs

2018-06-19 Thread Amol Surati
The fix utilizes the existing policy QEMU has about short PRDs, and considers the transfers that cause the crash as generated through short PRDS. It - continues to allow QEMU to support multiple calls to prepare_buf/ide_dma_cb, - so, continues to keep QEMU free from needing the entire sglist in

[Qemu-devel] [PATCH 1/2] ide/hw/core: fix crash on processing a partial-sector-size DMA xfer

2018-06-19 Thread Amol Surati
Fixes: https://bugs.launchpad.net/qemu/+bug/1777315 QEMU's short PRD policy applies to a DMA transfer of size < 512 bytes. But it fails to consider transfers which are >= 512 bytes, but are not a multiple of 512 bytes. Such transfers are not subject to the short PRD policy. They end up violating

[Qemu-devel] [PATCH 2/2] tests/ide-test: test case for crash when processing short PRDs

2018-06-19 Thread Amol Surati
From: John Snow Related Bug: https://bugs.launchpad.net/qemu/+bug/1777315 Signed-off-by: Amol Surati --- tests/ide-test.c | 28 1 file changed, 28 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index f39431b1a9..382c29a174 100644 --- a/tests/ide-te

Re: [Qemu-devel] [virtio-dev] Re: [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-06-19 Thread Michael S. Tsirkin
On Wed, Jan 10, 2018 at 01:53:09PM +0800, Longpeng (Mike) wrote: > Hi Halil, > > We are fixing the Intel BUG these days, so I will go through your comments > after > we're done. Thanks. All right - are you guys done with meltdown/spectre? I'd like us to start finally getting parts of this in the

Re: [Qemu-devel] [PATCH v2 3/8] ppc4xx_i2c: Implement directcntl register

2018-06-19 Thread BALATON Zoltan
On Wed, 20 Jun 2018, David Gibson wrote: On Tue, Jun 19, 2018 at 11:29:09AM +0200, BALATON Zoltan wrote: On Mon, 18 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 04:03:18PM +0200, BALATON Zoltan wrote: On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 10:54:22AM +0200,

Re: [Qemu-devel] [virtio-dev] [PATCH] Add virtio gpu device specification.

2018-06-19 Thread Michael S. Tsirkin
On Tue, May 10, 2016 at 01:25:37PM +0200, Gerd Hoffmann wrote: > Hi, > > > > > Rendered versions are available here: > > > > https://www.kraxel.org/virtio/virtio-v1.0-cs03-virtio-gpu.pdf > > > > > > > > https://www.kraxel.org/virtio/virtio-v1.0-cs03-virtio-gpu.html#x1-287 > > > > I gue

Re: [Qemu-devel] [PATCH v4 6/7] monitor: remove "x-oob", turn oob on by default

2018-06-19 Thread Peter Xu
On Tue, Jun 19, 2018 at 04:16:49PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > There was a regression reported by Eric Auger before with OOB: > > > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > > > It is fixed in 951702f39c ("monitor: bind dispatch bh to

Re: [Qemu-devel] [PATCH v4 4/7] tests: iotests: drop some stderr line

2018-06-19 Thread Peter Xu
On Tue, Jun 19, 2018 at 03:57:07PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > In my Out-Of-Band test, "check -qcow2 060" fail with this (the output is > > manually changed due to line width requirement): > > > > 060 5s ... - output mismatch (see 060.out.bad) > > --- /home/peterx/git

Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-19 Thread Peter Xu
On Tue, Jun 19, 2018 at 03:55:12PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Tue, Jun 19, 2018 at 01:34:22PM +0800, Peter Xu wrote: > > > > [...] > > > >> Fixes: 6d2d563f8c ("qmp: cleanup qmp queues properly", 2018-03-27) > >> Suggested-by: Markus Armbruster > >> Signed-off-by:

Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-19 Thread Peter Xu
On Tue, Jun 19, 2018 at 03:53:11PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Previously we clean up the queues when we got CLOSED event. It was used > > to make sure we won't send leftover replies/events of a old client to a > > new client which makes perfect sense. However this w

Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off

2018-06-19 Thread Michael S. Tsirkin
On Wed, Jun 20, 2018 at 08:46:10AM +0800, Wanpeng Li wrote: > On Wed, 20 Jun 2018 at 08:07, Michael S. Tsirkin wrote: > > > > On Tue, Jun 19, 2018 at 05:07:46PM -0500, Eric Blake wrote: > > > On 06/19/2018 10:17 AM, Paolo Bonzini wrote: > > > > On 16/06/2018 00:29, Michael S. Tsirkin wrote: > > >

Re: [Qemu-devel] [PATCH for-2.11.2] spapr: make pseries-2.11 the default machine type

2018-06-19 Thread David Gibson
On Tue, Jun 19, 2018 at 01:11:28PM +0200, Greg Kurz wrote: > On Mon, 18 Jun 2018 21:04:38 -0500 > Michael Roth wrote: > > > Quoting Greg Kurz (2018-05-22 12:17:28) > > > The spapr capability framework was introduced in QEMU 2.12. It allows > > > to have an explicit control on how host features ar

Re: [Qemu-devel] [PATCH v2 3/8] ppc4xx_i2c: Implement directcntl register

2018-06-19 Thread David Gibson
On Tue, Jun 19, 2018 at 11:29:09AM +0200, BALATON Zoltan wrote: > On Mon, 18 Jun 2018, David Gibson wrote: > > On Wed, Jun 13, 2018 at 04:03:18PM +0200, BALATON Zoltan wrote: > > > On Wed, 13 Jun 2018, David Gibson wrote: > > > > On Wed, Jun 13, 2018 at 10:54:22AM +0200, BALATON Zoltan wrote: > > >

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Wed, Jun 20, 2018 at 06:23:19AM +0530, Amol Surati wrote: > On Tue, Jun 19, 2018 at 05:43:52PM -0400, John Snow wrote: > > > > > > On 06/19/2018 05:26 PM, Amol Surati wrote: > > > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > > >> On Tue, Jun 19, 2018 at 09:45:15AM -0400, John

Re: [Qemu-devel] [PATCH V1 RESEND 4/6] numa: Extend the command-line to provide memory latency and bandwidth information

2018-06-19 Thread Liu, Jingqi
On 6/19/2018 11:39 PM, Eric Blake wrote: On 06/19/2018 10:20 AM, Liu Jingqi wrote: Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information Structure(s) in ACPI Heterogeneous M

Re: [Qemu-devel] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models

2018-06-19 Thread David Gibson
On Tue, Jun 19, 2018 at 07:24:44AM +0200, Cédric Le Goater wrote: > > >>> typedef struct PnvChipClass { > >>> /*< private >*/ > >>> @@ -75,6 +95,7 @@ typedef struct PnvChipClass { > >>> > >>> hwaddr xscom_base; > >>> > >>> +void (*realize)(PnvChip *chip, Error **errp); > >

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 05:43:52PM -0400, John Snow wrote: > > > On 06/19/2018 05:26 PM, Amol Surati wrote: > > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > >> On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > >>> > >>> > >>> On 06/19/2018 04:53 AM, Kevin Wolf wrote:

Re: [Qemu-devel] [PATCH v2 3/3] spapr: introduce a fixed IRQ number space

2018-06-19 Thread David Gibson
On Tue, Jun 19, 2018 at 12:05:21PM +0200, Cédric Le Goater wrote: > On 06/19/2018 03:02 AM, David Gibson wrote: > > On Mon, Jun 18, 2018 at 07:34:02PM +0200, Cédric Le Goater wrote: > >> This proposal introduces a new IRQ number space layout using static > >> numbers for all devices and a bitmap al

Re: [Qemu-devel] [PATCH v4 01/11] ppc4xx_i2c: Remove unimplemented sdata and intr registers

2018-06-19 Thread David Gibson
On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote: > We don't emulate slave mode so related registers are not needed. > [lh]sadr are only retained to avoid too many warnings and simplify > debugging but sdata is not even correct because device has a 4 byte > FIFO instead so just remove

Re: [Qemu-devel] [PATCH v2 3/3] spapr: introduce a fixed IRQ number space

2018-06-19 Thread David Gibson
On Tue, Jun 19, 2018 at 07:00:18AM +0200, Cédric Le Goater wrote: > On 06/19/2018 03:02 AM, David Gibson wrote: > > On Mon, Jun 18, 2018 at 07:34:02PM +0200, Cédric Le Goater wrote: > >> This proposal introduces a new IRQ number space layout using static > >> numbers for all devices and a bitmap al

Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off

2018-06-19 Thread Wanpeng Li
On Wed, 20 Jun 2018 at 08:07, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 05:07:46PM -0500, Eric Blake wrote: > > On 06/19/2018 10:17 AM, Paolo Bonzini wrote: > > > On 16/06/2018 00:29, Michael S. Tsirkin wrote: > > > > +static QemuOptsList qemu_dedicated_opts = { > > > > +.name = "d

Re: [Qemu-devel] [PATCH] hmp-commands: use long for begin and length in dump-guest-memory

2018-06-19 Thread Suraj Jitindar Singh
On Tue, 2018-06-19 at 11:25 +0100, Dr. David Alan Gilbert wrote: > * Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote: > > The dump-guest-memory command is used to dump an area of guest > > memory > > to a file, the piece of memory is specified by a begin address and > > a length. These parame

[Qemu-devel] [PATCH] [RESEND] hmp-commands: use long for begin and length in dump-guest-memory

2018-06-19 Thread Suraj Jitindar Singh
The dump-guest-memory command is used to dump an area of guest memory to a file, the piece of memory is specified by a begin address and a length. These parameters are specified as ints and thus have a maximum value of 4GB. This means you can't dump the guest memory past the first 4GB and instead g

Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 05:07:46PM -0500, Eric Blake wrote: > On 06/19/2018 10:17 AM, Paolo Bonzini wrote: > > On 16/06/2018 00:29, Michael S. Tsirkin wrote: > > > +static QemuOptsList qemu_dedicated_opts = { > > > +.name = "dedicated", > > > +.head = QTAILQ_HEAD_INITIALIZER(qemu_dedicated_

Re: [Qemu-devel] [PATCH v1 4/6] qga: removing switch statements, adding run_process_child

2018-06-19 Thread Marc-André Lureau
Hi On Tue, Jun 19, 2018 at 9:38 PM, Daniel Henrique Barboza wrote: > This is a cleanup of the resulting code after detaching > pmutils and Linux sys state file logic: > > - remove the SUSPEND_MODE_* macros and use an enumeration > instead. At the same time, drop the switch statements > at the sta

Re: [Qemu-devel] [PATCH v1 3/6] qga: guest_suspend: decoupling pm-utils and sys logic

2018-06-19 Thread Marc-André Lureau
Hi On Tue, Jun 19, 2018 at 9:38 PM, Daniel Henrique Barboza wrote: > Following the same logic of the previous patch, let's also > decouple the suspend logic from guest_suspend into specialized > functions, one for each strategy we support at this moment. > > Signed-off-by: Daniel Henrique Barboza

Re: [Qemu-devel] [PATCH] [RFC v2] aio: properly bubble up errors from initialization

2018-06-19 Thread Nishanth Aravamudan via Qemu-devel
On 19.06.2018 [15:35:57 -0700], Nishanth Aravamudan wrote: > On 19.06.2018 [13:14:51 -0700], Nishanth Aravamudan wrote: > > On 19.06.2018 [14:35:33 -0500], Eric Blake wrote: > > > On 06/15/2018 12:47 PM, Nishanth Aravamudan via Qemu-devel wrote: > > > > > > > } else if (s->use_linux_ai

Re: [Qemu-devel] [PATCH] [RFC v2] aio: properly bubble up errors from initialization

2018-06-19 Thread Nishanth Aravamudan via Qemu-devel
On 19.06.2018 [13:14:51 -0700], Nishanth Aravamudan wrote: > On 19.06.2018 [14:35:33 -0500], Eric Blake wrote: > > On 06/15/2018 12:47 PM, Nishanth Aravamudan via Qemu-devel wrote: > > > } else if (s->use_linux_aio) { > > > +int rc; > > > +rc = aio_setup_linux_a

[Qemu-devel] [Bug 1776920] Re: qemu-img convert on Mac OSX creates corrupt images

2018-06-19 Thread Waldemar Kozaczuk
Have I provided all necessary data and other details? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1776920 Title: qemu-img convert on Mac OSX creates corrupt images Status in QEMU: New Bug des

Re: [Qemu-devel] [PATCH 2/6] nbd: allow authorization with nbd-server-start QMP command

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 03:10:12PM -0500, Eric Blake wrote: > On 06/15/2018 10:50 AM, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > As with the previous patch to qemu-nbd, the nbd-server-start QMP command > > also needs to be able to specify authorization when enabling TLS encr

Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off

2018-06-19 Thread Eric Blake
On 06/19/2018 10:17 AM, Paolo Bonzini wrote: On 16/06/2018 00:29, Michael S. Tsirkin wrote: +static QemuOptsList qemu_dedicated_opts = { +.name = "dedicated", +.head = QTAILQ_HEAD_INITIALIZER(qemu_dedicated_opts.head), +.desc = { +{ +.name = "mem-lock", +

Re: [Qemu-devel] [PATCH v1 0/6] QGA: systemd hibernate/suspend/hybrid-sleep

2018-06-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180619193806.17419-1-danielhb...@gmail.com Subject: [Qemu-devel] [PATCH v1 0/6] QGA: systemd hibernate/suspend/hybrid-sleep === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH 00/113] Patch Round-up for stable 2.11.2, freeze on 2018-06-22

2018-06-19 Thread Bruce Rogers
>>> On 6/18/2018 at 7:41 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.11.2: > > https://github.com/mdroth/qemu/commits/stable-2.11-staging > > The release is planned for 2018-06-22: > > https://wiki.qemu.org/Planning/2.11 > > Please

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread John Snow
On 06/19/2018 05:26 PM, Amol Surati wrote: > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: >> On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: >>> >>> >>> On 06/19/2018 04:53 AM, Kevin Wolf wrote: Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > On Mon, Jun

[Qemu-devel] [PATCH v16 2/3] i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-06-19 Thread Babu Moger
Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. Also extend xlevel to 0x801E. Disable topoext on PC_COMPAT_2_12 and keep xlevel 0x800a. Signed-off-by: Babu Moger --- include/hw/i386/pc.h | 8 target/i386/cpu.c| 10 ++ 2

[Qemu-devel] [PATCH v16 1/3] i386: Fix up the Node id for CPUID_8000_001E

2018-06-19 Thread Babu Moger
This is part of topoext support. To keep the compatibility, it is better we support all the combination of nr_cores and nr_threads currently supported. By allowing more nr_cores and nr_threads, we might end up with more nodes than we can actually support with the real hardware. We need to fix up th

[Qemu-devel] [PATCH v16 0/3] i386: Enable TOPOEXT to support hyperthreading on AMD CPU

2018-06-19 Thread Babu Moger
This series enables the TOPOEXT feature for AMD CPUs. This is required to support hyperthreading on kvm guests. This addresses the issues reported in these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481253 https://bugs.launchpad.net/qemu/+bug/1703506 v16: Patches are based off of Eduard

[Qemu-devel] [PATCH v16 3/3] i386: Remove generic SMT thread check

2018-06-19 Thread Babu Moger
Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae Reviewed-by: Eduardo Habkost --- target/i386/cpu.c | 17

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > > > > > > On 06/19/2018 04:53 AM, Kevin Wolf wrote: > > > Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > > >> On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrot

Re: [Qemu-devel] [PATCH] tests: Simplify .gitignore

2018-06-19 Thread Philippe Mathieu-Daudé
On 06/19/2018 05:39 PM, Eric Blake wrote: > Commit 0bcc8e5b was yet another instance of 'git status' reporting > dirty files after an in-tree build, thanks to the new binary > tests/check-block-qdict. > > Instead of piecemeal exemptions of each new binary as they are > added, let's use git's negat

Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 05:17:45PM +0200, Paolo Bonzini wrote: > On 16/06/2018 00:29, Michael S. Tsirkin wrote: > > > > +static QemuOptsList qemu_dedicated_opts = { > > +.name = "dedicated", > > +.head = QTAILQ_HEAD_INITIALIZER(qemu_dedicated_opts.head), > > +.desc = { > > +{

[Qemu-devel] [PATCH] target/arm: Set strict alignment for ARMv6-M load/store

2018-06-19 Thread Julia Suvorova via Qemu-devel
Unlike ARMv7-M, ARMv6-M only supports naturally aligned memory accesses for 16-bit halfword and 32-bit word accesses using the LDR, LDRH, LDRSH, STR and STRH instructions. Signed-off-by: Julia Suvorova --- target/arm/translate.c | 18 -- 1 file changed, 16 insertions(+), 2 deleti

[Qemu-devel] [PATCH] tests: Simplify .gitignore

2018-06-19 Thread Eric Blake
Commit 0bcc8e5b was yet another instance of 'git status' reporting dirty files after an in-tree build, thanks to the new binary tests/check-block-qdict. Instead of piecemeal exemptions of each new binary as they are added, let's use git's negative globbing feature to exempt ALL files that have a '

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 12:54:53PM +0200, Cornelia Huck wrote: > Sorry about dragging mainframes into this, but this will only work for > homogenous device coupling, not for heterogenous. Consider my vfio-pci > + virtio-net-ccw example again: The guest cannot find out that the two > belong together

[Qemu-devel] [PATCH v2] xilinx_spips: Make dma transactions as per dma_burst_size

2018-06-19 Thread Sai Pavan Boddu
Qspi dma has a burst length of 64 bytes, So limit transaction length to 64 max. Signed-off-by: Sai Pavan Boddu --- hw/ssi/xilinx_spips.c | 20 +--- include/hw/ssi/xilinx_spips.h | 5 - 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/hw/ssi/xilinx_spip

Re: [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-06-19 Thread Daniel Henrique Barboza
Hi, Sorry for the delay. I'll summarize what I've understood from the discussion so far: - query-target is the wrong place for this flag. query-machines is (less) wrong because it is not a static property of the machine object - a new "query-current-machine" can be created to host these dynam

Re: [Qemu-devel] [PATCH] xilinx_spips: Make dma transactions as per dma_burst_size

2018-06-19 Thread Sai Pavan Boddu
Hi Edgar, I got your suggestion below. Will be sending a V2 asap. Thanks, Sai Pavan > -Original Message- > From: Edgar E. Iglesias [mailto:edgar.igles...@xilinx.com] > Sent: Thursday, June 14, 2018 4:55 PM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org; Alistair Francis ; Peter > Cro

Re: [Qemu-devel] [PATCH v5 3/6] nbd/server: add nbd_meta_empty_or_pattern helper

2018-06-19 Thread Eric Blake
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add nbd_meta_pattern() and nbd_meta_empty_or_pattern() helpers for metadata query parsing. nbd_meta_pattern() will be reused for "qemu" s/for/for the/ namespace in following patches. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [PATCH] [RFC v2] aio: properly bubble up errors from initialization

2018-06-19 Thread Nishanth Aravamudan via Qemu-devel
On 19.06.2018 [14:35:33 -0500], Eric Blake wrote: > On 06/15/2018 12:47 PM, Nishanth Aravamudan via Qemu-devel wrote: > > laio_init() can fail for a couple of reasons, which will lead to a NULL > > pointer dereference in laio_attach_aio_context(). > > > > To solve this, add a aio_setup_linux_aio()

Re: [Qemu-devel] [PATCH 2/6] nbd: allow authorization with nbd-server-start QMP command

2018-06-19 Thread Eric Blake
On 06/15/2018 10:50 AM, Daniel P. Berrangé wrote: From: "Daniel P. Berrange" As with the previous patch to qemu-nbd, the nbd-server-start QMP command also needs to be able to specify authorization when enabling TLS encryption. First the client must create a QAuthZ object instance using the 'ob

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Siwei Liu
On Tue, Jun 19, 2018 at 3:54 AM, Cornelia Huck wrote: > On Fri, 15 Jun 2018 10:06:07 -0700 > Siwei Liu wrote: > >> On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: >> > On Thu, 14 Jun 2018 18:57:11 -0700 >> > Siwei Liu wrote: >> > >> >> Thank you for sharing your thoughts, Cornelia. With q

Re: [Qemu-devel] [PATCH 1/6] qemu-nbd: add support for authorization of TLS clients

2018-06-19 Thread Eric Blake
On 06/15/2018 10:50 AM, Daniel P. Berrangé wrote: From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use the NBD server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. Thi

Re: [Qemu-devel] [PATCH v2] migration: fix crash in when incoming client channel setup fails

2018-06-19 Thread Juan Quintela
Daniel P. Berrangé wrote: > The way we determine if we can start the incoming migration was > changed to use migration_has_all_channels() in: > > commit 428d89084c709e568f9cd301c2f6416a54c53d6d > Author: Juan Quintela > Date: Mon Jul 24 13:06:25 2017 +0200 > > migration: Create migrat

[Qemu-devel] [PATCH] simpletrace: Convert name from mapping record to str

2018-06-19 Thread Eduardo Habkost
The rest of the code assumes that idtoname is a (int -> str) dictionary, so convert the data accordingly. This is necessary to make the script work with Python 3 (where reads from a binary file return 'bytes' objects, not 'str'). Fixes the following error: $ python3 ./scripts/simpletrace.py tr

[Qemu-devel] [PATCH v1 6/6] qga: removing bios_supports_mode

2018-06-19 Thread Daniel Henrique Barboza
bios_support_mode verifies if the guest has support for a certain suspend mode but it doesn't inform back which suspend tool provides it. The caller, guest_suspend, executes all suspend strategies in order again. After adding systemd suspend support, bios_support_mode now will verify for support f

[Qemu-devel] [PATCH v1 5/6] qga: adding systemd hibernate/suspend/hybrid-sleep support

2018-06-19 Thread Daniel Henrique Barboza
pmutils isn't being supported by newer OSes like Fedora 27 or Mint. This means that the only suspend option QGA offers for these guests are writing directly into the Linux sys state file. This also means that QGA also loses the ability to do hybrid suspend in those guests - this suspend mode is on

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-19 Thread Sebastian Bauer
Hello David, Am 2018-06-19 06:36, schrieb David Gibson: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. Please make sure your patches are against the current

[Qemu-devel] [PATCH v1 3/6] qga: guest_suspend: decoupling pm-utils and sys logic

2018-06-19 Thread Daniel Henrique Barboza
Following the same logic of the previous patch, let's also decouple the suspend logic from guest_suspend into specialized functions, one for each strategy we support at this moment. Signed-off-by: Daniel Henrique Barboza --- qga/commands-posix.c | 170 +++

[Qemu-devel] [PATCH v1 1/6] qga: refactoring qmp_guest_suspend_* functions

2018-06-19 Thread Daniel Henrique Barboza
To be able to add new suspend mechanisms we need to detach the existing QMP functions from the current implementation specifics. At this moment we have functions such as qmp_guest_suspend_ram calling bios_suspend_mode and guest_suspend passing the pmutils command and arguments as parameters. This

[Qemu-devel] [PATCH v1 2/6] qga: bios_supports_mode: decoupling pm-utils and sys logic

2018-06-19 Thread Daniel Henrique Barboza
In bios_supports_mode there is a verification to assert if the chosen suspend mode is supported by the pmutils tools and, if not, we see if the Linux sys state files supports it. This verification is done in the same function, one after the other, and it works for now. But, when adding a new suspe

[Qemu-devel] [PATCH v1 4/6] qga: removing switch statements, adding run_process_child

2018-06-19 Thread Daniel Henrique Barboza
This is a cleanup of the resulting code after detaching pmutils and Linux sys state file logic: - remove the SUSPEND_MODE_* macros and use an enumeration instead. At the same time, drop the switch statements at the start of each function and use the enumeration index to get the right binary/argume

[Qemu-devel] [PATCH v1 0/6] QGA: systemd hibernate/suspend/hybrid-sleep

2018-06-19 Thread Daniel Henrique Barboza
This series adds systemd suspend support for QGA. Some newer guests don't have pmutils anymore, leaving us with just the Linux state file mechanism to suspend the guest OS, which does not support hybrid-sleep. With this implementation, QGA is now able to hybrid suspend newer guests again. Most of

Re: [Qemu-devel] [PATCH] [RFC v2] aio: properly bubble up errors from initialization

2018-06-19 Thread Eric Blake
On 06/15/2018 12:47 PM, Nishanth Aravamudan via Qemu-devel wrote: laio_init() can fail for a couple of reasons, which will lead to a NULL pointer dereference in laio_attach_aio_context(). To solve this, add a aio_setup_linux_aio() function which is called before aio_get_linux_aio() where it is c

Re: [Qemu-devel] [PULL 08/26] qobject: Move block-specific qdict code to block-qdict.c

2018-06-19 Thread Eric Blake
On 06/15/2018 09:20 AM, Kevin Wolf wrote: From: Markus Armbruster Pure code motion, except for two brace placements and a comment tweaked to appease checkpatch. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- qobject/block-qdict.c | 640 +

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 02:02:10PM -0500, Venu Busireddy wrote: > On 2018-06-19 21:53:01 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 01:36:17PM -0500, Venu Busireddy wrote: > > > On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jun 19, 2018 at 01:14:06PM -050

Re: [Qemu-devel] [PATCH v5 2/6] nbd/server: refactor NBDExportMetaContexts

2018-06-19 Thread Eric Blake
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Use NBDExport pointer instead of just export name: there no needs to s/no needs/is no need/ store duplicated name in the struct, moreover, NBDExport will be used further. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server

Re: [Qemu-devel] [PATCH v2 05/11] hw/arm/virt: GICv3 DT node with one or two redistributor regions

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 20:53, Laszlo Ersek wrote: > Hi Eric, > > sorry about the late followup. I have one question (mainly for Ard): > > On 06/15/18 16:28, Eric Auger wrote: >> This patch allows the creation of a GICv3 node with 1 or 2 >> redistributor regions depending on the number of smu_cpus. >>

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 21:53:01 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 01:36:17PM -0500, Venu Busireddy wrote: > > On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > > > > On 2018-06-19 20:24:12 +0300, Michael S

Re: [Qemu-devel] [PATCH V7 RESEND 12/17] savevm: split the process of different stages for loadvm/savevm

2018-06-19 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > On Wed, May 16, 2018 at 2:56 AM, Dr. David Alan Gilbert > wrote: > > > * Zhang Chen (zhangc...@gmail.com) wrote: > > > From: zhanghailiang > > > > > > There are several stages during loadvm/savevm process. In different > > stage, > > > migration incomi

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 01:36:17PM -0500, Venu Busireddy wrote: > On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > > > On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jun 19, 2018 at 11:32:26AM -050

Re: [Qemu-devel] [PATCH 6/7] block/qcow2-refcount: fix out-of-file L1 entries to be zero

2018-06-19 Thread Eric Blake
On 06/19/2018 01:34 PM, Vladimir Sementsov-Ogievskiy wrote: Zero out corrupted L1 table entry, which reference L2 table out of underlying file. Zero L1 table entry means that "the L2 table and all clusters described by this L2 table are unallocated." Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v2 05/11] hw/arm/virt: GICv3 DT node with one or two redistributor regions

2018-06-19 Thread Laszlo Ersek
Hi Eric, sorry about the late followup. I have one question (mainly for Ard): On 06/15/18 16:28, Eric Auger wrote: > This patch allows the creation of a GICv3 node with 1 or 2 > redistributor regions depending on the number of smu_cpus. > The second redistributor region is located just after the

Re: [Qemu-devel] [PATCH 3/7] block/qcow2-refcount: check_refcounts_l2: refactor compressed case

2018-06-19 Thread Eric Blake
On 06/19/2018 01:34 PM, Vladimir Sementsov-Ogievskiy wrote: Separate offset and size of compressed cluster. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) Hmm, I wonder if this duplicates my pend

Re: [Qemu-devel] [PATCH v6 5/6] iotests: Add new test 214 for max compressed cluster offset

2018-06-19 Thread Eric Blake
On 04/26/2018 07:10 AM, Alberto Garcia wrote: On Thu 26 Apr 2018 04:51:28 AM CEST, Eric Blake wrote: If you have a capable file system (tmpfs is good, ext4 not so much; run ./check with TEST_DIR pointing to a good location so as not to skip the test), it's actually possible to create a qcow2 fil

Re: [Qemu-devel] [PATCH] hw/pci-host/xilinx-pcie: don't make "io" region be RAM

2018-06-19 Thread Alistair Francis
On Tue, Jun 19, 2018 at 5:07 AM, Peter Maydell wrote: > Currently we use memory_region_init_rom_nomigrate() to create > the "io" memory region to pass to pci_register_root_bus(). > This is a dummy region, because this PCI controller doesn't > support accesses to PCI IO space. > > There is no reaso

Re: [Qemu-devel] [PATCH v6 0/6] minor qcow2 compression improvements

2018-06-19 Thread Eric Blake
ping On 04/25/2018 09:51 PM, Eric Blake wrote: Even though v5 was posted earlier today, it was worth a respin: - 2/6: add R-b [Berto] - 4/6, 6/6: improve commit messages [Max] - 5/6: new patch, with an iotests proving that 4/6 is a bug fix [Max] The new test is rather slow (nearly 90 seconds fo

Re: [Qemu-devel] [PATCH 2/7] block/qcow2-refcount: avoid eating RAM

2018-06-19 Thread Eric Blake
On 06/19/2018 01:34 PM, Vladimir Sementsov-Ogievskiy wrote: qcow2_inc_refcounts_imrt() (through realloc_refcount_array()) can eat unpredicted amount of memory on corrupted table entries, which are s/unpredicted/an unpredictable/ referencing regions far beyond the end of file. Prevent this, b

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > > On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote: > > > > Add a "Vendor-Specific" capability to t

[Qemu-devel] [PATCH 5/7] block/qcow2-refcount: check_refcounts_l2: split fix_l2_entry_to_zero

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
Split entry repairing to separate function, to be reused later. Note: entry in in-memory l2 table (local variable in check_refcounts_l2) is not updated after this patch. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 147

[Qemu-devel] [PATCH 3/7] block/qcow2-refcount: check_refcounts_l2: refactor compressed case

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
Separate offset and size of compressed cluster. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 28d21bedc3..42167b7040 100644 --- a/bl

Re: [Qemu-devel] [PATCH v5 1/6] nbd/server: fix trace

2018-06-19 Thread Eric Blake
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Return code = 1 doesn't mean that we parsed base:allocation. Use correct traces in both -parsed and -skipped cases. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 9 +++-- 1 file changed, 7 insertions(+), 2 delet

[Qemu-devel] [PATCH 7/7] block/qcow2-refcount: fix out-of-file L2 entries to be read-as-zero

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
Rewrite corrupted L2 table entry, which reference space out of underlying file. Make this L2 table entry read-as-all-zeros without any allocation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 32 1 file changed, 32 insertions(+) diff

[Qemu-devel] [PATCH 1/7] block/qcow2-refcount: fix check_oflag_copied

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
Increase corruptions_fixed only after successful fix. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 18c729aa27..f9d095aa2d 100644 --- a/block

[Qemu-devel] [PATCH 6/7] block/qcow2-refcount: fix out-of-file L1 entries to be zero

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
Zero out corrupted L1 table entry, which reference L2 table out of underlying file. Zero L1 table entry means that "the L2 table and all clusters described by this L2 table are unallocated." Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 37 +

[Qemu-devel] [PATCH 4/7] block/qcow2-refcount: check_refcounts_l2: reduce ignored overlaps

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
Reduce number of structures ignored in overlap check: when checking active table ignore active tables, when checking inactive table ignore inactive ones. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH 0/7] qcow2 check improvements

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
Hi all! We've faced the following problem: after host fs corruption, vm images becomes invalid. And which is interesting, starting qemu-img check on them led to allocating of the whole RAM and then killing qemu-img by OOM Killer. This was due to corrupted l2 entries, which referenced clusters far

[Qemu-devel] [PATCH 2/7] block/qcow2-refcount: avoid eating RAM

2018-06-19 Thread Vladimir Sementsov-Ogievskiy
qcow2_inc_refcounts_imrt() (through realloc_refcount_array()) can eat unpredicted amount of memory on corrupted table entries, which are referencing regions far beyond the end of file. Prevent this, by skipping such regions from further processing. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote: > > > Add a "Vendor-Specific" capability to the PCIe bridge, to contain the > > > "Group Identifier" (UUID) t

Re: [Qemu-devel] [PATCH v2] migration: fix crash in when incoming client channel setup fails

2018-06-19 Thread Eric Blake
On 06/19/2018 11:35 AM, Daniel P. Berrangé wrote: The way we determine if we can start the incoming migration was changed to use migration_has_all_channels() in: commit 428d89084c709e568f9cd301c2f6416a54c53d6d Author: Juan Quintela Date: Mon Jul 24 13:06:25 2017 +0200 migration

Re: [Qemu-devel] [PATCH 00/113] Patch Round-up for stable 2.11.2, freeze on 2018-06-22

2018-06-19 Thread Cole Robinson
On 06/18/2018 09:41 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.11.2: > > https://github.com/mdroth/qemu/commits/stable-2.11-staging > > The release is planned for 2018-06-22: > > https://wiki.qemu.org/Planning/2.11 > > Please respond

Re: [Qemu-devel] [virtio-dev] Re: [PATCH virtio 1/1] Add "Group Identifier" support to virtio PCI capabilities.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 21:12:17 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 12:54:06PM -0500, Venu Busireddy wrote: > > On 2018-06-19 20:30:06 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 19, 2018 at 11:32:28AM -0500, Venu Busireddy wrote: > > > > Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group

  1   2   3   4   >