From: Mark Cave-Ayland
The 6522 VIA timer frequency cannot be set by altering registers within the
device itself and hence it is a fixed property of the machine.
Move the initialisation of the timer frequency to the mos6522 reset function
and ensure that any subclasses always call the parent res
From: Joel Stanley
The powerpc Linux kernel[1] and skiboot firmware[2] recently gained changes
that cause the Processor Compatibility Register (PCR) SPR to be cleared.
These changes cause Linux to fail to boot on the Qemu powernv machine
with an error:
Trying to write privileged spr 338 (0x152
From: David Hildenbrand
Factor out cpu core unplug into separate function from
spapr_core_release(). Then use generic hotplug_handler_unplug() to trigger
cpu core unplug, which would call spapr_machine_device_unplug() ->
spapr_core_unplug() in the end.
This way unplug operation is not buried in
From: Mark Cave-Ayland
This was accidentally introduced when extracting the 6522 VIA functionality
from the CUDA device, and prevents loadvm from completing successfully.
Signed-off-by: Mark Cave-Ayland
Signed-off-by: David Gibson
---
hw/misc/mos6522.c | 2 +-
1 file changed, 1 insertion(+),
From: Mark Cave-Ayland
Commits b6712ea391 removed the macio_init() function but missed the header
prototype in mac.h. Remove it since it is no longer needed.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: David Gibson
---
hw/ppc/mac.h | 3 ---
1 file chang
From: Suraj Jitindar Singh
Factor out the parsing of struct kvm_ppc_cpu_char in
kvmppc_get_cpu_characteristics() into a separate function for each cap
for simplicity.
Signed-off-by: Suraj Jitindar Singh
Signed-off-by: David Gibson
---
target/ppc/kvm.c | 59
From: Philippe Mathieu-Daudé
Missed while moved in 7092e84d42b.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: David Gibson
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a40f558694..5286a1519c 100644
--- a/MAINTAINE
From: Philippe Mathieu-Daudé
Introduced in 51f233ec92c.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: David Gibson
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5286a1519c..8a94517e9e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@
From: Cédric Le Goater
VIO devices have an "irq" property that can be used by the sPAPR IRQ
allocator as an IRQ number hint. But it is not set in QEMU nor in
libvirt. It brings unnecessary complexity to the underlying layers
managing the IRQ number space and it is in full opposition with the
new
From: Thomas Huth
fprintf() and qemu_log_separate() are frowned upon these days for printing
logging information in QEMU. Accessing the wrong SPRs indicates wrong guest
behaviour in most cases, and we've got a proper way to log such situations,
which is the qemu_log_mask(LOG_GUEST_ERROR, ...) fun
From: Mark Cave-Ayland
Commit 72d3d8f052 "hw/isa/superio: Add a keyboard/mouse controller (8042)"
added an 8042 keyboard device to the PC87312 superio device to replace that
being used by the prep machine.
Unfortunately this commit didn't do the same for the 40p machine which broke
the keyboard
From: Philippe Mathieu-Daudé
Use error_report() + abort() instead of error_setg(&error_abort),
as suggested by the "qapi/error.h" documentation:
Please don't error_setg(&error_fatal, ...), use error_report() and
exit(), because that's more obvious.
Likewise, don't error_setg(&error_a
From: Mark Cave-Ayland
>From observation of various OS sources it can be seen that the token register
introduced in 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" is not
required, since the only register currently implemented is the uninorth hardware
version which is read-only.
Remove t
From: Mark Cave-Ayland
The Linux sandalfoot zImage has an initialisation process which resets the
VGA controller by setting all the BAR addresses to zero to access the VGA
ioports at their legacy addresses.
Unfortunately setting the framebuffer BAR to address 0 makes the framebuffer
memory overl
The following changes since commit 2afc4e3df80d947dd1bd42ce80278f591b35c74a:
Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-06-11'
into staging (2018-06-11 15:31:20 +0100)
are available in the Git repository at:
git://github.com/dgibson/qemu.git tags/ppc-for-3.0-2018061
From: Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: David Gibson
---
hw/misc/macio/macio.c | 3 +++
hw/misc/macio/trace-events | 4
2 files changed, 7 insertions(+)
diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c
inde
From: Nicholas Piggin
This allows KVM with the Book3S radix MMU mode to take advantage of
THP and install larger pages in the partition scope page tables (the
host translation).
Signed-off-by: Nicholas Piggin
Signed-off-by: David Gibson
---
include/qemu/osdep.h | 3 ++-
1 file changed, 2 inse
From: BALATON Zoltan
Signed-off-by: BALATON Zoltan
Signed-off-by: David Gibson
---
hw/ppc/ppc440_pcix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c
index b1307e6477..d8af04b70f 100644
--- a/hw/ppc/ppc440_pcix.c
+++ b/hw/ppc/pp
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert (git)" writes:
>>
>> > From: "Dr. David Alan Gilbert"
>> >
>> > Allow a bunch of the info commands to be used in preconfig.
>> >
>> > version, chardev, name, uuid,memdev, iothreads
>> >
On Tue, 06/12 14:24, Peter Xu wrote:
> Hi,
>
> For example, I wanted to compile QEMU once and install it on multiple
> systems. What would be the suggested way to do so?
>
> Is there something similar to "make bin-rpmpkg" for Linux?
>
> Thanks in advance,
No. The big question is the libraries.
From: Junyan He
Because we need to make sure the pmem kind memory data is synced
after migration, we choose to call pmem_persist() when the migration
finish. This will make sure the data of pmem is safe and will not
lose if power is off.
Signed-off-by: Junyan He
Reviewed-by: Stefan Hajnoczi
--
From: Junyan He
The nvdimm kind memory does not support post copy now.
We disable post copy if we have nvdimm memory and print some
log hint to user.
Signed-off-by: Junyan He
Reviewed-by: Stefan Hajnoczi
---
migration/ram.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/migratio
From: Junyan He
Guest writes to vNVDIMM labels are intercepted and performed on the
backend by QEMU. When the backend is a real persistent memort, QEMU
needs to take proper operations to ensure its write persistence on the
persistent memory. Otherwise, a host power failure may result in the
loss
From: Junyan He
QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and
live migration. If the backend is on the persistent memory, QEMU needs
to take proper operations to ensure its writes persistent on the
persistent memory. Otherwise, a host power failure may result in the
loss the
From: Junyan He
Add a pair of configure options --{enable,disable}-libpmem to control
whether QEMU is compiled with PMDK libpmem [1].
QEMU may write to the host persistent memory (e.g. in vNVDIMM label
emulation and live migration), so it must take the proper operations
to ensure the persistence
From: Junyan He
When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it
needs to know whether the backend storage is a real persistent memory,
in order to decide whether special operations should be performed to
ensure the data persistence.
This boolean option 'pmem' allows users to s
From: Junyan He
As more flag parameters besides the existing 'share' are going to be
added to following functions
memory_region_init_ram_from_file
qemu_ram_alloc_from_fd
qemu_ram_alloc_from_file
let's switch them to use the 'flags' parameters so as to ease future
flag additions.
The existi
From: Junyan He
We need to use these flags in other files rather than just in exec.c,
For example, RAM_SHARED should be used when create a ram block from file.
We expose them the exec/memory.h
Signed-off-by: Junyan He
Reviewed-by: Stefan Hajnoczi
---
exec.c| 20 ---
Hi,
For example, I wanted to compile QEMU once and install it on multiple
systems. What would be the suggested way to do so?
Is there something similar to "make bin-rpmpkg" for Linux?
Thanks in advance,
--
Peter Xu
On 11.06.2018 14:03, Viktor VM Mihajlovski wrote:
> On 11.06.2018 13:12, Thomas Huth wrote:
>> On 11.06.2018 11:08, Viktor VM Mihajlovski wrote:
>>> On 07.06.2018 14:22, Thomas Huth wrote:
This patch series adds pxelinux.cfg-style network booting to the s390-ccw
firmware. The core pxelinu
On 06/12/2018 07:58 AM, David Gibson wrote:
> On Wed, Jun 06, 2018 at 09:04:10AM +0200, Cédric Le Goater wrote:
>> On 06/06/2018 08:39 AM, David Gibson wrote:
>>> On Wed, May 30, 2018 at 12:07:54PM +0200, Cédric Le Goater wrote:
Based on previous work done in skiboot, the physical mapping arra
Andreas Färber writes:
> Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert:
>> * Andreas Färber (afaer...@suse.de) wrote:
>>> Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco:
For debugging purposes it is very useful to:
- See the description of the field. This information is al
On Wed, Jun 06, 2018 at 09:04:10AM +0200, Cédric Le Goater wrote:
> On 06/06/2018 08:39 AM, David Gibson wrote:
> > On Wed, May 30, 2018 at 12:07:54PM +0200, Cédric Le Goater wrote:
> >> Based on previous work done in skiboot, the physical mapping array
> >> helps in calculating the MMIO ranges of
On Mon, Jun 11, 2018 at 05:45:49PM +0100, Stefan Hajnoczi wrote:
> On Fri, Jun 08, 2018 at 10:18:25AM +0200, Markus Armbruster wrote:
> > Stefan Hajnoczi writes:
> > > On Fri, Jun 08, 2018 at 12:42:35PM +0800, Peter Xu wrote:
> > >> On Thu, Jun 07, 2018 at 01:53:01PM +0200, Markus Armbruster wrote
I do have time, the function mentioned in last comments isn't difficult to
implement, but I wonder how to write corresponding qtest-case for cortex-m3. You
know, becuase #current# QEMU doesn't surpport the cortex-m3 instruction, I don't
know how to prove correctness of hex loader. For example, in
On 一, 2018-06-11 at 19:55 -0700, Dan Williams wrote:
> On Mon, Jun 11, 2018 at 9:26 AM, Stefan Hajnoczi > wrote:
> >
> > On Mon, Jun 11, 2018 at 06:54:25PM +0800, Zhang Yi wrote:
> > >
> > > Nvdimm driver use Memory hot-plug APIs to map it's pmem resource,
> > > which at a section granularity.
>
Hi,
> > Now let's review the three commands:
> >
> > * Gerd, why does "info usbhost" have no QMP equivalent?
Works only when running qemu directly, in the libvirt sandbox qemu
hasn't the permissions needed to scan the host usb bus so that would be
rather pointless ...
cheers,
Gerd
On Tue, Jun 12, 2018 at 11:19:14AM +0800, Xiao Guangrong wrote:
>
>
> On 06/11/2018 04:00 PM, Peter Xu wrote:
> > On Mon, Jun 04, 2018 at 05:55:08PM +0800, guangrong.x...@gmail.com wrote:
> > > From: Xiao Guangrong
> > >
> > > Background
> > > --
> > > Current implementation of compress
In default_caps_with_cpu() we set spapr_cap_cfpc to broken for POWER8
processors and before.
Since we no longer require private l1d cache on POWER8 for this cap to
be set to workaround change this to default to broken for POWER7
processors and before.
Signed-off-by: Suraj Jitindar Singh
Reviewed
For cap_ppc_safe_cache to be set to workaround, we require both a l1d
cache flush instruction and private l1d cache.
On POWER8 don't require private l1d cache. This means a guest on a
POWER8 machine can make use of the cache flush workarounds.
Signed-off-by: Suraj Jitindar Singh
---
V1 -> V2:
On 6/11/2018 7:17 PM, Michael S. Tsirkin wrote:
On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote:
On 2018年06月12日 01:26, Michael S. Tsirkin wrote:
On Mon, May 07, 2018 at 04:09:54PM -0700, Sridhar Samudrala wrote:
This feature bit can be used by hypervisor to indicate virtio_net devi
On Tue, Jun 12, 2018 at 07:26:25AM +0800, Jie Wang wrote:
> if laio_init create linux_aio failed and return NULL, NULL pointer
> dereference will occur when laio_attach_aio_context dereference
> linux_aio in aio_get_linux_aio. Let's avoid it and report error.
>
> Signed-off-by: Jie Wang
Reviewed
On 06/11/2018 04:00 PM, Peter Xu wrote:
On Mon, Jun 04, 2018 at 05:55:08PM +0800, guangrong.x...@gmail.com wrote:
From: Xiao Guangrong
Background
--
Current implementation of compression and decompression are very
hard to be enabled on productions. We noticed that too many wait-wake
On Tue, Jun 12, 2018 at 10:42:25AM +0800, Xiao Guangrong wrote:
>
>
> On 06/11/2018 03:39 PM, Peter Xu wrote:
> > On Mon, Jun 04, 2018 at 05:55:09PM +0800, guangrong.x...@gmail.com wrote:
> > > From: Xiao Guangrong
> > >
> > > Instead of putting the main thread to sleep state to wait for
> > >
On Mon, Jun 11, 2018 at 9:26 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 11, 2018 at 06:54:25PM +0800, Zhang Yi wrote:
>> Nvdimm driver use Memory hot-plug APIs to map it's pmem resource,
>> which at a section granularity.
>>
>> When QEMU emulated the vNVDIMM device, decrease the label-storage,
>> QE
On 06/11/2018 03:39 PM, Peter Xu wrote:
On Mon, Jun 04, 2018 at 05:55:09PM +0800, guangrong.x...@gmail.com wrote:
From: Xiao Guangrong
Instead of putting the main thread to sleep state to wait for
free compression thread, we can directly post it out as normal
page that reduces the latency a
On Mon, Jun 11, 2018 at 02:16:55PM +0200, David Hildenbrand wrote:
> We can assign and verify the slot before realizing and trying to plug.
> reading/writing the slot property should never change, so let's reduce
> error handling a bit by using &error_abort.
>
> Signed-off-by: David Hildenbrand
As qemu_new_net_client create new ncs but error happens later,
ncs will be left in global net_clients list and we can't use them any
more, so we need to cleanup them.
Signed-off-by: linzhecheng
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 608b837175..a39f9c9974 100644
--- a/net/vhost-u
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180611174243.31070-1-ehabk...@redhat.com
Subject: [Qemu-devel] [PULL 00/13] Python queue, 2018-06-11
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --
On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote:
>
>
> On 2018年06月12日 01:26, Michael S. Tsirkin wrote:
> > On Mon, May 07, 2018 at 04:09:54PM -0700, Sridhar Samudrala wrote:
> > > This feature bit can be used by hypervisor to indicate virtio_net device
> > > to
> > > act as a standby
As my previos reply said, the mirror_exit is done in
aio_poll(qemu_get_aio_context(), true). In
mirror_exit, the bs willl be free by bdrv_unref. So it will make a
Null pointer access in the follow-up procedure in bdrv_set_aio_context.
So we should add bdrv_ref for it to avoid bs freed in mirror_
On 2018年06月11日 15:31, linzhecheng wrote:
As qemu_new_net_client create new ncs but error happens later,
ncs will be left in global net_clients list, so we need to cleanup them.
Signed-off-by: linzhecheng
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 608b837175..1c7ee48b60 100644
--
On 2018年06月11日 17:48, Thomas Huth wrote:
On 11.06.2018 11:23, Lin Ma wrote:
If user forgets to provide any backend types for '-netdev' in qemu CLI,
It triggers seg fault.
e.g.
Expected:
$ qemu -netdev id=net0
qemu-system-x86_64: Parameter 'type' is missing
Actual:
$ qemu -netdev id=net0
Se
The appended paves the way for leveraging the host FPU for a subset
of guest FP operations. For most guest workloads (e.g. FP flags
aren't ever cleared, inexact occurs often and rounding is set to the
default [to nearest]) this will yield sizable performance speedups.
The approach followed here av
Performance results for fp-bench:
1. Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
- before:
sqrt-single: 43.27 MFlops
sqrt-double: 24.81 MFlops
- after:
sqrt-single: 297.94 MFlops
sqrt-double: 210.46 MFlops
2. ARM Aarch64 A57 @ 2.4GHz
- before:
sqrt-single: 12.41 MFlops
sqrt-double: 6.22 MFlops
- aft
This will allow us to measure the performance impact of FP emulation
optimizations. Note that we can measure both directly the impact
on the softfloat functions (with "-t soft"), or the impact on an
emulated workload (call with "-t host" and run under qemu user-mode).
Signed-off-by: Emilio G. Cota
These are a few muladd-related operations that the original IBM syntax
does not specify; model files for these are in muladd.fptest.
Signed-off-by: Emilio G. Cota
---
tests/fp/fp-test.c | 24
tests/fp/muladd.fptest | 51 +++
Performance results (single and double precision) for fp-bench:
1. Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
- before:
add-single: 135.07 MFlops
add-double: 131.60 MFlops
sub-single: 130.04 MFlops
sub-double: 133.01 MFlops
- after:
add-single: 443.04 MFlops
add-double: 301.95 MFlops
sub-single: 411
Performance results for fp-bench:
1. Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
- before:
fma-single: 74.73 MFlops
fma-double: 74.54 MFlops
- after:
fma-single: 203.37 MFlops
fma-double: 169.37 MFlops
2. ARM Aarch64 A57 @ 2.4GHz
- before:
fma-single: 23.24 MFlops
fma-double: 23.70 MFlops
- after:
f
On Mon, Jun 11, 2018 at 02:16:54PM +0200, David Hildenbrand wrote:
> We'll be factoring out some pc-dimm specific and some memory-device
> checks next.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
ppc parts
Acked-by: David Gibson
> ---
> hw/i386/pc.c | 2 ++
>
These will gain some users very soon.
Signed-off-by: Emilio G. Cota
---
include/fpu/softfloat.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index 1fbece5..08f63ae 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloa
On 2018年06月12日 01:26, Michael S. Tsirkin wrote:
On Mon, May 07, 2018 at 04:09:54PM -0700, Sridhar Samudrala wrote:
This feature bit can be used by hypervisor to indicate virtio_net device to
act as a standby for another device with the same MAC address.
I tested this with a small change to t
Cc: Bastian Koppelmann
Reviewed-by: Bastian Koppelmann
Signed-off-by: Emilio G. Cota
---
target/tricore/fpu_helper.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c
index df16290..31df462 100644
--- a/target/
This paves the way for upcoming work.
Cc: Bastian Koppelmann
Reviewed-by: Bastian Koppelmann
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/fpu/softfloat.h | 20
1 file changed, 20 insertions(+)
diff --git a/include/fpu/softfloat.h b/include/fpu/softf
Performance results for fp-bench:
1. Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
- before:
cmp-single: 113.01 MFlops
cmp-double: 115.54 MFlops
- after:
cmp-single: 527.83 MFlops
cmp-double: 457.21 MFlops
2. ARM Aarch64 A57 @ 2.4GHz
- before:
cmp-single: 39.32 MFlops
cmp-double: 39.80 MFlops
- after:
Sending this respin (little more than a rebase) in case there's
reviewer bandwidth available until the soft-freeze in 3 weeks.
v3: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00455.html
Not much has changed since April's v3:
- Rebase to current master, fixing some conflicts.
- Ad
Performance results for fp-bench:
1. Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
- before:
div-single: 34.84 MFlops
div-double: 34.04 MFlops
- after:
div-single: 275.23 MFlops
div-double: 216.38 MFlops
2. ARM Aarch64 A57 @ 2.4GHz
- before:
div-single: 9.33 MFlops
div-double: 9.30 MFlops
- after:
div
On Mon, Jun 11, 2018 at 02:16:49PM +0200, David Hildenbrand wrote:
> This might look like a step backwards, but it is not. get_memory_region()
> should not be called on uninititalized devices. In general, only
> properties should be access, but no "derived" satte like the memory
> region.
>
> 1. W
Performance results for fp-bench:
1. Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
- before:
mul-single: 126.91 MFlops
mul-double: 118.28 MFlops
- after:
mul-single: 258.02 MFlops
mul-double: 197.96 MFlops
2. ARM Aarch64 A57 @ 2.4GHz
- before:
mul-single: 37.42 MFlops
mul-double: 38.77 MFlops
- after:
glibc >= 2.25 defines canonicalize in commit eaf5ad0
(Add canonicalize, canonicalizef, canonicalizel., 2016-10-26).
Given that we'll be including soon, prepare
for this by prefixing our canonicalize() with sf_ to avoid
clashing with the libc's canonicalize().
Cc: Bastian Koppelmann
Reported-by:
On Mon, Jun 11, 2018 at 02:16:48PM +0200, David Hildenbrand wrote:
> Unused, so let's remove it.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
> ---
> backends/hostmem.c | 3 +--
> hw/mem/nvdimm.c | 4 ++--
> hw/mem/pc-dimm.c | 4 ++--
> hw/misc/ivshmem
On Mon, Jun 11, 2018 at 02:16:52PM +0200, David Hildenbrand wrote:
> This is guaranteed by passing into host_memory_backend_get_memory() a
> value that is not NULL - which is what we always do.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
> ---
> hw/mem/pc-dimm.c | 15 ++
This will allow us to run correctness tests against our
FP implementation. The test can be run in two modes (called
"testers"): host and soft. With the former we check the results
and FP flags on the host machine against the model.
With the latter we check QEMU's fpu primitives against the
model. N
On Mon, Jun 11, 2018 at 02:16:51PM +0200, David Hildenbrand wrote:
> We already verify when realizing that the memdev property has been
> set. We have no more accesses to get_memory_region() before the device
> is realized.
>
> So this function will never fail. Remove the stale check and the
> err
On Mon, Jun 11, 2018 at 02:16:53PM +0200, David Hildenbrand wrote:
> We can reuse pc_dimm_get_memory_region() now, as both functions are
> (besides the assert which is also correct), equal.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
> ---
> hw/mem/pc-dimm.c | 7 +--
>
On Mon, Jun 11, 2018 at 02:16:50PM +0200, David Hildenbrand wrote:
> "size" should not be queried before the device was realized. Let' make
> that explicit.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
> ---
> hw/mem/pc-dimm.c | 6 ++
> 1 file changed, 6 insertions(+)
>
On Mon, 06/11 11:31, l00284672 wrote:
> I tried your patch with my modification below can slove this problem.
>
> void blk_set_aio_context(BlockBackend *blk, AioContext *new_context)
> {
> BlockDriverState *bs = blk_bs(blk);
> ThrottleGroupMember *tgm = &blk->public.throttle_group_member;
if laio_init create linux_aio failed and return NULL, NULL pointer
dereference will occur when laio_attach_aio_context dereference
linux_aio in aio_get_linux_aio. Let's avoid it and report error.
Signed-off-by: Jie Wang
---
block/file-posix.c | 19 +--
util/async.c | 5 +++
Ping?
On 2018/5/16 17:18, Shannon Zhao wrote:
> According to KVM commit 75d61fbc, it needs to delete the slot before
> changing the KVM_MEM_READONLY flag. But QEMU commit 235e8982 only check
> whether KVM_MEM_READONLY flag is set instead of changing. It doesn't
> need to delete the slot if the KVM
ping
On 2018/6/11 11:31, l00284672 wrote:
I tried your patch with my modification below can slove this problem.
void blk_set_aio_context(BlockBackend *blk, AioContext *new_context)
{
BlockDriverState *bs = blk_bs(blk);
ThrottleGroupMember *tgm = &blk->public.throttle_group_member;
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180612005145.3375-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PATCH v3 00/19] linux-user: Split do_syscall
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
to
This includes mmap, mmap2, munmap, mlock, mlockall, munlock,
munlockall, mprotect, mremap, msync.
Signed-off-by: Richard Henderson
---
linux-user/syscall.h | 2 +
linux-user/strace.c| 55 ++
linux-user/syscall.c | 118
linux-user/sy
This includes clone, getgroups, gettid, setfsgid, setfsuid,
setgroups, setsid, setuid, fork, getegid, getegid32, geteuid,
geteuid32, getgid, getgid32, getgroups32, getpgrp, getpid,
getppid, getresgid, getresgid32, getresuid, getresuid32,
getuid, getuid32, getxgid, getxpid, getxuid, setfsgid32,
setg
Signed-off-by: Richard Henderson
---
linux-user/syscall.h | 51
linux-user/strace.c| 35 ---
linux-user/syscall.c | 402 +--
linux-user/syscall_file.c | 423 +
linux-user/Makefile.objs |
Given that these are all intertwined via TARGET_NR_ipc,
we must move them all to the new file all at once.
Signed-off-by: Richard Henderson
---
linux-user/strace.c| 83 ---
linux-user/syscall.c | 973
linux-user/syscall_ipc.c | 1095 +++
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 60
1 file changed, 22 insertions(+), 38 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 5a17803732..fd8d48b0da 100644
--- a/linux-use
Defines a unified structure for implementation and strace.
Supplies a generator script to build the declarations and
the lookup function.
Signed-off-by: Richard Henderson
---
linux-user/syscall.h | 178 +++
linux-user/strace.c| 386 --
There is no point in listing a syscall if you want the same effect as
not listing it. In one less trivial case, the goto was demonstrably
not reachable.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 144 +--
1 file changed, 1 insertion(+), 1
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 341 ++-
1 file changed, 175 insertions(+), 166 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index efe882612b..a6b8268332 100644
--- a/linux-u
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a6b8268332..06205d3d65 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscal
Signed-off-by: Richard Henderson
---
linux-user/syscall.h | 5 ++
linux-user/syscall.c | 85 ++-
linux-user/syscall_file.c | 103 +
linux-user/gen_syscall_list.py | 4 ++
linux-user/strace.list | 12 ---
There was supposed to be a single point of return for do_syscall
so that tracing works properly. However, there are a few bugs
in that area. It is significantly simpler to simply split out
an inner function to enforce this.
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linu
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/sparc64/syscall_nr.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/sparc64/syscall_nr.h b/linux-user/sparc64/syscall_nr.h
index 9391645598..0b91b896da 100644
--- a/linux-user/sparc64/
Signed-off-by: Richard Henderson
---
linux-user/syscall.h | 1 +
linux-user/strace.c| 5 +-
linux-user/syscall.c | 98 --
linux-user/syscall_file.c | 88 ++
linux-user/gen_syscall_list.py | 2 +
li
Transform outermost "break" to "return ret". If the immediately
preceeding statement was an assignment to ret, return the value
directly.
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 970 +--
1 file changed, 390
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/microblaze/syscall_nr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/microblaze/syscall_nr.h
b/linux-user/microblaze/syscall_nr.h
index 0704449bae..
This is redundant with both -strace and actual tracing.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 7b9
Signed-off-by: Richard Henderson
---
linux-user/syscall.h | 44 +
linux-user/syscall.c | 70 --
linux-user/syscall_file.c | 61 +++--
linux-user/gen_syscall_list.py | 2 +
linux-user/strace.list
These were named incorrectly, going so far as to invade strace.list.
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/alpha/syscall_nr.h | 6 +++---
linux-user/strace.list| 9 -
2 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/linux-user
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Laurent Vivier
Signed-off-by: Richard Henderson
---
linux-user/hppa/syscall_nr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/hppa/syscall_nr.h b/linux-user/hppa/syscall_nr.h
index 55bdf71d50..9c1d0a195d 100644
-
1 - 100 of 426 matches
Mail list logo
