On Mon, Jun 11, 2018 at 02:16:50PM +0200, David Hildenbrand wrote: > "size" should not be queried before the device was realized. Let' make > that explicit. > > Signed-off-by: David Hildenbrand <da...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/mem/pc-dimm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 86fbcf2d0c..5294734529 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -166,6 +166,12 @@ static void pc_dimm_get_size(Object *obj, Visitor *v,
> const char *name,
> PCDIMMDevice *dimm = PC_DIMM(obj);
> PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(obj);
>
> + if (!DEVICE(obj)->realized) {
> + error_setg(errp, "Property \"%s\" not accessible before realized",
> + name);
> + return;
> + }
> +
> mr = ddc->get_memory_region(dimm, errp);
> if (!mr) {
> return;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
