[Qemu-devel] [Bug 1756927] Re: ARMv7 LPAE: IFSR doesn't have the LPAE bit in case of BKPT

2018-04-03 Thread Vincent Siles
thanks Peter ! Any news on the review ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1756927 Title: ARMv7 LPAE: IFSR doesn't have the LPAE bit in case of BKPT Status in QEMU: In Progress Bug d

Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests

2018-04-03 Thread Peter Xu
On Wed, Apr 04, 2018 at 01:03:47PM +0800, Peter Xu wrote: > On Wed, Apr 04, 2018 at 10:51:58AM +0800, Fam Zheng wrote: > > Docker testing on patchew has long suffered from 'make check' hangings. The > > cleanness of VM testing is the cure. Now let's add a CentOS 7 image to run > > the > > tests.

[Qemu-devel] [PATCH for-2.12] iothread: workaround glib bug which hangs qmp-test

2018-04-03 Thread Peter Xu
Free the AIO context earlier than the GMainContext (if we have) to workaround a possible Glib bug. No functional change at all. We encountered a qmp-test hang with oob: #0 0x7f35ffe45334 in __lll_lock_wait () from /lib64/libpthread.so.0 #1 0x7f35ffe405d8 in _L_lock_854 () from /lib

Re: [Qemu-devel] [PATCH] docker: Inline "prep_fail" in run script

2018-04-03 Thread Fam Zheng
On Mon, 03/26 17:03, Fam Zheng wrote: > We don't source common.rc where prep_fail is defined, so spell out the > commands and do what was intended. > > Signed-off-by: Fam Zheng > --- > tests/docker/run | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/run b/t

Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-03 Thread Balamuruhan S
On 2018-04-04 07:29, Peter Xu wrote: On Tue, Apr 03, 2018 at 11:00:00PM +0530, bala24 wrote: On 2018-04-03 11:40, Peter Xu wrote: > On Sun, Apr 01, 2018 at 12:25:36AM +0530, Balamuruhan S wrote: > > expected_downtime value is not accurate with dirty_pages_rate * > > page_size, > > using ram_byte

Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests

2018-04-03 Thread Peter Xu
On Wed, Apr 04, 2018 at 10:51:58AM +0800, Fam Zheng wrote: > Docker testing on patchew has long suffered from 'make check' hangings. The > cleanness of VM testing is the cure. Now let's add a CentOS 7 image to run the > tests. It's purely ad-hoc, but hopefully still easy to understand and use for

Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests

2018-04-03 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180404025201.11921-1-f...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] Add a CentOS test

Re: [Qemu-devel] [PATCH] target/ppc: Fix backwards migration of msr_mask

2018-04-03 Thread Simon Guo
David, On Tue, Mar 20, 2018 at 01:23:19PM +1100, David Gibson wrote: > 21b786f "PowerPC: Add TS bits into msr_mask" added the transaction states > to msr_mask for recent POWER CPUs to allow correct migration of machines > that are in certain interim transactional memory states. > > This was correc

Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests

2018-04-03 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180404025201.11921-1-f...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] Add a CentOS te

[Qemu-devel] [PATCH 3/3] tests: Add centos VM testing

2018-04-03 Thread Fam Zheng
This one does docker testing in the VM. It is intended to replace the native docker testing on patchew testers. Signed-off-by: Fam Zheng --- tests/vm/centos | 82 + 1 file changed, 82 insertions(+) create mode 100755 tests/vm/centos diff

[Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests

2018-04-03 Thread Fam Zheng
Docker testing on patchew has long suffered from 'make check' hangings. The cleanness of VM testing is the cure. Now let's add a CentOS 7 image to run the tests. It's purely ad-hoc, but hopefully still easy to understand and use for everyone. The first patch makes passing source code from host to

[Qemu-devel] [PATCH 2/3] tests: Add an option for snapshot (default: off)

2018-04-03 Thread Fam Zheng
Not using snapshot has the benefit of automatically persisting useful test harnesses, such as docker images and ccache database. Although it will lose some cleanness, it is imaginably useful for patchew. Signed-off-by: Fam Zheng --- tests/vm/basevm.py | 7 ++- 1 file changed, 6 insertions(+)

[Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code

2018-04-03 Thread Fam Zheng
./configure and make now take care of submodules, we only need to clone the top tree. Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 47 --- 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/scripts/archive-source.sh b/scripts/ar

Re: [Qemu-devel] [PATCH v2] scsi-block: Handle error from host devices

2018-04-03 Thread Fam Zheng
On Wed, 04/04 09:47, Fam Zheng wrote: > The callback of blk_aio_ioctl is not sensible to SCSI errors, so > werror=stop doesn't work if ioctl returns 0 but the scsi status is > error. > > Peek at the sg_io_hdr_t fields and amend ret to fix that. > > Signed-off-by: Fam Zheng > > --- > > v2: Fix

Re: [Qemu-devel] [PATCH 0/2] Couple of qemu-pr-helper fixes

2018-04-03 Thread Fam Zheng
On Tue, 04/03 15:12, Michal Privoznik wrote: > The first one is trivial. > > The second is slightly trickier. Libvirt has this virCommand subsystem > (found under src/util/vircommand.c) which it uses to spawn commands. The > subsystem allows libvirt to both daemonize a process and learn its PID. >

Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-03 Thread Peter Xu
On Tue, Apr 03, 2018 at 11:00:00PM +0530, bala24 wrote: > On 2018-04-03 11:40, Peter Xu wrote: > > On Sun, Apr 01, 2018 at 12:25:36AM +0530, Balamuruhan S wrote: > > > expected_downtime value is not accurate with dirty_pages_rate * > > > page_size, > > > using ram_bytes_remaining would yeild it cor

[Qemu-devel] [PATCH v2] scsi-block: Handle error from host devices

2018-04-03 Thread Fam Zheng
The callback of blk_aio_ioctl is not sensible to SCSI errors, so werror=stop doesn't work if ioctl returns 0 but the scsi status is error. Peek at the sg_io_hdr_t fields and amend ret to fix that. Signed-off-by: Fam Zheng --- v2: Fix ->cb. [Daniel] --- hw/scsi/scsi-disk.c | 21 +++

Re: [Qemu-devel] [PATCH] iotests: fix wait_until_completed()

2018-04-03 Thread Peter Xu
On Tue, Apr 03, 2018 at 01:59:18PM +0100, Stefan Hajnoczi wrote: > On Tue, Mar 27, 2018 at 10:21:55AM +0800, Peter Xu wrote: > > On Mon, Mar 26, 2018 at 12:47:39PM +0200, Kevin Wolf wrote: > > > Am 26.03.2018 um 08:11 hat Peter Xu geschrieben: > > > > If there are more than one events, wait_until_c

Re: [Qemu-devel] [PATCH] scsi-block: Handle error from host devices

2018-04-03 Thread Fam Zheng
On Tue, 04/03 17:41, Daniel Henrique Barboza wrote: > Hi Fam, > > I've tried this patch and found issues when booting a VM using SCSI > passthrough. This is the backtrace from gdb from the segfault that happens > in the middle of kernel boot: > > Thread 1 "qemu-system-ppc" received signal SIGSEGV

[Qemu-devel] [Bug 1761027] [NEW] Unexpected error

2018-04-03 Thread Mahdi Golestaneh
Public bug reported: When run it this error happens: Unexpected error in aio_context_set_poll_params() at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/util/aio-win32.c:413: C:\Program Files\qemu\qemu-system-x86_64.exe: AioContext polling is not implemented on Windows This application has requested

Re: [Qemu-devel] [PATCH for-2.12] monitor: bind dispatch bh to iohandler context

2018-04-03 Thread Peter Xu
On Tue, Apr 03, 2018 at 08:02:44AM -0500, Eric Blake wrote: > On 04/03/2018 12:01 AM, Peter Xu wrote: > > Eric Auger reported the problem days ago that OOB broke ARM when running > > with libvirt: > > > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > > > This patch fixes

Re: [Qemu-devel] [PULL 0/8] xtensa-specific and generic fixes for linux-user

2018-04-03 Thread Peter Maydell
On 2 April 2018 at 18:13, Max Filippov wrote: > Hi Peter, > > please pull the following batch of linux-user fixes for 2.12. > > The following changes since commit dfe732fb68ef9195517f4f380a477d58a054edc1: > > Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into > staging (20

Re: [Qemu-devel] [PULL 1/9] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Jeff Cody
On Tue, Apr 03, 2018 at 06:33:52PM +0200, Kevin Wolf wrote: > The legacy command line interface gets the socket path from an option > called 'socket'. QAPI in contract uses SocketAddress, where the > corresponding option is called 'path'. > > Fix the gluster block driver to accept both 'socket' an

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-03 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 28.03.2018 um 19:02 hat Dr. David Alan Gilbert (git) geschrieben: > > From: "Dr. David Alan Gilbert" > > > > Activating the block devices causes the locks to be taken on > > the backing file. If we're running with -S and the destination libvirt > > has

Re: [Qemu-devel] [PATCH] scsi-block: Handle error from host devices

2018-04-03 Thread Daniel Henrique Barboza
Hi Fam, I've tried this patch and found issues when booting a VM using SCSI passthrough. This is the backtrace from gdb from the segfault that happens in the middle of kernel boot: Thread 1 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x77ff63a0 (LWP

[Qemu-devel] [Bug 1740219] Re: static linux-user ARM emulation has several-second startup time

2018-04-03 Thread LukeShu
Yes, I believe that 2a53535af471f4bee9d6cb5b363746b8d5ed21dd alone is good. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1740219 Title: static linux-user ARM emulation has several-second startup t

Re: [Qemu-devel] [PATCH] iotests: fix 169

2018-04-03 Thread John Snow
On 04/03/2018 12:23 PM, Max Reitz wrote: > On 2018-03-30 18:10, Vladimir Sementsov-Ogievskiy wrote: >> Use MIGRATION events instead of RESUME. Also, make a TODO: enable >> dirty-bitmaps capability for offline case. >> >> This (likely) fixes racy faults at least of the following types: >> >> -

Re: [Qemu-devel] [Bug 1760176] Re: optical drive doesn't open in Lubuntu 18.04 on '12 MacPro

2018-04-03 Thread Fritz Hudnut
@John Snow: Don't know on the "QEMU" front, this is install to HD partitions of Lu 18.04 . . . while trying to burn an iso to DVD, pressing the "eject" keyboard button will not open the open drive door, so no DVD can be put there . . . problem remains in Lu. Whereas I have a couple installs of Op

[Qemu-devel] [PULL 3/3] dump: Fix build with newer gcc

2018-04-03 Thread Eric Blake
gcc 8 on rawhide is picky enough to complain: /home/dummy/qemu/dump.c: In function 'create_header32': /home/dummy/qemu/dump.c:817:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation] strncpy(dh->signature,

[Qemu-devel] [PULL 2/3] maint: Add .mailmap entries for patches claiming list authorship

2018-04-03 Thread Eric Blake
The list did not author any patches, but it does rewrite the 'From:' header of messages sent from any domain with restrictive SPF policies that would otherwise prevent the message from reaching all list recipients. If a maintainer is not careful to undo the list header rewrite, and the author did

[Qemu-devel] [PULL 1/3] monitor: bind dispatch bh to iohandler context

2018-04-03 Thread Eric Blake
From: Peter Xu Eric Auger reported the problem days ago that OOB broke ARM when running with libvirt: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html This patch fixes the problem. It's not really needed now since we have turned OOB off now, but it's still a bug fix, and it'l

[Qemu-devel] [PULL 0/3] QAPI and misc patches for 2.12-rc2

2018-04-03 Thread Eric Blake
The following changes since commit 13b65ec54dbf524cb62331281a98b432f78d4e3a: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-04-02' into staging (2018-04-03 15:59:50 +0100) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-qapi-2018-04-03 for

[Qemu-devel] [Bug 1760176] Re: optical drive doesn't open in Lubuntu 18.04 on '12 MacPro

2018-04-03 Thread John Snow
Sorry, I'm not sure if I understand you. Does this bug have anything to do with QEMU? Are you running a virtual machine? If so: (A) What is your host OS, version, and QEMU version? (B) What is your guest OS and version? (C) What are you trying to do, and (D) What is the expected behavior? ** Cha

Re: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

2018-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1522768634-5548-1-git-send-email-suhan...@mails.ucas.ac.cn Subject: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case === TEST SCRIPT BEGIN === #!/bin

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-04-03 Thread Tony Krowiak
On 04/02/2018 01:05 PM, Tony Krowiak wrote: On 03/27/2018 08:02 AM, Cornelia Huck wrote: On Fri, 16 Mar 2018 14:22:52 +0100 Halil Pasic wrote: On 03/16/2018 11:42 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via th

Re: [Qemu-devel] [PATCH for-2.12] dump: Fix build with newer gcc

2018-04-03 Thread Eric Blake
On 03/27/2018 03:21 PM, Eric Blake wrote: > gcc 8 on rawhide is picky enough to complain: > > /home/dummy/qemu/dump.c: In function 'create_header32': > /home/dummy/qemu/dump.c:817:5: error: 'strncpy' output truncated before > terminating nul copying 8 bytes from a string of the same length > [-W

Re: [Qemu-devel] [PATCH for-2.12] maint: Add .mailmap entries for patches claiming list authorship

2018-04-03 Thread Eric Blake
On 03/26/2018 01:41 PM, Eric Blake wrote: > The list did not author any patches, but it does rewrite the > 'From:' header of messages sent from any domain with restrictive > SPF policies that would otherwise prevent the message from reaching > all list recipients. If a maintainer is not careful to

Re: [Qemu-devel] [PULL 0/3] NBD patches for 2.12-rc2

2018-04-03 Thread Peter Maydell
On 2 April 2018 at 15:16, Eric Blake wrote: > The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 > 09:42:33 +0100) > > are available in the Git repository a

[Qemu-devel] [Bug 1481272] Re: main-loop: WARNING: I/O thread spun for 1000 iterations

2018-04-03 Thread Thomas Huth
Ok, closing this for upstream, too, according to the previous comments. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1481272 Title: main-loo

Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-03 Thread bala24
On 2018-04-03 11:40, Peter Xu wrote: On Sun, Apr 01, 2018 at 12:25:36AM +0530, Balamuruhan S wrote: expected_downtime value is not accurate with dirty_pages_rate * page_size, using ram_bytes_remaining would yeild it correct. Signed-off-by: Balamuruhan S --- migration/migration.c | 3 +-- 1 f

Re: [Qemu-devel] [PATCH] linux-user: call cpu_copy under clone_lock

2018-04-03 Thread Max Filippov
Hi Alex, On Tue, Apr 3, 2018 at 9:26 AM, Alex Bennée wrote: > Max Filippov writes: > >> cpu_copy adds newly created CPU object to container/machine/unattached, >> but does it w/o proper locking. As a result when multiple threads are >> created rapidly QEMU may abort with the following message: >

[Qemu-devel] [PULL 6/9] block/file-posix: Fix fully preallocated truncate

2018-04-03 Thread Kevin Wolf
From: Max Reitz Storing the lseek() result in an int results in it overflowing when the file is at least 2 GB big. Then, we have a 50 % chance of the result being "negative" and thus thinking an error occurred when actually everything went just fine. So we should use the correct type for storin

[Qemu-devel] [PULL 0/9] Block layer patches for 2.12.0-rc2

2018-04-03 Thread Kevin Wolf
The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[Qemu-devel] [PULL 4/9] iotests: Update 186 after commit ac64273c66ab136c44043259162

2018-04-03 Thread Kevin Wolf
From: Alberto Garcia Commit ac64273c66ab136c44 modified the output of iotest 186, changing the QOM path of floppy drives from /machine/unattached/device[17] to /machine/unattached/device[13]. Instead of updating the test output to reflect this change, this patch adds a new filter that hides all

[Qemu-devel] [PULL 9/9] iotests: Test abnormally large size in compressed cluster descriptor

2018-04-03 Thread Kevin Wolf
From: Alberto Garcia L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size is usually not a m

[Qemu-devel] [PULL 7/9] iotests: Test preallocated truncate of 2G image

2018-04-03 Thread Kevin Wolf
From: Max Reitz Signed-off-by: Max Reitz Message-id: 20180228131315.30194-3-mre...@redhat.com Reviewed-by: Daniel P. Berrangé Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/106 | 24 tests/qemu-iotests/106.out | 10 ++ 2 files cha

[Qemu-devel] [PULL 8/9] qemu-iotests: Use ppc64 qemu_arch on ppc64le host

2018-04-03 Thread Kevin Wolf
From: Lukáš Doktor The qemu target does not always correspond to the host machine type. For example ppc64le machine target is ppc64. Let's introduce "qemu_arch" variable to store the matching qemu architecture related to the current architecture and use it when auto-detecting the default qemu bin

[Qemu-devel] [PULL 5/9] iotests: fix 208 for luks format

2018-04-03 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Support luks images creatins like in 205 Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- tests/qemu-iotests/208 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/208 b/tests/qemu-iotests/208 inde

[Qemu-devel] [PULL 2/9] block: handle invalid lseek returns gracefully

2018-04-03 Thread Kevin Wolf
From: Jeff Cody In commit 223a23c198787328ae75bc65d84edf5fde33c0b6, we implemented a workaround in the gluster driver to handle invalid values returned for SEEK_DATA or SEEK_HOLE. In some instances, these same invalid values can be seen in the posix file handler as well - for example, it has bee

[Qemu-devel] [PULL 3/9] iotests: Update 051 and 186 after commit 1454509726719e0933c

2018-04-03 Thread Kevin Wolf
From: Alberto Garcia SCSI controllers are no longer created automatically for -drive if=scsi, so this patch updates the tests that relied on that. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Cc: Thomas Huth Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051.pc.out | 20 -

[Qemu-devel] [PULL 1/9] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Kevin Wolf
The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the preferred syntax. https://bugzilla.re

Re: [Qemu-devel] [PATCH] linux-user: call cpu_copy under clone_lock

2018-04-03 Thread Alex Bennée
Max Filippov writes: > cpu_copy adds newly created CPU object to container/machine/unattached, > but does it w/o proper locking. As a result when multiple threads are > created rapidly QEMU may abort with the following message: > > GLib-CRITICAL **: g_hash_table_iter_next: assertion > 'ri->v

Re: [Qemu-devel] [PATCH] iotests: fix 169

2018-04-03 Thread Max Reitz
On 2018-03-30 18:10, Vladimir Sementsov-Ogievskiy wrote: > Use MIGRATION events instead of RESUME. Also, make a TODO: enable > dirty-bitmaps capability for offline case. > > This (likely) fixes racy faults at least of the following types: > > - timeout on waiting for RESUME event > - sha2

[Qemu-devel] [PULL 1/3] blockjob: leak fix, remove from txn when failing early

2018-04-03 Thread Jeff Cody
From: Marc-André Lureau This fixes leaks found by ASAN such as: GTESTER tests/test-blockjob = ==31442==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f88483cba38 in _

[Qemu-devel] [PULL 3/3] gluster: Fix blockdev-add with server.N.type=unix

2018-04-03 Thread Jeff Cody
From: Kevin Wolf The legacy command line interface gets the socket path from an option called 'socket'. QAPI in contract uses SocketAddress, where the corresponding option is called 'path'. Fix the gluster block driver to accept both 'socket' and 'path', with 'path' being the preferred syntax.

[Qemu-devel] [PULL 0/3] Block patches for 2.12-rc2

2018-04-03 Thread Jeff Cody
The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/bl

[Qemu-devel] [PULL 2/3] blockjob: use qapi enum helpers

2018-04-03 Thread Jeff Cody
From: Marc-André Lureau QAPI generator provide #define helpers for looking up enum string. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow Message-id: 20180327153011.29569-1-marcandre.lur...@redhat.com Signed-off-by: Jeff Cody --- blockjob.c | 14 +- 1 file changed, 5 ins

Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage

2018-04-03 Thread Max Reitz
On 2018-03-30 17:32, Vladimir Sementsov-Ogievskiy wrote: > 30.03.2018 16:31, Vladimir Sementsov-Ogievskiy wrote: >> 29.03.2018 18:09, Vladimir Sementsov-Ogievskiy wrote: >>> 29.03.2018 17:03, Max Reitz wrote: On 2018-03-29 10:08, Vladimir Sementsov-Ogievskiy wrote: > 28.03.2018 17:53, Max

Re: [Qemu-devel] [PATCH v2 0/4] target-i386: Enhance SVM support

2018-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1522769774.git.jan.kis...@web.de Subject: [Qemu-devel] [PATCH v2 0/4] target-i386: Enhance SVM support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH] tcg: fix 16-byte vector operations detection

2018-04-03 Thread Laurent Vivier
On 29/03/2018 18:54, Laurent Vivier wrote: > Hi, > > I think it would be good to have this fix (or something similar) in -rc2. So no one agrees with that? Thanks, Laurent

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/67] target/arm: Scalable Vector Extension

2018-04-03 Thread Alex Bennée
Richard Henderson writes: > This is 99% of the instruction set. There are a few things missing, > notably first-fault and non-fault loads (even these are decoded, but > simply treated as normal loads for now). I've finished my quick pass, apart from the individual comments I think it looks pre

[Qemu-devel] [PATCH v2 3/4] target-i386: Mark cpu_vmexit noreturn

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka It calls cpu_loop_exit in system emulation mode (and should never be called in user emulation mode). Signed-off-by: Jan Kiszka --- target/i386/cpu.h| 4 ++-- target/i386/svm_helper.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.

Re: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

2018-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1522769426-6056-1-git-send-email-suhan...@mails.ucas.ac.cn Subject: [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH v2 2/4] target-i386: Allow interrupt injection after STGI

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka We need to terminate the translation block after STGI so that pending interrupts can be injected. This fixes pending NMI injection for Jailhouse which uses "stgi; clgi" to open a brief injection window. Signed-off-by: Jan Kiszka --- target/i386/translate.c | 3 ++- 1 file cha

[Qemu-devel] [PATCH v2 1/4] target-i386: Add NMI interception to SVM

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka Check for SVM interception prior to injecting an NMI. Tested via the Jailhouse hypervisor. Signed-off-by: Jan Kiszka --- target/i386/seg_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/seg_helper.c b/target/i386/seg_helper.c index 600a4d7586..00301a0c0

[Qemu-devel] [PATCH v2 4/4] target-i386: Add NPT support

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka This implements NPT suport for SVM by hooking into x86_cpu_handle_mmu_fault where it reads the stage-1 page table. Whether we need to perform this 2nd stage translation, and how, is decided during vmrun and stored in hflags as well as nested_cr3 and nested_pg_mode. As get_hphys

[Qemu-devel] [PATCH v2 0/4] target-i386: Enhance SVM support

2018-04-03 Thread Jan Kiszka
These patches allow to run Jailhouse in emulated x86-64 mode under QEMU. AMD IOMMU only works with one additional hack, but that's a different story, and we can test these changes without it. Change in v2: - build fix for 32-bit hosts - replaces NPT exitinfo magics with symbolic constants Jan

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-03 Thread Eduardo Habkost
On Tue, Apr 03, 2018 at 04:32:53PM +0200, Igor Mammedov wrote: > On Thu, 29 Mar 2018 13:24:09 -0300 > Eduardo Habkost wrote: > > > On Thu, Mar 29, 2018 at 01:43:03PM +0200, Igor Mammedov wrote: > > > On Wed, 28 Mar 2018 16:21:48 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Wed, Mar 28,

Re: [Qemu-devel] [PATCH for 2.12] iotests: fix 208 for luks format

2018-04-03 Thread Kevin Wolf
Am 30.03.2018 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Support luks images creatins like in 205 > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH 1/2] Implement .hex file loader

2018-04-03 Thread Su Hang
This patch adds Intel Hexadecimal Object File format support to the loader. The file format specification is available here: http://www.piclist.com/techref/fileext/hex/intel.htm The file format is mainly intended for embedded systems and microcontrollers, such as Arduino, ARM, STM32, etc. Sugges

[Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

2018-04-03 Thread Su Hang
These series of patchs implement Intel Hexadecimal File loader and add QTest testcase to verify the correctness of Loader. Su Hang (2): Implement .hex file loader Add QTest testcase for the Intel Hexadecimal Object File Loader. hw/arm/boot.c | 9 +- hw/core/loader.c | 280

[Qemu-devel] [PATCH 2/2] Add QTest testcase for the Hex File Loader

2018-04-03 Thread Su Hang
'test.hex' file is a bare metal ARM software stored in Hexadecimal Object Format. When it's loaded by QEMU, it will print "Hello world!\n" on console. `pre_store` array in 'hexloader-test.c' file, stores the binary format of 'test.hex' file, which is used to verify correctness. Signed-off-by: Su

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-04-03 Thread Su Hang
Please ignore this email, this patch was accidentally sent. "Su Hang" wrote: > checkpatch.pl stops complaining about following pattern: > """ > do { > //do somethins; > } while (conditions); > """ > > One things need to be mentioned: > Becasue `if`, `while` and `for` check have been done in t

Re: [Qemu-devel] [PATCH for-2.12 v4 0/2] Update output of some iotests

2018-04-03 Thread Kevin Wolf
Am 22.03.2018 um 15:45 hat Alberto Garcia geschrieben: > I sent a patch a few days ago correction the output of iotests 051 and > 186. I wanted to resend it again but I noticed that 186 needs now more > changes due to commit ac64273c66ab136c44043259162, so I'm including > those changes too. [ Cc:

[Qemu-devel] [PATCH 4/4] target-i386: Add NPT support

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka This implements NPT suport for SVM by hooking into x86_cpu_handle_mmu_fault where it reads the stage-1 page table. Whether we need to perform this 2nd stage translation, and how, is decided during vmrun and stored in hflags as well as nested_cr3 and nested_pg_mode. As get_hphys

[Qemu-devel] [PATCH 3/4] target-i386: Mark cpu_vmexit noreturn

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka It calls cpu_loop_exit in system emulation mode (and should never be called in user emulation mode). Signed-off-by: Jan Kiszka --- target/i386/cpu.h| 4 ++-- target/i386/svm_helper.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.

[Qemu-devel] [PATCH 2/4] target-i386: Allow interrupt injection after STGI

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka We need to terminate the translation block after STGI so that pending interrupts can be injected. This fixes pending NMI injection for Jailhouse which uses "stgi; clgi" to open a brief injection window. Signed-off-by: Jan Kiszka --- target/i386/translate.c | 3 ++- 1 file cha

[Qemu-devel] [PATCH 1/4] target-i386: Add NMI interception to SVM

2018-04-03 Thread Jan Kiszka
From: Jan Kiszka Check for SVM interception prior to injecting an NMI. Tested via the Jailhouse hypervisor. Signed-off-by: Jan Kiszka --- target/i386/seg_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/seg_helper.c b/target/i386/seg_helper.c index 600a4d7586..00301a0c0

[Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support

2018-04-03 Thread Jan Kiszka
These patches allow to run Jailhouse in emulated x86-64 mode under QEMU. AMD IOMMU only works with one additional hack, but that's a different story, and we can test these changes without it. Jan Jan Kiszka (4): target-i386: Add NMI interception to SVM target-i386: Allow interrupt injection a

Re: [Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support

2018-04-03 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1522767657.git.jan.kis...@web.de Subject: [Qemu-devel] [PATCH 0/4] target-i386: Enha

[Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-04-03 Thread Su Hang
checkpatch.pl stops complaining about following pattern: """ do { //do somethins; } while (conditions); """ One things need to be mentioned: Becasue `if`, `while` and `for` check have been done in this `if` block(Line: 2356), and this block contains following statement: """ Line: 2379 $suppres

[Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case

2018-04-03 Thread Su Hang
These series of patchs implement Intel Hexadecimal File loader and add QTest testcase to verify the correctness of Loader. Su Hang (2): Implement .hex file loader Add QTest testcase for the Intel Hexadecimal Object File Loader. hw/arm/boot.c | 9 +- hw/core/loader.c | 280

Re: [Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support

2018-04-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1522767657.git.jan.kis...@web.de Subject: [Qemu-devel] [PATCH 0/4] target-i386: Enhance SVM support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH 0/2] pvpanic: implement abort_on_panic option

2018-04-03 Thread Sergio Lopez
On Fri, Jan 12, 2018 at 05:31:58PM +0100, Sergio Lopez wrote: > On Fri, Dec 29, 2017 at 10:42 AM, Sergio Lopez wrote: > > Extend pvpanic and qemu_system_guest_panicked so it's possible to > > configure the first to induce an abort() when the Guest panics. > > > > This is specially useful (and main

[Qemu-devel] [PATCH 2/2] Add QTest testcase for the Hex File Loader

2018-04-03 Thread Su Hang
'test.hex' file is a bare metal ARM software stored in Hexadecimal Object Format. When it's loaded by QEMU, it will print "Hello world!\n" on console. `pre_store` array in 'hexloader-test.c' file, stores the binary format of 'test.hex' file, which is used to verify correctness. Signed-off-by: Su

[Qemu-devel] [PATCH 1/2] Implement .hex file loader

2018-04-03 Thread Su Hang
This patch adds Intel Hexadecimal Object File format support to the loader. The file format specification is available here: http://www.piclist.com/techref/fileext/hex/intel.htm The file format is mainly intended for embedded systems and microcontrollers, such as Arduino, ARM, STM32, etc. Sugges

Re: [Qemu-devel] [PULL 0/2] migration queue

2018-04-03 Thread Peter Maydell
On 29 March 2018 at 14:57, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 47d3b60858d90ac8a0cc3a72af7f95c96781125a: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-important-fixes' into staging (2018-03-28 > 2

Re: [Qemu-devel] [PULL] Net patches

2018-04-03 Thread Peter Maydell
On 30 March 2018 at 04:53, Jason Wang wrote: > The following changes since commit 47d3b60858d90ac8a0cc3a72af7f95c96781125a: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-important-fixes' into staging (2018-03-28 > 22:13:38 +0100) > > are available in the git repository

Re: [Qemu-devel] [PULL v1 0/4] Merge tpm 2018/03/29 v1

2018-04-03 Thread Peter Maydell
On 30 March 2018 at 01:12, Stefan Berger wrote: > The following patches fix the handling of some more flags of the TPM CRB > interface and extend the existing TPM CRB test program with tests of more > flags. > > Stefan > > The following changes since commit 043289bef4d9c0d277c45695c676a6cc9fca

Re: [Qemu-devel] [PULL 0/1] RISC-V: Critical fixes for QEMU 2.12

2018-04-03 Thread Peter Maydell
On 29 March 2018 at 18:26, Michael Clark wrote: > The following changes since commit 47d3b60858d90ac8a0cc3a72af7f95c96781125a: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-important-fixes' into staging (2018-03-28 > 22:13:38 +0100) > > are available in the git reposit

Re: [Qemu-devel] [PATCH v2] ccid-card: include libcacard.h only

2018-04-03 Thread Marc-André Lureau
Hi On Tue, Apr 3, 2018 at 1:48 PM, Michal Privoznik wrote: > On 04/03/2018 01:38 PM, Marc-André Lureau wrote: >> Hi >> >> On Tue, Apr 3, 2018 at 12:34 PM, Michal Privoznik >> wrote: >>> When trying to build with latest libcacard-2.5.1, I hit the >>> following error: >>> >>> In file included fro

Re: [Qemu-devel] [PULL 0/1] RISC-V: Critical fixes for QEMU 2.12

2018-04-03 Thread Peter Maydell
On 3 April 2018 at 03:43, Michael Clark wrote: > I submitted the pull request for your's/Stefan's workaround so that QEMU > 2.12 has working FP context switching under Linux (always returning dirty or > off is valid implementation choice according to the specification), given > Richard Henderson h

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-03 Thread Kevin Wolf
Am 28.03.2018 um 19:02 hat Dr. David Alan Gilbert (git) geschrieben: > From: "Dr. David Alan Gilbert" > > Activating the block devices causes the locks to be taken on > the backing file. If we're running with -S and the destination libvirt > hasn't started the destination with 'cont', it's expec

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

2018-04-03 Thread Igor Mammedov
On Thu, 29 Mar 2018 13:24:09 -0300 Eduardo Habkost wrote: > On Thu, Mar 29, 2018 at 01:43:03PM +0200, Igor Mammedov wrote: > > On Wed, 28 Mar 2018 16:21:48 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, Mar 28, 2018 at 01:48:35PM +0200, Igor Mammedov wrote: > > > > On Tue, 27 Mar 2018 1

Re: [Qemu-devel] [PATCH v2 1/1] iotests: fix test case 185

2018-04-03 Thread Stefan Hajnoczi
On Tue, Mar 27, 2018 at 11:32:00AM +0800, QingFeng Hao wrote: > > 在 2018/3/23 18:04, Stefan Hajnoczi 写道: > > On Fri, Mar 23, 2018 at 3:43 AM, QingFeng Hao > > wrote: > > > Test case 185 failed since commit 4486e89c219 --- "vl: introduce > > > vm_shutdown()". > > > It's because of the newly intr

Re: [Qemu-devel] [PATCH] qemu-iotests: update 185 output

2018-04-03 Thread Kevin Wolf
Am 03.04.2018 um 16:03 hat Stefan Hajnoczi geschrieben: > Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce > vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the > drain operation the block job iterates one more time than before. The > 185 output no longer matches

Re: [Qemu-devel] [PATCH for-2.13] s390x: introduce 2.13 compat machine

2018-04-03 Thread Cornelia Huck
On Thu, 29 Mar 2018 13:33:20 +0200 Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > Yes, it's that time again :) > --- > hw/s390x/s390-virtio-ccw.c | 17 - > include/hw/compat.h| 3 +++ > 2 files changed, 19 insertions(+), 1 deletion(-) Queued to s390-next (

[Qemu-devel] [PATCH] qemu-iotests: update 185 output

2018-04-03 Thread Stefan Hajnoczi
Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the drain operation the block job iterates one more time than before. The 185 output no longer matches and the test is failing now. It may be possible to avoid the s

[Qemu-devel] [PULL 2/2] sev/i386: fix memory leak in sev_guest_init()

2018-04-03 Thread Eduardo Habkost
From: Greg Kurz The string returned by object_property_get_str() is dynamically allocated. Fixes: d8575c6c0242b Signed-off-by: Greg Kurz Message-Id: <152231462116.69730.14119625999092384450.st...@bahia.lan> Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: Eduardo Habkost --

[Qemu-devel] [PULL 0/2] Fix memory leaks when using object_property_get_str()

2018-04-03 Thread Eduardo Habkost
The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 09:42:33 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/x86-next-pu

  1   2   >