Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1519480458-9573-1-git-send-email-suhan...@mails.ucas.ac.cn
Subject: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl:Add check for `while`
and `for`
=== TEST SCRIPT BEGIN ===
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1519532963-12976-1-git-send-email-suhan...@mails.ucas.ac.cn
Subject: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format
=== TEST SCRIPT BEGIN ===
#!/bin/bash
B
On Wed, 02/14 14:37, Philippe Mathieu-Daudé wrote:
> On 02/13/2018 02:34 PM, Stefan Hajnoczi wrote:
> > From: Fam Zheng
> >
> > git-publish [1] is a convenient tool to send patches and has been
> > popular among QEMU developers. Recently it has been made available in
> > Fedora official repo tha
On Wed, 02/14 15:08, Paolo Bonzini wrote:
> On 13/02/2018 19:09, Daniel P. Berrangé wrote:
> > Why is a custom entry needed for block here (and other things
> > below). Won't running get_maintainer.pl already correctly
> > report when a patch needs cc'ing to qemu-bl...@nongnu.org
> > based on MAI
On Thu, 02/15 14:23, Philippe Mathieu-Daudé wrote:
> Suggested-by: Eric Blake
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/docker/common.rc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 7951555e3f..dd
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1519533358-13759-1-git-send-email-suhan...@mails.ucas.ac.cn
Subject: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format
=== TEST SCRIPT BEGIN ===
#!/bin/bash
B
Signed-off-by: Su Hang
---
util/uri.c | 1468 ++--
1 file changed, 735 insertions(+), 733 deletions(-)
diff --git a/util/uri.c b/util/uri.c
index 21b18281703a..cf09f41735a1 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -63,7 +63,6 @@ static v
For this patch, using curly braces to wrap `if` `while` `else` statements,
which only hold single statement. For example:
'''
if (cond)
statement;
'''
to
'''
if (cond) {
statement;
}
'''
And using tricks that compare the disassemblies before and after
code changes, to make sure code logic
only remove brackets that wrap `return` statements' content.
use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
to remove pattern like this: "return (1);"
Signed-off-by: Su Hang
---
util/uri.c | 160 ++---
1 file changed, 80 i
Su Hang (3):
util/uri.c: Coding style check, Only whitespace involved.
util/uri.c: remove brackets () that wrap `return` statement's content.
util/uri.c: wrap single statement blocks with braces {}
util/uri.c | 1753
1 file change
Signed-off-by: Su Hang
---
util/uri.c | 1468 ++--
1 file changed, 735 insertions(+), 733 deletions(-)
diff --git a/util/uri.c b/util/uri.c
index 21b18281703a..cf09f41735a1 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -63,7 +63,6 @@ static v
For this patch, using curly braces to wrap `if` `while` `else` statements,
which only hold single statement. For example:
'''
if (cond)
statement;
'''
to
'''
if (cond) {
statement;
}
'''
And using tricks that compare the disassemblies before and after
code changes, to make sure code logic
only remove brackets that wrap `return` statements' content.
use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
to remove pattern like this: "return (1);"
Signed-off-by: Su Hang
---
util/uri.c | 160 ++---
1 file changed, 80 i
*** BLURB HERE ***
Su Hang (3):
util/uri.c: Coding style check, Only whitespace involved.
util/uri.c: remove brackets () that wrap `return` statement's content.
util/uri.c: wrap single statement blocks with braces {}
util/uri.c | 1753 ---
From 295640e6f4aa83b843e245bb1af9995be37de84d Mon Sep 17 00:00:00 2001
From: zhangjixiang
Date: Sun, 25 Feb 2018 09:47:51 +0800
Subject: [PATCH] HMP: Initialize err before using
When bdrv_snapshot_delete return fail, the errp will not be
assigned a valid value in error_propagate as errp didn't be
Add check for `while` and `for` statement, which condition has more than
one line.
The former checkpatch.pl can check `if` statement, which condition has more
than one line, whether block misses brace round, like this:
'''
if (cond1 ||
cond2)
statement;
'''
But it doesn't do the same check
On 02/24/2018 12:18 PM, Laurent Vivier wrote:
> Since f3218a8 ("softfloat: add floatx80 constants")
> floatx80_infinity is defined but never used.
>
> This patch updates floatx80 functions to use
> this definition.
>
> This allows to define a different default Infinity
> value on m68k: the m68k F
Hi,
This series failed docker-build@min-glib build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180224154033.29559-1-mre...@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/7] block: Han
On 02/24/2018 09:40 AM, Max Reitz wrote:
Instead of converting all "backing": null instances into "backing": "",
handle a null value directly in bdrv_open_inherit().
This enables explicitly null backing links for json:{} filenames.
Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
---
bl
On 02/24/2018 09:40 AM, Max Reitz wrote:
This patch reworks some places which use either qobject_type() checks
plus qobject_to(), where the latter alone is sufficient, or NULL checks
plus qobject_type() checks where we can simply do a qobject_to() != NULL
check.
Signed-off-by: Max Reitz
Reviewe
On 02/24/2018 09:40 AM, Max Reitz wrote:
They are no longer needed now.
Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
---
include/qapi/qmp/qbool.h | 1 -
include/qapi/qmp/qdict.h | 1 -
include/qapi/qmp/qlist.h | 1 -
include/qapi/qmp/qnum.h| 1 -
include/qapi/qmp/qs
On 02/24/2018 09:40 AM, Max Reitz wrote:
This patch was generated using the following Coccinelle script:
and a bit of manual fix-up for overly long lines and three places in
tests/check-qjson.c that Coccinelle did not find.
Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
---
diff -
On 02/24/2018 09:40 AM, Max Reitz wrote:
This is a dynamic casting macro that, given a QObject type, returns an
object as that type or NULL if the object is of a different type (or
NULL itself).
The macro uses lower-case letters because:
1. There does not seem to be a hard rule on whether qemu m
Hi,
This series failed docker-quick@centos6 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180224154033.29559-1-mre...@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/7] block: Hand
Move fpu/softfloat-macros.h to include/fpu/
Export floatx80 functions to be used by target floatx80
specific implementations.
Exports:
propagateFloatx80NaN(), extractFloatx80Frac(),
extractFloatx80Exp(), extractFloatx80Sign(),
normalizeFloatx80Subnormal(), packFloatx80(),
roundAndPackFloa
Since f3218a8 ("softfloat: add floatx80 constants")
floatx80_infinity is defined but never used.
This patch updates floatx80 functions to use
this definition.
This allows to define a different default Infinity
value on m68k: the m68k FPU defines infinity with
all bits set to zero in the mantissa.
Using local m68k floatx80_getman(), floatx80_getexp(), floatx80_scale()
[copied from previous:
Written by Andreas Grabher for Previous, NeXT Computer Emulator.]
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
---
target/m68k/fpu_helper.c | 15 +
target/m68k/helper.h | 3
Using a local m68k floatx80_mod()
[copied from previous:
Written by Andreas Grabher for Previous, NeXT Computer Emulator.]
The quotient byte of the FPSR is updated with
the result of the operation.
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
---
target/m68k/Makefile.objs | 3
Implement fmod, frem, fscale, fgetman and fgetexp.
Instead of using functions of libm (v1 of this series)
and converting between host long double and floatx80 type
the new version (v2) adds new floatx80 functions in softfloat.
All the floatx80 functions are copied from "Previous",
the NeXT Comput
On 02/24/2018 09:40 AM, Max Reitz wrote:
_Static_assert() allows us to specify messages, and that may come in
handy. Even without _Static_assert(), encouraging developers to put a
helpful message next to the QEMU_BUILD_BUG_* may make debugging easier
whenever it breaks.
Signed-off-by: Max Reitz
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180224154033.29559-1-mre...@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/7] block: Handl
On 02/24/2018 06:56 AM, 苏航 wrote:
Hi, when I try to change
`while (cond) ;`
to
`while (cond) {
}`
checkpatch.pl complains about this:
'''
ERROR: suspect code indent for conditional statements (8, 8)
#1506: FILE: uri.c:1506:
+while ((*tmp++ = *segp++) != 0) {
[...]
+}
ERROR: suspe
Public bug reported:
While building QEMU on Mac OS 10.6.8 I saw this error message:
tag-target.inc.c:3495:no such instruction: `xgetbv'
In the file tcg/i386/tcg-target.inc.c at line 3495 is where the issue is
located. This is the problem code:
asm ("xgetbv" : "=a" (xcrl), "=d" (xcrh) : "c" (0));
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180224154033.29559-1-mre...@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the
Le 24/02/2018 à 18:26, Richard Henderson a écrit :
> On 02/24/2018 09:21 AM, Laurent Vivier wrote:
>> I think the change should be in fact:
>>
>> @@ -4549,10 +4555,7 @@ int64_t floatx80_to_int64(floatx80 a,
>> float_status *status)
>> if ( shiftCount <= 0 ) {
>> if ( shiftCount ) {
>>
On 02/24/2018 09:21 AM, Laurent Vivier wrote:
> I think the change should be in fact:
>
> @@ -4549,10 +4555,7 @@ int64_t floatx80_to_int64(floatx80 a,
> float_status *status)
> if ( shiftCount <= 0 ) {
> if ( shiftCount ) {
> float_raise(float_flag_invalid, status);
> -
Le 24/02/2018 à 03:26, Richard Henderson a écrit :
> On 02/23/2018 06:59 AM, Laurent Vivier wrote:
>> @@ -4550,8 +4556,8 @@ int64_t floatx80_to_int64(floatx80 a, float_status
>> *status)
>> if ( shiftCount ) {
>> float_raise(float_flag_invalid, status);
>> if (
Hi,
This series failed build test on s390x host. Please find the details below.
N/A. Internal error while reading log file
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
This patch was generated using the following Coccinelle script:
@@
expression Obj;
@@
(
- qobject_to_qnum(Obj)
+ qobject_to(Obj, QNum)
|
- qobject_to_qstring(Obj)
+ qobject_to(Obj, QString)
|
- qobject_to_qdict(Obj)
+ qobject_to(Obj, QDict)
|
- qobject_to_qlist(Obj)
+ qobject_to(Obj, QList)
|
- qo
This patch reworks some places which use either qobject_type() checks
plus qobject_to(), where the latter alone is sufficient, or NULL checks
plus qobject_type() checks where we can simply do a qobject_to() != NULL
check.
Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
---
qapi/qobject-inp
They are no longer needed now.
Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
---
include/qapi/qmp/qbool.h | 1 -
include/qapi/qmp/qdict.h | 1 -
include/qapi/qmp/qlist.h | 1 -
include/qapi/qmp/qnum.h| 1 -
include/qapi/qmp/qstring.h | 1 -
qobject/qbool.c| 11
We have a clear replacement, so let's deprecate it.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
---
qapi/block-core.json | 4 ++--
block.c | 4
qemu-doc.texi| 7 +++
qemu-options.hx | 4 ++--
4 files changed, 15 insertions(+),
Pïng
On 2018-01-22 23:07, Max Reitz wrote:
> This series implements an active and synchronous mirroring mode.
>
> Currently, the mirror block job is passive an asynchronous: Depending on
> your start conditions, some part of the source disk starts as "dirty".
> Then, the block job will (as a back
This is a dynamic casting macro that, given a QObject type, returns an
object as that type or NULL if the object is of a different type (or
NULL itself).
The macro uses lower-case letters because:
1. There does not seem to be a hard rule on whether qemu macros have to
be upper-cased,
2. The cur
Instead of converting all "backing": null instances into "backing": "",
handle a null value directly in bdrv_open_inherit().
This enables explicitly null backing links for json:{} filenames.
Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
---
block.c| 4 +++-
blockdev
Currently, we try to rewrite every occurrence of "backing": null into
"backing": "" in qmp_blockdev_add(). However, that breaks using the
same "backing": null construction in json:{} file names (which do not go
through qmp_blockdev_add()). Currently, these then just behave as if
the option has no
_Static_assert() allows us to specify messages, and that may come in
handy. Even without _Static_assert(), encouraging developers to put a
helpful message next to the QEMU_BUILD_BUG_* may make debugging easier
whenever it breaks.
Signed-off-by: Max Reitz
---
include/qemu/compiler.h | 12 +++
Hi,
Sorry in advance, if wrong maillist.
Where may I find comprehensive description how virtualization CPU
extensions (like VMX) interact with CPU data caches as well as
corresponding qemu implementation details? I've looked through
memory_ldst.inc.c with little success.
I am trying to debug vir
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180223235142.21501-1-js...@redhat.com
Subject: [Qemu-devel] [RFC v4 00/21] blockjobs: add explicit job management
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total
Add check for `while` and `for` statement, which condition has more than
one line.
The former checkpatch.pl can check `if` statement, which condition has more
than one line, whether block misses brace round, like this:
'''
if (cond1 ||
cond2)
statement;
'''
But it doesn't do the same check
Hi, when I try to change
`while (cond) ;`
to
`while (cond) {
}`
checkpatch.pl complains about this:
'''
ERROR: suspect code indent for conditional statements (8, 8)
#1506: FILE: uri.c:1506:
+while ((*tmp++ = *segp++) != 0) {
[...]
+}
ERROR: suspect code indent for conditional sta
Hi,
This series failed build test on s390x host. Please find the details below.
N/A. Internal error while reading log file
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180223153636.29809-1-alex.ben...@linaro.org
Subject: [Qemu-devel] [PATCH v3 00/31] Add ARMv8.2 half-precision functions
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
Hi,
This series failed docker-build@min-glib build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1519139403-2646-1-git-send-email...@kamp.de
Subject: [Qemu-devel] [PATCH] migration: do
Thanks for your comments :)
I will pay more attention to what you point out.
"Eric Blake" wrote:
> On 02/23/2018 03:34 AM, Thomas Huth wrote:
> > On 23.02.2018 08:51, Su Hang wrote:
> >> Add brackets that wrap `if`, `else`, `while` that hold single
> >> statements.
> >>
> >> In order to do this, I
Yes, you are right: sendkey does not send keys to the serial console. I
had a chat with Peter last year about it in the IRC where the explained:
hey! quick question: is the 'sendkey' monitor command supposed to
send the key presses to the serial console of the guest when running with
-nographic
Hi,
This series failed docker-build@min-glib build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180218144021.11641-1-vinc...@bernat.im
Subject: [Qemu-devel] [RFC, PATCH, v1] hw/audio
From: Jan Kiszka
Xen is doing this [1] and currently triggers an abort.
[1]
http://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=xen/drivers/passthrough/vtd/iommu.c;h=daaed0abbdd06b6ba3d948ea103aadf02651e83c;hb=refs/heads/master#l1108
Reported-by: Luis Lloret
Signed-off-by: Jan Kiszka
--
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: alpine.lsu.2.21.1802231729040.10...@wotan.suse.de
Subject: [Qemu-devel] [PATCH] ppc: Fix size of ppc64 xer register (fwd)
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
59 matches
Mail list logo
