Re: [Qemu-devel] [qemu-s390x] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-14 Thread Viktor Mihajlovski
On 15.02.2018 07:38, Thomas Huth wrote: > On 14.02.2018 18:46, Collin L. Walling wrote: >> I'm beginning to like the usage of splash-time to represent a timeout >> for the boot menu >> less and less.  It is really meant for how long a _splash_ _image_ >> should appear during boot. >> >> I'd like to

Re: [Qemu-devel] [qemu-s390x] [PATCH 11/30] hw/s390x: use the BYTE-based definitions

2018-02-14 Thread Thomas Huth
On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/s390x/sclp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index 276972b59f..8537aa

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-14 Thread Thomas Huth
On 14.02.2018 16:33, Collin L. Walling wrote: > On 02/14/2018 05:57 AM, David Hildenbrand wrote: [...] >> 1. CKC interrupts can be cleared by resetting the CKC >> 2. SCLP interrupts can be cleared only via delivery (apart from CPU >> reset) >> >> So if you have CKC and SCLP pending at the same time

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-14 Thread Thomas Huth
On 14.02.2018 18:46, Collin L. Walling wrote: > I'm beginning to like the usage of splash-time to represent a timeout > for the boot menu > less and less.  It is really meant for how long a _splash_ _image_ > should appear during boot. > > I'd like to suggest adding a new boot option "menu-timeout

Re: [Qemu-devel] [PATCH 04/30] hw/lm32/milkymist: remove unused include

2018-02-14 Thread Thomas Huth
On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/lm32/milkymist.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c > index 471a74eaa1..c28379399f 100644 > --- a/hw/lm32/milkymist.c > +++ b/hw/lm

Re: [Qemu-devel] [PATCH 05/30] hw/mips/r4k: constify params_size

2018-02-14 Thread Thomas Huth
On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mips_r4k.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c > index 830ee7732c..5a74c44b9a 100644 > --- a/hw/mips/mips_r

Re: [Qemu-devel] [PATCH 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"

2018-02-14 Thread Thomas Huth
On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > These files were including "qemu/cutils.h" to use the byte-based size > definitions, now available in "qemu/cunits.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/hw.h | 1 + > hw/arm/msf2-soc.c | 1 - > hw/arm/msf2-

[Qemu-devel] [PATCH V3 2/2] tests: Add migration test for aarch64

2018-02-14 Thread Wei Huang
This patch adds migration test support for aarch64. The test code, which implements the same functionality as x86, is booted as a kernel in qemu. Here are the design choices we make for aarch64: * We choose this -kernel approach because aarch64 QEMU doesn't provide a built-in fw like x86 does.

Re: [Qemu-devel] [PATCH 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file

2018-02-14 Thread Thomas Huth
On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: > where it is used. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/block/nvme.h | 1 - > hw/block/nvme.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/nvme.h b/hw/block/nvme.h > index 8f3981121d..cabcf2

[Qemu-devel] [PATCH V3 1/2] tests/migration: Convert the boot block compilation script into Makefile

2018-02-14 Thread Wei Huang
The x86 boot block header currently is generated with a shell script. To better support other CPUs (e.g. aarch64), we convert the script into Makefile. This allows us to 1) support cross-compilation easily; 2) avoid creating a script file for every architecture. Signed-off-by: Wei Huang --- test

[Qemu-devel] [PATCH V3 0/2] tests: Add migration test for aarch64

2018-02-14 Thread Wei Huang
This is a new version of migration-test for aarch64. This version needs to be applied on top of Dave Gilbert's recent patch "[v4] tests/migration: Add source to PC boot block". V2->V3: * Convert build script to Makefile * Add cross-compilation support * Fix CPU type for "tcg" machine type * Re

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Thomas Huth
On 14.02.2018 21:23, Eric Blake wrote: > On 02/14/2018 11:31 AM, Thomas Huth wrote: >> When running configure with --with-pkgversion=foo there is no >> space anymore between the version number and the parentheses: >> >> $ m68k-softmmu/qemu-system-m68k -version >> QEMU emulator version 2.11.50(foo)

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

2018-02-14 Thread Alexey Kardashevskiy
On 10/01/18 19:59, David Gibson wrote: > On Mon, Jan 08, 2018 at 07:35:43PM +1100, Alexey Kardashevskiy wrote: >> On 03/01/18 11:09, David Gibson wrote: >>> On Tue, Jan 02, 2018 at 05:13:09PM +1100, Alexey Kardashevskiy wrote: On 11/12/17 17:20, Alexey Kardashevskiy wrote: > On 09/11/17 17

Re: [Qemu-devel] [PATCH 10/30] hw/ppc: use the BYTE-based definitions

2018-02-14 Thread David Gibson
On Thu, Feb 15, 2018 at 01:28:40AM -0300, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > include/hw/ppc/spapr.h | 2 +- > hw/pci-host/prep.c | 2 +- > hw/ppc/e500.c | 8 >

[Qemu-devel] [PATCH 30/30] xen: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/xen_disk.c| 4 ++-- hw/xenpv/xen_domainbuild.c | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index f74fcd42d1..557005b5e5

[Qemu-devel] [PATCH 28/30] ivshmem: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 16f03701b7..9b3ad96471 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -1302,7 +1302,7 @@ static void ivshmem_reali

[Qemu-devel] [PATCH 20/30] hw/cris: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/cris/axis_dev88.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index 9ccc4350a5..1dea3c594c 100644 --- a/hw/cris/axis_dev88.c +++ b/hw/cris/axis_

[Qemu-devel] [PATCH 27/30] vfio/pci: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/pci-quirks.c | 8 hw/vfio/pci.c| 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index e5779a7ad3..3c091106dd 100644 --- a/hw

[Qemu-devel] [PATCH 19/30] hw/nios2: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/nios2/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c index 771e00267b..911f28c0d8 100644 --- a/hw/nios2/boot.c +++ b/hw/nios2/boot.c @@ -176,7 +176,7

[Qemu-devel] [PATCH 18/30] hw/microblaze: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/microblaze/petalogix_ml605_mmu.c | 6 +++--- hw/microblaze/petalogix_s3adsp1800_mmu.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/micr

[Qemu-devel] [PATCH 29/30] tpm: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/acpi/tpm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h index 96fd3a92f7..751567a73a 100644 --- a/include/hw/acpi/tpm.h +++ b/include/h

[Qemu-devel] [PATCH 22/30] hw/display: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 9 - hw/display/g364fb.c | 2 +- hw/display/qxl.c| 26 +++--- hw/display/vga-isa-mm.c | 4 ++-- hw/display/vga.c| 4 ++-- hw/display/virt

[Qemu-devel] [PATCH 15/30] hw/lm32: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. --- hw/lm32/lm32_boards.c | 12 ++-- hw/lm32/milkymist.c | 8 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c index 527bcc229c..15315101be 100644 --- a/hw/lm32/lm32_boards.c ++

[Qemu-devel] [PATCH 17/30] hw/tricore: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/tricore/tricore_testboard.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/tricore/tricore_testboard.c b/hw/tricore/tricore_testboard.c index ac75eb2128..032bcc8efb 100644 ---

[Qemu-devel] [PATCH 26/30] hw/smbios: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 27a07e96f4..fa02f9ce3f 100644 --- a/hw/smbios/smbios.c +++ b/hw/smb

[Qemu-devel] [PATCH 23/30] hw/net: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/allwinner_emac.h | 4 ++-- hw/net/e1000e.c | 6 +++--- hw/net/eepro100.c | 6 ++ 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/include/hw/net/allwinn

[Qemu-devel] [PATCH 16/30] hw/sh4: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/tc58128.c | 2 +- hw/sh4/r2d.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c index 1d9f7ee000..3e658d509f 100644 --- a/hw/block/tc58128

[Qemu-devel] [PATCH 10/30] hw/ppc: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ppc/spapr.h | 2 +- hw/pci-host/prep.c | 2 +- hw/ppc/e500.c | 8 hw/ppc/mac_oldworld.c | 7 +++ hw/ppc/ppc405_boards.c | 8 hw/ppc/ppc405_uc.c | 6 +++--- hw

[Qemu-devel] [PATCH 21/30] hw/misc: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/auxbus.c | 2 +- hw/misc/edu.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index b4cacd664b..c78aaebcbe 100644 --- a/hw/misc/auxbus.c +++ b/h

[Qemu-devel] [PATCH 25/30] hw/scsi: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-disk.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 49d2559d93..bfdb34a71c 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/s

[Qemu-devel] [PATCH 09/30] hw/sparc: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 8 hw/sparc/sun4m.c | 7 +++ hw/sparc64/niagara.c | 2 +- hw/sparc64/sun4u.c | 2 +- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sp

[Qemu-devel] [PATCH 24/30] hw/ipack: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/ipack/tpci200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ipack/tpci200.c b/hw/ipack/tpci200.c index da05c8589d..56c0ad8932 100644 --- a/hw/ipack/tpci200.c +++ b/hw/ipack/tpci200.

[Qemu-devel] [PATCH 12/30] hw/hppa: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/dino.c| 2 +- hw/hppa/machine.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index 15aefde09c..7728123cc8 100644 --- a/hw/hppa/dino.c +++ b

[Qemu-devel] [PATCH 13/30] hw/xtensa: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 70686a2eb1..922417af15 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@

[Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ich9.h | 2 +- hw/i386/acpi-build.c | 4 ++-- hw/i386/pc.c | 18 +- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 2 +- hw/i386/pc_sysfw.

[Qemu-devel] [PATCH 07/30] hw/arm: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/stm32f205_soc.h | 4 ++-- hw/arm/boot.c | 6 +++--- hw/arm/collie.c| 4 ++-- hw/arm/digic_boards.c | 6 +++--- hw/arm/gumstix.c | 2 +- hw/

[Qemu-devel] [PATCH 14/30] hw/alpha: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/typhoon.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index 6a40869488..0acfb4b1d0 100644 --- a/hw/alpha/typhoon.c +++ b/hw/a

[Qemu-devel] [PATCH 11/30] hw/s390x: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/sclp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 276972b59f..8537aa2688 100644 --- a/hw/s390x/sclp.c +++ b/hw/s390x/sclp.c @@ -526,8 +52

[Qemu-devel] [PATCH 05/30] hw/mips/r4k: constify params_size

2018-02-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_r4k.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index 830ee7732c..5a74c44b9a 100644 --- a/hw/mips/mips_r4k.c +++ b/hw/mips/mips_r4k.c @@ -79,8 +79,9 @@ typedef struct Rese

[Qemu-devel] [PATCH 04/30] hw/lm32/milkymist: remove unused include

2018-02-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/milkymist.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 471a74eaa1..c28379399f 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32/milkymist.c @@ -30,7 +30,6 @@ #include "hw/boards.h" #include "h

[Qemu-devel] [PATCH 06/30] hw/mips: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/intc/mips_gic.h | 2 +- include/hw/mips/bios.h | 2 +- hw/mips/boston.c | 2 +- hw/mips/mips_fulong2e.c| 6 +++--- hw/mips/mips_malta.c | 19 ++- hw/mips/mips_r

[Qemu-devel] [PATCH 01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h"

2018-02-14 Thread Philippe Mathieu-Daudé
(added in 076b35b5a56) Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/cunits.h | 11 +++ include/qemu/cutils.h | 8 +--- 2 files changed, 12 insertions(+), 7 deletions(-) create mode 100644 include/qemu/cunits.h diff --git a/include/qemu/cunits.h b/include/qemu/cunits.h ne

[Qemu-devel] [PATCH 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"

2018-02-14 Thread Philippe Mathieu-Daudé
These files were including "qemu/cutils.h" to use the byte-based size definitions, now available in "qemu/cunits.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/hw.h | 1 + hw/arm/msf2-soc.c | 1 - hw/arm/msf2-som.c | 1 - hw/core/loader-fit.c | 1 - hw/core/loader.c

[Qemu-devel] [PATCH 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file

2018-02-14 Thread Philippe Mathieu-Daudé
where it is used. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/nvme.h | 1 - hw/block/nvme.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.h b/hw/block/nvme.h index 8f3981121d..cabcf20c32 100644 --- a/hw/block/nvme.h +++ b/hw/block/nvme.h @@ -1,6 +1,5 @@

[Qemu-devel] [PATCH 00/30] hw: use the BYTE-based definitions when useful

2018-02-14 Thread Philippe Mathieu-Daudé
Hi, This series: - split the byte-based definitions from "qemu/cutils.h" to "qemu/cunits.h" and let them available for all hw/ files (via "hw/hw.h"); - clean hw/ includes; - replace different constants used for byte size with their corresponding BYTE-based definitions. patches generated usin

Re: [Qemu-devel] [PATCH 4/5] spapr: consolidate the VCPU id numbering logic in a single place

2018-02-14 Thread David Gibson
On Wed, Feb 14, 2018 at 08:40:53PM +0100, Greg Kurz wrote: > Several places in the code need to calculate a VCPU id: > > (cpu_index / smp_threads) * spapr->vsmt + cpu_index % smp_threads > (core_id / smp_threads) * spapr->vsmt (1 user) > index * spapr->vsmt (2 users) > > or guess that

Re: [Qemu-devel] [PATCH 5/5] spapr: drop DIV_ROUND_UP() from xics_max_server_number()

2018-02-14 Thread David Gibson
On Wed, Feb 14, 2018 at 08:41:03PM +0100, Greg Kurz wrote: > XICS needs to know the highest VCPU id that may be presented to the > guest plus 1. Commit f303f117fec3 "spapr: ensure we have at least one > XICS server" changed how the maximum is computed from: > > smp_cpus * kvmppc_smt_thread

Re: [Qemu-devel] [PATCH 1/5] spapr: use spapr->vsmt to compute VCPU ids

2018-02-14 Thread David Gibson
On Wed, Feb 14, 2018 at 08:40:26PM +0100, Greg Kurz wrote: > Since the introduction of VSMT in 2.11, the spacing of VCPU ids > between cores is controllable through a machine property instead > of being only dictated by the SMT mode of the host: > > cpu->vcpu_id = (cc->core_id * spapr->vsmt /

Re: [Qemu-devel] [PATCH 3/5] spapr: rename spapr_vcpu_id() to spapr_get_vcpu_id()

2018-02-14 Thread David Gibson
On Wed, Feb 14, 2018 at 08:40:44PM +0100, Greg Kurz wrote: > The spapr_vcpu_id() function is an accessor actually. Let's rename it > for symmetry with the recently added spapr_set_vcpu_id() helper. > > The motivation behind this is that a later patch will consolidate > the VCPU id formula in a fun

Re: [Qemu-devel] [PATCH v4] hw/char: remove legacy interface escc_init()

2018-02-14 Thread David Gibson
On Wed, Feb 14, 2018 at 07:35:58AM +0100, Laurent Vivier wrote: > Move necessary stuff in escc.h and update type names. > Remove slavio_serial_ms_kbd_init(). > Fix code style problems reported by checkpatch.pl > Update mac_newworld, mac_oldworld and sun4m to use directly the > QDEV interface. > >

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3 1/3] ppc/spapr-caps: Change migration macro to take full spapr-cap name

2018-02-14 Thread David Gibson
On Thu, Feb 15, 2018 at 11:44:41AM +1100, Suraj Jitindar Singh wrote: > Change the macro that generates the vmstate migration field and the needed > function for the spapr-caps to take the full spapr-cap name. This has > the benefit of meaning this instance will be picked up when greping > for the

[Qemu-devel] [PATCH] nbd: Honor server's advertised minimum block size

2018-02-14 Thread Eric Blake
Commit 79ba8c98 (v2.7) changed the setting of request_alignment to occur only during bdrv_refresh_limits(), rather than at at bdrv_open() time; but at the time, NBD was unaffected, because it still used sector-based callbacks, so the block layer defaulted NBD to use 512 request_alignment. Later, c

[Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase

2018-02-14 Thread Emilio G. Cota
A couple of notes: - removed ctx->nip in favour of base->pc_next. Yes, it is annoying, but didn't want to waste its 4 bytes. - ctx->singlestep_enabled does a lot more than base.singlestep_enabled; this confused me at first. Signed-off-by: Emilio G. Cota --- target/ppc/translate.c

[Qemu-devel] [PATCH 0/3] target/ppc: convert to generic translation loop

2018-02-14 Thread Emilio G. Cota
After converting riscv to the translation loop, I'm trying to keep the momentum going. Hopefully this will lead to quite a few more targets being converted. The appended converts the ppc target to TranslatorOps. I have tested it by booting ubuntu on a ppc64 guest. Please review! Thanks,

[Qemu-devel] [PATCH 3/3] target/ppc: convert to TranslatorOps

2018-02-14 Thread Emilio G. Cota
A few changes worth noting: - Didn't migrate ctx->exception to DISAS_* since the exception field is in many cases architecturally relevant. - Moved the cross-page check from the end of translate_insn to tb_start. - Removed the exit(1) after a TCG temp leak; changed the fprintf there to qemu_

[Qemu-devel] [PATCH 1/3] translator: add retcode to translator_loop_temp_check

2018-02-14 Thread Emilio G. Cota
This will allow us to print further info from target code. Signed-off-by: Emilio G. Cota --- accel/tcg/translator.c| 4 +++- include/exec/translator.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index 23c6602..f409a95

[Qemu-devel] [PATCH] target/hppa: use tb_cflags() to access tb->cflags

2018-02-14 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6499b39..b4b74a8 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -2075,7 +2075,7 @@ static Di

[Qemu-devel] ERROR:qom/object.c:907:object_unref: assertion failed (obj->ref > 0): (0 > 0)

2018-02-14 Thread Bandan Das
I get the error mentioined in the subject line when using vncviewer with commit 13e1d0e71e78a925848258391a6e616b6b5ae219: Author: Daniel P. Berrange Date: Thu Feb 1 16:45:14 2018 + ui: convert VNC server to QIONetListener The VNC server already has the ability to listen on mu

[Qemu-devel] [PATCH] tests: add test for TPM TIS device

2018-02-14 Thread Stefan Berger
Move the TPM TIS related register and flag #defines into include/hw/acpi/tpm.h for access by the test case. Write a test case that covers the TIS functionality. Add the tests cases to the MAINTAINERS file. Signed-off-by: Stefan Berger --- MAINTAINERS| 1 + hw/tpm/tpm_tis.c

[Qemu-devel] [QEMU-PPC] [PATCH V3 3/3] ppc/spapr-caps: For pseries-2.12 change spapr-cap defaults

2018-02-14 Thread Suraj Jitindar Singh
For the pseries-2.12 machine type, make the spapr-caps SPAPR_CAP_CFPC and SPAPR_CAP_SBBC default to workaround. Thus if the host is capable the guest will be able to take advantage of these workarounds by default. Otherwise if the host doesn't have these capabilities qemu will fail to start and the

[Qemu-devel] [QEMU-PPC] [PATCH V3 1/3] ppc/spapr-caps: Change migration macro to take full spapr-cap name

2018-02-14 Thread Suraj Jitindar Singh
Change the macro that generates the vmstate migration field and the needed function for the spapr-caps to take the full spapr-cap name. This has the benefit of meaning this instance will be picked up when greping for the spapr-caps and making it more obvious what this macro is doing. Signed-off-by

[Qemu-devel] [QEMU-PPC] [PATCH V3 2/3] ppc/spapr-caps: Convert spapr-cap-ibs to be a boolean

2018-02-14 Thread Suraj Jitindar Singh
The spapr-cap cap-ibs can only have values broken or fixed as there is no workaround. Currently setting the value workaround will hit an assert if the guest makes the hcall h_get_cpu_characteristics. Thus this capability is better suited to being represented as a boolean. Setting this to OFF corre

Re: [Qemu-devel] [PATCH] syscall: fix special case of write(fd, NULL, 0)

2018-02-14 Thread Oliver Smith
Hello there, I'm a little late to the party. But what is necessary to get this upstreamed, and how can I help? PS: Sorry if I picked the wrong e-mail addresses, I wasn't subscribed to the ML at that point and used the addresses I could find for the people who answered to the original thread here:

Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation

2018-02-14 Thread Emilio G. Cota
On Wed, Feb 14, 2018 at 13:13:09 -0800, Richard Henderson wrote: > On 02/14/2018 11:52 AM, Emilio G. Cota wrote: > > Should I send those patches to the list, or let Michael squash their > > changes? > > That's up to you, I guess. I don't mind if it goes in before or after merge. OK, will send t

[Qemu-devel] [ANNOUNCE] QEMU 2.11.1 Stable released

2018-02-14 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v2.11.1 stable release is now available: You can grab the tarball from our download page here: https://www.qemu.org/download/#source v2.11.1 is now tagged in the official qemu.git repository, and the stable-2.11 branch has been updated accor

Re: [Qemu-devel] [PATCH v2 1/4] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-02-14 Thread Eric Blake
On 02/13/2018 10:01 AM, Eric Blake wrote: On 02/13/2018 08:20 AM, Stefan Hajnoczi wrote: BlockDriverState has the BDRV_POLL_WHILE() macro to wait on event loop activity while a condition evaluates to true.  This is used to implement synchronous operations where it acts as a condvar between the I

Re: [Qemu-devel] [PATCH v2 1/4] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-02-14 Thread Eric Blake
On 02/14/2018 08:06 AM, Stefan Hajnoczi wrote: On Tue, Feb 13, 2018 at 10:01:06AM -0600, Eric Blake wrote: Trying to understand here: +#define AIO_WAIT_WHILE(wait, ctx, cond) ({ \ +bool waited_ = false; \ +bool busy_ = true;

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V2 3/3] ppc/spapr-caps: For pseries-2.12 change spapr-cap defaults

2018-02-14 Thread Suraj Jitindar Singh
On Wed, 2018-02-14 at 15:20 +0100, Greg Kurz wrote: > On Wed, 14 Feb 2018 17:51:35 +1100 > Suraj Jitindar Singh wrote: > > > For the pseries-2.12 machine type, make the spapr-caps > > SPAPR_CAP_CFPC > > and SPAPR_CAP_SBBC default to workaround. Thus if the host is > > capable > > the guest will b

Re: [Qemu-devel] [PATCH 2/3] block/ssh: Make ssh_grow_file() blocking

2018-02-14 Thread Max Reitz
On 2018-02-14 22:11, Eric Blake wrote: > On 02/14/2018 02:49 PM, Max Reitz wrote: >> At runtime (that is, during a future ssh_truncate()), the SSH session is >> non-blocking.  However, ssh_truncate() (or rather, bdrv_truncate() in >> general) is not a coroutine, so this resize operation needs to bl

Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation

2018-02-14 Thread Richard Henderson
On 02/14/2018 11:52 AM, Emilio G. Cota wrote: > Should I send those patches to the list, or let Michael squash their changes? That's up to you, I guess. I don't mind if it goes in before or after merge. r~

Re: [Qemu-devel] [PATCH 3/3] block/ssh: Add basic .bdrv_truncate()

2018-02-14 Thread Eric Blake
On 02/14/2018 02:49 PM, Max Reitz wrote: libssh2 does not seem to offer real truncation support, so we can only grow files -- but that is better than nothing. Signed-off-by: Max Reitz --- block/ssh.c | 24 1 file changed, 24 insertions(+) Reviewed-by: Eric Blake

Re: [Qemu-devel] [Qemu-stable] [PULL 10/25] virtio_error: don't invoke status callbacks

2018-02-14 Thread Peter Lieven
Am 13.02.2018 um 23:23 schrieb Michael S. Tsirkin: > On Tue, Feb 13, 2018 at 09:53:58PM +0100, Peter Lieven wrote: >> Am 21.12.2017 um 15:29 schrieb Michael S. Tsirkin: >>> Backends don't need to know what frontend requested a reset, >>> and notifying then from virtio_error is messy because >>> vir

Re: [Qemu-devel] [PATCH 2/3] block/ssh: Make ssh_grow_file() blocking

2018-02-14 Thread Eric Blake
On 02/14/2018 02:49 PM, Max Reitz wrote: At runtime (that is, during a future ssh_truncate()), the SSH session is non-blocking. However, ssh_truncate() (or rather, bdrv_truncate() in general) is not a coroutine, so this resize operation needs to block. For ssh_create(), that is fine, too; the s

Re: [Qemu-devel] [PATCH 1/3] block/ssh: Pull ssh_grow_file() from ssh_create()

2018-02-14 Thread Eric Blake
On 02/14/2018 02:49 PM, Max Reitz wrote: If we ever want to offer even rudimentary truncation functionality for ssh, we should put the respective code into a reusable function. Signed-off-by: Max Reitz --- block/ssh.c | 30 ++ 1 file changed, 22 insertions(+), 8 d

Re: [Qemu-devel] [RFC PATCH 0/2] s/size/entries/ when dealing with non-byte units

2018-02-14 Thread Max Reitz
On 2018-02-14 00:33, Eric Blake wrote: > I mentioned this while reviewing Berto's series on L2 slice handling; > this is a first cut at patches that I think are worth doing throughout > the qcow2 code base if we like the idea. I like the idea. :-) The patches look good to me. Max > Eric Blake (

[Qemu-devel] [PATCH 2/3] block/ssh: Make ssh_grow_file() blocking

2018-02-14 Thread Max Reitz
At runtime (that is, during a future ssh_truncate()), the SSH session is non-blocking. However, ssh_truncate() (or rather, bdrv_truncate() in general) is not a coroutine, so this resize operation needs to block. For ssh_create(), that is fine, too; the session is never set to non-blocking anyway.

[Qemu-devel] [PATCH 3/3] block/ssh: Add basic .bdrv_truncate()

2018-02-14 Thread Max Reitz
libssh2 does not seem to offer real truncation support, so we can only grow files -- but that is better than nothing. Signed-off-by: Max Reitz --- block/ssh.c | 24 1 file changed, 24 insertions(+) diff --git a/block/ssh.c b/block/ssh.c index ff8576f21e..c235eec255 1006

[Qemu-devel] [PATCH 1/3] block/ssh: Pull ssh_grow_file() from ssh_create()

2018-02-14 Thread Max Reitz
If we ever want to offer even rudimentary truncation functionality for ssh, we should put the respective code into a reusable function. Signed-off-by: Max Reitz --- block/ssh.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/block/ssh.c b/block

[Qemu-devel] [PATCH 0/3] block/ssh: Add basic .bdrv_truncate()

2018-02-14 Thread Max Reitz
For (x-)blockdev-create, all protocol drivers that support image creation also need to offer a .bdrv_truncate() implementation that matches in features. A previous series of mine brought gluster's and sheepdog's implementation up to par regarding preallocated truncation; but I forgot about drivers

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Eric Blake
On 02/14/2018 11:31 AM, Thomas Huth wrote: When running configure with --with-pkgversion=foo there is no space anymore between the version number and the parentheses: $ m68k-softmmu/qemu-system-m68k -version QEMU emulator version 2.11.50(foo) Fix it by moving the space from the configure script

Re: [Qemu-devel] [PATCH V2 1/1] tests: Add migration test for aarch64

2018-02-14 Thread Wei Huang
On 02/12/2018 11:31 AM, Andrew Jones wrote: > On Fri, Feb 09, 2018 at 04:42:42PM -0500, Wei Huang wrote: >> This patch adds migration test support for aarch64. The test code, which >> implements the same functionality as x86, is booted as a kernel in qemu. >> Here are the design choices we make f

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Eric Blake
On 02/14/2018 02:00 PM, Thomas Huth wrote: On 14.02.2018 19:33, Peter Maydell wrote: On 14 February 2018 at 17:31, Thomas Huth wrote: When running configure with --with-pkgversion=foo there is no space anymore between the version number and the parentheses: $ m68k-softmmu/qemu-system-m68k -ve

Re: [Qemu-devel] [PATCHv2 0/3] add query-cpu-fast and related s390 changes

2018-02-14 Thread Eric Blake
On 02/14/2018 09:16 AM, Eric Blake wrote: How shall we proceed with this series? Patch 3 depends upon patch 1, so I think it makes sense to merge this in one go. I can give my R-b on patch 1 and Someone(tm) can merge this, or I can take the whole series through the s390 tree (with some further r

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-14 Thread Thomas Huth
On 14.02.2018 19:33, Peter Maydell wrote: > On 14 February 2018 at 17:31, Thomas Huth wrote: >> When running configure with --with-pkgversion=foo there is no >> space anymore between the version number and the parentheses: >> >> $ m68k-softmmu/qemu-system-m68k -version >> QEMU emulator version 2.1

Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Eric Blake
On 02/13/2018 11:18 AM, Viktor Mihajlovski wrote: The s390 CPU state can be retrieved without interrupting the VM execution. Extendend the CpuInfoFast union with architecture s/Extendend/Extend/ specific data and an implementation for s390. Return data looks like this: [ {"thread-id":6

Re: [Qemu-devel] Assigning network devices to nested VMs results in driver errors in nested VMs

2018-02-14 Thread Jintack Lim
On Tue, Feb 13, 2018 at 11:44 PM, Jintack Lim wrote: > Hi, > > I'm trying to assign network devices to nested VMs on x86 using KVM, > but I got network device driver errors in the nested VMs. (I've tried > this about an year ago when vIOMMU patches were not upstreamed, and I > got similar errors a

Re: [Qemu-devel] [PATCH v5 09/23] RISC-V TCG Code Generation

2018-02-14 Thread Emilio G. Cota
On Wed, Feb 14, 2018 at 11:14:48 -0800, Richard Henderson wrote: > On 02/13/2018 04:10 PM, Emilio G. Cota wrote: > > On Tue, Feb 13, 2018 at 14:10:20 -0800, Richard Henderson wrote: > >> On 02/13/2018 01:55 PM, Emilio G. Cota wrote: > >>> Are we planning to use BS_STOP in the future? I see it has n

[Qemu-devel] [PATCH 3/5] spapr: rename spapr_vcpu_id() to spapr_get_vcpu_id()

2018-02-14 Thread Greg Kurz
The spapr_vcpu_id() function is an accessor actually. Let's rename it for symmetry with the recently added spapr_set_vcpu_id() helper. The motivation behind this is that a later patch will consolidate the VCPU id formula in a function and spapr_vcpu_id looks like an appropriate name. Signed-off-b

Re: [Qemu-devel] [PATCHv2 2/3] qmp: add query-cpus-fast

2018-02-14 Thread Eric Blake
On 02/13/2018 11:18 AM, Viktor Mihajlovski wrote: From: Luiz Capitulino The query-cpus command has an extremely serious side effect: it always interrupts all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for some workloads. And most of the informa

[Qemu-devel] [PATCH 2/5] spapr: move VCPU calculation to core machine code

2018-02-14 Thread Greg Kurz
The VCPU ids are currently computed and assigned to each individual CPU threads in spapr_cpu_core_realize(). But the numbering logic of VCPU ids is actually a machine-level concept, and many places in hw/ppc/spapr.c also have to compute VCPU ids out of CPU indexes. The current formula used in spap

[Qemu-devel] [PATCH 1/5] spapr: use spapr->vsmt to compute VCPU ids

2018-02-14 Thread Greg Kurz
Since the introduction of VSMT in 2.11, the spacing of VCPU ids between cores is controllable through a machine property instead of being only dictated by the SMT mode of the host: cpu->vcpu_id = (cc->core_id * spapr->vsmt / smp_threads) + i Until recently, the machine code would try to chang

[Qemu-devel] [PATCH 5/5] spapr: drop DIV_ROUND_UP() from xics_max_server_number()

2018-02-14 Thread Greg Kurz
XICS needs to know the highest VCPU id that may be presented to the guest plus 1. Commit f303f117fec3 "spapr: ensure we have at least one XICS server" changed how the maximum is computed from: smp_cpus * kvmppc_smt_threads() / smp_threads to: DIV_ROUND_UP(smp_cpus * kvmppc_smt_th

[Qemu-devel] [PATCH 4/5] spapr: consolidate the VCPU id numbering logic in a single place

2018-02-14 Thread Greg Kurz
Several places in the code need to calculate a VCPU id: (cpu_index / smp_threads) * spapr->vsmt + cpu_index % smp_threads (core_id / smp_threads) * spapr->vsmt (1 user) index * spapr->vsmt (2 users) or guess that the VCPU id of a given VCPU is the first thread of a virtual core:

[Qemu-devel] [PATCH 0/5] spapr: fix VCPU ids miscalculation

2018-02-14 Thread Greg Kurz
After the review of Laurent's patch "spapr: set vsmt to MAX(8, smp_threads)", I realized that most of the machine code that deals with VCPU ids assume the spacing between cores is kvmppc_smt_threads() instead of spapr->vsmt. Most of the time this is ok because both are equals, and QEMU used to exit

[Qemu-devel] [PATCH V11 09/10] hw/rdma: Implementation of PVRDMA device

2018-02-14 Thread Marcel Apfelbaum
From: Yuval Shaia PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. It works with its Linux Kernel driver AS IS, no need for any special guest modifications. While it complies with the VMware device, it can also communicate with bare metal RDMA-enabled machines and does

[Qemu-devel] [PATCH V11 08/10] hw/rdma: PVRDMA commands and data-path ops

2018-02-14 Thread Marcel Apfelbaum
From: Yuval Shaia First PVRDMA sub-module - implementation of the PVRDMA device. - PVRDMA commands such as create CQ and create MR. - Data path QP operations - post_send and post_recv. - Completion handler. Reviewed-by: Dotan Barak Reviewed-by: Zhu Yanjun Signed-off-by: Yuval Shaia Signed-off

[Qemu-devel] [PATCH V11 10/10] MAINTAINERS: add entry for hw/rdma

2018-02-14 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57358a08e2..6e7adad1df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2034,6 +2034,14 @@ F: block/replication.c F: tests/test-re

[Qemu-devel] [PATCH V11 06/10] hw/rdma: Definitions for rdma device and rdma resource manager

2018-02-14 Thread Marcel Apfelbaum
From: Yuval Shaia Definition of various structures and constants used in backend and resource manager modules. Reviewed-by: Dotan Barak Reviewed-by: Zhu Yanjun Signed-off-by: Yuval Shaia Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend_defs.h | 62 ++ hw/rdm

[Qemu-devel] [PATCH V11 00/10] hw/pvrdma: PVRDMA device implementation

2018-02-14 Thread Marcel Apfelbaum
V10 -> V11: - Addressed Michael S. Tsirkin comments: - Split the standard-headers patch in two, one dealing with the update-linux-headers script while the other adds the imported headers. - Add comments to the update-linux-headers script explaining the sed transformations. -

[Qemu-devel] [PATCH V11 07/10] hw/rdma: Implementation of generic rdma device layers

2018-02-14 Thread Marcel Apfelbaum
From: Yuval Shaia This layer is composed of two sub-modules, backend and resource manager. Backend sub-module is responsible for all the interaction with IB layers such as ibverbs and umad (external libraries). Resource manager is a collection of functions and structures to manage RDMA resources

  1   2   3   >