On 10/01/18 19:59, David Gibson wrote: > On Mon, Jan 08, 2018 at 07:35:43PM +1100, Alexey Kardashevskiy wrote: >> On 03/01/18 11:09, David Gibson wrote: >>> On Tue, Jan 02, 2018 at 05:13:09PM +1100, Alexey Kardashevskiy wrote: >>>> On 11/12/17 17:20, Alexey Kardashevskiy wrote: >>>>> On 09/11/17 17:38, David Gibson wrote: >>>>>> On Tue, Nov 07, 2017 at 06:14:04PM +1100, Alexey Kardashevskiy wrote: >>>>>>> On 20/10/17 11:46, Alexey Kardashevskiy wrote: >>>>>>>> On 19/10/17 17:24, David Gibson wrote: >>>>>>>>> On Tue, Oct 17, 2017 at 04:55:03PM +1100, Alexey Kardashevskiy wrote: >>>>>>>>>> On 16/10/17 20:36, David Gibson wrote: >>>>>>>>>>> On Mon, Oct 16, 2017 at 04:20:04PM +1100, Alexey Kardashevskiy >>>>>>>>>> wrote: >>>>>>>>> [snip] >>>>>>>>>>> || >>>>>>>>>>> >>>>>>>>>>> Yeah.. this is all a bit complicated, I'm really thinking about a >>>>>>>>>>> fdt_fsck() function for libfdt. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Oh. So what now? Do as below or wait for libdtc update? >>>>>>>>> >>>>>>>>> So I started hacking on this. It's a bit fiddlier to get right than I >>>>>>>>> anticipated. How about you make a placeholder function to "test" the >>>>>>>>> tree for now, with a comment that it will be updated once the libfdt >>>>>>>>> extensions are there. >>>>>>>> >>>>>>>> What would the placeholder do? Nothing or my proposed "FDT_CHK" thingy? >>>>>>>> >>>>>>>> Are we in a hurry with this one at all, or I can wait till libfdt gets >>>>>>>> this >>>>>>>> fsck()? >>>>>>> >>>>>>> >>>>>>> Ping? >>>>>>> >>>>>>> This is not v2.11 material, is it? >>>>>> >>>>>> Not at this stage, no. >>>>>> >>>>>> I've started looking at writing the fdt_fsck() thing, but got >>>>>> sidetracked by a bunch of related fixes to safety of handling >>>>>> corrupted blobs in libfdt. >>>>> >>>>> Please let me know when I can repost the " >>>>> ppc/spapr: Receive and store device tree blob from SLOF" again. Thanks. >>>> >>>> >>>> Still to early to repost? >>> >>> No. >> >> >> I looked at the recent libfdt (from qemu tree, sha1 e543880, v1.4.6) and >> could not find fdt_fsck() or similar, and I was waiting for this really, >> have I missed something? > > Oh, right, yeah, I haven't had time to look at that again.
Any progress with fdt_fsck()? Thanks, -- Alexey
signature.asc
Description: OpenPGP digital signature
