[Qemu-devel] [PATCH v3] hw/usb/ccid: Make ccid_card_init() take an error parameter

2017-12-24 Thread Mao Zhongyi
Replace init() of CCIDCardClass with realize, then convert ccid_card_init(), ccid_card_initfn() and it's callbacks to take an Error** in ordor to report the error more clearly. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Cao jin Signed-off-by: Mao Zhongyi Signed-off-by: Cao jin --- v3: add

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Peter Xu
On Mon, Dec 25, 2017 at 03:13:49PM +0800, Fam Zheng wrote: > On Mon, 12/25 14:18, Peter Xu wrote: > > On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > > > On Mon, 12/25 13:18, Peter Xu wrote: > > > > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > > > > On Tue, 12/19 16:4

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Fam Zheng
On Mon, 12/25 14:18, Peter Xu wrote: > On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > > On Mon, 12/25 13:18, Peter Xu wrote: > > > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > > > On Tue, 12/19 16:45, Peter Xu wrote: > > > > > Set maximum QMP command queue length to

Re: [Qemu-devel] [PATCH] irq: fix memory leak

2017-12-24 Thread Peter Xu
On Mon, Dec 25, 2017 at 10:47:04AM +0800, linzhecheng wrote: > entry is moved from list but is not freed. > > Signed-off-by: linzhecheng > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 351b64f77c..3c920db79a 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@ -3494,6 +

Re: [Qemu-devel] [PATCH] intel_iommu: a fix to vtd_dev_get_trans_type()

2017-12-24 Thread Peter Xu
On Mon, Dec 25, 2017 at 02:19:33PM +0800, Liu, Yi L wrote: > On Mon, Dec 25, 2017 at 01:45:22PM +0800, Peter Xu wrote: > > On Thu, Dec 21, 2017 at 02:15:19PM +0800, Liu, Yi L wrote: > > > vtd_ce_get_type() returns uin32_t and vtd_dev_get_trans_type() returns > > > the value from vtd_ce_get_type().

Re: [Qemu-devel] [PATCH v2] hw/usb/ccid: Make ccid_card_init() take an error parameter

2017-12-24 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 7221483436734a75f3919fb6caf7b4a79a7465b9.1514183911.git.maozy.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v2] hw/usb/ccid: Make ccid_card_init() take an error parameter === TEST SCRIPT

Re: [Qemu-devel] [PATCH v2] hw/usb/ccid: Make ccid_card_init() take an error parameter

2017-12-24 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 7221483436734a75f3919fb6caf7b4a79a7465b9.1514183911.git.maozy.f...@cn.fujitsu.com Subject: [Qemu-dev

[Qemu-devel] [PATCH v2] hw/usb/ccid: Make ccid_card_init() take an error parameter

2017-12-24 Thread Mao Zhongyi
Replace init() of CCIDCardClass with realize, then convert ccid_card_init(), ccid_card_initfn() and it's callbacks to take an Error** in ordor to report the error more clearly. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Cao jin Signed-off-by: Mao Zhongyi Signed-off-by: Cao jin --- hw/usb/c

Re: [Qemu-devel] [PATCH] intel_iommu: a fix to vtd_dev_get_trans_type()

2017-12-24 Thread Liu, Yi L
On Mon, Dec 25, 2017 at 01:45:22PM +0800, Peter Xu wrote: > On Thu, Dec 21, 2017 at 02:15:19PM +0800, Liu, Yi L wrote: > > vtd_ce_get_type() returns uin32_t and vtd_dev_get_trans_type() returns > > the value from vtd_ce_get_type(). However, vtd_dev_get_trans_type() > > returns int. This patch switc

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Peter Xu
On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > On Mon, 12/25 13:18, Peter Xu wrote: > > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > > On Tue, 12/19 16:45, Peter Xu wrote: > > > > Set maximum QMP command queue length to 8. If queue full, instead of > > > > queue the

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Fam Zheng
On Mon, 12/25 13:18, Peter Xu wrote: > On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > > On Tue, 12/19 16:45, Peter Xu wrote: > > > Set maximum QMP command queue length to 8. If queue full, instead of > > > queue the command, we directly return a "command-dropped" event, telling > > >

Re: [Qemu-devel] [PATCH] intel_iommu: a fix to vtd_dev_get_trans_type()

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 02:15:19PM +0800, Liu, Yi L wrote: > vtd_ce_get_type() returns uin32_t and vtd_dev_get_trans_type() returns > the value from vtd_ce_get_type(). However, vtd_dev_get_trans_type() > returns int. This patch switchs to return the translation type by > parameter. It avoids unsign

Re: [Qemu-devel] [PATCH] irq: fix memory leak

2017-12-24 Thread Peter Xu
On Mon, Dec 25, 2017 at 10:47:04AM +0800, linzhecheng wrote: > entry is moved from list but is not freed. > > Signed-off-by: linzhecheng > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 351b64f77c..3c920db79a 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@ -3494,6 +

Re: [Qemu-devel] [RFC v6 22/27] qmp: isolate responses into io thread

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 08:57:02PM +0800, Fam Zheng wrote: > On Tue, 12/19 16:45, Peter Xu wrote: > > For those monitors who has enabled IO thread, we'll offload the > > s/has/have/ > > > responding procedure into IO thread. The main reason is that chardev is > > not thread safe, and we need to

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 07:42:46PM +0800, Fam Zheng wrote: > On Tue, 12/19 16:45, Peter Xu wrote: > > Set maximum QMP command queue length to 8. If queue full, instead of > > queue the command, we directly return a "command-dropped" event, telling > > client that specific command is dropped. > >

Re: [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 07:40:13PM +0800, Fam Zheng wrote: [...] > > +/* > > + * Pop one QMP request from monitor queues, return NULL if not found. > > + * We are using round-robin fasion to pop the request, to avoid > > s/fasion/fashion/ Fixed. [...] > > static void monitor_qmp_read(void *o

[Qemu-devel] [Bug 1290370] Re: FreeBSD 9.2 shell crashes when run with -smp 4 option

2017-12-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1290370 Title: FreeBSD 9.2

[Qemu-devel] [Bug 1336801] Re: 12.04 guest hangs on a 14.04 host server with cirrus graphics

2017-12-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336801 Title: 12.04 guest

[Qemu-devel] [Bug 1374905] Re: Pixelation issue in 16-bit color VGA graphics

2017-12-24 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1374905 Title: Pixelation

[Qemu-devel] [Bug 1336801] Re: 12.04 guest hangs on a 14.04 host server with cirrus graphics

2017-12-24 Thread Launchpad Bug Tracker
[Expired for qemu (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336801 Ti

Re: [Qemu-devel] [RFC v6 15/27] monitor: let suspend/resume work even with QMPs

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 07:27:38PM +0800, Fam Zheng wrote: > On Tue, 12/19 16:45, Peter Xu wrote: > > One thing to mention is that for QMPs that are using IOThreads, we need > > an explicit kick for the IOThread in case it is sleeping. > > > > Since at it, add traces for the operations. > > > > S

Re: [Qemu-devel] [RFC v6 12/27] qmp: negotiate QMP capabilities

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 06:01:00PM +0800, Fam Zheng wrote: [...] > > +void qmp_qmp_capabilities(bool has_enable, QMPCapabilityList *enable, > > + Error **errp) > > { > > +Error *local_err = NULL; > > + > > if (cur_mon->qmp.commands == &qmp_commands) { > >

Re: [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2017-12-24 Thread Peter Xu
On Thu, Dec 21, 2017 at 05:56:37PM +0800, Fam Zheng wrote: > On Tue, 12/19 16:45, Peter Xu wrote: > > diff --git a/monitor.c b/monitor.c > > index 4b2bee773f..81fb0a42b4 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -3943,12 +3943,18 @@ void monitor_resume(Monitor *mon) > > > > static QO

[Qemu-devel] [PATCH v4 2/2] colo: compare the packet based on the tcp sequence number

2017-12-24 Thread Mao Zhongyi
Packet size some time different or when network is busy. Based on same payload size, but TCP protocol can not guarantee send the same one packet in the same way, like that: We send this payload: -- | header |1|2|3|4|5|6|7|8|9|0| -- primary:

[Qemu-devel] [PATCH v4 0/2] Rewrite TCP packet comparison in colo

2017-12-24 Thread Mao Zhongyi
v4: p2: fix some typo [Zhang Chen] v3: p1: merged the patch1 and patch2 from v2 p2: -merged the patch3 and patch4 from v2 -implement the same process flow for tcp, udp and icmp [Zhang Chen]

[Qemu-devel] [PATCH v4 1/2] colo: modified the payload compare function

2017-12-24 Thread Mao Zhongyi
Modified the function colo_packet_compare_common to prepare for the tcp packet comparison in the next patch. Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen --- net/colo-compare.c | 88

Re: [Qemu-devel] [RFC v6 01/27] chardev: use backend chr context when watch for fe

2017-12-24 Thread Peter Xu
On Wed, Dec 20, 2017 at 04:40:05PM +, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 04:45:31PM +0800, Peter Xu wrote: > > In commit 6bbb6c0644 ("chardev: use per-dev context for > > io_add_watch_poll", 2017-09-22) all the chardev watches are converted to > > use per-chardev gcontext to suppo

[Qemu-devel] [PATCH v2] iotests: Test creating overlay when guest running

2017-12-24 Thread Fam Zheng
Signed-off-by: Fam Zheng --- v2: Actually test the thing. [Kevin] --- tests/qemu-iotests/153 | 8 +--- tests/qemu-iotests/153.out | 7 --- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 index fa25eb24bd..adfd02695b 1007

[Qemu-devel] [PATCH] irq: fix memory leak

2017-12-24 Thread linzhecheng
entry is moved from list but is not freed. Signed-off-by: linzhecheng diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 351b64f77c..3c920db79a 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -3494,6 +3494,7 @@ int kvm_arch_release_virq_post(int virq) if (entry->virq ==

Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes

2017-12-24 Thread Fam Zheng
On Sat, 12/23 08:36, Corey Minyard wrote: > On 12/21/2017 05:10 PM, no-re...@patchew.org wrote: > > Hi, > > > > This series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably > > reproduce it > > locally. >

[Qemu-devel] [PATCH] input: fix memory leak

2017-12-24 Thread linzhecheng
If kbd_queue is not empty and queue_count >= queue_limit, we should free evt. Change-Id: Ieeacf90d5e7e370a40452ec79031912d8b864d83 Signed-off-by: linzhecheng diff --git a/ui/input.c b/ui/input.c index 3e2d324278..e5b78aae9e 100644 --- a/ui/input.c +++ b/ui/input.c @@ -421,6 +421,8 @@ void qemu_i

[Qemu-devel] [PATCH] vga: check the validation of memory addr when draw text

2017-12-24 Thread linzhecheng
Start a vm with qemu-kvm -enable-kvm -vnc :66 -smp 1 -m 1024 -hda redhat_5.11.qcow2 -device pcnet -vga cirrus, then use VNC client to connect to VM, and excute the code below in guest OS will lead to qemu crash: int main() { iopl(3); srand(time(NULL)); int a,b; while(1){

Re: [Qemu-devel] [PATCH v3 2/2] colo: compare the packet based on the tcp sequence number

2017-12-24 Thread Mao Zhongyi
On 12/25/2017 09:51 AM, Dou Liyang wrote: 转发的消息 主题: Re: [Qemu-devel] [PATCH v3 2/2] colo: compare the packet based on the tcp sequence number 日期: Mon, 25 Dec 2017 03:20:25 +0800 发件人: Zhang Chen 收件人: Mao Zhongyi 抄送: Jason Wang , qemu-devel@nongnu.org, Li Zhijian On Fri

Re: [Qemu-devel] [PATCH v3 2/2] colo: compare the packet based on the tcp sequence number

2017-12-24 Thread Mao Zhongyi
On 12/25/2017 09:51 AM, Dou Liyang wrote: 转发的消息 主题: Re: [Qemu-devel] [PATCH v3 2/2] colo: compare the packet based on the tcp sequence number 日期: Mon, 25 Dec 2017 03:20:25 +0800 发件人: Zhang Chen 收件人: Mao Zhongyi 抄送: Jason Wang , qemu-devel@nongnu.org, Li Zhijian On Fri

[Qemu-devel] [PATCH 1/2] util/pmem: add function to make writes to pmem persistent

2017-12-24 Thread Haozhong Zhang
The new function pmem_persistent() flushes the previous cached writes on the specified memory buffer, which ensures the write persistence if the buffer is in persistent memory. Signed-off-by: Haozhong Zhang --- include/qemu/pmem.h | 25 ++ util/Makefile.objs | 1 + util/pmem.c

[Qemu-devel] [PATCH 0/2] mem/nvdimm: ensure persistence of QEMU writes to real NVDIMM device

2017-12-24 Thread Haozhong Zhang
QEMU intercepts guest writes to vNVDIMM labels, and then stores them to the backend. When the backend is a real NVDIMM device, QEMU needs to ensure the write persistence before returning to guest, so that the guest labels will not be lost if QEMU exits abnormally. Haozhong Zhang (2): util/pmem:

[Qemu-devel] [PATCH 2/2] mem/nvdimm: ensure persistence of QEMU writes to real NVDIMM device

2017-12-24 Thread Haozhong Zhang
QEMU intercepts guest writes to vNVDIMM labels, and then stores them to the backend. When the backend is a real NVDIMM device, QEMU needs to ensure the write persistence before returning to guest, so that the guest labels will not be lost if QEMU exits abnormally. Signed-off-by: Haozhong Zhang --

Re: [Qemu-devel] [PATCH v3 2/2] colo: compare the packet based on the tcp sequence number

2017-12-24 Thread Zhang Chen
On Fri, Dec 22, 2017 at 5:28 PM, Mao Zhongyi wrote: > Packet size some time different or when network is busy. > Based on same payload size, but TCP protocol can not > garantee send the same one packet in the same way, > S/garantee /guarantee > > like that: > We send this payload: > --

Re: [Qemu-devel] [PATCH v3 1/2] colo: modified the payload compare function

2017-12-24 Thread Zhang Chen
On Fri, Dec 22, 2017 at 5:28 PM, Mao Zhongyi wrote: > Modified the function colo_packet_compare_common to prepare for the > tcp packet comparison in the next patch. > > Cc: Zhang Chen > Cc: Li Zhijian > Cc: Jason Wang > > Signed-off-by: Mao Zhongyi > Signed-off-by: Li Zhijian > Signed-off-by

Re: [Qemu-devel] [PATCH] linux-user: MIPS set cpu to r6 CPU if binary is R6

2017-12-24 Thread YunQiang Su
should something like: +int fd, retval; +off_t cur_pos; +bool is_execfd = true; +char bprm_buf[BPRM_BUF_SIZE]; + +fd = qemu_getauxval(AT_EXECFD); +if (fd == 0){ +is_execfd = false; +fd = open(path(filename), O_RDONLY); +if (fd < 0) { +ret

Re: [Qemu-devel] [PULL v4 00/19] Initial support for Hypervisor.framework

2017-12-24 Thread Paolo Bonzini
On 23/12/2017 17:02, Programmingkid wrote: >> for you to fetch changes up to >> 895f9fdf3ac5481ca5ad5763bf667cbf82aa52c4: >> >> i386: hvf: cleanup x86_gen.h (2017-12-22 15:02:07 +0100) >> >> >> Initial support for the HVF accelerat

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-12-24 Thread Wei Wang
On 12/24/2017 03:42 PM, Wei Wang wrote: On 12/24/2017 12:45 PM, Tetsuo Handa wrote: Matthew Wilcox wrote: +unsigned long pfn = page_to_pfn(page); +int ret; + +*pfn_min = min(pfn, *pfn_min); +*pfn_max = max(pfn, *pfn_max); + +do { +if (xb_preload(GFP_NOWAIT | __GFP_NO