Re: [Qemu-devel] [PATCH v2] util: add is_equal to UUID API

2017-11-27 Thread Fam Zheng
On Mon, 11/27 15:43, Roman Kagan wrote: > It's going to be useful, in particular, in VMBus code massively using > uuids aka GUIDs. > > Signed-off-by: Roman Kagan > --- > v1 -> v2: > - drop dedicated testcase (for it was of no value) and incorporate >is_null and is_equal assertions into uuid_

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2017-11-27 Thread ChristianEhrhardt
Also on the qemu side this is "works as intended" and workarounds are documented in this bug. So we should set that bug status as well - looking back given it was mostly a discussion I guess "opinion" is the best close status in this case. ** Changed in: qemu (Ubuntu) Status: Won't Fix =>

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2017-11-27 Thread ChristianEhrhardt
Umm, the latter is the official way to go, but only in latter libvirt versions. https://libvirt.org/git/?p=libvirt.git;a=commit;h=28907b0043fbf71085a798372ab9c816ba043b93 I'm adding a libvirt bug task for the bionic merge to pick that up "explicitly" ** Changed in: qemu (Ubuntu) Status: Ne

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2017-11-27 Thread ChristianEhrhardt
Note: Depending on the case you might also get lucky with "shareable" and/or "readonly" disk attributes. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716028 Title: qemu 2.10 locks images with no

Re: [Qemu-devel] [PATCH 4/4] iotests: add dirty bitmap migration test

2017-11-27 Thread Vladimir Sementsov-Ogievskiy
28.11.2017 10:14, Vladimir Sementsov-Ogievskiy wrote: The test creates two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bitmaps. For now, only migration through shared storage for persistent bitmaps is

[Qemu-devel] [PATCH 1/4] qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint()

2017-11-27 Thread Vladimir Sementsov-Ogievskiy
Add version of qcow2_reopen_bitmaps_rw, which do the same work but also return a hint about was header updated or not. This will be used in the following fix for bitmaps reloading after migration. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 2 ++ block/qcow2-bitmap.c

[Qemu-devel] [PATCH 4/4] iotests: add dirty bitmap migration test

2017-11-27 Thread Vladimir Sementsov-Ogievskiy
The test creates two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bitmaps. For now, only migration through shared storage for persistent bitmaps is available, so it is tested here. Only offline variant is

[Qemu-devel] [PATCH 3/4] scripts/qemu.py: tiny enhancement for event_wiat

2017-11-27 Thread Vladimir Sementsov-Ogievskiy
- add comment - allow int timeout and disallow bool (which has special meaning for pull_event()) - remove unreachable 'return None' Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/qemu.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/scripts/qemu.py b/s

[Qemu-devel] [PATCH 2/4] qcow2: handle reopening bitmaps on bdrv_invalidate_cache

2017-11-27 Thread Vladimir Sementsov-Ogievskiy
Consider migration with shared storage. Persistent bitmaps are stored on bdrv_inactivate. Then, on destination process_incoming_migration_bh() calls bdrv_invalidate_cache_all() which leads to qcow2_load_autoloading_dirty_bitmaps() which fails if bitmaps are already loaded on destination start. In t

[Qemu-devel] [PATCH for 2.11 0/4] fix bitmaps migration through shared storage

2017-11-27 Thread Vladimir Sementsov-Ogievskiy
Hi all. This fix may be considered as a material for 2.11, or may be postponed to 2.12, on your choice. The core patch is 02. Vladimir Sementsov-Ogievskiy (4): qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint() qcow2: handle reopening bitmaps on bdrv_invalidate_cache scripts/qemu.py: tiny en

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Yi Min Zhao
在 2017/11/28 上午12:02, Cornelia Huck 写道: On Mon, 27 Nov 2017 16:53:04 +0100 Pierre Morel wrote: On 27/11/2017 16:30, Cornelia Huck wrote: On Mon, 27 Nov 2017 16:24:08 +0100 Pierre Morel wrote: On 27/11/2017 15:34, Cornelia Huck wrote: On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Yi Min Zhao
在 2017/11/27 下午7:13, Thomas Huth 写道: On 27.11.2017 11:09, Yi Min Zhao wrote: 在 2017/11/27 下午2:59, Thomas Huth 写道: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: 在 2017/11/23 下午6

Re: [Qemu-devel] [PATCH v4] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread Fam Zheng
On Tue, 11/28 12:46, linzhecheng wrote: > If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault > in a low probability. > > The backtrace is: > #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at > ../nptl/sysdeps/unix/sysv/linux/raise.c:56 > #1 0x7f46c602a8c8

[Qemu-devel] [PATCH 2/2] hw/pci/pci.c : changed the access to ObjectClass to use OBJECT_CLASS macro

2017-11-27 Thread Yoni Bettan
Signed-off-by: Yoni Bettan --- hw/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 02f6f2f37a..d2bf749251 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2014,7 +2014,7 @@ static void pci_qdev_realize(DeviceState *qdev, Error **errp

[Qemu-devel] [PATCH 1/2] pci: removed the is_express field since a uniform interface was inserted

2017-11-27 Thread Yoni Bettan
* according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Signed-off-by: Yoni Bettan --- hw/block/nvme.c| 1 - hw/net/e1000e.c

Re: [Qemu-devel] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-27 Thread Jeff Cody
On Tue, Nov 28, 2017 at 12:29:09AM +0100, Kevin Wolf wrote: > Am 23.11.2017 um 18:57 hat Fam Zheng geschrieben: > > Jeff's block job patch made the latent drain bug visible, and I find this > > patch, which by itself also makes some sense, can hide it again. :) With it > > applied we are at least b

Re: [Qemu-devel] [PATCH v2 3/6] ppc: e500: Allow only supported dynamic sysbus devices

2017-11-27 Thread David Gibson
On Mon, Nov 27, 2017 at 11:12:43PM -0200, Eduardo Habkost wrote: > On Mon, Nov 27, 2017 at 12:52:09PM +1100, David Gibson wrote: > > On Sat, Nov 25, 2017 at 01:16:07PM -0200, Eduardo Habkost wrote: > > > platform_bus_create_devtree() already rejects all dynamic sysbus > > > devices except TYPE_ETSE

[Qemu-devel] [PATCH v4] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread linzhecheng
If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault in a low probability. The backtrace is: #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x7f46c602a8c8 in __GI_abort () at abort.c:90 #2 0x008543c9

[Qemu-devel] [PULL] virtio-net: don't touch virtqueue if vm is stopped

2017-11-27 Thread Jason Wang
Guest state should not be touched if VM is stopped, unfortunately we didn't check running state and tried to drain tx queue unconditionally in virtio_net_set_status(). A crash was then noticed as a migration destination when user type quit after virtqueue state is loaded but before region cache is

[Qemu-devel] [PULL] Net patches

2017-11-27 Thread Jason Wang
The following changes since commit 5e19aed59ab48ca3c7f1e2da203eed27b91bef2d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171127' into staging (2017-11-27 11:16:20 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pu

Re: [Qemu-devel] [PATCH v2] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread Fam Zheng
On Tue, 11/28 09:50, linzhecheng wrote: > If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault > in a low probability. > > The backtrace is: > arg=arg@entry=0x3f5cf70, mode=mode@entry=1) at > util/qemu_thread_posix.c:512 > at io/task.c:141 > destroy=destroy@e

[Qemu-devel] [PATCH v3] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread linzhecheng
If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault in a low probability. The backtrace is: #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x7f46c602a8c8 in __GI_abort () at abort.c:90 #2 0x008543c9

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Fam Zheng
On Mon, 11/27 13:02, Peter Maydell wrote: > On 26 November 2017 at 22:13, Brad Smith wrote: > > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > > constants. > > ncurses 5.7 was released in 200

Re: [Qemu-devel] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-27 Thread Fam Zheng
On Fri, 11/24 17:39, Kevin Wolf wrote: > Maybe the backtraces would help me understand the problem if they were > actually there. :-) Ouch, looks like git-tag(1) doesn't like to store # lines in the message. Unfortunately I rebooted the laptop and didn't save the vim buffer, thinking it is already

[Qemu-devel] [PATCH] etsec: fix IRQ (un)masking

2017-11-27 Thread Michael Davidsaver
Interrupt conditions occurring while masked are not being signaled when later unmasked. The fix is to raise/lower IRQs when IMASK is changed. To avoid problems like this in future, consolidate IRQ pin update logic in one function. Also fix probable typo "IEVENT_TXF | IEVENT_TXF", and update IRQ p

Re: [Qemu-devel] [PATCH v2 2/2] qemu-options: Mention locking option of file driver

2017-11-27 Thread Fam Zheng
On Fri, 11/24 16:24, Kevin Wolf wrote: > > @@ -693,6 +693,10 @@ This is the protocol-level block driver for accessing > > regular files. > > The path to the image file in the local filesystem > > @item aio > > Specifies the AIO backend (threads/native, default: threads) > > +@item locking > > +

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Dong Jia Shi
* Cornelia Huck [2017-11-27 13:58:16 +0100]: > On Mon, 27 Nov 2017 10:20:56 +0800 > Dong Jia Shi wrote: > > > * Halil Pasic [2017-11-24 17:39:04 +0100]: > > > > > > > > > > > On 11/24/2017 05:15 PM, Cornelia Huck wrote: > > > >>> In theory this should work. > > > >>> > > > >>> In reality

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Dong Jia Shi
* Cornelia Huck [2017-11-27 17:56:07 +0100]: > On Mon, 27 Nov 2017 16:09:09 +0100 > Boris Fiuczynski wrote: > > > On 11/27/2017 03:13 PM, Halil Pasic wrote: > > > > > > > > > On 11/27/2017 02:19 PM, Cornelia Huck wrote: > > >> On Mon, 27 Nov 2017 14:11:57 +0100 > > >> Halil Pasic wrote: >

[Qemu-devel] [PATCH v2] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread linzhecheng
If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault in a low probability. The backtrace is: arg=arg@entry=0x3f5cf70, mode=mode@entry=1) at util/qemu_thread_posix.c:512 at io/task.c:141 destroy=destroy@entry=0x0) at io/channel_socket.c:194 The root cause of t

[Qemu-devel] [Bug 1591611] Re: chroot using qemu-x86_64-static fails on ppc64el

2017-11-27 Thread Timothy Pearson
Nope, looks good here. As a note to other commenters, this won't work unless you are using a kernel compiled with the 4k page size -- default for PPC64 is 64k. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

Re: [Qemu-devel] [PATCH v2 6/6] q35: Allow only supported dynamic sysbus devices

2017-11-27 Thread Eduardo Habkost
On Mon, Nov 27, 2017 at 10:44:34AM +0200, Marcel Apfelbaum wrote: > On 25/11/2017 17:16, Eduardo Habkost wrote: > > The only user-creatable sysbus devices in qemu-system-x86_64 are > > amd-iommu, intel-iommu, and xen-backend. xen-backend is handled > > by xen_set_dynamic_sysbus(), so we only need

[Qemu-devel] [Bug 1734792] [NEW] qemu-x86_64 fails with unsupported syscall 319

2017-11-27 Thread Timothy Pearson
Public bug reported: qemu-x86_66 GIT HEAD fails on a userspace application that requires memfd_create with: "qemu: Unsupported syscall: 319". memfd_create support needs to be implemented in QEMU. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notific

Re: [Qemu-devel] [PATCH v2 3/6] ppc: e500: Allow only supported dynamic sysbus devices

2017-11-27 Thread Eduardo Habkost
On Mon, Nov 27, 2017 at 12:52:09PM +1100, David Gibson wrote: > On Sat, Nov 25, 2017 at 01:16:07PM -0200, Eduardo Habkost wrote: > > platform_bus_create_devtree() already rejects all dynamic sysbus > > devices except TYPE_ETSEC_COMMON, so register it as the only > > allowed dynamic sysbus device fo

Re: [Qemu-devel] [PATCH v2 3/6] ppc: e500: Allow only supported dynamic sysbus devices

2017-11-27 Thread Eduardo Habkost
On Sat, Nov 25, 2017 at 07:31:19PM +0100, Greg Kurz wrote: > On Sat, 25 Nov 2017 13:16:07 -0200 > Eduardo Habkost wrote: > > > platform_bus_create_devtree() already rejects all dynamic sysbus > > devices except TYPE_ETSEC_COMMON, so register it as the only > > allowed dynamic sysbus device for th

Re: [Qemu-devel] [PATCH v3 1/3] hostmem-file: add "align" option

2017-11-27 Thread Eduardo Habkost
On Mon, Nov 27, 2017 at 12:35:15PM +0800, Haozhong Zhang wrote: > When mmap(2) the backend files, QEMU uses the host page size > (getpagesize(2)) by default as the alignment of mapping address. > However, some backends may require alignments different than the page > size. For example, mmap a devic

[Qemu-devel] [Bug 1401798] Re: Qemu 2.2.0 savevm crash.

2017-11-27 Thread changlimin
** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1401798 Title: Qemu 2.2.0 savevm crash. Status in QEMU: Fix Released Bug description:

Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-27 Thread John Snow
On 11/27/2017 06:29 PM, Kevin Wolf wrote: > Am 23.11.2017 um 18:57 hat Fam Zheng geschrieben: >> Jeff's block job patch made the latent drain bug visible, and I find this >> patch, which by itself also makes some sense, can hide it again. :) With it >> applied we are at least back to the ground w

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-11-27 Thread Brad Smith
On 11/27/17 07:02, Peter Maydell wrote: On 26 November 2017 at 22:13, Brad Smith wrote: Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* constants. ncurses 5.7 was released in 2008 and is now 9 years

Re: [Qemu-devel] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-27 Thread Kevin Wolf
Am 23.11.2017 um 18:57 hat Fam Zheng geschrieben: > Jeff's block job patch made the latent drain bug visible, and I find this > patch, which by itself also makes some sense, can hide it again. :) With it > applied we are at least back to the ground where patchew's iotests (make > docker-test-block@

Re: [Qemu-devel] [PATCH v9 08/13] xilinx_spips: Make tx/rx_data_bytes more generic and reusable

2017-11-27 Thread francisco iglesias
On 27 November 2017 at 04:52, Philippe Mathieu-Daudé wrote: > Hi Francisco, > > On 11/26/2017 08:16 PM, Francisco Iglesias wrote: > > Make tx/rx_data_bytes more generic so they can be reused (when adding > > support for the Zynqmp Generic QSPI). > > > > Signed-off-by: Francisco Iglesias > > Revi

Re: [Qemu-devel] QEMU Summit 2017: minutes

2017-11-27 Thread John Snow
On 11/23/2017 11:31 AM, Peter Maydell wrote: > As usual, during this year's KVM Forum we also held the > QEMU Summit, which is where the more active subsystem > maintainers meet up for a discussion of various maintenance > and other project issues. As usual, none of this is set-in-stone > decisio

Re: [Qemu-devel] [PATCH for-2.11] block/nfs: fix nfs_client_open for filesize greater than 1TB

2017-11-27 Thread Max Reitz
On 2017-11-27 17:00, Peter Lieven wrote: > DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE) was overflowing ret (int) if > st.st_size is greater than 1TB. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Peter Lieven > --- > block/nfs.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Th

Re: [Qemu-devel] [SPARC] Accessing devices through MMU mapped memory region

2017-11-27 Thread Jean-Christophe DUBOIS
Surprisingly the GCC compiler transformed my 32 bits access into 4 x 8 bits access in my application code. So this is not a Qemu issue but I need to find why the compiler is not generating the code I was expecting. Sorry for the noise. JC Le 27/11/2017 à 21:16, Jean-Christophe DUBOIS a écri

[Qemu-devel] [PATCH v1 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-11-27 Thread Collin L. Walling
When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-build-20170714 interactive boot menu. 0. default

[Qemu-devel] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

2017-11-27 Thread Collin L. Walling
Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml: Where X represents some positive integer representing milliseconds. Signed-off-by: C

[Qemu-devel] [PATCH v1 0/5] (FIXED) Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread Collin L. Walling
These patches implement a boot menu for ECKD DASD and SCSI guests on s390x. The menu will only appear if the disk has been configured for IPL with the zIPL tool and with the following QEMU command line options: -boot menu=on[,splash-time=X] and/or -machine loadparm='prompt' or via the follo

[Qemu-devel] [PATCH v1 5/5] s390-ccw: interactive boot menu for scsi

2017-11-27 Thread Collin L. Walling
Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 9

[Qemu-devel] [PATCH v1 1/5] s390-ccw: update libc.h

2017-11-27 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function: itostr Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: fran...@linux

[Qemu-devel] [PATCH v1 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-27 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. A new struct, EckdLdlIpl1 is introduced and contains boot info for LDL. Also introduce structs for IPL stages 1 and 1b and for disk geometry.

Re: [Qemu-devel] [PATCH] build: fix typo in error message

2017-11-27 Thread Eric Blake
On 11/27/2017 11:49 AM, Mike Frysinger wrote: > Signed-off-by: Mike Frysinger > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh > index 030617b4ac0c..bc7224a27fe3 100755 > --- a/scripts/gi

Re: [Qemu-devel] [PATCH] Remove MemoryRegionSection check code from sparc_cpu_get_phys_page_debug()

2017-11-27 Thread Jean-Christophe DUBOIS
Hello Mark, Did you get any second opinion on this? Also do you need me to resend the patch with the SPARC keyword in the patch subject line? Regards JC Le 23/11/2017 à 20:49, Mark Cave-Ayland a écrit : On 22/11/17 06:32, Jean-Christophe Dubois wrote: This code is preventing the MMU debu

[Qemu-devel] [SPARC] Accessing devices through MMU mapped memory region

2017-11-27 Thread Jean-Christophe DUBOIS
Hi, I am using Qemu to emulate a Leon3 based board. In the software I am running on top of Qemu, I am mapping devices to a virtual address using MMU table. Now I am experimenting some issues when I am trying to access some device (here the UART port at 0x8100) through the MMU mapping (wi

Re: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread Collin L. Walling
On 11/27/2017 01:58 PM, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x Message-id: 1511808659-8846-1-git-send-email-wall...@lin

Re: [Qemu-devel] [PATCH] build: fix typo in error message

2017-11-27 Thread John Snow
On 11/27/2017 12:49 PM, Mike Frysinger wrote: > Signed-off-by: Mike Frysinger > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh > index 030617b4ac0c..bc7224a27fe3 100755 > --- a/scripts/

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

2017-11-27 Thread Andrew Baumann via Qemu-devel
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, 25 November 2017 10:05 > On 25 November 2017 at 16:43, bzt bzt wrote: > > Dear Andrew, > > > > A month passed, and the maintainers didn't gave a damn about raspi3 > support > > in qemu. Any ideas? > > Sorry this patch fell

Re: [Qemu-devel] [PATCH 03/17] i2c: add mpc8540 i2c controller

2017-11-27 Thread Michael Davidsaver
On 11/27/2017 01:12 AM, David Gibson wrote: > On Sun, Nov 26, 2017 at 03:59:01PM -0600, Michael Davidsaver wrote: >> Signed-off-by: Michael Davidsaver >> --- >> hw/i2c/Makefile.objs | 1 + >> hw/i2c/mpc8540_i2c.c | 307 >> +++ >> hw/i2c/trace-eve

Re: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x Message-id: 1511808659-8846-1-git-send-email-wall...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x Type: series Message-id: 1511808659-8846-1-git-send-email-wall...@linux.vnet.ibm.com === TEST SCRIPT BEGI

[Qemu-devel] [PATCH v1 3/4] s390-ccw: interactive boot menu for eckd dasd

2017-11-27 Thread Collin L. Walling
When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-build-20170714 interactive boot menu. 0. default

[Qemu-devel] [PATCH v1 4/4] s390-ccw: interactive boot menu for scsi

2017-11-27 Thread Collin L. Walling
Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 9

[Qemu-devel] [PATCH v1 1/4] s390-ccw: ipl structs for eckd cdl/ldl

2017-11-27 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. A new struct, EckdLdlIpl1 is introduced and contains boot info for LDL. Also introduce structs for IPL stages 1 and 1b and for disk geometry.

[Qemu-devel] [PATCH v1 2/4] s390-ccw: parse and set boot menu options

2017-11-27 Thread Collin L. Walling
Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml: Where X represents some positive integer representing milliseconds. Signed-off-by: C

[Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-11-27 Thread Collin L. Walling
These patches implement a boot menu for ECKD DASD and SCSI guests on s390x. The menu will only appear if the disk has been configured for IPL with the zIPL tool and with the following QEMU command line options: -boot menu=on[,splash-time=X] and/or -machine loadparm='prompt' or via the follo

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-27 Thread Deepa Srinivasan
> On Nov 23, 2017, at 9:29 AM, Kevin Wolf wrote: > > Am 23.11.2017 um 18:05 hat Deepa Srinivasan geschrieben: >> blk_aio_prwv() now takes a void pointer and the coroutine functions >> have been modified to cast it into QEMUIOVector if needed. It does not >> use an union in BlkRwCo since this lea

Re: [Qemu-devel] [PATCH v3 1/2] virtio: check VirtQueue Vring object is set

2017-11-27 Thread P J P
+-- On Mon, 27 Nov 2017, Cornelia Huck wrote --+ |The check for align is not really needed, as virtio-1 disallows setting align |anyway. disallows...? | Checking for !desc is wrong (why shouldn't a driver be able to unset a | descriptor table?) +-- On Mon, 27 Nov 2017, Stefan Hajnoczi wrote --

[Qemu-devel] [PATCH] build: fix typo in error message

2017-11-27 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index 030617b4ac0c..bc7224a27fe3 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -24,7 +24,7 @

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Halil Pasic
On 11/27/2017 05:56 PM, Cornelia Huck wrote: > On Mon, 27 Nov 2017 16:09:09 +0100 > Boris Fiuczynski wrote: > >> On 11/27/2017 03:13 PM, Halil Pasic wrote: >>> >>> >>> On 11/27/2017 02:19 PM, Cornelia Huck wrote: On Mon, 27 Nov 2017 14:11:57 +0100 Halil Pasic wrote: > On

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Aaron Conole
"Tan, Jianfeng" writes: > On 11/27/2017 10:27 PM, Yuanhan Liu wrote: >> On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: >>> Hi Aaron Conole && Jianfeng, >>> >>> The stp could not work in ovs-dpdk vhostuser. >>> Because the attached vhost device doesn't have MAC address. >>> >>> Now w

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 16:09:09 +0100 Boris Fiuczynski wrote: > On 11/27/2017 03:13 PM, Halil Pasic wrote: > > > > > > On 11/27/2017 02:19 PM, Cornelia Huck wrote: > >> On Mon, 27 Nov 2017 14:11:57 +0100 > >> Halil Pasic wrote: > >> > >>> On 11/27/2017 01:56 PM, Cornelia Huck wrote: >

Re: [Qemu-devel] [PATCH 1/2] ARM: BUG if jumping to usermode address in kernel mode

2017-11-27 Thread Cédric Le Goater
On 11/27/2017 12:50 PM, Peter Maydell wrote: > On 27 November 2017 at 11:47, Russell King - ARM Linux > wrote: >> On Mon, Nov 27, 2017 at 11:16:06AM +0100, Cédric Le Goater wrote: >>> Additional QEMU logging gives us : >>> >>> Ignoring attempt to switch CPSR_A flag from non-secure world with SCR

Re: [Qemu-devel] [PATCH v2 1/2] qdev-properties: add UUID property type

2017-11-27 Thread Marc-André Lureau
On Mon, Nov 27, 2017 at 2:05 PM, Roman Kagan wrote: > UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated > property type becomes helpful. > > The property accepts a string-formatted UUID or a special keyword "auto" > meaning a randomly generated UUID; the latter is also the defau

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-27 Thread Marc-André Lureau
On Mon, Nov 27, 2017 at 2:05 PM, Roman Kagan wrote: > Switch vmgenid device to use the UUID property type introduced in the > previous patch for its 'guid' property. > > One semantic change it introduces is that post-realize modification of > 'guid' via HMP or QMP will now be rejected with an erro

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Pierre Morel
On 27/11/2017 17:02, Cornelia Huck wrote: On Mon, 27 Nov 2017 16:53:04 +0100 Pierre Morel wrote: On 27/11/2017 16:30, Cornelia Huck wrote: On Mon, 27 Nov 2017 16:24:08 +0100 Pierre Morel wrote: On 27/11/2017 15:34, Cornelia Huck wrote: On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-27 Thread Ben Warren via Qemu-devel
It looks like you dropped Marc-André and my Reviewed-by lines. Please put them back. > On Nov 27, 2017, at 5:05 AM, Roman Kagan wrote: > > Switch vmgenid device to use the UUID property type introduced in the > previous patch for its 'guid' property. > > One semantic change it introduces is t

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Tan, Jianfeng
On 11/28/2017 12:14 AM, Aaron Conole wrote: Yuanhan Liu writes: On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: Hi Aaron Conole && Jianfeng, The stp could not work in ovs-dpdk vhostuser. Because the attached vhost device doesn't have MAC address. Now we have two ways to solve

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Adhemerval Zanella
On 27/11/2017 14:10, John Paul Adrian Glaubitz wrote: > On 11/27/2017 05:07 PM, Adhemerval Zanella wrote:> However I am not very > compelled to change internal posix_spawn >> on GLIBC on Linux mainly because it uses a slight less resources >> than the generic POSIX one (check e83be730910c) and i

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Aaron Conole
Yuanhan Liu writes: > On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: >> Hi Aaron Conole && Jianfeng, >> >> The stp could not work in ovs-dpdk vhostuser. >> Because the attached vhost device doesn't have MAC address. >> >> Now we have two ways to solve this problem. >> 1. The vhost

[Qemu-devel] [PATCH] pci: removed the is_express field since a uniform interface was inserted

2017-11-27 Thread Yoni Bettan
* according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Signed-off-by: Yoni Bettan --- hw/block/nvme.c| 1 - hw/net/e1000e.c

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread John Paul Adrian Glaubitz
On 11/27/2017 05:07 PM, Adhemerval Zanella wrote:> However I am not very compelled to change internal posix_spawn on GLIBC on Linux mainly because it uses a slight less resources than the generic POSIX one (check e83be730910c) and it works on Linux kernel as expected. But it breaks QEMU and Mi

Re: [Qemu-devel] [PATCH v6 00/26] tcg: generic vector operations

2017-11-27 Thread Timothy Pearson
Just as a note, I've been watching these series with great interest. Once the changes settle down / are mergeable we will be looking to implement vector <--> vector support between a couple of other architectures. Thanks for working on this! On 11/21/2017 03:25 PM, Richard Henderson wrote: > Quit

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Adhemerval Zanella
On 27/11/2017 13:24, Peter Maydell wrote: > On 27 November 2017 at 12:57, Adhemerval Zanella > wrote: >> We found out this potential bogus assert on 2.27 development [1] which >> resulted in two fixes [2][3]. >> >> It should not be an issue for generic posix_spawn usage where there is >> no expe

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 16:53:04 +0100 Pierre Morel wrote: > On 27/11/2017 16:30, Cornelia Huck wrote: > > On Mon, 27 Nov 2017 16:24:08 +0100 > > Pierre Morel wrote: > > > >> On 27/11/2017 15:34, Cornelia Huck wrote: > >>> On Mon, 27 Nov 2017 12:02:55 +0100 > >>> Cornelia Huck wrote: > >>>

[Qemu-devel] [PATCH for-2.11] block/nfs: fix nfs_client_open for filesize greater than 1TB

2017-11-27 Thread Peter Lieven
DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE) was overflowing ret (int) if st.st_size is greater than 1TB. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- block/nfs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 337fcd9..effc8

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Pierre Morel
On 27/11/2017 16:30, Cornelia Huck wrote: On Mon, 27 Nov 2017 16:24:08 +0100 Pierre Morel wrote: On 27/11/2017 15:34, Cornelia Huck wrote: On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck wrote: On Mon, 27 Nov 2017 07:59:36 +0100 Thomas Huth wrote: On 25.11.2017 14:49, Pierre Morel

Re: [Qemu-devel] [dpdk-dev] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-27 Thread Tan, Jianfeng
On 11/27/2017 10:27 PM, Yuanhan Liu wrote: On Fri, Nov 24, 2017 at 05:59:09PM +0800, Chen Hailin wrote: Hi Aaron Conole && Jianfeng, The stp could not work in ovs-dpdk vhostuser. Because the attached vhost device doesn't have MAC address. Now we have two ways to solve this problem. 1. The vh

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Cornelia Huck
On Mon, 27 Nov 2017 16:24:08 +0100 Pierre Morel wrote: > On 27/11/2017 15:34, Cornelia Huck wrote: > > On Mon, 27 Nov 2017 12:02:55 +0100 > > Cornelia Huck wrote: > > > >> On Mon, 27 Nov 2017 07:59:36 +0100 > >> Thomas Huth wrote: > >> > >>> On 25.11.2017 14:49, Pierre Morel wrote: > >>>

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Pierre Morel
On 27/11/2017 15:34, Cornelia Huck wrote: On Mon, 27 Nov 2017 12:02:55 +0100 Cornelia Huck wrote: On Mon, 27 Nov 2017 07:59:36 +0100 Thomas Huth wrote: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 12:57, Adhemerval Zanella wrote: > We found out this potential bogus assert on 2.27 development [1] which > resulted in two fixes [2][3]. > > It should not be an issue for generic posix_spawn usage where there is > no expectation system/user/program kills random pids (since

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Subject: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread Type: series Message-id: 20171127145936.15676-1-linzhech...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing sc

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread Paolo Bonzini
On 27/11/2017 16:08, Daniel P. Berrange wrote: > We should just do > > if (mode == QEMU_THREAD_DETACHED) { > pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); > } > This is true, but Zhecheng's patch (when fixed---see patchew's report) would also fix a similar race on

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Paolo Bonzini
On 27/11/2017 16:06, Peter Maydell wrote: > On 27 November 2017 at 15:53, Paolo Bonzini wrote: >> On 27/11/2017 15:47, Peter Maydell wrote: >>> I have a patch from rth based on an idea he and I came up with: >>> we add a field to the PageDesc struct to store the thread id of >>> the thread that la

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-27 Thread Boris Fiuczynski
On 11/27/2017 03:13 PM, Halil Pasic wrote: On 11/27/2017 02:19 PM, Cornelia Huck wrote: On Mon, 27 Nov 2017 14:11:57 +0100 Halil Pasic wrote: On 11/27/2017 01:56 PM, Cornelia Huck wrote: On Fri, 24 Nov 2017 17:39:04 +0100 Halil Pasic wrote: On 11/24/2017 05:15 PM, Cornelia Huck wrote

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread Daniel P. Berrange
On Mon, Nov 27, 2017 at 10:59:36PM +0800, linzhecheng wrote: > If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault > in a low probability. > > The backtrace is: > #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at > ../nptl/sysdeps/unix/sysv/linux/raise.c:56 > #1

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Peter Maydell
On 27 November 2017 at 15:53, Paolo Bonzini wrote: > On 27/11/2017 15:47, Peter Maydell wrote: >> I have a patch from rth based on an idea he and I came up with: >> we add a field to the PageDesc struct to store the thread id of >> the thread that last touches the flags. If you come into the >> se

Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread Message-id: 20171127145936.15676-1-linzhech...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing

Re: [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

2017-11-27 Thread Max Reitz
On 2017-11-23 08:24, Fam Zheng wrote: > On Thu, 11/23 03:08, Max Reitz wrote: >> (I hate to write Python tests because the boilerplate seems so large and >> the debugging is so hard. But there is test 194 which shows that it is >> possible to write simple bash-like tests as well--and that is how

[Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread

2017-11-27 Thread linzhecheng
If we create a thread with QEMU_THREAD_DETACHED mode, QEMU may get a segfault in a low probability. The backtrace is: #0 0x7f46c60291d7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x7f46c602a8c8 in __GI_abort () at abort.c:90 #2 0x008543c9

[Qemu-devel] tpm: swtpm and libtpms projects tagged

2017-11-27 Thread Stefan Berger
Hello! I tagged libtpms with TPM 1.2 and TPM 2 support with tag/v0.6.0-dev1 and swtpm with TPM 1.2 and TPM 2 support with tag/v0.1.0-dev2. The git repos of the respective projects are here: libtpms: https://github.com/stefanberger/libtpms swtpm: https://github.com/stefanberger/swtpm Note:

Re: [Qemu-devel] glibc "linux: spawni.c: simplify error reporting to parent" breaks qemu-user/Windows Service For Linux

2017-11-27 Thread Adhemerval Zanella
On 26/11/2017 18:35, John Paul Adrian Glaubitz wrote: > On 11/26/2017 09:28 PM, John Paul Adrian Glaubitz wrote: >> I'm not sure yet what the actual problem is but I thought it should be >> necessary >> to point you at the problem. > > Ok, there is already a QEMU bug report for this [1]. > > Adr

Re: [Qemu-devel] javac crash in user-mode emulation: races on page_unprotect()

2017-11-27 Thread Paolo Bonzini
On 27/11/2017 15:47, Peter Maydell wrote: > On 27 November 2017 at 15:38, Paolo Bonzini wrote: >> On 24/11/2017 18:18, Peter Maydell wrote: >>> * threads A & B both try to do a write to a page with code in it at >>>the same time (ie which we've made non-writeable, so SEGV) >>> * they race in

  1   2   >