Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v1 0/4] Interactive Boot Menu for DASD and SCSI
Guests on s390x
Type: series
Message-id: 1511808659-8846-1-git-send-email-wall...@linux.vnet.ibm.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/1511808659-8846-1-git-send-email-wall...@linux.vnet.ibm.com ->
patchew/1511808659-8846-1-git-send-email-wall...@linux.vnet.ibm.com
Switched to a new branch 'test'
0624863a96 s390-ccw: interactive boot menu for scsi
71e76c88d2 s390-ccw: interactive boot menu for eckd dasd
b336111df1 s390-ccw: parse and set boot menu options
d197f099ae s390-ccw: ipl structs for eckd cdl/ldl
=== OUTPUT BEGIN ===
Checking PATCH 1/4: s390-ccw: ipl structs for eckd cdl/ldl...
Checking PATCH 2/4: s390-ccw: parse and set boot menu options...
ERROR: consider using qemu_strtol in preference to strtol
#52: FILE: hw/s390x/ipl.c:234:
+ *boot_menu_timeout = p ? strtol(p, &p, 10) : 0;
total: 1 errors, 0 warnings, 84 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/4: s390-ccw: interactive boot menu for eckd dasd...
Checking PATCH 4/4: s390-ccw: interactive boot menu for scsi...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
