Re: [Qemu-devel] [PATCH] s390x/sclp: mark sclp-cpu-hotplug as non-usercreatable

2017-10-04 Thread Christian Borntraeger
On 10/04/2017 05:46 PM, Cornelia Huck wrote: > A TYPE_SCLP_CPU_HOTPLUG device for handling cpu hotplug events > is already created by the sclp event facility. Adding a second > TYPE_SCLP_CPU_HOTPLUG device via -device sclp-cpu-hotplug creates > an ambiguity in raise_irq_cpu_hotplug(), leading to a

Re: [Qemu-devel] [PATCH] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-04 Thread Thomas Huth
On 04.10.2017 23:21, Eduardo Habkost wrote: > On Wed, Oct 04, 2017 at 09:29:54PM +0200, Thomas Huth wrote: >> On 04.10.2017 13:36, Igor Mammedov wrote: >>> On Tue, 3 Oct 2017 18:46:02 +0200 >>> Thomas Huth wrote: >>> The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, >>>

[Qemu-devel] [PATCH qemu v5 2/2] spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2017-10-04 Thread Alexey Kardashevskiy
This implements a notification for a new IOMMU group attached to sPAPR's logical IO bus (LIOBN) to enable in-kernel TCE acceleration. This uses new kernel KVM_CAP_SPAPR_TCE_VFIO capability to enable in-kernel acceleration of TCE update requests which will go via the VFIO KVM device. Signed-off-by

[Qemu-devel] [PATCH qemu v5 0/2] vfio-pci, spapr: Allow in-kernel TCE ops acceleration

2017-10-04 Thread Alexey Kardashevskiy
This is my current working tree to support kernel's "powerpc/kvm/vfio: Enable in-kernel acceleration". Changes: v5: * changed IOMMU MR callbacks and reworked the whole thing as David suggested v4: * rebased on the latest upstream with IOMMU MR QOM and VFIO initialization reordering v3: * fixed m

[Qemu-devel] [PATCH qemu v5 1/2] memory/iommu/vfio: Define add_vfio_group() callback

2017-10-04 Thread Alexey Kardashevskiy
The new callback will be called when a new VFIO IOMMU group is added. This should cause no behavioral change, the next patch will. Signed-off-by: Alexey Kardashevskiy --- This could be at the higher level - in MemoryRegionOps, makes sense? --- include/exec/memory.h | 4 hw/vfio/common.c

Re: [Qemu-devel] [PATCH v4 2/2] vl: Deprecate auto-loading of qemu.conf

2017-10-04 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Oct 04, 2017 at 09:23:08AM -0300, Eduardo Habkost wrote: >> On Wed, Oct 04, 2017 at 07:42:17AM +0200, Markus Armbruster wrote: >> > Eduardo Habkost writes: >> > >> > > In case there were options set in the default config file, print >> > > a warning so users ca

Re: [Qemu-devel] [Qemu-arm] [PATCH 00/20] ARM v8M: exception entry, exit and security

2017-10-04 Thread Philippe Mathieu-Daudé
On 09/22/2017 11:59 AM, Peter Maydell wrote: > Another week, another set of v8M patches. > This lot adds: > * v8M and security extension changes in exception entry and exit > * the Security Attribution Unit > * SG and BLXNS instructions > * secure function return > * and a couple of fixes for

Re: [Qemu-devel] [Qemu-arm] [PATCH 15/20] target/arm: Fix calculation of secure mm_idx values

2017-10-04 Thread Philippe Mathieu-Daudé
On 09/22/2017 12:00 PM, Peter Maydell wrote: > In cpu_mmu_index() we try to do this: > if (env->v7m.secure) { > mmu_idx += ARMMMUIdx_MSUser; > } > but it will give the wrong answer, because ARMMMUIdx_MSUser > includes the 0x40 ARM_MMU_IDX_M field, and so does the > mmu_i

Re: [Qemu-devel] [RFC PATCH 19/32] qapi: Accept double-quoted strings

2017-10-04 Thread Markus Armbruster
Marc-André Lureau writes: > On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote: >> The QAPI schema parser has always accepted only single-quoted strings, >> even though JSON strings are double-quoted. Accept double-quoted >> strings as well, so you can write strings containing single quote

Re: [Qemu-devel] [PATCH 02/20] target/arm: Don't switch to target stack early in v7M exception return

2017-10-04 Thread Philippe Mathieu-Daudé
On 09/22/2017 11:59 AM, Peter Maydell wrote: > Currently our M profile exception return code switches to the > target stack pointer relatively early in the process, before > it tries to pop the exception frame off the stack. This is > awkward for v8M for two reasons: > * in v8M the process vs main

Re: [Qemu-devel] [Qemu-arm] [PATCH 20/20] nvic: Add missing code for writing SHCSR.HARDFAULTPENDED bit

2017-10-04 Thread Philippe Mathieu-Daudé
On 09/22/2017 12:00 PM, Peter Maydell wrote: > When we added support for the new SHCSR bits in v8M in commit > 437d59c17e9 the code to support writing to the new HARDFAULTPENDED > bit was accidentally only added for non-secure writes; the > secure banked version of the bit should also be writable.

Re: [Qemu-devel] [RFC PATCH 15/32] tests/qapi-schema: Improve simple union coverage

2017-10-04 Thread Markus Armbruster
Marc-André Lureau writes: > On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote: >> This demonstrates a bug in the lowering of simple unions: if more than >> one schema uses the same built-in type T for a simple union member, >> they all generate the same q_obj_T_wrapper into their qapi-type

Re: [Qemu-devel] [RFC PATCH 14/32] qapi: Rework generated code for built-in types

2017-10-04 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote: >> qapi-types.py and qapi-visit.py generate some C code for built-in >> types. To make this work with multiple schemas, we generate code for >> built-ins into .c files only when the user asks for it with

Re: [Qemu-devel] [Qemu-arm] [PATCH 16/20] target/arm: Factor out "get mmuidx for specified security state"

2017-10-04 Thread Philippe Mathieu-Daudé
On 09/22/2017 12:00 PM, Peter Maydell wrote: > For the SG instruction and secure function return we are going > to want to do memory accesses using the MMU index of the CPU > in secure state, even though the CPU is currently in non-secure > state. Write arm_v7m_mmu_idx_for_secstate() to do this job

Re: [Qemu-devel] [Qemu-arm] [PATCH 03/20] target/arm: Prepare for CONTROL.SPSEL being nonzero in Handler mode

2017-10-04 Thread Philippe Mathieu-Daudé
On 09/22/2017 11:59 AM, Peter Maydell wrote: > In the v7M architecture, there is an invariant that if the CPU is > in Handler mode then the CONTROL.SPSEL bit cannot be nonzero. > This in turn means that the current stack pointer is always > indicated by CONTROL.SPSEL, even though Handler mode alway

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-04 Thread Sean Feole
I was able to gather libvirt XMLs from both Newton and Ocata Instances, see attached sfeole@BSG-75:~$ diff xmlocata xmlnewton 1,2c1,2 < < main type='kvm' id='1'> --- > ubuntu@lundmark:/var/lib/nova/instances/358596e4-135d-461d-a514-84116440014c$ > sudo virsh dumpxml instance-0001 > 4c4 <

Re: [Qemu-devel] [PATCH v2 0/4] blockjobs: add explicit job reaping

2017-10-04 Thread John Snow
"Oh boy, another email from John! I bet it's concisely worded." Ha ha. I see my reputation precedes me. "Holy crap dude, that's a lot of words you've typed down there!" It's okay, skip to the "TLDR" for the conclusion I arrived at if you don't care how I got there! "Sigh, okay, John." Yes!! O

Re: [Qemu-devel] [PATCH v6 01/22] instrument: Add documentation

2017-10-04 Thread Emilio G. Cota
On Thu, Oct 05, 2017 at 02:28:12 +0300, Lluís Vilanova wrote: > Emilio G Cota writes: > > I see some potential problems with this: > > 1. Instrumenters' accesses could generate exceptions. I presume we'd want > > to avoid > >this, or leave it as a debug-only kind of option. > > The API takes

Re: [Qemu-devel] [PATCH v6 01/22] instrument: Add documentation

2017-10-04 Thread Lluís Vilanova
Emilio G Cota writes: > On Sat, Sep 30, 2017 at 00:46:33 +0300, Lluís Vilanova wrote: >> Emilio G Cota writes: >> > I'm not sure I understand this concept of filtering. Are you saying that in >> > the first case, all memory accesses are instrumented, and then in the >> > "access helper" we only ca

[Qemu-devel] [PATCH] linux-user: Add random ioctls

2017-10-04 Thread Marco A L Barbosa
I don't know how (and if it is necessary) to add buf field to rand_pool_info struct. See https://github.com/torvalds/linux/blob/5924bbecd0267d87c24110cbe2041b5075173a25/include/uapi/linux/random.h#L17 Signed-off-by: Marco A L Barbosa --- linux-user/ioctls.h| 7 +++ linux-user/syscall

Re: [Qemu-devel] [PATCH v1 2/5] netduino2: Specify the valid CPUs

2017-10-04 Thread Philippe Mathieu-Daudé
>>> +const char *netduino_valid_cpus[] = { ARM_CPU_TYPE_NAME("cortex-m3"), >> style nit, ^^^ put entries on new line with >> typical 4 space alignment > > Do you mean like this? > > const char *netduino_valid_cpus[] = { > ARM_CPU_

Re: [Qemu-devel] [PATCH v1 2/5] netduino2: Specify the valid CPUs

2017-10-04 Thread Alistair Francis
On Wed, Oct 4, 2017 at 4:02 AM, Igor Mammedov wrote: > On Tue, 3 Oct 2017 13:05:11 -0700 > Alistair Francis wrote: > >> List all possible valid CPU options. >> >> Although the board only ever has a Cortex-M3 we mark the Cortex-M4 as >> supported because the Netduino2 Plus supports the Cortex-M4 a

Re: [Qemu-devel] [PATCH v1 3/5] xlnx-zcu102: Specify the valid CPUs

2017-10-04 Thread Alistair Francis
On Wed, Oct 4, 2017 at 9:34 AM, Eduardo Habkost wrote: > On Wed, Oct 04, 2017 at 03:08:16PM +0200, Igor Mammedov wrote: >> On Wed, 4 Oct 2017 09:28:51 -0300 >> Eduardo Habkost wrote: >> >> > On Wed, Oct 04, 2017 at 01:12:32PM +0200, Igor Mammedov wrote: >> > > On Tue, 3 Oct 2017 14:41:17 -0700 >>

Re: [Qemu-devel] [PATCH] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-04 Thread Eduardo Habkost
On Wed, Oct 04, 2017 at 09:29:54PM +0200, Thomas Huth wrote: > On 04.10.2017 13:36, Igor Mammedov wrote: > > On Tue, 3 Oct 2017 18:46:02 +0200 > > Thomas Huth wrote: > > > >> The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, > >> so QEMU crashes when the user tries to devic

Re: [Qemu-devel] [PATCH v6 6/6] tests: Add check-qobject for equality tests

2017-10-04 Thread Eric Blake
On 10/04/2017 10:25 AM, Max Reitz wrote: > Add a new test file (check-qobject.c) for unit tests that concern > QObjects as a whole. > > Its only purpose for now is to test the qobject_is_equal() function. > > Signed-off-by: Max Reitz > --- > tests/Makefile.include | 4 +- > tests/check-qobjec

Re: [Qemu-devel] [PATCH v6 2/6] qapi/qlist: Add qlist_append_null() macro

2017-10-04 Thread Eric Blake
On 10/04/2017 10:25 AM, Max Reitz wrote: > Besides the macro itself, this patch also adds a corresponding > Coccinelle rule. > > Signed-off-by: Max Reitz > --- > include/qapi/qmp/qlist.h | 3 +++ > scripts/coccinelle/qobject.cocci | 3 +++ > 2 files changed, 6 insertions(+) Reviewed-by:

Re: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES()

2017-10-04 Thread Eduardo Habkost
On Wed, Oct 04, 2017 at 12:08:02PM +0200, Igor Mammedov wrote: > DEFINE_TYPES() will help to simplify following routine patterns: > > static void foo_register_types(void) > { > type_register_static(&foo1_type_info); > type_register_static(&foo2_type_info); > ... > } > > type_init(

Re: [Qemu-devel] [Qemu-block] [PATCH RFC] block: add block-insert-node QMP command

2017-10-04 Thread Manos Pitsidianakis
On Wed, Oct 04, 2017 at 08:09:24PM +0200, Max Reitz wrote: On 2017-10-04 19:05, Manos Pitsidianakis wrote: On Wed, Oct 04, 2017 at 02:49:27PM +0200, Max Reitz wrote: On 2017-08-15 09:45, Manos Pitsidianakis wrote: block-insert-node and its pair command block-remove-node provide runtime inserti

Re: [Qemu-devel] [PATCH v2 2/3] qom: introduce type_register_static_array()

2017-10-04 Thread Eduardo Habkost
On Wed, Oct 04, 2017 at 12:08:01PM +0200, Igor Mammedov wrote: > it will help to remove code duplication of registration > static types in places that have open coded loop to > perform batch type registering. > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost I will wait for 1 day o

Re: [Qemu-devel] [PATCH v2 1/3] qom: update doc comment for type_register[_static]()

2017-10-04 Thread Eduardo Habkost
On Wed, Oct 04, 2017 at 12:08:00PM +0200, Igor Mammedov wrote: > type_register()/type_register_static() functions in current impl. > can't fail returning 0, also none of the users check for error > so update doc comment to reflect current behaviour. > > Suggested-by: Eduardo Habkost > Signed-off-

Re: [Qemu-devel] [PATCH v4 2/2] vl: Deprecate auto-loading of qemu.conf

2017-10-04 Thread Eduardo Habkost
On Wed, Oct 04, 2017 at 09:23:08AM -0300, Eduardo Habkost wrote: > On Wed, Oct 04, 2017 at 07:42:17AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > In case there were options set in the default config file, print > > > a warning so users can update their scripts. > > > > >

Re: [Qemu-devel] [PATCH v3 0/2] Deprecate -nodefconfig

2017-10-04 Thread Eduardo Habkost
On Wed, Oct 04, 2017 at 12:00:23AM -0300, Eduardo Habkost wrote: > Changes v2 -> v3: > * Move documentation to the right section of qemu-doc.texi > > Changes v1 -> v2: > * Document at "Deprecated features" section in qemu-doc.texi > (Daniel) > * Remove documentation for the option from qemu-opti

Re: [Qemu-devel] [PATCH v4 1/2] config: qemu_config_parse() return number of config groups

2017-10-04 Thread Eduardo Habkost
On Tue, Oct 03, 2017 at 11:50:42PM -0300, Eduardo Habkost wrote: > Change qemu_config_parse() to return the number of config groups > in success and -EINVAL on error. This will allow callers of > qemu_config_parse() to check if something was really loaded from > the config file. > > All existing c

Re: [Qemu-devel] [PATCH] qdev: Check for the availability of a hotplug controller before adding a device

2017-10-04 Thread Thomas Huth
On 04.10.2017 13:36, Igor Mammedov wrote: > On Tue, 3 Oct 2017 18:46:02 +0200 > Thomas Huth wrote: > >> The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, >> so QEMU crashes when the user tries to device_add + device_del a device >> that does not have a corresponding hotplug

Re: [Qemu-devel] [PATCH v1 00/12] ARM v8.1 simd + v8.3 complex insns

2017-10-04 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20171004184325.24157-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v1 00/12] ARM v8.1 s

Re: [Qemu-devel] [PATCH v1 00/12] ARM v8.1 simd + v8.3 complex insns

2017-10-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171004184325.24157-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v1 00/12] ARM v8.1 simd + v8.3 complex insns === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH v1 12/12] target/arm: Decode aa32 armv8.3 2-reg-index

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index 48f30e2621..50ef2f1f21 100644 --- a/target/arm/translate.c +++ b/target/arm/tra

[Qemu-devel] [PATCH v1 11/12] target/arm: Decode aa32 armv8.3 3-same

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index ee1e364fb5..48f30e2621 100644 --- a/target/arm/translate.c +++ b/target/arm/tra

[Qemu-devel] [PATCH v1 08/12] target/arm: Add ARM_FEATURE_V8_FCMA

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 1 + linux-user/elfload.c | 1 + target/arm/cpu.c | 1 + target/arm/cpu64.c | 1 + 4 files changed, 4 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index c5c9cef834..fdf72534d0 100644 --- a/target/arm/cpu.h +++ b/

[Qemu-devel] [PATCH v1 09/12] target/arm: Decode aa64 armv8.3 fcadd

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.h | 5 target/arm/advsimd_helper.c | 66 + target/arm/translate-a64.c | 33 ++- 3 files changed, 103 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.h

[Qemu-devel] [PATCH v1 06/12] target/arm: Decode aa32 armv8.1 three same

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 83 ++ 1 file changed, 64 insertions(+), 19 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index ab1a12a1b8..0cd58710b3 100644 --- a/target/arm/translate.c +++

[Qemu-devel] [PATCH v1 05/12] target/arm: Decode aa64 armv8.1 scalar/vector x indexed element

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 46 -- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 0ea47a9dff..b02aad8cd7 100644 --- a/target/arm/translat

[Qemu-devel] [PATCH v1 07/12] target/arm: Decode aa32 armv8.1 two reg and a scalar

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 0cd58710b3..ee1e364fb5 100644 --- a/target/arm/translate.c +++ b/target/arm/t

[Qemu-devel] [PATCH v1 03/12] target/arm: Decode aa64 armv8.1 scalar three same extra

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.h | 4 ++ target/arm/advsimd_helper.c | 105 target/arm/translate-a64.c | 90 + target/arm/Makefile.objs| 2 +- 4 files changed, 200 insertions

[Qemu-devel] [PATCH v1 01/12] HACK: use objdump disas

2017-10-04 Thread Richard Henderson
--- disas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas.c b/disas.c index d6a1eb9c8e..69069a85ca 100644 --- a/disas.c +++ b/disas.c @@ -231,7 +231,7 @@ void target_disas(FILE *out, CPUState *cpu, target_ulong code, s.info.disassembler_options = (char *)"any";

[Qemu-devel] [PATCH v1 02/12] target/arm: Add ARM_FEATURE_V8_1_SIMD

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 1 + linux-user/elfload.c | 9 + target/arm/cpu.c | 1 + target/arm/cpu64.c | 1 + 4 files changed, 12 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 69cb49acc3..c5c9cef834 100644 --- a/target/arm/cpu

[Qemu-devel] [PATCH v1 04/12] target/arm: Decode aa64 armv8.1 three same extra

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.h | 9 + target/arm/advsimd_helper.c | 74 +++ target/arm/translate-a64.c | 84 + 3 files changed, 167 insertions(+) diff --git a/target/arm/helper

[Qemu-devel] [PATCH v1 10/12] target/arm: Decode aa64 armv8.3 fcmla

2017-10-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.h | 8 +++ target/arm/advsimd_helper.c | 86 target/arm/translate-a64.c | 119 ++-- 3 files changed, 176 insertions(+), 37 deletions(-) diff --git a/target/

[Qemu-devel] [PATCH v1 00/12] ARM v8.1 simd + v8.3 complex insns

2017-10-04 Thread Richard Henderson
This patch set depends on v3 of native-vector-registers; for ease of review the whole tree is at git://github.com/rth7680/qemu.git tgt-arm-cplx I have successfully tested all insns for AArch64 via RISU. I have successfully tested everything but VCMLA for AArch32. The insn that doesn't match up

Re: [Qemu-devel] [PATCH v2 0/7] xen: xen-domid-restrict improvements

2017-10-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1507132392-25051-1-git-send-email-ian.jack...@eu.citrix.com Subject: [Qemu-devel] [PATCH v2 0/7] xen: xen-domid-restrict improvements === TEST SCRIPT BEGIN === #!/bin/bash B

Re: [Qemu-devel] [PATCH v2 0/4] blockjobs: add explicit job reaping

2017-10-04 Thread Kevin Wolf
Am 04.10.2017 um 03:52 hat John Snow geschrieben: > For jobs that complete when a monitor isn't looking, there's no way to > tell what the job's final return code was. We need to allow jobs to > remain in the list until queried for reliable management. Just a short summary of what I discussed with

Re: [Qemu-devel] [Qemu-block] [PATCH RFC] block: add block-insert-node QMP command

2017-10-04 Thread Max Reitz
On 2017-10-04 19:05, Manos Pitsidianakis wrote: > On Wed, Oct 04, 2017 at 02:49:27PM +0200, Max Reitz wrote: >> On 2017-08-15 09:45, Manos Pitsidianakis wrote: >>> block-insert-node and its pair command block-remove-node provide runtime >>> insertion and removal of filter nodes. >>> >>> block-inser

Re: [Qemu-devel] [PATCH] s390x/tcg: initialize machine check queue

2017-10-04 Thread Richard Henderson
On 10/04/2017 12:25 PM, Cornelia Huck wrote: > Just as for external interrupts and I/O interrupts, we need to > initialize mchk_index during cpu reset. > > Signed-off-by: Cornelia Huck > --- > > Trying a device_add with a ccw device under tcg currently insta-crashes > qemu. Probably nobody ever

Re: [Qemu-devel] [PATCH] hw/s390x/sclp: Mark the sclp device with user_creatable = false

2017-10-04 Thread Thomas Huth
On 04.10.2017 17:18, Pierre Morel wrote: > On 04/10/2017 15:53, Thomas Huth wrote: >> The "sclp" device is just an internal device that can not be instantiated >> by the users. If they try to use it, they only get a simple error >> message: >> >> $ qemu-system-s390x -nographic -device sclp >> qemu-

Re: [Qemu-devel] [Qemu-block] [PATCH RFC] block: add block-insert-node QMP command

2017-10-04 Thread Manos Pitsidianakis
On Wed, Oct 04, 2017 at 02:49:27PM +0200, Max Reitz wrote: On 2017-08-15 09:45, Manos Pitsidianakis wrote: block-insert-node and its pair command block-remove-node provide runtime insertion and removal of filter nodes. block-insert-node takes a (parent, child) and (node, child) pair of edges an

Re: [Qemu-devel] [PATCH v1 1/2] scsi-disk: support reporting of rotation rate

2017-10-04 Thread Daniel P. Berrange
On Wed, Oct 04, 2017 at 05:49:44PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > The Linux kernel will query the SCSI "Block device characteristics" > > VPD to determine the rotations per minute of the disk. If this has > > the value 1, it is taken to

Re: [Qemu-devel] [PATCH v1 1/2] scsi-disk: support reporting of rotation rate

2017-10-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > The Linux kernel will query the SCSI "Block device characteristics" > VPD to determine the rotations per minute of the disk. If this has > the value 1, it is taken to be an SSD and so Linux sets the > 'rotational' flag to 0 for the I/O queue and w

Re: [Qemu-devel] [PATCH v1 3/5] xlnx-zcu102: Specify the valid CPUs

2017-10-04 Thread Eduardo Habkost
On Wed, Oct 04, 2017 at 03:08:16PM +0200, Igor Mammedov wrote: > On Wed, 4 Oct 2017 09:28:51 -0300 > Eduardo Habkost wrote: > > > On Wed, Oct 04, 2017 at 01:12:32PM +0200, Igor Mammedov wrote: > > > On Tue, 3 Oct 2017 14:41:17 -0700 > > > Alistair Francis wrote: > > > > > > > On Tue, Oct 3, 2

Re: [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl

2017-10-04 Thread Daniel P. Berrange
On Wed, Oct 04, 2017 at 06:44:20PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Do not use '/r' modifier which was introduced in perl 5.14. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/checkpatch.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel

Re: [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests

2017-10-04 Thread Kevin Wolf
Am 12.09.2017 um 16:44 hat Paolo Bonzini geschrieben: > The purpose of this series is to separate the "check" sources from > the tests. After these patches, common.config is reduced to simple > shell initialization, and common.rc is only included by the tests. > > Along the way, a lot of dead cod

[Qemu-devel] [PATCH] s390x/tcg: initialize machine check queue

2017-10-04 Thread Cornelia Huck
Just as for external interrupts and I/O interrupts, we need to initialize mchk_index during cpu reset. Signed-off-by: Cornelia Huck --- Trying a device_add with a ccw device under tcg currently insta-crashes qemu. Probably nobody ever tried the crw machine check support that I hacked in... Need

[Qemu-devel] [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-04 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson --- v2: Add compatibility stu

[Qemu-devel] [PATCH 3/8] xen: defer call to xen_restrict until after os_setup_post

2017-10-04 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so on

[Qemu-devel] [PATCH 4/8] xen: destroy_hvm_domain: Move reason into a variable

2017-10-04 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 7b60ec6..83420cd 100644 --- a/

[Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-04 Thread Ian Jackson
And insist that it works. Drop individual use of xendevicemodel_restrict and xenforeignmemory_restrict. These are not actually effective in this version of qemu, because qemu has a large number of fds open onto various Xen control devices. The restriction arrangements are still not right, becaus

[Qemu-devel] [PATCH v2 0/*] xen: xen-domid-restrict improvements

2017-10-04 Thread Ian Jackson
(Resending this because 1. I got the CC for xen-devel wrong; 2. I got the subject wrong: there are actually 8 patches; 3. I mangled Anthony's name in theheaders. Sorry for the noise.) I have been working on trying to get qemu, when running as a Xen device model, to _actually_ not have power equiv

[Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-10-04 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. Signed-off-by: Ian Jackson --- v2: Coding style fixes. --- os-posix.c | 31 +++ qemu-options.hx | 12

[Qemu-devel] [PATCH 5/8] xen: move xc_interface compatibility fallback further up the file

2017-10-04 Thread Ian Jackson
We are going to want to use the dummy xendevicemodel_handle type in new stub functions in the CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 section. So we need to provide that definition, or (as applicable) include the appropriate header, earlier in the file. (Ideally the newer compatibility layers w

[Qemu-devel] [Bug 1721221] Re: PCI-E passthrough of Nvidia GTX GFX card to Win 10 guest fails with "kvm_set_phys_mem: error registering slot: Invalid argument"

2017-10-04 Thread Joe Clifford
More noise... OK, so I've tested the Windows 10 guest VM using the same criteria but eliminating PCI-E pass-through and using virtio-vga graphics instead, and the the guest boots up fine so perhaps my assumption is correct. Let me know if you need to see the memory I/O regions or dmesg of my host

[Qemu-devel] [PATCH 8/8] RFC configure: do_compiler: Dump some extra info under bash

2017-10-04 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if configu

[Qemu-devel] [PATCH 1/8] xen: link against xentoolcore

2017-10-04 Thread Ian Jackson
From: Anthony PERARD Xen libraries 4.10 will include a new xentoolcore library, without which xendevicemodel et al will not work. Signed-off-by: Ian Jackson --- configure | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fd7e3a5..6f691df 10

Re: [Qemu-devel] [PULL 44/50] scripts: let checkpatch.pl process an entire GIT branch

2017-10-04 Thread Alex Williamson
On Wed, 4 Oct 2017 16:11:07 +0200 Paolo Bonzini wrote: > On 04/10/2017 15:17, Alex Williamson wrote: > > Yes, it works with the new --patch option. I use stgit which does > > not add a filename extension to the patch name on export, nor have I > > ever known patch files to have any accepted stan

[Qemu-devel] [Bug 1721221] Re: PCI-E passthrough of Nvidia GTX GFX card to Win 10 guest fails with "kvm_set_phys_mem: error registering slot: Invalid argument"

2017-10-04 Thread Joe Clifford
Apologies, the title of this bug might be very misleading. I've made a huge assumption that PCI-E GFX card pass-through was triggering the bug, purely because a Debian Stretch guest VM on the same host, using the same build of QEMU, which uses virtio-vga for graphics and the same version of OVMF fi

Re: [Qemu-devel] [PATCH] s390x/sclp: mark sclp-cpu-hotplug as non-usercreatable

2017-10-04 Thread Thomas Huth
On 04.10.2017 17:46, Cornelia Huck wrote: > A TYPE_SCLP_CPU_HOTPLUG device for handling cpu hotplug events > is already created by the sclp event facility. Adding a second > TYPE_SCLP_CPU_HOTPLUG device via -device sclp-cpu-hotplug creates > an ambiguity in raise_irq_cpu_hotplug(), leading to a cra

[Qemu-devel] [PATCH 4/8] xen: destroy_hvm_domain: Move reason into a variable

2017-10-04 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 7b60ec6..83420cd 100644 --- a/

[Qemu-devel] [PATCH 5/8] xen: move xc_interface compatibility fallback further up the file

2017-10-04 Thread Ian Jackson
We are going to want to use the dummy xendevicemodel_handle type in new stub functions in the CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 section. So we need to provide that definition, or (as applicable) include the appropriate header, earlier in the file. (Ideally the newer compatibility layers w

[Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-10-04 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. Signed-off-by: Ian Jackson --- v2: Coding style fixes. --- os-posix.c | 31 +++ qemu-options.hx | 12

[Qemu-devel] [PATCH 1/8] xen: link against xentoolcore

2017-10-04 Thread Ian Jackson
From: Anthony PERARD Xen libraries 4.10 will include a new xentoolcore library, without which xendevicemodel et al will not work. Signed-off-by: Ian Jackson --- configure | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fd7e3a5..6f691df 10

Re: [Qemu-devel] [PATCH v4 1/2] virtio: introduce `query-virtio' QMP command

2017-10-04 Thread Eric Blake
On 10/04/2017 09:26 AM, Jan Dakinevich wrote: > +{ > +'struct': 'VirtioInfo', > +'data': { > +'feature-names': ['VirtioInfoBit'], Why is feature-names listed at two different nestings of the return value? >>> >>> These are different feature names. Fir

[Qemu-devel] [PATCH 8/8] RFC configure: do_compiler: Dump some extra info under bash

2017-10-04 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if configu

[Qemu-devel] [PATCH v2 0/7] xen: xen-domid-restrict improvements

2017-10-04 Thread Ian Jackson
I have been working on trying to get qemu, when running as a Xen device model, to _actually_ not have power equivalent to root. I think I have achieved this, with some limitations (which will be discussed in my series against xen.git. However, there are changes to qemu needed. In particular *

Re: [Qemu-devel] [PATCH v1 2/2] ide: support reporting of rotation rate

2017-10-04 Thread John Snow
On 10/04/2017 07:40 AM, Daniel P. Berrange wrote: > The Linux kernel will query the ATA IDENTITY DEVICE data, word 217 > to determine the rotations per minute of the disk. If this has > the value 1, it is taken to be an SSD and so Linux sets the > 'rotational' flag to 0 for the I/O queue and will

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-04 Thread Eric Blake
On 10/04/2017 05:39 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 3 + > tests/migration-test.c | 497 > + > 2 files changed, 500 insertions(+) > create mode 100644 tests/migration-test.c New file; sho

[Qemu-devel] [PATCH 3/8] xen: defer call to xen_restrict until after os_setup_post

2017-10-04 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so on

Re: [Qemu-devel] kvm_set_phys_mem: assertion failed

2017-10-04 Thread Laszlo Ersek
Hi, On 09/21/17 16:28, Auger Eric wrote: > Hi David, > On 20/09/2017 16:34, David Hildenbrand wrote: >> On 20.09.2017 16:31, Gerd Hoffmann wrote: >>> Hi, >>> Dropping from os section: >>> type="pflash">/usr/share/edk2.git/ovmf-x64/OVMF_CODE-pure- efi.fd >>> template="/us

[Qemu-devel] [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-04 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson --- v2: Add compatibility stu

Re: [Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl

2017-10-04 Thread Alex Williamson
On Wed, 4 Oct 2017 18:44:20 +0300 Vladimir Sementsov-Ogievskiy wrote: > Do not use '/r' modifier which was introduced in perl 5.14. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Fixes: 3e5875afc0f ("checkpatch: check trace-events code style") Tested-by: Alex Williamson Thanks > sc

[Qemu-devel] [PATCH] s390x/sclp: mark sclp-cpu-hotplug as non-usercreatable

2017-10-04 Thread Cornelia Huck
A TYPE_SCLP_CPU_HOTPLUG device for handling cpu hotplug events is already created by the sclp event facility. Adding a second TYPE_SCLP_CPU_HOTPLUG device via -device sclp-cpu-hotplug creates an ambiguity in raise_irq_cpu_hotplug(), leading to a crash once a cpu is hotplugged. To fix this, disallo

[Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-04 Thread Ian Jackson
And insist that it works. Drop individual use of xendevicemodel_restrict and xenforeignmemory_restrict. These are not actually effective in this version of qemu, because qemu has a large number of fds open onto various Xen control devices. The restriction arrangements are still not right, becaus

[Qemu-devel] [Bug 1721221] Re: PCI-E passthrough of Nvidia GTX GFX card to Win 10 guest fails with "kvm_set_phys_mem: error registering slot: Invalid argument"

2017-10-04 Thread Laszlo Ersek (Red Hat)
There's another bug report / discussion thread on qemu-devel about the same commit: 1505913885.24609.8.camel@redhat.com">http://mid.mail-archive.com/1505913885.24609.8.camel@redhat.com I'll add a note to that thread about this LP report too. -- You received this bug notification because you are

Re: [Qemu-devel] [PATCH] Revert: checkpatch: check trace-events code style

2017-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2017 17:59, Alex Williamson wrote: On Wed, 4 Oct 2017 12:59:04 +0300 Vladimir Sementsov-Ogievskiy wrote: 04.10.2017 01:00, Alex Williamson wrote: Commit c3e5875afc0f ("checkpatch: check trace-events code style") introduces a regression as reported: https://lists.gnu.org/archive/html/qe

Re: [Qemu-devel] [PATCH v1 2/2] ide: support reporting of rotation rate

2017-10-04 Thread Eric Blake
On 10/04/2017 06:40 AM, Daniel P. Berrange wrote: > The Linux kernel will query the ATA IDENTITY DEVICE data, word 217 > to determine the rotations per minute of the disk. If this has > the value 1, it is taken to be an SSD and so Linux sets the > 'rotational' flag to 0 for the I/O queue and will s

[Qemu-devel] [PATCH] checkpatch: fix incompatibility with old perl

2017-10-04 Thread Vladimir Sementsov-Ogievskiy
Do not use '/r' modifier which was introduced in perl 5.14. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3c0a28e644..0c41f1212f 100755 --- a/scripts/

Re: [Qemu-devel] [PATCH v1 1/2] scsi-disk: support reporting of rotation rate

2017-10-04 Thread Eric Blake
On 10/04/2017 06:40 AM, Daniel P. Berrange wrote: > The Linux kernel will query the SCSI "Block device characteristics" > VPD to determine the rotations per minute of the disk. If this has > the value 1, it is taken to be an SSD and so Linux sets the > 'rotational' flag to 0 for the I/O queue and w

[Qemu-devel] [PATCH v2 6/8] s390x: refactor error handling for HSCH handler

2017-10-04 Thread Halil Pasic
Simplify the error handling of the HSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 18 +- include/hw/s390x/css.h | 2 +- target/s390x/ioinst.c | 23

[Qemu-devel] [PATCH v2 7/8] s390x: refactor error handling for MSCH handler

2017-10-04 Thread Halil Pasic
Simplify the error handling of the MSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 18 +- include/hw/s390x/css.h | 2 +- target/s390x/ioinst.c | 23

Re: [Qemu-devel] [PATCH] hw/s390x/sclp: Mark the sclp device with user_creatable = false

2017-10-04 Thread Cornelia Huck
On Wed, 4 Oct 2017 17:18:57 +0200 Pierre Morel wrote: > On 04/10/2017 15:53, Thomas Huth wrote: > > The "sclp" device is just an internal device that can not be instantiated > > by the users. If they try to use it, they only get a simple error message: > > > > $ qemu-system-s390x -nographic -dev

[Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic

2017-10-04 Thread Halil Pasic
Some of ioinst the handlers look very much the same: they basically delegate the work to the appropriate css function (doing some always the same stuff before and after the call to the appropriate css function). Let us create a template and get rid of some code. Signed-off-by: Halil Pasic Suggest

[Qemu-devel] [PATCH v2 5/8] s390x: refactor error handling for CSCH handler

2017-10-04 Thread Halil Pasic
Simplify the error handling of the cSCH. Let the code detecting the condition tell (in a less ambiguous way) how it's to be handled. No changes in behavior. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 12 +++- include/hw/s390x/css.h | 2 +- target/s390x/ioinst.c | 14 -

[Qemu-devel] [PATCH v2 1/8] s390x/css: be more consistent if broken beyond repair

2017-10-04 Thread Halil Pasic
Calling do_subchannel_work with no function control flags set in SCSW is a programming error. Currently the handle this differently in do_subchannel_work_virtual and do_subchannel_work_passthrough. Let's be consistent and guard with a common assert against this programming error. Signed-off-by: Ha

  1   2   3   4   >