Re: [Qemu-devel] [PATCH 08/14] qlit: add QLIT_QNULL and QLIT_BOOL

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > As they are going to be used in the following patches. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 07/14] qlit: make qlit_equal_qobject() take const arguments

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 +- > qobject/qlit.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h > index 2e22d0f73c..8882016199 100644 > --

Re: [Qemu-devel] [PATCH 06/14] qlit: make qlit_equal_qobject return a bool

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Make it more obvious about the expected return values. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 2 +- > qobject/qlit.c | 18 +- > tests/check-qjson.c | 14 +++--- > 3 files changed, 17 insertions(+),

Re: [Qemu-devel] Why got no response of vnc?

2017-08-24 Thread Sam
I follow this: https://en.wikibooks.org/wiki/QEMU/QEMU_Hello_World:_Installing_QEMU_and_getting_it_up_and_running 2017-08-25 14:31 GMT+08:00 Sam : > Hi all, > > I'm starting vm using: > > kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 >> -cdrom CentOS-7-x86_64-DVD-1503-01.iso

Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-24 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Use qlit_ prefix. > > Let's spell it out: > > qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() > > By the way, not only is your name shorter, it's also more precise: > "compare" suggests -1, 0, +1 for less than, equal

Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Use qlit_ prefix. Let's spell it out: qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() By the way, not only is your name shorter, it's also more precise: "compare" suggests -1, 0, +1 for less than, equal and greater than, equal suggests non-zero f

[Qemu-devel] Why got no response of vnc?

2017-08-24 Thread Sam
Hi all, I'm starting vm using: kvm]$ sudo /usr/local/bin/qemu-system-x86_64 -m 256 -hda test.qcow2 -cdrom > CentOS-7-x86_64-DVD-1503-01.iso -boot d > VNC server running on '127.0.0.1:5900' then I start vnc client in another PC to connect 10.253.23.24:11800 and 10.253.23.24:5900, I got time out,

Re: [Qemu-devel] [PATCH qemu v4 2/3] vfio/spapr: Add a notifier for PPC64 HV/PR KVM about new group attached to LIOBN

2017-08-24 Thread David Gibson
On Thu, Jul 20, 2017 at 05:22:30PM +1000, Alexey Kardashevskiy wrote: > This implements a notification for a new IOMMU group attached to > sPAPR's logical IO bus (LIOBN) to enable in-kernel TCE acceleration. > > This extends the TYPE_SPAPR_IOMMU_MEMORY_REGION class with a get_fd() > callback which

Re: [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > And misc code style fix. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h > index f36bca4554..1e9696988a 100644 > --

Re: [Qemu-devel] [PATCH 03/14] qlit: use QLit prefix consistently

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Rename from LiteralQ to QLit. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

2017-08-24 Thread Markus Armbruster
Conflicts with Eduardo's "[PATCH v2] qapi: Fix error handling code on alternate conflict". Message-Id: <20170717180926.14924-1-ehabk...@redhat.com> Marc-André, could you have a look? You can rebase your fix on top of Eduardo's, or merge the two into one commit. Marc-André Lureau writes: > The

Re: [Qemu-devel] [PATCH 02/14] qlit: move qlit from check-qjson to qobject/

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Fix code style issues while at it, to please check-patch. It's spelled checkpatch. Can touch up on commit. > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 49 + > qobject/qlit.c | 89 +++

Re: [Qemu-devel] [PATCH 01/14] qdict: add qdict_put_null() helper

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > A step towards completeness. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [RFC v2 8/8] migration: add incoming mgmt lock

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 07:01:35PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Now at least migrate_incoming can be run in parallel. Let's provide a > > migration lock to protect it. > > > > Signed-off-by: Peter Xu > > --- > > migration/migration.c | 6 +

Re: [Qemu-devel] Make test

2017-08-24 Thread Thomas Huth
On 25.08.2017 00:16, Cleber Rosa wrote: > > On 08/24/2017 05:50 PM, Programmingkid wrote: >> >> Thank you for the patches. I will test them. I was wondering what is the >> point to having both 'make check' and 'make test'. It looks like everyone is >> using 'make check'. Maybe we are better off

Re: [Qemu-devel] [RFC v2 5/8] hmp: support "without_bql"

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 06:46:29PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Introducing new option "without_bql" for HMP commands. It works just > > like QMP "without-bql", but for HMP commands. > > > > Signed-off-by: Peter Xu > > It's going to be interes

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-24 Thread Peter Xu
On Thu, Aug 24, 2017 at 07:37:32AM +0800, Fam Zheng wrote: > On Wed, 08/23 18:44, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Introducing this new parameter for QMP commands in general to mark out > > > when the command does not need BQL. Normally QMP command exec

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 06:44:12PM +0100, Dr. David Alan Gilbert wrote: [...] > > +Most of the commands require the Big QEMU Lock (BQL) be held during > > +execution. However, there is a small subset of the commands that may > > +not really need BQL at all. To mark out this kind of commands, we

Re: [Qemu-devel] Structure / order of generated QAPI/QMP docs

2017-08-24 Thread Markus Armbruster
Markus Armbruster writes: > We've split sub-schemas off qapi-schema.json to enable proper > MAINTAINERS coverage, and also because the complete schema has become > rather large. > > The reference documentation generated with qapi2texi.py is in textual > schema order, with included sub-schemas ins

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:28:15PM +0200, BALATON Zoltan wrote: > On Thu, 24 Aug 2017, David Gibson wrote: > > On Wed, Aug 23, 2017 at 12:16:24PM +0200, BALATON Zoltan wrote: > > > On Wed, 23 Aug 2017, David Gibson wrote: > > > > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > >

Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries

2017-08-24 Thread Markus Armbruster
Eric Blake writes: > On 08/24/2017 02:13 PM, Markus Armbruster wrote: >> Cc: "Daniel P. Berrange" >> Cc: Alberto Garcia >> Cc: Dr. David Alan Gilbert >> Cc: Gerd Hoffmann >> Cc: Jason Wang >> Cc: Juan Quintela >> Cc: Marc-André Lureau >> Cc: Paolo Bonzini >> >> Much of the QAPI schema re

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 11:11:22AM -0700, Ram Pai wrote: > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: > > > LoPAPR says: > > > > > > “ibm,processor-storage-keys” > > > > > > property name indic

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-24 Thread Peter Xu
On Wed, Aug 23, 2017 at 06:35:35PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > using non-mux typed backend chardev. We only do this for monitors, so > > mux-typed chardevs are not suita

Re: [Qemu-devel] [PATCH for-2.11 4/6] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:49AM +0200, Igor Mammedov wrote: > previous patches cleaned up cpu model/alias naming which > allows to simplify cpu model/alias to cpu type lookup a bit > byt removing recurssion and dependency of ppc_cpu_class_by_name() / > ppc_cpu_class_by_alias() on each other. > B

Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:50AM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > target/ppc/translate_init.c | 27 +++ > 1 file changed, 11 insertions(+), 16 deletions(-) > > diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c > ind

Re: [Qemu-devel] [PATCH for-2.11 6/6] ppc: drop caching ObjectClass from PowerPCCPUAlias

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:51AM +0200, Igor Mammedov wrote: > Caching there practically doesn't give any benefits > and that at slow path druring querying supported CPU list. > But it introduces non conventional path of where from > comes used CPU type name (kvm_ppc_register_host_cpu_type). > >

[Qemu-devel] [Bug 1712818] Re: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes

2017-08-24 Thread meeho yuen
hi,eblake,the problem still exists on qemu 2.10_rc4,although the possibility is less than before. kvm: block/io.c:1543: bdrv_co_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed. 2017-08-25 11:08:18.963+: shutting down, reason=crashed -- You received this bug notification because you

[Qemu-devel] [PATCH qemu] pci: Initialize pci_dev->name before use

2017-08-24 Thread Alexey Kardashevskiy
This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of empry string. Signed-off-by: Alexey Kardashevskiy --- hw/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 258fbe51e2..852babe812 10

Re: [Qemu-devel] [QGA] Bug of qga?

2017-08-24 Thread Sam
Also I found: when I use `socat` to take a qga socket, then I use `socat` to communicate it will got error. But also SOMETIMES, I will not got error and will communicate OK. If one user take qga socket, another user should got error, is it? But why sometimes, the communicate is OK? 2017-08-25 10

Re: [Qemu-devel] A use-after-free in slirp

2017-08-24 Thread Philippe Mathieu-Daudé
Hi Samuel, On 08/24/2017 08:42 PM, Samuel Thibault wrote: Hello, Thanks for the reproducer you sent me offline. Here is a fix which makes a lot of sense and fixes the reproducer. Could you try it with your whole testcase? Could somebody also review the patch? Your patch looks correct. It

Re: [Qemu-devel] [PATCH for-2.11 2/6] ppc: make cpu_model translation to type consistent

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:47AM +0200, Igor Mammedov wrote: > PPC handles -cpu FOO rather incosistently, > i.e. it does case-insensitive matching of FOO to > a CPU type (see: ppc_cpu_compare_class_name) but > handles alias names as case-sensitive, as result: > > # qemu-system-ppc64 -M mac99 -c

Re: [Qemu-devel] [PATCH for-2.11 3/6] ppc: make cpu alias point only to real cpu models

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:48AM +0200, Igor Mammedov wrote: > alias pointing to another alias forces lookup code to > do recurrsive translation till real cpu model is reached. > > Drop this nonsence and make each alias point to cpu model > that has corresponding CPU type. It will allow to drop

Re: [Qemu-devel] [PATCH for-2.11 1/6] ppc: use macros to make cpu type name from string literal

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 10:21:46AM +0200, Igor Mammedov wrote: > Replace > "-" TYPE_POWERPC_CPU > when composing cpu type name from cpu model string literal > and the same pattern in format strings with > POWERPC_CPU_TYPE_SUFFIX and POWERPC_CPU_TYPE_NAME(model) > macroses like we do in x86. > >

[Qemu-devel] [QGA] Bug of qga?

2017-08-24 Thread Sam
Hi all, I'm using qga to send `route -n` and `ping` command to guest. But I found SOMETIMES, the second `ping` command's result is the same as `route -n` command. So I guess is there some cache mechanism of qga command result? So when I send the second command, and receive from qga socket, I rece

Re: [Qemu-devel] [PATCH QEMU v4] xen/pt: allow QEMU to request MSI unmasking at bind time

2017-08-24 Thread Stefano Stabellini
On Thu, 24 Aug 2017, Roger Pau Monne wrote: > When a MSI interrupt is bound to a guest using > xc_domain_update_msi_irq (XEN_DOMCTL_bind_pt_irq) the interrupt is > left masked by default. > > This causes problems with guests that first configure interrupts and > clean the per-entry MSIX table mask

[Qemu-devel] [Bug 1712818] Re: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes

2017-08-24 Thread meeho yuen
Thank you,I will try it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1712818 Title: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes Status in QEMU:

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-24 Thread John Snow
Sorry in advance for :words: ... On 08/23/2017 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: > 23.08.2017 11:59, Vladimir Sementsov-Ogievskiy wrote: >> 22.08.2017 22:07, John Snow wrote: >>> Well, we knew we'd want this sooner or later. I've got some pings >>> downstream over whether or not we sup

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 11:37:09PM +0200, BALATON Zoltan wrote: > On Thu, 24 Aug 2017, David Gibson wrote: > > On Wed, Aug 23, 2017 at 01:12:06PM +0200, BALATON Zoltan wrote: > > > On Wed, 23 Aug 2017, David Gibson wrote: > > > > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > >

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread David Gibson
On Thu, Aug 24, 2017 at 11:43:18PM +0200, BALATON Zoltan wrote: > On Thu, 24 Aug 2017, David Gibson wrote: > > On Wed, Aug 23, 2017 at 01:43:56PM +0200, François Revol wrote: > > > Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : > > > > > What's the connection with mips_malta? > > > > > > > > The

Re: [Qemu-devel] A use-after-free in slirp

2017-08-24 Thread Samuel Thibault
Hello, Thanks for the reproducer you sent me offline. Here is a fix which makes a lot of sense and fixes the reproducer. Could you try it with your whole testcase? Could somebody also review the patch? Samuel commit 1a3a763509fad895c907e6978ea034a5c19ee370 Author: Samuel Thibault Date: Fri

Re: [Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started

2017-08-24 Thread Marc-André Lureau
Hi On Thu, Aug 24, 2017 at 9:39 PM Dr. David Alan Gilbert (git) < dgilb...@redhat.com> wrote: > From: "Dr. David Alan Gilbert" > > Add a vu_queue_started method to complement vu_queue_enabled. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Marc-André Lureau > --- > contrib/libvh

Re: [Qemu-devel] [PATCH v6 04/10] qemu.py: Simplify QMP key-conversion

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > The QMP key conversion consist of '_'s to be replaced with '-'s, which > can easily be done by a single `str.replace` method which is faster and > does not require `string` module import. > > Signed-off-by: Lukáš Doktor > Reviewed-by: Eduardo Habkos

Re: [Qemu-devel] [PATCH v6 03/10] qemu.py: Use iteritems rather than keys()

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > Let's avoid creating an in-memory list of keys and query for each value > and use `iteritems` which is an iterator of key-value pairs. > > Signed-off-by: Lukáš Doktor > Reviewed-by: Eduardo Habkost > Reviewed-by: Philippe Mathieu-Daudé > --- > sc

Re: [Qemu-devel] [PATCH v6 02/10] qemu|qtest: Avoid dangerous arguments

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > The list object is mutable in python and potentially might modify other > object's arguments when used as default argument. Reproducer: > > >>> vm1 = QEMUMachine("qemu") > >>> vm2 = QEMUMachine("qemu") > >>> vm1._wrapper.append("foo") >

Re: [Qemu-devel] [PATCH v6 01/10] qemu.py: Pylint/style fixes

2017-08-24 Thread Cleber Rosa
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > No actual code changes, just several pylint/style fixes and docstring > clarifications. > > Signed-off-by: Lukáš Doktor > Reviewed-by: Stefan Hajnoczi > --- > scripts/qemu.py | 73 > +++-- > 1 f

Re: [Qemu-devel] Make test

2017-08-24 Thread Programmingkid
> On Aug 24, 2017, at 6:21 PM, Cleber Rosa wrote: > > > > On 08/24/2017 06:18 PM, Programmingkid wrote: >> After applying the patches I saw this error: >> >> $ make test >> make -C tests/tcg test >> CC test_path.o >> LINKtest_path >> ./test_path >> cc -m32 -nostdlib -Wall -O2 -g -f

Re: [Qemu-devel] Make test

2017-08-24 Thread Cleber Rosa
On 08/24/2017 06:18 PM, Programmingkid wrote: > After applying the patches I saw this error: > > $ make test > make -C tests/tcg test > CC test_path.o > LINKtest_path > ./test_path > cc -m32 -nostdlib -Wall -O2 -g -fno-strict-aliasing -static -o hello-i386 > hello-i386.c > hello-i

Re: [Qemu-devel] Make test

2017-08-24 Thread Programmingkid
> On Aug 24, 2017, at 4:41 PM, Cleber Rosa wrote: > > > > On 08/24/2017 03:10 PM, Programmingkid wrote: >> I think 'make test' is an abandoned testing option for QEMU so this report >> might be unimportant. Here is my results for running 'make test': >> >> $ make test >> make -C tests/tcg te

Re: [Qemu-devel] Make test

2017-08-24 Thread Cleber Rosa
On 08/24/2017 05:50 PM, Programmingkid wrote: > > Thank you for the patches. I will test them. I was wondering what is the > point to having both 'make check' and 'make test'. It looks like everyone is > using 'make check'. Maybe we are better off removing the 'make test' target. > I think t

Re: [Qemu-devel] [PATCH 10/15] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-24 Thread BALATON Zoltan
On Sun, 20 Aug 2017, Philippe Mathieu-Daudé wrote: Hi Zoltan, Hello, Thanks for the review and comments. On 08/20/2017 02:23 PM, BALATON Zoltan wrote: This is the PCIX controller found in newer 440 core SoCs e.g. the AMMC 460EX. The device tree refers to this as plb-pcix compared to the plb

Re: [Qemu-devel] Make test

2017-08-24 Thread Programmingkid
> On Aug 24, 2017, at 4:41 PM, Cleber Rosa wrote: > > > > On 08/24/2017 03:10 PM, Programmingkid wrote: >> I think 'make test' is an abandoned testing option for QEMU so this report >> might be unimportant. Here is my results for running 'make test': >> >> $ make test >> make -C tests/tcg te

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread BALATON Zoltan
On Thu, 24 Aug 2017, David Gibson wrote: On Wed, Aug 23, 2017 at 01:43:56PM +0200, François Revol wrote: Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : What's the connection with mips_malta? The board's firmware wants to see SPD EEPROMs of the connected memory while initialising the memory c

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-24 Thread BALATON Zoltan
On Thu, 24 Aug 2017, David Gibson wrote: On Wed, Aug 23, 2017 at 01:12:06PM +0200, BALATON Zoltan wrote: On Wed, 23 Aug 2017, David Gibson wrote: On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not

Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver

2017-08-24 Thread Manos Pitsidianakis
On Thu, Aug 24, 2017 at 07:43:08PM +0100, Stefan Hajnoczi wrote: On Tue, Aug 22, 2017 at 01:15:35PM +0300, Manos Pitsidianakis wrote: +_supported_fmt qcow2 What makes this test qcow2-specific? With additional filtering for IMGFMT it should be possible to run this on any image format. I thin

Re: [Qemu-devel] Make test

2017-08-24 Thread Cleber Rosa
On 08/24/2017 03:10 PM, Programmingkid wrote: > I think 'make test' is an abandoned testing option for QEMU so this report > might be unimportant. Here is my results for running 'make test': > > $ make test > make -C tests/tcg test > LINKtest_path > Undefined symbols for architecture x86_

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/8] boards.h: Define new flag ignore_memory_transaction_failures

2017-08-24 Thread Richard Henderson
On 22 August 2017 at 09:36, Peter Maydell wrote: > On 22 August 2017 at 04:45, Philippe Mathieu-Daudé wrote: >> If we are worried about being backward compatible, defaulting background >> region to unimp() won't throw any transaction error. > > As I said, it will, for the cases of device model di

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-24 Thread BALATON Zoltan
On Thu, 24 Aug 2017, David Gibson wrote: On Wed, Aug 23, 2017 at 12:16:24PM +0200, BALATON Zoltan wrote: On Wed, 23 Aug 2017, David Gibson wrote: On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: These registers are present in 440 SoCs (and maybe in others too) and U-Boot accesse

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-24 Thread Farhan Ali
On 08/24/2017 02:33 PM, Christian Borntraeger wrote: Just to understand the urgency. Is the problem happening with the BIOS that is shipped in the upstream git tree, or a self-built one? The bios image upstream works fine, but if someone tries to recompile the bios and use that, it breaks.

[Qemu-devel] [RFC v2 21/32] postcopy: postcopy_notify_shared_wake

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a hook to allow a client userfaultfd to be 'woken' when a page arrives, and a walker that calls that hook for relevant clients given a RAMBlock and offset. Signed-off-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 16 migration/pos

Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries

2017-08-24 Thread Eric Blake
On 08/24/2017 02:13 PM, Markus Armbruster wrote: > Cc: "Daniel P. Berrange" > Cc: Alberto Garcia > Cc: Dr. David Alan Gilbert > Cc: Gerd Hoffmann > Cc: Jason Wang > Cc: Juan Quintela > Cc: Marc-André Lureau > Cc: Paolo Bonzini > > Much of the QAPI schema really belongs to a subsystem, but

[Qemu-devel] [RFC v2 17/32] vhost+postcopy: Stash RAMBlock and offset

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Stash the RAMBlock and offset for later use looking up addresses. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 1 + hw/virtio/vhost-user.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a/hw/virtio/trace-

[Qemu-devel] [RFC v2 27/32] vhost+postcopy: Wire up POSTCOPY_END notify

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Wire up a call to VHOST_USER_POSTCOPY_END message to the vhost clients right before we ask the listener thread to shutdown. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 2 ++ hw/virtio/vhost-user.c | 30 ++ m

[Qemu-devel] [RFC v2 32/32] postcopy shared docs

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add some notes to the migration documentation for shared memory postcopy. Signed-off-by: Dr. David Alan Gilbert --- docs/devel/migration.txt | 39 +++ 1 file changed, 39 insertions(+) diff --git a/docs/devel/migration.txt b/do

[Qemu-devel] [RFC v2 11/32] vhub: Open userfaultfd

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Open a userfaultfd (on a postcopy_advise) and send it back in the reply to the qemu for it to monitor. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 26 +++--- contrib/libvhost-user/libvhost-user.h | 3 +++

[Qemu-devel] [RFC v2 22/32] vhost+postcopy: Add vhost waker

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Register a waker function in vhost-user code to be notified when pages arrive or requests to previously mapped pages get requested. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 3 +++ hw/virtio/vhost-user.c | 26 ++

[Qemu-devel] [RFC v2 31/32] vhost: Don't break merged regions on small remove/non-adds

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The previous patch merges hugepage regions with small gaps back into one; this patch stops some of the cases that split them up again. vhost_set_memory avoids adding small regions that are being dirty-monitored (typically VGA regions), but vhost_set_memory does rem

[Qemu-devel] [RFC v2 26/32] vhost: Add VHOST_USER_POSTCOPY_END message

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This message is sent just before the end of postcopy to get the client to stop using userfault since we wont respond to any more requests. It should close userfaultfd so that any other pages get mapped to the backing file automatically by the kernel, since at this

[Qemu-devel] [RFC v2 10/32] vhub: Support sending fds back to qemu

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow replies with fds (for postcopy) Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contri

[Qemu-devel] [RFC v2 20/32] postcopy: wake shared

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Send a 'wake' request on a userfaultfd for a shared process. The address in the clients address space is specified together with the RAMBlock it was resolved to. Signed-off-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 26 ++ m

[Qemu-devel] [RFC v2 30/32] vhost: Merge neighbouring hugepage regions where appropriate

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Where two regions are created with a gap such that when aligned to hugepage boundaries, the two regions overlap, merge them. I also add quite a few trace events to see what's going on. Note: This doesn't handle all the cases, but does handle the common case on a P

[Qemu-devel] [RFC v2 24/32] vub+postcopy: madvises

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Clear the area and turn off THP. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib

[Qemu-devel] [RFC v2 07/32] postcopy: Add notifier chain

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a notifier chain for postcopy with a 'reason' flag and an opportunity for a notifier member to return an error. Call it when enabling postcopy. This will initially used to enable devices to declare they're unable to postcopy and later to notify of devices of s

[Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We need a better way, but at the moment we need the address of the mappings sent back to qemu so it can interpret the messages on the userfaultfd it reads. Note: We don't ask for the default 'ack' reply since we've got our own. Signed-off-by: Dr. David Alan Gilber

[Qemu-devel] [RFC v2 29/32] vhost-user: Claim support for postcopy

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Tell QEMU we understand the protocol features needed for postcopy. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 33 + 1 file changed, 33 insertions(+) diff --git a/contrib/libvhost-user/libvhos

[Qemu-devel] [RFC v2 18/32] vhost+postcopy: Send requests to source for shared pages

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Send requests back to the source for shared page requests. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.h| 2 ++ migration/postcopy-ram.c | 31 --- migration/postcopy-ram.h | 3 +++ migration/trace-events | 2

[Qemu-devel] [RFC v2 14/32] vhost+postcopy: Transmit 'listen' to client

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Notify the vhost-user client on reception of the 'postcopy-listen' event from the source. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 21 + contrib/libvhost-user/libvhost-user.h | 2 ++ docs/interop/vhost

[Qemu-devel] [RFC v2 28/32] postcopy: Allow shared memory

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Now that we have the mechanisms in here, allow shared memory in a postcopy. Note that QEMU can't tell who all the users of shared regions are and thus can't tell whether all the users of the shared regions have appropriate support for postcopy. Those devices that

[Qemu-devel] [RFC v2 03/32] migrate: Update ram_block_discard_range for shared

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The choice of call to discard a block is getting more complicated for other cases. We use fallocate PUNCH_HOLE in any file cases; it works for both hugepage and for tmpfs. We use the DONTNEED for non-hugepage cases either where they're anonymous or where they're p

[Qemu-devel] [RFC v2 15/32] vhost+postcopy: Register new regions with the ufd

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When new regions are sent to the client using SET_MEM_TABLE, register them with the userfaultfd. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 32 1 file changed, 32 insertions(+) diff --git a/

[Qemu-devel] [RFC v2 13/32] vhost+postcopy: Register shared ufd with postcopy

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Register the UFD that comes in as the response to the 'advise' method with the postcopy code. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost-user.c | 21 - migration/postcopy-ram.h | 2 +- 2 files changed, 21 insertions(+), 2 del

[Qemu-devel] [RFC v2 25/32] vhost+postcopy: Lock around set_mem_table

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" **HACK - better solution needed ** We have the situation where: qemu bridge send set_mem_table map memory a) mark area with UFD send reply with ma

[Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a vu_queue_started method to complement vu_queue_enabled. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 6 ++ contrib/libvhost-user/libvhost-user.h | 9 + 2 files changed, 15 insertions(+) diff --git a/contrib/

[Qemu-devel] [RFC v2 09/32] vhost-user: Add 'VHOST_USER_POSTCOPY_ADVISE' message

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Wire up a notifier to send a VHOST_USER_POSTCOPY_ADVISE message on an incoming advise. Later patches will fill in the behaviour/contents of the message. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.c | 21 --- contrib

[Qemu-devel] [RFC v2 12/32] postcopy: Allow registering of fd handler

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow other userfaultfd's to be registered into the fault thread so that handlers for shared memory can get responses. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c| 3 + migration/migration.h| 2 + migration/postcopy-ram.c | 212 +++

[Qemu-devel] [RFC v2 23/32] vhost+postcopy: Call wakeups

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Cause the vhost-user client to be woken up whenever: a) We place a page in postcopy mode b) We get a fault and the page has already been received Signed-off-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 14 ++ migration/trace-events

[Qemu-devel] [RFC v2 08/32] postcopy: Add vhost-user flag for postcopy and check it

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a vhost feature flag for postcopy support, and use the postcopy notifier to check it before allowing postcopy. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.h | 1 + docs/interop/vhost-user.txt | 10 + hw/vir

Re: [Qemu-devel] [PATCH 02/16] qapi: Drop superfluous qapi_enum_parse() parameter max

2017-08-24 Thread Markus Armbruster
Eric Blake writes: > On 08/24/2017 01:35 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/24/2017 03:45 AM, Markus Armbruster wrote: The lookup tables have a sentinel, no need to make callers pass their size. Fun: the header has it in the wrong position. Good

[Qemu-devel] [RFC v2 19/32] vhost+postcopy: Resolve client address

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Resolve fault addresses read off the clients UFD into RAMBlock and offset, and call back to the postcopy code to ask for the page. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 3 +++ hw/virtio/vhost-user.c | 30 +

[Qemu-devel] [RFC v2 05/32] migration/ram: ramblock_recv_bitmap_test_byte_offset

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Utility for testing the map when you already know the offset in the RAMBlock. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 5 + migration/ram.h | 1 + 2 files changed, 6 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index affb20

[Qemu-devel] [PATCH v2 3/3] hostmem-file: Add "discard-data" option

2017-08-24 Thread Eduardo Habkost
The new option can be used to indicate that the file contents can be destroyed and don't need to be flushed to disk when QEMU exits or when the memory backend object is removed. Internally, it will trigger a madvise(MADV_REMOVE) call when the memory backend is removed. Signed-off-by: Eduardo Habk

[Qemu-devel] [PATCH v2 1/3] vl: Clean up user-creatable objects when exiting

2017-08-24 Thread Eduardo Habkost
Delete all user-creatable objects in /objects when exiting QEMU, so they can perform cleanup actions. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * (none) --- include/qom/object_interfaces.h | 8 qom/object_interfaces.c | 5 + vl.c| 1 +

[Qemu-devel] [RFC v2 06/32] postcopy: use UFFDIO_ZEROPAGE only when available

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use a flag on the RAMBlock to state whether it has the UFFDIO_ZEROPAGE capability, use it when it's available. This allows the use of postcopy on tmpfs as well as hugepage backed files. Signed-off-by: Dr. David Alan Gilbert --- exec.c| 15 +++

[Qemu-devel] [RFC v2 02/32] vhub: Only process received packets on started queues

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Only process received packets if the queue has been started. Signed-off-by: Dr. David Alan Gilbert --- tests/vhost-user-bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 1e5b5ca3da..324abee53d

[Qemu-devel] [PATCH v2 2/3] osdep: Define QEMU_MADV_REMOVE

2017-08-24 Thread Eduardo Habkost
Define QEMU_MADV_REMOVE, so we can use it with qemu_madvise(). Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * New patch added to series --- include/qemu/osdep.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 6855b94..e9fa217 1

[Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json

2017-08-24 Thread Markus Armbruster
Cc: Juan Quintela Cc: Dr. David Alan Gilbert Signed-off-by: Markus Armbruster --- MAINTAINERS |1 + Makefile|1 + qapi-schema.json| 1056 + qapi/common.json| 16 + qapi/event.json | 38 -- qapi/migration

[Qemu-devel] [RFC v2 04/32] qemu_ram_block_host_offset

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Utility to give the offset of a host pointer within a RAMBlock (assuming we already know it's in that RAMBlock) Signed-off-by: Dr. David Alan Gilbert --- exec.c| 10 ++ include/exec/cpu-common.h | 1 + 2 files changed, 11 insertions(+

[Qemu-devel] [RFC v2 00/32] postcopy+vhost-user/shared ram

2017-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This is a RFC/WIP series that enables postcopy migration with shared memory to a vhost-user process. It's based off current-head + Alexey's bitmap series It's tested with vhost-user-bridge and a dpdk (modified by Maxime that will get posted separately) - both

[Qemu-devel] [PATCH v2 0/3] hostmem-file: Add "discard-data" option

2017-08-24 Thread Eduardo Habkost
This series adds a new "discard-data" option to memory-backend-file. The new option will be useful if somebody is sharing RAM contents on a pre-existing file using share=on, but don't need data to be flushed to disk when QEMU exits. Internally, it will trigger a madvise(MADV_REMOVE) call when the

[Qemu-devel] [PATCH v2 08/16] qapi-schema: Collect UI stuff in qapi/ui.json

2017-08-24 Thread Markus Armbruster
UI stuff is remote desktop stuff (Spice, VNC) and input stuff (mouse, keyboard). Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster --- MAINTAINERS | 2 + Makefile | 3 +- qapi-schema.json | 784 +--- qapi/event.json | 175 -- qa

[Qemu-devel] [PATCH v2 07/16] qapi-schema: Collect net device stuff in qapi/net.json

2017-08-24 Thread Markus Armbruster
Cc: Jason Wang Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + Makefile | 1 + qapi-schema.json | 675 +--- qapi/event.json | 24 -- qapi/net.json| 706 +++ 5 files

  1   2   3   4   >