On 4/20/2017 1:40 PM, Peter Xu wrote:
On Thu, Apr 20, 2017 at 04:55:24AM +, Liu, Yi L wrote:
[...]
In my previous RFC patchset of fault event reporting, I registered
fault notifier when there is a VFIO group attached to VFIO container
and used the address space to check whether vIOMMU is a
On 04/19/2017 10:52 PM, Jan Kiszka wrote:
On 2017-04-19 16:33, Wang, Wei W wrote:
On 04/19/2017 07:21 PM, Jan Kiszka wrote:
On 2017-04-19 13:11, Wei Wang wrote:
On 04/19/2017 06:36 PM, Jan Kiszka wrote:
On 2017-04-19 12:02, Wei Wang wrote:
The design presented here intends to use only one BA
On 2017年04月20日 14:36, Zhang Chen wrote:
On 04/20/2017 02:20 PM, Hailiang Zhang wrote:
On 2017/4/20 12:32, Zhang Chen wrote:
When network traffic heavy, compare_pri_rs_finalize() and
compare_sec_rs_finalize() have a chance to confilct.
Both of them call colo_compare_connection() to compare p
On 2017年04月18日 10:20, Zhang Chen wrote:
In this patch we support packet that have tcp options field.
Add tcp options field check, If the packet have options
field we just skip it and compare tcp payload,
Avoid unnecessary checkpoint, optimize performance.
Signed-off-by: Zhang Chen
---
net/c
COLO-Proxy just focus on packet payload, So we skip vnet header.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index b3e933c..1941ad9 100644
--- a/net/colo-compare.c
+++ b/net/
Make colo-compare and filter-rewriter can parse vnet packet.
Signed-off-by: Zhang Chen
---
net/colo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/colo.c b/net/colo.c
index 180eaed..28ce7c8 100644
--- a/net/colo.c
+++ b/net/colo.c
@@ -43,11 +43,11 @@ int parse_pa
In this patch, we change the send packet format from
struct {int size; const uint8_t buf[];} to {int size; int vnet_hdr_len; const
uint8_t buf[];}.
make other module(like colo-compare) know how to parse net packet correctly.
Signed-off-by: Zhang Chen
---
net/filter-mirror.c | 25 +++
COLO-compare can get vnet header length from filter,
Add vnet_hdr_len to struct packet and output packet with
the vnet_hdr_len.
Signed-off-by: Zhang Chen
---
net/colo-compare.c| 39 ---
net/colo.c| 3 ++-
net/colo.h| 4 +++-
net/f
Because of net_socket_send() add vnet header length argument,
Avoid conflict with net_socket_send().
Signed-off-by: Zhang Chen
---
net/socket.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/socket.c b/net/socket.c
index fe3547b..1f1f3d2 100644
--- a/net/socket.c
+++ b/net/socket.
Address Jason Wang's comments add vnet header length to SocketReadState.
So we change net_fill_rstate() to read
struct {int size; int vnet_hdr_len; const uint8_t buf[];}.
Signed-off-by: Zhang Chen
---
include/net/net.h | 4 +++-
net/net.c | 24 ++--
2 files changed,
If user use -device virtio-net-pci, virtio-net driver will add a header
to raw net packet that colo-proxy can't handle it. COLO-proxy just
focus on the packet payload, so we skip the virtio-net header to compare
the sent packet that primary guest's to secondary guest's.
Zhang Chen (6):
net/filte
> -Original Message-
> From: Peter Xu [mailto:pet...@redhat.com]
> Sent: Thursday, April 20, 2017 1:40 PM
> To: Liu, Yi L
> Cc: Lan, Tianyu ; qemu-devel@nongnu.org; Michael S .
> Tsirkin ; Jason Wang ; Marcel
> Apfelbaum ; David Gibson ;
> Tian, Kevin
> Subject: Re: [Qemu-devel] [PATCH
On 04/20/2017 02:20 PM, Hailiang Zhang wrote:
On 2017/4/20 12:32, Zhang Chen wrote:
When network traffic heavy, compare_pri_rs_finalize() and
compare_sec_rs_finalize() have a chance to confilct.
Both of them call colo_compare_connection() to compare packet,
But during compare_pri_rs_finalize()
Hello ,in kvm_set_phys_mem,I am confused about the following codes:
delta = TARGET_PAGE_ALIGN(size) - size;
if (delta > size) {
return;
}
start_addr += delta;
size -= delta;
size &= TARGET_PAGE_MASK;
why start_addr need to add delta,and why size sub delta,in my own
opin
On 2017/4/20 12:32, Zhang Chen wrote:
When network traffic heavy, compare_pri_rs_finalize() and
compare_sec_rs_finalize() have a chance to confilct.
Both of them call colo_compare_connection() to compare packet,
But during compare_pri_rs_finalize() comparison, have secondary
packet come and call
On 04/14/2017 08:52 PM, Stefano Stabellini wrote:
On Fri, 14 Apr 2017, Juergen Gross wrote:
On 14/04/17 08:06, Oleksandr Andrushchenko wrote:
On 04/14/2017 03:12 AM, Stefano Stabellini wrote:
On Tue, 11 Apr 2017, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
For some use case
On 2017年04月20日 13:28, Peter Xu wrote:
On Thu, Apr 20, 2017 at 01:18:28PM +0800, Jason Wang wrote:
On 2017年04月18日 12:21, Peter Xu wrote:
On Tue, Apr 18, 2017 at 12:00:13PM +0800, Jason Wang wrote:
On 2017年04月18日 11:50, Peter Xu wrote:
On Tue, Apr 18, 2017 at 11:23:35AM +0800, Jason Wang wro
Hi All
Has anyone experienced any kernel panics with the Sparc64 in 2.9-rc4? I dont
seem to be able to run it right out of the box.
Ill appreciate any kind of help
Regards
-H
On 04/19/2017 11:24 PM, Stefan Hajnoczi wrote:
On Wed, Apr 19, 2017 at 11:42 AM, Wei Wang wrote:
On 04/19/2017 05:57 PM, Stefan Hajnoczi wrote:
On Wed, Apr 19, 2017 at 06:38:11AM +, Wang, Wei W wrote:
We made some design changes to the original vhost-pci design, and want to
open
a discuss
On Thu, Apr 20, 2017 at 04:55:24AM +, Liu, Yi L wrote:
[...]
> > > In my previous RFC patchset of fault event reporting, I registered
> > > fault notifier when there is a VFIO group attached to VFIO container
> > > and used the address space to check whether vIOMMU is added. The
> > > address
Hi,
> > You can have two floppy drives, but they are hooked to the same
>
> Yes, I'm aware.
>
> I'm just saying here "Spec-wise" because you can have two controllers,
> one at 0x3F0 and one at 0x370.
Oh, ok. Wasn't aware of this detail.
Can't remember to have ever seen a pc with more than t
On Thu, Apr 20, 2017 at 01:18:28PM +0800, Jason Wang wrote:
>
>
> On 2017年04月18日 12:21, Peter Xu wrote:
> >On Tue, Apr 18, 2017 at 12:00:13PM +0800, Jason Wang wrote:
> >>
> >>On 2017年04月18日 11:50, Peter Xu wrote:
> >>>On Tue, Apr 18, 2017 at 11:23:35AM +0800, Jason Wang wrote:
> On 2017年04月1
On 2017年04月18日 12:21, Peter Xu wrote:
On Tue, Apr 18, 2017 at 12:00:13PM +0800, Jason Wang wrote:
On 2017年04月18日 11:50, Peter Xu wrote:
On Tue, Apr 18, 2017 at 11:23:35AM +0800, Jason Wang wrote:
On 2017年04月17日 18:58, Peter Xu wrote:
[...]
+static void vtd_switch_address_space(VTDAddress
On 2017年04月18日 14:58, Hailiang Zhang wrote:
On 2017/4/18 11:55, Jason Wang wrote:
On 2017年04月17日 19:04, Hailiang Zhang wrote:
Hi Jason,
On 2017/4/14 14:38, Jason Wang wrote:
On 2017年04月14日 14:22, Hailiang Zhang wrote:
Hi Jason,
On 2017/4/14 13:57, Jason Wang wrote:
On 2017年02月22日 17:31,
On Wed, Apr 19, 2017 at 09:50:01AM -0300, Eduardo Habkost wrote:
> On Wed, Apr 19, 2017 at 09:41:42AM +0100, Peter Maydell wrote:
> > On 18 April 2017 at 23:17, Eduardo Habkost wrote:
> > > pci_bus_new*() and pci_register_bus() work only when the 'parent'
> > > argument is a PCI_HOST_BRIDGE object
> -Original Message-
> From: Peter Xu [mailto:pet...@redhat.com]
> Sent: Thursday, April 20, 2017 11:04 AM
> To: Lan, Tianyu
> Cc: Liu, Yi L ; qemu-devel@nongnu.org; Michael S . Tsirkin
> ; Jason Wang ; Marcel Apfelbaum
> ; David Gibson ; Tian, Kevin
>
> Subject: Re: [Qemu-devel] [PATCH v
Hi folks,
I have a question regarding the algorithm used to select rx queue of
the VM in the case of multiqueue virtio-net on KVM.
Given a 4-tuple, how can we calculate the index of the receive queue
that virtio-net is going pick for that flow? From some of the email
threads in some of the relev
When network traffic heavy, compare_pri_rs_finalize() and
compare_sec_rs_finalize() have a chance to confilct.
Both of them call colo_compare_connection() to compare packet,
But during compare_pri_rs_finalize() comparison, have secondary
packet come and call compare_sec_rs_finalize(), that packet w
On Wed, Apr 19, 2017 at 10:26 PM, Eduardo Habkost wrote:
> On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote:
>> On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote:
>> > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote:
>> >> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo H
From: Lidong Chen
When use old style option like -o backing_file, img_convert
continue run when bs_n > 1, this patch fix this bug.
Signed-off-by: Lidong Chen
---
qemu-img.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-img.c b/qemu-img.c
index b220cf7..c673aef 100644
--- a/qe
Signed-off-by: Fam Zheng
---
block/sheepdog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index fb9203e..7e889ee 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -608,6 +608,7 @@ static int connect_to_sdog(BDRVSheepdogState *s, Error
**errp)
On Tue, 04/18 08:27, Eric Blake wrote:
> On 03/13/2017 09:39 PM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng
> > ---
> > qemu-io.c | 28 +---
> > 1 file changed, 21 insertions(+), 7 deletions(-)
> >
> > @@ -108,6 +112,7 @@ static void open_help(void)
> > " -r, -- open
On Tue, 04/18 08:20, Eric Blake wrote:
> bool, please. (Just because existing code is lousy with using an int
> for a bool doesn't mean we should perpetuate it)
OK, will fix.
>
>
> > @@ -3033,6 +3085,9 @@ static int img_rebase(int argc, char **argv)
> > case OPTION_IMAGE_OPTS:
> >
On Wed, Apr 19, 2017 at 07:13:47AM +, Liu, Yi L wrote:
> Peter,
>
> Besides the gPA->hPA mapping, pt mode enabling requires some sanity check on
> s->pt_supported. See comments inline.
>
> > -Original Message-
> > From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.o
On Wed, Apr 19, 2017 at 03:27:52PM +0800, Lan Tianyu wrote:
> Hi All:
> Sorry for later response.
> On 2017年04月18日 17:04, Liu, Yi L wrote:
> >> -Original Message-
> >> From: Peter Xu [mailto:pet...@redhat.com]
> >> Sent: Tuesday, April 18, 2017 3:27 PM
> >> To: Liu, Yi L
> >> Cc: qem
On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote:
> On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote:
> > On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote:
> >> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost
> >> wrote:
> >> > On Wed, Apr 19, 2017 at 04:16:53PM
On Thu, Apr 20, 2017 at 11:44:17AM +1000, Sam Bobroff wrote:
> On a fully emulated Power8 system, user space is currently unable to
> read from USPRG3 (SPR number 0x103) because it receives an illegal
> instruction exception.
>
> However the ISA indicates that it should have read access (to the
>
On a fully emulated Power8 system, user space is currently unable to
read from USPRG3 (SPR number 0x103) because it receives an illegal
instruction exception.
However the ISA indicates that it should have read access (to the
content of SPR 0x113, similar to some other registers with user space
rea
On 04/19/2017 05:36 PM, Alistair Francis wrote:
> On Wed, Apr 19, 2017 at 3:22 PM, Eric Blake wrote:
>> Libvirt would like to be able to distinguish between a SHUTDOWN
>> event triggered solely by guest request and one triggered by a
>> SIGTERM or other action on the host. qemu_kill_report() is
>
The sections for e500, mpc8544ds, and ppce500 all list Scott Wood as a
co-maintainer, but I'm getting bounce emails for scottw...@freescale.com
as an unknown address. What is the appropriate tweak needed to the
MAINTAINERS file?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On Wed, Apr 19, 2017 at 06:48:22PM +0200, Bernhard Kaindl wrote:
> This patch registers mfspr 259 for Book3S and e500 family cores
> following this research:
>
> mfspr 259 provides read-only mapped user access to SPRG3(SPR 275) according
> to:
>
> - PowerISA 2.02, Book III (documents implementat
On Wed, Apr 19, 2017 at 9:27 AM, Stefan Hajnoczi wrote:
> On Mon, Apr 03, 2017 at 08:48:08PM -0700, Ashish Mittal wrote:
>> Source code for the qnio library that this code loads can be downloaded from:
>> https://github.com/VeritasHyperScale/libqnio.git
>>
>> Sample command line using JSON syntax:
Mirror calculates job len from current I/O progress:
s->common.len = s->common.offset +
(cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE;
The final "len" of a failed mirror job in iotests 109 depends on the
subtle timing of the completion of read and write issued in the fir
On Wed, 04/19 19:13, Kevin Wolf wrote:
> Am 19.04.2017 um 11:17 hat Fam Zheng geschrieben:
> > Mirror calculates job len from current I/O progress:
> >
> > s->common.len = s->common.offset +
> > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE;
> >
> > The final "len" of a
On Wed, 04/19 18:38, Paolo Bonzini wrote:
>
>
> On 19/04/2017 11:17, Fam Zheng wrote:
> > Mirror calculates job len from current I/O progress:
> >
> > s->common.len = s->common.offset +
> > (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE;
> >
> > The final "len" of a fai
On Wed, 04/19 15:13, Ashijeet Acharya wrote:
> > In the second iteration, remaining is always 0 because of "remaining -=
> > n_bytes". What's the point of the while loop?
>
>
> I need the while loop in case if I truncate the bytes according to the L2
> table margins[scroll up to handle alloc(
On Wed, 04/19 15:21, Ashijeet Acharya wrote:
> On Wed, Apr 19, 2017 at 18:27 Fam Zheng wrote:
>
> > On Sat, 04/01 20:14, Ashijeet Acharya wrote:
> > > Rename the existing get_cluster_offset() function to
> > > vmdk_get_cluster_offset() and have it make use of the new
> > > get_cluster_table() to
On Wed, Apr 19, 2017 at 11:02:21AM +0200, Jan Kiszka wrote:
> On 2017-04-19 10:45, Peter Maydell wrote:
> > On 19 April 2017 at 05:37, Jan Kiszka wrote:
> >> On 2017-04-19 05:48, Constantin Petra wrote:
> >>> So from some reason, under QEMU something is not in place, but what can
> >>> that be? It
On 04/19/2017 06:15 AM, Gerd Hoffmann wrote:
> Hi,
>
>>> There is -global, which is actually used by libvirt to configure
>>> built-in floppy devices. But as the name suggests it sets properties
>>> globally, i.e. for all instances. Which works in this specific use
>>> case, as there can be
On 04/07/2017 07:34 AM, Vladimir Sementsov-Ogievskiy wrote:
> Do not do extra call to _get_block_status()
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
>
> Also, I'm not sure about last line:
> s->status = s->target_has_backing ? BLK_BACKING_FILE : BLK_DATA;
>
> (which is equal to old
On Wed, 19 Apr 2017, Paul Durrant wrote:
> > -Original Message-
> > From: Stefano Stabellini [mailto:sstabell...@kernel.org]
> > Sent: 18 April 2017 18:41
> > To: Paul Durrant
> > Cc: 'Stefano Stabellini' ; qemu-devel@nongnu.org;
> > Anthony Perard ; Wei Liu
> > ; jgr...@suse.com; julien.g
On Wed, Apr 19, 2017 at 3:22 PM, Eric Blake wrote:
> Libvirt would like to be able to distinguish between a SHUTDOWN
> event triggered solely by guest request and one triggered by a
> SIGTERM or other action on the host. qemu_kill_report() is
> already able to tell whether a shutdown was triggere
Libvirt would like to be able to distinguish between a SHUTDOWN
event triggered solely by guest request and one triggered by a
SIGTERM or other action on the host. qemu_kill_report() is
already able to tell whether a shutdown was triggered by a host
signal (but NOT by a host UI event, such as clic
Hi Juan,
On 04/19/2017 05:59 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela
I think you missed Dave's Reviewed-by (he sent April 7)
"Reviewed-by: Dr. David Alan Gilbert "
--
Improve comment
Fix typo
^ remove?
---
migration/ram.c | 14 +++---
1 file changed, 7 insertio
On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost wrote:
> On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote:
>> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote:
>> > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote:
>> >> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Ha
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20170419205923.8808-1-quint...@redhat.com
Subject: [Qemu-devel] [PATCH 00/59] RAMState + qdev
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $
Hi
I messed up previous submission and sent the wrong patch.
- This verios is a rebase on top of the ramstate series
- Fixed the problem with postcopy
Important bit is this one:
-pds->start_list[pds->cur_entry] = (start - pds->offset) * tp_size;
+pds->start_list[pds->cur_entry] = start
I need to move qdev_unplug to qdev-monitor in the following patch, and
it needs access to this variable.
Signed-off-by: Juan Quintela
Reviewed-by: Eric Blake
Reviewed-by: zhanghailiang
---
hw/core/qdev.c | 2 +-
include/hw/qdev-core.h | 1 +
2 files changed, 2 insertions(+), 1 deletion
We have disabled memory hotplug, so we don't need to handle
migration_bitamp there.
Signed-off-by: Juan Quintela
Reviewed-by: Eric Blake
Reviewed-by: zhanghailiang
---
exec.c | 1 -
include/exec/ram_addr.h | 2 --
migration/ram.c | 34
On Wed, Apr 19, 2017 at 05:25:23PM -0400, Pranith Kumar wrote:
> On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote:
> > On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote:
> >> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost
> >> wrote:
> >> > On Wed, Apr 19, 2017 at 04:00:49PM
This removes the needto pass also the absolute offset.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 67 -
1 file changed, 28 insertions(+), 39 deletions(-)
diff --git a/migration/ram.c b/migration
On 04/19/2017 05:12 PM, Eric Blake wrote:
> On 04/19/2017 03:32 PM, John Snow wrote:
>
>>> @@ -279,9 +280,9 @@ static int mig_save_device_bulk(QEMUFile *f,
>>> BlkMigDevState *bmds)
>>> /* Skip unallocated sectors; intentionally treats failure as
>>> * an allocated sector */
Signed-off-by: Juan Quintela
--
Improve comment
Fix typo
Signed-off-by: Juan Quintela
---
migration/ram.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 52ab14b..5b2045d 100644
--- a/migration/ram.c
+++ b/migration/ra
Both the ram bitmap and the unsent bitmap are split by RAMBlock.
Signed-off-by: Juan Quintela
---
include/exec/ram_addr.h | 13 ++-
include/migration/postcopy-ram.h | 3 -
migration/postcopy-ram.c | 5 +-
migration/ram.c | 215 +++---
We use an unsigned long for the page number. Notice that our bitmaps
already got that for the index, so we have that limit.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
--
rename page to page_abs everywhere.
fix trace types for pages
Signed-off-by: Juan Quintela
---
mig
It is not used by linux-user, otherwise I need to to create one stub
for migration_is_idle() on following patch.
Signed-off-by: Juan Quintela
Reviewed-by: Eric Blake
Reviewed-by: zhanghailiang
Reviewed-by: Markus Armbruster
---
hw/core/qdev.c | 34 --
qdev-moni
We were setting it far away of when we changed it. Now everything is
done inside save_page_header. Once there, reorganize code to pass
RAMState. We also set CONTINUE flag in a single place.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/
Until we have reviewed what can/can't be hotplugged during migration,
disable it. We can enable it later for the things that we know that
work. For instance, memory hotplug during postcopy doesn't work
currently.
Signed-off-by: Juan Quintela
Reviewed-by: zhanghailiang
--
- Fix typo. Thanks
Only user don't have a MigrationState handly.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
include/migration/migration.h | 2 +-
migration/migration.c | 8 +++-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/include/migration/migration.h b/inc
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 3 +--
migration/postcopy-ram.c | 6 ++
migration/ram.c | 9 +++--
migration/savevm.c| 3 +--
4 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/include/migr
Signed-off-by: Juan Quintela
Reviewed-by: zhanghailiang
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
---
hw/core/qdev.c | 4 ++--
include/hw/qdev-core.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 1e7fb33..
We are moving everything to work on pages, not addresses.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 51 ++-
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/migration/ram.c b/migration/ra
From: Chao Fan
The number of dirty pages is output in 'pages' in the command
'info migrate', so add page-size to calculate the number of dirty
pages in bytes.
Signed-off-by: Chao Fan
Signed-off-by: Li Zhijian
Reviewed-by: Eric Blake
Signed-off-by: Juan Quintela
---
hmp.c | 3
We always use it as pages anyways.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
exec.c | 6 +++---
include/exec/ram_addr.h | 2 +-
migration/ram.c | 11 +--
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/exec.c b/exec.c
It was used as a size in all cases except one.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
exec.c | 4 ++--
include/sysemu/sysemu.h | 2 +-
migration/migration.c| 4 ++--
migration/postcopy-ram.c | 8
migration/savevm.c | 8
We receive the file from save_live operations and we don't use it
until 3 or 4 levels of calls down.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 84 +
1 file changed, 37 insertions(+), 47 deletion
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index f972882..2af8080 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1451,7 +1451,7 @@ vo
Remove it from callers and callees.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 289d7eb..fe01
We can calculate its value, so we don't create a variable for it.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
--
After Peter and Dave review, I dropped the variable and just inlined
the condition.
Fix typo
Signed-off-by: Juan Quintela
---
migration/ram.c | 12 -
We need to call for the migrate_get_current() in more that half of the
uses, so call that inside.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
include/migration/migration.h | 2 +-
migration/migration.c | 6 --
migration/ram.c
On Wed, Apr 19, 2017 at 4:57 PM, Eduardo Habkost wrote:
> On Wed, Apr 19, 2017 at 04:16:53PM -0400, Pranith Kumar wrote:
>> On Wed, Apr 19, 2017 at 4:13 PM, Eduardo Habkost wrote:
>> > On Wed, Apr 19, 2017 at 04:00:49PM -0400, Pranith Kumar wrote:
>> >> On Wed, Apr 19, 2017 at 3:54 PM, Pranith Ku
Treat it like the rest of ram stats counters. Export its value the
same way. As an added bonus, no more MigrationState used in
migration_bitmap_sync();
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
--
Again, dave was the one reviewing it
Signed-off-
This are the last postcopy fields still at MigrationState. Once there
Move MigrationSrcPageRequest to ram.c and remove MigrationState
parameters where appropiate.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 17 +---
migration/migration.c
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index b9f415c..62b44cf 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -165,6 +165,8
It can be recalculated from dirty_pages_rate.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
--
Dave was the one that reviewed it O:-)
Signed-off-by: Juan Quintela
---
include/migration/migration.h | 1 -
migration/migration.c | 6 +++---
mig
Just unfold it. Move ram_bytes_remaining() with the rest of exported
functions.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/migration/ram.c b
This is a ram field that was inside MigrationState. Move it to
RAMState and make it the same that the other ram stats.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 2 +-
migration/migration.c | 3 +--
migration/ram.c | 6 +-
3
On Wed, Apr 19, 2017 at 09:41:19PM +0300, Marcel Apfelbaum wrote:
> On 04/19/2017 03:05 PM, Cornelia Huck wrote:
> > On Tue, 18 Apr 2017 22:42:07 -0300
> > Eduardo Habkost wrote:
> >
> > > On Wed, Apr 19, 2017 at 10:29:26AM +1000, David Gibson wrote:
> > > > On Tue, Apr 18, 2017 at 07:17:21PM -03
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 35 +--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index f6ae17f..7fbaa52 100644
--- a/migration/ra
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
migration/ram.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 88392e4..71f8ef3 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -183,6 +183
It was on MigrationState when it is only used inside ram.c for
postcopy. Problem is that we need to access it without being able to
pass it RAMState directly.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 2 --
migration/migration.c | 1 -
migra
On 04/19/2017 03:32 PM, John Snow wrote:
>> @@ -279,9 +280,9 @@ static int mig_save_device_bulk(QEMUFile *f,
>> BlkMigDevState *bmds)
>> /* Skip unallocated sectors; intentionally treats failure as
>> * an allocated sector */
>> while (cur_sector < total_sectors &&
>>
Once there, rename the type to be shorter.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 86 +++--
1 file changed, 47 insertions(+), 39 deletions(-)
diff --git a/migration/ram.c
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index cf6681c..b70db68 100644
--- a/migration/ram.c
+++ b/migration/ram.c
And then init only things that are not zero by default.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
in
We change the meaning of start to be the offset from the beggining of
the block.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
include/exec/ram_addr.h | 2 ++
migration/ram.c | 8
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/exec
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index b70db68..09f9eff 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 3e500ae..4dc7869 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -172,6 +172,8 @@ struct
Once there, remove the now unused AccountingInfo struct and var.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/migration/ram.c b/migration/ram
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 6 ++
migration/migration.c | 5 ++---
migration/ram.c | 13 +
3 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/include/migration/migration.h b/include/m
1 - 100 of 324 matches
Mail list logo
