On Tue, Feb 07, 2017 at 04:28:02PM +0800, Peter Xu wrote:
> This is v7 of vt-d vfio enablement series.
>
> v7:
> - for the two traces patches: Change subjects. Remove vtd_err() and
> vtd_err_nonzero_rsvd() tracers, instead using standalone trace for
> each of the places. Don't remove any DPRIN
On Tue, 28 Feb 2017 08:58:55 +0300
Michael Tokarev wrote:
> Greg, can you please send a separate pull request
> just for the symlink attack issue, so it can be
> easily picked up by downstreams if needed?
>
It makes sense indeed. I'll do that.
Cheers.
--
Greg
> Thanks,
>
> /mjt
pgppe5PCM
From: Thomas Huth
The "or-irq" device needs to be wired up in source code, there is no
way the user can make any real use of this device with the "-device"
parameter or the "device_add" monitor command yet.
Signed-off-by: Thomas Huth
Reviewed-by: Markus Armbruster
Reviewed-by: Alistair Francis
From: Peter Maydell
Don't truncate the multiplication and do a 64 bit one instead
because the result is stored in a 64 bit variable.
This fixes a similar coverity warning to commits 237a8650d640 and
4382fa655498, in a similar way, and is the final third of the fix for
coverity CID 1167561 (hopef
From: Peter Maydell
In float64_to_uint64_round_to_zero() a typo meant that we were
taking the uint64_t return value from float64_to_uint64() and
putting it into an int64_t variable before returning it as
uint64_t again. Use uint64_t instead of pointlessly casting it
back and forth to int64_t.
Si
From: Philippe Mathieu-Daudé
The register_read() and register_write() functions expect a bitmask argument.
To avoid duplicated code, a new inlined function register_enabled_mask() is
introduced.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Signed-off-by: Michael Tokarev
From: Thomas Huth
The "qemu,register" device needs to be wired up in source code, there
is no way the user can make any real use of this device with the
"-device" parameter or the "device_add" monitor command yet.
Signed-off-by: Thomas Huth
Reviewed-by: Markus Armbruster
Reviewed-by: Alistair
From: Vincenzo Maffione
In the vhost-user example, a chardev with id chr0 is referenced by the
vhost-user net backend, but the id is not specified in the chardev option.
Signed-off-by: Vincenzo Maffione
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
qemu-options.hx | 2 +-
From: Thomas Huth
The 32-bit TCG bug has been fixed a while ago, so we can enable
this test for sparc64 now, too. Unfortunately, OpenBIOS does not
work with the sun4v machine anymore (it needs to catch up with the
improved emulation), so we can only enable this test for the sun4u
machine right no
From: Fam Zheng
Reported by cppcheck.
Signed-off-by: Fam Zheng
Signed-off-by: Michael Tokarev
---
hw/net/cadence_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index e99d454..d4de8ad 100644
--- a/hw/net/cadence_gem.c
+++ b
On 02/28/2017 03:00 AM, David Gibson wrote:
> On Mon, Feb 27, 2017 at 03:29:09PM +0100, Cédric Le Goater wrote:
>> commit 5b17c7207938 ("xics: XICS should not be a SysBusDevice")
>> changed the nature of the XICS object to be a descendent of
>> TYPE_DEVICE. By doing so, the object is not on a bus a
From: Marc-André Lureau
It's still time to wish happy new year!
The Year of the Rooster will begin on January 28, 2017!
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Michael Tokarev
---
include/qemu-common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
From: "Franklin \\\"Snaipe\\\" Mathieu"
The current implementation of the mincore(2) syscall sets errno to
EFAULT when the region identified by the first two parameters is
invalid.
This goes against the man page specification, where mincore(2) should
only fail with EFAULT when the third paramete
From: Peter Maydell
Our defacto coding style strongly prefers /* */ style comments
over the single-line // style, and checkpatch enforces this,
but we don't actually document this. Mention it in CODING_STYLE.
Suggested-by: Thomas Huth
Signed-off-by: Peter Maydell
Reviewed-by: Markus Armbruster
From: John Snow
trivial: initialize the dirty buffer with a random-ish byte.
Stops valgrind from whining about uninitialized buffers.
Signed-off-by: John Snow
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Michael Tokarev
---
tests/ide-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
This is yet another trivial patches pull request.
Please consider applying/pulling.
The following changes since commit 8f2d7c341184a95d05476ea3c45dbae2b9ddbe51:
Merge remote-tracking branch
'remotes/berrange/tags/pull-qcrypto-2017-02-27-1' into staging (2017-02-27
15:33:21 +)
are availab
From: Igor Pavlikevich
TCO timer does not actually stop
Signed-off-by: Igor Pavlikevich
Signed-off-by: Michael Tokarev
---
hw/acpi/tco.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
index 8ce7daf..b4adac8 100644
--- a/hw/acpi/tco.c
+++ b/hw/acpi/tco.c
@@ -
From: Stefan Weil
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
target/s390x/cpu_models.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 5b66d33..2a894ee 100644
--- a/target/s390x/cpu_models.c
+++
On 02/28/2017 01:47 PM, Jason Wang wrote:
On 2017年02月28日 13:18, Zhang Chen wrote:
Add offset args for colo_packet_compare_common, optimize
colo_packet_compare_icmp() and colo_packet_compare_udp()
just compare the IP payload. Before compare all tcp packet,
we compare tcp checksum firstly, thi
16.02.2017 11:58, Franklin Snaipe Mathieu wrote:
> From: "Franklin \"Snaipe\" Mathieu"
>
> The current implementation of the mincore(2) syscall sets errno to
> EFAULT when the region identified by the first two parameters is
> invalid.
>
> This goes against the man page specification, where minc
Greg, can you please send a separate pull request
just for the symlink attack issue, so it can be
easily picked up by downstreams if needed?
Thanks,
/mjt
A check was introduced in 5ea2fc84da1bffce749c9d0848f5336def2818bb which
causes fork() and vfork() to fail if TARGET_SIGCHLD != SIGCHLD.
Signed-off-by: Tim Hentenaar
---
linux-user/syscall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user
On 2017年02月28日 13:18, Zhang Chen wrote:
Add offset args for colo_packet_compare_common, optimize
colo_packet_compare_icmp() and colo_packet_compare_udp()
just compare the IP payload. Before compare all tcp packet,
we compare tcp checksum firstly, this function can get
better performance.
Signe
In mttcg, calling pause_all_vcpus() during execution from the
generated TBs causes a deadlock if some vCPU is waiting for exclusive
execution in start_exclusive(). Fix this by using the aync_safe_*
framework instead of pausing vcpus for patching instructions.
CC: Paolo Bonzini
CC: Peter Maydell
Rename colo_packet_compare() to colo_packet_compare_common() that
make tcp_compare udp_compare icmp_compare reuse this function.
Remove minimum packet size check in icmp_compare, because we have
check this in parse_packet_early().
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 18 +++
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 61fcdf2..6b38723 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -275,9 +275,13 @@ static int colo_pac
Add offset args for colo_packet_compare_common, optimize
colo_packet_compare_icmp() and colo_packet_compare_udp()
just compare the IP payload. Before compare all tcp packet,
we compare tcp checksum firstly, this function can get
better performance.
Signed-off-by: Zhang Chen
---
net/colo-compare.
This series we will Optimize the code and fix some bug.
Patch1: Rename colo_packet_compare() and remove duplicate check in compare icmp.
Patch2: Optimize compare_common and increase compare performance.
Patch3: Fix debug info always print bug.
Zhang Chen (3):
COLO-compare: Rename compare functi
Jose Ricardo Ziviani writes:
> Signed-off-by: Jose Ricardo Ziviani
> ---
> risugen_ppc64.pm | 40 +---
> 1 file changed, 29 insertions(+), 11 deletions(-)
>
> diff --git a/risugen_ppc64.pm b/risugen_ppc64.pm
> index cb75300..28b6792 100644
> --- a/risugen_ppc
On 2017年02月28日 11:54, zhanghailiang wrote:
Hi,
Patch 1 fixes a double free bug.
Patch 2 is an optimization for filter-rewriter.
Please review, thanks.
zhanghailiang (2):
net/colo: fix memory double free error
filter-rewriter: skip net_checksum_calculate() while offset = 0
net/colo.
From: John Snow
int64_t is in all likelihood the actual scalar type we want.
Yep, really.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1219541
Signed-off-by: John Snow
Reviewed-by: Jeff Cody
Signed-off-by: Jeff Cody
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
The missing colons make the iscsi part of the documentation not render
quite as nicely, so add those in.
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 5f82
The following changes since commit 8f2d7c341184a95d05476ea3c45dbae2b9ddbe51:
Merge remote-tracking branch
'remotes/berrange/tags/pull-qcrypto-2017-02-27-1' into staging (2017-02-27
15:33:21 +)
are available in the git repository at:
https://github.com/codyprime/qemu-kvm-jtc.git tags/bl
On Mon, Feb 27, 2017 at 11:29:07PM -0500, Jeff Cody wrote:
> The missing colons make the iscsi part of the documentation not render
> quite as nicely, so add those in.
>
> Signed-off-by: Jeff Cody
> ---
> qapi/block-core.json | 18 +-
> 1 file changed, 9 insertions(+), 9 deletion
The missing colons make the iscsi part of the documentation not render
quite as nicely, so add those in.
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 5f82
Signed-off-by: Mike Nawrocki
I've rebased my branch on master and regenerated the patch.
I've run the patch through checkstyle.pl and it reported no issues, whitespace
or otherwise. I suspect that Outlook was messing with my formatting, so let's
give git send-email a go. Please let me know if
This adds support for three additional options that may be specified
by QAPI in blockdev-add:
server: host, port
auth method: either 'cephx' or 'none'
The "server" and "auth-supported" QAPI parameters are arrays. To conform
with the rados API, the array items are join as a single string
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 5f82d35..f152953 100644
--- a/qapi/block-core.json
+++ b/qapi/block-c
Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename.
This simplifies a lot of the parsing as well, as we can treat everything
a bit simpler since nonexistent options are simply NULL pointers instead
of empty strings.
An important item to note:
Ceph has many extra option values that can
This patch is prep work for parsing options for .bdrv_parse_filename,
and using QDict options.
The function qemu_rbd_next_tok() searched for various key/value pairs,
and copied them into buffers. This will soon be an unnecessary extra
step, so we will now return found strings by reference only, a
This adds all the currently supported runtime opts, which
are the options as parsed from the filename. All of these
options are explicitly checked for during during runtime,
with an exception to the "keyvalue-pairs" option.
This option contains all the key/value pairs that the QEMU rbd
driver mer
This series adds blockdev-add for rbd.
Changes from v2:
Patch 2: Updated commit message, and documented the runtime opts
(Thanks Eric)
Patch 3: Fixed commit type, added "FIXME" in ugly string concat spot
(Thanks Eric)
Patch 4: Fixed all the nits - deleted lines, spaces. Kep
The 'primary_list' and 'secondary_list' members of struct Connection
is not allocated through dynamically g_queue_new(), but we free it by using
g_queue_free(), which will lead to a double-free bug.
Reviewed-by: Zhang Chen
Signed-off-by: zhanghailiang
---
net/colo.c | 4 ++--
1 file changed, 2
On Mon, Feb 27, 2017 at 04:47:54PM -0600, Eric Blake wrote:
> On 02/27/2017 12:58 PM, Jeff Cody wrote:
> > This adds support for two additional options that may be specified
> > by QAPI in blockdev-add:
> >
> > mon_host: servername and port
> > auth_supported: either 'cephx' or 'none'
>
>
Hi,
Patch 1 fixes a double free bug.
Patch 2 is an optimization for filter-rewriter.
Please review, thanks.
zhanghailiang (2):
net/colo: fix memory double free error
filter-rewriter: skip net_checksum_calculate() while offset = 0
net/colo.c| 4 ++--
net/filter-rewriter.c | 17
While the offset of packets's sequence for primary side and
secondary side is zero, it is unnecessary to call net_checksum_calculate()
to recalculate the checksume value of packets.
Signed-off-by: zhanghailiang
---
net/filter-rewriter.c | 17 +++--
1 file changed, 11 insertions(+), 6
On Mon, Feb 27, 2017 at 03:29:07PM +0100, Cédric Le Goater wrote:
>
> Hello,
>
> The goal behind this series is to simplify the XICS interface by
> moving back in the machine the way the ICS and ICP objects interact
> together. It's up to the machine to implement this "fabric" logic by
> providi
On Tue, Feb 28, 2017 at 01:25:17PM +1100, Suraj Jitindar Singh wrote:
> On Tue, 2017-02-28 at 11:28 +1100, David Gibson wrote:
> > s/HTP/HPT/ in subject line.
> >
> >
> > On Thu, Feb 23, 2017 at 05:00:01PM +1100, Sam Bobroff wrote:
> > >
> > > If QEMU is using KVM, and KVM is capable of running
On 02/28/2017 11:22 AM, Jason Wang wrote:
On 2017年02月25日 11:43, Zhang Chen wrote:
Sorry, This patch has been renamed.
please ignore this patch.
Thanks
Zhang Chen
Want to repost to just withdraw this series (patch 2 does not apply)?
I have repost this patch, and will send V2 about t
On 2017年02月25日 11:43, Zhang Chen wrote:
Sorry, This patch has been renamed.
please ignore this patch.
Thanks
Zhang Chen
Want to repost to just withdraw this series (patch 2 does not apply)?
Thanks
On 2017年02月27日 18:29, Hailiang Zhang wrote:
On 2017/2/27 17:05, Jason Wang wrote:
On 2017年02月27日 14:53, Hailiang Zhang wrote:
I think the issue is that your code can not differ A from B.
We have a parameter 'fin_ack_seq' recording the sequence of
'FIN=1,ACK=1,seq=w,ack=u+1' and if the ac
On Mon, Feb 27, 2017 at 03:29:09PM +0100, Cédric Le Goater wrote:
> commit 5b17c7207938 ("xics: XICS should not be a SysBusDevice")
> changed the nature of the XICS object to be a descendent of
> TYPE_DEVICE. By doing so, the object is not on a bus and its reset
> handler is not called anymore. The
On Tue, 2017-02-28 at 11:12 +1100, David Gibson wrote:
> On Thu, Feb 23, 2017 at 04:59:59PM +1100, Sam Bobroff wrote:
> >
> > Use the new ioctl, KVM_PPC_GET_RMMU_INFO, to fetch radix MMU
> > information from KVM and present the page encodings in the device
> > tree
> > under ibm,processor-radix-AP
On Tue, 2017-02-28 at 11:28 +1100, David Gibson wrote:
> s/HTP/HPT/ in subject line.
>
>
> On Thu, Feb 23, 2017 at 05:00:01PM +1100, Sam Bobroff wrote:
> >
> > If QEMU is using KVM, and KVM is capable of running in radix mode,
> > guests can be run in real-mode without allocating a HPT (because
From: "Michael S. Tsirkin"
0. What happens now (PCIE AER only)
Fatal errors cause a link reset.
Non fatal errors don't.
All errors stop the VM eventually, but not immediately
because it's detected and reported asynchronously.
Interrupts are forwarded as usual.
Correctable errors
On Fri, Feb 24, 2017 at 06:47:03PM +0200, Michael S. Tsirkin wrote:
> On Thu, Feb 23, 2017 at 04:59:57PM +1100, Sam Bobroff wrote:
> > Currently, running update-linux-headers.sh will produce a patch that
> > deletes virtio_mmio.h, which is still needed. This happens because
> > virtio_mmio.h is in
Hi,
On 2017/2/27 23:37, Christian Pinto wrote:
Hello Hailiang,
are there any updates on this patch series? Are you planning to release
a new version?
No, userfaultfd still does not support write-protect for KVM.
You can see the newest discussion about it here:
https://lists.gnu.org/archive/h
On Fri, Jan 27, 2017 at 9:06 AM, Peter Maydell wrote:
> On 26 January 2017 at 05:50, Thomas Huth wrote:
>> I think there is no real use case yet. But this fix is 1) simpler than
>> doing an error_report() + exit() here, and 2) maybe the vision of
>> constructing machines on the fly with QEMU will
On 02/28/2017 12:16 AM, Michael S. Tsirkin wrote:
> On Mon, Feb 27, 2017 at 03:28:43PM +0800, Cao jin wrote:
>> Subject: Re: [PATCH] vfio pci: kernel support of error recovery only for non
>> fatal error
>
> Don't make the subject so long. This is why I had
> [PATCH v3] vfio error recovery
On Wed, Feb 22, 2017 at 11:56:53AM +0100, Greg Kurz wrote:
> From: Greg Kurz
>
> Since commit 1d2d974244c6 "spapr_pci: enumerate and add PCI device tree", QEMU
> populates the PCI device tree in the opposite order compared to SLOF.
>
> Before 1d2d974244c6:
>
> Populating /pci@8002000
>
On Wed, Feb 01, 2017 at 09:43:57PM +0100, Laurent Vivier wrote:
> Le 31/01/2017 à 23:05, Jose Ricardo Ziviani a écrit :
> > A segfault is noticed when an emulated program uses any of ucontext
> > regs fields. Risu detected this issue in the following operation when
> > handling a signal:
> > ucon
On 2017/2/28 6:52, Stefano Stabellini wrote:
On Mon, 27 Feb 2017, Eric Blake wrote:
On 02/27/2017 04:31 PM, Stefano Stabellini wrote:
Eric, are you OK with this series going upstream? If so, do you want me
to send the pull request for it or are you going to handle it?
Both patches have my R-b
On 28/02/17 11:41, David Gibson wrote:
> On Mon, Feb 27, 2017 at 12:52:44PM +0800, Yongji Xie wrote:
>> At the moment ram device's memory regions are DEVICE_NATIVE_ENDIAN. It's
>> incorrect. This memory region is backed by a MMIO area in host, so the
>> uint64_t data that MemoryRegionOps read from/
Alpha has a weak memory ordering and issues all of the required barriers.
Signed-off-by: Richard Henderson
---
configure | 1 +
target/alpha/cpu.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/configure b/configure
index df58e91..6c21975 100755
--- a/configure
+++ b/configure
On 25/02/17 21:40, Greg Kurz wrote:
> On Sat, 25 Feb 2017 20:39:18 +1100
> Alexey Kardashevskiy wrote:
>
>> On 22/02/17 21:56, Greg Kurz wrote:
>>> From: Greg Kurz
>>>
>>> Since commit 1d2d974244c6 "spapr_pci: enumerate and add PCI device tree",
>>> QEMU
>>> populates the PCI device tree in the
On Thu, Feb 23, 2017 at 05:00:03PM +1100, Sam Bobroff wrote:
> In the next patch, spapr_fixup_cpu_dt() will need to call
> spapr_populate_pa_features() so move it's definition up without making
> any other changes.
s/it's/its/
>
> Signed-off-by: Sam Bobroff
> ---
> hw/ppc/spapr.c | 86
> +
On Wed, Feb 08, 2017 at 08:39:36PM +, Nawrocki, Michael wrote:
> This patch extends support for the `dump-guest-memory` command to the 32-bit
> PowerPC architecture. It relies on the assumption that a 64-bit guest will
> not dump a 32-bit core file (and vice versa); if this assumption is inva
Thanks to Alex for the heroics getting the patch set in.
This is a tiny follow-up to enable it for Alpha.
r~
The following changes since commit 8f2d7c341184a95d05476ea3c45dbae2b9ddbe51:
Merge remote-tracking branch
'remotes/berrange/tags/pull-qcrypto-2017-02-27-1' into staging (2017-02-27
On Mon, Feb 27, 2017 at 12:52:44PM +0800, Yongji Xie wrote:
> At the moment ram device's memory regions are DEVICE_NATIVE_ENDIAN. It's
> incorrect. This memory region is backed by a MMIO area in host, so the
> uint64_t data that MemoryRegionOps read from/write to this area should be
> host-endian r
s/HTP/HPT/ in subject line.
On Thu, Feb 23, 2017 at 05:00:01PM +1100, Sam Bobroff wrote:
> If QEMU is using KVM, and KVM is capable of running in radix mode,
> guests can be run in real-mode without allocating a HPT (because KVM
> will use a minimal RPT). So in this case, we avoid creating the HP
On Thu, Feb 23, 2017 at 05:00:00PM +1100, Sam Bobroff wrote:
> Query and cache the value of two new KVM capabilities that indicate
> KVM's support for new radix and hash modes of the MMU.
>
> Signed-off-by: Sam Bobroff
Reviewed-by: David Gibson
> ---
> v2:
>
> * cap_mmu_hash renamed to cap_mm
Peter,
I have some issues with this pull request. Please don't apply it, I'll respin a
new one.
Thanks.
On Mon, 27 Feb 2017 23:59:50 +0100
Greg Kurz wrote:
> The following changes since commit 8f2d7c341184a95d05476ea3c45dbae2b9ddbe51:
>
> Merge remote-tracking branch
> 'remotes/berrange/ta
On Mon, 27 Feb 2017 16:00:25 -0800 (PST)
no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
Hmm... I don't understand how this is related to this pull request... :-\
> Type: series
> Subject: [Qemu-devel] [PULL 00/31] 9p patches
On 02/27/2017 07:53 PM, Miroslav Benes wrote:
Linux arch/s390/kernel/head(64).S uses lpp instruction if it is
available in facilities list provided by stfl/stfle instruction. This is
the case of newer z/System generations and their qemu definition.
Signed-off-by: Miroslav Benes
---
v2
- remove
On Thu, Feb 23, 2017 at 04:59:59PM +1100, Sam Bobroff wrote:
> Use the new ioctl, KVM_PPC_GET_RMMU_INFO, to fetch radix MMU
> information from KVM and present the page encodings in the device tree
> under ibm,processor-radix-AP-encodings. This provides page size
> information to the guest which is
On Thu, Feb 23, 2017 at 05:00:05PM +1100, Sam Bobroff wrote:
> For a little while around 4.9, Linux kernels that saw the radix bit in
> ibm,pa-features would attempt to set up the MMU as if they were a
> hypervisor, even if they were a guest, which would cause them to
> crash.
>
> Work around this
On Mon, 27 Feb 2017 17:28:33 -0600
Eric Blake wrote:
> On 02/26/2017 04:42 PM, Greg Kurz wrote:
> > When using the passthrough security mode, symbolic links created by the
> > guest are actual symbolic links on the host file system.
> >
>
> >
> > diff --git a/hw/9pfs/9p-util.c b/hw/9pfs/9p-u
On Mon, 27 Feb 2017 17:37:56 -0600
Eric Blake wrote:
> On 02/27/2017 04:59 PM, Greg Kurz wrote:
> > When using the passthrough security mode, symbolic links created by the
> > guest are actual symbolic links on the host file system.
> >
>
> Hmm, I just barely started reviewing the series, and
On 02/25/2017 10:05 PM, Laurent Vivier wrote:
From: Michael Karcher
do_rt_sigreturn uses an uninitialised local variable instead of fetching
the old signal mask directly from the signal frame when restoring the mask,
so the signal mask is undefined after do_rt_sigreturn. As the signal
frame dat
On 02/25/2017 10:05 PM, Laurent Vivier wrote:
Use cpu_m68k_get_ccr()/cpu_m68k_set_ccr() to setup and restore correctly
the value of SR in the ucontext structure
Signed-off-by: Laurent Vivier
---
linux-user/signal.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Richa
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Subject: [Qemu-devel] [PULL 00/31] 9p patches 2017-02-27 for 2.9 soft freeze
Message-id: 1488236421-30983-1-git-send-email-gr...@kaod.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be in
On Mon, Feb 27, 2017 at 10:27:53AM +0530, Nikunj A Dadhania wrote:
> This series contains implentation of CA32 and OV32 bits added to the
> ISA 3.0. Various fixed-point arithmetic instructions are updated to take
> care of the newer flags.
>
> Finally the last patch adds new instruction mcrxrx,
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1488236421-30983-1-git-send-email-gr...@kaod.org
Type: series
Subject: [Qemu-devel] [PULL 00/31] 9p patches 2017-02-27 for 2.9 soft freeze
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
On 02/27/2017 04:59 PM, Greg Kurz wrote:
> When using the passthrough security mode, symbolic links created by the
> guest are actual symbolic links on the host file system.
>
Hmm, I just barely started reviewing the series, and see a pull request.
At this point, anything I point out can probably
On 02/26/2017 04:42 PM, Greg Kurz wrote:
> When using the passthrough security mode, symbolic links created by the
> guest are actual symbolic links on the host file system.
>
>
> diff --git a/hw/9pfs/9p-util.c b/hw/9pfs/9p-util.c
> new file mode 100644
> index ..62fd7a76212a
> --- /
On 02/27/2017 07:27 AM, Max Reitz wrote:
> On 25.02.2017 18:07, Vladimir Sementsov-Ogievskiy wrote:
>> Add bitmap extension as specified in docs/specs/qcow2.txt.
>> For now, just mirror extension header into Qcow2 state and check
>> constraints. Also, calculate refcounts for qcow2 bitmaps, to not
On 02/27/2017 04:56 PM, Jeff Cody wrote:
>>> static BlockDriver bdrv_rbd = {
>
>>> -.instance_size = sizeof(BDRVRBDState),
>>> -.bdrv_needs_filename = true,
>>> -.bdrv_file_open = qemu_rbd_open,
>>> -.bdrv_close = qemu_rbd_close,
>>> -.bdrv_create= qe
The local_mknod() callback is vulnerable to symlink attacks because it
calls:
(1) mknod() which follows symbolic links for all path elements but the
rightmost one
(2) local_set_xattr()->setxattr() which follows symbolic links for all
path elements
(3) local_set_mapped_file_attr() which cal
The local_mkdir() callback is vulnerable to symlink attacks because it
calls:
(1) mkdir() which follows symbolic links for all path elements but the
rightmost one
(2) local_set_xattr()->setxattr() which follows symbolic links for all
path elements
(3) local_set_mapped_file_attr() which cal
The local_link() callback is vulnerable to symlink attacks because it calls:
(1) link() which follows symbolic links for all path elements but the
rightmost one
(2) local_create_mapped_attr_dir()->mkdir() which follows symbolic links
for all path elements but the rightmost one
This patch
The local_open2() callback is vulnerable to symlink attacks because it
calls:
(1) open() which follows symbolic links for all path elements but the
rightmost one
(2) local_set_xattr()->setxattr() which follows symbolic links for all
path elements
(3) local_set_mapped_file_attr() which call
On Mon, Feb 27, 2017 at 04:47:54PM -0600, Eric Blake wrote:
> On 02/27/2017 12:58 PM, Jeff Cody wrote:
> > This adds support for two additional options that may be specified
> > by QAPI in blockdev-add:
> >
> > mon_host: servername and port
> > auth_supported: either 'cephx' or 'none'
>
>
The local_chmod() callback is vulnerable to symlink attacks because it
calls:
(1) chmod() which follows symbolic links for all path elements
(2) local_set_xattr()->setxattr() which follows symbolic links for all
path elements
(3) local_set_mapped_file_attr() which calls in turn local_fopen() a
The local_open() and local_opendir() callbacks are vulnerable to symlink
attacks because they call:
(1) open(O_NOFOLLOW) which follows symbolic links in all path elements but
the rightmost one
(2) opendir() which follows symbolic links in all path elements
This patch converts both callbacks t
Now that the all callbacks have been converted to use "at" syscalls, we
can drop this code.
Signed-off-by: Greg Kurz
Reviewed-by: Stefan Hajnoczi
---
hw/9pfs/9p-local.c | 198 -
1 file changed, 198 deletions(-)
diff --git a/hw/9pfs/9p-local.c
The local_symlink() callback is vulnerable to symlink attacks because it
calls:
(1) symlink() which follows symbolic links for all path elements but the
rightmost one
(2) open(O_NOFOLLOW) which follows symbolic links for all path elements but
the rightmost one
(3) local_set_xattr()->setxat
The local_chown() callback is vulnerable to symlink attacks because it
calls:
(1) lchown() which follows symbolic links for all path elements but the
rightmost one
(2) local_set_xattr()->setxattr() which follows symbolic links for all
path elements
(3) local_set_mapped_file_attr() which ca
The local_rename() callback is vulnerable to symlink attacks because it
uses rename() which follows symbolic links in all path elements but the
rightmost one.
This patch simply transforms local_rename() into a wrapper around
local_renameat() which is symlink-attack safe.
This partly fixes CVE-201
The local_renameat() callback is currently a wrapper around local_rename()
which is vulnerable to symlink attacks.
This patch rewrites local_renameat() to have its own implementation, based
on local_opendir_nofollow() and renameat().
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz
Rev
The local_readlink() callback is vulnerable to symlink attacks because it
calls:
(1) open(O_NOFOLLOW) which follows symbolic links for all path elements but
the rightmost one
(2) readlink() which follows symbolic links for all path elements but the
rightmost one
This patch converts local_
1 - 100 of 599 matches
Mail list logo
