Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1488236421-30983-1-git-send-email-gr...@kaod.org
Type: series
Subject: [Qemu-devel] [PULL 00/31] 9p patches 2017-02-27 for 2.9 soft freeze
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update]
patchew/1488145424-14974-1-git-send-email-arm...@redhat.com ->
patchew/1488145424-14974-1-git-send-email-arm...@redhat.com
* [new tag] patchew/1488236421-30983-1-git-send-email-gr...@kaod.org
-> patchew/1488236421-30983-1-git-send-email-gr...@kaod.org
- [tag update] patchew/cover.1488220970.git.jc...@redhat.com ->
patchew/cover.1488220970.git.jc...@redhat.com
Switched to a new branch 'test'
f9b5a13 9pfs: local: drop unused code
cf1b63c 9pfs: local: open2: don't follow symlinks
9641242 9pfs: local: mkdir: don't follow symlinks
c3d9755 9pfs: local: mknod: don't follow symlinks
b0d698e 9pfs: local: symlink: don't follow symlinks
39fb819 9pfs: local: chown: don't follow symlinks
7462d9b 9pfs: local: chmod: don't follow symlinks
1e81f57 9pfs: local: link: don't follow symlinks
c24ccea 9pfs: local: improve error handling in link op
209a38b 9pfs: local: rename: use renameat
380a282 9pfs: local: renameat: don't follow symlinks
ba0f22c 9pfs: local: lstat: don't follow symlinks
4a0220b 9pfs: local: readlink: don't follow symlinks
a7c6dfc 9pfs: local: truncate: don't follow symlinks
9f617aa 9pfs: local: statfs: don't follow symlinks
990635a 9pfs: local: utimensat: don't follow symlinks
4244a9a 9pfs: local: remove: don't follow symlinks
152b2c9 9pfs: local: unlinkat: don't follow symlinks
3c5a97f 9pfs: local: lremovexattr: don't follow symlinks
24bdcad 9pfs: local: lsetxattr: don't follow symlinks
3d2628d 9pfs: local: llistxattr: don't follow symlinks
64eb4cf 9pfs: local: lgetxattr: don't follow symlinks
c9bebb7 9pfs: local: open/opendir: don't follow symlinks
05e374b 9pfs: local: keep a file descriptor on the shared folder
b6f4c75 9pfs: introduce relative_openat_nofollow() helper
68e34e0 9pfs: remove side-effects in local_open() and local_opendir()
19ee4dc 9pfs: remove side-effects in local_init()
e68cedb 9pfs: local: move xattr security ops to 9p-xattr.c
7bc1cc1 throttle: factor out duplicate code
17d2a01 fsdev: add IO throttle support to fsdev devices
563e39a 9pfs: fix v9fs_lock error case
=== OUTPUT BEGIN ===
Checking PATCH 1/31: 9pfs: fix v9fs_lock error case...
Checking PATCH 2/31: fsdev: add IO throttle support to fsdev devices...
Checking PATCH 3/31: throttle: factor out duplicate code...
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#235: FILE: include/qemu/throttle-options.h:13:
+#define THROTTLE_OPTS \
+ { \
+ .name = "throttling.iops-total",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "limit total I/O operations per second",\
+ },{ \
+ .name = "throttling.iops-read",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "limit read operations per second",\
+ },{ \
+ .name = "throttling.iops-write",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "limit write operations per second",\
+ },{ \
+ .name = "throttling.bps-total",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "limit total bytes per second",\
+ },{ \
+ .name = "throttling.bps-read",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "limit read bytes per second",\
+ },{ \
+ .name = "throttling.bps-write",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "limit write bytes per second",\
+ },{ \
+ .name = "throttling.iops-total-max",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "I/O operations burst",\
+ },{ \
+ .name = "throttling.iops-read-max",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "I/O operations read burst",\
+ },{ \
+ .name = "throttling.iops-write-max",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "I/O operations write burst",\
+ },{ \
+ .name = "throttling.bps-total-max",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "total bytes burst",\
+ },{ \
+ .name = "throttling.bps-read-max",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "total bytes read burst",\
+ },{ \
+ .name = "throttling.bps-write-max",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "total bytes write burst",\
+ },{ \
+ .name = "throttling.iops-total-max-length",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "length of the iops-total-max burst period, in seconds",\
+ },{ \
+ .name = "throttling.iops-read-max-length",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "length of the iops-read-max burst period, in seconds",\
+ },{ \
+ .name = "throttling.iops-write-max-length",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "length of the iops-write-max burst period, in seconds",\
+ },{ \
+ .name = "throttling.bps-total-max-length",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "length of the bps-total-max burst period, in seconds",\
+ },{ \
+ .name = "throttling.bps-read-max-length",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "length of the bps-read-max burst period, in seconds",\
+ },{ \
+ .name = "throttling.bps-write-max-length",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "length of the bps-write-max burst period, in seconds",\
+ },{ \
+ .name = "throttling.iops-size",\
+ .type = QEMU_OPT_NUMBER,\
+ .help = "when limiting by iops max size of an I/O in bytes",\
+ }
total: 1 errors, 0 warnings, 280 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/31: 9pfs: local: move xattr security ops to 9p-xattr.c...
Checking PATCH 5/31: 9pfs: remove side-effects in local_init()...
Checking PATCH 6/31: 9pfs: remove side-effects in local_open() and
local_opendir()...
Checking PATCH 7/31: 9pfs: introduce relative_openat_nofollow() helper...
Checking PATCH 8/31: 9pfs: local: keep a file descriptor on the shared folder...
Checking PATCH 9/31: 9pfs: local: open/opendir: don't follow symlinks...
Checking PATCH 10/31: 9pfs: local: lgetxattr: don't follow symlinks...
Checking PATCH 11/31: 9pfs: local: llistxattr: don't follow symlinks...
Checking PATCH 12/31: 9pfs: local: lsetxattr: don't follow symlinks...
Checking PATCH 13/31: 9pfs: local: lremovexattr: don't follow symlinks...
Checking PATCH 14/31: 9pfs: local: unlinkat: don't follow symlinks...
Checking PATCH 15/31: 9pfs: local: remove: don't follow symlinks...
Checking PATCH 16/31: 9pfs: local: utimensat: don't follow symlinks...
Checking PATCH 17/31: 9pfs: local: statfs: don't follow symlinks...
Checking PATCH 18/31: 9pfs: local: truncate: don't follow symlinks...
Checking PATCH 19/31: 9pfs: local: readlink: don't follow symlinks...
Checking PATCH 20/31: 9pfs: local: lstat: don't follow symlinks...
Checking PATCH 21/31: 9pfs: local: renameat: don't follow symlinks...
Checking PATCH 22/31: 9pfs: local: rename: use renameat...
Checking PATCH 23/31: 9pfs: local: improve error handling in link op...
Checking PATCH 24/31: 9pfs: local: link: don't follow symlinks...
Checking PATCH 25/31: 9pfs: local: chmod: don't follow symlinks...
Checking PATCH 26/31: 9pfs: local: chown: don't follow symlinks...
Checking PATCH 27/31: 9pfs: local: symlink: don't follow symlinks...
Checking PATCH 28/31: 9pfs: local: mknod: don't follow symlinks...
Checking PATCH 29/31: 9pfs: local: mkdir: don't follow symlinks...
Checking PATCH 30/31: 9pfs: local: open2: don't follow symlinks...
Checking PATCH 31/31: 9pfs: local: drop unused code...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
