[Qemu-devel] [PATCH V9 2/2] Add a new qmp command to do checkpoint, query xen replication status

We can call this qmp command to do checkpoint outside of qemu. Xen colo will need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- migration/colo.c | 23 +++ qapi-schema.json | 49 + 2 files changed, 72

[Qemu-devel] [PATCH V9 1/2] Add a new qmp command to start/stop replication

We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang Reviewed-by: Eric Blake Reviewed-by: Stefano Stabellini Reviewed-by: zhanghailiang --- migration/colo.c | 26 ++

[Qemu-devel] [PATCH V9 0/2] Add new qmp commands to suppurt Xen COLO

Xen COLO depend on qemu COLO replication function. So, We need new qmp commands for Xen to use qemu replication. Corresponding libxl patches already in xen.git. Commit ID: ed37ef1f91c20f0ab162ce60f8c38400b917fa64 COLO: introduce new API to prepare/start/do/get_error/stop replication a0ddc0b35937

Re: [Qemu-devel] [PATCH v14 00/24] MTTCG Base enabling patches with ARM enablement

Richard Henderson writes: > On 02/24/2017 05:29 AM, Alex Bennée wrote: >> Hi Richard/Peter, >> >> Well obviously it was expecting a bit much for v13 to pass with flying >> colours. A merge failure which didn't affect ARM caused the >> regressions on other platforms resulting in the iothread not

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 06/15] target/ppc: remove xer split-out flags(so, ov, ca)

Nikunj A Dadhania writes: > Richard Henderson writes: > >> On 02/24/2017 01:58 PM, David Gibson wrote: >>> On Fri, Feb 24, 2017 at 06:18:22AM +0530, Nikunj A Dadhania wrote: Richard Henderson writes: > On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: >> Now get rid all the spl

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On Fri, Feb 24, 2017 at 01:35:10AM -0500, Pankaj Gupta wrote: > > > > > On Fri, Feb 24, 2017 at 12:07:33AM -0500, Pankaj Gupta wrote: > > > Hello Peter, > > > > Hi, Pankaj! > > > > > > > > This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' > > > before 'intel-iommu' is no

Re: [Qemu-devel] [PATCH v4 06/15] target/ppc: remove xer split-out flags(so, ov, ca)

Richard Henderson writes: > On 02/24/2017 01:58 PM, David Gibson wrote: >> On Fri, Feb 24, 2017 at 06:18:22AM +0530, Nikunj A Dadhania wrote: >>> Richard Henderson writes: >>> On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: > Now get rid all the split out variables so, ca, ov. After th

Re: [Qemu-devel] [PATCH v2] mttcg/i386: Patch instruction using async_safe_* framework

On 02/24/2017 04:42 PM, Pranith Kumar wrote: In mttcg, calling pause_all_vcpus() during execution from the generated TBs causes a deadlock if some vCPU is waiting for exclusive execution in start_exclusive(). Fix this by using the aync_safe_* framework instead of pausing vcpus for patching instru

Re: [Qemu-devel] [PATCH v4 06/15] target/ppc: remove xer split-out flags(so, ov, ca)

On 02/24/2017 01:58 PM, David Gibson wrote: On Fri, Feb 24, 2017 at 06:18:22AM +0530, Nikunj A Dadhania wrote: Richard Henderson writes: On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: Now get rid all the split out variables so, ca, ov. After this patch, all the bits are stored in CPUPPCSta

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

> > On Fri, Feb 24, 2017 at 12:07:33AM -0500, Pankaj Gupta wrote: > > Hello Peter, > > Hi, Pankaj! > > > > > This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' > > before 'intel-iommu' is not initialized. > > > > Overall it looks good to me, just a small nit below. > >

[Qemu-devel] [PULL 4/5] MAINTAINERS: merge Build and test automation with Docker tests

From: Alex Bennée The docker framework is really just another piece in the build automation puzzle so lets merge it together. For added bonus I've also included the Travis and Patchew status links. The Shippable links will be added later once mainline tests have been configured and setup. Signed

[Qemu-devel] [PULL 5/5] docker: Install python2 explicitly in docker image

Python is no longer installed implicitly, but the QEMU build system requires it. List it in PACKAGES. Reported-by: Auger Eric Signed-off-by: Fam Zheng Message-Id: <20170222021801.28658-1-f...@redhat.com> Tested-by: Eric Auger Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker

[Qemu-devel] [PULL 3/5] .shippable.yml: new CI provider

From: Alex Bennée Ostensibly Shippable offers a similar set of services as Travis. However they are focused on Docker container based work-flows so we can use our existing containers to run a few extra builds - in this case a bunch of cross-compiled targets on a Debian multiarch system. Signed-o

[Qemu-devel] [PULL 0/5] Docker testing and shippable patches

The following changes since commit 10f25e4844cb9b3f02fb032f88051dd5b65b4206: Merge remote-tracking branch 'remotes/yongbok/tags/mips-20170222' into staging (2017-02-23 09:59:40 +) are available in the git repository at: git://github.com/famz/qemu.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 2/5] new: debian docker targets for cross-compiling

From: Alex Bennée This provides a basic Debian install with access to the emdebian cross compilers. The debian-armhf-cross and debian-arm64-cross targets build on the basic Debian image to allow cross compiling to those targets. A new environment variable (QEMU_CONFIGURE_OPTS) is set as part of

[Qemu-devel] [PULL 1/5] tests/docker: add basic user mapping support

From: Alex Bennée Currently all docker builds are done by exporting a tarball to the docker container and running the build as the containers root user. Other use cases are possible however and it is possible to map a part of users file-system to the container. This is useful for example for doin

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

On 02/24/2017 03:50 PM, David Gibson wrote: Although I guess they'd shrink right down again if we put an env->xer_mask in. Thoughts on that option Richard? Why would xer_mask shrink the code? I can't see that we'd be able to eliminate any code using the mask. r~

Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image

On Wed, 02/22 10:18, Fam Zheng wrote: > Python is no longer installed implicitly, but the QEMU build system > requires it. List it in PACKAGES. > > Reported-by: Auger Eric > Signed-off-by: Fam Zheng > --- > tests/docker/dockerfiles/fedora.docker | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [PATCH 03/21] qmp-test: New, covering basic QMP protocol

Eric Blake writes: > On 02/23/2017 03:44 PM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> tests/Makefile.include | 5 +- >> tests/libqtest.c | 17 -- >> tests/libqtest.h | 8 +++ >> tests/qmp-test.c | 139 >> +

Re: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd

2017-02-24 11:52 GMT+08:00 Jeff Cody : > On Tue, Feb 21, 2017 at 02:50:03PM +0800, jaze...@gmail.com wrote: >> From: tianqing >> >> Rbd can do readv and writev directly, so wo do not need to transform >> iov to buf or vice versa any more. >> >> Signed-off-by: tianqing >> --- > > > This is marked

Re: [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument

Eric Blake writes: > On 02/23/2017 04:46 PM, Eric Blake wrote: >> On 02/23/2017 03:44 PM, Markus Armbruster wrote: >>> The value of key 'arguments' must be a JSON object. qemu-ga neglects >>> to check, and crashes. To reproduce, send >>> >>> { 'execute': 'guest-sync', 'arguments': [] } >>>

[Qemu-devel] [PATCH v5 5/8] target/ppc: use tcg ops for neg instruction

Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target/ppc/translate.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 16f422f..d4d9941 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate

[Qemu-devel] [PATCH v5 3/8] target/ppc: update ca32 in arithmetic substract

Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target/ppc/translate.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index eba83ef..e083082 100644 --- a/target/ppc/translate.c +++ b/target/ppc/t

Re: [Qemu-devel] [PATCH v4 00/15] POWER9 TCG enablements - part15

David Gibson writes: > [ Unknown signature status ] > On Fri, Feb 24, 2017 at 01:26:25AM +0530, Nikunj A Dadhania wrote: >> Patches: >> 01-06 Cleans up the XER split out variables and now the >>flag bits are stored in XER at their respective places >> >> 07-14 Contains implentation o

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On Fri, Feb 24, 2017 at 12:07:33AM -0500, Pankaj Gupta wrote: > Hello Peter, Hi, Pankaj! > > This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' > before 'intel-iommu' is not initialized. > > Overall it looks good to me, just a small nit below. > > > > > Intel vIOMMU dev

[Qemu-devel] [PATCH v5 0/8] POWER9 TCG enablements - part15

This series contains implentation of CA32 and OV32 bits added to the ISA 3.0. Various fixed-point arithmetic instructions are updated to take care of the newer flags. Finally the last patch adds new instruction mcrxrx, that helps reading the carry (CA and CA32) and the overflow (OV and OV32) fl

[Qemu-devel] [PATCH v5 8/8] target/ppc: add mcrxrx instruction

mcrxrx: Move to CR from XER Extended Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target/ppc/translate.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 982e66f..6e6868b 100644 --- a/target

[Qemu-devel] [PATCH v5 6/8] target/ppc: add ov32 flag for multiply low insns

For Multiply Word: SO, OV, and OV32 bits reflects overflow of the 32-bit result For Multiply DoubleWord: SO, OV, and OV32 bits reflects overflow of the 64-bit result Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target/ppc/translate.c | 6 ++ 1 file changed, 6 inserti

[Qemu-devel] [PATCH v5 7/8] target/ppc: add ov32 flag in divide operations

Add helper_div_compute_ov() in the int_helper for updating the overflow flags. For Divide Word: SO, OV, and OV32 bits reflects overflow of the 32-bit result For Divide DoubleWord: SO, OV, and OV32 bits reflects overflow of the 64-bit result Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard

[Qemu-devel] [PATCH v5 1/8] target/ppc: support for 32-bit carry and overflow

POWER ISA 3.0 adds CA32 and OV32 status in 64-bit mode. Add the flags and corresponding defines. Moreover, CA32 is updated when CA is updated and OV32 is updated when OV is updated. Arithmetic instructions: * Addition and Substractions: addic, addic., subfic, addc, subfc, adde, subfe

[Qemu-devel] [PATCH v5 4/8] target/ppc: update overflow flags for add/sub

* SO and OV reflects overflow of the 64-bit result in 64-bit mode and overflow of the low-order 32-bit result in 32-bit mode * OV32 reflects overflow of the low-order 32-bit independent of the mode Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 11 +-- 1 file changed, 9

[Qemu-devel] [PATCH v5 2/8] target/ppc: update ca32 in arithmetic add

Adds routine to compute ca32 - gen_op_arith_compute_ca32 For 64-bit mode use the compute ca32 routine. While for 32-bit mode, CA and CA32 will have same value. Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target/ppc/translate.c | 21 + 1 file changed,

[Qemu-devel] [PATCH v2] mttcg/i386: Patch instruction using async_safe_* framework

In mttcg, calling pause_all_vcpus() during execution from the generated TBs causes a deadlock if some vCPU is waiting for exclusive execution in start_exclusive(). Fix this by using the aync_safe_* framework instead of pausing vcpus for patching instructions. CC: Richard Henderson CC: Peter Mayde

Re: [Qemu-devel] [PATCH V8 2/2] Add a new qmp command to do checkpoint, query xen replication status

On 02/23/2017 11:34 PM, Eric Blake wrote: On 02/23/2017 01:14 AM, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Xen colo will need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang Reviewed-by: Eric Blake You made a substantial change

Re: [Qemu-devel] [PATCH v4 00/15] POWER9 TCG enablements - part15

On Fri, Feb 24, 2017 at 01:26:25AM +0530, Nikunj A Dadhania wrote: > Patches: > 01-06 Cleans up the XER split out variables and now the >flag bits are stored in XER at their respective places > > 07-14 Contains implentation of CA32 and OV32 bits added to the >ISA 3.0. Various

Re: [Qemu-devel] [PATCH 5/6] target/ppc: Eliminate htab_base and htab_mask variables

On Thu, Feb 23, 2017 at 04:52:59PM +1100, Suraj Jitindar Singh wrote: > On Thu, 2017-02-23 at 13:09 +1100, David Gibson wrote: > > CPUPPCState includes fields htab_base and htab_mask which store the > > base > > address (GPA) and size (as a mask) of the guest's hashed page table > > (HPT). > > Thes

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

On Fri, Feb 24, 2017 at 06:11:30AM +0530, Nikunj Dadhania wrote: > On 24 February 2017 at 04:23, David Gibson > wrote: > > On Fri, Feb 24, 2017 at 09:34:32AM +1100, Richard Henderson wrote: > >> On 02/23/2017 05:40 PM, Nikunj A Dadhania wrote: > >> > Richard Henderson writes: > >> > > These func

Re: [Qemu-devel] [PATCH v6 0/2] spapr: generate DT node names

On Fri, Feb 17, 2017 at 02:31:32PM +0100, Laurent Vivier wrote: 1;4601;0c> This series is a rebased series from September 2015, it has been > reviewed but has never reached the master branch. > > When DT node names for PCI devices are generated by SLOF, > they are generated according to the type o

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

Hello Peter, This solution looks to check dependency of 'vfio-pci' over 'intel-iommu' before 'intel-iommu' is not initialized. Overall it looks good to me, just a small nit below. > > Intel vIOMMU devices are created with "-device" parameter, while here > actually we need to make sure the dmar

[Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs

From: Greg Kurz Some systems can already provide more than 255 hardware threads. Bumping the QEMU limit to 1024 seems reasonable: - it has no visible overhead in top; - the limit itself has no effect on hot paths. Cc: Greg Kurz Signed-off-by: Alexey Kardashevskiy --- With ulimit -u/-n bumped

[Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

Intel vIOMMU devices are created with "-device" parameter, while here actually we need to make sure the dmar device be created before other PCI devices (like vfio-pci) so that we know iommu_fn will be setup correctly before realizations of those PCI devices (it is sensible that PCI device fetch the

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Hi, Just want to check if the following mechanism for accepting the secret password looks OK? We have yet to internally discuss the semantics of how we plan to use the user-ID/password for authentication. This diff is just to understand how I am expected to accept the secret from the command line

Re: [Qemu-devel] [PATCH V8 1/2] Add a new qmp command to start/stop replication

On 02/23/2017 11:31 PM, Eric Blake wrote: On 02/23/2017 01:14 AM, Zhang Chen wrote: We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang Reviewed-by: Eric Blake Reviewed-by: Stefano S

Re: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd

On Tue, Feb 21, 2017 at 02:50:03PM +0800, jaze...@gmail.com wrote: > From: tianqing > > Rbd can do readv and writev directly, so wo do not need to transform > iov to buf or vice versa any more. > > Signed-off-by: tianqing > --- This is marked as an RFC still - is this a series you would like

Re: [Qemu-devel] [PATCH 0/2] block/nfs optimizations

On Fri, Feb 17, 2017 at 05:38:59PM +0100, Peter Lieven wrote: > Peter Lieven (2): > block/nfs: convert to preadv / pwritev > block/nfs: try to avoid the bounce buffer in pwritev > > block/nfs.c | 50 -- > 1 file changed, 28 insertions(+), 22 del

[Qemu-devel] [PATCH v4] mem-prealloc: reduce large guest start-up and migration time.

Using "-mem-prealloc" option for a large guest leads to higher guest start-up and migration time. This is because with "-mem-prealloc" option qemu tries to map every guest page (create address translations), and make sure the pages are available during runtime. virsh/libvirt by default, seems to us

Re: [Qemu-devel] [PATCH] memory: make ram device read/write endian sensitive

On Thu, Feb 23, 2017 at 12:43:37PM +0100, Paolo Bonzini wrote: > > > On 23/02/2017 12:34, Peter Maydell wrote: > > On 23 February 2017 at 10:33, Paolo Bonzini wrote: > >> > >> > >> On 23/02/2017 11:23, Peter Maydell wrote: > >>> On 23 February 2017 at 10:10, Paolo Bonzini wrote: > On 23/02

Re: [Qemu-devel] [PATCH] memory: make ram device read/write endian sensitive

On Fri, Feb 24, 2017 at 01:14:09AM +0800, Yongji Xie wrote: > on 2017/2/24 0:15, Paolo Bonzini wrote: > > > > > On 23/02/2017 17:08, Peter Maydell wrote: > > > On 23 February 2017 at 15:58, Paolo Bonzini wrote: > > > > However, DEVICE_NATIVE_ENDIAN would have to be paired with tswap, which > > >

Re: [Qemu-devel] [PATCH v4 06/15] target/ppc: remove xer split-out flags(so, ov, ca)

On Fri, Feb 24, 2017 at 06:18:22AM +0530, Nikunj A Dadhania wrote: > Richard Henderson writes: > > > On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: > >> Now get rid all the split out variables so, ca, ov. After this patch, > >> all the bits are stored in CPUPPCState::xer at appropriate places.

Re: [Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

On 2017/2/22 22:43, Paolo Bonzini wrote: On 22/02/2017 14:31, Chris Friesen wrote: Can you reproduce it with kernel 4.8+? I'm suspecting commmit 4e59516a12a6 ("kvm: vmx: ensure VMCS is current while enabling PML", 2016-07-14) to be the fix. I can't easily try with a newer kernel, the s

Re: [Qemu-devel] [PATCH] intel_iommu: make sure its init before PCI dev

On Fri, Feb 24, 2017 at 01:21:52AM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 22, 2017 at 01:49:25PM +0800, Peter Xu wrote: > > Intel vIOMMU devices are created with "-device" parameter, while here > > actually we need to make sure this device will be created before some > > other PCI devices (

Re: [Qemu-devel] [PATCH 2/2] vmxnet3: VMStatify rx/tx q_descr and int_state

On 2017年02月01日 03:44, Dr. David Alan Gilbert wrote: * Dmitry Fleytman (dmi...@daynix.com) wrote: On 3 Jan 2017, at 21:40 PM, Dr. David Alan Gilbert wrote: * Dmitry Fleytman (dmi...@daynix.com ) wrote: On 16 Dec 2016, at 14:19 PM, Dr. David Alan Gilbert wrote: *

Re: [Qemu-devel] using fdt_setprop() to set properties to empty values

On Fri, Feb 24, 2017 at 09:49:11AM +1100, David Gibson wrote: > On Thu, Feb 23, 2017 at 08:52:01AM -0600, Eric Blake wrote: > > On 02/23/2017 06:33 AM, Peter Maydell wrote: > > > What's the right way to use libfdt's fdt_setprop to set a property > > > to have an empty value? At the moment in QEMU w

Re: [Qemu-devel] [PATCH v4 06/15] target/ppc: remove xer split-out flags(so, ov, ca)

Richard Henderson writes: > On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: >> Now get rid all the split out variables so, ca, ov. After this patch, >> all the bits are stored in CPUPPCState::xer at appropriate places. >> >> Signed-off-by: Nikunj A Dadhania >> --- >> target/ppc/cpu.c|

Re: [Qemu-devel] [PATCH v4 02/15] target/ppc: update ov flag from remaining paths

Richard Henderson writes: > On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: >> @@ -320,22 +320,24 @@ target_ulong helper_divo(CPUPPCState *env, >> target_ulong arg1, >> target_ulong arg2) >> { >> uint64_t tmp = (uint64_t)arg1 << 32 | env->spr[SPR_MQ]; >> +int

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

On 24 February 2017 at 04:23, David Gibson wrote: > On Fri, Feb 24, 2017 at 09:34:32AM +1100, Richard Henderson wrote: >> On 02/23/2017 05:40 PM, Nikunj A Dadhania wrote: >> > Richard Henderson writes: >> > > These functions are becoming quite large. Are they performance critical >> > > enough

Re: [Qemu-devel] [PULL v2 8/8] hw/mips: MIPS Boston board support

On 23/02/2017 18:09, Peter Maydell wrote: > On 22 February 2017 at 00:21, Yongbok Kim wrote: >> From: Paul Burton >> >> Introduce support for emulating the MIPS Boston development board. The >> Boston board is built around an FPGA & 3 PCIe controllers, one of which >> is connected to an Intel E

[Qemu-devel] [PULL 0/2] target-mips queue

The following changes since commit 10f25e4844cb9b3f02fb032f88051dd5b65b4206: Merge remote-tracking branch 'remotes/yongbok/tags/mips-20170222' into staging (2017-02-23 09:59:40 +) are available in the git repository at: git://github.com/yongbok/upstream-qemu.git tags/mips-20170224 for

[Qemu-devel] [PULL 2/2] hw/mips: MIPS Boston board support

From: Paul Burton Introduce support for emulating the MIPS Boston development board. The Boston board is built around an FPGA & 3 PCIe controllers, one of which is connected to an Intel EG20T Platform Controller Hub. It is used during the development & debug of new CPUs and the software intended

[Qemu-devel] [PULL 1/2] Revert "hw/mips: MIPS Boston board support"

This reverts commit d3473e147a754e999718bf6fcb015d9978c6a1ee. The commit breaks "make check" on 32-bit hosts. Signed-off-by: Yongbok Kim --- configure| 2 +- default-configs/mips64el-softmmu.mak | 3 - hw/mips/Makefile.objs| 1 - hw/mips/boston.

Re: [Qemu-devel] [PATCH 13/29] 9pfs: local: remove: don't follow symlinks

On Thu, 23 Feb 2017 14:23:15 + Stefan Hajnoczi wrote: > On Mon, Feb 20, 2017 at 03:41:00PM +0100, Greg Kurz wrote: > > +dirfd = local_opendir_nofollow(ctx, dirpath); > > +if (dirfd) { > > +goto out; > > } > > > > -buffer = rpath(ctx, path); > > -err = remove(buf

[Qemu-devel] [PATCH] hw/mips: MIPS Boston board support

From: Paul Burton Introduce support for emulating the MIPS Boston development board. The Boston board is built around an FPGA & 3 PCIe controllers, one of which is connected to an Intel EG20T Platform Controller Hub. It is used during the development & debug of new CPUs and the software intended

Re: [Qemu-devel] [PATCH] memory: make ram device read/write endian sensitive

On Thu, Feb 23, 2017 at 03:29:53PM +, Peter Maydell wrote: > On 23 February 2017 at 15:21, Paolo Bonzini wrote: > > > > > > On 23/02/2017 15:35, Peter Maydell wrote: > >> On 23 February 2017 at 12:53, Paolo Bonzini wrote: > >>> > >>> > >>> On 23/02/2017 13:26, Peter Maydell wrote: > On 2

Re: [Qemu-devel] [PATCH] intel_iommu: make sure its init before PCI dev

On Thu, Feb 23, 2017 at 01:42:34PM +0800, Peter Xu wrote: > On Wed, Feb 22, 2017 at 08:24:51PM -0700, Alex Williamson wrote: > > [...] > > > > Now Jintack reported another issue, that we may have two default > > > devices there if not specifying "-nodefaults", and that two devices > > > will alwa

Re: [Qemu-devel] using fdt_setprop() to set properties to empty values

On Thu, Feb 23, 2017 at 08:52:01AM -0600, Eric Blake wrote: > On 02/23/2017 06:33 AM, Peter Maydell wrote: > > What's the right way to use libfdt's fdt_setprop to set a property > > to have an empty value? At the moment in QEMU we tend to use > > fdt_setprop(fdt, nodeoffset, "propertyname", NULL,

Re: [Qemu-devel] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

On Fri, Feb 24, 2017 at 09:34:32AM +1100, Richard Henderson wrote: > On 02/23/2017 05:40 PM, Nikunj A Dadhania wrote: > > Richard Henderson writes: > > > These functions are becoming quite large. Are they performance critical > > > enough > > > that they need to stay as inline code, or should th

Re: [Qemu-devel] [Qemu-ppc] Proposal PCI/PCIe device placement on PAPR guests

On Thu, Feb 23, 2017 at 08:23:50AM +0100, Greg Kurz wrote: > On Thu, 23 Feb 2017 13:11:52 +1100 > David Gibson wrote: > > > On Wed, Feb 22, 2017 at 12:08:25PM +0100, Greg Kurz wrote: > > > David, > > > > > > I don't see the "spapr_pci: Allow PCI-Express devices" patch in your > > > ppc-for-2.9 t

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 00/22] ppc/xics: simplify ICS and ICP creation

On Thu, Feb 23, 2017 at 08:19:31AM +0100, Cédric Le Goater wrote: > > Apart from that I'm pretty happy with the endpoint you reach. I'm a > > bit less convinced about the path taken to get there. I'm not sure if > > it's worth the churn of doing this reorg, but I think we'd get there > > more cle

Re: [Qemu-devel] [PATCH] intel_iommu: make sure its init before PCI dev

On Wed, Feb 22, 2017 at 01:49:25PM +0800, Peter Xu wrote: > Intel vIOMMU devices are created with "-device" parameter, while here > actually we need to make sure this device will be created before some > other PCI devices (like vfio-pci devices) so that we know iommu_fn will > be setup correctly be

Re: [Qemu-devel] [PATCH 03/21] qmp-test: New, covering basic QMP protocol

On 02/23/2017 03:44 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/Makefile.include | 5 +- > tests/libqtest.c | 17 -- > tests/libqtest.h | 8 +++ > tests/qmp-test.c | 139 > + > 4 files ch

Re: [Qemu-devel] iommu emulation

[cc Bandan] On Tue, Feb 21, 2017 at 5:33 AM, Jintack Lim wrote: > > > On Wed, Feb 15, 2017 at 9:47 PM, Alex Williamson < > alex.william...@redhat.com> wrote: > >> On Thu, 16 Feb 2017 10:28:39 +0800 >> Peter Xu wrote: >> >> > On Wed, Feb 15, 2017 at 11:15:52AM -0700, Alex Williamson wrote: >> >

Re: [Qemu-devel] [PATCH 02/21] libqtest: Work around a "QMP wants a newline" bug

On 02/23/2017 03:44 PM, Markus Armbruster wrote: > The next commit is going to add a test that calls qmp("null"). > Curiously, this hangs. Here's why. > > qmp_fd_sendv() doesn't send newlines. Not even when @fmt contains > some. At first glance, the QMP parser seems to be fine with that. > Howe

Re: [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument

On 02/23/2017 04:46 PM, Eric Blake wrote: > On 02/23/2017 03:44 PM, Markus Armbruster wrote: >> The value of key 'arguments' must be a JSON object. qemu-ga neglects >> to check, and crashes. To reproduce, send >> >> { 'execute': 'guest-sync', 'arguments': [] } >> >> to qemu-ga. >> >> do_qmp_d

Re: [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument

On 02/23/2017 03:44 PM, Markus Armbruster wrote: > The value of key 'arguments' must be a JSON object. qemu-ga neglects > to check, and crashes. To reproduce, send > > { 'execute': 'guest-sync', 'arguments': [] } > > to qemu-ga. > > do_qmp_dispatch() uses qdict_get_qdict() to get the argum

Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates

On 02/24/2017 01:09 AM, Stafford Horne wrote: I posted a test image to the wiki http://wiki.qemu-project.org/Testing/System_Images However, someone on the #qemu irc room mentioned its not ideal to post any images on the wiki and existing images should be taken down due to copyright issues. I

Re: [Qemu-devel] [PATCH] mttcg/i386: Patch instruction using async_safe_* framework

On 02/23/2017 12:20 PM, Pranith Kumar wrote: In mttcg, calling pause_all_vcpus() during execution from the generated TBs causes a deadlock if some vCPU is waiting for exclusive execution in start_exclusive(). Fix this by using the aync_safe_* framework instead of pausing vcpus for patching instru

Re: [Qemu-devel] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

On Thu, Feb 23, 2017 at 12:32:44PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > -static void gen_read_xer(TCGv dst) > >> +static void gen_read_xer(DisasContext *ctx, TCGv dst) > >> { > >> TCGv t0 = tcg_temp_new(); > >> TCGv t1 = tcg_temp_new(); > >> @@ -3715,15 +3719,30

Re: [Qemu-devel] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

On 02/23/2017 06:02 PM, Nikunj A Dadhania wrote: David Gibson writes: -static void gen_read_xer(TCGv dst) +static void gen_read_xer(DisasContext *ctx, TCGv dst) { TCGv t0 = tcg_temp_new(); TCGv t1 = tcg_temp_new(); @@ -3715,15 +3719,30 @@ static void gen_read_xer(TCGv dst) tcg

Re: [Qemu-devel] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

On 02/23/2017 05:40 PM, Nikunj A Dadhania wrote: Richard Henderson writes: These functions are becoming quite large. Are they performance critical enough that they need to stay as inline code, or should they be moved to helpers and share code with cpu_read/write_xer? Just to boot to login pr

Re: [Qemu-devel] [PATCH RESEND] aarch64: Change ext type to TCGType to fix warnings

On 02/18/2017 02:43 AM, Pranith Kumar wrote: To fix the following warnings: In file included from /users/pranith/qemu/tcg/tcg.c:255: /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:879:24: warning: implicit conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different enumera

Re: [Qemu-devel] [PATCH v2 0/3] i386: Add "max" CPU model to TCG and KVM

On Thu, Feb 23, 2017 at 05:07:47PM -0300, Eduardo Habkost wrote: > Ping? > > As v1 was sitting on the list since Jan 19, if there are no > objections I will merge this and include in my next pull request > before soft freeze. Do you have a copy which applies on top of current HEAD? I get loads o

[Qemu-devel] [PATCH 20/21] qapi: Make input visitors detect unvisited list tails

Fix the design flaw demonstrated in the previous commit: new method check_list() lets input visitors report that unvisited input remains for a list, exactly like check_struct() lets them report that unvisited input remains for a struct or union. Implement the method for the qobject input visitor (

[Qemu-devel] [PATCH 19/21] tests: Cover partial input visit of list

Demonstrates a design flaw: there is no way to for input visitors to report that a list visit didn't visit the complete input list. The generated list visits always do, but manual visits needn't. Signed-off-by: Markus Armbruster --- tests/test-opts-visitor.c | 41 ++

[Qemu-devel] [PATCH 17/21] qapi: Drop unused non-strict qobject input visitor

The split between tests/test-qobject-input-visitor.c and tests/test-qobject-input-strict.c now makes less sense than ever. The next commit will take care of that. Signed-off-by: Markus Armbruster --- block/nbd.c | 2 +- block/nfs.c | 2 +- blo

[Qemu-devel] [PATCH 18/21] tests-qobject-input-strict: Merge into test-qobject-input-visitor

Much test-qobject-input-strict.c duplicates test-qobject-input-strict.c less assertions on expected output: * test_validate_struct() duplicates test_visitor_in_struct() * test_validate_struct_nested() duplicates test_visitor_in_struct_nested() * test_validate_list() duplicates the first half o

[Qemu-devel] [PATCH 21/21] qapi: Improve qobject visitor documentation

Signed-off-by: Markus Armbruster --- include/qapi/qobject-input-visitor.h | 36 ++- include/qapi/qobject-output-visitor.h | 35 ++ 2 files changed, 66 insertions(+), 5 deletions(-) diff --git a/include/qapi/qobject-input-visitor.h

[Qemu-devel] [PATCH 15/21] qom: Make object_property_set_qobject()'s input visitor strict

Commit 240f64b made all qobject input visitors created outside tests strict, except for the one in object_property_set_qobject(). That one was left behind only because Eric couldn't spare the time to figure out whether making it strict would break anything, with a TODO comment. Time to resolve it

[Qemu-devel] [PATCH 12/21] qapi: Improve qobject input visitor error reporting

Error messages refer to nodes of the QObject being visited by name. Trouble is the names are sometimes less than helpful: * The name of the root QObject is whatever @name argument got passed to the visitor, except NULL gets mapped to "null". We commonly pass NULL. Not good. Avoiding error

[Qemu-devel] [PATCH 13/21] qapi: Drop string input visitor method optional()

visit_optional() is to be called only between visit_start_struct() and visit_end_struct(). Visitors that don't support struct visits, i.e. don't implement start_struct(), end_struct(), have no use for it. Clarify documentation. The string input visitor doesn't support struct visits. Its parse_op

[Qemu-devel] [PATCH 05/21] qmp: Clean up how we enforce capability negotiation

To enforce capability negotiation before normal operation, handle_qmp_command() inspects every command before it's handed off to qmp_dispatch(). This is a bit of a layering violation, and results in duplicated code. Before capability negotiation (!cur_mon->in_command_mode), we fail commands other

[Qemu-devel] [PATCH 07/21] qmp: Eliminate silly QERR_QMP_* macros

The QERR_ macros are leftovers from the days of "rich" error objects. QERR_QMP_BAD_INPUT_OBJECT, QERR_QMP_BAD_INPUT_OBJECT_MEMBER, QERR_QMP_EXTRA_MEMBER are used in just one place now, except for one use that has crept into qobject-input-visitor.c. Drop these macros, to make the (bad) error messa

[Qemu-devel] [PATCH 02/21] libqtest: Work around a "QMP wants a newline" bug

The next commit is going to add a test that calls qmp("null"). Curiously, this hangs. Here's why. qmp_fd_sendv() doesn't send newlines. Not even when @fmt contains some. At first glance, the QMP parser seems to be fine with that. However, it turns out that it fails to react to input until it se

[Qemu-devel] [PATCH 10/21] qapi: Clean up after commit 3d344c2

Drop unused QIV_STACK_SIZE and unused qobject_input_start_struct() parameter errp. Signed-off-by: Markus Armbruster --- qapi/qobject-input-visitor.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c ind

[Qemu-devel] [PATCH 14/21] qapi: Make string input and opts visitor require non-null input

The string input visitor tries to cope with null input. Null input isn't used anywhere, and isn't covered by tests. Unsurprisingly, it doesn't fully work: start_list() crashes because it passes the input via parse_str() to strtoll() unchecked. Make string_input_visitor_new() assert its argument

[Qemu-devel] [PATCH 08/21] qmp: Improve QMP dispatch error messages

Signed-off-by: Markus Armbruster --- qapi/qmp-dispatch.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 377ebb5..4610b6d 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -30,7 +30,7 @@ static QDict *q

[Qemu-devel] [PATCH 06/21] qmp: Drop duplicated QMP command object checks

qmp_check_input_obj() duplicates qmp_dispatch_check_obj(), except the latter screws up an error message. handle_qmp_command() runs first the former, then the latter via qmp_dispatch(), masking the screwup. qemu-ga also masks the screwup, because it also duplicates checks, just differently. qmp_c

[Qemu-devel] [PATCH 04/21] qmp: Dumb down how we run QMP command registration

The way we get QMP commands registered is high tech: * qapi-commands.py generates qmp_init_marshal() that does the actual work * it also generates the magic to register it as a MODULE_INIT_QAPI function, so it runs when someone calls module_call_init(MODULE_INIT_QAPI) * main() calls module_c

[Qemu-devel] [PATCH 11/21] qapi: Make QObject input visitor set *list reliably

qobject_input_start_struct() sets *list, except when it fails because qobject_input_get_object() fails, i.e. the input object doesn't exist. All the other input visitor start_struct(), start_list(), start_alternate() always set *obj / *list. Change qobject_input_start_struct() to match. Signed-o

[Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument

The value of key 'arguments' must be a JSON object. qemu-ga neglects to check, and crashes. To reproduce, send { 'execute': 'guest-sync', 'arguments': [] } to qemu-ga. do_qmp_dispatch() uses qdict_get_qdict() to get the arguments. When not a JSON object, this gets a null pointer, which fl

[Qemu-devel] [PATCH 16/21] test-qobject-input-visitor: Use strict visitor

The qobject input visitor comes in a strict and a non-strict variant. This test is the non-strict variant's last user. Turns out it relies on non-strict only in test_visitor_in_null(), and just out of laziness. We don't actually test the non-strict behavior. Clean up test_visitor_in_null(), and

  1   2   3   4   >