On Fri, Feb 24, 2017 at 06:18:22AM +0530, Nikunj A Dadhania wrote: > Richard Henderson <r...@twiddle.net> writes: > > > On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote: > >> Now get rid all the split out variables so, ca, ov. After this patch, > >> all the bits are stored in CPUPPCState::xer at appropriate places. > >> > >> Signed-off-by: Nikunj A Dadhania <nik...@linux.vnet.ibm.com> > >> --- > >> target/ppc/cpu.c | 8 +--- > >> target/ppc/cpu.h | 26 ++++++------ > >> target/ppc/int_helper.c | 12 +++--- > >> target/ppc/translate.c | 106 > >> +++++++++++++++++++++++++----------------------- > >> 4 files changed, 78 insertions(+), 74 deletions(-) > > > > I do not think this is a good direction to take this. > > Hmm, any particular reason?
Right, I suggested this, but based only a suspicion that the split
variables weren't worth the complexity. I'm happy to be corrected by
someone with better knowledge of TCG, but it'd be nice to know why.
> I can send back the v3 with suggested changes dropping the xer split out
> changes.
>
> Regards
> Nikunj
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
