Re: [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900

2016-10-26 Thread Thomas Huth
On 26.10.2016 21:08, Richard Henderson wrote: > The LT instruction was added in the extended immediate facility > introduced with the z9-109 processor. > > Cc: Riku Voipio > Reported-by: Michael Tokarev > Fixes: c9bc3437a905b660561a26cd4ecc64579843267b > Suggested-by: Aurelien Jarno > Signed-of

[Qemu-devel] [PATCH COLO-Frame (Base) v23 05/18] COLO: Establish a new communicating path for COLO

2016-10-26 Thread zhanghailiang
This new communication path will be used for returning messages from Secondary side to Primary side. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah --- v22: - Add Reviewed-by tag v13: - Remove useless error report v12: - Add Re

[Qemu-devel] [PATCH COLO-Frame (Base) v23 06/18] COLO: Introduce checkpointing protocol

2016-10-26 Thread zhanghailiang
We need communications protocol of user-defined to control the checkpointing process. The new checkpointing request is started by Primary VM, and the interactive process like below: Checkpoint synchronizing points: Primary Secondary

[Qemu-devel] [PATCH COLO-Frame (Base) v23 00/18] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-26 Thread zhanghailiang
Hi Amit & Juan, All patches except the last one in this series have been reviewed. And It is ready for QEMU 2.8. Would you please help merge this series into upstream ? Thanks very much. Hailiang Cc: Hai Huang Cc: Weidong Han Cc: Dong eddie Cc: Stefan Hajnoczi Cc: Jason Wang Cc: Dr. David

[Qemu-devel] [PATCH COLO-Frame (Base) v23 04/18] migration: Switch to COLO process after finishing loadvm

2016-10-26 Thread zhanghailiang
Switch from normal migration loadvm process into COLO checkpoint process if COLO mode is enabled. We add three new members to struct MigrationIncomingState, 'have_colo_incoming_thread' and 'colo_incoming_thread' record the COLO related thread for secondary VM, 'migration_incoming_co' records the o

[Qemu-devel] [PATCH COLO-Frame (Base) v23 15/18] COLO: Implement failover work for secondary VM

2016-10-26 Thread zhanghailiang
If users require SVM to takeover work, COLO incoming thread should exit from loop while failover BH helps backing to migration incoming coroutine. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah --- v22: - Add Reviewed-by tag v2

[Qemu-devel] [PATCH COLO-Frame (Base) v23 07/18] COLO: Add a new RunState RUN_STATE_COLO

2016-10-26 Thread zhanghailiang
Guest will enter this state when paused to save/restore VM state under COLO checkpoint. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake Reviewed-by: Amit Shah ---

[Qemu-devel] [PATCH COLO-Frame (Base) v23 17/18] configure: Support enable/disable COLO feature

2016-10-26 Thread zhanghailiang
configure --enable-colo/--disable-colo to switch COLO support on/off. COLO feature doesn't depend on any other external libraries, So here it is reasonable to enable COLO by default, to avoid re-compile QEMU if users want to use this capability. Signed-off-by: zhanghailiang Signed-off-by: Li Zhi

[Qemu-devel] [PATCH COLO-Frame (Base) v23 11/18] COLO: Synchronize PVM's state to SVM periodically

2016-10-26 Thread zhanghailiang
Do checkpoint periodically, the default interval is 200ms. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah --- v22: - Add Reviewed-by tag v12: - Add Reviewed-by tag v11: - Fix wrong sleep time for checkpoint period. (Dave's comm

[Qemu-devel] [PATCH COLO-Frame (Base) v23 10/18] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2016-10-26 Thread zhanghailiang
Add checkpoint-delay parameter for migrate-set-parameters, so that we can control the checkpoint frequency when COLO is in periodic mode. Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Review

[Qemu-devel] [PATCH COLO-Frame (Base) v23 13/18] COLO: Introduce state to record failover process

2016-10-26 Thread zhanghailiang
When handling failover, COLO processes differently according to the different stage of failover process, here we introduce a global atomic variable to record the status of failover. We add four failover status to indicate the different stage of failover process. You should use the helpers to get a

[Qemu-devel] [PATCH COLO-Frame (Base) v23 01/18] migration: Introduce capability 'x-colo' to migration

2016-10-26 Thread zhanghailiang
We add helper function colo_supported() to indicate whether colo is supported or not, with which we use to control whether or not showing 'x-colo' string to users, they can use qmp command 'query-migrate-capabilities' or hmp command 'info migrate_capabilities' to learn if colo is supported. The de

Re: [Qemu-devel] [PATCH 2/4] e1000e: No need to validate configuration on migration

2016-10-26 Thread Dmitry Fleytman
> On 26 Oct 2016, at 22:21 PM, Eduardo Habkost wrote: > > The user (or management software) is responsible for keeping the > same configuration on both sides while migrating. Remove the > configuration validation code at e1000e_post_load, and the > unnecessary subsys_used/subsys_ven_used fields.

Re: [Qemu-devel] [PATCH 1/4] e1000e: Use regular DEFINE_PROP_ macros for properties

2016-10-26 Thread Dmitry Fleytman
> On 27 Oct 2016, at 06:12 AM, Jason Wang wrote: > > > > On 2016年10月27日 03:21, Eduardo Habkost wrote: >> Instead of hacking custom PropertyInfo structs, use the regular >> DEFINE_PROP_ macros for the e1000e properties. >> >> This also fixes a bug in the disable_vnet_hdr property >> definition

Re: [Qemu-devel] [PATCH v3] char: cadence: check baud rate generator and divider values

2016-10-26 Thread P J P
+-- On Wed, 26 Oct 2016, Peter Maydell wrote --+ | You're relying on the register values never being | invalid to avoid the divide by zero, which means | you need to check them post-migration too. @Alistair: @Edgar: Would it be possible for you to fix the migration part? I'm preparing for coup

Re: [Qemu-devel] [PATCH v3] char: cadence: check baud rate generator and divider values

2016-10-26 Thread P J P
+-- On Wed, 26 Oct 2016, Alistair Francis wrote --+ | > * Device model for Cadence UART | > + * -> http://www.xilinx.com/support/documentation/user_guides/ug585-Zynq-7000-TRM.pdf | | Nit pick, I would put the URL under the title below. Okay. | > +case R_BRGR: /* Baud rate generator *

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-26 Thread Fam Zheng
On Wed, 10/26 17:33, Kevin Wolf wrote: > > As we concluded above, this is really a matrix a two bools rather than a > single property. We need a new option for "I can't allow other processes > to write to the image", but we don't need one for "I am writing to the > image" because that's the read-o

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Hailiang Zhang
On 2016/10/27 12:21, Amit Shah wrote: On (Wed) 26 Oct 2016 [23:42:10], zhanghailiang wrote: configure --enable-colo/--disable-colo to switch COLO support on/off. COLO feature doesn't depend on any other external librariesis, typo: libraries Will fix in next version, thanks :)

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 03/17] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-26 Thread Hailiang Zhang
On 2016/10/27 11:58, Amit Shah wrote: On (Wed) 26 Oct 2016 [21:49:10], Hailiang Zhang wrote: On 2016/10/26 12:50, Amit Shah wrote: On (Tue) 18 Oct 2016 [20:09:59], zhanghailiang wrote: Add a new migration state: MIGRATION_STATUS_COLO. Migration source side enters this state after the first liv

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a new communicating path for COLO

2016-10-26 Thread Hailiang Zhang
On 2016/10/27 11:57, Amit Shah wrote: On (Wed) 26 Oct 2016 [22:05:22], Hailiang Zhang wrote: On 2016/10/26 13:06, Amit Shah wrote: On (Tue) 18 Oct 2016 [20:10:01], zhanghailiang wrote: This new communication path will be used for returning messages >from Secondary side to Primary side. Sign

Re: [Qemu-devel] [PATCH v9 01/12] vfio: Mediated device Core driver

2016-10-26 Thread Jike Song
On 10/21/2016 01:12 AM, Alex Williamson wrote: > On Thu, 20 Oct 2016 15:23:53 +0800 > Jike Song wrote: > >> On 10/18/2016 05:22 AM, Kirti Wankhede wrote: >>> diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c >>> new file mode 100644 >>> index ..7db5ec164aeb >>

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-26 Thread Hailiang Zhang
On 2016/10/27 11:52, Amit Shah wrote: On (Wed) 26 Oct 2016 [23:52:48], Hailiang Zhang wrote: Hi Amit, On 2016/10/26 16:26, Amit Shah wrote: On (Wed) 26 Oct 2016 [14:43:30], Hailiang Zhang wrote: Hi Amit, On 2016/10/26 14:09, Amit Shah wrote: Hello, On (Tue) 18 Oct 2016 [20:09:56], zhanghai

Re: [Qemu-devel] [PATCH v2 5/6] target-ppc: add vprtyb[w/d/q] instructions

2016-10-26 Thread Richard Henderson
On 10/26/2016 08:47 PM, David Gibson wrote: > +void helper_vprtybq(ppc_avr_t *r, ppc_avr_t *b) > +{ > +int i; > +uint8_t s = 0; > +for (i = 0; i < 16; i++) { > +s ^= (b->u8[i] & 1); > +} > +r->u64[LO_IDX] = (!s) ? 0 : 1; > +r->u64[HI_IDX] = 0; > +} > + I think you

[Qemu-devel] [Bug 588803] Re: Image corruption during snapshot creation/deletion

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588803 Title: Image corrup

Re: [Qemu-devel] [PATCH v2 3/6] target-ppc: add vrldnmi and vrlwmi instructions

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:56:26AM +0530, Nikunj A Dadhania wrote: > From: "Gautham R. Shenoy" > > vrldmi: Vector Rotate Left Dword then Mask Insert > vrlwmi: Vector Rotate Left Word then Mask Insert > > Signed-off-by: Gautham R. Shenoy > Signed-off-by: Bharata B Rao > ( use extract[32,64] and

[Qemu-devel] [Bug 588731] Re: PXE boot not working

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588731 Title: PXE boot not

[Qemu-devel] [Bug 424450] Re: FDC reset should reset the MSR

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/424450 Title: FDC reset sh

[Qemu-devel] [Bug 642304] Re: Solaris/x86 v10 hangs under KVM

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/642304 Title: Solaris/x86

[Qemu-devel] [Bug 602336] Re: bad network performance with 10Gbit

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/602336 Title: bad network

Re: [Qemu-devel] [PATCH v2 5/6] target-ppc: add vprtyb[w/d/q] instructions

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:56:28AM +0530, Nikunj A Dadhania wrote: > From: Ankit Kumar > > Add following POWER ISA 3.0 instructions. > vprtybw: Vector Parity Byte Word > vprtybd: Vector Parity Byte Double Word > vprtybq: Vector Parity Byte Quad Word > > Signed-off-by: Ankit Kumar > Signed-off-b

[Qemu-devel] [Bug 1315747] Re: Qemu on Windows

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1315747 Title: Qemu on Win

[Qemu-devel] [Bug 1033494] Re: qemu-system-x86_64 segfaults with kernel 3.5.0

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1033494 Title: qemu-system

[Qemu-devel] [Bug 588735] Re: Quit command not working

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588735 Title: Quit command

Re: [Qemu-devel] [PATCH v2 0/6] spapr: dedicated hotplug events and memory unplug support

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 04:59:19PM -0500, Michael Roth wrote: > This series is based on David's ppc-for-2.8 branch, and is also available > from: > > https://github.com/mdroth/qemu/commits/spapr-hotplug-event-update Applied to ppc-for-2.8. > > Changes since v1: > * Rebased on latest ppc-fo

[Qemu-devel] [Bug 1298442] Re: build problem in qemu-2.0.0-rc0 No rule to make target `trace/generated-events.h'

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1298442 Title: build probl

Re: [Qemu-devel] [PATCH v2 1/6] target-ppc: add xscmp[eq, gt, ge, ne]dp instructions

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:56:24AM +0530, Nikunj A Dadhania wrote: > From: Sandipan Das > > xscmpeqdp: VSX Scalar Compare Equal Double-Precision > xscmpgedp: VSX Scalar Compare Greater Than or Equal Double-Precision > xscmpgtdp: VSX Scalar Compare Greater Than Double-Precision > xscmpnedp: VSX Sc

Re: [Qemu-devel] [PATCH qemu] configure, ppc64: Copy skiboot.lid to build directory when configuring

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 01:18:03PM +1100, Alexey Kardashevskiy wrote: > When configured to compile out of tree, the configure script > copies BIOS blobs to the build directory. However since the PPC64 powernv > machine ROM has .lid extension, it is ignored and "make check" fails > when trying the p

Re: [Qemu-devel] [Qemu-ppc] [PATCH 14/15] target-ppc: Use tcg_gen_extract_*

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 08:38:06AM -0700, Richard Henderson wrote: > On 10/25/2016 07:59 PM, David Gibson wrote: > > On Sat, Oct 15, 2016 at 08:37:49PM -0700, Richard Henderson wrote: > >> Use the new primitives for RDWINM and RLDICL. > >> > >> Cc: qemu-...@nongnu.org > >> Signed-off-by: Richard He

[Qemu-devel] [Bug 1090558] Re: hw/mc146818: error reading RTC_HOURS_ALARM

2016-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090558 Title: hw/mc146818

Re: [Qemu-devel] [PATCH v5 11/17] ppc/xics: Add "native" XICS subclass

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 09:13:18AM +0200, Cédric Le Goater wrote: > On 10/25/2016 07:08 AM, David Gibson wrote: > > On Sat, Oct 22, 2016 at 11:46:44AM +0200, Cédric Le Goater wrote: > >> This provides access to the MMIO based Interrupt Presentation > >> Controllers (ICP) as found on a POWER8 system

Re: [Qemu-devel] [PATCH v2 6/6] target-ppc: Add xvcmpnesp, xvcmpnedp instructions

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:56:29AM +0530, Nikunj A Dadhania wrote: > From: Swapnil Bokade > > xvcmpnedp[.]: VSX Vector Compare Not Equal Double-Precision > xvcmpnesp[.]: VSX Vector Compare Not Equal Single-Precision > > Signed-off-by: Swapnil Bokade > Signed-off-by: Nikunj A Dadhania Applied

Re: [Qemu-devel] [PATCH v5 13/17] ppc/xics: add a xics_get_cpu_index_by_pir helper

2016-10-26 Thread David Gibson
On Tue, Oct 25, 2016 at 12:58:11PM +0200, Cédric Le Goater wrote: > On 10/25/2016 07:36 AM, David Gibson wrote: > > On Sat, Oct 22, 2016 at 11:46:46AM +0200, Cédric Le Goater wrote: > >> We will need this helper to translate the server number of the XIVE > >> (which is a PIR) into an ICPState index

Re: [Qemu-devel] [PATCH v2 2/6] bitops: fix rol/ror when shift is zero

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 08:20:10AM -0700, Richard Henderson wrote: > On 10/25/2016 11:26 PM, Nikunj A Dadhania wrote: > > All the variants for rol/ror have a bug in case where the shift == 0. > > For example rol32, would generate: > > > > return (word << 0) | (word >> 32); > > > > Which thoug

Re: [Qemu-devel] [PATCH v2 4/6] target-ppc: add vrldnm and vrlwnm instructions

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:56:27AM +0530, Nikunj A Dadhania wrote: > From: Bharata B Rao > > vrldnm: Vector Rotate Left Doubleword then AND with Mask > vrlwnm: Vector Rotate Left Word then AND with Mask > > Signed-off-by: Bharata B Rao > Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gib

Re: [Qemu-devel] [PATCH 0/2] ppc: Allow "-prom-env" parameter for the pseries machine, too

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 09:35:39AM +0200, Thomas Huth wrote: > Here's a slightly updated version of the patch that enables the "-prom-env" > parameter for the pseries machine. The code is now only executed if > nb_prom_envs > 0. That means if the user did _not_ specify a "-prom-env" > parameter, th

Re: [Qemu-devel] [PATCH] 1/4] target-ppc: Implement bcdcfn. instruction

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:18:55AM -0200, Jose Ricardo Ziviani wrote: > bcdcfn. converts from National numeric format to BCD. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by: Jos

Re: [Qemu-devel] [PATCH v2 17/18] target-ppc: Use the new deposit and extract ops

2016-10-26 Thread David Gibson
On Tue, Oct 18, 2016 at 08:10:30AM -0700, Richard Henderson wrote: > Use the new primitives for RDWINM and RLDICL. > > Signed-off-by: Richard Henderson Reviewed-by: David Gibson > --- > target-ppc/translate.c | 35 +++ > 1 file changed, 19 insertions(+), 16 del

Re: [Qemu-devel] [PATCH] 2/4] target-ppc: Implement bcdctn. instruction

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:18:56AM -0200, Jose Ricardo Ziviani wrote: > bcdctn. converts from BCD to National numeric format. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by: Jos

[Qemu-devel] [PATCH v2 2/3] exec.c: check memory backend file size with 'size' option

2016-10-26 Thread Haozhong Zhang
If the memory backend file is not large enough to hold the required 'size', Qemu will report error and exit. Signed-off-by: Haozhong Zhang --- exec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/exec.c b/exec.c index a2b371a..264a25f 100644 --- a/exec.c +++ b/exec.c @@ -1316,6 +131

[Qemu-devel] [PATCH v2 3/3] hostmem-file: make option 'size' optional

2016-10-26 Thread Haozhong Zhang
If 'size' option is not given, Qemu will use the file size of 'mem-path' instead. If an empty file, a non-existing file or a directory is specified by option 'mem-path', a non-zero option 'size' is still needed. Signed-off-by: Haozhong Zhang --- backends/hostmem-file.c | 28 -

Re: [Qemu-devel] [PATCH] 4/4] target-ppc: Implement bcdctz. instruction

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:18:58AM -0200, Jose Ricardo Ziviani wrote: > bcdctz. converts from BCD to Zoned numeric format. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. > > Signed-off-by: Jose Ricardo Ziviani

Re: [Qemu-devel] [PATCH] 3/4] target-ppc: Implement bcdcfz. instruction

2016-10-26 Thread David Gibson
On Wed, Oct 26, 2016 at 11:18:57AM -0200, Jose Ricardo Ziviani wrote: > bcdcfz. converts from Zoned numeric format to BCD. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. > > Signed-off-by: Jose Ricardo Ziviani

[Qemu-devel] [PATCH v2 0/3] Improve truncation behavior of memory-backend-file

2016-10-26 Thread Haozhong Zhang
For a mmeory backend file, e.g. -object memory-backend-file,mem-path=foo,size=SZ,... the size of the backend file 'foo' is specified by the 'size' option. If the specified size 'SZ' does not match the actual size of file 'foo', QEMU will truncate the backend file 'foo'. In certain usage scenari

[Qemu-devel] [PATCH v2 1/3] exec.c: do not truncate non-empty memory backend file

2016-10-26 Thread Haozhong Zhang
For '-object memory-backend-file,mem-path=foo,size=xyz', if the size of file 'foo' does not match the given size 'xyz', the current QEMU will truncate the file to the given size, which may corrupt the existing data in that file. To avoid such data corruption, this patch disables truncating non-empt

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [23:42:10], zhanghailiang wrote: > configure --enable-colo/--disable-colo to switch COLO > support on/off. > > COLO feature doesn't depend on any other external librariesis, typo: libraries Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 14/17] COLO: Implement the process of failover for primary VM

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [23:42:07], zhanghailiang wrote: > For primary side, if COLO gets failover request from users. > To be exact, gets 'x_colo_lost_heartbeat' command. > COLO thread will exit the loop while the failover BH does the > cleanup work and resumes VM. > > Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 10/17] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [23:42:03], zhanghailiang wrote: > Add checkpoint-delay parameter for migrate-set-parameters, so that > we can control the checkpoint frequency when COLO is in periodic mode. > > Cc: Luiz Capitulino > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 03/17] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [23:41:56], zhanghailiang wrote: > Add a new migration state: MIGRATION_STATUS_COLO. Migration source side > enters this state after the first live migration successfully finished > if COLO is enabled by command 'migrate_set_capability x-colo on'. > > We reuse migration thread

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 03/17] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [21:49:10], Hailiang Zhang wrote: > On 2016/10/26 12:50, Amit Shah wrote: > >On (Tue) 18 Oct 2016 [20:09:59], zhanghailiang wrote: > >>Add a new migration state: MIGRATION_STATUS_COLO. Migration source side > >>enters this state after the first live migration successfully finis

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a new communicating path for COLO

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [22:05:22], Hailiang Zhang wrote: > On 2016/10/26 13:06, Amit Shah wrote: > >On (Tue) 18 Oct 2016 [20:10:01], zhanghailiang wrote: > >>This new communication path will be used for returning messages > >>from Secondary side to Primary side. > >> > >>Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [08:42:27], Eric Blake wrote: > On 10/26/2016 01:07 AM, Amit Shah wrote: > > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: > >> configure --enable-colo/--disable-colo to switch COLO > >> support on/off. > >> COLO feature is enabled by default. > >> > >> Signed-off-by: z

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [23:52:48], Hailiang Zhang wrote: > Hi Amit, > > On 2016/10/26 16:26, Amit Shah wrote: > >On (Wed) 26 Oct 2016 [14:43:30], Hailiang Zhang wrote: > >>Hi Amit, > >> > >>On 2016/10/26 14:09, Amit Shah wrote: > >>>Hello, > >>> > >>>On (Tue) 18 Oct 2016 [20:09:56], zhanghailiang wr

Re: [Qemu-devel] [PATCH v5 4/9] record/replay: add network support

2016-10-26 Thread Jason Wang
On 2016年09月26日 16:08, Pavel Dovgalyuk wrote: This patch adds support of recording and replaying network packets in irount rr mode. Record and replay for network interactions is performed with the network filter. Each backend must have its own instance of the replay filter as follows: -netdev

Re: [Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-26 Thread Buddhi Madhav
On 10/25/16, 9:41 PM, "Jeff Cody" wrote: >On Tue, Oct 25, 2016 at 03:02:07PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.g

[Qemu-devel] "block: use aio_bh_schedule_oneshot" breaks ibm-vscsi

2016-10-26 Thread Alexey Kardashevskiy
Hi, I just discovered that fffb6e12233002c26c0ee9ff92fa87927cd779f2 broke ibm-vscsi, the guest booting stops (I waited for a minute) at: [0.809286] ibmvscsi 7101: SRP_VERSION: 16.a [0.809766] ibmvscsi 7101: Maximum ID: 64 Maximum LUN: 32 Maximum Channel: 3 [0.810059] scsi hos

Re: [Qemu-devel] [PATCH 1/4] e1000e: Use regular DEFINE_PROP_ macros for properties

2016-10-26 Thread Jason Wang
On 2016年10月27日 03:21, Eduardo Habkost wrote: Instead of hacking custom PropertyInfo structs, use the regular DEFINE_PROP_ macros for the e1000e properties. This also fixes a bug in the disable_vnet_hdr property definition, that was using qdev_prop_uint8 for a bool field. Signed-off-by: Eduard

[Qemu-devel] [PATCH v3 3/6] spapr: add hotplug interrupt machine options

2016-10-26 Thread Michael Roth
This adds machine options of the form: -machine pseries,modern-hotplug-events=true -machine pseries,modern-hotplug-events=false If false, QEMU will force the use of "legacy" style hotplug events, which are surfaced through EPOW events instead of a dedicated hot plug event source, and lack cer

[Qemu-devel] [PATCH v3 6/6] spapr: Memory hot-unplug support

2016-10-26 Thread Michael Roth
From: Bharata B Rao Add support to hot remove pc-dimm memory devices. Since we're introducing a machine-level unplug_request hook, we also had handling for CPU unplug there as well to ensure CPU unplug continues to work as it did before. Signed-off-by: Bharata B Rao * add hooks to CAS/cmdline

[Qemu-devel] [PATCH v3 4/6] spapr: Add DRC count indexed hotplug identifier type

2016-10-26 Thread Michael Roth
From: Bharata B Rao Add support for DRC count indexed hotplug ID type which is primarily needed for memory hot unplug. This type allows for specifying the number of DRs that should be plugged/unplugged starting from a given DRC index. Signed-off-by: Bharata B Rao * updated rtas_event_log_v6_hp

[Qemu-devel] [PATCH v3 5/6] spapr: use count+index for memory hotplug

2016-10-26 Thread Michael Roth
Commit 0a417869: spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type dropped per-DRC/per-LMB hotplugs event in favor of a bulk add via a single LMB count value. This was to avoid overrunning the guest EPOW event queue with hotplug events. This works fine, but relies on the guest ex

[Qemu-devel] [PATCH v3 1/6] spapr: update spapr hotplug documentation

2016-10-26 Thread Michael Roth
This updates the existing documentation to reflect recent updates to the hotplug event structure, which are in draft form but slated for inclusion in PAPR/LoPAPR. Signed-off-by: Michael Roth Reviewed-by: David Gibson --- docs/specs/ppc-spapr-hotplug.txt | 55 +---

[Qemu-devel] [PATCH v3 0/6] spapr: dedicated hotplug events and memory unplug support

2016-10-26 Thread Michael Roth
This series is based on David's ppc-for-2.8 branch, and is also available from: https://github.com/mdroth/qemu/commits/spapr-hotplug-event-update Changes since v2: * Rebased on latest ppc-for-2.8 * Fix silly screw up with Reviewed-by attributions Changes since v1: * Rebased on latest ppc

[Qemu-devel] [PATCH v3 2/6] spapr_events: add support for dedicated hotplug event source

2016-10-26 Thread Michael Roth
Hotplug events were previously delivered using an EPOW interrupt and were queued by linux guests into a circular buffer. For traditional EPOW events like shutdown/resets, this isn't an issue, but for hotplug events there are cases where this buffer can be exhausted, resulting in the loss of hotplug

Re: [Qemu-devel] [PATCH v2 05/17] target-m68k: add dbcc

2016-10-26 Thread Richard Henderson
On 10/26/2016 05:42 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 25 + 1 file changed, 25 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 04/17] target-m68k: add addressing modes to scc

2016-10-26 Thread Richard Henderson
On 10/26/2016 05:42 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 03/17] target-m68k: add exg ops

2016-10-26 Thread Richard Henderson
On 10/26/2016 05:42 PM, Laurent Vivier wrote: Suggested-by: Richard Henderson Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 30 ++ 1 file changed, 30 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 00/20] dataplane: remove RFifoLock

2016-10-26 Thread Fam Zheng
On Wed, 10/19 08:55, Fam Zheng wrote: > Reviewed-by: Fam Zheng FWIW in merging it: Acked-by: Fam Zheng

Re: [Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-26 Thread Jeff Cody
On Wed, Oct 26, 2016 at 09:33:30PM +, Buddhi Madhav wrote: > > > On 10/25/16, 9:41 PM, "Jeff Cody" wrote: > > >On Tue, Oct 25, 2016 at 03:02:07PM -0700, Ashish Mittal wrote: > >> This patch adds support for a new block device type called "vxhs". > >> Source code for the library that this co

[Qemu-devel] [PATCH] linux-user: manage two new IFLA host message types

2016-10-26 Thread Laurent Vivier
Add QEMU_IFLA_GSO_MAX_SEGS and QEMU_IFLA_GSO_MAX_SIZE in host_to_target_data_link_rtattr(). These two messages are sent by the host kernel when we use "sudo". Found with qemu-m68k and Debian etch-m68k (sudo 1.6.8p12-4) and host kernel 4.7.6-200.fc24.x86_64 Signed-off-by: Laurent Vivier --- lin

Re: [Qemu-devel] [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-10-26 Thread Li, Liang Z
> On 10/26/2016 03:06 AM, Li, Liang Z wrote: > > I am working on Dave's new bitmap schema, I have finished the part of > > getting the 'hybrid scheme bitmap' and found the complexity was more > > than I expected. The main issue is more memory is required to save the > > 'hybrid scheme bitmap' besid

[Qemu-devel] [PATCH v2 15/17] target-m68k: add/sub manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 73 +++-- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index f7e6920..0448569 100644 --- a/t

[Qemu-devel] [PATCH v2 14/17] target-m68k: add addressing modes to neg

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index aa09bd4..f7e6920 100644 --- a/target-m68k/translate.c +++ b/t

[Qemu-devel] [PATCH v2 17/17] target-m68k: immediate ops manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 57 ++--- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 57ac2e5..ee0ffe3 100644 --- a/t

[Qemu-devel] [PATCH v2 16/17] target-m68k: cmp manages word and bytes operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 0448569..57ac2e5 100644 --- a/target-m68k/translate.c +++ b/targ

[Qemu-devel] [PATCH v2 10/17] target-m68k: and can manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index a6aaf5e..3f7db83 100644 --- a/target-m68k/translate.c +++ b/targe

[Qemu-devel] [PATCH v2 08/17] target-m68k: eor can manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 031f7eb..9734d05 100644 --- a/target-m68k/translate.c +++ b/target-m6

[Qemu-devel] [PATCH v2 01/17] target-m68k: add bkpt instruction

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 6c6173a..a128b67 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -1639,6 +1639,11 @@ DISAS_INSN(swap)

[Qemu-devel] [PATCH v2 04/17] target-m68k: add addressing modes to scc

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index b407623..e595673 100644 --- a/target-m68k/translate.c +++ b/target-m68k/

[Qemu-devel] [PATCH v2 03/17] target-m68k: add exg ops

2016-10-26 Thread Laurent Vivier
Suggested-by: Richard Henderson Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 0d3111d..b407623 100644 --- a/target-m68k/translate.c +++ b/target

[Qemu-devel] [PATCH v2 13/17] target-m68k: introduce byte and word cc_ops

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/cpu.h | 6 +-- target-m68k/helper.c| 25 ++--- target-m68k/translate.c | 131 +++- 3 files changed, 93 insertions(+), 69 deletions(-) diff --git a/target-m68

[Qemu-devel] [PATCH v2 06/17] target-m68k: Inline addx, subx, negx

2016-10-26 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson And add opcodes for 680x0 Signed-off-by: Laurent Vivier --- target-m68k/helper.c| 40 -- target-m68k/helper.h| 2 - target-m68k/translate.c | 196 +++- 3 files changed, 178

[Qemu-devel] [PATCH v2 12/17] target-m68k: some bit ops cleanup

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index b82ebf3..cf9b228 100644 --- a/target-m68k/tran

[Qemu-devel] [PATCH v2 11/17] target-m68k: suba/adda can manage word operand

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 3f7db83..b82ebf3 100644 --- a/target-m68k/translate.c +++ b/target-m68k/transl

[Qemu-devel] [PATCH v2 02/17] target-m68k: add linkl

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index a128b67..0d3111d 100644 --- a/target-m68k/translate.c +

[Qemu-devel] [PATCH v2 09/17] target-m68k: or can manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 9734d05..a6aaf5e 100644 --- a/target-m68k/translate.c +++ b/target-m

[Qemu-devel] [PATCH v2 05/17] target-m68k: add dbcc

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 25 + 1 file changed, 25 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index e595673..1836a22 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -1105,6 +1105,30

[Qemu-devel] [PATCH v2 07/17] target-m68k: add addressing modes to not

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index fd6631d..031f7eb 100644 --- a/target-m68k/translate.c +++ b/target-

[Qemu-devel] [PATCH v2 00/17] 680x0 instruction set, part 1

2016-10-26 Thread Laurent Vivier
This series is another subset of the series I sent in May: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00501.html It must be applied on top of series: "target-m68k: prepare to introduce 680x0 instruction set" This subset contains: - all the patches reviewed by Richard that needed no

Re: [Qemu-devel] [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-10-26 Thread Li, Liang Z
> Cc: linux-ker...@vger.kernel.org; virtualizat...@lists.linux-foundation.org; > linux...@kvack.org; virtio-...@lists.oasis-open.org; k...@vger.kernel.org; > qemu-devel@nongnu.org; quint...@redhat.com; dgilb...@redhat.com; > pbonz...@redhat.com; cornelia.h...@de.ibm.com; amit.s...@redhat.com > Subj

Re: [Qemu-devel] [PATCH v3] char: cadence: check baud rate generator and divider values

2016-10-26 Thread Peter Maydell
On 26 October 2016 at 22:22, P J P wrote: > From: Prasad J Pandit > > The Cadence UART device emulator calculates speed by dividing the > baud rate by a 'baud rate generator' & 'baud rate divider' value. > The device specification defines these register values to be > non-zero and within certain

  1   2   3   4   5   6   >