On Wed, Oct 26, 2016 at 08:20:10AM -0700, Richard Henderson wrote: > On 10/25/2016 11:26 PM, Nikunj A Dadhania wrote: > > All the variants for rol/ror have a bug in case where the shift == 0. > > For example rol32, would generate: > > > > return (word << 0) | (word >> 32); > > > > Which though works, would be flagged as a runtime error on clang's > > sanitizer. > > > > Suggested-by: Richard Henderson <r...@twiddle.net> > > Signed-off-by: Nikunj A Dadhania <nik...@linux.vnet.ibm.com> > > --- > > include/qemu/bitops.h | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > Reviewed-by: Richard Henderson <r...@twiddle.net>
This looks fine to me too, but I'm not sure if it should be going via
my tree or not.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
