On Wed, Oct 05, 2016 at 03:06:53PM +0200, Radim Krčmář wrote:
> * there no point in configuring the device if realization is going to
> fail, so move the check to the beginning,
> * create a separate function for the check,
> * use error_setg() instead error_report().
>
> Reviewed-by: Igor Mamme
On Wed, Oct 05, 2016 at 03:06:52PM +0200, Radim Krčmář wrote:
> The MMIO interface to APIC only allowed 8 bit addresses, which is not
> enough for 32 bit addresses from EIM remapping.
> Intel stored upper 24 bits in the high MSI address, so use the same
> technique. The technique is also used in KV
On Wed, Oct 05, 2016 at 03:06:51PM +0200, Radim Krčmář wrote:
> The MMIO based interface to APIC doesn't work well with MSIs that have
> upper address bits set (remapped x2APIC MSIs). A specialized interface
> is a quick and dirty way to avoid the shortcoming.
>
> Reviewed-by: Igor Mammedov
> Si
On Wed, Oct 05, 2016 at 03:06:50PM +0200, Radim Krčmář wrote:
> Every configuration has only up to one APIC class and we'll be extending
> the class with a function that can be called without an instanced
> object, so a direct access to the class is convenient.
>
> This patch will break compilatio
On Sat, Oct 08, 2016 at 02:14:09PM +0800, Peter Xu wrote:
> On Fri, Oct 07, 2016 at 06:24:15PM +0200, Radim Krčmář wrote:
>
> [...]
>
> > KVM accepts the address in host endianess and QEMU/VTD code also uses
> > host endianess for internal representation of memory addresses, so this
> > hunk shou
On Fri, Oct 07, 2016 at 06:24:15PM +0200, Radim Krčmář wrote:
[...]
> KVM accepts the address in host endianess and QEMU/VTD code also uses
> host endianess for internal representation of memory addresses, so this
> hunk should be fine.
>
> It is confusing, because the VTD is definitely broken w
On Tue, Oct 04, 2016 at 01:17:28PM +0200, Igor Mammedov wrote:
> On Fri, 30 Sep 2016 18:10:08 +0200
> Radim Krčmář wrote:
>
> > The MMIO interface to APIC only allowed 8 bit addresses, which is not
> > enough for 32 bit addresses from EIM remapping.
> > Intel stored upper 24 bits in the high MSI
+-- On Fri, 7 Oct 2016, Peter Maydell wrote --+
| This is still losing the setting of gtb->status in the
| case where the auto-increment bit is not set.
Ah, I've sent a revised patch v4. Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
From: Prasad J Pandit
ARM A9MP processor has a peripheral timer with an auto-increment
register, which holds an increment step value. A user could set
this value to zero. When auto-increment control bit is enabled,
it leads to an infinite loop in 'a9_gtimer_update' while
updating comparator value
Hi Peter,
On Fri, Oct 7, 2016 at 7:50 PM, Peter Maydell wrote:
> On 19 July 2016 at 12:04, Peter Maydell wrote:
>> On 19 July 2016 at 12:01, Vijay Kilari wrote:
>>> Hi Peter,
>>>
>>> Any update on this patch set. Is it merged?
>>
>> No. It's an RFC patchset really, and it was posted during so
On 2016/9/23 12:59, herongguang wrote:
From: He Rongguang
handle KVM_VCPUEVENT_VALID_SMM properly, or kvm-kmod/kernel will crash
in migration destination in gfn_to_rmap() since kvm_memslots_for_spte_role
is false, whilst (vcpu->arch.hflags & HF_SMM_MASK) is true
Signed-off-by: herongguang
-
Hi Eric,
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Friday, October 07, 2016 3:48 AM
> Subject: Re: [Qemu-devel] [PATCH v5 14/14] cryptodev: rename cryptodev stuff
>
> On 10/06/2016 06:36 AM, Gonglei wrote:
> > Remove qcrypto and/or QCRYPTO prefix in order
On Fri, Oct 7, 2016 at 1:04 PM, Seth K wrote:
> I applied that patch, made qemu and ran my code, I didn't see a change.
>
> According to the STM32F20xxx memory map, the memory range seems to be 0x400
> -- UART 1 is listed as 0x4001 - 0x400103FF. Should that memory region be
> set to 0x400?
I
On 10/07/2016 04:48 PM, Jeff Cody wrote:
> Add checks to see if the system compiling QEMU has support for
> SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek
> data is unsupported in gluster.
>
> Note: this is not a check on whether the gluster server itself supports
> SEEK_DATA
Add checks to see if the system compiling QEMU has support for
SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek
data is unsupported in gluster.
Note: this is not a check on whether the gluster server itself supports
SEEK_DATA (that is already done during runtime), but rather if
Fill the "unavailable-features" field on the x86 implementation
of query-cpu-definitions.
Cc: Jiri Denemark
Cc: libvir-l...@redhat.com
Signed-off-by: Eduardo Habkost
---
Changes v5 -> v6:
* Call x86_cpu_filter_features(), now that x86_cpu_load_features()
won't run it automatically
Changes v4
This series extends query-cpu-definitions to include an extra
field: "unavailable-features". The new field can be used to find
out reasons that prevent the CPU model from running in the
current host.
This will return information based on the current machine and
accelerator only. In the future we m
When probing for CPU model information, we need to reuse the code
that initializes CPUID fields, but not the remaining side-effects
of x86_cpu_realizefn(). Move that code to a separate function
that can be reused later.
Signed-off-by: Eduardo Habkost
---
Changes v5 -> v6:
* Move x86_cpu_filter_fe
x86_cpu_filter_features() will be reused by code that shouldn't
print any warning. Move the warning code to a new
x86_cpu_report_filtered_features() function, and call it from
x86_cpu_realizefn().
Signed-off-by: Eduardo Habkost
---
Changes v5 -> v6:
* Recovered v3 of patch, because x86_cpu_load_f
On Fri, Sep 30, 2016 at 03:49:45PM -0300, Eduardo Habkost wrote:
> Add a new optional field to query-cpu-definitions schema:
> "unavailable-features". It will contain a list of QOM properties
> that prevent the CPU model from running in the current host.
>
> Cc: David Hildenbrand
> Cc: Michael Mu
On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> For now bitmap directory entry some times called 'bitmap header'. This
Awkward wording; maybe:
A bitmap directory entry is sometimes called a 'bitmap header'.
> patch leaves only one name - 'bitmap directory entry'. The name 'bitmap
>
On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> docs/specs/qcow2.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
> index 80cdfd0..d3e292f 100644
> --- a/do
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> Add autoclear bit for handling rewriting image by old qemu version.
"Add support for the autoclear bit [...]"?
>
> If autoclear bit is not set, but bitmaps extension is found it
> would not be loaded and warning will be generated.
"If t
I applied that patch, made qemu and ran my code, I didn't see a change.
According to the STM32F20xxx memory map, the memory range seems to be 0x400
-- UART 1 is listed as 0x4001 - 0x400103FF. Should that memory region
be set to 0x400?
I tried that too, no change yet, but maybe I should look a
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> This will not touch loaded bitmaps, as they are alredy removed from the
> image.
Well, yes, and I don't think that's ideal. :-)
I think marking them in_use instead of deleting them would be better.
Also, I'm not so sure whether this patc
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> Check bitmap header constraints as specified in docs/specs/qcow2.txt
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/qcow2-bitmap.c | 39 +++
> 1 file changed, 39 insertions(+)
I'd pull
On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Optional. Default is false.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Signed-off-by: Denis V. Lunev
> ---
> blockdev.c | 22 --
> qapi/block-core.json | 7 ++-
> qmp-commands.hx | 5 ++
On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add optional 'persistent' flag to qmp command block-dirty-bitmap-add.
> Default is false.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Signed-off-by: Denis V. Lunev
> ---
> blockdev.c | 12 +++-
> qapi/block-co
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> This flag means that the bitmap is now in use by the software or was not
> successfully saved. In any way, with this flag set the bitmap data must
> be considered inconsistent and should not be loaded.
>
> With current implementation this
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> New field BdrvDirtyBitmap.persistent means, that bitmap should be saved
> on bdrv_close, using format driver. Format driver should maintain bitmap
> storing.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block.c
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are
> loaded at image open and becomes BdrvDirtyBitmap's for corresponding
> drive. These bitmaps are deleted from Qcow2 image after loading to avoid
> conflicts.
>
> Extr
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> Realize block bitmap stroing interface, to allow qcow2 images store
> persistent bitmaps.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/qcow2-bitmap.c | 241
> +++
> block/
On Fri, 7 Oct 2016 10:46:22 +0530
Kirti Wankhede wrote:
> Ping..
>
> Pulling the questions at the top.
>
> >> Will libvirt report 'description' RO attribute, its output would be
> >> string, so that user could be able to see the configuration of that
> >> profile?
> >>
> >
> > Daniel,
> > Wai
Vector Integer Negate Instructions:
vnegw: Vector Negate Word
vnegd: Vector Negate Doubleword
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 2 ++
target-ppc/int_helper.c | 12
target-ppc/translate/vmx-impl.inc.c | 2 ++
target-ppc/translat
From: Sandipan Das
xscmpeqdp: VSX Scalar Compare Equal Double-Precision
xscmpgedp: VSX Scalar Compare Greater Than or Equal Double-Precision
xscmpgtdp: VSX Scalar Compare Greater Than Double-Precision
xscmpnedp: VSX Scalar Compare Not Equal Double-Precision
Signed-off-by: Sandipan Das
[ Fix LE
Add required helpers (GEN_XX2FORM_EO) for supporting this instruction.
xxbrh: VSX Vector Byte-Reverse Halfword
xxbrw: VSX Vector Byte-Reverse Word
xxbrd: VSX Vector Byte-Reverse Doubleword
xxbrq: VSX Vector Byte-Reverse Quadword
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate.c
Vector Extend Sign Instructions:
vextsb2w: Vector Extend Sign Byte To Word
vextsh2w: Vector Extend Sign Halfword To Word
vextsb2d: Vector Extend Sign Byte To Doubleword
vextsh2d: Vector Extend Sign Halfword To Doubleword
vextsw2d: Vector Extend Sign Word To Doubleword
Signed-off-by: Nikunj A Dadh
This series contains 15 new instructions for POWER9 ISA3.0
Vector Extend Sign
Vector Integer Negate
VSX Scalar Compare
Vector Byte-Reverse
Patches:
01:
vextsb2w: Vector Extend Sign Byte To Word
vextsh2w: Vector Extend Sign Halfword To Word
vextsb2d: Vector Extend Sign Byte
On Fri, Sep 30, 2016 at 03:49:34PM -0300, Eduardo Habkost wrote:
[...]
> Eduardo Habkost (12):
> tests: Add test case for x86 feature parsing compatibility
> target-i386: List CPU models using subclass list
> target-i386: Disable VME by default with TCG
> target-i386: Register aliases for f
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote:
>
>
> On 10/07/2016 05:08 AM, Dr. David Alan Gilbert wrote:
> > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote:
> >> Current migration code cannot handle some data structures such as
> >> QTAILQ in qemu/queue.h. Here we extend the signatures of pu
On 09/30/2016 06:00 PM, John Snow wrote:
Refactor backup_start as backup_job_create, which only creates the job,
but does not automatically start it. The old interface, 'backup_start',
is not kept in favor of limiting the number of nearly-identical iterfaces
that would have to be edited to keep
From: Marc-André Lureau
Unlike the other visit methods, visit_type_any() and visit_type_null()
neglect to check whether qmp_input_get_object() succeeded. They crash
when it fails. Reproducer:
{ "execute": "qom-set",
"arguments": { "path": "/machine", "property": "rtc-time" } }
Will crash wi
From: Marc-André Lureau
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
parameters, but the qapi qmp_dispatch() code uses
QERR_INVALID_PARAMETER_TYPE.
Improve qapi code to return QERR_MISSING_PARAMETER where
appropriate.
Fix expected error message in iotests.
Signed-off-b
From: Eduardo Habkost
Instead of requiring clients to actually call the query-cpu-*
commands to find out if they are implemented, remove them from
the output of "query-commands", so clients know they are not
available.
This is implemented by extending the existing hack at
qmp_unregister_commands
From: Marc-André Lureau
This helps to figure out the expectations.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
Message-Id: <20160930095948.3154-3-marcandre.lur...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/qmp-input-visitor.c | 1 +
1 f
The following changes since commit a65b6f27ce65e2e4f771f69d549ffa455a4d543a:
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20161004' into
staging (2016-10-04 18:57:12 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2016-10-07
fo
Peter Maydell writes:
> On 7 October 2016 at 13:09, Markus Armbruster wrote:
>> The following changes since commit a65b6f27ce65e2e4f771f69d549ffa455a4d543a:
>>
>> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20161004'
>> into staging (2016-10-04 18:57:12 +0100)
>>
>> are avail
QObject is fairly tightly coupled to QAPI these days, and I've been
effectively maintaining it together with QAPI for a while. Update
MAINTAINERS to reflect that.
Signed-off-by: Markus Armbruster
Message-Id: <1475084022-30117-3-git-send-email-arm...@redhat.com>
Acked-by: Luiz Capitulino
---
MA
From: Marc-André Lureau
Since commit ad739706bbadee49, user_creatable_add_type() expects to be
given a qdict. However, if object-add is called without props, you reach
the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type:
Assertion `qdict' failed.", because the qdict isn't creat
Missed in commit 7537fe0 and commit 9b89b6a.
Signed-off-by: Markus Armbruster
Message-Id: <1475766600-7273-1-git-send-email-arm...@redhat.com>
Reviewed-by: Eric Blake
---
docs/qmp-commands.txt | 2 +-
docs/writing-qmp-commands.txt | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(
Missed in commit d076a2a and commit bd6092e.
Signed-off-by: Markus Armbruster
Message-Id: <1474546563-16332-1-git-send-email-arm...@redhat.com>
Reviewed-by: Marc-André Lureau
---
docs/xen-save-devices-state.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/xen-save-de
David graciously volunteered to take this off Luiz's hands.
Signed-off-by: Markus Armbruster
Message-Id: <1475084022-30117-2-git-send-email-arm...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert
Acked-by: Luiz Capitulino
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Marc-André Lureau
qiv->root should not be null, make that clearer with some assert.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
Message-Id: <20160930095948.3154-2-marcandre.lur...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi/qmp-inp
These tests would have caught the bug fixed by the previous commit.
Signed-off-by: Markus Armbruster
Message-Id: <1475594630-24758-1-git-send-email-arm...@redhat.com>
---
tests/test-qmp-input-strict.c | 46 +++
1 file changed, 46 insertions(+)
diff --git
Marc-André Lureau writes:
> These 2 tests exhibit two qmp bugs fixed by the previous patches.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Daniel P. Berrange
> Reviewed-by: Eric Blake
Fails make check, dropping from today's pull request.
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/dirty-bitmap.c | 7 +++
> include/block/dirty-bitmap.h | 3 +++
> 2 files changed, 10 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digit
On 07/10/2016 18:38, Greg Kurz wrote:
> On Sat, 1 Oct 2016 20:56:02 +0200
> Laurent Vivier wrote:
>
>> This patch replaces calls to qtest_start() and qtest_end() by
>> calls to qtest_pc_boot() and qtest_shutdown().
>>
>> This allows to initialize memory allocator and PCI interface
>> functions
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> New field BdrvDirtyBitmap.persistent means, that bitmap should be saved
> on bdrv_close, using format driver. Format driver should maintain bitmap
> storing.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block.c
On 10/07/2016 10:34 AM, Dr. David Alan Gilbert wrote:
> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 10/07/2016 09:32 AM, Paolo Bonzini wrote:
>>>
>>>
>>> On 07/10/2016 18:31, Jianjun Duan wrote:
On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote:
> * Paolo Bo
On 10/07/2016 09:32 AM, Paolo Bonzini wrote:
>
>
> On 07/10/2016 18:31, Jianjun Duan wrote:
>>
>>
>> On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote:
>>> * Paolo Bonzini (pbonz...@redhat.com) wrote:
On 06/10/2016 21:01, Dr. David Alan Gilbert wrote:
+
On 10/07/2016 10:38 AM, Kevin Wolf wrote:
> Now that QAPI supports boxed types, we can have unions at the top level
> of a command, so let's put our real options directly there for
> blockdev-add instead of having a single "options" dict that contains the
> real arguments.
>
> blockdev-add is stil
Daniel P Berrange writes:
> On Fri, Oct 07, 2016 at 03:46:27PM +0200, Lluís Vilanova wrote:
>> Peter Maydell writes:
>>
>> > On 7 October 2016 at 11:09, Stefan Hajnoczi wrote:
>> >> The following changes since commit
>> >> e902754e3d0890945ddcc1b33748ed73762ddb8d:
>> >>
>> >> Merge remote-trac
On 10/06/2016 08:12 PM, David Gibson wrote:
> On Mon, Oct 03, 2016 at 11:24:53AM -0700, Jianjun Duan wrote:
>> To manage hotplug/unplug of dynamic resources such as PCI cards,
>> memory, and CPU on sPAPR guests, a firmware abstraction known as
>> a Dynamic Resource Connector (DRC) is used to assi
Split more parts into separate chapters, place comparison last,
rename "Introduction" to "CPU emulation".
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 171 +
1 file changed, 74 insertions(+), 97 deletions(-
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote:
>
>
> On 10/07/2016 09:32 AM, Paolo Bonzini wrote:
> >
> >
> > On 07/10/2016 18:31, Jianjun Duan wrote:
> >>
> >>
> >> On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote:
> >>> * Paolo Bonzini (pbonz...@redhat.com) wrote:
>
>
> O
Unlike the other sections, they are pretty specific to a particular CPU.
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 25 -
target-cris/cpu.h | 7 +++
target-i386/cpu.h | 7 +++
target-m68k/cpu.h | 8
target-s39
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be
> needed in future, to save this flag back to Qcow2 for persistent
> bitmaps.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/dirty-bitmap.c | 15 +
Merge what is left of qemu-tech into the main manual as an appendix.
Ultimately we should have a new internals manual built from docs/, and
then the "Translator Internals" parts of qemu-tech could move to docs/
as well. The bits on limitation and features of CPU emulation should
remain in qemu-doc
Quoting Stefan Hajnoczi (2016-10-06 11:40:18)
> Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-serial.
>
> $ qemu-system-x86_64 -device vhost-vsock-pci,guest-cid=3 ...
> (guest)# qemu-ga -m vsock-listen -p 3:1234
>
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Michael Roth
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 35 --
tests/tcg/README | 76
2 files changed, 76 insertions(+), 35 deletions(-)
create mode 100644 tests/tcg/README
diff --git a/qem
These are in README or obsolete, and the detailed version can be on a
website instead.
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
README| 2 -
qemu-doc.texi | 249 --
2 files changed, 251 deletions(-)
diff --gi
Drop most the device emulation part and merge the rest into the description
of the MMU. Make some bits more up-to-date.
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 124 +++--
1 file changed, 42 insertions(+),
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 12 ++--
tcg/README | 5 +
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/qemu-tech.texi b/qemu-tech.texi
index 2ab7cd4..082b62c 100644
--- a/qemu-tech.texi
+++ b/qemu-tech.texi
@@ -28
From: "Emilio G. Cota"
Sometimes gcc doesn't pick up the fact that 'new' is properly
set if 'resize == true', which may generate an unnecessary
build warning.
Fix it by removing 'resize' and directly checking that 'new'
is non-NULL.
Signed-off-by: Emilio G. Cota
Message-Id: <1475706880-10667-2
From: Tomáš Golembiovský
When --offset is set the apparent device size has to be adjusted
accordingly. Otherwise client may request read/write beyond the file end
which would fail.
Signed-off-by: Tomáš Golembiovský
Message-Id:
<8a31654cb182932db78b95aae1e904fc2bd1c465.1475698895.git.tgole...@r
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
qemu-tech.texi | 5 -
1 file changed, 5 deletions(-)
diff --git a/qemu-tech.texi b/qemu-tech.texi
index 1b048cb..be1c210 100644
--- a/qemu-tech.texi
+++ b/qemu-tech.texi
@@ -32,7 +32,6 @@
* Introduction::
* QEMU Internals::
* R
From: Alex Bennée
ThreadSanitizer detects a possible race between reading/writing the
hashes. The ordering semantics are already documented for QHT however
for true C11 compliance we should use relaxed atomic primitives for
accesses that are done across threads. On x86 this slightly changes to
th
The user manual has an obsolete introduction, and the one in
the internals manual lists QEMU's features quite nicely.
Drop the obsolete content and remove generic user-level
documentation from qemu-tech.
Reviewed-by: Emilio G. Cota
Signed-off-by: Paolo Bonzini
---
qemu-doc.texi | 84 ++
From: "Emilio G. Cota"
qht_lookup is meant to be called from an RCU read-critical
section. Make sure we're in such a section in test-qht
when performing lookups, despite the fact that no races
in qht can be triggered by test-qht since it is single-threaded.
Note that rcu_register_thread is alrea
These are interesting for users too, since nowadays most
qemu-user users are going to be somewhat technical rather than
just people that want to run Wine. Some detail is lost, on
the other hand some of the information I removed (e.g. basic
block unchaining) was obsolete.
Reviewed-by: Emilio G. Co
From: Michal Privoznik
This is a small helper that tries to fetch binary name for given
PID.
Signed-off-by: Michal Privoznik
Message-Id:
<4d75d475c1884f8e94ee8b1e57273ddf3ed68bf7.1474987617.git.mpriv...@redhat.com>
Signed-off-by: Paolo Bonzini
---
include/qemu/osdep.h | 10 ++
util/o
From: Hervé Poussineau
Signed-off-by: Hervé Poussineau
Message-Id: <1475437467-22781-1-git-send-email-hpous...@reactos.org>
Signed-off-by: Paolo Bonzini
---
hw/intc/i8259_common.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_co
From: Michal Privoznik
When qemu is being killed, its last words are:
2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from
pid 11180
That's nice, but what process is 11180? What if I told you we can
do better:
2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminatin
From: "Emilio G. Cota"
The old map's bucket locks are being unlocked *after*
that same old map has been passed to RCU for destruction.
This is a bug that can cause a segfault, since there's
no guarantee that the deletion will be deferred (e.g.
there may be no concurrent readers).
The segfault is
From: Alex Bennée
ThreadSanitizer picks up potential races although we already use
barriers to ensure things are in the correct order when processing exit
requests. For true C11 defined behaviour across threads we need to use
relaxed atomic_set/atomic_read semantics to reassure tsan.
Signed-off-
From: Alex Bennée
The ThreadSanitizer rightly complains that something initialised with a
normal access is later updated and read atomically.
Signed-off-by: Alex Bennée
Message-Id: <20160930213106.20186-8-alex.ben...@linaro.org>
Signed-off-by: Paolo Bonzini
---
qom/cpu.c | 6 +-
1 file ch
From: Alex Bennée
There is a potential race if several threads exit at once. To serialise
the exits extend the lock above the initial checking of the CPU list.
Signed-off-by: Alex Bennée
Message-Id: <20160930213106.20186-11-alex.ben...@linaro.org>
Signed-off-by: Paolo Bonzini
---
linux-user/s
From: Marc-André Lureau
In commit ac1b84dd1 (rhbz#1027181), a check was added to only update the
"read handler" when the front-end is opened, because the read callbacks
were not restored when a device is plugged. However, this seems not
correct, the handler is correctly set back on hotplug (in
vi
From: Alex Bennée
As it seems easy to break the ThreadSanitizer build we should defend it to
ensure that fixes get applied when it breaks. We use the Ubuntu GCC PPA
to get the latest GCC goodness.
As we need to use the -fuse-ld=gold work around we have to disable the
linux-user targets as these
From: Alex Bennée
The idiom CPU_GET_CLASS(cpu) is fairly extensively used in various
threads and trips of ThreadSanitizer due to the fact it updates
obj->class->object_cast_cache behind the scenes. As this is just a
fast-path cache there is no need to lock updates.
However to ensure defined C11
From: Alex Bennée
Add some notes on the use of the relaxed atomic access helpers and their
importance for defined behaviour in C11's multi-threaded memory model.
Signed-off-by: Alex Bennée
Message-Id: <20160930213106.20186-3-alex.ben...@linaro.org>
Signed-off-by: Paolo Bonzini
---
include/qem
From: Marc-André Lureau
mux_chr_update_read_handler() is adding a new mux_cnt each time
mux_chr_update_read_handler() is called, it's not possible to actually
update the "child" chr callbacks that were set previously. This may lead
to crashes if the "child" chr is destroyed:
valgrind x86_64-soft
From: Hervé Poussineau
Signed-off-by: Hervé Poussineau
Message-Id: <1474921408-24710-7-git-send-email-hpous...@reactos.org>
Signed-off-by: Paolo Bonzini
---
hmp-commands-info.hx | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
There is a data race if the sequence is written concurrently to the
read. In C11 this has undefined behavior. Use atomic_set; the
read side is already using atomic_read.
Reported-by: Alex Bennée
Signed-off-by: Paolo Bonzini
Signed-off-by: Alex Bennée
Message-Id: <20160930213106.20186-6-alex.b
From: Alex Bennée
This is to appease sanitizer builds which complain that:
"error: control reaches end of non-void function"
Signed-off-by: Alex Bennée
Reviewed-by: Marc-André Lureau
Message-Id: <20160930213106.20186-5-alex.ben...@linaro.org>
Signed-off-by: Paolo Bonzini
---
tcg/optimize.
From: Alex Bennée
The guest client's use of the glib's g_atomic primitives causes newer
GCC's to barf when built on Travis. As QEMU has its own primitives with
well understood semantics we might as well use them.
The use of atomics was a little inconsistent so I've also ensure the
values are cor
From: Hervé Poussineau
Signed-off-by: Hervé Poussineau
Message-Id: <1474921408-24710-6-git-send-email-hpous...@reactos.org>
Signed-off-by: Paolo Bonzini
---
hmp-commands-info.hx | 12 -
hmp.c | 65 ++
hmp.h
From: Hervé Poussineau
Acked-by: Artyom Tarasenko
Signed-off-by: Hervé Poussineau
Message-Id: <1474921408-24710-4-git-send-email-hpous...@reactos.org>
Signed-off-by: Paolo Bonzini
---
hw/intc/slavio_intctl.c | 35 +++
1 file changed, 35 insertions(+)
diff --gi
From: Peter Xu
So now edu device can support both line or msi interrupt, depending on
how user configures it.
Signed-off-by: Peter Xu
Message-Id: <1475067819-21413-1-git-send-email-pet...@redhat.com>
Signed-off-by: Paolo Bonzini
---
docs/specs/edu.txt | 7 ++-
hw/misc/edu.c | 18 +++
From: Alex Bennée
Only very modern GCC's actually set this define when building with the
ThreadSanitizer so this little typo slipped though.
Signed-off-by: Alex Bennée
Message-Id: <20160930213106.20186-2-alex.ben...@linaro.org>
Signed-off-by: Paolo Bonzini
---
include/qemu/atomic.h | 2 +-
1
1 - 100 of 302 matches
Mail list logo
