On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > --- > blockdev.c | 12 +++++++++++- > qapi/block-core.json | 7 ++++++- > qmp-commands.hx | 5 ++++-
This and later patches have conflicts with recent changes in the tree
that removed qmp-commands.hx; hopefully shouldn't impact review of this
series too badly.
> +++ b/qapi/block-core.json
> @@ -1235,10 +1235,15 @@
> # @granularity: #optional the bitmap granularity, default is 64k for
> # block-dirty-bitmap-add
> #
> +# @persistent: #optional the bitmap is persistent, i.e. it will be saved to
> +# corresponding block device on it's close. Default is false.
s/corresponding/the corresponding/
s/it's/its/
("it's" is only appropriate if you can substitute "it is" or "it has")
> @@ -1458,6 +1458,9 @@ Arguments:
> - "node": device/node on which to create dirty bitmap (json-string)
> - "name": name of the new dirty bitmap (json-string)
> - "granularity": granularity to track writes with (int, optional)
> +- "persistent": bitmap will be saved to corresponding block device
> + on it's close. Block driver should maintain persistent
> bitmaps
One nice benefit of rebasing on top of qmp-commands.hx being removed is
that you don't have to repeat yourself :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
