[Qemu-devel] [PATCH v2] scsi: check page count while initialising descriptor rings

2016-08-30 Thread P J P
From: Prasad J Pandit Vmware Paravirtual SCSI emulation uses command descriptors to process SCSI commands. These descriptors come with their ring buffers. A guest could set the page count for these rings to an arbitrary value, leading to infinite loop or OOB access. Add check to avoid it. Report

Re: [Qemu-devel] [PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-08-30 Thread Li, Liang Z
Hi Michael, I know you are very busy. If you have time, could you help to take a look at this patch set? Thanks! Liang > -Original Message- > From: Li, Liang Z > Sent: Thursday, August 18, 2016 9:06 AM > To: Michael S. Tsirkin > Cc: virtualizat...@lists.linux-foundation.org; linux...@kv

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-08-30 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, August 31, 2016 12:17 AM > > Hi folks, > > At KVM Forum we had a BoF session primarily around the mediated device > sysfs interface. I'd like to share what I think we agreed on and the > "problem areas" that still nee

[Qemu-devel] [ANNOUNCE] QEMU 2.7.0-rc5 is now available

2016-08-30 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the sixth release candidate for the QEMU 2.7 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.7.0-rc5.tar.bz2 http://wiki.qe

Re: [Qemu-devel] [PATCH for 2.8 07/11] virtio-pci: address space translation service (ATS) support

2016-08-30 Thread Jason Wang
On 2016年08月30日 21:21, Peter Xu wrote: On Tue, Aug 30, 2016 at 11:06:55AM +0800, Jason Wang wrote: [...] +/* Type 2: Root Port ATS Capability Reporting Structure */ +struct AcpiDmarRootPortATS { +uint16_t type; +uint16_t length; +uint8_t flags; +uint8_t reserved; +uint16_t

Re: [Qemu-devel] [PATCH for 2.8 06/11] intel_iommu: support device iotlb descriptor

2016-08-30 Thread Jason Wang
On 2016年08月30日 21:16, Peter Xu wrote: On Tue, Aug 30, 2016 at 11:06:54AM +0800, Jason Wang wrote: This patch enables device IOTLB support for intel iommu. The major work is to implement QI device IOTLB descriptor processing and notify the device through iommu notifier. IMHO it'll be nicer if

Re: [Qemu-devel] [PATCH for 2.8 02/11] virtio: convert to use DMA api

2016-08-30 Thread Jason Wang
On 2016年08月30日 15:31, Cornelia Huck wrote: On Tue, 30 Aug 2016 11:06:50 +0800 Jason Wang wrote: Currently, all virtio devices bypass IOMMU completely. This is because address_space_memory is assumed and used during DMA emulation. This patch converts the virtio core API to use DMA API. This i

Re: [Qemu-devel] [PATCH for 2.8 10/11] Revert "intel_iommu: Throw hw_error on notify_started"

2016-08-30 Thread Jason Wang
On 2016年08月30日 11:37, Alex Williamson wrote: On Tue, 30 Aug 2016 11:06:58 +0800 Jason Wang wrote: From: Peter Xu This reverts commit 3cb3b1549f5401dc3a5e1d073e34063dc274136f. Vhost device IOTLB API will get notified and send invalidation request to vhost through this notifier. AFAICT this

Re: [Qemu-devel] [PATCH v4 1/3] 9pfs: forbid illegal path names

2016-08-30 Thread Aneesh Kumar K.V
Eric Blake writes: > [ Unknown signature status ] > On 08/30/2016 12:11 PM, Greg Kurz wrote: >> Empty path components don't make sense for most commands and may cause >> undefined behavior, depending on the backend. >> >> Also, the walk request described in the 9P spec [1] clearly shows that >>

Re: [Qemu-devel] [PATCH] block: Allow node name for 'qemu-io' HMP command

2016-08-30 Thread Eric Blake
On 08/19/2016 11:46 AM, Kevin Wolf wrote: > When using a node name, create a temporary BlockBackend that is used to > run the qemu-io command. > > Signed-off-by: Kevin Wolf > --- > hmp.c | 13 + > 1 file changed, 13 insertions(+) Reviewed-by: Eric Blake -- Eric Blake eblake red

Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object

2016-08-30 Thread Benjamin Herrenschmidt
On Tue, 2016-08-30 at 02:28 -0400, David Gibson wrote: > No.. the PIR itself is a cpu level construct (and we already have a > place for that in the cpu state).  The DT id as such isn't, although > it happens to have the same value.  The fact it has the same value is > itself a machine type propert

Re: [Qemu-devel] [RFC] target-i386: present virtual L3 cache info for vcpus

2016-08-30 Thread Longpeng (Mike)
Hi Eduardo, On 2016/8/30 22:25, Eduardo Habkost wrote: > On Mon, Aug 29, 2016 at 09:17:02AM +0800, Longpeng (Mike) wrote: >> This patch presents virtual L3 cache info for virtual cpus. > > Just changing the L3 cache size in the CPUID code will make > guests see a different cache topology after u

Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object

2016-08-30 Thread David Gibson
On Tue, Aug 30, 2016 at 04:15:35PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-08-29 at 10:30 -0400, David Gibson wrote: > > > > Possibly.  In fact, I'm planning to eliminate cpu->cpu_dt_id at some > > point, in favour of having the machine type construct the id when it > > actually builds

[Qemu-devel] [Bug 1617114] Re: Qemu 2.6.0 freezes with windows guests

2016-08-30 Thread Javier
Tested 2.6.1, fails/freezes the same way, :-( -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1617114 Title: Qemu 2.6.0 freezes with windows guests Status in QEMU: New Bug description: When lau

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: use native disk xenbus protocol if possible

2016-08-30 Thread Stefano Stabellini
On Tue, 30 Aug 2016, Juergen Gross wrote: > On 05/07/16 16:55, Stefano Stabellini wrote: > > On Wed, 29 Jun 2016, Anthony PERARD wrote: > >> On Wed, Jun 29, 2016 at 05:50:48PM +0200, Juergen Gross wrote: > >>> The qdisk implementation is using the native xenbus protocol only in > >>> case of no pro

[Qemu-devel] Op blockers notes from KVM Forum

2016-08-30 Thread Stefan Hajnoczi
At KVM Forum Jeff Cody, John Snow, Denis Lunev, Markus Armbruster, Max Reitz, and I discussed the next steps for planned the op blockers enhancement work. The idea is to make op blockers more powerful and usable outside the block layer. The following action items were agreed upon to start this wo

[Qemu-devel] [Bug 1617114] Re: Qemu 2.6.0 freezes with windows guests

2016-08-30 Thread John Snow
Can you please try with 2.6.1 or 2.7.0-rc4? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1617114 Title: Qemu 2.6.0 freezes with windows guests Status in QEMU: New Bug description: When launc

Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field

2016-08-30 Thread Denis V. Lunev
On 08/30/2016 10:54 PM, Stefan Hajnoczi wrote: > On Mon, Aug 22, 2016 at 10:00 AM, Denis V. Lunev > wrote: >> On 08/15/2016 08:54 AM, Stefan Hajnoczi wrote: >>> The VirtQueue->inuse field is not always updated correctly. These patches >>> fix >>> it. >>> >>> Originally this series was called "vir

[Qemu-devel] [Bug 1616706] Re: watchdog doesn't bring down the VM

2016-08-30 Thread John Snow
qemu-kvm-1.5.3-105.el7 isn't supported by the upstream community; if you need support with this Red Hat version, you'll have to go through Red Hat. The most recent version of qemu supported upstream is 2.6.1 and soon, 2.7.0. -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [PATCH] scsi: check page count while initialising descriptor rings

2016-08-30 Thread P J P
From: Prasad J Pandit Vmware Paravirtual SCSI emulation uses command descriptors to process SCSI commands. These descriptors come with their ring buffers. A guest could set the page count for these rings to be zero, leading to an infinite loop. Add check to avoid it. Reported-by: Tom Victor Sig

Re: [Qemu-devel] [QEMU PATCH v4 0/6] migration: ensure hotplug and migration work together

2016-08-30 Thread Jianjun Duan
Hi Amit, Have you had a chance to take a look? Thanks, Jianjun On 07/08/2016 03:18 AM, Amit Shah wrote: > Hi, > > I'm going to go through this series soon, and I know Dave is too. > Please give us some time to go through it. > > Thanks, > > On (Mon) 27 Jun 2016 [09:59:58], Jianjun Duan wrot

Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field

2016-08-30 Thread Stefan Hajnoczi
On Mon, Aug 22, 2016 at 10:00 AM, Denis V. Lunev wrote: > On 08/15/2016 08:54 AM, Stefan Hajnoczi wrote: >> >> The VirtQueue->inuse field is not always updated correctly. These patches >> fix >> it. >> >> Originally this series was called "virtio-balloon: fix stats vq migration" >> but >> Ladi Pr

Re: [Qemu-devel] [PATCH v4 0/3] 9pfs security fixes

2016-08-30 Thread Peter Maydell
On 30 August 2016 at 14:29, Peter Maydell wrote: > On 30 August 2016 at 18:10, Greg Kurz wrote: >> As reported by Felix Wilhelm, at various places in 9pfs, full paths are >> created by concatenating a guest originated string to the export path. A >> malicious guest could forge a relative path and

Re: [Qemu-devel] [PATCH v4 1/3] 9pfs: forbid illegal path names

2016-08-30 Thread Greg Kurz
On Tue, 30 Aug 2016 13:03:40 -0500 Eric Blake wrote: > On 08/30/2016 12:11 PM, Greg Kurz wrote: > > Empty path components don't make sense for most commands and may cause > > undefined behavior, depending on the backend. > > > > Also, the walk request described in the 9P spec [1] clearly shows t

Re: [Qemu-devel] [PATCH v4 2/5] target-ppc: add vector extract instructions

2016-08-30 Thread Richard Henderson
On 08/24/2016 06:00 AM, Rajalakshmi Srinivasaraghavan wrote: +void helper_vextract##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t index) \ +{\ +memmove(&r->u8[8 - sizeof(r->element)], &b->u8[index],

Re: [Qemu-devel] [PATCH v4 2/3] 9pfs: forbid . and .. in file names

2016-08-30 Thread Greg Kurz
On Tue, 30 Aug 2016 13:06:31 -0500 Eric Blake wrote: > On 08/30/2016 12:13 PM, Greg Kurz wrote: > > According to the 9P spec http://man.cat-v.org/plan_9/5/open about the > > create request: > > > > The names . and .. are special; it is illegal to create files with these > > names. > > > > This

[Qemu-devel] [PATCH v4 3/3] 9pfs: handle walk of ".." in the root directory

2016-08-30 Thread Greg Kurz
The 9P spec at http://man.cat-v.org/plan_9/5/intro says: All directories must support walks to the directory .. (dot-dot) meaning parent directory, although by convention directories contain no explicit entry for .. or . (dot). The parent of the root directory of a server's tree is itself. This

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread John Snow
On 08/30/2016 08:57 AM, Peter Maydell wrote: On 30 August 2016 at 13:48, Paolo Bonzini wrote: I think this is expected to some extent. Is it worth moving tests to many tests subdirectories, e.g. hw/scsi/tests? Many files would be covered automatically. Moving tests around in order to incr

Re: [Qemu-devel] [PATCH v4 0/3] 9pfs security fixes

2016-08-30 Thread Peter Maydell
On 30 August 2016 at 18:10, Greg Kurz wrote: > As reported by Felix Wilhelm, at various places in 9pfs, full paths are > created by concatenating a guest originated string to the export path. A > malicious guest could forge a relative path and access files outside the > export path. > > A tentativ

Re: [Qemu-devel] [PATCH v4 0/3] 9pfs security fixes

2016-08-30 Thread Michael S. Tsirkin
On Tue, Aug 30, 2016 at 07:10:47PM +0200, Greg Kurz wrote: > As reported by Felix Wilhelm, at various places in 9pfs, full paths are > created by concatenating a guest originated string to the export path. A > malicious guest could forge a relative path and access files outside the > export path. >

Re: [Qemu-devel] [PATCH v4 2/3] 9pfs: forbid . and .. in file names

2016-08-30 Thread Eric Blake
On 08/30/2016 12:13 PM, Greg Kurz wrote: > According to the 9P spec http://man.cat-v.org/plan_9/5/open about the > create request: > > The names . and .. are special; it is illegal to create files with these > names. > > This patch causes the create and lcreate requests to fail with EINVAL if > t

Re: [Qemu-devel] [PATCH v4 1/3] 9pfs: forbid illegal path names

2016-08-30 Thread Eric Blake
On 08/30/2016 12:11 PM, Greg Kurz wrote: > Empty path components don't make sense for most commands and may cause > undefined behavior, depending on the backend. > > Also, the walk request described in the 9P spec [1] clearly shows that > the client is supposed to send individual path components:

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-30 Thread Jeff Cody
First-pass-over-the-code review: On Mon, Aug 22, 2016 at 11:56:30PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git > > Sample

Re: [Qemu-devel] [PULL v2 0/2] Last minute changes for 2.7.0-rc5

2016-08-30 Thread Peter Maydell
On 30 August 2016 at 17:07, Paolo Bonzini wrote: > The following changes since commit 135a972b45203ba992afc99ef4f061be8a5acae0: > > translate: early exit in tb_flush if there is no tcg (2016-08-30 13:30:55 > +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.

[Qemu-devel] [PATCH v4 2/3] 9pfs: forbid . and .. in file names

2016-08-30 Thread Greg Kurz
According to the 9P spec http://man.cat-v.org/plan_9/5/open about the create request: The names . and .. are special; it is illegal to create files with these names. This patch causes the create and lcreate requests to fail with EINVAL if the file name is either "." or "..". Even if it isn't exp

[Qemu-devel] [PATCH v4 0/3] 9pfs security fixes

2016-08-30 Thread Greg Kurz
As reported by Felix Wilhelm, at various places in 9pfs, full paths are created by concatenating a guest originated string to the export path. A malicious guest could forge a relative path and access files outside the export path. A tentative fix was sent recently by Prasad J Pandit, but it was on

[Qemu-devel] [PATCH v4 1/3] 9pfs: forbid illegal path names

2016-08-30 Thread Greg Kurz
Empty path components don't make sense for most commands and may cause undefined behavior, depending on the backend. Also, the walk request described in the 9P spec [1] clearly shows that the client is supposed to send individual path components: the official linux client never sends portions of p

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-08-30 Thread Dan Williams
On Mon, Aug 29, 2016 at 11:53 PM, Xiao Guangrong wrote: > > > On 08/30/2016 03:30 AM, Ross Zwisler wrote: > >> >> Can you please verify that you are using "usable" memory for your memmap? >> All >> the details are here: >> >> >> https://nvdimm.wiki.kernel.org/how_to_choose_the_correct_memmap_kerne

Re: [Qemu-devel] [PATCH v2 5/5] 9p: forbid empty extension string

2016-08-30 Thread Greg Kurz
On Mon, 29 Aug 2016 14:35:07 -0500 Eric Blake wrote: > On 08/28/2016 12:34 PM, Greg Kurz wrote: > > >> > >> For the sake of simplicity, I'd rather have the target names to follow the > >> same rules as other file names, and return ENOENT directly (the link you > >> provide states it is a valid o

Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-08-30 Thread Alex Williamson
Hi folks, At KVM Forum we had a BoF session primarily around the mediated device sysfs interface. I'd like to share what I think we agreed on and the "problem areas" that still need some work so we can get the thoughts and ideas from those who weren't able to attend. DanPB expressed some concern

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: use native disk xenbus protocol if possible

2016-08-30 Thread Juergen Gross
On 05/07/16 16:55, Stefano Stabellini wrote: > On Wed, 29 Jun 2016, Anthony PERARD wrote: >> On Wed, Jun 29, 2016 at 05:50:48PM +0200, Juergen Gross wrote: >>> The qdisk implementation is using the native xenbus protocol only in >>> case of no protocol specified at all. As using the explicit 32- or

Re: [Qemu-devel] Can't open boot device for Solaris 8

2016-08-30 Thread Phillip Shin
I still get the same prom_panic with that command. I reconfigured with --target-list=i386-softmmu and remade QEMU before trying the command. Thoughts?

Re: [Qemu-devel] [PATCH v2] atomics: Use __atomic_*_n() variant primitives

2016-08-30 Thread Richard Henderson
On 08/29/2016 10:17 AM, Pranith Kumar wrote: #define atomic_read(ptr) \ ({\ QEMU_BUILD_BUG_ON(sizeof(*ptr) > sizeof(void *)); \ -typeof_strip_qual(*ptr) _val; \ - __atomic_load(ptr,

[Qemu-devel] [PULL v2 0/2] Last minute changes for 2.7.0-rc5

2016-08-30 Thread Paolo Bonzini
The following changes since commit 135a972b45203ba992afc99ef4f061be8a5acae0: translate: early exit in tb_flush if there is no tcg (2016-08-30 13:30:55 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 336d5881a

Re: [Qemu-devel] [PULL 0/2] Last minute fixes for 2.7.0-rc5

2016-08-30 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/2] Last minute fixes for 2.7.0-rc5 Type: series Message-id: 1472572593-86410-1-git-send-email-pbonz...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 to

[Qemu-devel] [PULL 0/2] Last minute fixes for 2.7.0-rc5

2016-08-30 Thread Paolo Bonzini
The following changes since commit 135a972b45203ba992afc99ef4f061be8a5acae0: translate: early exit in tb_flush if there is no tcg (2016-08-30 13:30:55 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git for you to fetch changes up to 336d5881a927cd80e8c0ff61c7

[Qemu-devel] [PULL 2/2] optionrom: cope with multiple -O options

2016-08-30 Thread Paolo Bonzini
Reproducer: CFLAGS="-g3 -O0" ./configure --target-list=aarch64-softmmu,arm-softmmu --enable-vhost-net --enable-virtfs Here CFLAGS ends up with "-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 ... -g3 -O0" and pc-bios/optionrom/Makefile forgets to add the -O2 it needs. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 1/2] Revert "Change net/socket.c to use socket_*() functions"

2016-08-30 Thread Paolo Bonzini
Since commit 7e8449594c929, the socket connect code is blocking, because calling socket_connect() without callback is blocking. This reverts the commit. Signed-off-by: Paolo Bonzini --- net/socket.c | 55 --- 1 file changed, 28 insertions(+),

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:44, Markus Armbruster wrote: >> > There is no limit in the SCSI spec. 20 was copy-pasted from virtio-blk >> > which in turn was copy-pasted from ATA. So 36 is even more arbitrary, >> > but bumping it up too much might cause issues (e.g. who knows there's no >> > off-by-one some

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 17:29, Markus Armbruster wrote: > > > > Active subsystems lacking a maintainer include tilegx, qdev, replay. > > > > > > You, Eduardo, me? > > > > FWIW I was referring to qdev. > > Jointly? A subset not including me would also be fine. But since the git fallback still exists, and

Re: [Qemu-devel] [PATCH v3 1/3] 9pfs: forbid illegal path names

2016-08-30 Thread Greg Kurz
I forgot to pass --edit-patches to stg mail and some mails managed to get away before I hit ^C :\ Please ignore this thread: <147256918576.23038.4177640830854859642.st...@bahia.lab.toulouse-stg.fr.ibm.com> and look at this one instead: <147256922286.23141.1863740247797922944.st...@bahia.lab.tou

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 30/08/2016 14:48, Paolo Bonzini wrote: >> > Active subsystems lacking a maintainer include tilegx, qdev, replay. >> >> You, Eduardo, me? > > FWIW I was referring to qdev. Jointly? [...]

Re: [Qemu-devel] Can't open boot device for Solaris 8

2016-08-30 Thread Artyom Tarasenko
On Tue, Aug 30, 2016 at 4:23 PM, Phillip Shin wrote: > Thanks that starts a new window and boots! Then it reaches: > SunOS Secondary Boot Version 3.00 > > prom_panic: Could not mount filesystem. > > Entering boot debugger: > [131085]: > > Thoughts on this issue? I've looked at a similar thread fro

[Qemu-devel] [PATCH v3 1/3] 9pfs: forbid illegal path names

2016-08-30 Thread Greg Kurz
Empty path components don't make sense for most commands and may cause undefined behavior, depending on the backend. A notable exception would be the target of a symbolic link: POSIX requires implementations to support the empty string for target names. But 9p is only supported on linux hosts, whic

[Qemu-devel] [PATCH v3 0/3] 9P security fixes

2016-08-30 Thread Greg Kurz
As reported by Felix Wilhelm, at various places in 9pfs, full paths are created by concatenating a guest originated string to the export path. A malicious guest could forge a relative path and access files outside the export path. A tentative fix was sent recently by Prasad J Pandit, but it was on

[Qemu-devel] [PATCH v3 3/3] 9pfs: handle walk of ".." in the root directory

2016-08-30 Thread Greg Kurz
The 9P spec at http://man.cat-v.org/plan_9/5/intro says: All directories must support walks to the directory .. (dot-dot) meaning parent directory, although by convention directories contain no explicit entry for .. or . (dot). The parent of the root directory of a server's tree is itself. This

Re: [Qemu-devel] [PATCH 08/29] qcow2-bitmap: delete bitmap from qcow2 after load

2016-08-30 Thread Vladimir Sementsov-Ogievskiy
On 11.08.2016 16:18, Kevin Wolf wrote: Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben: If we load bitmap for r/w bds, it's data in the image should be considered inconsistent from this point. Therefore it is safe to remove it from the image. Signed-off-by: Vladimir Sementso

[Qemu-devel] [PATCH v3 2/3] 9pfs: forbid . and .. in file names

2016-08-30 Thread Greg Kurz
According to the 9P spec http://man.cat-v.org/plan_9/5/open about the create request: The names . and .. are special; it is illegal to create files with these names. This patch causes the create and lcreate requests to fail with EINVAL if the file name is either "." or "..". Even if it isn't exp

[Qemu-devel] [PATCH v3 0/3] 9P security fixes

2016-08-30 Thread Greg Kurz
As reported by Felix Wilhelm, at various places in 9pfs, full paths are created by concatenating a guest originated string to the export path. A malicious guest could forge a relative path and access files outside the export path. A tentative fix was sent recently by Prasad J Pandit, but it was on

[Qemu-devel] [PATCH v3 1/3] 9pfs: forbid illegal path names

2016-08-30 Thread Greg Kurz
Empty path components don't make sense for most commands and may cause undefined behavior, depending on the backend. A notable exception would be the target of a symbolic link: POSIX requires implementations to support the empty string for target names. But 9p is only supported on linux hosts, whic

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:48, Paolo Bonzini wrote: > > Active subsystems lacking a maintainer include tilegx, qdev, replay. > > You, Eduardo, me? FWIW I was referring to qdev. As to replay, it is mostly by Pavel but the remaining changes would need review by the relevant maintainers (e.g. USB for USB r

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 03/10] arm/arm64: smp: support more than 8 cpus

2016-08-30 Thread Auger Eric
Hi Drew, Proper commit message? ... also selects the vgic model corresponding to the host > Reviewed-by: Alex Bennée > Signed-off-by: Andrew Jones > --- > arm/run | 19 --- > arm/selftest.c| 5 - > lib/arm/asm/processor.h | 9 +++-- > li

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 02/10] arm64: fix get_"sysreg32" and make MPIDR 64bit

2016-08-30 Thread Auger Eric
Hi, On 15/07/2016 15:00, Andrew Jones wrote: > mrs is always 64bit, so we should always use a 64bit register. > Sometimes we'll only want to return the lower 32, but not for > MPIDR, as that does define fields in the upper 32. > > Reviewed-by: Alex Bennée > Signed-off-by: Andrew Jones > --- >

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 01/10] lib: xstr: allow multiple args

2016-08-30 Thread Auger Eric
Hi Drew, On 15/07/2016 15:00, Andrew Jones wrote: > Make implementation equivalent to Linux's include/linux/stringify.h > > Signed-off-by: Andrew Jones > --- > lib/libcflat.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/libcflat.h b/lib/libcflat.h > index 72

Re: [Qemu-devel] [RFC] target-i386: present virtual L3 cache info for vcpus

2016-08-30 Thread Eduardo Habkost
On Mon, Aug 29, 2016 at 09:17:02AM +0800, Longpeng (Mike) wrote: > This patch presents virtual L3 cache info for virtual cpus. Just changing the L3 cache size in the CPUID code will make guests see a different cache topology after upgrading QEMU (even on live migration). If you want to change the

Re: [Qemu-devel] Can't open boot device for Solaris 8

2016-08-30 Thread Phillip Shin
Thanks that starts a new window and boots! Then it reaches: SunOS Secondary Boot Version 3.00 prom_panic: Could not mount filesystem. Entering boot debugger: [131085]: Thoughts on this issue? I've looked at a similar thread from 2004 but it didn't help much.

Re: [Qemu-devel] [PATCH v2 1/2] crypto: fix building complaint

2016-08-30 Thread Peter Maydell
On 30 August 2016 at 15:14, Eric Blake wrote: > On 08/29/2016 11:10 PM, Gonglei wrote: >> gnutls commit 846753877d renamed LIBGNUTLS_VERSION_NUMBER to >> GNUTLS_VERSION_NUMBER. >> If using gnutls before that verion, we'll get the below warning: > > s/verion/version/ > >> crypto/tlscredsx509.c:618

Re: [Qemu-devel] [PATCH v2 1/2] crypto: fix building complaint

2016-08-30 Thread Eric Blake
On 08/29/2016 11:10 PM, Gonglei wrote: > gnutls commit 846753877d renamed LIBGNUTLS_VERSION_NUMBER to > GNUTLS_VERSION_NUMBER. > If using gnutls before that verion, we'll get the below warning: s/verion/version/ > crypto/tlscredsx509.c:618:5: warning: "GNUTLS_VERSION_NUMBER" is not defined > T

Re: [Qemu-devel] [PATCH] ipmi: chassis poweroff should use qemu_system_shutdown_request()

2016-08-30 Thread Peter Maydell
On 30 August 2016 at 14:43, Cédric Le Goater wrote: > On 08/30/2016 03:16 AM, Corey Minyard wrote: >> On 08/28/2016 03:44 PM, Greg Kurz wrote: >>> On Fri, 26 Aug 2016 18:05:31 +0200 >>> Cédric Le Goater wrote: >>> When issuing a chassis 'powerdown' control command, the routine qemu_syst

[Qemu-devel] [Bug 1618431] [NEW] windows hangs after live migration with virtio

2016-08-30 Thread Wry
Public bug reported: Several of our users reported problems with windows machines hanging after live migrations. The common denominator _seems_ to be virtio devices. I've managed to reproduce this reliably on a windows 10 (+ virtio-win-0.1.118) guest, always within 1 to 5 migrations, with a virtio

Re: [Qemu-devel] [PATCH] ipmi: chassis poweroff should use qemu_system_shutdown_request()

2016-08-30 Thread Cédric Le Goater
On 08/30/2016 03:16 AM, Corey Minyard wrote: > On 08/28/2016 03:44 PM, Greg Kurz wrote: >> On Fri, 26 Aug 2016 18:05:31 +0200 >> Cédric Le Goater wrote: >> >>> When issuing a chassis 'powerdown' control command, the routine >>> qemu_system_shutdown_request() should be used to exit the guest. >>> q

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Cornelia Huck
On Tue, 30 Aug 2016 13:31:12 +0200 Markus Armbruster wrote: > >> Full list of unmaintained files now: > docs/virtio-migration.txt I wrote this so I guess I could maintain it; but it should probably go with the other core virtio stuff? > default-configs/s390x-softmmu.mak > include/hw/watchdog/w

[Qemu-devel] [Bug 1615823] Re: Windows 10 reports no compatible TPM found yet device manager shows it?

2016-08-30 Thread Kelvin Middleton
Hi, any chance of this bug getting triaged anytime soon? I've posted to the qemu-devel mailing list twice but no response. Am keen to resolve this soon if its user error or not so if its a bonafide bug? Thanks, Kelvin -- You received this bug notification because you are a member of qemu- dev

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Cornelia Huck
On Tue, 30 Aug 2016 14:40:05 +0200 Paolo Bonzini wrote: > On 30/08/2016 14:26, Cornelia Huck wrote: > > Same goes for linux-headers. We don't even touch those (beyond the > > massaging done by the import script). > > > > Maybe we could make get_maintainers.pl point at the maintainer for > > the

Re: [Qemu-devel] [PATCH for 2.8 09/11] memory: handle alias for iommu notifier

2016-08-30 Thread Peter Xu
On Tue, Aug 30, 2016 at 11:06:57AM +0800, Jason Wang wrote: > Cc: Paolo Bonzini > Signed-off-by: Jason Wang Reviewed-by: Peter Xu > --- > memory.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/memory.c b/memory.c > index 0eb6895..ca0a698 100644 > --- a/memory.c > +++ b/me

Re: [Qemu-devel] [PATCH for 2.8 07/11] virtio-pci: address space translation service (ATS) support

2016-08-30 Thread Peter Xu
On Tue, Aug 30, 2016 at 11:06:55AM +0800, Jason Wang wrote: [...] > +/* Type 2: Root Port ATS Capability Reporting Structure */ > +struct AcpiDmarRootPortATS { > +uint16_t type; > +uint16_t length; > +uint8_t flags; > +uint8_t reserved; > +uint16_t pci_segment; > +AcpiDmar

Re: [Qemu-devel] Can't open boot device for Solaris 8

2016-08-30 Thread Artyom Tarasenko
On Tue, Aug 30, 2016 at 3:02 PM, Phillip Shin wrote: > Thanks for replying! I configured with target-list=x86_64-softmmu and called > make again. Then I tried this command: > $ qemu-system-x86_64 -bios ss5.bin -nographic -L . -hda 36GB.disk -m 256 -M > SS-5 -cdrom sol-8-u7-install-ia.iso > qemu-sy

Re: [Qemu-devel] [PATCH for 2.8 06/11] intel_iommu: support device iotlb descriptor

2016-08-30 Thread Peter Xu
On Tue, Aug 30, 2016 at 11:06:54AM +0800, Jason Wang wrote: > This patch enables device IOTLB support for intel iommu. The major > work is to implement QI device IOTLB descriptor processing and notify > the device through iommu notifier. IMHO it'll be nicer if we can mention the new bit in the com

Re: [Qemu-devel] Can't open boot device for Solaris 8

2016-08-30 Thread Phillip Shin
Thanks for replying! I configured with target-list=x86_64-softmmu and called make again. Then I tried this command: $ qemu-system-x86_64 -bios ss5.bin -nographic -L . -hda 36GB.disk -m 256 -M SS-5 -cdrom sol-8-u7-install-ia.iso qemu-system-x86_64: -bios ss5.bin: unsupported machine type Use -machin

Re: [Qemu-devel] [PATCH] translate: early exit in tb_flush if there is no tcg

2016-08-30 Thread Peter Maydell
On 25 August 2016 at 19:38, Christian Borntraeger wrote: > On 08/25/2016 02:11 PM, Christian Borntraeger wrote: >> tb_flush does all kind of things, which are very tcg specific. As it >> is called from some places even for KVM (e.g. gdb server) it is better >> to detect these cases and do an early

Re: [Qemu-devel] [virtio-comment] [PATCH] *** Vhost-pci RFC v2 ***

2016-08-30 Thread Wang, Wei W
On Tuesday, August 30, 2016 7:11 PM, Michael S. Tsirkin wrote: > On Tue, Aug 30, 2016 at 10:08:01AM +, Wang, Wei W wrote: > > On Monday, August 29, 2016 11:25 PM, Stefan Hajnoczi wrote: > > > To: Wang, Wei W > > > Cc: k...@vger.kernel.org; qemu-devel@nongnu.org; virtio- > > > comm...@lists.oas

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Peter Maydell
On 30 August 2016 at 13:48, Paolo Bonzini wrote: > I think this is expected to some extent. Is it worth moving tests to > many tests subdirectories, e.g. hw/scsi/tests? Many files would be > covered automatically. Moving tests around in order to increase MAINTAINERS coverage seems to me to be p

[Qemu-devel] KVM call for agenda for 2016-09-13

2016-08-30 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. Call details: By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXR

Re: [Qemu-devel] KVM call for agenda for 2016-08-30

2016-08-30 Thread Juan Quintela
Juan Quintela wrote: > Hi As there are no agenda, call is cancelled. Thanks, Juan. > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEMU Sum

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 13:31, Markus Armbruster wrote: > $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f > --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done > >unmaintained-files > $ grep -c '\.c$' unmaintained-files > 402 > > 402 out of 2132 (19%). More prog

Re: [Qemu-devel] [PATCH v2 2/2] vfio: add virtio pci quirk

2016-08-30 Thread Alex Williamson
On Tue, 30 Aug 2016 08:20:38 +0300 "Michael S. Tsirkin" wrote: > On Mon, Aug 29, 2016 at 10:53:04PM -0600, Alex Williamson wrote: > > On Mon, 29 Aug 2016 21:52:20 -0600 > > Alex Williamson wrote: > > > > > On Mon, 29 Aug 2016 21:23:25 -0600 > > > Alex Williamson wrote: > > > > > > > On Tu

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 30/08/2016 14:08, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 29/08/2016 09:52, ronyw...@synology.com wrote: From: ronyweng Openstack Cinder assigns volume a 36 characters uuid as serial. Qemu will shrinks the uuid to 20 characters

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:26, Cornelia Huck wrote: > Same goes for linux-headers. We don't even touch those (beyond the > massaging done by the import script). > > Maybe we could make get_maintainers.pl point at the maintainer for > the import script for these headers? Or is there something more > clever

[Qemu-devel] question with usb stick host pass-through do ejection in guest

2016-08-30 Thread wangxin (U)
Hi, I deploy USB stick pass-through in a Windows2008 VM in qemu-kvm platform (host OS is redhat 7.2) as follows: and the qemu commands: qemu-kvm -M pc ${otheroptions} \ -device piix3-u

[Qemu-devel] [PATCH for-2.7] optionrom: cope with multiple -O options

2016-08-30 Thread Paolo Bonzini
Reproducer: CFLAGS="-g3 -O0" ./configure --target-list=aarch64-softmmu,arm-softmmu --enable-vhost-net --enable-virtfs Here CFLAGS ends up with "-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 ... -g3 -O0" and pc-bios/optionrom/Makefile forgets to add the -O2 it needs. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] QEMU make: ROM is too large

2016-08-30 Thread Paolo Bonzini
On 22/08/2016 18:44, Thomas Hanson wrote: > On 22 August 2016 at 08:23, Peter Maydell > wrote: > > PS: just passing --enable-debug to configure should > be sufficient to do a no-optimization debug-symbols > build; do you really need to manually speci

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2016-08-30 Thread Cornelia Huck
On Tue, 30 Aug 2016 13:31:12 +0200 Markus Armbruster wrote: > >> Full list of unmaintained files now: (...) > include/standard-headers/asm-s390/kvm_virtio.h > include/standard-headers/asm-s390/virtio-ccw.h > include/standard-headers/asm-x86/hyperv.h > include/standard-headers/linux/if_ether.h >

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Paolo Bonzini
On 30/08/2016 14:08, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 29/08/2016 09:52, ronyw...@synology.com wrote: >>> From: ronyweng >>> >>> Openstack Cinder assigns volume a 36 characters uuid as serial. >>> Qemu will shrinks the uuid to 20 characters, >>> missmatch with original u

[Qemu-devel] [PATCH v8 2/2] virtio-crypto: Add conformance clauses

2016-08-30 Thread Gonglei
Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 31 +++ 1 file changed, 31 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..8268dc9 100644 --- a/conformance.tex +++ b/conformanc

[Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-30 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. Signed-off-by: Gonglei CC: Michael

[Qemu-devel] [PATCH v8 0/2] virtio-crypto: virtio crypto device specification

2016-08-30 Thread Gonglei
This is the specification about a new virtio crypto device. If you have any comments, please let me know, thanks :) CC: Michael S. Tsirkin CC: Cornelia Huck CC: Stefan Hajnoczi CC: Lingli Deng CC: Jani Kokkonen CC: Ola Liljedahl CC: Varun Sethi CC: Zeng Xin CC: Keating Brian CC: Ma Liang

Re: [Qemu-devel] [PATCH 0/2] vmxcap: Show raw MSR value, add TSC scaling bit

2016-08-30 Thread Paolo Bonzini
On 26/08/2016 05:10, Eduardo Habkost wrote: > Eduardo Habkost (2): > vmxcap: Show raw MSR value > vmxcap: Add TSC scaling bit > > scripts/kvm/vmxcap | 2 ++ > 1 file changed, 2 insertions(+) > Queued for 2.8, thanks. Paolo

Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36

2016-08-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 29/08/2016 09:52, ronyw...@synology.com wrote: >> From: ronyweng >> >> Openstack Cinder assigns volume a 36 characters uuid as serial. >> Qemu will shrinks the uuid to 20 characters, >> missmatch with original uuid. >> >> Signed-off-by: Rony Weng >> --- >> hw/scsi/

Re: [Qemu-devel] [PATCH V7 0/6] coroutine: mmap stack memory and stack size

2016-08-30 Thread Paolo Bonzini
On 23/08/2016 16:21, Peter Lieven wrote: > I decided to split this from the rest of the Qemu RSS usage series as > it contains the more or less non contentious patches. > > I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which > side effects it has. > > I kept the guard page wh

Re: [Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions

2016-08-30 Thread Paolo Bonzini
On 23/08/2016 11:45, Marc-André Lureau wrote: > Hi, > > Commit 7e8449594c929 introduced multiple regressions. The most > important is that the socket is actually not the one connected, due to > wrong usage of socket_connect(). I fixed that along with some leak > fixes, that could eventually be s

  1   2   >