Hi David,
On 11.08.2016 00:42, David Kiarie wrote:
Hello all,
The following patchset adds AMD-Vi interrupt remapping logic
to Qemu and hooks it onto existing interrupt remapping infrastructure.It has
a dependency on "Explicit SID for IOAPIC" patchset though.
I would appreciate your feedback!
On Wed, 08/10 23:17, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Hi,
>
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce
> it
> locally.
This may not relate to this patch.
P J P writes:
> From: Prasad J Pandit
>
> At various places in 9pfs back-end, it creates full path by
> concatenating two path strings. It could lead to a path
> traversal issue if one of the parameter was a relative path.
> Add check to avoid it.
>
> Reported-by: Felix Wilhelm
> Signed-off-by:
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH] 9pfs: add check for relative path
Message-id: 1470892391-4917-1-git-send-email-ppan...@redhat.co
On 11/08/2016 05:16, Fam Zheng wrote:
>> > +zlib-devel SDL-devel pixman-devel \
>> > +epel-release
>> > +RUN yum install -y libfdt-devel ccache
>> > +RUN yum downgrade -y
>> > http://vault.centos.org/6.0/os/x86_64/Packages/glib2-2.22.5-5.el6.x86_64.rpm
>> > +RUN yum install -y
>> > http
Looks like this issue has been fixed by this commit here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=4efeabbbe8441cc327052304
... so I think it should be OK to close this now.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a membe
From: Prasad J Pandit
At various places in 9pfs back-end, it creates full path by
concatenating two path strings. It could lead to a path
traversal issue if one of the parameter was a relative path.
Add check to avoid it.
Reported-by: Felix Wilhelm
Signed-off-by: Prasad J Pandit
---
hw/9pfs/9
On Wed, Aug 10, 2016 at 10:51:51AM +0200, Igor Mammedov wrote:
[...]
> > > Upstream guest kernel 4.7.0+ (d52bd54db) crashes when booting with irq
> > > remapping on:
> > >
> > > ./qemu-system-x86_64 -enable-kvm -smp
> > > 1,sockets=9,cores=32,threads=1,maxcpus=288 -device
> > > qemu64-x86_64-
Update all qemu_uuid users as well, especially get rid of the duplicated
low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID API.
Since qemu_uuid_parse is quite tangled with qemu_uuid, it's switching to
QemuUUID is done here too to keep everything in sync and avoid code
churn.
Sig
Signed-off-by: Fam Zheng
---
tests/Makefile.include | 2 +
tests/test-uuid.c | 173 +
2 files changed, 175 insertions(+)
create mode 100644 tests/test-uuid.c
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 14be491..aa4f83
The uuid generation doesn't return error, so update the function
signature and calling code accordingly.
Signed-off-by: Fam Zheng
---
crypto/block-luks.c | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/crypto/block-luks.c b/crypto/block-luks.c
inde
All code now uses built-in UUID implementation. Remove the code of
libuuid and make --enable-uuid and --disable-uuid only print a message.
Signed-off-by: Fam Zheng
---
configure | 43 ---
1 file changed, 4 insertions(+), 39 deletions(-)
diff --git a/confi
crypto now uses built-in uuid implementation, so this check is not
needed.
Signed-off-by: Fam Zheng
---
tests/test-crypto-block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-crypto-block.c b/tests/test-crypto-block.c
index a38110d..1957a86 100644
--- a/tests/te
Previously we conditionally generated footer->uuid, when libuuid was
available. Now that we have a built-in implementation, we can switch to
it.
Signed-off-by: Fam Zheng
---
block/vpc.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index
The UUID operations we need from libuuid is fully supported by QEMU UUID
implementation. Use it, and remove the unused code.
Signed-off-by: Fam Zheng
---
block/vdi.c | 73 ++---
1 file changed, 17 insertions(+), 56 deletions(-)
diff --git
This removes our dependency to libuuid, so that the driver can always be
built.
Similar to how we handled data plane configure options, --enable-vhdx
and --disable-vhdx are also changed to a nop with a message saying it's
obsolete.
Signed-off-by: Fam Zheng
---
block/Makefile.objs | 2 +-
block
A number of different places across the code base use CONFIG_UUID. Some
of them are soft dependency, some are not built if libuuid is not
available, some come with dummy fallback, some throws runtime error.
It is hard to maintain, and hard to reason for users.
Since UUID is a simple standard with
v4: Use memcpy instead of pointer type cast. [Richard]
Keep parameter order consistent with libuuid. [Jeff]
qemu_uuid_convert -> qemu_uuid_bswap. [Jeff]
v3: Negative tests. [Daniel]
Update QemuUUID type from array to struct. [Markus]
Add qemu_uuid_unparse_strdup.
Add qemu_uuid_
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v4 00/17] qapi: remove the 'middle' mode
Message-id: 20160810180235.32469-1-marcandre.lur...@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
On Wed, 08/10 16:25, Richard Henderson wrote:
> On 08/09/2016 12:19 PM, Fam Zheng wrote:
> >+/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */
> >+
> >+typedef struct {
> >+unsigned char data[16];
> >+} QemuUUID;
> ...
> >+void qemu_uuid_generate(QemuUUID *uuid)
> >+{
> >+int i;
>
On (Wed) 10 Aug 2016 [18:58:21], Dr. David Alan Gilbert wrote:
> * Li, Liang Z (liang.z...@intel.com) wrote:
> > > Subject: Re: [PATCH] migration: fix live migration failure with
> > > compression
> > >
> > > * Liang Li (liang.z...@intel.com) wrote:
> > > > Because of commit 11808bb0c422, which r
The virtio crypto device is a virtual crypto device (ie. hardware
crypto accelerator card). The virtio crypto device can provide
five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE.
In this patch, CIPHER, MAC, HASH, AEAD services are introduced.
Signed-off-by: Gonglei
CC: Michael
This is the specification (version 7) about a new virtio crypto device.
If you have any comments, please let me know, thanks :)
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Lingli Deng
CC: Jani Kokkonen
CC: Ola Liljedahl
CC: Varun Sethi
CC: Zeng Xin
CC: Keating Brian
Add the conformance targets and clauses for
virtio-crypto device.
Signed-off-by: Gonglei
---
conformance.tex | 30 ++
1 file changed, 30 insertions(+)
diff --git a/conformance.tex b/conformance.tex
index f59e360..915a9f0 100644
--- a/conformance.tex
+++ b/conformance
dd was creating an output image regardless of whether there was one already
created. With this patch we try to open first the output image and resize it
if necessary.
Signed-off-by: Reda Sallahi
---
Depends on:
[PATCH v2] qemu-img: add conv=notrunc option to dd
qemu-img.c | 91 +
This adds the conv=notrunc option to dd which tells dd to not truncate the
output.
For the time being we make it mandatory to specify conv=notrunc.
Signed-off-by: Reda Sallahi
---
Depends on:
[PATCH v5] qemu-img: add skip option to dd
Changes from v1:
* Added comment
qemu-img-cmds.hx |
On Wed, Aug 10, 2016 at 06:59:14PM +0200, Radim Krčmář wrote:
> 2016-08-10 11:29+0800, Peter Xu:
> > On Tue, Aug 09, 2016 at 05:03:33PM +0200, Radim Krčmář wrote:
> >> APIC in QEMU doesn't support x2APIC so exposing EIM is pointless and KVM
> >> has a quirk that needs to be disabled unless we want
On Wed, 08/10 21:06, Max Reitz wrote:
> On 10.08.2016 21:04, Colin Lord wrote:
> > On 08/10/2016 02:37 PM, Max Reitz wrote:
> >> On 08.08.2016 20:07, Colin Lord wrote:
> >>> From: Marc Mari
> >>>
> >>> Extend the current module interface to allow for block drivers to be
> >>> loaded dynamically on
On Tue, 08/09 10:15, Fam Zheng wrote:
> It's a variation of our existing centos6, plus two more lines to
> downgrade glib2 to version 2.22 which we download from vault.centos.org.
>
> Suggested-by: Paolo Bonzini
> Signed-off-by: Fam Zheng
> ---
> tests/docker/dockerfiles/min-glib.docker | 8 +++
On Thu, 08/11 05:07, Reda Sallahi wrote:
> This adds the conv=notrunc option to dd which tells dd to not truncate the
> output.
>
> For the time being we make it mandatory to specify conv=notrunc.
>
> Signed-off-by: Reda Sallahi
> ---
> qemu-img-cmds.hx | 4 ++--
> qemu-img.c
On Wed, Aug 10, 2016 at 09:08:01PM +0200, Cédric Le Goater wrote:
> From: Greg Kurz
>
> Considering that features are converted to global properties and
> global properties are automatically applied to every new instance
> of created CPU (at object_new() time), there is no point in
> parsing cpu_
This adds the conv=notrunc option to dd which tells dd to not truncate the
output.
For the time being we make it mandatory to specify conv=notrunc.
Signed-off-by: Reda Sallahi
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 31 ---
qemu-img.texi
On Wed, 08/10 20:30, Max Reitz wrote:
> On 03.08.2016 10:01, Fam Zheng wrote:
> > dmg.o was moved to block-obj-m in 5505e8b76 to become a separate module,
> > so that its reference to libbz2, since 6b383c08c, doesn't add an extra
> > library to the main executable.
> >
> > We are working on on-dem
> On 09/08/2016 10:04, Xulei (Stone) wrote:
> > Following your suggestion, i'm now sure it is caused by missing SMI.
> > I have tried adding dprintf() like this:
> >
> > --- a/roms/seabios/src/fw/smm.c
> > +++ b/roms/seabios/src/fw/smm.c
> > @@ -65,7 +65,8 @@ handle_smi(u16 cs)
> > u8 cmd
> On Tue, Aug 09, 2016 at 08:30:42AM +0800, Liang Li wrote:
> > Since there in wrapper around madvise(), the virtio-balloon code is
> > able to work without the precompiled directive, the directive can be
> > removed.
> >
> > Signed-off-by: Liang Li
> > Suggested-by: Thomas Huth
> > Reviewd-by: D
On 08/08/16 12:11, Peter Maydell wrote:
The various host OSes are irritatingly variable about the name
of the linker emulation we need to pass to ld's -m option to
build the i386 option ROMs. Instead of doing this via a
CONFIG ifdef, check in configure whether any of the emulation
names we know a
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1470817370-145190-1-git-send-email-pbonz...@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git
On Wed, 08/10 16:56, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> === OUTPUT BEGIN ===
> Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
> Cloning into 'dtc'...
> Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf'
> BUILD cent
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks
Message-id: 1470817370-145190-1-git-send-email-pbonz...@redhat.com
Type
On 08/08/16 12:11, Peter Maydell wrote:
The various host OSes are irritatingly variable about the name
of the linker emulation we need to pass to ld's -m option to
build the i386 option ROMs. Instead of doing this via a
CONFIG ifdef, check in configure whether any of the emulation
names we know a
On 08/08/16 04:50, Paolo Bonzini wrote:
On 07/08/2016 01:53, Brad Smith wrote:
On 07/14/16 09:52, Paolo Bonzini wrote:
diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
index 2cdda87..d88ce11 100644
--- a/pc-bios/optionrom/Makefile
+++ b/pc-bios/optionrom/Makefile
@@ -9,22
On Thu, 11 Aug 2016 02:53:10 +0530
Kirti Wankhede wrote:
> On 8/10/2016 12:30 AM, Alex Williamson wrote:
> > On Thu, 4 Aug 2016 00:33:52 +0530
> > Kirti Wankhede wrote:
> >
>
> ...
>
> >> +
> >> + switch (info.index) {
> >> + case VFIO_PCI_CONFIG_REGION_INDEX:
> >> +
Public bug reported:
this has been broken for over 2 years
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1611979
Title:
GTK+ inter
On 8/10/2016 12:30 AM, Alex Williamson wrote:
> On Thu, 4 Aug 2016 00:33:52 +0530
> Kirti Wankhede wrote:
>
...
>> +
>> +switch (info.index) {
>> +case VFIO_PCI_CONFIG_REGION_INDEX:
>> +case VFIO_PCI_BAR0_REGION_INDEX ... VFIO_PCI_BAR5_REGION_INDEX:
>> +
From: Li Qiang
When net transport abstraction layer initialises the pkt,
the maximum fragmentation count is not checked. This could
lead to an integer overflow causing a NULL pointer dereference.
Add check to avoid it.
Reported-by: Li Qiang
Signed-off-by: Prasad J Pandit
---
hw/net/net_tx_pkt
Introduce AMD IOMMU interrupt remapping and hook it onto
the existing interrupt remapping infrastructure
Signed-off-by: David Kiarie
---
hw/i386/amd_iommu.c | 226 +++-
hw/i386/amd_iommu.h | 2 +
2 files changed, 227 insertions(+), 1 deletion(-)
Enabling interrupt remapping with kernel_irqchip=on should
result in error for both VT-d and AMD-Vi
Signed-off-by: David Kiarie
---
hw/i386/intel_iommu.c | 9 -
hw/i386/x86-iommu.c | 8
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i
On Wed, Aug 10, 2016 at 10:42 PM, David Kiarie
wrote:
Sorry, forgot to cc Peter.
Hello all,
>
> The following patchset adds AMD-Vi interrupt remapping logic
> to Qemu and hooks it onto existing interrupt remapping infrastructure.It
> has
> a dependency on "Explicit SID for IOAPIC" patchset thoug
Report IOAPIC via IVRS which effectively allows linux AMD-Vi
driver to enable interrupt remapping
Signed-off-by: David Kiarie
---
hw/i386/acpi-build.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 49bd183..da602c3 100644
--- a/hw/i386/acp
Introduce macros and trace events for use in AMD IOMMU
interrupt remapping
Signed-off-by: David Kiarie
---
hw/i386/amd_iommu.h | 72
hw/i386/trace-events | 7 +
2 files changed, 79 insertions(+)
diff --git a/hw/i386/amd_iommu.h b/hw/i38
Hello all,
The following patchset adds AMD-Vi interrupt remapping logic
to Qemu and hooks it onto existing interrupt remapping infrastructure.It has
a dependency on "Explicit SID for IOAPIC" patchset though.
I would appreciate your feedback!
For quick testing https://github.com/aslaq/qemu IR
D
On 08/10/2016 03:24 PM, Colin Lord wrote:
> On 08/10/2016 03:04 PM, Colin Lord wrote:
>> On 08/10/2016 02:37 PM, Max Reitz wrote:
>>> On 08.08.2016 20:07, Colin Lord wrote:
From: Marc Mari
Extend the current module interface to allow for block drivers to be
loaded dynamically o
Alex Bennée writes:
> Pranith Kumar writes:
>
>> This adds the x86 store-after-load re-ordering litmus test.
>>
>> Most of the supporting files are mostly unmodified and generated by
>> the litmus tool.
>>
>> Signed-off-by: Pranith Kumar
>> ---
>> tests/tcg/mttcg/x86/Makefile | 42 ++
>>
tb_flush() is called when debugging the guest (under both KVM
and TCG accelerators) with gdb. tb_flush() resets TCG's qht, which
segfaults if we're using KVM due to the qht not being initialized.
Fix this adding a magic number field to struct qht to track whether a qht
has been initialized with qh
On 10.08.2016 21:04, Colin Lord wrote:
> On 08/10/2016 02:37 PM, Max Reitz wrote:
>> On 08.08.2016 20:07, Colin Lord wrote:
>>> From: Marc Mari
>>>
>>> Extend the current module interface to allow for block drivers to be
>>> loaded dynamically on request. The only block drivers that can be
>>> con
On 08/10/2016 03:04 PM, Colin Lord wrote:
> On 08/10/2016 02:37 PM, Max Reitz wrote:
>> On 08.08.2016 20:07, Colin Lord wrote:
>>> From: Marc Mari
>>>
>>> Extend the current module interface to allow for block drivers to be
>>> loaded dynamically on request. The only block drivers that can be
>>>
On 08/10/2016 03:04 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> Modularizes the nfs block driver so that it gets dynamically loaded.
>>
>> Signed-off-by: Colin Lord
>> Reviewed-by: Stefan Hajnoczi
>> ---
>> block/Makefile.objs | 1 +
>> configure | 4 ++--
>> 2 fil
On 08.08.2016 20:07, Colin Lord wrote:
> One more minor revision from v6, no big changes.
>
> v7:
> - Add ifdef around qemu_iscsi_opts in vl.c (first patch)
>
> v6:
> - Fix bug so that users can specify a modularized driver on the cli
> without qemu exiting
> - Remove extra lines from Makefile
On 08/10/2016 02:37 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> From: Marc Mari
>>
>> Extend the current module interface to allow for block drivers to be
>> loaded dynamically on request. The only block drivers that can be
>> converted into modules are the drivers that don't
On 08/10/2016 09:08 PM, Cédric Le Goater wrote:
> From: Greg Kurz
>
> Considering that features are converted to global properties and
> global properties are automatically applied to every new instance
> of created CPU (at object_new() time), there is no point in
> parsing cpu_model string every
From: Li Qiang
In Vmxnet3 device emulator while processing transmit(tx) queue,
when it reaches end of packet, it calls vmxnet3_complete_packet.
In that local 'txcq_descr' object is not initialised, which could
leak host memory bytes a guest.
Reported-by: Li Qiang
Signed-off-by: Prasad J Pandit
Manipulate data and store 8bytes instead of 4bytes.
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate/vsx-impl.inc.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/target-ppc/translate/vsx-impl.inc.c
b/target-ppc/translate/vsx-impl.inc.
From: Greg Kurz
Considering that features are converted to global properties and
global properties are automatically applied to every new instance
of created CPU (at object_new() time), there is no point in
parsing cpu_model string every time a CPU created. So move
parsing outside CPU creation lo
On 08.08.2016 20:07, Colin Lord wrote:
> Modularizes the nfs block driver so that it gets dynamically loaded.
>
> Signed-off-by: Colin Lord
> Reviewed-by: Stefan Hajnoczi
> ---
> block/Makefile.objs | 1 +
> configure | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
I'm n
From: Ravi Bangoria
darn: Deliver A Random Number
For both CRN and RRN, returning 64-bit random number.
Signed-off-by: Ravi Bangoria
[ use /dev/random to get the number ]
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 2 ++
target-ppc/int_helper.c | 51 ++
stxvb16x: Store VSX Vector Byte*16
stxvh8x: Store VSX Vector Halfword*8
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate/vsx-impl.inc.c | 55 +
target-ppc/translate/vsx-ops.inc.c | 2 ++
2 files changed, 57 insertions(+)
diff --git a/target-ppc/tr
stxsibx - Store VSX Scalar as Integer Byte Indexed
stxsihx - Store VSX Scalar as Integer Halfword Indexed
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate.c | 2 ++
target-ppc/translate/vsx-impl.inc.c | 2 ++
target-ppc/translate/vsx-ops.inc.c | 2 ++
3 files changed, 6 in
lxsibzx - Load VSX Scalar as Integer Byte & Zero Indexed
lxsihzx - Load VSX Scalar as Integer Halfword & Zero Indexed
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate.c | 2 ++
target-ppc/translate/vsx-impl.inc.c | 2 ++
target-ppc/translate/vsx-ops.inc.c | 2 ++
3 files c
Load 8byte at a time and manipulate.
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 1 +
target-ppc/mem_helper.c | 5 +
target-ppc/translate/vsx-impl.inc.c | 34 --
3 files changed, 26 insertions(+), 14 deletions(-)
d
Implement macro to consolidate store operations using newer
tcg_gen_qemu_ld functions.
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate.c | 70 +++---
1 file changed, 26 insertions(+), 44 deletions(-)
diff --git a/target-ppc/translate.c b/tar
This series contains 10 new instructions for POWER9 ISA3.0.
Use newer qemu load/store tcg helpers and optimize stxvw4x and lxvw4x.
Patches:
01: xxspltib: VSX Vector Splat Immediate Byte
02: Use tcg_gen_qemu_ld and write consolidated macro
03: Use tcg_gen_qemu_st and write consolidat
Implement macro to consolidate store operations using newer
tcg_gen_qemu_st functions.
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate.c | 37 ++---
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/trans
lxvb16x: Load VSX Vector Byte*16
lxvh8x: Load VSX Vector Halfword*8
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 1 +
target-ppc/mem_helper.c | 6
target-ppc/translate/vsx-impl.inc.c | 57 +
target-ppc/translat
xxspltib: VSX Vector Splat Immediate Byte
Copy the immediate byte in each byte of target VSR
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate.c | 2 ++
target-ppc/translate/vsx-impl.inc.c | 22 ++
target-ppc/translate/vsx-ops.inc.c | 7 +++
3 fil
On 2016-08-10 14:55, Pranith Kumar wrote:
> Change the flag type to 'uint8_t' to fix the implicit conversion error.
>
> Signed-off-by: Pranith Kumar
> ---
> fpu/softfloat-specialize.h | 2 +-
> include/fpu/softfloat.h| 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --gi
Change the flag type to 'uint8_t' to fix the implicit conversion error.
Signed-off-by: Pranith Kumar
---
fpu/softfloat-specialize.h | 2 +-
include/fpu/softfloat.h| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
On 08.08.2016 20:07, Colin Lord wrote:
> From: Marc Mari
>
> Extend the current module interface to allow for block drivers to be
> loaded dynamically on request. The only block drivers that can be
> converted into modules are the drivers that don't perform any init
> operation except for registe
On 08.08.2016 20:07, Colin Lord wrote:
> From: Marc Mari
>
> To simplify the addition of new block modules, add a script that generates
> module_block.h automatically from the modules' source code.
>
> This script assumes that the QEMU coding style rules are followed.
>
> Signed-off-by: Marc Ma
On 03.08.2016 10:01, Fam Zheng wrote:
> dmg.o was moved to block-obj-m in 5505e8b76 to become a separate module,
> so that its reference to libbz2, since 6b383c08c, doesn't add an extra
> library to the main executable.
>
> We are working on on-demand loading of block drivers which will be
> easie
From: Marc-André Lureau
Add some missing lines, remove superflous @ in command name, remove
trailing spaces.
Signed-off-by: Marc-André Lureau
---
docs/qmp-commands.txt | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/docs/qmp-commands.txt b/
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
Makefile.target | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index a440bcb..3d8572f 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -156,7
From: Marc-André Lureau
Replace the old manual dispatch and validation code by the generic one
provided by qapi common code.
Note that it is now possible to call the following commands that used to
be disabled by compile-time conditionals:
- dump-skeys
- query-spice
- rtc-reset-reinjection
- que
From: Marc-André Lureau
The following "use qmp_dispatch()" commit will use the generated
dispatch command table that is unaware of compile time conditionals.
There are a few commands that are under #ifdef conditions in
qmp-commands.hx. Move the qmp_query_spice fallback in the same location
as th
A check for multicast MAC addresses has been introduced by this commit here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d60b20cf2ae6644b051
So I think we can close this ticket now.
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you
From: Marc-André Lureau
Now that the register function is always generated, we can
remove the so-called "middle" mode from the generator script.
Signed-off-by: Marc-André Lureau
---
scripts/qapi-commands.py | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/sc
From: Marc-André Lureau
One step towards getting rid of the static qmp_cmds table.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
monitor.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/monitor.c b/monitor.c
index 2050698..cd
From: Marc-André Lureau
The generated marshal functions do not visit arguments from commands
that take no arguments. Thus they fail to catch invalid
members. Visit the arguments, if provided, to throw an error in case of
invalid members.
Currently, qmp_check_client_args() checks for invalid argu
From: Marc-André Lureau
Make it possible to call marshallers manually, without going through
qmp_dispatch(). (this is currently only possible in middle-mode, but
it's also useful in general)
Signed-off-by: Marc-André Lureau
---
scripts/qapi-commands.py | 8 ++--
1 file changed, 2 insertion
From: Marc-André Lureau
The only remaining function of qmp-commands.hx is to let us generate
qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt.
(a later update will move the documentation in the respective json files
and again generate the text file)
Signed-off-by: Marc-And
From: Marc-André Lureau
This is no longer necessary now that we aren't using middle mode
anymore.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
monitor.c | 13 +--
docs/writing-qmp-commands.txt | 4 +-
hmp-commands-info.hx | 118 -
From: Marc-André Lureau
The current monitor dispatch codes doesn't know commands that have been
filtered out during qmp-commands.hx preprocessing. query-commands
doesn't list them either. However, qapi generator doesn't filter them
out, and they are listed in the command list.
For now, disable t
From: Marc-André Lureau
Stop using the so-called 'middle' mode. Instead, use qmp_find_command()
from generated qapi commands registry. Update and fix the documentation
too.
Signed-off-by: Marc-André Lureau
---
monitor.c | 10 ++-
vl.c | 1 +
Make
From: Marc-André Lureau
Since a few commands are using 'gen': false, they are not registered
automatically by the generator. Register manually instead.
This is in preparation for removal of qapi 'middle' mode generation.
Note that qmp_init_marshal() function isn't run yet, so the commands
aren'
From: Marc-André Lureau
Even though device_add is not fully qapi'fied, we may add it to the json
schema with 'gen': false, so registration and documentation can be
generated.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
qapi-schema.json | 40 +++
From: Marc-André Lureau
handle_qmp_command() will switch to use qmp_dispatch(). It won't have a
pointer to the marshaller function anymore, but only the name of the
command to invoke. Simplify invalid_qmp_mode() so it can just be called
with the command name.
Signed-off-by: Marc-André Lureau
R
From: Marc-André Lureau
qapi'fy the 'qmp_capabilities' command, makes the command visible in
query-qmp-schema.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
Reviewed-by: Markus Armbruster
---
monitor.c| 4 ++--
qapi-schema.json | 21 +
qmp-commands.hx
From: Marc-André Lureau
Hi,
Although some QMP commands are still not fully qapi'fied, it is
possible to use more qapi common and generated code by dropping the
'middle' mode and use qmp_dispatch().
v4:
- export all marshaller functions (so we can keep calling them after
middle mode is removed
From: Marc-André Lureau
There are better chances to find what went wrong at build time than a
later assert in qmp_query_version
Signed-off-by: Marc-André Lureau
---
qmp.c | 16 +++-
scripts/create_config | 6 ++
2 files changed, 9 insertions(+), 13 deletions(-)
Hi Richard,
On Wed, Aug 10, 2016 at 6:44 AM, Richard Henderson wrote:
> On 08/10/2016 04:42 AM, Pranith Kumar wrote:
>>
>> +/* Eliminate duplicate and unnecessary fence instructions */
>> +void tcg_optimize_mb(TCGContext *s)
>> +{
>> +int oi, oi_next;
>> +TCGArg prev_op_mb = -1;
>> +T
* Li, Liang Z (liang.z...@intel.com) wrote:
> > Subject: Re: [PATCH] migration: fix live migration failure with compression
> >
> > * Liang Li (liang.z...@intel.com) wrote:
> > > Because of commit 11808bb0c422, which remove some condition checks of
> > > 'f->ops->writev_buffer', 'qemu_put_qemu_fil
1 - 100 of 241 matches
Mail list logo
