Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-04 Thread Gerd Hoffmann
Hi, > > +if (file->copy(file, opregion, file->size) < 0) { > Is opregion content on host immutable? > if not then copying it probably wrong and it should be passed-through. The OpRegion is used for communication between bios and driver, it is *not* something going directly to the hardware.

Re: [Qemu-devel] [PATCH v2 04/11] block: m25p80: Extend address mode

2016-02-04 Thread Cédric Le Goater
On 02/04/2016 01:23 PM, marcin.krzemin...@nokia.com wrote: > From: Marcin Krzeminski > > Extend address mode allows to switch flash 16 MiB banks, > allowing user to access all flash sectors. > This access mode is used by u-boot. > > Signed-off-by: Marcin Krzeminski > Reviewed-by: Peter Crosthwa

Re: [Qemu-devel] [PATCH v2 05/11] block: m25p80: 4byte address mode

2016-02-04 Thread Cédric Le Goater
Hello Marcin, Some comments below On 02/04/2016 01:23 PM, marcin.krzemin...@nokia.com wrote: > From: Marcin Krzeminski > > This patch adds only 4byte address mode (does not cover dummy cycles). > This mode is needed to access more than 16 MiB of flash. > > Signed-off-by: Marcin Krzeminski >

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 04/02/2016 12:41, Andreas Färber wrote: >> You're talking about machine, right? Some time ago I had proposed Marcel >> who initially worked on it, but I'm fine with anyone taking it. > > Yes. > >> For some (but not all) core qdev parts related to the (stalled) QOM >> mi

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-04 Thread Marcel Apfelbaum
On 02/05/2016 09:49 AM, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Thu, Feb 04, 2016 at 12:55:22PM +0100, Paolo Bonzini wrote: On 04/02/2016 12:41, Andreas Färber wrote: You're talking about machine, right? Some time ago I had proposed Marcel who initially worked on it, but I

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-04 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Feb 04, 2016 at 12:55:22PM +0100, Paolo Bonzini wrote: >> >> >> On 04/02/2016 12:41, Andreas Färber wrote: >> > You're talking about machine, right? Some time ago I had proposed Marcel >> > who initially worked on it, but I'm fine with anyone taking it. >>

Re: [Qemu-devel] [PATCH] [trivial] qapi: Add missing JSON files in build dependencies

2016-02-04 Thread Markus Armbruster
Lluís Vilanova writes: Suggest to add: "Forgotten in commit 1dde0f4 (trace.json) and commit fafa4d5 (rocker.json)." Could be done on commit. Since I have a QAPI pull request coming up, I can take it through my tree. > Signed-off-by: Lluís Vilanova > --- > Makefile |3 ++- > 1 file change

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-04 Thread Jason Wang
On 02/05/2016 03:01 PM, Hailiang Zhang wrote: > On 2016/2/5 14:19, Jason Wang wrote: >> >> >> On 02/01/2016 06:40 PM, Hailiang Zhang wrote: >>> On 2016/2/1 17:42, Jason Wang wrote: On 02/01/2016 05:22 PM, Hailiang Zhang wrote: > On 2016/2/1 17:04, Jason Wang wrote: >> >

Re: [Qemu-devel] [PATCH 7/7] igd: add q35 support

2016-02-04 Thread Gerd Hoffmann
On Do, 2016-02-04 at 17:22 +0200, Michael S. Tsirkin wrote: > On Tue, Dec 08, 2015 at 03:07:28PM +0100, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > Acked-by: Michael S. Tsirkin > > Generally are you merging this through your tree? First this needs more testing, then we can figure

Re: [Qemu-devel] [PATCH v2 00/10] virtio/vring: optimization patches

2016-02-04 Thread Gonglei (Arei)
Dear Paolo, > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, February 04, 2016 6:19 PM > > On 03/02/2016 13:08, Gonglei (Arei) wrote: > > 22.56% qemu-kvm [.] address_space_translate > > 13.29% qemu-kvm [.] qemu_get_ram_ptr > > We could g

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-04 Thread Hailiang Zhang
On 2016/2/5 14:19, Jason Wang wrote: On 02/01/2016 06:40 PM, Hailiang Zhang wrote: On 2016/2/1 17:42, Jason Wang wrote: On 02/01/2016 05:22 PM, Hailiang Zhang wrote: On 2016/2/1 17:04, Jason Wang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote:

[Qemu-devel] [PATCH] net/filter-redirector:Add filter-redirector

2016-02-04 Thread Zhang Chen
From: ZhangChen Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter +

Re: [Qemu-devel] [PULL 6/6] MAINTAINERS: Add .travis.yml

2016-02-04 Thread Fam Zheng
On Thu, 02/04 17:12, Alex Bennée wrote: > Signed-off-by: Alex Bennée > Reviewed-by: David Gibson > > --- > pr: added r-b tags > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b6ed87a..426a735 100644 > --- a/MAINTAINERS > +++ b/

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-04 Thread Jason Wang
On 02/01/2016 06:40 PM, Hailiang Zhang wrote: > On 2016/2/1 17:42, Jason Wang wrote: >> >> >> On 02/01/2016 05:22 PM, Hailiang Zhang wrote: >>> On 2016/2/1 17:04, Jason Wang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: > On 2016/2/1 15:46, Jason Wang wrote: >> >

Re: [Qemu-devel] [RFC PATCH 1/4] tests: Introduce Docker based tests

2016-02-04 Thread Fam Zheng
On Thu, 02/04 11:58, Daniel P. Berrange wrote: > On Wed, Feb 03, 2016 at 10:36:01PM +0800, Fam Zheng wrote: > > > diff --git a/tests/docker/fedora22.docker b/tests/docker/fedora22.docker > > new file mode 100644 > > index 000..5fd48d6 > > --- /dev/null > > +++ b/tests/docker/fedora22.docker >

Re: [Qemu-devel] [PATCH 07/10] virtio: combine the read of a descriptor

2016-02-04 Thread Gonglei (Arei)
Regards, -Gonglei > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, February 04, 2016 6:18 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: cornelia.h...@de.ibm.com; m...@redhat.com > Subject: Re: [PATCH 07/10] virtio: combine the read of a

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-04 Thread Alex Williamson
On Thu, 4 Feb 2016 17:58:23 +0100 Igor Mammedov wrote: > On Tue, 02 Feb 2016 13:10:37 -0700 > Alex Williamson wrote: > > > When assigning Intel IGD graphics via QEMU/vfio, the OpRegion for > > the device may be exposed as a fw_cfg file. Allocate space for > > this, copy the contents and write

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

2016-02-04 Thread Pankaj Gupta
> > Hi Pankaj, > > - Original Message - > > > > Hi Ladi, > > > > I think this is fine if we have multiple requests from Guests and > > depending on entropy pool available we can honour individual requests > > and return with the entropy. > > > > Just one point I have is, Suppose we ha

Re: [Qemu-devel] [PATCH 0/4] vfio-pci: pass the aer error to guest, part1

2016-02-04 Thread Alex Williamson
On Thu, 4 Feb 2016 13:28:53 +0200 "Michael S. Tsirkin" wrote: > On Thu, Feb 04, 2016 at 09:31:04AM +0800, Cao jin wrote: > > From: Chen Fan > > > > this patchset are splited out from my aer series patches, > > this part of aer patches is harmless, and have been reviewed-by. > > In order to avoi

[Qemu-devel] [PATCH v15 5/9] docs: block replication's description

2016-02-04 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 238 + 1 file changed, 238 insertions(+) create mode 100644 docs/block-replication.txt

[Qemu-devel] [PATCH v15 7/9] Introduce new APIs to do replication operation

2016-02-04 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 94 replication.h| 53 ++

[Qemu-devel] [PATCH v15 3/9] Backup: clear all bitmap when doing block checkpoint

2016-02-04 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c| 15 +++ include/block/block_int.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/block/backup.c b/block/backup

[Qemu-devel] [PATCH v15 9/9] support replication driver in blockdev-add

2016-02-04 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/q

[Qemu-devel] [PATCH v15 0/9] Block replication for continuous checkpoints

2016-02-04 Thread Changlong Xie
Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features/BlockReplication Usage: Please refer to docs/block-replication.txt This patch series is

[Qemu-devel] [PATCH v15 1/9] unblock backup operations in backing file

2016-02-04 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index a285de5..70ab625 100644 --- a/block.c +++ b/block.c @@ -1279,6 +1279,24 @@ void bdrv_set_backing_hd(BlockDrive

[Qemu-devel] [PATCH v15 4/9] Link backup into block core

2016-02-04 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v15 6/9] auto complete active commit

2016-02-04 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

[Qemu-devel] [PATCH v15 2/9] Store parent BDS in BdrvChild

2016-02-04 Thread Changlong Xie
From: Wen Congyang We need to access the parent BDS to get the root BDS. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 1 + include/block/block_int.h | 1 + 2 files changed, 2 insertions(+) diff --git a/block.c b/block.c index 70ab625..c18b462 10064

[Qemu-devel] [PATCH v15 8/9] Implement new driver for block replication

2016-02-04 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 594 2 files changed, 595 insertions(+) create mode 100

[Qemu-devel] [PATCH] Fixes missing key in usb keyboard emulation

2016-02-04 Thread Daniel Serpell
Hi, This one-liner patch adds a translation entry for the key that is between left shift and 'Z' on international keyboards, enabling its use in the usb keyboard device emulation. Daniel Serpell (1): Adds keycode 86 to the hid_usage_keys translation table. hw/input/hid.c | 2 +- 1 file change

[Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table.

2016-02-04 Thread Daniel Serpell
This key is present in international keyboards, between left shift and the 'Z' key, ant is described in the HID usage tables as "Keyboard Non-US \ and |": http://www.usb.org/developers/hidpage/Hut1_12v2.pdf This patch fixes the usb-kbd devices. Signed-off-by: Daniel Serpell --- hw/input/hid.c |

[Qemu-devel] [PATCH] qqq: module for synchronizing with a simulation clock

2016-02-04 Thread James J. Nutaro
This patch adds an interface for pacing the execution of QEMU to match an external simulation clock. Its aim is to permit QEMU to be used as a module within a larger simulation system. Makefile.target | 2 +- cpus.c | 13 ++- docs/simulation-sync.txt | 61

[Qemu-devel] [PATCH v4 3/4] filter-buffer: Accept zero interval

2016-02-04 Thread zhanghailiang
We may want to accept zero interval when VM FT solutions like MC or COLO use this filter to release packets on demand. Signed-off-by: zhanghailiang Reviewed-by: Yang Hongyang --- net/filter-buffer.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/net/filter-buffer.c b/net/filter-

[Qemu-devel] [PATCH v4 2/4] net/filter: Introduce a helper to add a filter to the netdev

2016-02-04 Thread zhanghailiang
We add a new helper function netdev_add_default_filter(), this function can help adding a filter object to a netdev. Besides, we add a is_default member for struct NetFilterState to indicate whether the filter is default or not. Signed-off-by: zhanghailiang --- v4: - Rename netdev_add_filter() t

[Qemu-devel] [PATCH v4 0/4] Netfilter: Add each netdev a default filter

2016-02-04 Thread zhanghailiang
This series is a prerequisite for COLO, here we add each netdev a default buffer filter, it is disabled by default, and has no side effect for delivering packets in net layer. ChangeLog: v4: - Rename helper netdev_add_filter() to netdev_add_default_filter() and drop the is_default parameter (H

[Qemu-devel] [PATCH v4 4/4] net/filter: Add a default filter to each netdev

2016-02-04 Thread zhanghailiang
We add each netdev a default buffer filter, and the default buffer filter is disabled, so it has no side effect for packets delivering in qemu net layer. The default buffer filter can be used by COLO or Micro-checkpoint, The reason we add the default filter is we hope to support hot add network du

[Qemu-devel] [PATCH v4 1/4] net/filter: Add a 'status' property for filter object

2016-02-04 Thread zhanghailiang
With this property, users can control if this filter is 'enable' or 'disable'. The default behavior for filter is enabled. We will skip the disabled filter when delivering packets in net layer. Signed-off-by: zhanghailiang --- v2: - Squash previous patch 3 into this patch (Jason's suggestion) -

Re: [Qemu-devel] [PATCH v3 4/4] net/filter: Add a default filter to each netdev

2016-02-04 Thread Hailiang Zhang
On 2016/2/2 11:16, Yang Hongyang wrote: On 02/01/2016 08:01 PM, zhanghailiang wrote: We add each netdev a default buffer filter, and the default buffer filter is disabled, so it has no side effect for packets delivering in qemu net layer. The default buffer filter can be used by COLO or Micro

Re: [Qemu-devel] [PATCH v3 2/4] net/filter: Introduce a helper to add a filter to the netdev

2016-02-04 Thread Hailiang Zhang
On 2016/2/2 11:14, Yang Hongyang wrote: On 02/01/2016 08:01 PM, zhanghailiang wrote: We add a new helper function netdev_add_filter(), this function can help adding a filter object to a netdev. Besides, we add a is_default member for struct NetFilterState to indicate whether the filter is defa

[Qemu-devel] [PATCH V2] quorum: fix segfault when read fails in fifo mode

2016-02-04 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/quorum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index a5ae4b8..11cc60b 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -286,7 +286,8 @@ static void quorum_aio_cb(

[Qemu-devel] [PATCH 5/6] target-ppc: Remove hack for ppc_hash64_load_hpte*() with HV KVM

2016-02-04 Thread David Gibson
With HV KVM, the guest's hash page table (HPT) is managed by the kernel and not directly accessible to QEMU. This means that spapr->htab is NULL and normally env->external_htab would also be NULL for each cpu. However, that would cause ppc_hash64_load_hpte*() to do the wrong thing in the few case

[Qemu-devel] [PATCH 0/6] Cleanups to Hash Page Table handling

2016-02-04 Thread David Gibson
This contains some assorted cleanups and small improvements to the management of the Hash Page Table for 64-bit ppc systems, and the "pseries" machine type in particular. These were devised in the context of getting hash page table resizing working, but can stand on their own. David Gibson (6):

[Qemu-devel] [PATCH 4/6] pseries: Move hash page table allocation to reset time

2016-02-04 Thread David Gibson
At the moment the size of the hash page table (HPT) is fixed based on the maximum memory allowed to the guest. As such, we allocate the table during machine construction, and just clear it at reset. However, we're planning to implement a PAPR extension allowing the hash page table to be resized a

[Qemu-devel] [PATCH 3/6] pseries: Simplify handling of the hash page table fd

2016-02-04 Thread David Gibson
When migrating the 'pseries' machine type with KVM, we use a special fd to access the hash page table stored within KVM. Usually, this fd is opened at the beginning of migration, and kept open until the migration is complete. However, if there is a guest reset during the migration, the fd can bec

[Qemu-devel] [PATCH 1/6] target-ppc: Remove unused kvmppc_update_sdr1() stub

2016-02-04 Thread David Gibson
This KVM stub implementation isn't used anywhere. Signed-off-by: David Gibson --- target-ppc/kvm_ppc.h | 5 - 1 file changed, 5 deletions(-) diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h index 62406ce..aaa828c 100644 --- a/target-ppc/kvm_ppc.h +++ b/target-ppc/kvm_ppc.h @@ -184,1

[Qemu-devel] [PATCH 6/6] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-02-04 Thread David Gibson
When a Power cpu with 64-bit hash MMU has it's hash page table (HPT) pointer updated by a write to the SDR1 register we need to update some derived variables. Likewise, when the cpu is configured for an external HPT (one not in the guest memory space) some derived variables need to be updated. Cu

[Qemu-devel] [PATCH 2/6] target-ppc: Include missing MMU models for SDR1 in info registers

2016-02-04 Thread David Gibson
The HMP command "info registers" produces somewhat different information on different ppc cpu variants. For those with a hash MMU it's supposed to include the SDR1, DAR and DSISR registers related to the MMU. However, the switch is missing a couple of MMU model variants, meaning we will miss out

Re: [Qemu-devel] [PATCH] hw: fix some debug message format strings

2016-02-04 Thread David Gibson
On Thu, Feb 04, 2016 at 06:40:57PM +, Alyssa Milburn wrote: > Signed-off-by: Alyssa Milburn Applied to ppc-for-2.6, thanks. > --- > hw/nvram/mac_nvram.c | 6 -- > hw/pci-host/uninorth.c | 4 ++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/hw/nvram/mac_nvram.c

[Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-04 Thread Fam Zheng
The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. The output of iotests 109 is updated because we now report

Re: [Qemu-devel] [iGVT-g] RE: VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-04 Thread Tian, Kevin
> From: Song, Jike > Sent: Thursday, February 04, 2016 11:05 PM > > On 02/04/2016 12:16 PM, Tian, Kevin wrote: > > 5) Pin/unpin guest memory > > -- > > IGD or any PCI passthru should have same requirement. So we should be > > able to leverage existing code in VFIO. The only tricky

[Qemu-devel] [PATCH v12 0/2] mirror: Improve zero write and discard

2016-02-04 Thread Fam Zheng
v12: Treat target cluster size as BDRV_SECTOR_SIZE if bdrv_get_info failed or doesn't set bdi.cluster_size; v11: Rebase. The only difference is the "file" parameter of bdrv_get_block_status_above. Patch 1 rewrites mirror_iteration. Patch 2 is a small DRY cleaning up. The main benefit i

[Qemu-devel] [PATCH v12 2/2] mirror: Add mirror_wait_for_io

2016-02-04 Thread Fam Zheng
The three lines are duplicated a number of times now, refactor a function. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/mirror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 48cd0b3..9635fa8 100

Re: [Qemu-devel] [PATCH] quorum: fix segfault when read fails in fifo mode

2016-02-04 Thread Changlong Xie
On 02/04/2016 08:24 PM, Kevin Wolf wrote: Am 04.02.2016 um 11:19 hat Changlong Xie geschrieben: Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/quorum.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a5ae4b8..0965277 100644 --

Re: [Qemu-devel] [PATCH 0/2] pci core function cleanup

2016-02-04 Thread Cao jin
And this one got reviewed-by too, could it be accepted? On 01/27/2016 06:29 PM, Cao jin wrote: See each commit message says please. Cao jin (2): pci core: function pci_host_bus_register() cleanup pci core: function pci_bus_init() cleanup hw/pci/pci.c | 13 + 1 file changed

Re: [Qemu-devel] [PATCH v4 0/2] change type of pci_bridge_initfn()

2016-02-04 Thread Cao jin
Hi mst, the series has got reviewed-by for a long while, could it be accepted now? On 01/15/2016 10:23 AM, Cao jin wrote: v4 changelog: 1. fix apb bridge build fail as Marcel find. Test: 1. Compiled on all arch(configure without param) 2. make check passed 3. Hacked to test dec bridge rea

[Qemu-devel] [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-04 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD and DVD media. Signed-off-by: John Arbuckl

Re: [Qemu-devel] [PATCH v2 06/17] crypto: add block encryption framework

2016-02-04 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > Add a generic framework for support different block encryption > formats. Upon instantiating a QCryptoBlock object, it will read > the encryption header and extract the encryption keys. It is > then possible to call methods to encrypt/decrypt data

Re: [Qemu-devel] [PATCH v2 00/10] target-i386 addressing cleanups

2016-02-04 Thread Richard Henderson
On 12/18/2015 06:19 AM, Richard Henderson wrote: This is a rebase of the patch set I posted in July. There are no substantive changes since then. The only comment at the time was re 05/10, where Paolo suggests optimizing access to CS overrides with the constant that we know via the TB operands.

Re: [Qemu-devel] [PATCH v5 5/9] qemu-log: support simple pid substitution in logfile

2016-02-04 Thread Eric Blake
On 02/04/2016 03:26 PM, Richard Henderson wrote: > On 02/05/2016 01:56 AM, Alex Bennée wrote: >> +if (g_strrstr(filename, "%d")) { >> +/* if we are going to format this we'd better validate first */ >> +if (g_regex_match_simple("^[^%]+%d[^%]+$", filename, 0, 0)) { > > Why g_str

Re: [Qemu-devel] [PATCH v2 05/17] crypto: add support for anti-forensic split algorithm

2016-02-04 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > The LUKS format specifies an anti-forensic split algorithm which > is used to artificially expand the size of the key material on > disk. This is an implementation of that algorithm. > > Signed-off-by: Daniel P. Berrange > --- > crypto/Makefile

Re: [Qemu-devel] [PATCH v5 9/9] cputlb: modernise the debug support

2016-02-04 Thread Richard Henderson
On 02/05/2016 01:56 AM, Alex Bennée wrote: To avoid cluttering the code with #ifdef legs we wrap up the print statements into a tlb_debug() macro. As access to the virtual TLB can get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to the qemu_log target of CPU_LOG_MMU instead of s

Re: [Qemu-devel] [PATCH v5 7/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op

2016-02-04 Thread Richard Henderson
On 02/05/2016 01:56 AM, Alex Bennée wrote: This ensures the code generation debug code will honour -dfilter if set. For the "exec" tracing I've added a new inline macro for efficiency's sake. Signed-off-by: Alex Bennée Reviewed-by: Aurelien Jarno v2 - checkpatch updates - add qemu_

Re: [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

2016-02-04 Thread Richard Henderson
On 02/05/2016 01:56 AM, Alex Bennée wrote: +gchar *range_op = g_strstr_len(r, -1, "-"); This is strchr. +range_op = g_strstr_len(r, -1, "."); Or at least if you're going to make use of strstr, search for "..". +g_strdelimit(range_val, ".", ' ');

Re: [Qemu-devel] [RFC PATCH 0/2] Early release of -drive QemuOpts

2016-02-04 Thread Paolo Bonzini
On 22/01/2016 23:38, Max Reitz wrote: > On 22.01.2016 15:01, Paolo Bonzini wrote: >> >> >> On 08/01/2016 18:37, Paolo Bonzini wrote: >>> In short, this patch gets rid of blockdev_mark_auto_del and >>> blockdev_auto_del. >>> >>> With these patches, it is possible to create a new -drive with the sa

Re: [Qemu-devel] [PATCH v2 04/17] crypto: add support for generating initialization vectors

2016-02-04 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > There are a number of different algorithms that can be used > to generate initialization vectors for disk encryption. This > introduces a simple internal QCryptoBlockIV object to provide > a consistent internal API to the different algorithms. The

[Qemu-devel] [PATCH] migration: reorder code to make it symmetric

2016-02-04 Thread Wei Yang
In qemu_savevm_state_complete_precopy(), it iterates on each device to add a json object and transfer related status to destination, while the order of the last two steps could be refined. Current order: json_start_object() save_section_header() vmstate_save() json_end_obj

Re: [Qemu-devel] [PATCH v5 5/9] qemu-log: support simple pid substitution in logfile

2016-02-04 Thread Richard Henderson
On 02/05/2016 01:56 AM, Alex Bennée wrote: +if (g_strrstr(filename, "%d")) { +/* if we are going to format this we'd better validate first */ +if (g_regex_match_simple("^[^%]+%d[^%]+$", filename, 0, 0)) { Why g_strrstr instead of strstr? There should be only one, so why loo

Re: [Qemu-devel] [PULL 38/49] acpi: take oem_id in build_header(), optionally

2016-02-04 Thread Laszlo Ersek
Thank you for picking up my patches, and for rebasing them to the SSDT removal (Igor's "[PULL 02/49] pc: acpi: merge SSDT into DSDT"). Laszlo On 02/04/16 22:53, Michael S. Tsirkin wrote: > From: Laszlo Ersek > > This patch is the continuation of commit 8870ca0e94f2 ("acpi: support > specified o

Re: [Qemu-devel] [PATCH v5 4/9] qemu-log: Improve the "exec" TB execution logging

2016-02-04 Thread Richard Henderson
On 02/05/2016 01:56 AM, Alex Bennée wrote: From: Peter Maydell Improve the TB execution logging so that it is easier to identify what is happening from trace logs: * move the "Trace" logging of executed TBs into cpu_tb_exec() so that it is emitted if and only if we actually execute a TB,

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-04 Thread Michael S. Tsirkin
On Thu, Feb 04, 2016 at 05:09:44PM -0200, Eduardo Habkost wrote: > On Thu, Feb 04, 2016 at 08:02:30PM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 04, 2016 at 03:16:17PM -0200, Eduardo Habkost wrote: > > > On Thu, Feb 04, 2016 at 06:01:50PM +0200, Michael S. Tsirkin wrote: > > > > On Sat, Jan 2

Re: [Qemu-devel] [PATCH v2 03/17] crypto: add support for PBKDF2 algorithm

2016-02-04 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > The LUKS data format includes use of PBKDF2 (Password-Based > Key Derivation Function). The Nettle library can provide > an implementation of this, but we don't want code directly > depending on a specific crypto library backend. Introduce > a inc

Re: [Qemu-devel] [PATCH v16 00/14] vfio-pci: pass the aer error to guest

2016-02-04 Thread Michael S. Tsirkin
On Thu, Feb 04, 2016 at 03:15:39PM -0500, Alex Williamson wrote: > > > - Original Message - > > On Thu, Feb 04, 2016 at 10:46:52AM -0700, Alex Williamson wrote: > > > On Thu, 4 Feb 2016 13:21:57 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu, Feb 04, 2016 at 10:04:01AM +08

[Qemu-devel] [PULL 47/49] expose floppy drive geometry and CMOS type

2016-02-04 Thread Michael S. Tsirkin
From: Roman Kagan Make it possible to query the geometry and the CMOS type of a floppy drive outside of the respective source files. It will be useful, in particular, when dynamically building ACPI tables, and will allow to properly populate the corresponding ACPI objects and thus enable BIOS-le

[Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

2016-02-04 Thread Michael S. Tsirkin
From: Roman Kagan On x86-based systems Linux determines the presence and the type of floppy drives via a query of a CMOS field. So does SeaBIOS when populating the return data for int 0x13 function 0x08. However Windows doesn't do it. Instead, it requests this information from BIOS via int 0x13/

[Qemu-devel] [PULL 41/49] pc: set the OEM fields in the RSDT and the FADT from the SLIC

2016-02-04 Thread Michael S. Tsirkin
From: Laszlo Ersek The Microsoft spec about the SLIC and MSDM ACPI tables at requires the OEM ID and OEM Table ID fields to be consistent between the SLIC and the RSDT/XSDT. That further affects the FADT, because a similar match between the FADT a

[Qemu-devel] [PULL 45/49] net: set endianness on all backend devices

2016-02-04 Thread Michael S. Tsirkin
From: Laurent Vivier commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 vhost-net: tell tap backend about the vnet endianness makes vhost net to set the endianness of the device, but only for the first device. In case of multiqueue, we have multiple devices... This patch sets the endianness

[Qemu-devel] [PULL 36/49] pc: Move APIC and NUMA data from PcGuestInfo to PCMachineState

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/i386/pc.h | 14 +- hw/i386/acpi-build.c | 22 +- hw/i386/pc.c | 20 ++--

[Qemu-devel] [PULL 40/49] acpi: add function to extract oem_id and oem_table_id from the user's SLIC

2016-02-04 Thread Michael S. Tsirkin
From: Laszlo Ersek The acpi_get_slic_oem() function stores pointers to these fields in the (first) SLIC table that the user passes in with the -acpitable switch. Cc: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) Cc: Igor Mammedov (supporter:ACPI/SMBIOS) Cc: Richard W.M. Jones Cc: Aleksei Kovur

[Qemu-devel] [PULL 49/49] acpi: update expected DSDT

2016-02-04 Thread Michael S. Tsirkin
Previous patches ("i386: populate floppy drive information in DSDT" and ("i386/acpi: make floppy controller object dynamic") change the floppy description in DSDT (and remove the floppy device if it's not present). Update expected files accordingly. Signed-off-by: Michael S. Tsirkin --- tests/ac

[Qemu-devel] [PULL 35/49] pc: Move PcGuestInfo.fw_cfg to PCMachineState

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/i386/pc.h | 2 +- hw/i386/acpi-build.c | 7 +++ hw/i386/pc.c | 10 -- 3 files changed, 8 insertions(+), 11

[Qemu-devel] [PULL 39/49] acpi: expose oem_id and oem_table_id in build_rsdt()

2016-02-04 Thread Michael S. Tsirkin
From: Laszlo Ersek Since build_rsdt() is implemented as common utility code (in "hw/acpi/aml-build.c"), it should expose -- and forward -- the oem_id and oem_table_id parameters between board code and the generic build_header() function. Cc: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) Cc: Igor

[Qemu-devel] [PULL 46/49] i386/acpi: make floppy controller object dynamic

2016-02-04 Thread Michael S. Tsirkin
From: Roman Kagan Instead of statically declaring the floppy controller in DSDT, with its _STA method depending on some obscure bit in the parent ISA bridge, add the object dynamically to DSDT via AML API only when the controller is present. The _STA method is no longer necessary and is therefor

[Qemu-devel] [PULL 31/49] acpi: Don't save PcGuestInfo on AcpiBuildState

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost We don't need to save the pointer on AcpiBuildState, as it is not used anymore. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 3 --- 1 file changed, 3 deletions(

[Qemu-devel] [PULL 44/49] fix MSI injection on Xen

2016-02-04 Thread Michael S. Tsirkin
From: Stefano Stabellini On Xen MSIs can be remapped into pirqs, which are a type of event channels. It's mostly for the benefit of PCI passthrough devices, to avoid the overhead of interacting with the emulated lapic. However remapping interrupts and MSIs is also supported for emulated devices,

[Qemu-devel] [PULL 38/49] acpi: take oem_id in build_header(), optionally

2016-02-04 Thread Michael S. Tsirkin
From: Laszlo Ersek This patch is the continuation of commit 8870ca0e94f2 ("acpi: support specified oem table id for build_header"). It will allow us to control the OEM ID field too in the SDT header. Cc: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) Cc: Igor Mammedov (supporter:ACPI/SMBIOS) Cc:

[Qemu-devel] [PULL 30/49] acpi: Remove guest_info parameters from functions

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get guest_info. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 35 +-- 1 file changed, 21 insertion

[Qemu-devel] [PULL 33/49] pc: Remove RAM size fields from PcGuestInfo

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost The ACPI code can use the PCMachineState fields directly. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/i386/pc.h | 1 - hw/i386/acpi-build.c | 10 +- hw/i386/pc.c

[Qemu-devel] [PULL 34/49] pc: Remove PcGuestInfo.isapc_ram_fw field

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost The code can use the PCMachineClass.pci_enabled field directly. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 2 +- hw/i386/pc_piix.c

[Qemu-devel] [PULL 27/49] pc: Eliminate struct PcGuestInfoState

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost Instead of allocating a new struct just for PcGuestInfo and the mchine_done Notifier, place them inside PCMachineState. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/i386/pc

[Qemu-devel] [PULL 32/49] pc: Remove compat fields from PcGuestInfo

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost Remove the fields: legacy_acpi_table_size, has_acpi_build, has_reserved_memory, and rsdp_in_ram from PcGuestInfo, and let the existing code use the PCMachineClass fields directly. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsi

[Qemu-devel] [PULL 22/49] ipmi: introduce a struct ipmi_sdr_compact

2016-02-04 Thread Michael S. Tsirkin
From: Cédric Le Goater Currently, sdr attributes are identified using byte offsets and this can be a bit confusing. This patch adds a struct ipmi_sdr_compact conforming to the IPMI specs and replaces byte offsets with names. It also introduces and uses a struct ipmi_sdr_header in sections of the

[Qemu-devel] [PULL 43/49] intel_iommu: large page support

2016-02-04 Thread Michael S. Tsirkin
From: Jason Wang Current intel_iommu only supports 4K page which may not be sufficient to cover guest working set. This patch tries to enable 2M and 1G mapping for intel_iommu. This is also useful for future device IOTLB implementation to have a better hit rate. Major work is adding a page mask

[Qemu-devel] [PULL 26/49] pc: Move PcGuestInfo declaration to top of file

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost The struct will be used inside PCMachineState. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/i386/pc.h | 31 --- 1 file changed, 16 insertions(+)

[Qemu-devel] [PULL 29/49] pc: Simplify xen_load_linux() signature

2016-02-04 Thread Michael S. Tsirkin
From: Eduardo Habkost We can get the PcGuestInfo struct directly from PCMachineState, and the return value is not needed at all. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/i386/pc.h | 3 +-- h

[Qemu-devel] [PULL 19/49] ipmi: replace *_MAXCMD defines

2016-02-04 Thread Michael S. Tsirkin
From: Cédric Le Goater ARRAY_SIZE() is simple to use and removes the need to pre-define the size of the command arrays. Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ipmi/ipmi_bmc_sim.c | 21 -

[Qemu-devel] [PULL 42/49] dimm: Correct type of MemoryHotplugState->base

2016-02-04 Thread Michael S. Tsirkin
From: David Gibson The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that it exists in the abstract address space of RAM regions. However, the actual usage of this field indicates that it is a concrete physical address (it's passed as an offset to memory_region_add_subgregion

[Qemu-devel] [PULL 25/49] ipmi: add ACPI power and GUID commands

2016-02-04 Thread Michael S. Tsirkin
From: Cédric Le Goater >From the specs (20.8 Get Device GUID Command), the command needs to return a GUID (Globally Unique ID), or UUID, that should never change over the lifetime of the device. qemu_uuid looked like a good candidate to start with but we could use a specific BMC property also if

[Qemu-devel] [PULL 23/49] ipmi: add get and set SENSOR_TYPE commands

2016-02-04 Thread Michael S. Tsirkin
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Acked-by: Corey Minyard Reviewed-by: Greg Kurz Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ipmi/ipmi_bmc_sim.c | 45 - 1 file changed, 44 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 24/49] ipmi: add GET_SYS_RESTART_CAUSE chassis command

2016-02-04 Thread Michael S. Tsirkin
From: Cédric Le Goater This is a simulator. Just return an unknown cause (0). Signed-off-by: Cédric Le Goater Acked-by: Corey Minyard Reviewed-by: Greg Kurz Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ipmi/ipmi_bmc_sim.c | 16 +++- 1 file changed, 15 i

[Qemu-devel] [PULL 17/49] hw/pci: ensure that only PCI/PCIe bridges can be attached to pxb/pxb-pcie devices

2016-02-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum PCI devices can't be plugged directly into PCI extra root bridges because their resources can't be computed by firmware before the ACPI tables are loaded. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c

  1   2   3   4   >