Re: [Qemu-devel] [RFC 0/3] Draft implementation of HPT resizing (qemu side)

On Mon, Jan 18, 2016 at 04:44:38PM +1100, David Gibson wrote: > Here is a draft qemu implementation of my proposed PAPR extension for > allowing runtime resizing of a KVM/ppc64 guest's hash page table. > That in turn will allow for more flexible memory hotplug. > > This should work with the guest

Re: [Qemu-devel] [PATCH v1 0/5] KVM: Hyper-V VMBus hypercalls

On 01/12/2016 01:50 PM, Andrey Smetanin wrote: The patch implements userspace exit 'KVM_EXIT_HYPERV_HCALL' for Hyper-V VMBus hypercalls(postmsg, signalevent) to handle these hypercalls by QEMU. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini CC: Joe

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

On 12/24/2015 12:33 PM, Andrey Smetanin wrote: Lately tsc page was implemented but filled with empty values. This patch setup tsc page scale and offset based on vcpu tsc, tsc_khz and HV_X64_MSR_TIME_REF_COUNT value. The valid tsc page drops HV_X64_MSR_TIME_REF_COUNT msr reads count to zero whic

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

David Gibson writes: > The functions for migrating the hash page table on pseries machine type > (htab_save_setup() and htab_load()) can report some errors with an > explicit fprintf() before returning an appropriate error code. Change these > to use error_report() instead. > > Signed-off-by: Da

Re: [Qemu-devel] [PATCH v2 0/4] set the OEM fields in the RSDT and the FADT from the SLIC

On Tue Jan 19 07:35:27 2016 GMT, Steven Newbury wrote: > > > On Mon Jan 18 14:12:09 2016 GMT, Laszlo Ersek wrote: > > This is version 2 of > > . > > > > Changes in v2 (also annotated per patch): > > - introduce acpi_get_slic_oem() [MST]

Re: [Qemu-devel] [PATCH v2 0/4] set the OEM fields in the RSDT and the FADT from the SLIC

On Mon Jan 18 14:12:09 2016 GMT, Laszlo Ersek wrote: > This is version 2 of > . > > Changes in v2 (also annotated per patch): > - introduce acpi_get_slic_oem() [MST], > - drop machine property that disables the SLIC-based override [MST].

Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings

Greg Kurz writes: > Also fix a typo in the virtio_balloon_handle_output() trace while here. > > Signed-off-by: Greg Kurz Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

Peter Maydell writes: > On 11 January 2016 at 15:19, Daniel P. Berrange wrote: >> On Mon, Dec 07, 2015 at 04:23:42PM +, Peter Maydell wrote: >>> We've had some discussion previously (on list and IRC) about adding an >>> include of "qemu/osdep.h" to everything. The basic idea is that every >>

[Qemu-devel] [PATCH v3 7/7] MAINTAINERS: Add Alistair to the maintainers list

Add Alistair Francis as the maintainer for the Netduino 2 and SMM32F205 SoC. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- MAINTAINERS | 15 +++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4030e27..24aaef4 100644 --- a/MAINTAI

[Qemu-devel] [PATCH v3 5/7] STM32F205: Connect the ADC devices

Connect the ADC devices to the STM32F205 SoC. Signed-off-by: Alistair Francis --- V2: - Fix up the device/devices commit message hw/arm/stm32f205_soc.c | 22 ++ include/hw/arm/stm32f205_soc.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/hw/arm/stm32f205

[Qemu-devel] [PATCH v3 3/7] STM32F2xx: Add the ADC device

Add the STM32F2xx ADC device. This device randomly generates values on each read. This also includes creating a hw/adc directory. Signed-off-by: Alistair Francis --- V2: - Address Peter C's comments - Create a ADC folder and move the file in there - Move some of the registers into arrays de

[Qemu-devel] [PATCH v3 4/7] STM32F2xx: Add the SPI device

Add the STM32F2xx SPI device. Signed-off-by: Alistair Francis --- V2: - Address Peter C's comments default-configs/arm-softmmu.mak | 1 + hw/ssi/Makefile.objs| 1 + hw/ssi/stm32f2xx_spi.c | 205 include/hw/ssi/stm32f2xx_spi.h |

[Qemu-devel] [PATCH v3 0/7] Update the Netduino 2 Machine

This patchset continues with the Netduino 2 and STM32F205 SoC work. This patch series makes a small change to the STM32F2xx SoC to tidy up the code. Next a feature is added to the STM32F2xx timer to display the PWM duty cycle, when debugging is enabled. Then the STM32F2xx SPI and ADC devices are

[Qemu-devel] [PATCH v3 1/7] STM32F205: Remove the individual device variables

Cleanup the individual DeviceState and SysBusDevice variables to re-use the same variable for each device. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/arm/stm32f205_soc.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --

[Qemu-devel] [PATCH v3 2/7] STM32F2xx: Display PWM duty cycle from timer

If correctly configured allow the STM32F2xx timer to print out the PWM duty cycle information. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V3: - Use OR instead of + for masking - Improve clarity of print statement V2: - Fix up if statement braces - Remove stm32f2xx_tim

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

Cao jin writes: > Seems I forgot to CC Eric, but I checked my command line history, I do > include Eric...weird Probably the broken duplicate suppression feature. Eric, are you sure the reduction in e-mail for you is worth the occasional confusion for others?

Re: [Qemu-devel] [PATCH] .travis.yml: migrate to container builds

David Gibson writes: > On Fri, Jan 15, 2016 at 10:45:09AM +, Alex Bennée wrote: >> This moves the Travis tests from their old legacy VM >> infrastructure (which only seems to run 5-6 jobs at once) to their new >> container based approach. >> >> The principle difference is there is no sudo in

Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description

Copying maintainer. Always do that even for trivial patches. Alistair Francis writes: > The description of object_property_get_int() stated that on an error > it returns NULL. This is not the case and the function will return -1 > if an error occurs. Update the commented documentation according

Re: [Qemu-devel] usb-storage assertions

On Di, 2016-01-19 at 02:49 +0300, Andrey Korolyov wrote: > On Mon, Jan 18, 2016 at 4:55 PM, Gerd Hoffmann wrote: > > Hi, > > > >> > ok. Had no trouble with freebsd, will go fetch netbsd images. What > >> > arch is this? i386? x86_64? > >> > >> i386 7.0 for the reference, but I`m sure that th

Re: [Qemu-devel] [PATCH v6 00/15] qemu-img map: Allow driver to return file of the allocated block

On Fri, 01/08 10:07, Fam Zheng wrote: > v6: Two more changes as suggested by Max: > - Fix comments of BDRV_BLOCK_OFFSET_VALID and BDRV_BLOCK_DATA; > - Really keep 102 working; > - Add rev-by in patch 11. Ping?

Re: [Qemu-devel] [PATCH] .travis.yml: migrate to container builds

On Fri, Jan 15, 2016 at 10:45:09AM +, Alex Bennée wrote: > This moves the Travis tests from their old legacy VM > infrastructure (which only seems to run 5-6 jobs at once) to their new > container based approach. > > The principle difference is there is no sudo in the containers so all > packa

Re: [Qemu-devel] [PATCHv2 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer

On Tue, Jan 19, 2016 at 03:38:09PM +1100, Alexey Kardashevskiy wrote: > On 01/19/2016 03:30 PM, David Gibson wrote: > >rtas_st_buffer() appears in spapr.h as though it were a widely used helper, > >but in fact it is only used for saving data in a format used by > >rtas_ibm_get_system_parameter().

Re: [Qemu-devel] [PATCH] spapr: Don't create ibm, dynamic-reconfiguration-memory w/o DR LMBs

On Tue, Jan 19, 2016 at 10:09:21AM +0530, Bharata B Rao wrote: > If guest doesn't have any dynamically reconfigurable (DR) logical memory > blocks (LMB), then we shouldn't create ibm,dynamic-reconfiguration-memory > device tree node. > > Signed-off-by: Bharata B Rao > --- > This applies against p

[Qemu-devel] [PATCH 3/5] ide: move buffered DMA cancel to core

Buffered DMA cancellation was added to ATAPI devices and implemented for the BMDMA HBA. Move the code over to common IDE code and allow it to be used for any HBA. Signed-off-by: John Snow --- hw/ide/core.c | 45 + hw/ide/internal.h | 1 + hw/ide/p

[Qemu-devel] [PATCH 5/5] ide: fix device_reset to not ignore pending AIO

Signed-off-by: John Snow --- hw/ide/core.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 4b4bfe5..f728d43 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -502,7 +502,6 @@ void ide_transfer_stop(IDEState *s)

[Qemu-devel] [PATCH 0/5] ide: fix atapi software reset

The ATAPI software reset function is implemented somewhat lackadaisically. Firstly, it is valid only for ATAPI drives - not HDs. If a HD should receive this command while BSY, it should be ignored like any other command instead of aborted. A non-BSY HD is free to abort the command in the usual fas

[Qemu-devel] [PATCH 2/5] ide: code motion

Shuffle the reset function upwards. Signed-off-by: John Snow --- hw/ide/core.c | 116 +- 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index ba33064..75486c2 100644 --- a/hw/ide/core.c +++ b/h

[Qemu-devel] [PATCH 1/5] ide: Prohibit RESET on IDE drives

This command is meant for ATAPI devices only, prohibit acknowledging it with a command aborted response when an IDE device is busy. Signed-off-by: John Snow --- hw/ide/core.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index da3baab.

[Qemu-devel] [PATCH 4/5] ide: Add silent DRQ cancellation

Split apart the ide_transfer_stop function into two versions: one that interrupts and one that doesn't. The one that doesn't can be used to halt any PIO transfers that are in the DRQ phase. It will not halt any PIO transfers that are currently in the process of buffering data for the guest to read.

Re: [Qemu-devel] [PATCHv2 2/3] spapr: Remove rtas_st_buffer_direct()

On 01/19/2016 03:30 PM, David Gibson wrote: rtas_st_buffer_direct() is a not particularly useful wrapper around cpu_physical_memory_write(). All the callers are in rtas_ibm_configure_connector, where it's better handled by local helper. Signed-off-by: David Gibson Reviewed-by: Alexey Kardash

[Qemu-devel] [PATCH] spapr: Don't create ibm, dynamic-reconfiguration-memory w/o DR LMBs

If guest doesn't have any dynamically reconfigurable (DR) logical memory blocks (LMB), then we shouldn't create ibm,dynamic-reconfiguration-memory device tree node. Signed-off-by: Bharata B Rao --- This applies against ppc-for-2.6 branch of David Gibson's tree. hw/ppc/spapr.c | 9 - 1 f

Re: [Qemu-devel] [PATCHv4 7/8] pseries: Clean up error reporting in ppc_spapr_init()

On 01/19/2016 02:39 PM, David Gibson wrote: This function includes a number of explicit fprintf()s for errors. Change these to use error_report() instead. Also replace the single exit(EXIT_FAILURE) with an explicit exit(1), since the latter is the more usual idiom in qemu by a large margin. Sig

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

On 01/19/2016 02:39 PM, David Gibson wrote: The functions for migrating the hash page table on pseries machine type (htab_save_setup() and htab_load()) can report some errors with an explicit fprintf() before returning an appropriate error code. Change these to use error_report() instead. Signe

Re: [Qemu-devel] [PATCHv4 5/8] pseries: Clean up error handling in spapr_rtas_register()

On 01/19/2016 02:39 PM, David Gibson wrote: The errors detected in this function necessarily indicate bugs in the rest of the qemu code, rather than an external or configuration problem. So, a simple assert() is more appropriate than any more complex error reporting. Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCHv4 2/8] pseries: Cleanup error handling of spapr_cpu_init()

On 01/19/2016 02:39 PM, David Gibson wrote: Currently spapr_cpu_init() is hardcoded to handle any errors as fatal. That works for now, since it's only called from initial setup where an error here means we really can't proceed. However, we'll want to handle this more flexibly for cpu hotplug in

[Qemu-devel] [PATCHv2 0/3] Reduce abuse of rtas_st / rtas_ld

The rtas_ld() and rtas_st() helpers were designed for loading RTAS arguments and storing RTAS returns which are in a simple, common array format. However, a number of RTAS routines - and even non-RTAS routines - have started using these for accessing other memory buffers, where the normal qemu mem

[Qemu-devel] [PATCHv2 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer

rtas_st_buffer() appears in spapr.h as though it were a widely used helper, but in fact it is only used for saving data in a format used by rtas_ibm_get_system_parameter(). This changes it to a local helper more specifically for that function. While we're there fix a couple of small defects in rt

Re: [Qemu-devel] [PATCHv4 6/8] pseries: Clean up error handling in xics_system_init()

On 01/19/2016 02:39 PM, David Gibson wrote: Use the error handling infrastructure to pass an error out from try_create_xics() instead of assuming &error_abort - the caller is in a better position to decide on error handling policy. Also change the error handling from an &error_abort to &error_fa

Re: [Qemu-devel] [PATCHv4 3/8] pseries: Clean up error handling in spapr_validate_node_memory()

On 01/19/2016 02:39 PM, David Gibson wrote: Use error_setg() and return an error, rather than using an explicit exit(). Also improve messages, and be more explicit about which constraint failed. Signed-off-by: David Gibson Reviewed-by: Bharata B Rao Reviewed-by: Thomas Huth Reviewed-by: A

Re: [Qemu-devel] [PATCHv4 4/8] pseries: Cleanup error handling in spapr_vga_init()

On 01/19/2016 02:39 PM, David Gibson wrote: Use error_setg() to return an error rather than an explicit exit(). Previously it was an exit(0) instead of a non-zero exit code, which was simply a bug. Also improve the error message. While we're at it change the type of spapr_vga_init() to bool sin

Re: [Qemu-devel] [PATCHv4 1/8] ppc: Cleanup error handling in ppc_set_compat()

On 01/19/2016 02:39 PM, David Gibson wrote: Current ppc_set_compat() returns -1 for errors, and also (unconditionally) reports an error message. The caller in h_client_architecture_support() may then report it again using an outdated fprintf(). Clean this up by using the modern error reporting

[Qemu-devel] [PATCHv2 2/3] spapr: Remove rtas_st_buffer_direct()

rtas_st_buffer_direct() is a not particularly useful wrapper around cpu_physical_memory_write(). All the callers are in rtas_ibm_configure_connector, where it's better handled by local helper. Signed-off-by: David Gibson --- hw/ppc/spapr_rtas.c| 17 ++--- include/hw/ppc/spapr.h

Re: [Qemu-devel] [PATCH 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer

On Tue, Jan 19, 2016 at 01:00:50PM +1100, Alexey Kardashevskiy wrote: > On 01/16/2016 12:14 PM, David Gibson wrote: > >rtas_st_buffer() appears in spapr.h as though it were a widely used helper, > >but in fact it is only used for saving data in a format used by > >rtas_ibm_get_system_parameter().

[Qemu-devel] [PATCHv2 3/3] spapr: Remove abuse of rtas_ld() in h_client_architecture_support

h_client_architecture_support() uses rtas_ld() for general purpose memory access, despite the fact that it's not an RTAS routine at all and rtas_ld makes things more awkward. Clean this up by replacing rtas_ld() calls with appropriate ldXX_phys() calls. Signed-off-by: David Gibson Reviewed-by: A

Re: [Qemu-devel] [PATCH 2/3] spapr: Remove rtas_st_buffer_direct()

On Tue, Jan 19, 2016 at 01:07:23PM +1100, Alexey Kardashevskiy wrote: > On 01/16/2016 12:14 PM, David Gibson wrote: > >rtas_st_buffer_direct() is a not particularly useful wrapper around > >cpu_physical_memory_write(). All the callers are in > >rtas_ibm_configure_connector, where it's better handl

Re: [Qemu-devel] [PATCH COLO-Frame v13 38/39] colo: Use default buffer-filter to buffer and release packets

On 12/29/2015 03:09 PM, zhanghailiang wrote: > Enable default filter to buffer packets and release the > packets after a checkpoint. > > Signed-off-by: zhanghailiang > Cc: Jason Wang > Cc: Yang Hongyang > --- > v12: > - Add a helper function to check if all netdev supports buffer packets. > -

Re: [Qemu-devel] [RFC PATCH v2 00/10] Introduce Intel 82574 GbE Controller Emulation (e1000e)

On 01/19/2016 01:35 AM, Leonid Bloch wrote: > Hello All, > > This series is the latest code of the e1000e device emulation being developed. > > Changes since v1: > > 1. Added support for all the device features: > - Interrupt moderation. > - RSS. > - Multiqueue. > 2. Simulated exact PCI/PCI

[Qemu-devel] [PATCHv4 1/8] ppc: Cleanup error handling in ppc_set_compat()

Current ppc_set_compat() returns -1 for errors, and also (unconditionally) reports an error message. The caller in h_client_architecture_support() may then report it again using an outdated fprintf(). Clean this up by using the modern error reporting mechanisms. Also add strerror(errno) to the e

[Qemu-devel] [PATCHv4 7/8] pseries: Clean up error reporting in ppc_spapr_init()

This function includes a number of explicit fprintf()s for errors. Change these to use error_report() instead. Also replace the single exit(EXIT_FAILURE) with an explicit exit(1), since the latter is the more usual idiom in qemu by a large margin. Signed-off-by: David Gibson --- hw/ppc/spapr.c

[Qemu-devel] [PATCHv4 6/8] pseries: Clean up error handling in xics_system_init()

Use the error handling infrastructure to pass an error out from try_create_xics() instead of assuming &error_abort - the caller is in a better position to decide on error handling policy. Also change the error handling from an &error_abort to &error_fatal, since this occurs during the initial mach

[Qemu-devel] [PATCHv4 2/8] pseries: Cleanup error handling of spapr_cpu_init()

Currently spapr_cpu_init() is hardcoded to handle any errors as fatal. That works for now, since it's only called from initial setup where an error here means we really can't proceed. However, we'll want to handle this more flexibly for cpu hotplug in future so generalize this using the error repo

[Qemu-devel] [PATCHv4 0/8] Cleanups to error reporting on ppc and spapr

Another spin of my patches to clean up a bunch of error reporting in the pseries machine type and target-ppc code, to better use the error API. Once reviewed, I hope to merge this into ppc-for-2.6 shortly. Changes in v4: * Corrected a place I'd accidentally messed up the indenting * Dropped the

[Qemu-devel] [PATCHv4 3/8] pseries: Clean up error handling in spapr_validate_node_memory()

Use error_setg() and return an error, rather than using an explicit exit(). Also improve messages, and be more explicit about which constraint failed. Signed-off-by: David Gibson Reviewed-by: Bharata B Rao Reviewed-by: Thomas Huth --- hw/ppc/spapr.c | 37 ++---

[Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

The functions for migrating the hash page table on pseries machine type (htab_save_setup() and htab_load()) can report some errors with an explicit fprintf() before returning an appropriate error code. Change these to use error_report() instead. Signed-off-by: David Gibson Reviewed-by: Thomas Hu

[Qemu-devel] [PATCHv4 4/8] pseries: Cleanup error handling in spapr_vga_init()

Use error_setg() to return an error rather than an explicit exit(). Previously it was an exit(0) instead of a non-zero exit code, which was simply a bug. Also improve the error message. While we're at it change the type of spapr_vga_init() to bool since that's how we're using it anyway. Signed-o

[Qemu-devel] [PATCHv4 5/8] pseries: Clean up error handling in spapr_rtas_register()

The errors detected in this function necessarily indicate bugs in the rest of the qemu code, rather than an external or configuration problem. So, a simple assert() is more appropriate than any more complex error reporting. Signed-off-by: David Gibson Reviewed-by: Thomas Huth --- hw/ppc/spapr_

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

> Actually, someone has done like that before and cause a migration bug, See > commit f1c72795af573b24a7da5eb52375c9aba8a37972, and the fixing patch is > commit 9ef051e5536b6368a1076046ec6c4ec4ac12b5c6 > Revert "migration: do not sent zero pages in bulk stage" Thanks for your information, I didn't

Re: [Qemu-devel] [PATCH COLO-Frame v13 36/39] filter-buffer: Introduce a helper function to enable/disable default filter

On 12/29/2015 03:09 PM, zhanghailiang wrote: > The default buffer filter doesn't buffer packets in default, > but we need to buffer packets for COLO or Micro-checkpoint, > Here we add a helper function to enable/disable filter's buffer > capability. > > Signed-off-by: zhanghailiang > Cc: Jason W

Re: [Qemu-devel] virtio-blk-dataplane performance numbers

On Fri, 01/15 12:35, Diana Madalina Craciun wrote: > Hi, > > I made some measurements guest vs bare metal (using virtio-data-plane) > and got some results I cannot fully explain. > > First some details about the setup: > > - I have an ARM v8 hardware + 1 SSD connected to SATA. > > I have run FI

Re: [Qemu-devel] [PATCH v2 2/4] acpi: expose oem_id and oem_table_id in build_rsdt()

On 2016/1/18 22:12, Laszlo Ersek wrote: > Since build_rsdt() is implemented as common utility code (in > "hw/acpi/aml-build.c"), it should expose -- and forward -- the oem_id and > oem_table_id parameters between board code and the generic build_header() > function. > > Cc: "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH v2 1/4] acpi: take oem_id in build_header(), optionally

On 2016/1/18 22:12, Laszlo Ersek wrote: > This patch is the continuation of commit 8870ca0e94f2 ("acpi: support > specified oem table id for build_header"). It will allow us to control the > OEM ID field too in the SDT header. > > Cc: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) > Cc: Igor Mamm

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

On 2016/1/19 11:11, Hailiang Zhang wrote: On 2016/1/19 9:26, Li, Liang Z wrote: On 2016/1/15 18:24, Li, Liang Z wrote: It seems that this patch is incorrect, if the no-zero pages are zeroed again during !ram_bulk_stage, we didn't send the new zeroed page, there will be an error. If not in ra

Re: [Qemu-devel] [PATCH COLO-Frame v13 35/39] filter-buffer: Accept zero interval

On 12/29/2015 03:09 PM, zhanghailiang wrote: > For default buffer filter, its 'interval' value is zero, > so here we should accept zero interval. > > Signed-off-by: zhanghailiang > Reviewed-by: Yang Hongyang > Cc: Jason Wang > --- > v12: > - Add Reviewed-by tag > v11: > - Add comment > v10: >

Re: [Qemu-devel] [PATCH COLO-Frame v13 34/39] net/filter-buffer: Add default filter-buffer for each netdev

On 12/29/2015 03:09 PM, zhanghailiang wrote: > We add each netdev (except vhost-net) a default filter-buffer, > which will be used for COLO or Micro-checkpoint to buffer VM's packets. > The name of default filter-buffer is 'nop'. > For the default filter-buffer, it will not buffer any packets in

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

> > Not yet, I saw Dave's comment's, it will beak post copy, it's not hard to > > fix > this. > > A more important thing is Paolo's comments, I don't know in which case > this patch will break LM. Do you have any idea about this? > > Hope that QEMU don't write data to the block 'pc.ram'. > > > >

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

On 2016/1/19 9:26, Li, Liang Z wrote: On 2016/1/15 18:24, Li, Liang Z wrote: It seems that this patch is incorrect, if the no-zero pages are zeroed again during !ram_bulk_stage, we didn't send the new zeroed page, there will be an error. If not in ram_bulk_stage, still send the header, could

Re: [Qemu-devel] qcow2 snapshot + resize

>I guess the only thing that would need to implement something new is >qcow2_snapshot_goto(), which currently refuses to load a snapshot that >has a different disk size. >Once this is done, just removing the check in qcow2_truncate() should be >okay. Thanks! I'll see what I can do, later.

Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow

On 01/19/2016 12:54 AM, Alistair Francis wrote: > On Mon, Jan 18, 2016 at 2:06 AM, Peter Maydell > wrote: >> On 18 January 2016 at 09:57, Jason Wang wrote: >>> Thanks for the pointer. >>> >>> In section 16.1.5, it said >>> >>> "Jumbo frames are not supported." >>> >>> So it was in fact not an

Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow

On 01/18/2016 06:06 PM, Peter Maydell wrote: > On 18 January 2016 at 09:57, Jason Wang wrote: >> Thanks for the pointer. >> >> In section 16.1.5, it said >> >> "Jumbo frames are not supported." >> >> So it was in fact not an unimplemented feature? > I have a vague feeling from the last time I lo

[Qemu-devel] [Bug 1535497] [NEW] Guest can not boot up when assigned more than 20 vcpus with option "-no-acpi"

Public bug reported: Environment: --- KVM commit/branch: da3f7ca3/next Qemu commit/branch: 7b8a354d/master Host OS: RHEL7.2 ia32e Host Kernel: 4.4-rc2 Guest OS: RHEL7.2 ia32e Description: When assign more than 20 vpcus with optio

[Qemu-devel] [Bug 1535497] Re: Guest can not boot up when assigned more than 20 vcpus with option "-no-acpi"

** Attachment added: "guest log" https://bugs.launchpad.net/qemu/+bug/1535497/+attachment/4552328/+files/guest.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1535497 Title: Guest can not boo

Re: [Qemu-devel] [PATCH 3/3] spapr: Remove abuse of rtas_ld() in h_client_architecture_support

On 01/16/2016 12:14 PM, David Gibson wrote: h_client_architecture_support() uses rtas_ld() for general purpose memory access, despite the fact that it's not an RTAS routine at all and rtas_ld makes things more awkward. Clean this up by replacing rtas_ld() calls with appropriate ldXX_phys() calls

Re: [Qemu-devel] [PATCH 2/3] spapr: Remove rtas_st_buffer_direct()

On 01/16/2016 12:14 PM, David Gibson wrote: rtas_st_buffer_direct() is a not particularly useful wrapper around cpu_physical_memory_write(). All the callers are in rtas_ibm_configure_connector, where it's better handled by local helper. Signed-off-by: David Gibson --- hw/ppc/spapr_rtas.c

Re: [Qemu-devel] [PATCH 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer

On 01/16/2016 12:14 PM, David Gibson wrote: rtas_st_buffer() appears in spapr.h as though it were a widely used helper, but in fact it is only used for saving data in a format used by rtas_ibm_get_system_parameter(). We can fold it into that caller just as simply. While we're there fix a couple

Re: [Qemu-devel] [PATCH COLO-Frame v13 34/39] net/filter-buffer: Add default filter-buffer for each netdev

ping? The other part of this series have been fully reviewed except this net related part. We hope COLO frame could be merged in qemu 2.6, so please help us. Any comments will be welcomed, thanks. zhanghailiang On 2016/1/11 9:26, Hailiang Zhang wrote: Hi Jason, Could you please help reviewin

Re: [Qemu-devel] [PATCHv3 3/9] pseries: Clean up hash page table allocation error handling

On Mon, Jan 18, 2016 at 11:21:08AM +0100, Markus Armbruster wrote: > Thomas Huth writes: > > > On 18.01.2016 05:24, David Gibson wrote: > >> The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > >> all errors with error_setg(&error_abort, ...). > >> > >> But really, the call

Re: [Qemu-devel] [PATCHv3 8/9] pseries: Clean up error reporting in ppc_spapr_init()

On Mon, Jan 18, 2016 at 10:31:42AM +0100, Thomas Huth wrote: > On 18.01.2016 05:24, David Gibson wrote: > > This function includes a number of explicit fprintf()s for errors. > > Change these to use error_report() instead. > > > > Also replace the single exit(EXIT_FAILURE) with an explicit exit(1)

[Qemu-devel] [PATCHv2] sysbus: Remove ignored return value of FindSysbusDeviceFunc

Functions of type FindSysbusDeviceFunc currently return an integer. However, this return value is always ignored by the caller in find_sysbus_device(). This changes the function type to return void, to avoid confusion over the function semantics. Signed-off-by: David Gibson --- I recently screw

Re: [Qemu-devel] [PATCH v16 09/14] add check reset mechanism when hotplug vfio device

On 01/18/2016 07:03 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Since we support multi-function hotplug. the function 0 indicate I think you wanted , instead of ., also I would suggest "..., function 0 indicates..." the closure of the slot, so we hav

[Qemu-devel] [PATCH v1 1/1] arm_gic: Update ID registers based on revision

Update the GIC ID registers (registers above 0xfe0) based on the GIC revision instead of using the sames values for all GIC implementations. Signed-off-by: Alistair Francis Tested-by: Sören Brinkmann --- hw/intc/arm_gic.c | 29 ++--- 1 file changed, 26 insertions(+), 3

Re: [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize()

Seems I forgot to CC Eric, but I checked my command line history, I do include Eric...weird On 01/17/2016 08:13 PM, Cao jin wrote: v6 changelog: 1. split modification of xen_host_pci_sysfs_path() into a separate new patch as 1/6 shows. 2. 'bug' fix of qemu_strtoul(), in patch 2/6 & 3/6 3. G

Re: [Qemu-devel] [PATCH v1 1/1] arm_gic: Include the GIC ArchRev in the ICPIDR2 register

On Mon, Jan 18, 2016 at 2:13 PM, Peter Maydell wrote: > On 18 January 2016 at 21:41, Alistair Francis > wrote: >> On Mon, Jan 11, 2016 at 5:58 AM, Peter Maydell >> wrote: >>> The current implementation of the ID registers seems to be >>> simply "like the 11MPCore interrupt controller". I think

Re: [Qemu-devel] [PATCH v14 0/8] Block replication for continuous checkpoints

ping... It seems that there is no feedback for a long time, we hope COLO prototype could be merged in QEMU 2.6, it depends on this series, so please help us. Thanks. zhanghailiang On 2016/1/14 9:12, Changlong Xie wrote: It seems i missed someone in CC list, add them. Thanks -Xie On 01/1

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

> On 2016/1/15 18:24, Li, Liang Z wrote: > >> It seems that this patch is incorrect, if the no-zero pages are > >> zeroed again during !ram_bulk_stage, we didn't send the new zeroed > >> page, there will be an error. > >> > > > > If not in ram_bulk_stage, still send the header, could you explain wh

Re: [Qemu-devel] CMSG_SPACE() causing compile time error on Mac OS X

On Jan 18, 2016, at 5:09 PM, Peter Maydell wrote: > On 18 January 2016 at 21:09, Programmingkid wrote: >> >> On Jan 18, 2016, at 3:49 PM, Peter Maydell wrote: >>> Can you say what 'gcc --version' prints for you? That will >>> tell us the clang version number, which is more interesting >>> than

Re: [Qemu-devel] [PATCH 1/7] target-ppc: kvm: fix floating point registers sync on little-endian hosts

On Mon, Jan 18, 2016 at 09:51:56AM +0100, Greg Kurz wrote: > On Mon, 18 Jan 2016 13:16:44 +1100 > David Gibson wrote: > > > On Fri, Jan 15, 2016 at 04:00:12PM +0100, Greg Kurz wrote: > > > On VSX capable CPUs, the 32 FP registers are mapped to the high-bits > > > of the 32 first VSX registers. So

Re: [Qemu-devel] [PATCH] sysbus: Remove ignored return value of FindSysbusDeviceFunc

On Mon, Jan 18, 2016 at 06:45:14PM +0100, Andreas Färber wrote: > Am 18.01.2016 um 05:39 schrieb David Gibson: > > Functions of type FindSysbusDeviceFunc currently return an integer. I > > recently made an error in a patch because I assumed that this return value > > would control whether iteratio

Re: [Qemu-devel] [PATCHv3 3/9] pseries: Clean up hash page table allocation error handling

On Mon, Jan 18, 2016 at 09:47:59AM +0100, Thomas Huth wrote: > On 18.01.2016 05:24, David Gibson wrote: > > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > > all errors with error_setg(&error_abort, ...). > > > > But really, the callers are really better placed to decide

Re: [Qemu-devel] [PATCHv3 6/9] pseries: Clean up error handling in spapr_rtas_register()

On Mon, Jan 18, 2016 at 10:20:24AM +0100, Thomas Huth wrote: > On 18.01.2016 05:24, David Gibson wrote: > > The errors detected in this function necessarily indicate bugs in the rest > > of the qemu code, rather than an external or configuration problem. > > > > So, a simple assert() is more appro

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] target-ppc: use cpu_write_xer() helper in cpu_post_load

On Mon, Jan 18, 2016 at 08:31:02AM +, Mark Cave-Ayland wrote: > On 18/01/16 03:12, David Gibson wrote: > > > On Fri, Jan 08, 2016 at 01:25:32PM +1100, Alexey Kardashevskiy wrote: > >> On 01/07/2016 05:22 AM, Mark Cave-Ayland wrote: > >>> Otherwise some internal xer variables fail to get set po

Re: [Qemu-devel] usb-storage assertions

On Mon, Jan 18, 2016 at 4:55 PM, Gerd Hoffmann wrote: > Hi, > >> > ok. Had no trouble with freebsd, will go fetch netbsd images. What >> > arch is this? i386? x86_64? >> >> i386 7.0 for the reference, but I`m sure that this wouldn`t matter in >> any way. > > 7.0 trace: Whoops, sorry, should

[Qemu-devel] [PATCH] linux-user,ppc: synchronize syscall_nr.h

Synchronize with include/uapi/asm/unistd.h from kernel v4.4 This allows to use timerfd_create(). Signed-off-by: Laurent Vivier --- linux-user/ppc/syscall_nr.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/linux-user/ppc/syscall_nr.h b/linux-user/ppc/syscall_

[Qemu-devel] [RE-RESEND PATCH] pci: Adjust PCI config limit based on bus topology

A conventional PCI bus does not support config space accesses above the standard 256 byte configuration space. PCIe-to-PCI bridges are not permitted to forward transactions if the extended register address field is non-zero and must handle it as an unsupported request (PCIe bridge spec rev 1.0, 4.

[Qemu-devel] [PATCH] linux-user: fix realloc size of target_fd_trans.

target_fd_trans is an array of "TargetFdTrans *": compute size accordingly. Use g_renew() as proposed by Paolo. Reported-by: Paolo Bonzini Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-

Re: [Qemu-devel] [PATCH v1 1/1] arm_gic: Include the GIC ArchRev in the ICPIDR2 register

On 18 January 2016 at 21:41, Alistair Francis wrote: > On Mon, Jan 11, 2016 at 5:58 AM, Peter Maydell > wrote: >> The current implementation of the ID registers seems to be >> simply "like the 11MPCore interrupt controller". I think we >> should get them right more generally if we're going to fi

Re: [Qemu-devel] CMSG_SPACE() causing compile time error on Mac OS X

On 18 January 2016 at 21:09, Programmingkid wrote: > > On Jan 18, 2016, at 3:49 PM, Peter Maydell wrote: >> Can you say what 'gcc --version' prints for you? That will >> tell us the clang version number, which is more interesting >> than what clang claims its gcc-compatibility is. > > $ gcc-4.9 --

Re: [Qemu-devel] [PATCH v1 08/17] target-arm: cpu: Move cpu_is_big_endian to header

On Sun, Jan 17, 2016 at 11:12 PM, Peter Crosthwaite wrote: > From: Peter Crosthwaite > > There is a CPU data endianness test that is used to drive the > virtio_big_endian test. > > Move this up to the header so it can be more generally used for endian > tests. The KVM specific cpu_syncronize_stat

Re: [Qemu-devel] [PATCH v1 1/1] arm_gic: Include the GIC ArchRev in the ICPIDR2 register

On Mon, Jan 11, 2016 at 5:58 AM, Peter Maydell wrote: > On 8 January 2016 at 18:57, Alistair Francis > wrote: >> The ARM GIC documentation (page 4-119) describes that bits >> 7 to 4 of the ICPIDR2 register should include the GIC architecture >> version. This patche ORs the version into the existi

Re: [Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

Got it. Thanks, I missed that line while reading the spec. Is docs/specs/vhost-user.txt the official spec ? -- - Thanks char * (*shesha) (uint64_t cache, uint8_t F00D) { return 0xC0DE; } From: "Michael S. Tsirkin" mailto:m...@redhat.com>> Date: Sunday, January 17, 2016 at 3:23 AM To: Cisco E

Re: [Qemu-devel] [PATCH] cpu: Clean up includes

On 01/18/2016 11:05 AM, Peter Maydell wrote: >>> +++ b/qom/cpu.c >>> @@ -18,6 +18,7 @@ >>> * >>> */ >>> >>> +#include "qemu/osdep.h" >>> #include "qemu-common.h" >> >> Shouldn't qemu-common.h include osdep.h? > > It does, but the intention is that e

  1   2   3   4   >