[Qemu-devel] [Bug 1395217] Re: Networking in qemu 2.0.0 and beyond is not compatible with Open Solaris (Illumos) 5.11

2015-12-14 Thread Jan Vlug
I fixed this by adding the configuration in the xml configuration file: SandyBridge See also attachement (https://bugzilla.redhat.com/attachment.cgi?id=1072357) of bug https://bugzilla.redhat.com/show_bug.cgi?id=1262093. Note that I tested with Solaris 10, not openindiana 5.11 On

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

2015-12-14 Thread Dmitry Fleytman
Hello Prasad, Looks good. Reviewed-by: Dmitry Fleytman Regards, Dmitry > On 15 Dec 2015, at 08:57 AM, P J P wrote: > > Hello Dmitry, > > +-- On Mon, 14 Dec 2015, Dmitry Fleytman wrote --+ > | The patch looks basically good. > | The only issue I can think of is that now vmxnet_tx_pkt_unini

Re: [Qemu-devel] [PATCH 11/11] linux-user: convert DEBUG_SIGNAL logging to tracepoints

2015-12-14 Thread Thomas Huth
On 12/12/15 11:39, Paolo Bonzini wrote: > "Unimplemented" messages go to stderr, everything else goes to tracepoints > > Signed-off-by: Paolo Bonzini > --- [...] > diff --git a/linux-user/signal.c b/linux-user/signal.c > index 9d62e02..919aa83 100644 > --- a/linux-user/signal.c > +++ b/linux-user

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

2015-12-14 Thread P J P
Hello Dmitry, +-- On Mon, 14 Dec 2015, Dmitry Fleytman wrote --+ | The patch looks basically good. | The only issue I can think of is that now vmxnet_tx_pkt_uninit and | vmxnet_rx_pkt_uninit may be called a few times in a row. For example guest | may quiesce device and then shutdown. In this

Re: [Qemu-devel] [PATCH RFC 0/8] scsi-disk: Active/passive ALUA support

2015-12-14 Thread Hannes Reinecke
On 12/15/2015 04:02 AM, Stefan Hajnoczi wrote: On Mon, Dec 14, 2015 at 08:35:43AM +0100, Hannes Reinecke wrote: On 12/14/2015 08:24 AM, Stefan Hajnoczi wrote: On Thu, Dec 10, 2015 at 10:13:17AM +0100, Hannes Reinecke wrote: On 12/10/2015 09:26 AM, Stefan Hajnoczi wrote: On Fri, Nov 27, 2015 a

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Thomas Huth
On 14/12/15 23:06, Samuel Thibault wrote: > Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: >>> +default: >>> +/* Do not assert while we don't manage IP6VERSION */ >>> +/* assert(0); */ >> >> Not sure if we ever want to have an assert() here - since I assume this >> could

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-14 Thread Shmulik Ladkani
Hi Jason, On Tue, 15 Dec 2015 10:35:59 +0800 Jason Wang wrote: > > Another attempt I've made is to indroduce a new type vmxnet3e (the > > pcie variant of vmxnet3). > > I dropped this approach since it was way too cumbersome, introducing > > lots of boiler-plate code for the two (otherwise) identi

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Shmulik Ladkani
Hi, On Mon, 14 Dec 2015 23:10:20 +0200 "Michael S. Tsirkin" wrote: > > In order to set QEMU_PCI_CAP_EXPRESS conditionally per instance > > (for example, according to the given x-pcie-disable property), the > > 'parent_dc_realize' trick was suggested. > > > > Reasoning is documented in: > > 056

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-14 Thread Zhu Guihua
and allow individual targets to use its own way to build CPUs? For initial conversion of x86-cpus to device-add we could do pretty much the same like we do now, where cpu devices will appear under: /machine (pc-i440fx-2.5-machine) /unattached (container) /device[x] (qemu64-x86_64-cpu)

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-14 Thread Fam Zheng
On Mon, 12/14 17:26, John Snow wrote: > > If the auto bit is on, it's a must. > > Let's try again: > > "1: auto > This bitmap is of the Dirty Tracking Type and must accurately > reflect all writes to the virtual disk image by any application > that would write to it. This bitmap shou

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-14 Thread Fam Zheng
On Mon, 12/14 21:05, Max Reitz wrote: > On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: > > The new feature for qcow2: storing dirty bitmaps. > > > > Only dirty bitmaps relative to this qcow2 image should be stored in it. > > > > Strings started from +# are RFC-strings, not to be commite

Re: [Qemu-devel] [Qemu-trivial][PATCH] trace: reflect the file name change

2015-12-14 Thread Stefan Hajnoczi
On Fri, Dec 11, 2015 at 03:06:12PM +0800, Qinghua Jin wrote: > Some functions was moved from block.c to block/io.c, so the trace-events file > should reflect that change. > > > Signed-off-by: Qinghua Jin > --- > trace-events | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Please us

Re: [Qemu-devel] [PATCH RFC 0/8] scsi-disk: Active/passive ALUA support

2015-12-14 Thread Stefan Hajnoczi
On Mon, Dec 14, 2015 at 08:35:43AM +0100, Hannes Reinecke wrote: > On 12/14/2015 08:24 AM, Stefan Hajnoczi wrote: > >On Thu, Dec 10, 2015 at 10:13:17AM +0100, Hannes Reinecke wrote: > >>On 12/10/2015 09:26 AM, Stefan Hajnoczi wrote: > >>>On Fri, Nov 27, 2015 at 03:58:58PM +0100, Hannes Reinecke wro

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-14 Thread Jason Wang
On 12/14/2015 03:32 PM, Shmulik Ladkani wrote: > Thanks Jason, > > On Mon, 14 Dec 2015 14:24:36 +0800, jasow...@redhat.com wrote: >>> +static void vmxnet3_realize(DeviceState *qdev, Error **errp) >>> +{ >>> +VMXNET3Class *vc = VMXNET3_DEVICE_GET_CLASS(qdev); >>> +PCIDevice *pci_dev = PCI_

Re: [Qemu-devel] [PATCH v3 06/21] block: Exclude nested options only for children in append_open_options()

2015-12-14 Thread Wen Congyang
On 12/04/2015 09:35 PM, Kevin Wolf wrote: > Some drivers have nested options (e.g. blkdebug rule arrays), which > don't belong to a child node and shouldn't be removed. Don't remove all > options with "." in their name, but check for the complete prefixes of > actually existing child nodes. I thin

Re: [Qemu-devel] [PATCH 3/4] error: Clean up errors with embedded newlines (again), part 2

2015-12-14 Thread Fam Zheng
On Mon, 12/14 10:42, Markus Armbruster wrote: > Laszlo Ersek writes: > > > On 12/10/15 18:23, Markus Armbruster wrote: > >> The arguments of error_setg() & friends should yield a short error > >> string without newlines. > >> > >> A few places try to append additional help to the error message b

Re: [Qemu-devel] [Patch v8 3/3] qmp: add monitor command to add/remove a child

2015-12-14 Thread Li Zhijian
On 11/27/2015 02:06 PM, Wen Congyang wrote: The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed

Re: [Qemu-devel] [Patch v8 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-12-14 Thread Li Zhijian
On 11/27/2015 02:06 PM, Wen Congyang wrote: Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 8 ++-- block/quorum.c| 124 +- include/block/block.h | 4 ++ 3 files chang

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-14 Thread Gonglei (Arei)
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, December 15, 2015 2:17 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; r...@twiddle.net; > ke...@koconnor.net; Huangpeng (Peter) > Subject: Re: [PATCH] rtc: introduce nmi dis

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-14 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, December 14, 2015 9:37 PM > On 14/12/2015 14:27, Gonglei (Arei) wrote: > > > >> > >> On 14/12/2015 13:49, Gonglei (Arei) wrote: > >>> This patch introduce nmi disable bit handler to fix the problem > >>> and make the emulate

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Raj, Ashok
On Mon, Dec 14, 2015 at 11:37:16PM +0100, Borislav Petkov wrote: > On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > > This is mostly harmless.. since the MCG_CAP space is shared and has no > > conflict between vendors. Also just the CAP being set has no effect. > > Of course it does -

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Borislav Petkov
On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > This is mostly harmless.. since the MCG_CAP space is shared and has no > conflict between vendors. Also just the CAP being set has no effect. Of course it does - we check SER_P in machine_check_poll() and when I emulate an AMD guest and

Re: [Qemu-devel] [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

2015-12-14 Thread Alexander Duyck
On Mon, Dec 14, 2015 at 12:52 PM, Michael S. Tsirkin wrote: > On Mon, Dec 14, 2015 at 09:59:13AM -0800, Alexander Duyck wrote: >> On Mon, Dec 14, 2015 at 9:20 AM, Michael S. Tsirkin wrote: >> > On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: >> >> > This way distro can use a gues

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-14 Thread John Snow
On 12/14/2015 04:44 PM, Max Reitz wrote: > On 14.12.2015 21:45, John Snow wrote: >> >> >> On 12/14/2015 03:05 PM, Max Reitz wrote: >>> On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing dirty bitmaps. Only dirty bitmaps relative to this qcow

Re: [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic

2015-12-14 Thread Samuel Thibault
Thomas Huth, on Mon 14 Dec 2015 21:17:19 +0100, wrote: > > + lhost.ss_family = AF_INET; > > + ((struct sockaddr_in *)&lhost)->sin_addr = ti->ti_src; > > + ((struct sockaddr_in *)&lhost)->sin_port = ti->ti_sport; > > + fhost.ss_family = AF_INET; > > + ((struct sockaddr_in *)&fhost)->sin_ad

Re: [Qemu-devel] [RFC v6 00/14] Slow-path for atomic instruction translation

2015-12-14 Thread Andreas Tobler
Alvise, On 14.12.15 09:41, Alvise Rigo wrote: This is the sixth iteration of the patch series which applies to the upstream branch of QEMU (v2.5.0-rc3). Changes versus previous versions are at the bottom of this cover letter. The code is also available at following repository: https://git.virt

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: > > +default: > > +/* Do not assert while we don't manage IP6VERSION */ > > +/* assert(0); */ > > Not sure if we ever want to have an assert() here - since I assume this > could be triggered by the guest? No, this is if_en

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
Samuel Thibault, on Mon 14 Dec 2015 23:06:16 +0100, wrote: > Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: > > > +default: > > > +/* Do not assert while we don't manage IP6VERSION */ > > > +/* assert(0); */ > > > > Not sure if we ever want to have an assert() here - si

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-14 Thread Max Reitz
On 14.12.2015 21:45, John Snow wrote: > > > On 12/14/2015 03:05 PM, Max Reitz wrote: >> On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: >>> The new feature for qcow2: storing dirty bitmaps. >>> >>> Only dirty bitmaps relative to this qcow2 image should be stored in it. >>> >>> Strings st

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 11:01:05PM +0200, Shmulik Ladkani wrote: > Hi Michael, > > On Mon, 14 Dec 2015 19:37:29 +0200 "Michael S. Tsirkin" > wrote: > > On Mon, Dec 14, 2015 at 06:14:37PM +0100, Paolo Bonzini wrote: > > > > > > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > > > +pvs_k->pare

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Shmulik Ladkani
Hi Michael, On Mon, 14 Dec 2015 19:37:29 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 14, 2015 at 06:14:37PM +0100, Paolo Bonzini wrote: > > > > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > > +pvs_k->parent_dc_realize = dc->realize; > > > > Marcel, Michael, > > > > this creates a rea

Re: [Qemu-devel] [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 09:59:13AM -0800, Alexander Duyck wrote: > On Mon, Dec 14, 2015 at 9:20 AM, Michael S. Tsirkin wrote: > > On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: > >> > This way distro can use a guest agent to disable > >> > dirtying until before migration starts.

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-14 Thread John Snow
On 12/14/2015 03:05 PM, Max Reitz wrote: > On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: >> The new feature for qcow2: storing dirty bitmaps. >> >> Only dirty bitmaps relative to this qcow2 image should be stored in it. >> >> Strings started from +# are RFC-strings, not to be commited

Re: [Qemu-devel] [PATCH v3 0/5] block: allow partial info-block query

2015-12-14 Thread Max Reitz
On 14.12.2015 20:55, John Snow wrote: > Allow info-block to succeed even when it cannot reconstruct filenames, > but be explicit about this failure. Utilities that rely on the current > behavior are modified to report this explicit failure to users. > > v3: > - Fix qemu-img output such that "back

Re: [Qemu-devel] [PATCH for-2.5??] configure: Fix shell syntax to placate OpenBSD's pdksh

2015-12-14 Thread Stefan Weil
Am 14.12.2015 um 20:31 schrieb Markus Armbruster: > Peter Maydell writes: > > Mmm, I'm kind of leaning towards "don't put this in 2.5" as well. > Add to http://qemu-project.org/ChangeLog/2.5#Known_issues and call it a > day? Good idea. Done. Regards, Stefan

Re: [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic

2015-12-14 Thread Thomas Huth
On 14/12/15 14:51, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch makes solookup() compatible with varying address > families, by using a new sockaddr_equal() function that compares > two sockaddr_storage. > > This prepares for IPv6 support. > > Signed-off-by: Guillaume Subiron

Re: [Qemu-devel] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

2015-12-14 Thread Max Reitz
On 14.12.2015 20:55, John Snow wrote: > Disambiguate "Backing filename and full backing filename" are equivalent Just noticed: R-b is assuming s/" are equivalent/ are equivalent"/. Max > from "full backing filename could not be determined." > > Signed-off-by: John Snow > --- > block/qapi.c |

Re: [Qemu-devel] [PATCH v3 5/5] block/qapi: allow best-effort query

2015-12-14 Thread Max Reitz
On 14.12.2015 20:55, John Snow wrote: > For more complex BDS trees that can be created under normal circumstances, > we lose the ability to issue query commands because of our inability to > re-construct the absolute filename. > > Instead, omit this field when it is a problem and present as much i

Re: [Qemu-devel] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

2015-12-14 Thread Max Reitz
On 14.12.2015 20:55, John Snow wrote: > Disambiguate "Backing filename and full backing filename" are equivalent > from "full backing filename could not be determined." > > Signed-off-by: John Snow > --- > block/qapi.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-14 Thread Max Reitz
On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing dirty bitmaps. > > Only dirty bitmaps relative to this qcow2 image should be stored in it. > > Strings started from +# are RFC-strings, not to be commited of course. > > > Signed-off-by: Vladimir Semen

Re: [Qemu-devel] [PATCH 6/9] slirp: Factorizing and cleaning solookup()

2015-12-14 Thread Thomas Huth
On 14/12/15 14:51, Samuel Thibault wrote: > From: Guillaume Subiron > > solookup() was only compatible with TCP. Having the socket list in > argument, it is now compatible with UDP too. > > Some optimization code is factorized inside the function (the function > look at the last returned result

Re: [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option

2015-12-14 Thread John Snow
On 12/07/2015 06:56 PM, Eric Blake wrote: > On 12/07/2015 04:34 PM, John Snow wrote: >> This patch adds a new explicit Floppy Drive Type option. The existing >> behavior in QEMU is to automatically guess a drive type based on the >> media inserted, or if a diskette is not present, arbitrarily ass

[Qemu-devel] [PATCH v3 0/5] block: allow partial info-block query

2015-12-14 Thread John Snow
Allow info-block to succeed even when it cannot reconstruct filenames, but be explicit about this failure. Utilities that rely on the current behavior are modified to report this explicit failure to users. v3: - Fix qemu-img output such that "backing file IS the absolute backing path" and "abs

[Qemu-devel] [PATCH v3 2/5] block/qapi: always report full_backing_filename

2015-12-14 Thread John Snow
Always report full_backing_filename, even if it's the same as backing_filename. In the next patch, full_backing_filename may be omitted if it cannot be generated instead of allowing e.g. drive_query to abort if it runs into this scenario. The presence or absence of the "full" field becomes useful

[Qemu-devel] [PATCH v3 1/5] block/qapi: do not redundantly print "actual path"

2015-12-14 Thread John Snow
If it happens to match the backing path, that was the actual path. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block/qapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/qapi.c b/block/qapi.c index 267f147..01569da 100644 --- a/block/qapi.c +++ b/block/qap

[Qemu-devel] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename

2015-12-14 Thread John Snow
Disambiguate "Backing filename and full backing filename" are equivalent from "full backing filename could not be determined." Signed-off-by: John Snow --- block/qapi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index 0e6b333..c61fb30 1

[Qemu-devel] [PATCH v3 4/5] qemu-img: abort when full_backing_filename not present

2015-12-14 Thread John Snow
...But only if we have the backing_filename. It means something Scary happened and we can't really be quite exactly sure if we can trust the backing_filename. Signed-off-by: John Snow Reviewed-by: Max Reitz --- qemu-img.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/q

[Qemu-devel] [PATCH v3 5/5] block/qapi: allow best-effort query

2015-12-14 Thread John Snow
For more complex BDS trees that can be created under normal circumstances, we lose the ability to issue query commands because of our inability to re-construct the absolute filename. Instead, omit this field when it is a problem and present as much information as we can. This will change the expe

Re: [Qemu-devel] [PATCH 4/9] slirp: Make Socket structure IPv6 compatible

2015-12-14 Thread Thomas Huth
On 14/12/15 14:51, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch replaces foreign and local address/port couples in Socket > structure by 2 sockaddr_storage which can be casted in sockaddr_in. > Direct access to address and port is still possible thanks to some > \#define, so re

Re: [Qemu-devel] [PATCH for-2.5??] configure: Fix shell syntax to placate OpenBSD's pdksh

2015-12-14 Thread Markus Armbruster
Peter Maydell writes: > On 14 December 2015 at 15:13, Eric Blake wrote: >> On 12/14/2015 08:02 AM, Peter Maydell wrote: >>> This fixes a problem where configure just falls over on OpenBSD, >>> but on the other hand it is not a regression since 2.4.0... >>> Opinions on whether we should put it in

Re: [Qemu-devel] [PATCH v2 1/2] Use error_fatal to simplify obvious fatal errors

2015-12-14 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Dec 10, 2015 at 05:29:14PM +0100, Markus Armbruster wrote: >> Done with this admittedly crude Coccinelle semantic patch: >> > > Reviewed-by: Eduardo Habkost > > You can rewrite the semantic patch as: > > @@ > type T; > identifier FUN, RET; > exp

Re: [Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Eric Blake
[adding autoconf, which likes to document shell bugs] On 12/14/2015 04:34 AM, Dmitrij D. Czarkoff wrote: > OK, so I misidentified the issue and screwed up my bug report. > > The shell is pdksh on OpenBSD, and the real issue is with parentheses: > > $ a=1 > $ b=2 > $ echo "${a+($b)}" > ks

Re: [Qemu-devel] [vfio-users] [PATCH v2 2/3] input: linux evdev support

2015-12-14 Thread thibaut noah
So basically this remove the need for us to use synergy, how do we apply the patch to an existing config using libvirt? 2015-12-14 15:18 GMT+01:00 Gerd Hoffmann : > This patch adds support for reading input events directly from linux > evdev devices and forward them to the guest. Unlike virtio-i

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Borislav Petkov
On Mon, Dec 14, 2015 at 02:23:56PM -0200, Eduardo Habkost wrote: > > -#define MCE_CAP_DEF (MCG_CTL_P|MCG_SER_P) > > +#define MCE_CAP_DEF (MCG_CTL_P|MCG_SER_P|MCG_LMCE_P) > > This makes mcg_cap change when upgrading QEMU. > > VMs with MCG_LMCE_P enabled shouldn't be migratable to hosts > r

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Peter Maydell
The patch to fix this is at: http://patchwork.ozlabs.org/patch/556537/ Unfortunately it has just missed the cutoff to get into 2.5.0 (since it has been present since 2.4.0 and there is a workaround of running "/path/to/bash configure"). We'll put it into the next 2.5.x stable release, though. --

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Eduardo Habkost
On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > On Mon, Dec 14, 2015 at 05:37:38PM +0100, Borislav Petkov wrote: > > > > ... and obviously LMCE is vendor-specific so it cannot be enabled on > > !Intel guests with a define like that. mce_init() in qemu should check > > vendor too. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-12-14 Thread Laurent Vivier
On 13/11/2015 12:23, Mark Cave-Ayland wrote: > On 13/11/15 09:45, Hervé Poussineau wrote: > >> Le 13/11/2015 05:09, Programmingkid a écrit : >>> >>> On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: >>> Message: 3 Date: Thu, 12 Nov 2015 22:24:08 +0100 From: Herv? Po

Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 07:04:33PM +0100, Paolo Bonzini wrote: > > > On 14/12/2015 18:35, Michael S. Tsirkin wrote: > > > What distinguishes an internal from an external property? Everything > > > except links to backends would be "internal". > > > > How do you mean? We have a ton of properties

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Marcel Apfelbaum
On 12/14/2015 07:14 PM, Paolo Bonzini wrote: On 13/12/2015 09:08, Shmulik Ladkani wrote: +pvs_k->parent_dc_realize = dc->realize; Marcel, Michael, this creates a really nasty dependency on the contents of pci_qdev_realize. Hi Paolo, In this case is exactly want we want to do. We don'

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-14 Thread Eduardo Habkost
On Sat, Dec 12, 2015 at 09:15:46PM +0800, Gonglei wrote: > The Non-Maskable Interrupt (NMI) Enable bit is 0x80 bit of > Port 0x70 (and its aliases). This bit must be 0b to enable > the hardware chipset to send a Non-Maskable Interrupt. When > set to a 1b, NMI's are disabled. This bit is commonly ac

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Raj, Ashok
On Mon, Dec 14, 2015 at 05:37:38PM +0100, Borislav Petkov wrote: > > ... and obviously LMCE is vendor-specific so it cannot be enabled on > !Intel guests with a define like that. mce_init() in qemu should check > vendor too. > > The same mistake was done with SER_P but that's much harder to chang

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Raj, Ashok
Hi Eduardo, Thanks for the feedback. All the suggestions make sense.. On Mon, Dec 14, 2015 at 02:23:56PM -0200, Eduardo Habkost wrote: > > +static void feature_control_init(X86CPU *cpu) > > +{ > > + CPUX86State *cenv = &cpu->env; > > + > > + cenv->msr_ia32_feature_control = ((1<<20) | (1<<0))

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Paolo Bonzini
On 14/12/2015 18:37, Michael S. Tsirkin wrote: > > Can you instead change PCIDeviceClass's pc->is_express to a function > > pointer, and provide a sample implementation pci_is_express_true for the > > devices that set is_express to true? > > I'm not very familiar with vmw code, and I dislike ove

Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

2015-12-14 Thread Paolo Bonzini
On 14/12/2015 18:35, Michael S. Tsirkin wrote: > > What distinguishes an internal from an external property? Everything > > except links to backends would be "internal". > > How do you mean? We have a ton of properties e.g. > to control which offloads are allowed for virtio net. Why would user

Re: [Qemu-devel] [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

2015-12-14 Thread Alexander Duyck
On Mon, Dec 14, 2015 at 9:20 AM, Michael S. Tsirkin wrote: > On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: >> > This way distro can use a guest agent to disable >> > dirtying until before migration starts. >> >> Right. For a v2 version I would definitely want to have some way t

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Thomas Huth
On 14/12/15 14:51, Samuel Thibault wrote: > From: Guillaume Subiron > > In if_encap, a switch is added to prepare for the IPv6 case. Some code > is factorized. > > This prepares for IPv6 support. > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel Thibault > --- > slirp/slirp.c | 61

Re: [Qemu-devel] [PATCH 1/1] block/raw-posix: avoid bogus fixup for cylinders on DASD disks

2015-12-14 Thread Cornelia Huck
On Mon, 14 Dec 2015 16:41:19 +0100 Christian Borntraeger wrote: > large volume DASD that have > 64k cylinders do claim to have > 0xFFFE cylinders as special value in the old 16 bit field. We > want to pass this "token" along to the guest, instead of > calculating the real number. Otherwise qemu m

Re: [Qemu-devel] [PATCH 1/1] block/raw-posix: avoid bogus fixup for cylinders on DASD disks

2015-12-14 Thread Markus Armbruster
Christian Borntraeger writes: > large volume DASD that have > 64k cylinders do claim to have > 0xFFFE cylinders as special value in the old 16 bit field. We > want to pass this "token" along to the guest, instead of > calculating the real number. Otherwise qemu might fail with > "cyls must be bet

[Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-14 Thread Vladimir Sementsov-Ogievskiy
The new feature for qcow2: storing dirty bitmaps. Only dirty bitmaps relative to this qcow2 image should be stored in it. Strings started from +# are RFC-strings, not to be commited of course. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/specs/qcow2.txt | 151

Re: [Qemu-devel] [RFC PATCH v0 8/9] target-i386: Set apic_id during CPU initfn

2015-12-14 Thread Eduardo Habkost
On Thu, Dec 10, 2015 at 11:45:43AM +0530, Bharata B Rao wrote: > Move back the setting of apic_id to instance_init routine (x86_cpu_initfn) > This is needed to initialize X86 CPUs using generic cpu-package device. Could you explain where exactly apic_id will be used, to make it necessary to initia

Re: [Qemu-devel] [RFC PATCH v0 1/9] vl: Don't allow CPU toplogies with partially filled cores

2015-12-14 Thread Eduardo Habkost
On Fri, Dec 11, 2015 at 08:54:31AM +0530, Bharata B Rao wrote: > On Thu, Dec 10, 2015 at 10:25:28AM +, Daniel P. Berrange wrote: > > On Thu, Dec 10, 2015 at 11:45:36AM +0530, Bharata B Rao wrote: > > > Prevent guests from booting with CPU topologies that have partially > > > filled CPU cores or

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 06:14:37PM +0100, Paolo Bonzini wrote: > > > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > +pvs_k->parent_dc_realize = dc->realize; > > Marcel, Michael, > > this creates a really nasty dependency on the contents of pci_qdev_realize. > > Can you instead change PCID

Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 12:28:50PM -0500, Paolo Bonzini wrote: > > Well qapi/qmp docs say things like: > > > > Any name (command, event, type, field, or enum value) beginning with > > "x-" is marked experimental, and may be withdrawn or changed > > incompatibly in a future release. > >

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Shmulik Ladkani
Hi, On Mon, 14 Dec 2015 18:14:37 +0100 Paolo Bonzini wrote: > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > +pvs_k->parent_dc_realize = dc->realize; > > Marcel, Michael, > > this creates a really nasty dependency on the contents of pci_qdev_realize. > > Can you instead change PCIDeviceCl

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

2015-12-14 Thread Dmitry Fleytman
Hello Prasad, > On 14 Dec 2015, at 13:58 PM, P J P wrote: > > Hello Dmitry, Jason > > +-- On Sun, 13 Dec 2015, Dmitry Fleytman wrote --+ > | According to Linux driver code VMXNET3_CMD_QUIESCE_DEV does not flip > | paused/active states. It always disables device, see vmxnet3_resume() for > |

Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState

2015-12-14 Thread Eduardo Habkost
On Thu, Dec 10, 2015 at 11:45:37AM +0530, Bharata B Rao wrote: > Storing CPU typename in MachineState lets us to create CPU threads > for all architectures in uniform manner from arch-neutral code. > > TODO: Touching only i386 and spapr targets for now > > Signed-off-by: Bharata B Rao Suggestio

Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

2015-12-14 Thread Paolo Bonzini
> Well qapi/qmp docs say things like: > > Any name (command, event, type, field, or enum value) beginning with > "x-" is marked experimental, and may be withdrawn or changed > incompatibly in a future release. > > It's thus reasonable to use this for internal properties, > that

Re: [Qemu-devel] [PATCH for-2.5??] configure: Fix shell syntax to placate OpenBSD's pdksh

2015-12-14 Thread Peter Maydell
On 14 December 2015 at 15:13, Eric Blake wrote: > On 12/14/2015 08:02 AM, Peter Maydell wrote: >> This fixes a problem where configure just falls over on OpenBSD, >> but on the other hand it is not a regression since 2.4.0... >> Opinions on whether we should put it in 2.5 as a last minute >> thing

Re: [Qemu-devel] [PATCH v2 0/4] block: allow partial info-block query

2015-12-14 Thread John Snow
On 12/14/2015 12:13 PM, Max Reitz wrote: > On 12.12.2015 02:25, John Snow wrote: >> Max: Did you have in mind something like this? > > What I had in mind was fixing the whole thing (the test case in 110 > should actually work just fine, because you can easily determine the > base directory to be

Re: [Qemu-devel] [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 08:34:00AM -0800, Alexander Duyck wrote: > > This way distro can use a guest agent to disable > > dirtying until before migration starts. > > Right. For a v2 version I would definitely want to have some way to > limit the scope of this. My main reason for putting this out

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

2015-12-14 Thread Paolo Bonzini
On 13/12/2015 09:08, Shmulik Ladkani wrote: > +pvs_k->parent_dc_realize = dc->realize; Marcel, Michael, this creates a really nasty dependency on the contents of pci_qdev_realize. Can you instead change PCIDeviceClass's pc->is_express to a function pointer, and provide a sample implementat

Re: [Qemu-devel] [PATCH RFC] virtio: proposal to optimize accesses to VQs

2015-12-14 Thread Vincenzo Maffione
2015-12-14 17:06 GMT+01:00 Paolo Bonzini : > > > On 14/12/2015 15:51, Vincenzo Maffione wrote: >> >> This patch slightly rewrites the code to reduce the number of accesses, since >> many of them seems unnecessary to me. After this reduction, the bottleneck >> jumps from 1 Mpps to 2 Mpps. >> >> Patc

Re: [Qemu-devel] [PATCH v2 0/4] block: allow partial info-block query

2015-12-14 Thread Max Reitz
On 12.12.2015 02:25, John Snow wrote: > Max: Did you have in mind something like this? What I had in mind was fixing the whole thing (the test case in 110 should actually work just fine, because you can easily determine the base directory to be used). ;-) I've been working on that myself anyway,

Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 06:07:31PM +0100, Paolo Bonzini wrote: > > > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > Following the previous patch which changed pvscsi to be a pci express > > device, this patch introduces a boolean property 'x-disable-pcie'. > > > > Its default value is false, ex

Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

2015-12-14 Thread Paolo Bonzini
On 13/12/2015 09:08, Shmulik Ladkani wrote: > Following the previous patch which changed pvscsi to be a pci express > device, this patch introduces a boolean property 'x-disable-pcie'. > > Its default value is false, exposing pvscsi as a pcie device. > > Setting 'x-disable-pcie' to 'on' preserv

Re: [Qemu-devel] [PATCH v1] kvm/x86: Remove Hyper-V SynIC timer stopping

2015-12-14 Thread Andrey Smetanin
On 12/14/2015 07:09 PM, Paolo Bonzini wrote: On 14/12/2015 16:33, Andrey Smetanin wrote: It's possible that guest send us Hyper-V EOM at the middle of Hyper-V SynIC timer running, so we start processing of Hyper-V SynIC timers in vcpu context and stop the Hyper-V SynIC timer uncoditionally a

Re: [Qemu-devel] [PATCH v2 1/2] Use error_fatal to simplify obvious fatal errors

2015-12-14 Thread Eduardo Habkost
On Thu, Dec 10, 2015 at 05:29:14PM +0100, Markus Armbruster wrote: > Done with this admittedly crude Coccinelle semantic patch: > Reviewed-by: Eduardo Habkost You can rewrite the semantic patch as: @@ type T; identifier FUN, RET; expression list ARGS; expression ERR, EC;

Re: [Qemu-devel] [PATCH v2 4/4] block/qapi: allow best-effort query

2015-12-14 Thread Max Reitz
On 12.12.2015 02:25, John Snow wrote: > For more complex BDS trees that can be created under normal circumstances, > we lose the ability to issue query commands because of our inability to > re-construct the absolute filename. > > Instead, omit this field when it is a problem and present as much i

Re: [Qemu-devel] [PATCH v1] kvm/x86: Remove Hyper-V SynIC timer stopping

2015-12-14 Thread Andrey Smetanin
On 12/14/2015 07:09 PM, Paolo Bonzini wrote: On 14/12/2015 16:33, Andrey Smetanin wrote: It's possible that guest send us Hyper-V EOM at the middle of Hyper-V SynIC timer running, so we start processing of Hyper-V SynIC timers in vcpu context and stop the Hyper-V SynIC timer uncoditionally a

Re: [Qemu-devel] [PATCH v2 3/4] qemu-img: abort when full_backing_filename not present

2015-12-14 Thread Max Reitz
On 12.12.2015 02:25, John Snow wrote: > ...But only if we have the backing_filename. It means something Scary > happened and we can't really be quite exactly sure if we can trust the > backing_filename. > > Signed-off-by: John Snow > --- > qemu-img.c | 5 - > 1 file changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH v2 2/4] block/qapi: always report full_backing_filename

2015-12-14 Thread Max Reitz
On 14.12.2015 17:38, John Snow wrote: > > > On 12/14/2015 11:36 AM, Max Reitz wrote: >> On 12.12.2015 02:25, John Snow wrote: >>> Always report full_backing_filename, even if it's the same as >>> backing_filename. In the next patch, full_backing_filename may be >>> omitted if it cannot be generat

Re: [Qemu-devel] [PATCH v2 2/4] block/qapi: always report full_backing_filename

2015-12-14 Thread Max Reitz
On 12.12.2015 02:25, John Snow wrote: > Always report full_backing_filename, even if it's the same as > backing_filename. In the next patch, full_backing_filename may be > omitted if it cannot be generated instead of allowing e.g. drive_query > to abort if it runs into this scenario. > > The prese

Re: [Qemu-devel] [PATCH v2 2/4] block/qapi: always report full_backing_filename

2015-12-14 Thread John Snow
On 12/14/2015 11:36 AM, Max Reitz wrote: > On 12.12.2015 02:25, John Snow wrote: >> Always report full_backing_filename, even if it's the same as >> backing_filename. In the next patch, full_backing_filename may be >> omitted if it cannot be generated instead of allowing e.g. drive_query >> to ab

Re: [Qemu-devel] [RFC PATCH 3/3] x86: Create dma_mark_dirty to dirty pages used for DMA by VM guest

2015-12-14 Thread Alexander Duyck
On Mon, Dec 14, 2015 at 6:00 AM, Michael S. Tsirkin wrote: > On Sun, Dec 13, 2015 at 01:28:31PM -0800, Alexander Duyck wrote: >> This patch is meant to provide the guest with a way of flagging DMA pages >> as being dirty to the host when using a direct-assign device within a >> guest. The advanta

Re: [Qemu-devel] [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-14 Thread Stefano Stabellini
On Mon, 14 Dec 2015, Jan Beulich wrote: > >>> On 11.12.15 at 17:56, wrote: > > For the original issue here, could the flag be exposed as a > > XEN_SYSCTL_PHYSCAP_ > > Yes, I think it could, albeit calling this a "capability" or "feature" > seems odd (since really the original behavior was bog

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-14 Thread Eduardo Habkost
Hi, Comments below: On Thu, Dec 10, 2015 at 02:41:21PM -0500, Ashok Raj wrote: > This patch adds basic enumeration, control msr's required to support > Local Machine Check Exception Support (LMCE). > > - Added Local Machine Check definitions, changed MCG_CAP > - Added support for IA32_FEATURE_CO

Re: [Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-14 Thread Christopher Friedt
On Mon, Dec 14, 2015 at 10:56 AM, Alex Bennée wrote: > IIRC last time I played with this when adding aarch64 system registers > for debugging is the number is irrelevant to gdb, its all dependant on > what the stub sends. As long as the coprocessor get/set functions agree > on the order with the x

Re: [Qemu-devel] [PATCH] target-*: Get rid of "PC advancement" trick

2015-12-14 Thread Richard Henderson
On 12/12/2015 12:02 PM, Sergey Fedorov wrote: On 12/12/15 02:39, Richard Henderson wrote: On 12/10/2015 10:47 AM, Sergey Fedorov wrote: The "PC advancement" trick was used just after recognizing that a breakpoint exception was going to be generated. This trick has had two points: 1. Guarantee

Re: [Qemu-devel] [PATCH v1] kvm/x86: Remove Hyper-V SynIC timer stopping

2015-12-14 Thread Paolo Bonzini
On 14/12/2015 16:33, Andrey Smetanin wrote: > It's possible that guest send us Hyper-V EOM at the middle > of Hyper-V SynIC timer running, so we start processing of Hyper-V > SynIC timers in vcpu context and stop the Hyper-V SynIC timer > uncoditionally and lose time expiration which Windows 2012

Re: [Qemu-devel] [PATCH RFC] virtio: proposal to optimize accesses to VQs

2015-12-14 Thread Paolo Bonzini
On 14/12/2015 15:51, Vincenzo Maffione wrote: > > This patch slightly rewrites the code to reduce the number of accesses, since > many of them seems unnecessary to me. After this reduction, the bottleneck > jumps from 1 Mpps to 2 Mpps. > > Patch is not complete (e.g. it still does not properly

  1   2   3   >