Hi, On Mon, 14 Dec 2015 18:14:37 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote: > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > + pvs_k->parent_dc_realize = dc->realize; > > Marcel, Michael, > > this creates a really nasty dependency on the contents of pci_qdev_realize. > > Can you instead change PCIDeviceClass's pc->is_express to a function > pointer, and provide a sample implementation pci_is_express_true for the > devices that set is_express to true?
Thanks Paolo, I like the idea. Indeed repeating the parent_dc_realize hack for various devices seems awkward. If this approach is accepted, I'm okay doing the suggested refactor. Regards, Shmulik
