Re: [Qemu-devel] [Patch V2 2/2] x86, mce: Need to translate GPA to HPA to inject error in guest.

2015-12-11 Thread Chen, Gong
Hi, Ashok Please add " original author by Huang Ying " at some place. Thanks. > -Original Message- > From: Raj, Ashok > Sent: Friday, December 11, 2015 3:41 AM > To: k...@vger.kernel.org > Cc: Chen, Gong; Gleb Natapov; Paolo Bonzini; qemu-devel@nongnu.org; > linux-ker...@vger.kernel.org;

Re: [Qemu-devel] An RDMA race?

2015-12-11 Thread Michael R. Hines
David, Thanks for including my email directly. It helps a lot. Below, I'm going to assume that only "dest" is calling qemu_rdma_exchange_recv() and only src is calling qemu_rdma_exchange_send(), since you didn't specify who is sending and who is receiving. If that assumption is wrong, please res

[Qemu-devel] [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-11 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD and DVD media. Signed-off-by: John Arbuckl

Re: [Qemu-devel] [PATCH v3 3/4] target-tilegx: Add double floating point implementation

2015-12-11 Thread Chen Gang
On 12/12/15 08:41, Richard Henderson wrote: > On 12/11/2015 03:38 PM, Chen Gang wrote: >> >> On 12/11/15 05:17, Richard Henderson wrote: >>> On 12/10/2015 06:15 AM, Chen Gang wrote: +#define TILEGX_F_MAN_HBIT (1ULL << 59) >>> ... +static uint64_t fr_to_man(float64 d) +{ +

[Qemu-devel] [PATCH v2 4/4] block/qapi: allow best-effort query

2015-12-11 Thread John Snow
For more complex BDS trees that can be created under normal circumstances, we lose the ability to issue query commands because of our inability to re-construct the absolute filename. Instead, omit this field when it is a problem and present as much information as we can. This will change the expe

[Qemu-devel] [PATCH v2 0/4] block: allow partial info-block query

2015-12-11 Thread John Snow
Max: Did you have in mind something like this? v2: - Fix qemu-img from now choking when it gets a partial response. For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch block-allo

[Qemu-devel] [PATCH v2 3/4] qemu-img: abort when full_backing_filename not present

2015-12-11 Thread John Snow
...But only if we have the backing_filename. It means something Scary happened and we can't really be quite exactly sure if we can trust the backing_filename. Signed-off-by: John Snow --- qemu-img.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c i

[Qemu-devel] [PATCH v2 1/4] block/qapi: do not redundantly print "actual path"

2015-12-11 Thread John Snow
If it happens to match the backing path, that was the actual path. Signed-off-by: John Snow --- block/qapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/qapi.c b/block/qapi.c index 267f147..01569da 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -676,7 +676,9 @@

[Qemu-devel] [PATCH v2 2/4] block/qapi: always report full_backing_filename

2015-12-11 Thread John Snow
Always report full_backing_filename, even if it's the same as backing_filename. In the next patch, full_backing_filename may be omitted if it cannot be generated instead of allowing e.g. drive_query to abort if it runs into this scenario. The presence or absence of the "full" field becomes useful

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.5?] qemu-iotests: Reduce racy output in 028

2015-12-11 Thread John Snow
On 12/10/2015 10:27 PM, Eric Blake wrote: > On my machine, './check -qcow2 028' was failing about 80% of the > time, due to a race in how many times the repeated attempts > to run 'info block-jobs' could occur before the job was done, > showing up as a failure of fewer '(qemu) ' prompts than in t

Re: [Qemu-devel] [PATCH v3 3/4] target-tilegx: Add double floating point implementation

2015-12-11 Thread Richard Henderson
On 12/11/2015 03:38 PM, Chen Gang wrote: On 12/11/15 05:17, Richard Henderson wrote: On 12/10/2015 06:15 AM, Chen Gang wrote: +#define TILEGX_F_MAN_HBIT (1ULL << 59) ... +static uint64_t fr_to_man(float64 d) +{ +uint64_t val = get_f64_man(d) << 7; + +if (get_f64_exp(d)) { +

Re: [Qemu-devel] [Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-11 Thread Eric Blake
On 12/11/2015 04:40 PM, Programmingkid wrote: > I guess the commit message is a little out of date. How about this: > > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a

[Qemu-devel] [ANNOUNCE] QEMU 2.5.0-rc4 is now available

2015-12-11 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.5 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.5.0-rc4.tar.bz2 You can help i

Re: [Qemu-devel] [Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-11 Thread Programmingkid
On Dec 11, 2015, at 5:00 PM, Jeff Cody wrote: > On Thu, Dec 10, 2015 at 09:39:51AM -0500, Programmingkid wrote: >> https://patchwork.ozlabs.org/patch/550295/ >> >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be of

Re: [Qemu-devel] [PATCH] target-*: Get rid of "PC advancement" trick

2015-12-11 Thread Richard Henderson
On 12/10/2015 10:47 AM, Sergey Fedorov wrote: The "PC advancement" trick was used just after recognizing that a breakpoint exception was going to be generated. This trick has had two points: 1. Guarantee that tb->size isn't zero: there are many places where it's expected to be non-zero. In

Re: [Qemu-devel] [PATCH v3 3/4] target-tilegx: Add double floating point implementation

2015-12-11 Thread Chen Gang
On 12/11/15 05:17, Richard Henderson wrote: > On 12/10/2015 06:15 AM, Chen Gang wrote: >> +#define TILEGX_F_MAN_HBIT (1ULL << 59) > ... >> +static uint64_t fr_to_man(float64 d) >> +{ >> +uint64_t val = get_f64_man(d) << 7; >> + >> +if (get_f64_exp(d)) { >> +val |= TILEGX_F_MAN_HB

Re: [Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation

2015-12-11 Thread Samuel Thibault
Hello, Thomas, this is the last refactoring patch which doesn't have a review yet, right? Samuel Samuel Thibault, on Fri 11 Dec 2015 01:15:17 +0100, wrote: > From: Guillaume Subiron > > This patch factorizes some duplicate code into a new function, > sotranslate_out(). This function perform th

Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 19:01, Kevin O'Connor wrote: > On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: >> Update the SDHCI code to use the new SDBus APIs. >> >> This commit introduces the new command line options required >> to connect a disk to sdhci-pci: >> >> -device sdhci-pci -d

Re: [Qemu-devel] [Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-11 Thread Jeff Cody
On Thu, Dec 10, 2015 at 09:39:51AM -0500, Programmingkid wrote: > https://patchwork.ozlabs.org/patch/550295/ > > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote: > Also, I'd prefer if you could split this patch into two: One for > renaming the "arp_requested" field, and one for adding the additional > logic with the switch statement (since there are two different kind of > changes). Ok, at least it's e

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:51:02 +0100, wrote: > Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > > I'll however have a look at introducing the optimizations etc. first, so > > that both making solookup use sockaddr and introducing sockaddr_equal > > looks natural. > > Yes,

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > I'll however have a look at introducing the optimizations etc. first, so > that both making solookup use sockaddr and introducing sockaddr_equal > looks natural. Yes, it seems to be working very nicely. Samuel

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:29:44 +0100, wrote: > Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > > On 11/12/15 01:15, Samuel Thibault wrote: > > > From: Guillaume Subiron > > > > > > This patch makes solookup() compatible with varying address families. > > > Also, > > > this

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > On 11/12/15 01:15, Samuel Thibault wrote: > > From: Guillaume Subiron > > > > This patch makes solookup() compatible with varying address families. Also, > > this function was only compatible with TCP. Having the socket list in > > argument

[Qemu-devel] [PATCH v2 00/14] pc: Eliminate struct PcGuestInfo

2015-12-11 Thread Eduardo Habkost
This moves all data from PcGuestInfo to either PCMachineState or PCMachineClass. This series depends on other two series: * [PATCH v3 0/6] pc: Initialization and compat function cleanup * [PATCH V3 0/3] hw/pcie: Multi-root support for Q35 For reference, there's a git tree containing this series p

Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-11 Thread Kevin O'Connor
On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: > Update the SDHCI code to use the new SDBus APIs. > > This commit introduces the new command line options required > to connect a disk to sdhci-pci: > > -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive I can't rev

[Qemu-devel] [PATCH v2 12/14] pc: Move PcGuestInfo.fw_cfg to PCMachineState

2015-12-11 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 7 +++ hw/i386/pc.c | 10 -- include/hw/i386/pc.h | 2 +- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 9598eac..43d8166 100644 --- a/hw/i386/acpi-bu

[Qemu-devel] [PATCH v2 11/14] pc: Remove PcGuestInfo.isapc_ram_fw field

2015-12-11 Thread Eduardo Habkost
The code can use the PCMachineClass.pci_enabled field directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 2 +- hw/i386/pc_piix.c| 5 + hw/i386/pc_q35.c | 4 +--- include/hw/i386/pc.h | 1 - 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc.c b

[Qemu-devel] [PATCH v2 08/14] acpi: Don't save PcGuestInfo on AcpiBuildState

2015-12-11 Thread Eduardo Habkost
We don't need to save the pointer on AcpiBuildState, as it is not used anymore. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 92d25c9..82d55bb 100644 --- a/hw/i386/acpi-build.c +++ b

[Qemu-devel] [PATCH v2 09/14] pc: Remove compat fields from PcGuestInfo

2015-12-11 Thread Eduardo Habkost
Remove the fields: legacy_acpi_table_size, has_acpi_build, has_reserved_memory, and rsdp_in_ram from PcGuestInfo, and let the existing code use the PCMachineClass fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 10 ++ hw/i386/pc.c | 6 +++--- hw/i386/p

[Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions

2015-12-11 Thread Eduardo Habkost
We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get guest_info. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 35 +-- hw/i386/acpi-build.h | 2 +- hw/i386/pc.c | 2 +- 3 files changed, 23 insertions(+), 16 deletions(-) diff --g

[Qemu-devel] [PATCH v2 14/14] pc: Eliminate PcGuestInfo struct

2015-12-11 Thread Eduardo Habkost
The struct is not used for anything, now. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 4 +--- include/hw/i386/pc.h | 7 +-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 43a25a0..f78b877 100644 --- a/hw/i386/pc.c +++ b/hw/i386/

[Qemu-devel] [PATCH v2 10/14] pc: Remove RAM size fields from PcGuestInfo

2015-12-11 Thread Eduardo Habkost
The ACPI code can use the PCMachineState fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 10 +- hw/i386/pc.c | 2 -- include/hw/i386/pc.h | 1 - 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c

[Qemu-devel] [PATCH v2 06/14] pc: Simplify xen_load_linux() signature

2015-12-11 Thread Eduardo Habkost
We can get the PcGuestInfo struct directly from PCMachineState, and the return value is not needed at all. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 5 ++--- hw/i386/pc_piix.c| 2 +- include/hw/i386/pc.h | 3 +-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/

[Qemu-devel] [PATCH v2 05/14] pc: Simplify pc_memory_init() signature

2015-12-11 Thread Eduardo Habkost
We can get the PcGuestInfo struct directly from PCMachineState, and the return value is not needed at all. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 11 +-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 9 - 4 files changed, 1

[Qemu-devel] [PATCH v2 13/14] pc: Move APIC and NUMA data from PcGuestInfo to PCMachineState

2015-12-11 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 22 +- hw/i386/pc.c | 20 ++-- include/hw/i386/pc.h | 14 +- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 43d8166

[Qemu-devel] [PATCH v2 02/14] pc: Group and document related PCMachineState/PCMachineclass fields

2015-12-11 Thread Eduardo Habkost
Group related PCMachineState and PCMachineClass fields into sections, and move existing field descriptions to doc comments. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 48 1 file changed, 36 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH v2 04/14] pc: Eliminate struct PcGuestInfoState

2015-12-11 Thread Eduardo Habkost
Instead of allocating a new struct just for PcGuestInfo and the mchine_done Notifier, place them inside PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 27 ++- include/hw/i386/pc.h | 2 ++ 2 files changed, 12 insertions(+), 17 deletions(-) diff

[Qemu-devel] [PATCH v2 03/14] pc: Move PcGuestInfo declaration to top of file

2015-12-11 Thread Eduardo Habkost
The struct will be used inside PCMachineState. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 9503dbb..84bc88f 100644 --- a/include/hw/

[Qemu-devel] [PATCH v2 01/14] q35: Remove MCHPCIState.guest_info field

2015-12-11 Thread Eduardo Habkost
The field is not used for anything. Signed-off-by: Eduardo Habkost --- hw/i386/pc_q35.c | 1 - include/hw/pci-host/q35.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 9da751b..43ee8bb 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @

[Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions

2015-12-11 Thread Jason J. Herne
We don't want newlines embedded in error messages. This seems to be a common problem with new code so let's try to catch it with checkpatch. This will not catch cases where newlines are inserted into the middle of an existing multi-line statement. But those cases should be rare. Signed-off-by: Ja

Re: [Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions

2015-12-11 Thread Jason J. Herne
On 12/11/2015 09:52 AM, Jason J. Herne wrote: We don't want newlines embedded in error messages. This seems to be a common problem with new code so let's try to catch it with checkpatch. This does not catch the newline when it is in a multiline statement. This is quite a bit more difficult and c

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Laszlo Ersek
On 12/11/15 17:17, Eric Blake wrote: > On 12/11/2015 08:40 AM, Laszlo Ersek wrote: >> meta >> >> On 12/11/15 16:09, Thomas Huth wrote: >>> On 11/12/15 15:55, Samuel Thibault wrote: Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: > So maybe it's better to do smaller steps instead: Wo

[Qemu-devel] An RDMA race?

2015-12-11 Thread Dr. David Alan Gilbert
Hi Michael, I think I've got an RDMA race condition, but I'm being a little cautious at the moment and wondered if you agree with the following diagnosis. It's showing up in a world of mine that's sending more control messages from the destination->source and I'm seeing the following. We norma

[Qemu-devel] [PATCH] tcg: Remove lingering references to gen_opc_buf

2015-12-11 Thread Richard Henderson
Three in comments and one in code in the stub tcg_liveness_analysis. Signed-off-by: Richard Henderson --- target-arm/translate.c | 3 +-- target-i386/translate.c | 3 +-- target-unicore32/translate.c | 3 +-- tcg/tcg.c| 3 +-- 4 files changed, 4 insertions(+), 8 de

Re: [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile

2015-12-11 Thread Richard Henderson
On 12/11/2015 05:41 AM, Peter Maydell wrote: Hi; I noticed while grepping through code that the version of tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS won't compile because it's still referring to the no-longer-existent TCGContext::gen_opc_buf. Oops. Richard, I thin

Re: [Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 17:01, Stefano Stabellini wrote: > On Fri, 11 Dec 2015, Peter Maydell wrote: >> On 11 December 2015 at 16:52, Stefano Stabellini >> wrote: >> If this was intended for 2.5 you have missed the boat. > > I sent it because it is a bug fix, but waiting for 2.6 also makes > sense

Re: [Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

2015-12-11 Thread Stefano Stabellini
On Fri, 11 Dec 2015, Peter Maydell wrote: > On 11 December 2015 at 16:52, Stefano Stabellini > wrote: > > The following changes since commit 6e0abc251dd4f8eba1f53656dfede12e5840e83b: > > > > blockdev: Mark {insert, remove}-medium experimental (2015-12-11 15:39:29 > > +) > > > > are availabl

Re: [Qemu-devel] [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-11 Thread Ian Campbell
On Fri, 2015-12-11 at 16:44 +, Stefano Stabellini wrote: >   > It is not possible to do this at runtime. I think we should do this at > compile time because in any case it is not supported to run a QEMU built > for a given Xen version on a different Xen version. I am currently working pretty h

Re: [Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 16:52, Stefano Stabellini wrote: > The following changes since commit 6e0abc251dd4f8eba1f53656dfede12e5840e83b: > > blockdev: Mark {insert, remove}-medium experimental (2015-12-11 15:39:29 > +) > > are available in the git repository at: > > git://xenbits.xen.org/pe

[Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

2015-12-11 Thread Stefano Stabellini
The following changes since commit 6e0abc251dd4f8eba1f53656dfede12e5840e83b: blockdev: Mark {insert, remove}-medium experimental (2015-12-11 15:39:29 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-12-11 for you to fetch cha

[Qemu-devel] [PULL 1/1] xen_disk: treat "vhd" as "vpc"

2015-12-11 Thread Stefano Stabellini
The Xen toolstack uses "vhd" to specify a disk in VHD format, however the name of the driver in QEMU is "vpc". Replace "vhd" with "vpc", so that QEMU can find the right driver to use for it. Signed-off-by: Stefano Stabellini --- hw/block/xen_disk.c |3 +++ 1 file changed, 3 insertions(+) di

[Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-11 Thread Peter Maydell
Update the SDHCI code to use the new SDBus APIs. This commit introduces the new command line options required to connect a disk to sdhci-pci: -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive Signed-off-by: Peter Maydell --- hw/sd/sdhci.c | 95

[Qemu-devel] [PATCH 09/10] hw/sd/pxa2xx_mmci: Convert to VMStateDescription

2015-12-11 Thread Peter Maydell
Convert the pxa2xx_mmci device from manual save/load functions to a VMStateDescription structure. This is a migration compatibility break. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 148 1 file changed, 56 insertions(+), 92 deleti

[Qemu-devel] [PATCH 07/10] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-11 Thread Peter Maydell
Convert the pxa2xx_mmci device to be a sysbus device. In this commit we only change the device itself, and leave the interface to the SD card using the old non-SDBus APIs. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 73 - 1 file cha

[Qemu-devel] [PATCH 03/10] hw/sd/sd.c: Convert sd_reset() function into Device reset method

2015-12-11 Thread Peter Maydell
Convert the sd_reset() function into a proper Device reset method. Signed-off-by: Peter Maydell --- hw/sd/sd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 7c79217..b4a5a62 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -393,8 +393,9 @

[Qemu-devel] [PATCH 08/10] hw/sd/pxa2xx_mmci: Update to use new SDBus APIs

2015-12-11 Thread Peter Maydell
Now the PXA2xx MMCI device is QOMified itself, we can update it to use the SDBus APIs to talk to the SD card. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 80 +++-- 1 file changed, 66 insertions(+), 14 deletions(-) diff --git a/hw/sd/pxa

[Qemu-devel] [PATCH 10/10] hw/sd/pxa2xx_mmci: Add reset function

2015-12-11 Thread Peter Maydell
Add a reset function to the pxa2xx_mmci device; previously it had no handling for system reset at all. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/sd/pxa2xx_mmci.c b/hw/sd/pxa2xx_mmci.c index 8

[Qemu-devel] [PATCH 06/10] sdhci_sysbus: Create SD card device in users, not the device itself

2015-12-11 Thread Peter Maydell
Move the creation of the SD card device from the sdhci_sysbus device itself into the boards that create these devices. This allows us to remove the cannot_instantiate_with_device_add notation because we no longer call drive_get_next in the device model. Signed-off-by: Peter Maydell --- hw/arm/xi

[Qemu-devel] [PATCH 02/10] hw/sd/sd.c: QOMify

2015-12-11 Thread Peter Maydell
Turn the SD card into a QOM device. This conversion only changes the device itself; the various functions which are effectively methods on the device are not touched at this point. Signed-off-by: Peter Maydell --- hw/sd/sd.c | 99 ++ in

[Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2015-12-11 Thread Peter Maydell
Add a QOM bus for SD cards to plug in to. Note that since sd_enable() is used only by one board and there only as part of a broken implementation, we do not provide it in the SDBus API (but instead add a warning comment about the old function). Whoever converts OMAP and the nseries boards to QOM w

[Qemu-devel] [PATCH 00/10] hw/sd: QOMify sd.c (and pxa2xx_mmci)

2015-12-11 Thread Peter Maydell
This series attempts to QOMify sd.c (the actual SD card model), including a proper QOM bus between the controller and the card. This series removes the experimental x-drive property on sdhci-pci; the syntax for using that device changes: instead of using the x-drive property: -device sdhci-pci

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-11 Thread Stefano Stabellini
On Fri, 11 Dec 2015, Jan Beulich wrote: > >>> On 11.12.15 at 15:33, wrote: > > On Mon, 7 Dec 2015, Jan Beulich wrote: > >> >>> On 07.12.15 at 15:56, wrote: > >> > On Mon, 7 Dec 2015, Jan Beulich wrote: > >> >> >>> On 07.12.15 at 13:45, wrote: > >> >> > On Tue, 24 Nov 2015, Jan Beulich wrote: > >

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-11 Thread Stefano Stabellini
On Fri, 11 Dec 2015, Ian Campbell wrote: > On Fri, 2015-12-11 at 14:26 +, Stefano Stabellini wrote: > > On Wed, 9 Dec 2015, Ian Campbell wrote: > > > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > > > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > > > > index 5e324ef..c96d97

[Qemu-devel] [PATCH 01/10] hw/sd/sdhci.c: Remove x-drive property

2015-12-11 Thread Peter Maydell
The following commits will remove support for the old sdhci-pci command line syntax using the x-drive property: -device sdhci-pci,x-drive=mydrive -drive id=mydrive,[...] and replace it with an explicit sd device: -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive (This is OK beca

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 15:43, Max Reitz wrote: > On 2015-12-11 at 16:40, Peter Maydell wrote: >> >> On 11 December 2015 at 15:30, Eric Blake wrote: >>> >>> On 12/11/2015 08:23 AM, Max Reitz wrote: SQMP -blockdev-remove-medium +x-blockdev-remove-medium ---

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Eric Blake
On 12/11/2015 08:40 AM, Laszlo Ersek wrote: > meta > > On 12/11/15 16:09, Thomas Huth wrote: >> On 11/12/15 15:55, Samuel Thibault wrote: >>> Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: So maybe it's better to do smaller steps instead: Would it for example make sense to split

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Max Reitz
On 2015-12-11 at 16:40, Peter Maydell wrote: On 11 December 2015 at 15:30, Eric Blake wrote: On 12/11/2015 08:23 AM, Max Reitz wrote: SQMP -blockdev-remove-medium +x-blockdev-remove-medium -- Formatting nit, but not worth holding this up (as it is really our last cha

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Laszlo Ersek, on Fri 11 Dec 2015 16:40:32 +0100, wrote: > > Sounds good, ... then I'd suggest to sent the preparation patches > > separately next time and get them accepted first. > > And then the next reviewer will say, "nice, but it would be even nicer > to see what *motivates* these preparatory

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Laszlo Ersek
meta On 12/11/15 16:09, Thomas Huth wrote: > On 11/12/15 15:55, Samuel Thibault wrote: >> Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: >>> So maybe it's better to do smaller steps instead: Would it for example >>> make sense to split the whole series into two parts - first a series >>> t

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 15:30, Eric Blake wrote: > On 12/11/2015 08:23 AM, Max Reitz wrote: >> >> SQMP >> -blockdev-remove-medium >> +x-blockdev-remove-medium >> -- > > Formatting nit, but not worth holding this up (as it is really our last > chance to get it in 2.5 before bak

Re: [Qemu-devel] How does TCG gen host code for a TB?

2015-12-11 Thread Valerón JC
Peter and Sergey, Thank you so much for your help and explanation. I appreciate your helps very much. Sent from Mail for Windows 10 From: Sergey Fedorov Sent: Friday, December 11, 2015 10:21 PM To: Valerón JC;qemu-devel@nongnu.org Subject: Re: [Qemu-devel] How does TCG gen host code for a TB?

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Eric Blake
On 12/11/2015 08:23 AM, Max Reitz wrote: > While in the long term we want throttling to be its own block filter > BDS, in the short term we want it to be part of the BB instead of a BDS; > even in the long term we may want legacy throttling to be automatically > tied to the BB. > > blockdev-insert

Re: [Qemu-devel] [PATCH 08/18] slirp: Adding family argument to tcp_fconnect()

2015-12-11 Thread Thomas Huth
On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch simply adds a sa_family_t argument to remove the hardcoded > "AF_INET" in the call of qemu_socket(). > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel Thibault > --- > slirp/slirp.h | 2 +- > sli

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-11 Thread Ian Campbell
On Fri, 2015-12-11 at 14:26 +, Stefano Stabellini wrote: > On Wed, 9 Dec 2015, Ian Campbell wrote: > > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > > > index 5e324ef..c96d974 100644 > > > --- a/hw/display/xenfb.c > > > +++ b

[Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Max Reitz
While in the long term we want throttling to be its own block filter BDS, in the short term we want it to be part of the BB instead of a BDS; even in the long term we may want legacy throttling to be automatically tied to the BB. blockdev-insert-medium and blockdev-remove-medium do not retain thro

[Qemu-devel] [PATCH for-2.5 0/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Max Reitz
Hello Peter, After having talked about the current status of the block layer today, Markus, Kevin and me agreed to mark the newly introduced QMP commands blockdev-insert-medium and blockdev-remove-medium experimental after all (due to possible interference of its current status with future designs

Re: [Qemu-devel] [PATCH 11/11] pseries: Clean up error reporting in htab migration functions

2015-12-11 Thread Eric Blake
On 12/10/2015 05:11 PM, David Gibson wrote: > The functions for migrating the hash page table on pseries machine type > (htab_save_setup() and htab_load()) can report some errors with an > explicit fprintf() before returning an appropriate eror code. Change these > to use error_report() instead. >

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-11 Thread Jan Beulich
>>> On 11.12.15 at 15:33, wrote: > On Mon, 7 Dec 2015, Jan Beulich wrote: >> >>> On 07.12.15 at 15:56, wrote: >> > On Mon, 7 Dec 2015, Jan Beulich wrote: >> >> >>> On 07.12.15 at 13:45, wrote: >> >> > On Tue, 24 Nov 2015, Jan Beulich wrote: >> >> >> TBD: We probably need to deal with running on

Re: [Qemu-devel] [PATCH 06/11] pseries: Improve error handling in find_unknown_sysbus_device()

2015-12-11 Thread Eric Blake
On 12/10/2015 05:11 PM, David Gibson wrote: > Use error_setg() to return an error instead of using an explicit exit(). > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > +++ b/hw/ppc/spapr.c > @@ -1107,6 +1107,7 @@ static

Re: [Qemu-devel] [PATCH 07/18] slirp: Make udp_attach IPv6 compatible

2015-12-11 Thread Thomas Huth
On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > A sa_family_t is now passed in argument to udp_attach instead of using a > hardcoded "AF_INET" to call qemu_socket(). > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel Thibault > --- > slirp/ip_icmp.c | 2 +- >

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Thomas Huth
On 11/12/15 15:55, Samuel Thibault wrote: > Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: >> So maybe it's better to do smaller steps instead: Would it for example >> make sense to split the whole series into two parts - first a series >> that does all the preparation and cleanup patches.

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Thomas Huth
On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch makes solookup() compatible with varying address families. Also, > this function was only compatible with TCP. Having the socket list in > argument, it is now compatible with UDP too. Finally, some optimization > c

Re: [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

2015-12-11 Thread Eric Blake
On 12/10/2015 05:11 PM, David Gibson wrote: > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > all errors with error_setg(&error_abort, ...). That's correct for > spapr_reset_htab() - if anything goes wrong there, there's really nothing > we can do about it. For spapr_al

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: > So maybe it's better to do smaller steps instead: Would it for example > make sense to split the whole series into two parts - first a series > that does all the preparation and cleanup patches. And then once that > has been reviewed and merg

Re: [Qemu-devel] [PATCH 02/11] pseries: Cleanup error handling of spapr_cpu_init()

2015-12-11 Thread Eric Blake
On 12/10/2015 05:11 PM, David Gibson wrote: > Currently spapr_cpu_init() is hardcoded to handle any errors as fatal. > That works for now, since it's only called from initial setup where an > error here means we really can't proceed. > > However, we'll want to handle this more flexibly for cpu hot

[Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions

2015-12-11 Thread Jason J. Herne
We don't want newlines embedded in error messages. This seems to be a common problem with new code so let's try to catch it with checkpatch. This does not catch the newline when it is in a multiline statement. This is quite a bit more difficult and can be handled as follow on work. Signed-off-by:

Re: [Qemu-devel] [PATCH 04/18] slirp: Make Socket structure IPv6 compatible

2015-12-11 Thread Thomas Huth
On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch replaces foreign and local address/port couples in Socket > structure by 2 sockaddr_storage which can be casted in sockaddr_in. > Direct access to address and port is still possible thanks to some > \#define, so re

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-11 Thread Stefano Stabellini
On Mon, 7 Dec 2015, Jan Beulich wrote: > >>> On 07.12.15 at 15:56, wrote: > > On Mon, 7 Dec 2015, Jan Beulich wrote: > >> >>> On 07.12.15 at 13:45, wrote: > >> > On Tue, 24 Nov 2015, Jan Beulich wrote: > >> >> Now that the hypervisor intercepts all config space writes and monitors > >> >> changes

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Thomas Huth
On 11/12/15 15:01, Samuel Thibault wrote: > Just to explain. > > I'm fine with revamping the patches, provided that we eventually > converge somewhere. > > What I'm afraid of is that splitting patches in yet more many pieces, > revamping the code yet more (moving code into their own functions, et

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-11 Thread Stefano Stabellini
On Wed, 9 Dec 2015, Ian Campbell wrote: > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > > index 5e324ef..c96d974 100644 > > --- a/hw/display/xenfb.c > > +++ b/hw/display/xenfb.c > > @@ -104,9 +104,8 @@ static int common_bind(struct

Re: [Qemu-devel] How does TCG gen host code for a TB?

2015-12-11 Thread Sergey Fedorov
On 11.12.2015 06:43, Valerón JC wrote: > I want to trace a bug in tcg, which for me, at some point, generate > infinite loop TB chains, that's unexpected. and I've found the final > TB(head, since they're chaining) which run in an infinite loop, and I > know a very weird trick to 'disable' this bug

[Qemu-devel] [PATCH V2] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

2015-12-11 Thread Boris Schrijver
A server can respond different to both methods, or can block one of the two. Signed-off-by: Boris Schrijver Reviewed-by: John Snow --- V2: Impovements over V1: - Don't check for CURLE_WRITE_ERROR, on success CURLE_OK will be returned. - Use CURLOPT_CUSTOMREQUEST instead of CURLOPT_HTTPGET. ---

Re: [Qemu-devel] [PATCH 06/16] acpi: Save PCMachineState on AcpiBuildState

2015-12-11 Thread Eduardo Habkost
On Wed, Dec 09, 2015 at 08:37:16PM +0100, Igor Mammedov wrote: > On Tue, 8 Dec 2015 20:44:38 +0200 > Marcel Apfelbaum wrote: > > On 12/08/2015 07:59 PM, Eduardo Habkost wrote: > > > On Mon, Dec 07, 2015 at 05:39:29PM +0200, Marcel Apfelbaum wrote: > > >> On 12/02/2015 03:47 AM, Eduardo Habkost wro

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Just to explain. I'm fine with revamping the patches, provided that we eventually converge somewhere. What I'm afraid of is that splitting patches in yet more many pieces, revamping the code yet more (moving code into their own functions, etc.) will only make the patch series look even bigger and

Re: [Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat()

2015-12-11 Thread Eric Blake
On 12/10/2015 05:11 PM, David Gibson wrote: > Current ppc_set_compat() returns -1 for errors, and also (unconditionally) > reports an error message. The caller in h_client_architecture_support() > may then report it again using an outdated fprintf(). > > Clean this up by using the modern error re

Re: [Qemu-devel] [Qemu-block] [PATCH V2] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

2015-12-11 Thread Eric Blake
[adding qemu-devel; per http://wiki.qemu.org/Contribute/SubmitAPatch, ALL patches must include qemu-devel, even if they are also copying other sublists] On 12/11/2015 01:40 AM, Boris Schrijver wrote: > A server can respond different to both methods, or can block one of the two. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Thomas Huth
On 11/12/15 14:47, Samuel Thibault wrote: > Thomas Huth, on Fri 11 Dec 2015 14:43:42 +0100, wrote: >> Anyway, it's IMHO a somewhat strange way to structure a patch ... maybe >> it would be nicer to do it in one go instead (after splitting off the >> arp_requested renaming)? > > Please discuss abou

Re: [Qemu-devel] [PATCH v7 13/31] qapi: Drop unused 'kind' for struct/enum visit

2015-12-11 Thread Eric Blake
On 12/07/2015 08:55 PM, Eric Blake wrote: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the arg

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Thomas Huth
On 11/12/15 14:43, Thomas Huth wrote: > On 11/12/15 14:38, Thomas Huth wrote: >> On 11/12/15 01:15, Samuel Thibault wrote: >>> From: Guillaume Subiron >>> >>> Basically, this patch replaces "arp" by "resolution" every time "arp" >>> means "mac resolution" and not specifically ARP. >>> >>> Some ind

  1   2   >