Re: [Qemu-devel] Reminder: QEMU 2.5rc3 (final RC) planned for Thurs 1st Dec, please get bugfixes in before then

2015-11-30 Thread Markus Armbruster
Peter Maydell writes: > Hi; just a reminder that QEMU 2.5 rc3 is planned for this Thursday, > the 1st December. (http://wiki.qemu.org/Planning/2.5#Release_Schedule) 3rd > This is our last scheduled release candidate, so please make sure you > get all outstanding bugfixes for 2.5 in before then.

[Qemu-devel] BUG ALERT: vexpress model + KVM does not boot up with default settings

2015-11-30 Thread Pavel Fedin
Hello! Unfortunately i don't have much time to investigate this and it is out of my project's scope, but from time to time i test vexpress model on ARM32. And after the recent changes regarding TrustZone support vexpress model with direct kernel boot in KVM gets stuck at this point: --- cut -

Re: [Qemu-devel] [Qemu-ppc] [PATCH 40/77] ppc/pnv: Wire up XICS native with PowerNV platform

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:53AM +1100, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Looks sound enough, but will probably need some rework due to other suggested changes in the new xics stuff. > --- > hw/ppc/pnv.c | 69 >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 41/77] ppc/pnv: Add LPC controller and hook it up with a UART and RTC

2015-11-30 Thread David Gibson
On Tue, Nov 17, 2015 at 11:40:04AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2015-11-17 at 11:32 +1100, Alexey Kardashevskiy wrote: > > On 11/11/2015 11:27 AM, Benjamin Herrenschmidt wrote: > > > This adds a model of the POWER8 LPC controller. It is then used > > > by the PowerNV code to attac

Re: [Qemu-devel] [Qemu-ppc] [PATCH 38/77] ppc/xics: Add "native" XICS subclass

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:51AM +1100, Benjamin Herrenschmidt wrote: > This provides MMIO based ICP access as found on POWER8 > > Signed-off-by: Benjamin Herrenschmidt [snip] > +static void xics_native_realize(DeviceState *dev, Error **errp) > +{ > +XICSState *s = XICS_NATIVE(dev); > +

Re: [Qemu-devel] [Qemu-ppc] [PATCH 38/77] ppc/xics: Add "native" XICS subclass

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:51AM +1100, Benjamin Herrenschmidt wrote: > This provides MMIO based ICP access as found on POWER8 Mostly looks sound. I note that the links registers don't actually do anything at this point, I assume thats intentional. It probably deserves a comment somewhere (in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 39/77] ppc/xics: Add xics to the monitor "info pic" command

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:52AM +1100, Benjamin Herrenschmidt wrote: > Useful to debug interrupt problems. Ugh.. I can see the use of this, but we really want to just deprecate info pic entirely, it's an awful, awful interface. I think the right way to do this is to allow some state introspect

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

2015-11-30 Thread Lan, Tianyu
On 11/30/2015 4:01 PM, Michael S. Tsirkin wrote: It is still not very clear what it is you are trying to achieve, and whether your patchset achieves it. You merely say "adding live migration" but it seems pretty clear this isn't about being able to migrate a guest transparently, since you are

Re: [Qemu-devel] [Qemu-ppc] [PATCH 37/77] ppc/xics: Split ICS into base class and "simple" implementation

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:50AM +1100, Benjamin Herrenschmidt wrote: > The existing implementation becomes the "ics-simple" subclass of ICS, > so there should be no change in behaviour for SPAPR. > > This will allow different implementations for the source controllers > such as the MSI support

Re: [Qemu-devel] [PATCH v3] vmxnet3: silence warning

2015-11-30 Thread Jason Wang
On 12/01/2015 12:26 AM, Michael S. Tsirkin wrote: > vmxnet3 always produces a warning under qtest. > > This is not a user error, don't warn. > > Suggested-by: Paolo Bonzini > Signed-off-by: Michael S. Tsirkin > --- > > Now for real. > > hw/net/vmxnet3.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [Qemu-devel] [PATCH for 2.5 1/2] net: pcnet: add check to validate receive data size(CVE-2015-7504)

2015-11-30 Thread Jason Wang
On 11/30/2015 06:46 PM, Michael S. Tsirkin wrote: > On Mon, Nov 30, 2015 at 03:38:22PM +0800, Jason Wang wrote: >> From: Prasad J Pandit >> >> In loopback mode, pcnet_receive routine appends CRC code to the >> receive buffer. If the data size given is same as the buffer size, >> the appended CRC

Re: [Qemu-devel] [PATCH for 2.5 2/2] pcnet: fix rx buffer overflow(CVE-2015-7512)

2015-11-30 Thread Jason Wang
On 11/30/2015 06:46 PM, Michael S. Tsirkin wrote: > On Mon, Nov 30, 2015 at 03:38:23PM +0800, Jason Wang wrote: >> Backends could provide a packet whose length is greater than buffer >> size. Check for this and truncate the packet to avoid rx buffer >> overflow in this case. >> >> Cc: Prasad J Pa

Re: [Qemu-devel] [Qemu-ppc] [PATCH 33/77] ppc/xics: Make the ICSState a list

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:46AM +1100, Benjamin Herrenschmidt wrote: > Instead of an array of fixed sized blocks, use a list, as we will need > to have sources with variable number of interrupts. SPAPR only uses > a single entry. Native will create more. If performance becomes an > issue we can

Re: [Qemu-devel] [Qemu-ppc] [PATCH 34/77] ppc/xics: An ICS with offset 0 is assumed to be uninitialized

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:47AM +1100, Benjamin Herrenschmidt wrote: > This will make life easier for dealing with dynamically configured > ICSes such as PHB3 > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson > --- > include/hw/ppc/xics.h | 2 +- > 1 file changed, 1 inse

Re: [Qemu-devel] [Qemu-ppc] [PATCH 36/77] ppc/xics: Use a helper to add a new ICS

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:49AM +1100, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Hmm.. does it make sense for the helper to do the object_new() and add_child() as well? > --- > hw/intc/xics.c| 6 ++ > hw/intc/xics_spapr.c | 3 +-- > include/hw/ppc/xi

Re: [Qemu-devel] [Qemu-ppc] [PATCH 35/77] ppc/xics: Move xics_set_nr_irqs() to xics_spapr.c and xics_kvm.c

2015-11-30 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:48AM +1100, Benjamin Herrenschmidt wrote: > It will not be used by the native implementation. This allows us to > also remove the include of spapr.h from the common code > > Signed-off-by: Benjamin Herrenschmidt > --- > hw/intc/xics.c| 12 > hw/

Re: [Qemu-devel] [PATCH v5 08/10] spapr: CPU hotplug support

2015-11-30 Thread Bharata B Rao
On Tue, Dec 01, 2015 at 12:30:12PM +1100, David Gibson wrote: > On Fri, Nov 20, 2015 at 06:24:37PM +0530, Bharata B Rao wrote: > > Support CPU hotplug via device-add command. Set up device tree > > entries for the hotplugged CPU core and use the exising EPOW event > > infrastructure to send CPU hot

Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump"

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 03:17:01PM -0700, Eric Blake wrote: > On 11/30/2015 04:32 AM, Peter Xu wrote: > > +DumpQueryResult *qmp_query_dump(Error **errp) > > +{ > > +DumpQueryResult *result = g_malloc0(sizeof(*result)); > > Might be nicer as g_new0(DumpQueryResult, 1). Markus has been switching

Re: [Qemu-devel] [PATCH v3 12/12] Dump: enhance the documentations.

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 03:22:37PM -0700, Eric Blake wrote: > On 11/30/2015 04:32 AM, Peter Xu wrote: > > Add more documents to mention about "query-dump" and DUMP_COMPLETED > > events. > > > > Signed-off-by: Peter Xu > > --- > > qapi-schema.json | 7 +-- > > qmp-commands.hx | 4 +++- > > 2

Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump"

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 01:56:42PM +0100, Paolo Bonzini wrote: > > > On 30/11/2015 12:32, Peter Xu wrote: > > +{ > > +DumpQueryResult *result = g_malloc0(sizeof(*result)); > > +DumpState *state = dump_state_get_global(); > > +result->status = state->status; > > +result->written_by

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-30 Thread David Gibson
On Thu, Nov 12, 2015 at 08:46:27AM -0800, Nishanth Aravamudan wrote: > On 12.11.2015 [15:47:15 +1100], David Gibson wrote: > > On Wed, Nov 11, 2015 at 02:10:48PM -0800, Nishanth Aravamudan wrote: > > > On 11.11.2015 [12:41:26 +1100], David Gibson wrote: > > > > On Tue, Nov 10, 2015 at 04:56:38PM -0

Re: [Qemu-devel] [PATCH for 2.5 1/1] e1000: fix hang of win2k12 shutdown with flood ping

2015-11-30 Thread Jason Wang
On 11/30/2015 02:22 PM, Denis V. Lunev wrote: > On 11/30/2015 08:58 AM, Jason Wang wrote: >> >> On 11/27/2015 07:42 PM, Denis V. Lunev wrote: >>> On 11/27/2015 09:50 AM, Denis V. Lunev wrote: On 11/27/2015 09:48 AM, Denis V. Lunev wrote: > e1000 driver in Win2k12 is really well rotten. I

Re: [Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 03:12:31PM -0700, Eric Blake wrote: > On 11/30/2015 04:32 AM, Peter Xu wrote: > > +Example: > > + > > +{ "event": "DUMP_COMPLETED", > > + "data": {} } > > Please keep this file sorted. The insertion should be between > DEVICE_TRAY_MOVED and GUEST_PANICKED. Sorry for the

Re: [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function.

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 01:55:01PM +0100, Paolo Bonzini wrote: > > > On 30/11/2015 12:32, Peter Xu wrote: > > if (*errp) { > > s->status = DUMP_STATUS_FAILED; > > Why not move this "if" to dump_process as well? Yes. I did that in another patch. I will move it to this patch, which

Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 03:08:24PM -0700, Eric Blake wrote: > On 11/30/2015 04:32 AM, Peter Xu wrote: > > Instead of malloc/free each time for DumpState, make it > > static. Added DumpStatus to show status for dump. > > > > This is to be used for detach dump. > > s/detach/detached/ > > > > > Si

Re: [Qemu-devel] [RFC 01/12] vfio: Start improving VFIO/EEH interface

2015-11-30 Thread David Gibson
On Mon, Nov 23, 2015 at 02:58:11PM -0700, Alex Williamson wrote: > On Thu, 2015-11-19 at 15:29 +1100, David Gibson wrote: > > At present the code handling IBM's Enhanced Error Handling (EEH) interface > > on VFIO devices operates by bypassing the usual VFIO logic with > > vfio_container_ioctl(). T

Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 02:00:28PM +0100, Paolo Bonzini wrote: > > +/* init dump state with specific status */ > > +static void dump_state_prepare(DumpState *s, DumpStatus status) > > +{ > > +bzero(s, sizeof(*s)); > > +s->status = status; > > Either use memcpy, or > > s = (DumpState)

Re: [Qemu-devel] [PATCH v3 02/12] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 03:05:10PM -0700, Eric Blake wrote: > On 11/30/2015 04:32 AM, Peter Xu wrote: > > This patch only adds the interfaces, but not implements them. > > "detach" parameter is made optional, to make sure that all the old > > dump-guest-memory requests will still be able to work. >

Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 11:27:35AM -0700, Eric Blake wrote: > On 11/26/2015 07:48 PM, Peter Xu wrote: > > This patch is only adding the QMP/HMP interface for "dump-query" > > command, but not implementing them. This command could be used to > > query background dump status. Please refer to the next

Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 11:18:48AM -0700, Eric Blake wrote: > On 11/26/2015 07:48 PM, Peter Xu wrote: > > To get aligned with QMP interface, one new QMP event DUMP_COMPLETED > > is added. It is used when user specified "detach" in dump, and > > triggered when the dump finishes. Error message will b

Re: [Qemu-devel] [PATCH v5 02/10] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:31PM +0530, Bharata B Rao wrote: > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It > should be removed from cpu_exec_exit(). > > cpu_exec_init() is called from generic CPU::instance_finalize and some > archs like PowerPC call it from CPU unrealize

Re: [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug

2015-11-30 Thread David Gibson
On Mon, Nov 23, 2015 at 02:04:46PM +0100, Christian Borntraeger wrote: > On 11/23/2015 12:54 PM, Peter Krempa wrote: > > On Fri, Nov 20, 2015 at 18:24:29 +0530, Bharata B Rao wrote: > >> This patchset adds CPU hotplug support for sPAPR PowerPC guests using > >> device_add and device_del commands >

Re: [Qemu-devel] [PATCH v5 09/10] spapr: CPU hot unplug support

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:38PM +0530, Bharata B Rao wrote: > Support hot removal of CPU for sPAPR guests by sending the hot unplug > notification to the guest via EPOW interrupt. Release the vCPU object > after CPU hot unplug so that vCPU fd can be parked and reused. > > Signed-off-by: Bharata

Re: [Qemu-devel] [PATCH v5 03/10] exec: Do vmstate unregistration from cpu_exec_exit()

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:32PM +0530, Bharata B Rao wrote: > cpu_exec_init() does vmstate_register and register_savevm for the CPU device. > These need to be undone from cpu_exec_exit(). These changes are needed to > support CPU hot removal and also to correctly fail hotplug attempts > beyond m

Re: [Qemu-devel] [edk2] Could not add PCI device with big memory to aarch64 VMs

2015-11-30 Thread Laszlo Ersek
On 12/01/15 01:46, liang yan wrote: > Hello, Laszlo, > > On 11/30/2015 03:05 PM, Laszlo Ersek wrote: [snip] >> If you need more room (with large alignments), then there's no way >> around supporting QEMU's 64 bit aperture, VIRT_PCIE_MMIO_HIGH (see my >> earlier email). > I checked the function c

Re: [Qemu-devel] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially filled cores

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:30PM +0530, Bharata B Rao wrote: > Prevent guests from booting with CPU topologies that have partially > filled CPU cores or can result in partially filled CPU cores after > CPU hotplug like > > -smp 15,sockets=1,cores=4,threads=4,maxcpus=16 or > -smp 15,sockets=1,cor

Re: [Qemu-devel] [PATCH v5 04/10] cpu: Reclaim vCPU objects

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:33PM +0530, Bharata B Rao wrote: > From: Gu Zheng > > In order to deal well with the kvm vcpus (which can not be removed without any > protection), we do not close KVM vcpu fd, just record and mark it as stopped > into a list, so that we can reuse it for the appendin

Re: [Qemu-devel] [PATCH v5 08/10] spapr: CPU hotplug support

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:37PM +0530, Bharata B Rao wrote: > Support CPU hotplug via device-add command. Set up device tree > entries for the hotplugged CPU core and use the exising EPOW event > infrastructure to send CPU hotplug notification to the guest. > > Create only cores explicitly from

Re: [Qemu-devel] [PATCH v5 06/10] xics_kvm: Add cpu_destroy method to XICS

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:35PM +0530, Bharata B Rao wrote: > XICS is setup for each CPU during initialization. Provide a routine > to undo the same when CPU is unplugged. > > This allows reboot of a VM that has undergone CPU hotplug and unplug > to work correctly. > > Signed-off-by: Bharata B

Re: [Qemu-devel] [PATCH v5 07/10] spapr: Enable CPU hotplug for pseries-2.5 and add CPU DRC DT entries

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:36PM +0530, Bharata B Rao wrote: > Start supporting CPU hotplug from pseries-2.5 onwards. Add CPU > DRC (Dynamic Resource Connector) device tree entries. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 23 +++ > include/hw/ppc/s

Re: [Qemu-devel] [PATCH v5 05/10] cpu: Add a sync version of cpu_remove()

2015-11-30 Thread David Gibson
On Fri, Nov 20, 2015 at 06:24:34PM +0530, Bharata B Rao wrote: > This sync API will be used by the CPU hotplug code to wait for the CPU to > completely get removed before flagging the failure to the device_add > command. > > Sync version of this call is needed to correctly recover from CPU > reali

Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 11:21:23AM -0700, Eric Blake wrote: > On 11/26/2015 07:48 PM, Peter Xu wrote: > > This patch only adds the interfaces, but not implements them. > > s/not implements/does not implement/ > > > "detach" parameter is made optional, to make sure that all the old > > dump-guest-

Re: [Qemu-devel] [edk2] Could not add PCI device with big memory to aarch64 VMs

2015-11-30 Thread liang yan
Hello, Laszlo, On 11/30/2015 03:05 PM, Laszlo Ersek wrote: On 11/30/15 19:45, liang yan wrote: On 11/04/2015 05:53 PM, Laszlo Ersek wrote: On 11/04/15 23:22, liang yan wrote: Hello, Laszlo, (2)It also has a problem that once I use a memory bigger than 256M for ivshmem, it could not get thr

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

2015-11-30 Thread Ming Lin
On Mon, 2015-11-23 at 15:14 +0100, Paolo Bonzini wrote: > > On 23/11/2015 09:17, Ming Lin wrote: > > On Sat, 2015-11-21 at 14:11 +0100, Paolo Bonzini wrote: > >> > >> On 20/11/2015 01:20, Ming Lin wrote: > >>> One improvment could be to use google's NVMe vendor extension that > >>> I send in anoth

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform

2015-11-30 Thread Benjamin Herrenschmidt
On Mon, 2015-11-30 at 22:24 +0100, Cédric Le Goater wrote: > > In practice we should read the partition tables, I don't like hard > > coded offsets... But we should probably create a proper "flash driver" > > that does a bunch of this, and also adds the BMC style flash interface > > so OPAL can wri

[Qemu-devel] [Bug 1450881] Re: qemu-system-sparc MUTEX_HELD assert and libC lock errors

2015-11-30 Thread Mark Cave-Ayland
Not yet - things have been made much harder now as my original test image tends to hang for long periods of time instead of giving the MUTEX_HELD error. If you have an image that you would be willing to share for debugging, please get in touch via email and I'll try and take a look. -- You receiv

Re: [Qemu-devel] [PATCH] m25p80.c Added support for N25Q256 and N25Q512

2015-11-30 Thread Peter Crosthwaite
On Mon, Nov 30, 2015 at 1:33 PM, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > >> -Original Message- >> From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Monday, November 30, 2015 9:55 PM >> To: Krzeminski, Marcin (Nokia - PL/Wroclaw) >> Cc: qemu-devel@nongnu.or

[Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-11-30 Thread Andrew Baumann
Qemu does not generally perform alignment checks. However, the ARM ARM requires implementation of alignment exceptions for a number of cases including LDREX, and Windows-on-ARM relies on this. This change adds a helper function to raise an alignment exception (data abort), a framework for implemen

Re: [Qemu-devel] [PATCH v3 12/12] Dump: enhance the documentations.

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > Add more documents to mention about "query-dump" and DUMP_COMPLETED > events. > > Signed-off-by: Peter Xu > --- > qapi-schema.json | 7 +-- > qmp-commands.hx | 4 +++- > 2 files changed, 8 insertions(+), 3 deletions(-) Why not squash this in to the

Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump"

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > When dump-guest-memory is requested with detach flag, after its > return, user could query its status using "query-dump" command (with > no argument). The result for now contains: > > - status: current dump status > - written_bytes: bytes written in latest

Re: [Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > One new QMP event DUMP_COMPLETED is added. It is used when user > specified "detach" in dump, and triggered when the dump finishes > (either succeeded or failed). If failed, one "err" data will be > passed with specific error message. > > Signed-off-by: Pe

[Qemu-devel] Reminder: QEMU 2.5rc3 (final RC) planned for Thurs 1st Dec, please get bugfixes in before then

2015-11-30 Thread Peter Maydell
Hi; just a reminder that QEMU 2.5 rc3 is planned for this Thursday, the 1st December. (http://wiki.qemu.org/Planning/2.5#Release_Schedule) This is our last scheduled release candidate, so please make sure you get all outstanding bugfixes for 2.5 in before then. As usual I intend to only roll an ext

[Qemu-devel] [PATCH] exec: Stop using memory after free

2015-11-30 Thread Don Slutz
memory_region_unref(mr) can free memory. For example I got: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f43280d4700 (LWP 4462)] 0x7f43323283c0 in phys_section_destroy (mr=0x7f43259468b0) at /home/don/xen/tools/qemu-xen-dir/exec.c:1023 1023if (mr->s

Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > Instead of malloc/free each time for DumpState, make it > static. Added DumpStatus to show status for dump. > > This is to be used for detach dump. s/detach/detached/ > > Signed-off-by: Peter Xu > --- > dump.c| 30 +

Re: [Qemu-devel] [edk2] Could not add PCI device with big memory to aarch64 VMs

2015-11-30 Thread Laszlo Ersek
On 11/30/15 19:45, liang yan wrote: > > > On 11/04/2015 05:53 PM, Laszlo Ersek wrote: >> On 11/04/15 23:22, liang yan wrote: >>> Hello, Laszlo, >>> >>> >>> (2)It also has a problem that once I use a memory bigger than 256M for >>> ivshmem, it could not get through UEFI, >>> the error message is >

Re: [Qemu-devel] [PATCH v3 02/12] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > This patch only adds the interfaces, but not implements them. > "detach" parameter is made optional, to make sure that all the old > dump-guest-memory requests will still be able to work. > > Signed-off-by: Peter Xu > --- > dump.c | 5 +++-- >

Re: [Qemu-devel] [PULL 0/5] ppc-for-2.5 queue 20151130

2015-11-30 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.5-20151130 > > for you to fetch changes up to 7624789234cd63b671bce1b49b93b0b1c00ea407: > > target-ppc/fpu_helper: fix FPSCR_FX bit

Re: [Qemu-devel] [PATCH] m25p80.c Added support for N25Q256 and N25Q512

2015-11-30 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, November 30, 2015 9:55 PM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > Cc: qemu-devel@nongnu.org; g...@xilinx.com; Sai Pavan Boddu > Subject: Re: [Qemu-devel] [PATCH] m25p80.c Added s

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform

2015-11-30 Thread Cédric Le Goater
On 11/30/2015 09:09 PM, Benjamin Herrenschmidt wrote: > On Mon, 2015-11-30 at 19:15 +0100, Cédric Le Goater wrote: >> The pnor file is compiled from github. The patch is below (without the dirty >> cut and paste I did in loader.c). The offset for the PAYLOAD and BOOTKERNEL >> partitions are hard co

Re: [Qemu-devel] [PATCH] m25p80.c Added support for N25Q256 and N25Q512

2015-11-30 Thread Peter Crosthwaite
On Mon, Nov 30, 2015 at 11:51 AM, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > >> -Original Message- >> From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Sunday, November 29, 2015 8:19 PM >> To: Krzeminski, Marcin (Nokia - PL/Wroclaw) >> Cc: qemu-devel@nongnu.o

Re: [Qemu-devel] SPI EEPROM device model

2015-11-30 Thread Peter Crosthwaite
On Mon, Nov 30, 2015 at 11:43 AM, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > >> -Original Message- >> From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Monday, November 30, 2015 7:45 PM >> To: Krzeminski, Marcin (Nokia - PL/Wroclaw) >> Cc: qemu-devel@nongnu.o

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform

2015-11-30 Thread Benjamin Herrenschmidt
On Mon, 2015-11-30 at 19:15 +0100, Cédric Le Goater wrote: > The pnor file is compiled from github. The patch is below (without the dirty > cut and paste I did in loader.c). The offset for the PAYLOAD and BOOTKERNEL > partitions are hard coded but I guess we don't need to read the flash > partitio

Re: [Qemu-devel] [PATCH] m25p80.c Added support for N25Q256 and N25Q512

2015-11-30 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Sunday, November 29, 2015 8:19 PM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > Cc: qemu-devel@nongnu.org; g...@xilinx.com; Sai Pavan Boddu > Subject: Re: [Qemu-devel] [PATCH] m25p80.c Added s

Re: [Qemu-devel] SPI EEPROM device model

2015-11-30 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, November 30, 2015 7:45 PM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > Cc: qemu-devel@nongnu.org > Subject: Re: SPI EEPROM device model > > On Mon, Nov 30, 2015 at 12:53 AM, Krzemins

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.5] blkdebug: silence warning under qtest

2015-11-30 Thread Max Reitz
On 30.11.2015 12:44, Michael S. Tsirkin wrote: > make check always outputs warnings, this > is not nice. Disable blkdebug warnings under qtest. > > Signed-off-by: Michael S. Tsirkin > --- > block/blkdebug.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks, applied to my

Re: [Qemu-devel] [PATCH 0/7] target-i386: MMReg struct cleanup

2015-11-30 Thread Richard Henderson
On 11/30/2015 10:21 AM, Eduardo Habkost wrote: This is an attempt to cleanup the MMXReg/XMMReg structs and make their names, fields and usage consistent. The last 2 patches use a bit of macro magic to generate the union definitions and ensure type safety when using the field helper macros, and I

Re: [Qemu-devel] SPI EEPROM device model

2015-11-30 Thread Peter Crosthwaite
On Mon, Nov 30, 2015 at 12:53 AM, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > Hello, > > I need to write some SPI eeprom device model (probably AT25128B or AT93C56). > I can not see any such device in qemu, but this time I want to ask before I > start to implement, > if something that can sp

Re: [Qemu-devel] Could not add PCI device with big memory to aarch64 VMs

2015-11-30 Thread liang yan
On 11/04/2015 05:53 PM, Laszlo Ersek wrote: On 11/04/15 23:22, liang yan wrote: Hello, Laszlo, (2)It also has a problem that once I use a memory bigger than 256M for ivshmem, it could not get through UEFI, the error message is PciBus: Discovered PCI @ [00|01|00] BAR[0]: Type = Mem32; A

[Qemu-devel] [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle --- error_report()'s had their \n

Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

2015-11-30 Thread Eric Blake
On 11/26/2015 07:48 PM, Peter Xu wrote: > This patch is only adding the QMP/HMP interface for "dump-query" > command, but not implementing them. This command could be used to > query background dump status. Please refer to the next patch to see > how dump status are defined. > > Currently, only fa

[Qemu-devel] [PATCH 7/7] [RFC] target-i386: Add suffixes to MMReg struct fields

2015-11-30 Thread Eduardo Habkost
This will ensure we never use the MMX_* and ZMM_* macros with the wrong struct type. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 66 +++ 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/

[Qemu-devel] [PATCH 4/7] target-i386: Rename XMM_[BWLSDQ] helpers to ZMM_*

2015-11-30 Thread Eduardo Habkost
They are helpers for the ZMMReg fields, so name them accordingly. This is just a global search+replace, no other changes are being introduced. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h| 24 ++-- target-i386/fpu_helper.c | 8 +- target-i386/gdbstub.c| 8 +- target-i38

[Qemu-devel] [PATCH 6/7] [RFC] target-i386: Define MMREG_UNION macro

2015-11-30 Thread Eduardo Habkost
This will simplify the definitions of ZMMReg and MMXReg. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 7519023..b189748 100644 --- a/target-i386/cp

[Qemu-devel] [PATCH 5/7] target-i386: Define MMXReg._d field

2015-11-30 Thread Eduardo Habkost
Add a new field and reorder MMXReg fields, to make MMXReg and ZMMReg field lists look the same (except for the array sizes). Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 6141

[Qemu-devel] [PATCH 1/7] target-i386/ops_sse.h: Use MMX_Q macro

2015-11-30 Thread Eduardo Habkost
We have a MMX_Q macro in addition to MMX_{B,W,L}. Use it. Signed-off-by: Eduardo Habkost --- target-i386/ops_sse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h index 1780d1d..52ec0b0 100644 --- a/target-i386/ops_sse.h +++ b/tar

[Qemu-devel] [PATCH 2/7] target-i386: Use a _q array on MMXReg too

2015-11-30 Thread Eduardo Habkost
Make MMXReg use the same field names used on XMMReg, so we can try to reuse macros and other code later. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 84edfd0..154891e 10064

[Qemu-devel] [PATCH 3/7] target-i386: Rename struct XMMReg to ZMMReg

2015-11-30 Thread Eduardo Habkost
The struct represents a 512-bit register, so name it accordingly. This is just a global search+replace, no other changes are being introduced. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h| 6 ++-- target-i386/machine.c| 40 ++--- target-i386/ops_sse.

[Qemu-devel] [PATCH 0/7] target-i386: MMReg struct cleanup

2015-11-30 Thread Eduardo Habkost
This is an attempt to cleanup the MMXReg/XMMReg structs and make their names, fields and usage consistent. The last 2 patches use a bit of macro magic to generate the union definitions and ensure type safety when using the field helper macros, and I am sending them as RFCs. Eduardo Habkost (7):

Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-30 Thread Eric Blake
On 11/26/2015 07:48 PM, Peter Xu wrote: > This patch only adds the interfaces, but not implements them. s/not implements/does not implement/ > "detach" parameter is made optional, to make sure that all the old > dump-guest-memory requests will still be able to work. > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-30 Thread Eric Blake
On 11/26/2015 07:48 PM, Peter Xu wrote: > To get aligned with QMP interface, one new QMP event DUMP_COMPLETED > is added. It is used when user specified "detach" in dump, and > triggered when the dump finishes. Error message will be appended to > this event if the dump has failed. Why not emit the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform

2015-11-30 Thread Cédric Le Goater
On 11/28/2015 08:59 AM, Benjamin Herrenschmidt wrote: > On Fri, 2015-11-27 at 11:21 +0100, Alexander Graf wrote: >> >> How does real hardware store petitboot? If it's flash, you could pass it >> in using -pflash and thus model things even more closely and allow users >> to just take the ROM image a

Re: [Qemu-devel] [PATCH v2 2/2] hmp: add support for system_suspend

2015-11-30 Thread Eric Blake
On 11/27/2015 08:01 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add support for system_suspend hmp command. > > Signed-off-by: Chen Hanxiao > --- > hmp-commands.hx | 14 ++ > hmp.c | 5 + > hmp.h | 1 + > 3 files changed, 20 insertions(+) >

Re: [Qemu-devel] [PATCH v2 1/2] qmp: add support for system_suspend

2015-11-30 Thread Eric Blake
On 11/27/2015 08:01 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add support for system_suspend qmp command. > > Signed-off-by: Chen Hanxiao > --- > qapi-schema.json | 9 + > qmp-commands.hx | 21 + > qmp.c| 5 + > 3 files changed,

Re: [Qemu-devel] [PATCH v7 24/24] iotests: Add test for block jobs and BDS ejection

2015-11-30 Thread Max Reitz
On 30.11.2015 17:23, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> Suggested-by: Paolo Bonzini >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/141 | 166 >> + >> tests/qemu-iotests/141.out | 47 + >>

[Qemu-devel] [PATCH v2 2/3] target-i386: Use xsave structs for ext_save_area

2015-11-30 Thread Eduardo Habkost
This doesn't introduce any change in the code, as the offsets and struct sizes match what was present in the table. This can be validated by the QEMU_BUILD_BUG_ON lines on target-i386/cpu.h, which ensures the struct sizes and offsets match the existing values in ext_save_area. Signed-off-by: Eduar

[Qemu-devel] [PATCH v2 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load

2015-11-30 Thread Eduardo Habkost
Instead of using offset macros and bit operations in a uint32_t array, use the X86XSaveArea struct to perform the loading/saving operations in kvm_put_xsave() and kvm_get_xsave(). Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use uint8_t pointers when loading/saving xmm, ymmh, zmmh, ke

[Qemu-devel] [PATCH v2 1/3] target-i386: Define structs for layout of xsave area

2015-11-30 Thread Eduardo Habkost
Add structs that define the layout of the xsave areas used by Intel processors. Add some QEMU_BUILD_BUG_ON lines to ensure the structs match the XSAVE_* macros in target-i386/kvm.c and the offsets and sizes at target-i386/cpu.c:ext_save_areas. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2:

[Qemu-devel] [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes

2015-11-30 Thread Eduardo Habkost
target-i386/cpu.c:ext_save_area uses magic numbers for the xsave area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave() uses offset macros and bit manipulation to access the xsave area. This series changes both to use C structs for those operations. I still need to figure out a way to

Re: [Qemu-devel] [PATCH v7 14/24] nbd: Switch from close to eject notifier

2015-11-30 Thread Max Reitz
On 30.11.2015 16:36, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> The NBD code uses the BDS close notifier to determine when a medium is >> ejected. However, now it should use the BB's BDS removal notifier for >> that instead of the BDS's close notifier. >> >> Signed-off

Re: [Qemu-devel] [PATCH v6 20/21] iotests: add incremental backup failure recovery test

2015-11-30 Thread John Snow
On 11/27/2015 12:14 PM, Kevin Wolf wrote: > Am 18.04.2015 um 01:50 hat John Snow geschrieben: >> Test the failure case for incremental backups. >> >> Signed-off-by: John Snow >> Reviewed-by: Max Reitz >> --- >> tests/qemu-iotests/124 | 57 >> ++

Re: [Qemu-devel] [PULL 0/3] wxx: Last minute fixes for 2.5

2015-11-30 Thread Peter Maydell
ble in the git repository at: > > git://qemu.weilnetz.de/qemu.git tags/pull-wxx-20151130 > > for you to fetch changes up to 78e9d4ad11e7116376328860a58b96765ade7b62: > > w32: Use gcc option -mthreads (2015-11-30 06:47:02 +0100) > > --

Re: [Qemu-devel] [PATCH v10] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/30/2015 09:51 AM, Programmingkid wrote: >>> +++ b/block/raw-posix.c >>> @@ -42,9 +42,9 @@ >>> #include >>> #include >>> #include >>> -//#include >>> +#include >>> #include >>> -#endif >>> +#endif /* (__APPLE__) && (__MACH__) */ >>> >> >> I have now mentioned in both v8 and v9 that this

[Qemu-devel] keycode error

2015-11-30 Thread hjenkins
Dear QEMU Developers, I'm trying to use QEMU to run Debian on OS X Yosemite on a MacBookPro (13-inch). I followed the instructions at https://wiki.debian.org/QEMU, downloaded a standard prefab iso, and issued these commands with this result: qemu-img create debian.img 2G qemu-system-x86_64 -hda

[Qemu-devel] [Bug 1450881] Re: qemu-system-sparc MUTEX_HELD assert and libC lock errors

2015-11-30 Thread Pierre L
Hi all, I also have this issue with my sparcstation installation : Emulated OS : SunOS 5.5.1 Emulated Processor : sparc Host machine OS : Linux RED HAT Do you manage to fix it ? -- You received this bug notificat

[Qemu-devel] iSCSI options for IQN with colons

2015-11-30 Thread Pino Toscano
Hi, while testing the integration of QEMU with iSCSI, I was setting up an environment with both target and initiator IQNs with colons. Then I tried to connect to two different targets using two different initiator IQN, like the following: $ qemu ... \ -iscsi id=iqn.2015-11.com.bla:suffix

Re: [Qemu-devel] [PATCH] mmap-alloc: use same backend for all mappings

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2015 at 02:46:31PM +0100, Greg Kurz wrote: > On Mon, 30 Nov 2015 15:06:33 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 30, 2015 at 11:51:57AM +0100, Greg Kurz wrote: > > > Since commit 8561c9244ddf1122d "exec: allocate PROT_NONE pages on top of > > > RAM", > > > it is no

Re: [Qemu-devel] [PATCH v10] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
On Nov 30, 2015, at 11:26 AM, Eric Blake wrote: > On 11/27/2015 02:49 PM, Programmingkid wrote: >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be off limits to QEMU. If an issue is detected, >> a message is display

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/30/2015 09:38 AM, Programmingkid wrote: >> +/* if a working partition on the device was not found */ >> +if (partition_found == false) { >> +error_setg(errp, "Error: Failed to find a working partition on " >> +

[Qemu-devel] [PATCH for-2.5 v4 3/4] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau The prepare callback needs to be implemented with glib < 2.36, quoting glib documentation: "Since 2.36 this may be NULL, in which case the effect is as if the function always returns FALSE with a timeout of -1." Signed-off-by: Marc-André Lureau --- tests/vhost-user-test

[Qemu-devel] [PATCH for-2.5 v4 2/4] vhost-user-test: use unix port for migration

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau TCP port 1234 may be used by another process concurrently. Instead use a temporary unix socket. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-

  1   2   3   >