On 11/26/2015 07:48 PM, Peter Xu wrote: > This patch only adds the interfaces, but not implements them.
s/not implements/does not implement/
> "detach" parameter is made optional, to make sure that all the old
> dump-guest-memory requests will still be able to work.
>
> Signed-off-by: Peter Xu <pet...@redhat.com>
> ---
In addition to Fam's comments,
> +++ b/qapi-schema.json
> @@ -2115,6 +2115,9 @@
> # 2. fd: the protocol starts with "fd:", and the following string
> # is the fd's name.
> #
> +# @detach: #optional if true, QMP will return immediately rather than
> +# waiting dump to be finished (since 2.6).
s/waiting/waiting for the/
s/be finished/finish/
> +++ b/qmp-commands.hx
> @@ -840,8 +840,8 @@ EQMP
>
> {
> .name = "dump-guest-memory",
> - .args_type = "paging:b,protocol:s,begin:i?,end:i?,format:s?",
> - .params = "-p protocol [begin] [length] [format]",
> + .args_type =
> "paging:b,protocol:s,detach:b?,begin:i?,end:i?,format:s?",
> + .params = "-p protocol [-d] [begin] [length] [format]",
> .help = "dump guest memory to file",
> .mhandler.cmd_new = qmp_marshal_dump_guest_memory,
> },
> @@ -857,6 +857,8 @@ Arguments:
> - "paging": do paging to get guest's memory mapping (json-bool)
> - "protocol": destination file(started with "file:") or destination file
> descriptor (started with "fd:") (json-string)
> +- "detach": if specificed, command will return immediately, without waiting
s/specificed/specified/
> + for dump to be finished (json-bool)
s/dump to be finished/the dump to finish/
> - "begin": the starting physical address. It's optional, and should be
> specified
> with length together (json-int)
> - "length": the memory size, in bytes. It's optional, and should be specified
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
