Cao jin writes:
> On 11/27/2015 10:22 PM, Markus Armbruster wrote:
>> Cao jin writes:
>>
>>> Hi, Markus
>>>
>>> On 11/24/2015 06:08 PM, Markus Armbruster wrote:
> [...]
>>>
>>> and this will cover to output to the monitor, right?
>>
>> The device still implements the old PCIDeviceClass.init() in
Backends could provide a packet whose length is greater than buffer
size. Check for this and truncate the packet to avoid rx buffer
overflow in this case.
Cc: Prasad J Pandit
Cc: qemu-sta...@nongnu.org
Signed-off-by: Jason Wang
---
hw/net/pcnet.c | 6 ++
1 file changed, 6 insertions(+)
dif
From: Prasad J Pandit
In loopback mode, pcnet_receive routine appends CRC code to the
receive buffer. If the data size given is same as the buffer size,
the appended CRC code overwrites 4 bytes after s->buffer. Added a
check to avoid that.
Reported by: Qinghao Tang
Cc: qemu-sta...@nongnu.org
Si
On 11/20/2015 11:54 PM, Bharata B Rao wrote:
From: Gu Zheng
In order to deal well with the kvm vcpus (which can not be removed without any
protection), we do not close KVM vcpu fd, just record and mark it as stopped
into a list, so that we can reuse it for the appending cpu hot-add request if
p
Hello!
> > +/* Our two regions are always adjacent, therefore we now combine them
> > + * into a single one in order to make our users' life easier.
> > + */
> > +memory_region_init(&s->iomem_main, OBJECT(s), "gicv3_its", ITS_SIZE);
> > +memory_region_add_subregion(&s->iomem_m
On 11/26/2015 11:56 AM, Alexander Duyck wrote:
> I am not saying you cannot modify the drivers, however what you are
doing is far too invasive. Do you seriously plan on modifying all of
the PCI device drivers out there in order to allow any device that
might be direct assigned to a port to suppo
Hello!
> > +route->u.msi.devid = pci_requester_id(dev);
> > +}
>
> Is there anything that would go wrong if we just always set
> the u.msi.devid and the VALID_DEVID flag? (ie do we need the
> kvm_arm_msi_use_devid bool?)
Current kernels always make sure that flags == 0, or they sim
On 11/30/2015 08:58 AM, Jason Wang wrote:
On 11/27/2015 07:42 PM, Denis V. Lunev wrote:
On 11/27/2015 09:50 AM, Denis V. Lunev wrote:
On 11/27/2015 09:48 AM, Denis V. Lunev wrote:
e1000 driver in Win2k12 is really well rotten. It 100% hangs on
shutdown
of UP VM under flood ping. The guest che
> -Original Message-
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Sunday, November 29, 2015 2:21 AM
> To: qemu-devel@nongnu.org; j...@tribudubois.net
> Cc: Sai Pavan Boddu; qemu-bl...@nongnu.org; Peter Crosthwaite
> Subject: [PATCH v1 1/2] sd: sdhci: Delete over-z
On 11/27/2015 07:42 PM, Denis V. Lunev wrote:
> On 11/27/2015 09:50 AM, Denis V. Lunev wrote:
>> On 11/27/2015 09:48 AM, Denis V. Lunev wrote:
>>> e1000 driver in Win2k12 is really well rotten. It 100% hangs on
>>> shutdown
>>> of UP VM under flood ping. The guest checks card state and reinjects
On Windows, getpid() always returns an int value, but pid_t (which is
expected by the format string) is either a 32 bit or a 64 bit value.
Without a type cast (or a modified format string), the compiler prints
a warning when building for 64 bit Windows and the resulting trace_file_name
will includ
QEMU uses threads / coroutines, therefore support for thread local storage
and thread safe libraries (-D_MT) must be enabled by using -mthreads.
Signed-off-by: Stefan Weil
---
configure | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b/configure
index 979bc55..67801b0 100755
---
getpagesize on Linux returns an int. Fix QEMU's implementation for
Windows to return an int (instead of size_t), too.
This fixes a compiler warning which was introduced recently
(commit 093e3c42).
Signed-off-by: Stefan Weil
---
include/sysemu/os-win32.h | 2 +-
util/oslib-win32.c| 2 +-
The following changes since commit 714487515dbe0c65d5904251e796cd3a5b3579fb:
Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into
staging (2015-11-27 10:44:42 +)
are available in the git repository at:
git://qemu.weilnetz.de/qemu.git tags/pull-wxx-20151130
for you
On 11/30/2015 11:10 AM, Wen Congyang wrote:
On 11/27/2015 08:27 PM, Zhang Chen wrote:
From: zhangchen
Colo-proxy is a plugin of qemu netfilter
like filter-buffer and dump
Signed-off-by: zhangchen
---
net/Makefile.objs | 1 +
net/colo-proxy.c | 139
On 11/30/2015 05:07 AM, Shmulik Ladkani wrote:
> Hi,
>
> On Wed, 25 Nov 2015 16:24:39 +0800 Jason Wang wrote:
> @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class,
> void *data)
> c->class_id = PCI_CLASS_NETWORK_ETHERNET;
> c->subsystem_vendor_id =
Hi QEMU programmers,
While doing some experimental work on QEMU that has involved adding a lot of
new log messages (using qemu_log_mask()), I've discovered that under some
conditions a lot of my log messages go missing.
I've tracked the issue down to qemu_logfile being left at the default (stderr
On 11/30/2015 10:50 AM, Wen Congyang wrote:
On 11/27/2015 08:27 PM, Zhang Chen wrote:
From: zhangchen
add colo-proxy in vl.c and qemu-options.hx
Signed-off-by: zhangchen
---
qemu-options.hx | 4
vl.c| 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a
On 11/28/2015 11:17 AM, Hailiang Zhang wrote:
On 2015/11/27 20:27, Zhang Chen wrote:
From: zhangchen
add primary and secondary handler
Signed-off-by: zhangchen
---
net/colo-proxy.c | 105
+--
1 file changed, 103 insertions(+), 2 dele
On 11/29/15 13:37, Marcel Apfelbaum wrote:
> On 11/26/2015 07:01 PM, Laszlo Ersek wrote:
>> Hello Marcel,
>>
>
> [...] if you have ACPI table dumps from within an i440fx
>> SeaBIOS Linux guest, both from before and after your QEMU patches, and
>> those dumps are identical, then that's good evidenc
Hi, all,
I met one problem when trying to add a new public function in dump.h
named "dump_state_get_global" and using it in hmp.c. What I got is
something like:
In file included from /root/git/qemu/hmp.c:35:0:
/root/git/qemu/include/sysemu/dump.h:26:34: error: attempt to use poisoned
"TARGET_PAG
On Tue, 11/24 19:00, Paolo Bonzini wrote:
> Build the addresses and s/g lists on the stack, and then copy them
> to a VirtQueueElement that is just as big as required to contain this
> particular s/g list. The cost of the copy is minimal compared to that
> of a large malloc.
>
> When virtqueue_ma
On 11/27/2015 08:27 PM, Zhang Chen wrote:
> From: zhangchen
>
> Colo-proxy is a plugin of qemu netfilter
> like filter-buffer and dump
>
> Signed-off-by: zhangchen
> ---
> net/Makefile.objs | 1 +
> net/colo-proxy.c | 139
> ++
> net/colo
On Tue, 11/24 19:00, Paolo Bonzini wrote:
> @@ -436,10 +454,11 @@ static void control_out(VirtIODevice *vdev, VirtQueue
> *vq)
> buf = g_malloc(cur_len);
> len = cur_len;
> }
> -iov_to_buf(elem.out_sg, elem.out_num, 0, buf, cur_len);
> +iov_to_buf
On 11/27/2015 08:27 PM, Zhang Chen wrote:
> From: zhangchen
>
> add colo-proxy in vl.c and qemu-options.hx
>
> Signed-off-by: zhangchen
> ---
> qemu-options.hx | 4
> vl.c| 3 ++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-option
On Tue, Nov 17, 2015 at 10:43:36AM +0100, Paolo Bonzini wrote:
>
>
> On 16/11/2015 15:57, Peter Maydell wrote:
> > The taihu_cpld_writel() function had an obvious typo that meant that
> > if it was ever called it would go into an infinite recursion. Newer
> > versions of clang will detect and war
On 11/28/2015 11:02 AM, Hailiang Zhang wrote:
On 2015/11/27 20:27, Zhang Chen wrote:
From: zhangchen
Secondary setup socket server for colo-forward
primary setup connect to secondary for colo-forward
add data structure will be uesed
Signed-off-by: zhangchen
---
net/colo-proxy.c | 87
+++
On Mon, 11/30 10:27, Fam Zheng wrote:
> On Tue, 11/24 19:00, Paolo Bonzini wrote:
> OK, and I think handle_9p_output no longer needs to check the returned
> pointer.
Yes it's removed in patch 3, good.
Fam
On Tue, 11/24 19:00, Paolo Bonzini wrote:
> Prepare for moving the allocation to virtqueue_pop.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/9pfs/virtio-9p-device.c | 7 +--
> hw/9pfs/virtio-9p.c| 10 +++---
> hw/9pfs/virtio-9p.h| 2 --
> 3 files changed, 4 insertions(+)
On 11/28/2015 10:46 AM, Hailiang Zhang wrote:
On 2015/11/27 20:27, Zhang Chen wrote:
From: zhangchen
Colo-proxy is a plugin of qemu netfilter
like filter-buffer and dump
Signed-off-by: zhangchen
---
net/Makefile.objs | 1 +
net/colo-proxy.c | 139
On Sat, 11/28 13:51, Peter Xu wrote:
> On Fri, Nov 27, 2015 at 01:14:25PM +0800, Fam Zheng wrote:
> > On Fri, 11/27 10:48, Peter Xu wrote:
>
> [snip]
>
> >
> > This patch doesn't handle the incoming migration case, i.e. when QEMU is
> > started with "-incoming", or "-incoming defer". Dump can go
On 11/24/2015 05:25 PM, zhanghailiang wrote:
We add each netdev a default filter-buffer, which will be used for COLO
or Micro-checkpoint to buffer VM's packets. The name of default filter-buffer
is 'nop'.
For the default filter-buffer, it will not buffer any packets in default.
So it has no side
Le 27/11/2015 21:26, Peter Crosthwaite a écrit :
On Fri, Nov 27, 2015 at 11:54 AM, Jean-Christophe DUBOIS
wrote:
Le 27/11/2015 03:39, Peter Crosthwaite a écrit :
On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois
wrote:
Signed-off-by: Jean-Christophe Dubois
This seems to slow down bo
Hello Peter,
Le 28/11/2015 21:50, Peter Crosthwaite a écrit :
Add the two SD card controllers as the generic sysbus SDHCI device.
Tested as sucessfully working with Linux 4.2. using the SD card for the
root file system.
I guess the SDHCI device present in Qemu is (surprisingly) close enough
t
I have experienced this behavior (main-loop: WARNING: I/O thread spun
for 1000 iterations) and the resulting degraded performance. The VM
becomes very unresponsive but eventually recovers. My setup:
Ubuntu 15.10 | qemu-system-x86_64 --version QEMU emulator version 2.3.0
(Debian 1:2.3+dfsg-5ubu
Hi,
On Wed, 25 Nov 2015 16:24:39 +0800 Jason Wang wrote:
> >>> @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class,
> >>> void *data)
> >>> c->class_id = PCI_CLASS_NETWORK_ETHERNET;
> >>> c->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE;
> >>> c->subsystem_id = PC
On Sun, Nov 29, 2015 at 5:12 AM, Krzeminski, Marcin (Nokia -
PL/Wroclaw) wrote:
>
>
>> -Original Message-
>> From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
>> Sent: Saturday, November 28, 2015 7:50 PM
>> To: Krzeminski, Marcin (Nokia - PL/Wroclaw)
>> Cc: qemu-devel@nongnu.
Hi Marcel,
Marcel Apfelbaum writes:
...
>
> Maybe is too late, but this contradicts QEMU usage, as I understand
Why late ? We can always revert it :)
> object_property_get_* should be used when we don't know object's type.
My understanding is that it's not mandatory to use it only when type
is u
On 11/27/2015 08:01 PM, Eduardo Habkost wrote:
Remove the redundant 'alias = NULL' and 'is_default = 0' lines
from older machine-types. pc_*_2_4_machine_options() already
clear those fields, so they don't need to be cleared by
pc_*_2_3_machine_options().
Signed-off-by: Eduardo Habkost
---
hw/
On 11/27/2015 08:01 PM, Eduardo Habkost wrote:
Add pc-i440fx-2.6 and pc-q35-2.6 machine classes.
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Add missing backslash to PC_COMPAT_2_4
---
hw/i386/pc_piix.c| 16 +---
hw/i386/pc_q35.c | 13 +++--
include/hw/
Hello Maintainers:
Please help check these patches when you have time.
If it is necessary to send patch v3 for it, please let me know.
Thanks.
On 11/17/15 03:37, Chen Gang wrote:
> From d0f0e0a78e81f9589d25b0a2b4ad826d6e55257d Mon Sep 17 00:00:00 2001
> From: Chen Gang
> Date: Tue, 17 Nov 201
Current text_console_update() writes totally broken color attributes
to console_write_ch(). The format now is writing,
[WRONG]
bold << 21 | fg << 12 | bg << 8 | char
fg == 3bits curses color number
bg == 3bits curses color number
I can't see this format is where come from.
> -Original Message-
> From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Saturday, November 28, 2015 7:50 PM
> To: Krzeminski, Marcin (Nokia - PL/Wroclaw)
> Cc: qemu-devel@nongnu.org; g...@xilinx.com; Sai Pavan Boddu
> Subject: Re: [Qemu-devel] [PATCH] m25p80.c Added
On 11/26/2015 07:01 PM, Laszlo Ersek wrote:
Hello Marcel,
[...] if you have ACPI table dumps from within an i440fx
SeaBIOS Linux guest, both from before and after your QEMU patches, and
those dumps are identical, then that's good evidence against
regressions. (I tend to do such acpidump-based
On 11/19/2015 03:36 PM, Michael S. Tsirkin wrote:
From: Bandan Das
The helper function machine_iommu() isn't necesary. We can
directly check for the property.
Signed-off-by: Bandan Das
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Bandan Das
---
include
Peter Maydell wrote:
> On 27 November 2015 at 19:16, Stefan Weil wrote:
>> Yes, that's correct. I just did a short test and replaced "printf"
>> by "gnu_printf" in disas/libvixl/utils.h: no more warnings when MinGW
>> compiles disas/libvixl/a64/disasm-a64.cc.
>>
>> I think we can wait for a new v
19.11.2015 15:29, Markus Armbruster wrote:
> "Please keep this list in alphabetical order" has been more honoured
> in the breach than in the observance. Clean up.
>
> While there, drop a redundant struct declaration.
Applied to -trivial, thank you!
/mjt
Applied to -trivial, thank you!
/mjt
05.11.2015 10:39, Cao jin wrote:
> it don`t has "GSList *interfaces" anymore
Andreas, should this be applied? It's been on the list for long already,
and you said I shouldn't apply qom patches...
Thanks,
/mjt
> Signed-off-by: Cao jin
> ---
> include/qom/object.h | 3 ---
> 1 file changed, 3
06.11.2015 18:34, Paolo Bonzini wrote:
> The GT64xxx's internal registers can be placed above the first 4 GiB
> in the address space, but not above the first 64 GiB. Correctly cast
> the register to a 64-bit integer, and mask away bits above bit 35.
Applied to -trivial, thank you!
/mjt
12.11.2015 17:04, Rodrigo Rebello wrote:
> The check for stack-protector support consisted in compiling and linking
> the test program below (output by function write_c_skeleton()) with the
> compiler flag -fstack-protector-strong first and then with
> -fstack-protector-all if the first one failed
13.11.2015 20:45, Daniel P. Berrange wrote:
> In qcrypto_tls_creds_get_path() coverity complains that
> we are checking '*creds' for NULL, despite having
> dereferenced it previously. This is harmless bug due
> to fact that the trace call was too early. Moving it
> after the cleanup gets the desire
24.11.2015 17:55, Peter Maydell wrote:
> Currently if the user's compiler works for creating .o files but
> their linker is broken such that compiling an executable from a
> C file does not work, we will report a misleading error message
> about the compiler not supporting __thread (since that happ
28.11.2015 18:13, Paolo Bonzini wrote:
> On 27/11/2015 18:57, Paolo Bonzini wrote:
>> See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For
>> historical
>> reasons these do not use sizeof, and Coverity caught a mistake in
>> EVT_ENCRYPT_CHANGE_SIZE.
>>
>> Note other sizes that seem
27.11.2015 15:08, Paolo Bonzini wrote:
> In the case of a 4-byte length, shifting a value by 24 may cause
> an unintended sign extension when converting from int to size_t.
> Use a uint32_t variable instead.
Applied to -trivial, thank you!
/mjt
26.11.2015 00:03, John Snow wrote:
> Trivial: this array should be allocated to have ID_MAX entries always.
> Otherwise if someone were to forget to expand this table, the assertion
> in the id generator won't actually trigger; it will read junk data.
Applied to -trivial as a bugfix, with a trivia
On 11/27/2015 07:04 PM, Igor Mammedov wrote:
On Thu, 26 Nov 2015 20:35:59 +0200
Marcel Apfelbaum wrote:
On 11/26/2015 07:01 PM, Laszlo Ersek wrote:
Hello Marcel,
On 11/26/15 17:00, Marcel Apfelbaum wrote:
Note:
I took the liberty to CC all the reviewers that took their time
and had a look o
On 25/11/2015 19:14, Andrew Baumann wrote:
> How does this work out with object_property_add_alias? It can fail
> and returns an error, so it should be called from realize, but it
> adds a new property on the object, so the property won't be useful if
> it can only be set after realize has added
On 11/27/2015 07:28 PM, Eduardo Habkost wrote:
On Thu, Nov 26, 2015 at 06:00:28PM +0200, Marcel Apfelbaum wrote:
Add bus property to PC machines and use it when looking
for primary PCI root bus (bus 0).
Signed-off-by: Marcel Apfelbaum
I can't pretend I have reviewed the q35 part, but the cha
From: Shannon Zhao
If GIC ITS is supported, add description in ACPI MADT table, then guest
could use ITS when booting with ACPI.
Signed-off-by: Shannon Zhao
---
hw/arm/virt-acpi-build.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi
From: Shannon Zhao
These two patches add ITS description in ACPI MADT table. It bases on
Pavel Fedin's ITS series[1].
[1]https://www.mail-archive.com/qemu-devel@nongnu.org/msg337421.html
Shannon Zhao (2):
ACPI: Add GIC Interrupt Translation Service Structure definition
ARM: Virt: ACPI: Add
From: Shannon Zhao
ACPI Spec 6.0 introduces GIC Interrupt Translation Service Structure.
Here we add the definition of the Structure.
Signed-off-by: Shannon Zhao
---
include/hw/acpi/acpi-defs.h | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/hw/acpi/ac
On 2015/11/24 18:13, Pavel Fedin wrote:
> +static const VMStateDescription vmstate_its = {
> +.name = "arm_gicv3_its",
> +.pre_save = gicv3_its_pre_save,
> +.post_load = gicv3_its_post_load,
> +.fields = (VMStateField[]) {
> +VMSTATE_UINT32(ctlr, GICv3ITSState),
> +
63 matches
Mail list logo
