Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-27 Thread Cao jin
On 11/27/2015 10:22 PM, Markus Armbruster wrote: Cao jin writes: Hi, Markus On 11/24/2015 06:08 PM, Markus Armbruster wrote: [...] and this will cover to output to the monitor, right? The device still implements the old PCIDeviceClass.init() instead of the new .realize(). All devices n

Re: [Qemu-devel] [PATCH COLO-Frame v11 38/39] colo: Use default buffer-filter to buffer and release packets

2015-11-27 Thread Hailiang Zhang
On 2015/11/27 20:51, Yang Hongyang wrote: On 2015年11月24日 17:25, zhanghailiang wrote: Enable default filter to buffer packets and release the packets after a checkpoint. Signed-off-by: zhanghailiang Cc: Jason Wang Cc: Yang Hongyang --- v11: - Use new helper functions to buffer and release p

Re: [Qemu-devel] [PATCH COLO-Frame v11 34/39] net/filter-buffer: Add default filter-buffer for each netdev

2015-11-27 Thread Hailiang Zhang
On 2015/11/27 19:39, Yang Hongyang wrote: On 2015年11月24日 17:25, zhanghailiang wrote: We add each netdev a default filter-buffer, which will be used for COLO or Micro-checkpoint to buffer VM's packets. The name of default filter-buffer is 'nop'. For the default filter-buffer, it will not buffer a

Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

2015-11-27 Thread Peter Xu
On Fri, Nov 27, 2015 at 01:14:25PM +0800, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: [snip] > > This patch doesn't handle the incoming migration case, i.e. when QEMU is > started with "-incoming", or "-incoming defer". Dump can go wrong when > incoming > migration happens at the sa

Re: [Qemu-devel] [RFC PATCH v3 5/5] arm/virt: Add ITS to the virt board

2015-11-27 Thread Shannon Zhao
On 2015/11/28 0:18, Peter Maydell wrote: > On 24 November 2015 at 10:13, Pavel Fedin wrote: >> > If supported by the configuration, ITS will be added automatically. >> > >> > This patch also renames v2m_phandle to msi_phandle because it's now used >> > by both MSI implementations. >> > >> > Sign

Re: [Qemu-devel] [RFC PATCH 5/9] net/colo-proxy: add colo packet handler

2015-11-27 Thread Hailiang Zhang
On 2015/11/27 20:27, Zhang Chen wrote: From: zhangchen add primary and secondary handler Signed-off-by: zhangchen --- net/colo-proxy.c | 105 +-- 1 file changed, 103 insertions(+), 2 deletions(-) diff --git a/net/colo-proxy.c b/net/colo-

Re: [Qemu-devel] [PATCH v3 8/8] hw/arm/virt: Add gpio-keys node for Poweroff using DT

2015-11-27 Thread Shannon Zhao
On 2015/11/28 1:16, Peter Maydell wrote: > On 16 November 2015 at 13:23, wrote: >> From: Shannon Zhao >> >> Add a gpio-keys node. This is used for Poweroff for the systems which >> use DT not ACPI. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao >> Tested-by: Wei Huang >> -

[Qemu-devel] [PATCH v2 2/2] hmp: add support for system_suspend

2015-11-27 Thread Chen Hanxiao
From: Chen Hanxiao This patch add support for system_suspend hmp command. Signed-off-by: Chen Hanxiao --- hmp-commands.hx | 14 ++ hmp.c | 5 + hmp.h | 1 + 3 files changed, 20 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index bb52e4d..0e

Re: [Qemu-devel] [RFC PATCH 4/9] colo-proxy: add colo-proxy setup work

2015-11-27 Thread Hailiang Zhang
On 2015/11/27 20:27, Zhang Chen wrote: From: zhangchen Secondary setup socket server for colo-forward primary setup connect to secondary for colo-forward add data structure will be uesed Signed-off-by: zhangchen --- net/colo-proxy.c | 87 +

[Qemu-devel] [PATCH v2 1/2] qmp: add support for system_suspend

2015-11-27 Thread Chen Hanxiao
From: Chen Hanxiao This patch add support for system_suspend qmp command. Signed-off-by: Chen Hanxiao --- qapi-schema.json | 9 + qmp-commands.hx | 21 + qmp.c| 5 + 3 files changed, 35 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.js

[Qemu-devel] [PATCH v2 0/2] qmp/hmp: add support for system_suspend

2015-11-27 Thread Chen Hanxiao
From: Chen Hanxiao Chen Hanxiao (2): qmp: add support for system_suspend hmp: add support for system_suspend hmp-commands.hx | 14 ++ hmp.c| 5 + hmp.h| 1 + qapi-schema.json | 9 + qmp-commands.hx | 21 + qmp.c

Re: [Qemu-devel] [RFC PATCH 3/9] colo-proxy: add colo-proxy framework

2015-11-27 Thread Hailiang Zhang
On 2015/11/27 20:27, Zhang Chen wrote: From: zhangchen Colo-proxy is a plugin of qemu netfilter like filter-buffer and dump Signed-off-by: zhangchen --- net/Makefile.objs | 1 + net/colo-proxy.c | 139 ++ net/colo-proxy.h | 63 +

Re: [Qemu-devel] [PATCH] qmp/hmp: add support for system_suspend

2015-11-27 Thread Chen Hanxiao
On 11/28/2015 01:53 AM, Eric Blake wrote: On 11/27/2015 08:15 AM, Chen Hanxiao wrote: From: Chen Hanxiao This patch add support for system_suspend command. Signed-off-by: Chen Hanxiao --- hmp-commands.hx | 14 ++ hmp.c | 5 + hmp.h | 1 + qmp.c

Re: [Qemu-devel] [PATCH 1/2] hw/ppc/spapr: Create pseries-2.6 machine

2015-11-27 Thread Thomas Huth
On 27/11/15 18:56, Eduardo Habkost wrote: > On Fri, Nov 27, 2015 at 06:18:30PM +0100, Thomas Huth wrote: >> On 27/11/15 10:55, Alexander Graf wrote: >>> >>> On 27.11.15 10:32, Thomas Huth wrote: Add a new pseries-2.6 machine class version to make sure we can keep the old types compatible

Re: [Qemu-devel] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-27 Thread Peter Crosthwaite
On Fri, Nov 27, 2015 at 2:05 PM, Jean-Christophe DUBOIS wrote: > Le 27/11/2015 21:26, Peter Crosthwaite a écrit : >> >> On Fri, Nov 27, 2015 at 11:54 AM, Jean-Christophe DUBOIS >> wrote: >>> >>> Le 27/11/2015 03:39, Peter Crosthwaite a écrit : >>> >>> On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christ

Re: [Qemu-devel] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-27 Thread Jean-Christophe DUBOIS
Le 27/11/2015 21:26, Peter Crosthwaite a écrit : On Fri, Nov 27, 2015 at 11:54 AM, Jean-Christophe DUBOIS wrote: Le 27/11/2015 03:39, Peter Crosthwaite a écrit : On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: Signed-off-by: Jean-Christophe Dubois This seems to slow down bo

[Qemu-devel] [PATCH v10] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-27 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle --- Fixed some spacing issues. R

Re: [Qemu-devel] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-27 Thread Guenter Roeck
On 11/27/2015 12:26 PM, Peter Crosthwaite wrote: On Fri, Nov 27, 2015 at 11:54 AM, Jean-Christophe DUBOIS wrote: Le 27/11/2015 03:39, Peter Crosthwaite a écrit : On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: Signed-off-by: Jean-Christophe Dubois This seems to slow down bo

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-27 Thread Programmingkid
On Nov 25, 2015, at 11:29 PM, Eric Blake wrote: > On 11/25/2015 09:23 PM, Eric Blake wrote: > >>> +static kern_return_t FindEjectableOpticalMedia(io_iterator_t >>> *mediaIterator, >>> +char >>> *mediaType) >> >> Unusual indentati

Re: [Qemu-devel] [PATCH v2 20/21] qemu-iotests: Test cache mode option inheritance

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > This is doing a more complete test on setting cache modes both while > opening an image (i.e. in a -drive command line) and in reopen > situations. It checks that reopen can specify options for child nodes > and that cache modes are correctly inherited from

Re: [Qemu-devel] MinGW build

2015-11-27 Thread Peter Maydell
On 27 November 2015 at 19:16, Stefan Weil wrote: > Yes, that's correct. I just did a short test and replaced "printf" > by "gnu_printf" in disas/libvixl/utils.h: no more warnings when MinGW > compiles disas/libvixl/a64/disasm-a64.cc. > > I think we can wait for a new version of libvixl which inclu

Re: [Qemu-devel] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-27 Thread Peter Crosthwaite
On Fri, Nov 27, 2015 at 11:54 AM, Jean-Christophe DUBOIS wrote: > Le 27/11/2015 03:39, Peter Crosthwaite a écrit : > > On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois > wrote: > > Signed-off-by: Jean-Christophe Dubois > > This seems to slow down boot performance for i.MX25 Linux. Admitt

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.5.0-rc2 is now available

2015-11-27 Thread Denis V. Lunev
On 11/27/2015 10:47 PM, Michael Roth wrote: Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 2.5 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/d

Re: [Qemu-devel] [PATCH v2 18/21] blkdebug: Enable reopen

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > Just reopening the children (as block.c does now) is enough. > > Signed-off-by: Kevin Wolf > --- > block/blkdebug.c | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 17/21] block: Move cache options into options QDict

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > This adds the cache mode options to the QDict, so that they can be > specified for child nodes (e.g. backing.cache.direct=off). > > The cache modes are not removed from the flags at this point; instead, > options and flags are kept in sync. If the user spec

Re: [Qemu-devel] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-27 Thread Jean-Christophe DUBOIS
Le 27/11/2015 03:39, Peter Crosthwaite a écrit : On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: Signed-off-by: Jean-Christophe Dubois This seems to slow down boot performance for i.MX25 Linux. Admittedly, the issue looks to be in timeout code for an unmodelled periph (NAND):

[Qemu-devel] [ANNOUNCE] QEMU 2.5.0-rc2 is now available

2015-11-27 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 2.5 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.5.0-rc2.tar.bz2 You can help im

Re: [Qemu-devel] [RESEND RFC 4/6] device_tree: introduce qemu_fdt_getprop_optional

2015-11-27 Thread Peter Crosthwaite
On Thu, Nov 19, 2015 at 7:22 AM, Eric Auger wrote: > Current qemu_fdt_getprop exits if the property is not found. It is > sometimes needed to read an optional property, in which case we do > not wish to exit but simply returns a null value. > > This is what this new qemu_fdt_getprop_optional funct

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-27 Thread Programmingkid
On Nov 25, 2015, at 11:23 PM, Eric Blake wrote: > On 11/25/2015 09:10 PM, Programmingkid wrote: >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be off limits to QEMU. If an issue is detected, >> a message is display

Re: [Qemu-devel] MinGW build

2015-11-27 Thread Stefan Weil
Am 27.11.2015 um 19:49 schrieb Peter Maydell: > On 28 November 2014 at 07:14, Stefan Weil wrote: >> The libvixl code is correct, but the C++ compiler would need to be >> fixed. Here are some examples: >> >> disas/libvixl/a64/disasm-a64.cc:1340:57: warning: unknown conversion >> type character ‘l’

Re: [Qemu-devel] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > Creating an empty drive while specifying 'format' doesn't make sense. > The specified format driver would simply be ignored. > > Make a set 'format' option an indication that a non-empty drive should > be created. This makes 'format' consistent with 'driver

Re: [Qemu-devel] MinGW build

2015-11-27 Thread Peter Maydell
On 28 November 2014 at 07:14, Stefan Weil wrote: > The libvixl code is correct, but the C++ compiler would need to be > fixed. Here are some examples: > > disas/libvixl/a64/disasm-a64.cc:1340:57: warning: unknown conversion > type character ‘l’ in format [-Wformat] > disas/libvixl/a64/disasm-a64.c

Re: [Qemu-devel] [PATCH v2 13/21] block: Introduce bs->explicit_options

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > bs->options doesn't only contain options that the user explicitly > requested, but also option that were derived from flags, the filename or > inherited from the parent node. > > For reopen, it is important to know the difference because reopening the > par

Re: [Qemu-devel] [PATCH v2 12/21] block: Split out parse_json_protocol()

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > The next patch distinguishes options that were explicitly set and > options that were derived. bdrv_fill_option() added options of both > types: Options given by json: syntax should be counted as explicit, but > the rest is derived. > > In preparation for t

Re: [Qemu-devel] [PATCH v2 11/21] block: Add infrastructure for option inheritance

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > Options are not actually inherited from the parent node yet, but this > commit lays the grounds for doing so. > > Signed-off-by: Kevin Wolf > --- > block.c | 52 > --- > include/block/block_in

Re: [Qemu-devel] [PATCH v1 2/7] drivers/hv: Move struct hv_message into UAPI Hyper-V x86 header

2015-11-27 Thread KY Srinivasan
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, November 27, 2015 1:35 AM > To: Andrey Smetanin ; k...@vger.kernel.org > Cc: Gleb Natapov ; KY Srinivasan ; > Haiyang Zhang ; Vitaly Kuznetsov > ; Roman Kagan ; Denis V

Re: [Qemu-devel] [PATCH 8/8] block: Implement 'block_disconnect' HMP command

2015-11-27 Thread Eric Blake
On 11/27/2015 07:59 AM, Hannes Reinecke wrote: > Implement a 'block_disconnect' HMP command to simulate a device > communication / link failure. > > Signed-off-by: Hannes Reinecke > --- > +++ b/qapi/block-core.json > @@ -754,6 +754,27 @@ > 'size': 'int' }}

Re: [Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options()

2015-11-27 Thread Max Reitz
On 27.11.2015 18:58, Max Reitz wrote: > On 23.11.2015 16:59, Kevin Wolf wrote: >> Some drivers have nested options (e.g. blkdebug rule arrays), which >> don't belong to a child node and shouldn't be removed. Don't remove all >> options with "." in their name, but check for the complete prefixes of

[Qemu-devel] [for-2.6 PATCH v2 1/2] pc: Remove redundant code from pc-*-2.3 machine classes

2015-11-27 Thread Eduardo Habkost
Remove the redundant 'alias = NULL' and 'is_default = 0' lines from older machine-types. pc_*_2_4_machine_options() already clear those fields, so they don't need to be cleared by pc_*_2_3_machine_options(). Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 2 -- hw/i386/pc_q35.c | 1 - 2

[Qemu-devel] [for-2.6 PATCH v2 2/2] pc: Add pc-*-2.6 machine classes

2015-11-27 Thread Eduardo Habkost
Add pc-i440fx-2.6 and pc-q35-2.6 machine classes. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Add missing backslash to PC_COMPAT_2_4 --- hw/i386/pc_piix.c| 16 +--- hw/i386/pc_q35.c | 13 +++-- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 4

[Qemu-devel] [for-2.6 PATCH v2 0/2] pc: Add pc-*-2.6 machine classes

2015-11-27 Thread Eduardo Habkost
I am sending this earlier so it can be queued and used as base for patches that need to add compat code to the pc-2.5 machine types. Changes v1 -> v2: * Typo fix that I forgot to commit before submitting v1 Eduardo Habkost (2): pc: Remove redundant code from pc-*-2.3 machine classes pc: Add p

Re: [Qemu-devel] [PATCH v1 1/7] drivers/hv: Move HV_SYNIC_STIMER_COUNT into Hyper-V UAPI x86 header

2015-11-27 Thread KY Srinivasan
> -Original Message- > From: Andrey Smetanin [mailto:asmeta...@virtuozzo.com] > Sent: Wednesday, November 25, 2015 7:20 AM > To: k...@vger.kernel.org > Cc: Gleb Natapov ; Paolo Bonzini > ; KY Srinivasan ; Haiyang > Zhang ; Vitaly Kuznetsov > ; Roman Kagan ; Denis V. > Lunev ; qemu-devel@n

Re: [Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options()

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > Some drivers have nested options (e.g. blkdebug rule arrays), which > don't belong to a child node and shouldn't be removed. Don't remove all > options with "." in their name, but check for the complete prefixes of > actually existing child nodes. > > Signe

Re: [Qemu-devel] [for-2.6 PATCH 2/2] pc: Add pc-*-2.6 machine classes

2015-11-27 Thread Eduardo Habkost
On Fri, Nov 27, 2015 at 03:11:50PM -0200, Eduardo Habkost wrote: > Add pc-i440fx-2.6 and pc-q35-2.6 machine classes. > > Signed-off-by: Eduardo Habkost Oops, this is broken. I forgot to commit a build fix, please ignore. I will submit v2. -- Eduardo

[Qemu-devel] [PATCH v2] bt: check struct sizes

2015-11-27 Thread Paolo Bonzini
See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical reasons these do not use sizeof, and Coverity caught a mistake in EVT_ENCRYPT_CHANGE_SIZE. Note other sizes that seem wrong or inconsistent with the kernel header. Signed-off-by: Paolo Bonzini --- include/hw/bt.h | 1

Re: [Qemu-devel] [PATCH 1/2] hw/ppc/spapr: Create pseries-2.6 machine

2015-11-27 Thread Eduardo Habkost
On Fri, Nov 27, 2015 at 06:18:30PM +0100, Thomas Huth wrote: > On 27/11/15 10:55, Alexander Graf wrote: > > > > On 27.11.15 10:32, Thomas Huth wrote: > >> Add a new pseries-2.6 machine class version to make sure we can > >> keep the old types compatible to previous versions of QEMU in > >> later p

Re: [Qemu-devel] [PATCH] qmp/hmp: add support for system_suspend

2015-11-27 Thread Eric Blake
On 11/27/2015 08:15 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add support for system_suspend command. > > Signed-off-by: Chen Hanxiao > --- > hmp-commands.hx | 14 ++ > hmp.c | 5 + > hmp.h | 1 + > qmp.c | 5 + > 4 files c

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/11/2015 18:08, Markus Armbruster wrote: >>> > evt_encrypt_change 4 5 >> Used in bt_hci_event_encrypt_change(). I figure it makes bt_hci_event() >> overrun the destination by one byte. > > Yes, and Coverity complains. > >> Kernel has >> >>

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Paolo Bonzini
On 27/11/2015 18:08, Markus Armbruster wrote: >> > evt_encrypt_change 4 5 > Used in bt_hci_event_encrypt_change(). I figure it makes bt_hci_event() > overrun the destination by one byte. Yes, and Coverity complains. > Kernel has > > struct hci_ev_encrypt_change {

Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines

2015-11-27 Thread Eduardo Habkost
On Thu, Nov 26, 2015 at 06:00:28PM +0200, Marcel Apfelbaum wrote: > Add bus property to PC machines and use it when looking > for primary PCI root bus (bus 0). > > Signed-off-by: Marcel Apfelbaum I can't pretend I have reviewed the q35 part, but the changes are an improvement to the existing cod

Re: [Qemu-devel] [PATCH v2 04/21] block: Allow references for backing files

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > For bs->file, using references to existing BDSes has been possible for a > while already. This patch enables the same for bs->backing_hd. It's just "backing" now (instead of "backing_hd"). > > Signed-off-by: Kevin Wolf > --- > block.c | 47

Re: [Qemu-devel] [PATCH 1/2] hw/ppc/spapr: Create pseries-2.6 machine

2015-11-27 Thread Thomas Huth
On 27/11/15 10:55, Alexander Graf wrote: > > On 27.11.15 10:32, Thomas Huth wrote: >> Add a new pseries-2.6 machine class version to make sure we can >> keep the old types compatible to previous versions of QEMU in >> later patches. >> >> Signed-off-by: Thomas Huth >> --- >> hw/ppc/spapr.c | 21

Re: [Qemu-devel] [PATCH v2 0/8] Add system_powerdown support on ARM for ACPI and DT

2015-11-27 Thread Peter Maydell
On 29 October 2015 at 14:27, Shannon Zhao wrote: > ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced > platforms(like ARM). It uses GPIO pin to trigger an event to the guest. > For QEMU, here we add PL061 GPIO controller and use PIN 3 for > system_powerdown, reserving PIN 0, 1,

Re: [Qemu-devel] [PATCH v3 8/8] hw/arm/virt: Add gpio-keys node for Poweroff using DT

2015-11-27 Thread Peter Maydell
On 16 November 2015 at 13:23, wrote: > From: Shannon Zhao > > Add a gpio-keys node. This is used for Poweroff for the systems which > use DT not ACPI. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Tested-by: Wei Huang > --- > hw/arm/virt.c | 15 +++ > 1 file cha

Re: [Qemu-devel] [PATCH v6 20/21] iotests: add incremental backup failure recovery test

2015-11-27 Thread Kevin Wolf
Am 18.04.2015 um 01:50 hat John Snow geschrieben: > Test the failure case for incremental backups. > > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > tests/qemu-iotests/124 | 57 > ++ > tests/qemu-iotests/124.out | 4 ++-- > 2 files c

[Qemu-devel] [for-2.6 PATCH 0/2] pc: Add pc-*-2.6 machine classes

2015-11-27 Thread Eduardo Habkost
I am sending this earlier so it can be queued and used as base for patches that need to add compat code to the pc-2.5 machine types. Eduardo Habkost (2): pc: Remove redundant code from pc-*-2.3 machine classes pc: Add pc-*-2.6 machine classes hw/i386/pc_piix.c| 18 +- hw/

[Qemu-devel] [for-2.6 PATCH 1/2] pc: Remove redundant code from pc-*-2.3 machine classes

2015-11-27 Thread Eduardo Habkost
Remove the redundant 'alias = NULL' and 'is_default = 0' lines from older machine-types. pc_*_2_4_machine_options() already clear those fields, so they don't need to be cleared by pc_*_2_3_machine_options(). Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 2 -- hw/i386/pc_q35.c | 1 - 2

[Qemu-devel] [for-2.6 PATCH 2/2] pc: Add pc-*-2.6 machine classes

2015-11-27 Thread Eduardo Habkost
Add pc-i440fx-2.6 and pc-q35-2.6 machine classes. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 16 +--- hw/i386/pc_q35.c | 13 +++-- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 4 4 files changed, 31 insertions(+), 5 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Markus Armbruster writes: > Paolo Bonzini writes: > >> On 27/11/2015 16:16, Markus Armbruster wrote: > >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you > >> checked them all. > >> > >> Reviewed-by: Markus Armbruster Retracted. > No, I just copied

Re: [Qemu-devel] [PATCH v2 03/21] mirror: Error out when a BDS would get two BBs

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > bdrv_replace_in_backing_chain() asserts that not both old and new > BlockDdriverState have a BlockBackend attached to them because both > would have to end up pointing to the new BDS and we don't support more > than one BB per BDS yet. > > Before we can saf

Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35

2015-11-27 Thread Igor Mammedov
On Thu, 26 Nov 2015 20:35:59 +0200 Marcel Apfelbaum wrote: > On 11/26/2015 07:01 PM, Laszlo Ersek wrote: > > Hello Marcel, > > > > On 11/26/15 17:00, Marcel Apfelbaum wrote: > >> Note: > >> I took the liberty to CC all the reviewers that took their time > >> and had a look on the previous version

[Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2015-11-27 Thread Patrik Hermansson
This patch adds the option to specify virtio queue sizes. Currently the queue sizes is hard coded to 256, which might not be suitable for all types of applications. This patch makes it possible to specify the queue size between 256 to 1024. The minimum value is chosen based on the current sizes of

[Qemu-devel] [PATCH] qmp/hmp: add support for system_suspend

2015-11-27 Thread Chen Hanxiao
From: Chen Hanxiao This patch add support for system_suspend command. Signed-off-by: Chen Hanxiao --- hmp-commands.hx | 14 ++ hmp.c | 5 + hmp.h | 1 + qmp.c | 5 + 4 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-comma

Re: [Qemu-devel] [PATCH v2 02/21] block: Fix reopen with semantically overlapping options

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > This fixes bdrv_reopen() calls like the following one: > > qemu-io -c 'open -o overlap-check.template=all /tmp/test.qcow2' \ > -c 'reopen -o overlap-check=none' > > The approach taken so far would result in an options QDict that has both > "overlap

Re: [Qemu-devel] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback

2015-11-27 Thread Max Reitz
On 23.11.2015 16:59, Kevin Wolf wrote: > qcow2 accepts a few driver-specific options that overlap semantically > (e.g. "overlap-check" is an alias of "overlap-check.template", and any > missing cache size option is derived from the given ones). > > When bdrv_reopen() merges the set of updated opti

Re: [Qemu-devel] [SeaBIOS] bug: incorrect uuid in seabios output

2015-11-27 Thread Eduardo Habkost
On Thu, Nov 26, 2015 at 07:40:10PM +0100, Laszlo Ersek wrote: > On 11/26/15 08:43, Gerd Hoffmann wrote: > > On Di, 2015-11-24 at 11:55 -0500, Cole Robinson wrote: > >> Hi, > >> > >> The UUID seabios reports in its boot output doesn't match what is passed > >> via > >> qemu -uuid option. An example

[Qemu-devel] [PATCH v3 4/5] crypto: add QCryptoSecret object class for password/key handling

2015-11-27 Thread Daniel P. Berrange
Introduce a new QCryptoSecret object class which will be used for providing passwords and keys to other objects which need sensitive credentials. The new object can provide secret values directly as properties, or indirectly via a file. The latter includes support for file descriptor passing synta

[Qemu-devel] [PATCH v3 1/5] util: add base64 decoding function

2015-11-27 Thread Daniel P. Berrange
The standard glib provided g_base64_decode doesn't provide any kind of sensible error checking on its input. Add a QEMU custom wrapper qbase64_decode which can be used with untrustworthy input that can contain invalid base64 characters, embedded NUL characters, or not be NUL terminated at all. Sig

[Qemu-devel] [PATCH v3 3/5] qga: convert to use error checked base64 decode

2015-11-27 Thread Daniel P. Berrange
Switch from using g_base64_decode over to qbase64_decode in order to get error checking of the base64 input data. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qga/commands-posix.c | 11 +-- qga/commands-win32.c | 11 +-- qga/commands.c | 13 -

[Qemu-devel] [PATCH v3 2/5] qemu-char: convert to use error checked base64 decode

2015-11-27 Thread Daniel P. Berrange
Switch from using g_base64_decode over to qbase64_decode in order to get error checking of the base64 input data. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qapi-schema.json | 2 -- qemu-char.c | 8 +++- qmp-commands.hx | 2 -- 3 files changed, 7 insertions(+), 5 de

[Qemu-devel] [PATCH v3 5/5] crypto: add support for loading encrypted x509 keys

2015-11-27 Thread Daniel P. Berrange
Make use of the QCryptoSecret object to support loading of encrypted x509 keys. The optional 'passwordid' parameter to the tls-creds-x509 object type, provides the ID of a secret object instance that holds the decryption password for the PEM file. # printf "123456" > mypasswd.txt # $QEMU \ -

[Qemu-devel] [PATCH v3 0/5] Add framework for passing secrets to QEMU

2015-11-27 Thread Daniel P. Berrange
This small series contains just the first two patches for adding the secrets object to QEMU previously shown here: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04748.html The QCryptoSecret object provides a QOM object that allows passing secrets (passwords, encryption keys, etc) to

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/11/2015 16:16, Markus Armbruster wrote: >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >> checked them all. >> >> Reviewed-by: Markus Armbruster >>> > >>> > No, I just copied the upstream bluez patch. >> At least CREATE

Re: [Qemu-devel] target i386 compile problem for hw/core/nmi.c

2015-11-27 Thread Peter Maydell
On 27 November 2015 at 15:03, Tim Sander wrote: > We are trying to call "inject_nmi" from a device on a x386 target. > Unfortunatly it gets called with the wrong defines and the define > TARGET_I386 is *not* defined. If we define TARGET_I386 for testing > the code in the defines fails to compile.

Re: [Qemu-devel] [RFC PATCH v3 5/5] arm/virt: Add ITS to the virt board

2015-11-27 Thread Peter Maydell
On 24 November 2015 at 10:13, Pavel Fedin wrote: > If supported by the configuration, ITS will be added automatically. > > This patch also renames v2m_phandle to msi_phandle because it's now used > by both MSI implementations. > > Signed-off-by: Pavel Fedin Reviewed-by: Peter Maydell We'll nee

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Paolo Bonzini
On 27/11/2015 16:16, Markus Armbruster wrote: >>> >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >>> >> checked them all. >>> >> >>> >> Reviewed-by: Markus Armbruster >> > >> > No, I just copied the upstream bluez patch. > At least CREATE_CONN_CANCEL_CP_SIZE is also wr

Re: [Qemu-devel] [RFC PATCH v3 4/5] kvm_arm: Implement support for ITS emulation by KVM

2015-11-27 Thread Peter Maydell
On 24 November 2015 at 10:13, Pavel Fedin wrote: > This patch relies on new kernel API which is not released yet. > > Signed-off-by: Pavel Fedin > --- > hw/intc/Makefile.objs | 1 + > hw/intc/arm_gicv3_its_common.c | 2 +- > hw/intc/arm_gicv3_its_kvm.c| 88 > +

Re: [Qemu-devel] [RFC PATCH v3 3/5] kvm_arm: Pass requester ID to MSI routing functions

2015-11-27 Thread Peter Maydell
On 24 November 2015 at 10:13, Pavel Fedin wrote: > Introduce global kvm_arm_msi_use_devid flag and pass device IDs in > kvm_arch_fixup_msi_route(). Device IDs are required by the ITS. > > Signed-off-by: Pavel Fedin > --- > target-arm/kvm.c | 6 ++ > target-arm/kvm_arm.h | 3 +++ > 2 file

Re: [Qemu-devel] [RFC PATCH v3 1/5] hw/intc: Implement ITS base class

2015-11-27 Thread Peter Maydell
On 24 November 2015 at 10:13, Pavel Fedin wrote: > This is the basic skeleton for both KVM and software-emulated ITS. > Since we already prepare status structure, we also introduce complete > VMState description. But, because we currently have no migratable > implementations, we also set unmigrata

[Qemu-devel] [PATCH] qom: change object property iterator API contract

2015-11-27 Thread Daniel P. Berrange
Currently the object property iterator API works as follows ObjectPropertyIterator *iter; iter = object_property_iter_init(obj); while ((prop = object_property_iter_next(iter))) { ... } object_property_iter_free(iter); This has the benefit that the ObjectPropertyIterator struct ca

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/11/2015 15:39, Markus Armbruster wrote: >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >> checked them all. >> >> Reviewed-by: Markus Armbruster > > No, I just copied the upstream bluez patch. At least CREATE_CONN_CANCEL_CP_SIZE is also w

[Qemu-devel] target i386 compile problem for hw/core/nmi.c

2015-11-27 Thread Tim Sander
Hi We are trying to call "inject_nmi" from a device on a x386 target. Unfortunatly it gets called with the wrong defines and the define TARGET_I386 is *not* defined. If we define TARGET_I386 for testing the code in the defines fails to compile. Trying to fix this by including: "qom/cpu.h" and "

[Qemu-devel] [PATCH 8/8] block: Implement 'block_disconnect' HMP command

2015-11-27 Thread Hannes Reinecke
Implement a 'block_disconnect' HMP command to simulate a device communication / link failure. Signed-off-by: Hannes Reinecke --- block.c| 5 + block/block-backend.c | 8 blockdev.c | 18 ++ hmp-commands.hx

[Qemu-devel] [PATCH 5/8] scsi-disk: implement ALUA policy

2015-11-27 Thread Hannes Reinecke
Implement ALUA policies 'optimized-standby' and 'optimized-nonoptimized' to emulate active/passive multipath configurations. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 211 ++-- 1 file changed, 204 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH 1/8] scsi-disk: Add 'port_group' property

2015-11-27 Thread Hannes Reinecke
Each SCSI target port can have a 'target port group' identifier. This identifier is used for management software to group individual I_T_L nexus together eg when assembling a multipath topology. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 12 1 file changed, 12 insertio

[Qemu-devel] [PATCH 6/8] scsi-disk: Allow READ CAPACITY in standby

2015-11-27 Thread Hannes Reinecke
SPC does not mandate to allow READ CAPACITY when in standby, but linux currently relies on a valid capacity. Otherwise requests will be retried from sd_prep_fn() and I/O will never complete. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 16 1 file changed, 16 insertio

[Qemu-devel] [PATCH 4/8] scsi-disk: Implement 'SET TARGET PORT GROUPS'

2015-11-27 Thread Hannes Reinecke
Implement 'SET TARGET PORT GROUPS' handling. The ports states are switched as indicated in the command; no strategy is implemented. This might cause issues with standard Linux behaviour, which will only switch the passive path to 'active' and leave the former active path alone. Signed-off-by: Hann

[Qemu-devel] [PATCH 2/8] scsi-disk: Add 'alua_state' property

2015-11-27 Thread Hannes Reinecke
To support asymmetric logical unit access (ALUA) we need to store the ALUA state in the device structure. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-bus.c | 20 + hw/scsi/scsi-disk.c| 117 + include/block/scsi.h | 13 ++

[Qemu-devel] [PATCH RFC 0/8] scsi-disk: Active/passive ALUA support

2015-11-27 Thread Hannes Reinecke
Hi all, here's now an updated version to enable ALUA and simplified active/passive multipath support for qemu. This patchset relies on having _two_ block devices configured, and two SCSI disks pointing to those block devices with the _same_ 'wwn' property and unique 'port_group' properties. I kno

[Qemu-devel] [PATCH 7/8] scsi-disk: Implement 'alua_preferred' option

2015-11-27 Thread Hannes Reinecke
Implement an option to set the 'preferred path' bit in the REPORT TARGET PORT GROUPS output. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index b3ab890..

[Qemu-devel] [PATCH 3/8] scsi-disk: Implement 'REPORT TARGET PORT GROUPS'

2015-11-27 Thread Hannes Reinecke
Implement support for REPORT TARGET PORT GROUPS scsi command. Note that target port groups are referenced per SCSI wwn , which might be connected to different hosts. So we need to walk the entire qtree to find all eligible SCSI devices. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c | 15

[Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-27 Thread marcandre . lureau
From: Marc-André Lureau The prepare callback needs to be implemented with glib < 2.36. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 29205ed.

[Qemu-devel] [PATCH for-2.5 2/3] vhost-user-test: use unix port for migration

2015-11-27 Thread marcandre . lureau
From: Marc-André Lureau TCP port 1234 may be used by another process concurrently. Instead use a temporary unix socket. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-

[Qemu-devel] [PATCH for-2.5 0/3] vhost-user-test fixes

2015-11-27 Thread marcandre . lureau
From: Marc-André Lureau This series fixes a number of races and crashes on glib < 2.36 (with Travis build for ex). Marc-André Lureau (3): vhost-user-test: fix chardriver race vhost-user-test: use unix port for migration vhost-user-test: fix crash with glib < 2.36 tests/vhost-user-test.c

[Qemu-devel] [PATCH for-2.5 1/3] vhost-user-test: fix chardriver race

2015-11-27 Thread marcandre . lureau
From: Marc-André Lureau vhost-user-tests uses a helper thread to dispatch the vhost-user servers sources. However the CharDriverState is not thread-safe. Therefore, when it's given to the thread, it shouldn't be manipulated concurrently. We dispatch cleaning the server in an idle source. By the

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Paolo Bonzini
On 27/11/2015 15:39, Markus Armbruster wrote: > Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you > checked them all. > > Reviewed-by: Markus Armbruster No, I just copied the upstream bluez patch. Paolo

Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical > reasons these do not use sizeof, and Coverity caught a mistake in > EVT_ENCRYPT_CHANGE_SIZE. > > Signed-off-by: Paolo Bonzini > --- > include/hw/bt.h | 4 ++-- > 1 file changed, 2 insertions

Re: [Qemu-devel] [PATCH for-2.5] bt: avoid unintended sign extension

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > In the case of a 4-byte length, shifting a value by 24 may cause > an unintended sign extension when converting from int to size_t. > Use a uint32_t variable instead. > > Signed-off-by: Paolo Bonzini For 32 bit ssize_t, lengths > 0x7fff go to negative, same as before

Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-27 Thread Markus Armbruster
Cao jin writes: > Hi, Markus > > On 11/24/2015 06:08 PM, Markus Armbruster wrote: >> Cao jin writes: >> >>> detailed error info could show user about how to use it. >>> >>> Signed-off-by: Cao jin >>> --- >>> hw/pci-bridge/xio3130_downstream.c | 5 + >>> 1 file changed, 5 insertions(+) >>

Re: [Qemu-devel] [PATCH for-2.5] virtio-9p: use QEMU thread pool

2015-11-27 Thread Greg Kurz
On Fri, 27 Nov 2015 14:08:47 +0100 Paolo Bonzini wrote: > > > On 27/11/2015 13:42, Greg Kurz wrote: > > On Fri, 27 Nov 2015 12:43:06 +0100 > > Paolo Bonzini wrote: > > > >> The QEMU thread pool already has a mechanism to invoke callbacks in the > >> main > >> thread. It does not need an Eve

  1   2   >