Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

2015-11-26 Thread Peter Xu
On 11/27/2015 01:25 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> This patch is only adding the QMP/HMP interface for "dump-query" >> command, but not implementing them. This command could be used to >> query background dump status. Please refer to the next patch to see >> how du

Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

2015-11-26 Thread Peter Xu
On 11/27/2015 01:28 PM, Fam Zheng wrote: > Looks good overall! I've replied patches with a few questions. Thanks! > > Fam Thanks! Will wait for more comments and post v3 later. Peter

Re: [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

2015-11-26 Thread Peter Xu
On 11/27/2015 12:28 PM, Fam Zheng wrote: > I think when write_dump_header() returns a failure, it does call > dump_cleanup(), in create_header{32,64}. > > But the changes of code in this patch look sane to me, and the new error > handling is definitely looking better. Yes, you are right. I will

Re: [Qemu-devel] [PATCH for 2.5 1/1] e1000: fix hang of win2k12 shutdown with flood ping

2015-11-26 Thread Denis V. Lunev
On 11/27/2015 09:48 AM, Denis V. Lunev wrote: e1000 driver in Win2k12 is really well rotten. It 100% hangs on shutdown of UP VM under flood ping. The guest checks card state and reinjects itself interrupt in a loop. This is fatal for UP machine. There is no good way to fix this misbehavior but t

[Qemu-devel] [PATCH for 2.5 1/1] e1000: fix hang of win2k12 shutdown with flood ping

2015-11-26 Thread Denis V. Lunev
e1000 driver in Win2k12 is really well rotten. It 100% hangs on shutdown of UP VM under flood ping. The guest checks card state and reinjects itself interrupt in a loop. This is fatal for UP machine. There is no good way to fix this misbehavior but to kludge it. The emulation has interrupt throttl

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-26 Thread Gerd Hoffmann
On Do, 2015-11-26 at 17:35 +0100, Tim Sander wrote: > Hi > > Below is a patch implementing the i2c-tiny-usb device. Is there a specification for this kind of device? Or does it mimic existing hardware? Please add that into to the comment at the head of the file. > +#ifdef DEBUG_USBI2C > +#defin

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-26 Thread David Gibson
On Tue, Nov 24, 2015 at 10:30:31PM -0800, Sukadev Bhattiprolu wrote: > David, Alexey, > > Any comments on this patch? Sorry, I've been busy, I've sent comments now. > > Suka > > Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: > | Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter t

Re: [Qemu-devel] [PATCH v3 2/2] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-26 Thread David Gibson
On Fri, Nov 13, 2015 at 06:13:08PM -0800, Sukadev Bhattiprolu wrote: > Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() > call in qemu. This call returns the processor module (socket), chip and core > information as specified in section 7.3.16.17 of LoPAPR v2.7. > > We

Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-26 Thread Peter Xu
On 11/27/2015 01:19 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp) >> static void *dump_thread(void *data) >> { >> GlobalDumpState *global = (GlobalDumpState *)data; >> -dump_process(global->gds

Re: [Qemu-devel] [PATCH] Fix memory leak on error

2015-11-26 Thread Stefano Dong
On 2015/11/26 20:33, Markus Armbruster wrote: > Stefano Dong (董兴水) writes: > >> hw/ppc/spapr.c: Fix memory leak on error, it was introduced in bc09e0611 >> hw/acpi/memory_hotplug.c: Fix memory leak on error, it was introduced in >> 34f2af3d >> >> Signed-off-by: Stefano Dong (董兴水) >> --- >> h

Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

2015-11-26 Thread Peter Xu
On 11/27/2015 01:14 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> This patch implements "detach" for "dump-guest-memory" command. When >> specified, one background thread is created to do the dump work. >> >> When there is a dump running in background, the commands "stop", >> "co

[Qemu-devel] [Patch v12 05/10] docs: block replication's description

2015-11-26 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 227 + 1 file changed, 227 insertions(+) create mode 100644 docs/block-replication.txt diff --git a/docs/block-replication.txt b/docs/bl

[Qemu-devel] [Patch v12 04/10] Allow creating backup jobs when opening BDS

2015-11-26 Thread Wen Congyang
When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [Patch v12 07/10] quorum: implement block driver interfaces for block replication

2015-11-26 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Alberto Garcia --- block/quorum.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index b7df14b..6fa54f3

[Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

2015-11-26 Thread Wen Congyang
Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features/BlockReplication Usage: Please refer to docs/block-replication.txt This patch series is

[Qemu-devel] [Patch v12 02/10] Store parent BDS in BdrvChild

2015-11-26 Thread Wen Congyang
We need to access the parent BDS to get the root BDS. Signed-off-by: Wen Congyang --- block.c | 1 + include/block/block_int.h | 1 + 2 files changed, 2 insertions(+) diff --git a/block.c b/block.c index eaf479a..0a0468f 100644 --- a/block.c +++ b/block.c @@ -1204,6 +1204,7 @@

[Qemu-devel] [Patch v12 06/10] Add new block driver interfaces to control block replication

2015-11-26 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino Cc: Michael Roth Reviewed-by: Paolo Bonzini --- block.c | 43 +++ include/block/block.h | 5 + include/block/block_int.h | 14

[Qemu-devel] [Patch v12 01/10] unblock backup operations in backing file

2015-11-26 Thread Wen Congyang
Signed-off-by: Wen Congyang --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index bfc2be8..eaf479a 100644 --- a/block.c +++ b/block.c @@ -1275,6 +1275,24 @@ void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd) /*

[Qemu-devel] [Patch v12 03/10] Backup: clear all bitmap when doing block checkpoint

2015-11-26 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Jeff Cody --- block/backup.c | 14 ++ blockjob.c | 11 +++ include/block/blockjob.h | 12 3 files changed, 37 insertions(+) diff --git a/block/

[Qemu-devel] [Patch v8 3/3] qmp: add monitor command to add/remove a child

2015-11-26 Thread Wen Congyang
The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei

[Qemu-devel] [Patch v8 0/3] qapi: child add/delete support

2015-11-26 Thread Wen Congyang
If quorum's child is broken, we can use mirror job to replace it. But sometimes, the user only need to remove the broken child, and add it later when the problem is fixed. It is based on the Kevin's child name related patch: http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg04949.html Ch

[Qemu-devel] [Patch v8 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-11-26 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 8 ++-- block/quorum.c| 124 +- include/block/block.h | 4 ++ 3 files changed, 130 insertions(+), 6 deletions(-) diff --git a/

[Qemu-devel] [Patch v8 1/3] Add new block driver interface to add/delete a BDS's child

2015-11-26 Thread Wen Congyang
In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block.c | 50 +++

Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-26 Thread Peter Xu
On 11/27/2015 12:31 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> This patch only adds the interfaces, but not implements them. >> "detach" parameter is made optional, to make sure that all the old >> dump-guest-memory requests will still be able to work. >> >> Signed-off-by: Pet

Re: [Qemu-devel] [PATCH COLO-Frame v11 18/39] COLO: Flush PVM's cached RAM into SVM's memory

2015-11-26 Thread Li Zhijian
On 11/24/2015 05:25 PM, zhanghailiang wrote: During the time of VM's running, PVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM cache will always be some with PVM's memory after checkpoint

Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

2015-11-26 Thread Fam Zheng
On Fri, 11/27 10:48, Peter Xu wrote: > Sorry that this v2 series cannot be aligned with the v1 series. One > patch is added at the begining of the series to do some code > cleanups (also fix potential memory leak). Meanwhile, several new > patches are appended to the v1 series. Please see the chang

Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

2015-11-26 Thread Fam Zheng
On Fri, 11/27 10:48, Peter Xu wrote: > This patch is only adding the QMP/HMP interface for "dump-query" > command, but not implementing them. This command could be used to > query background dump status. Please refer to the next patch to see > how dump status are defined. > > Currently, only fake

Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

2015-11-26 Thread Fam Zheng
On Fri, 11/27 13:14, Fam Zheng wrote: > But what I really wonder is why a single boolean is not enough: the DumpState > pointer can be passed to dump_thread, so it doesn't need to be global, then > you > don't need the mutex. Never mind, it's useful in later patches. Fam

Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-26 Thread Fam Zheng
On Fri, 11/27 10:48, Peter Xu wrote: > @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp) > static void *dump_thread(void *data) > { > GlobalDumpState *global = (GlobalDumpState *)data; > -dump_process(global->gds_cur, NULL); > +Error *local_err = NULL; > +

Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

2015-11-26 Thread Fam Zheng
On Fri, 11/27 10:48, Peter Xu wrote: > This patch implements "detach" for "dump-guest-memory" command. When > specified, one background thread is created to do the dump work. > > When there is a dump running in background, the commands "stop", > "cont" and "dump-guest-memory" will fail directly, w

Re: [Qemu-devel] [PATCH COLO-Frame v11 32/39] COLO: Separate the process of saving/loading ram and device state

2015-11-26 Thread Li Zhijian
On 11/24/2015 05:25 PM, zhanghailiang wrote: We separate the process of saving/loading ram and device state when do checkpoint, we add new helpers for save/load ram/device. With this change, we can directly transfer ram from master to slave without using QEMUSizeBuffer as assistant, which also r

Re: [Qemu-devel] [PATCH v13 03/14] qapi: Convert QType into QAPI built-in enum type

2015-11-26 Thread Eric Blake
On 11/26/2015 07:51 AM, Markus Armbruster wrote: > Eric Blake writes: > >> What's more meta than using qapi to define qapi? :) >> >> Convert QType into a full-fledged[*] builtin qapi enum type, so >> that a subsequent patch can then use it as the discriminator >> type of qapi alternate types. Fo

Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-26 Thread Yuanhan Liu
On Thu, Nov 26, 2015 at 06:52:56PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote: > > On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote: > > > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. > > > > > > In case of live

Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-26 Thread Fam Zheng
On Fri, 11/27 10:48, Peter Xu wrote: > This patch only adds the interfaces, but not implements them. > "detach" parameter is made optional, to make sure that all the old > dump-guest-memory requests will still be able to work. > > Signed-off-by: Peter Xu > --- > dump.c | 5 +++-- > hmp

Re: [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

2015-11-26 Thread Fam Zheng
On Fri, 11/27 10:48, Peter Xu wrote: > It might be a little bit confusing to do dump_cleanup() in these two > functions (and error prone, please see section below). A better way > is to do dump_cleanup() before dump finish, no matter whether dump > has succeeded or not. > > Meanwhile, this patch w

[Qemu-devel] [PULL for-2.5 2/3] tap-win32: skip unexpected nodes during registry enumeration

2015-11-26 Thread Jason Wang
From: Andrew Baumann In order to find a named tap device, get_device_guid() enumerates children of HKLM\SYSTEM\CCS\Control\Network\{4D36E972-E325-11CE-BFC1-08002BE10318} (aka NETWORK_CONNECTIONS_KEY). For each child, it then looks for a "Connection" subkey, but if this key doesn't exist, it abort

[Qemu-devel] [PULL for-2.5 3/3] tap-win32: disable broken async write path

2015-11-26 Thread Jason Wang
From: Andrew Baumann The code under the TUN_ASYNCHRONOUS_WRITES path makes two incorrect assumptions about the behaviour of the WriteFile API for overlapped file handles. First, WriteFile does not update the lpNumberOfBytesWritten parameter when the write completes asynchronously (the number of b

[Qemu-devel] [PULL for-2.5 1/3] eepro100: Prevent two endless loops

2015-11-26 Thread Jason Wang
From: Stefan Weil http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg04592.html shows an example how an endless loop in function action_command can be achieved. During my code review, I noticed a 2nd case which can result in an endless loop. Reported-by: Qinghao Tang Signed-off-by: Ste

[Qemu-devel] [PULL for-2.5 0/3] Net patches for 2.5

2015-11-26 Thread Jason Wang
The following changes since commit b04fc428356a540fdb9065fa8c3c71ee476c2031: Update version for v2.5.0-rc2 release (2015-11-26 17:50:12 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to b73c1849148da1229a

Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

2015-11-26 Thread Peter Xu
Hi, all, Sorry that I forgot to CC reviewers and maintainers when posting the patch set. :( Please review! Thanks. Peter On 11/27/2015 10:48 AM, Peter Xu wrote: > Sorry that this v2 series cannot be aligned with the v1 series. One > patch is added at the begining of the series to do some code >

[Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

2015-11-26 Thread Peter Xu
This patch implements "detach" for "dump-guest-memory" command. When specified, one background thread is created to do the dump work. When there is a dump running in background, the commands "stop", "cont" and "dump-guest-memory" will fail directly, with a hint telling user: "there is a dump in pr

[Qemu-devel] [PATCH v2 7/8] DumpState: adding total_size and written_size fields

2015-11-26 Thread Peter Xu
Here, total_size is the size in bytes to be dumped (raw data, which means before compression), while written_size are bytes handled (raw size too). These two fields could be used when do "dump-query". With these information, we could get a very accurate percentage of finished work. Signed-off-by:

[Qemu-devel] [PATCH v2 8/8] dump-query: make the percentage accurate.

2015-11-26 Thread Peter Xu
By calculating the total_size and written_size of memory, we could get relatively accurate percentage of finished dump. Signed-off-by: Peter Xu --- dump.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 65bd5fb..0fcad28 100644 --- a/dump.c +++ b/d

[Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-26 Thread Peter Xu
To get aligned with QMP interface, one new QMP event DUMP_COMPLETED is added. It is used when user specified "detach" in dump, and triggered when the dump finishes. Error message will be appended to this event if the dump has failed. Signed-off-by: Peter Xu --- docs/qmp-events.txt | 12 +

[Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-26 Thread Peter Xu
This patch only adds the interfaces, but not implements them. "detach" parameter is made optional, to make sure that all the old dump-guest-memory requests will still be able to work. Signed-off-by: Peter Xu --- dump.c | 5 +++-- hmp-commands.hx | 5 +++-- hmp.c| 9 +++

[Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

2015-11-26 Thread Peter Xu
This patch is only adding the QMP/HMP interface for "dump-query" command, but not implementing them. This command could be used to query background dump status. Please refer to the next patch to see how dump status are defined. Currently, only fake results are returned. Signed-off-by: Peter Xu -

[Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command.

2015-11-26 Thread Peter Xu
This patch implements the status changes inside dump process. When query dump status, three possible results could be: 1. never started dump: { "status": "NOT_STARTED", "percentage": "N/A" } 2. one dump is running in background: { "status": "IN_PROGRESS", "percentage": "{0..100}%" } 3. no dump i

[Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

2015-11-26 Thread Peter Xu
It might be a little bit confusing to do dump_cleanup() in these two functions (and error prone, please see section below). A better way is to do dump_cleanup() before dump finish, no matter whether dump has succeeded or not. Meanwhile, this patch will also fix the potential memory leaks that migh

[Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

2015-11-26 Thread Peter Xu
Sorry that this v2 series cannot be aligned with the v1 series. One patch is added at the begining of the series to do some code cleanups (also fix potential memory leak). Meanwhile, several new patches are appended to the v1 series. Please see the change log for more info. v2 changes: - fixed Eng

Re: [Qemu-devel] [PATCH v4 1/3] i.MX: rename i.MX CCM get_clock() function and CLK ID enum names

2015-11-26 Thread Peter Crosthwaite
On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: > This is to prepare for CCM code refactoring. > > This is just a bit of function and enum values renaming. > > We also remove some useless intermediate variables. > > Signed-off-by: Jean-Christophe Dubois > Reviewed-by: Peter Crosth

Re: [Qemu-devel] [PATCH v4 2/3] i.MX: Split the CCM class into an abstact base class and a concrete class.

2015-11-26 Thread Peter Crosthwaite
On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: > The IMX_CCM class is now the base abstract class that is used by EPIT and GPT > timer implementation. > > IMX31_CCM class is the concrete class implementing CCM for i.MX31 SOC. > > For now the i.MX25 continues to use the i.MX31 CCM

Re: [Qemu-devel] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-26 Thread Peter Crosthwaite
On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois This seems to slow down boot performance for i.MX25 Linux. Admittedly, the issue looks to be in timeout code for an unmodelled periph (NAND): [ cut here ] WARNING: CPU

Re: [Qemu-devel] [iGVT-g] XenGT for PV guest

2015-11-26 Thread Jike Song
On 11/27/2015 01:10 AM, Oleksii Kurochko wrote: Hello all, Do you have any ideas about previously mentioned question? With best regards, Oleksii On Tue, Nov 24, 2015 at 6:48 PM, Oleksii Kurochko mailto:oleksii.kuroc...@globallogic.com>> wrote: Hi all, I am trying to enable XenGT fo

Re: [Qemu-devel] [PATCH v3 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-26 Thread Peter Crosthwaite
On Wed, Nov 25, 2015 at 11:14 PM, Jean-Christophe DUBOIS wrote: > Le 25/11/2015 06:51, Peter Crosthwaite a écrit : >> >> On Thu, Nov 19, 2015 at 12:40 PM, Jean-Christophe Dubois >> wrote: >>> >>> Signed-off-by: Jean-Christophe Dubois >>> --- >>> >>> Changes since v1: >>> * rework loging to mat

Re: [Qemu-devel] [PATCH v6 3/3] target-i386: add support to migrate vcpu's TSC rate

2015-11-26 Thread Haozhong Zhang
On 11/26/15 12:19, Eduardo Habkost wrote: > On Tue, Nov 24, 2015 at 11:33:57AM +0800, Haozhong Zhang wrote: > > This patch enables migrating vcpu's TSC rate. If KVM on the destination > > machine supports TSC scaling, guest programs will observe a consistent > > TSC rate across the migration. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Add /system-id

2015-11-26 Thread David Gibson
On Thu, Nov 26, 2015 at 03:29:07PM +1100, Alexey Kardashevskiy wrote: > On 11/26/2015 11:49 AM, David Gibson wrote: > >On Wed, Nov 25, 2015 at 04:15:01PM +0100, Alexander Graf wrote: > >> > >> > >>On 18.11.15 11:49, David Gibson wrote: > >>>On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashev

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-11-26 Thread Juan Quintela
Alexander Graf wrote: > On 26.11.15 16:31, Dr. David Alan Gilbert wrote: >> * Alexander Graf (ag...@suse.de) wrote: >>> >>> >>> On 30.10.15 17:50, Mark Cave-Ayland wrote: On 26/10/15 09:48, Mark Cave-Ayland wrote: > On 06/09/15 12:54, Mark Cave-Ayland wrote: > >> On 06/09/15

Re: [Qemu-devel] RFC: raspberry pi / pi2 / Windows-on-ARM support

2015-11-26 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Thursday, 26 November 2015 11:39 > So I am looking at some recent news, and there is the RPi Zero which reuses > the bcm2835 as a different board. Can't find the schematic yet, but from > what I can see, this is a raw SoC (no USB

Re: [Qemu-devel] RFC: raspberry pi / pi2 / Windows-on-ARM support

2015-11-26 Thread Peter Crosthwaite
On Wed, Nov 18, 2015 at 10:16 AM, Andrew Baumann wrote: > Hi Peter, > > Thanks for your feedback! > > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Tuesday, 17 November 2015 23:51 >> I haven't looked beyond the diffstat yet, but a top level >> architectural comment, I only se

Re: [Qemu-devel] [PATCH] tests: fix vhost-user-test race

2015-11-26 Thread Michael S. Tsirkin
On Thu, Nov 26, 2015 at 07:30:55PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > vhost-user-tests uses a helper thread to dispatch the vhost-user servers > sources. However the CharDriverState is not thread-safe. Therefore, when > it's given to the thread, it shouldn't b

Re: [Qemu-devel] [SeaBIOS] bug: incorrect uuid in seabios output

2015-11-26 Thread Laszlo Ersek
On 11/26/15 08:43, Gerd Hoffmann wrote: > On Di, 2015-11-24 at 11:55 -0500, Cole Robinson wrote: >> Hi, >> >> The UUID seabios reports in its boot output doesn't match what is passed via >> qemu -uuid option. An example is reported here: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1284259 >>

Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35

2015-11-26 Thread Marcel Apfelbaum
On 11/26/2015 07:01 PM, Laszlo Ersek wrote: Hello Marcel, On 11/26/15 17:00, Marcel Apfelbaum wrote: Note: I took the liberty to CC all the reviewers that took their time and had a look on the previous version, thanks!! The PXB host bridge provides a way to have multiple PCI hierarchies (PCI r

[Qemu-devel] [PATCH] tests: fix vhost-user-test race

2015-11-26 Thread marcandre . lureau
From: Marc-André Lureau vhost-user-tests uses a helper thread to dispatch the vhost-user servers sources. However the CharDriverState is not thread-safe. Therefore, when it's given to the thread, it shouldn't be maniuplated concurrently. We dispatch cleaning the server in an idle source. By the

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-26 Thread Alex Bennée
Tim Sander writes: > Hi > > Below is a patch implementing the i2c-tiny-usb device. > I am currently not sure about the i2c semantics. I think > incrementing the address on longer reads is wrong? > But at least i can read the high byte(?) of the temperature > via "i2cget -y 0 0x50". > > With this

Re: [Qemu-devel] [PATCH v4 03/17] ipmi: Add a local BMC simulation

2015-11-26 Thread Cédric Le Goater
On 11/24/2015 08:46 PM, Corey Minyard wrote: > On 11/24/2015 07:31 AM, Cédric Le Goater wrote: >> A few comments below, > > Thanks a bunch for the review. As you probably have guessed, this was > not really intended as a fully functional BMC, though it has most of the > trappings of what you woul

Re: [Qemu-devel] [PULL 0/9] vhost, pc: fixes for 2.5

2015-11-26 Thread Peter Maydell
On 26 November 2015 at 16:43, Michael S. Tsirkin wrote: > The following changes since commit 541abd10a01da56c5f16582cd32d67114ec22a5c: > > Update version for v2.5.0-rc1 release (2015-11-20 17:43:46 +) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst

Re: [Qemu-devel] qemu-char issues (was Re: [PULL 00/15] vhost, pc: fixes for

2015-11-26 Thread Peter Maydell
On 26 November 2015 at 17:01, Michael S. Tsirkin wrote: > Last note: > https://developer.gnome.org/glib/stable/glib-The-Main-Event-Loop.html#mainloop-memory-management > suggests two ways to manage memory for sources. > We seem to do neither, opting for a different approach. We seem to pretty muc

Re: [Qemu-devel] [PATCH for 2.5 1/1] qga: added another non-interactive gspawn() helper file.

2015-11-26 Thread Yuri Pudgorodskiy
On 11/26/2015 1:21 AM, Michael Roth wrote: Quoting Denis V. Lunev (2015-11-25 13:02:26) From: Yuri Pudgorodskiy With previous commit we added gspawn-win64-helper-console.exe, required for gspawn() mingw implementation. Unfortunatly when running as a service without interactive desktop, gspawn(

Re: [Qemu-devel] [RESEND RFC 6/6] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation

2015-11-26 Thread Alex Bennée
Eric Auger writes: > This patch allows the instantiation of the vfio-amd-xgbe device > from the QEMU command line (-device vfio-amd-xgbe,host=""). > > The guest is exposed with a device tree node that combines the description > of both XGBE and PHY (representation supported from 4.2 onwards kern

Re: [Qemu-devel] [iGVT-g] XenGT for PV guest

2015-11-26 Thread Oleksii Kurochko
Hello all, Do you have any ideas about previously mentioned question? With best regards, Oleksii On Tue, Nov 24, 2015 at 6:48 PM, Oleksii Kurochko < oleksii.kuroc...@globallogic.com> wrote: > Hi all, > > I am trying to enable XenGT for Android on board vtc1010 in PV mode. > Used: > - Intel® At

Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35

2015-11-26 Thread Laszlo Ersek
Hello Marcel, On 11/26/15 17:00, Marcel Apfelbaum wrote: > Note: > I took the liberty to CC all the reviewers that took their time > and had a look on the previous version, thanks!! > > The PXB host bridge provides a way to have multiple PCI hierarchies (PCI root > buses). > This series introduc

[Qemu-devel] qemu-char issues (was Re: [PULL 00/15] vhost, pc: fixes for

2015-11-26 Thread Michael S. Tsirkin
2.5) Message-ID: <20151126190029-mutt-send-email-...@redhat.com> Reply-To: In-Reply-To: <20151126182218-mutt-send-email-...@redhat.com> On Thu, Nov 26, 2015 at 06:24:12PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 26, 2015 at 06:19:46PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 26, 201

[Qemu-devel] [PATCH v1 1/1] (for-2.5) virtio-scsi: don't crash without a valid device

2015-11-26 Thread Eugene (jno) Dvurechenski
Make sure that we actually have a device when checking the aio context. Otherwise guests could trigger QEMU crashes. Signed-off-by: "Eugene (jno) Dvurechenski" Reviewed-by: David Hildenbrand --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vi

[Qemu-devel] [PATCH 0/1] (for-2.5) Don't allow a guest to crash QEMU

2015-11-26 Thread Eugene (jno) Dvurechenski
I've found the case where erratic guest was able to crash QEMU. This patch prevents dereferencing of a NULL pointer (empty 'd' in the assertion, no valid LUN was specified). Eugene (jno) Dvurechenski (1): virtio-scsi: don't crash without a valid device hw/scsi/virtio-scsi.c | 2 +- 1 file chan

Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-26 Thread Michael S. Tsirkin
On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote: > On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote: > > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. > > > > In case of live migration several queues can be enabled and not only the > > first one. So in

Re: [Qemu-devel] [PULL for-2.5 00/13] QMP and QObject patches

2015-11-26 Thread Peter Maydell
On 26 November 2015 at 12:47, Markus Armbruster wrote: > The following changes since commit 1a4dab849d5d06191ab5e5850f6b8bfcad8ceb47: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-11-25 14:47:06 +) > > are available in the git repository at: > > g

Re: [Qemu-devel] [PATCH v13 11/14] qapi: Populate info['name'] for each entity

2015-11-26 Thread Markus Armbruster
Eric Blake writes: > Every non-implicit entity is associated with an info dictionary, > but it is not easy to reverse-engineer the name of the top-most > entity associated with that info. Add a new info['name'] field > to track this information, as it will be handy in future commits > for better

[Qemu-devel] [PULL 9/9] vhost-user-test: fix migration overlap test

2015-11-26 Thread Michael S. Tsirkin
During migration, source does GET_BASE, destination does SET_BASE. Use that as opposed to fds being configured to detect vhost user running on both source and destination. Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 13 - 1 file changed, 8 insertions(+), 5 deletio

[Qemu-devel] [PULL 7/9] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-26 Thread Michael S. Tsirkin
This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. In case of live migration several queues can be enabled and not only the first one. So informing backend that only the first queue is enabled is wrong. Reported-by: Thibaut Collet Cc: Yuanhan Liu Signed-off-by: Michael S. Tsirkin Re

[Qemu-devel] [PULL 8/9] Fix memory leak on error

2015-11-26 Thread Michael S. Tsirkin
From: Stefano Dong (董兴水) hw/ppc/spapr.c: Fix memory leak on error, it was introduced in bc09e0611 hw/acpi/memory_hotplug.c: Fix memory leak on error, it was introduced in 34f2af3d Signed-off-by: Stefano Dong (董兴水) Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi

[Qemu-devel] [PULL 5/9] tests/vhost-user-bridge: propose GUEST_ANNOUNCE feature

2015-11-26 Thread Michael S. Tsirkin
From: Victor Kaplansky The backend has to know whether VIRTIO_NET_F_GUEST_ANNOUNCE was negotiated, so, as a hack we propose the feature by vhost-user-bridge during the feature negotiation. Signed-off-by: Victor Kaplansky Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- t

[Qemu-devel] [PULL 3/9] vhost-user: set link down when the char device is closed

2015-11-26 Thread Michael S. Tsirkin
From: Wen Congyang Signed-off-by: Wen Congyang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Yuanhan Liu --- net/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index 0ebd7df..5071602 100644

[Qemu-devel] [PULL 6/9] tests/vhost-user-bridge: read command line arguments

2015-11-26 Thread Michael S. Tsirkin
From: Victor Kaplansky Now some vhost-user-bridge parameters can be passed from the command line: Usage: prog [-u ud_socket_path] [-l lhost:lport] [-r rhost:rport] -u path to unix doman socket. default: /tmp/vubr.sock -l local host and port. default: 127.0.0.1: -r rem

[Qemu-devel] [PULL 2/9] pc: Don't set hw_version on pc-*-2.5

2015-11-26 Thread Michael S. Tsirkin
From: Eduardo Habkost Now that qemu_hw_version() returns a fixed "2.5+" string instead of QEMU_VERSION, we don't need to set hw_version on pc-*-2.5 explicitly. Suggested-by: Michael S. Tsirkin Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --

[Qemu-devel] [PULL 1/9] osdep: Change default value of qemu_hw_version() to "2.5+"

2015-11-26 Thread Michael S. Tsirkin
From: Eduardo Habkost There are two issues with qemu_hw_version() today: 1) If a machine has hw_version set, the value returned by it is not very useful, because it is not the actual QEMU version. 2) If a machine does't set hw_version, the return value of qemu_hw_version() is broken, becau

[Qemu-devel] [PULL 4/9] vhost-user: clarify start and enable

2015-11-26 Thread Michael S. Tsirkin
It seems that we currently have some duplication between started and enabled states. The actual reason is that enable is not documented correctly: what it does is connecting ring to the backend. This is important for MQ, because a Linux guest expects TX packets to be completed even if it disables

[Qemu-devel] [PULL 0/9] vhost, pc: fixes for 2.5

2015-11-26 Thread Michael S. Tsirkin
The following changes since commit 541abd10a01da56c5f16582cd32d67114ec22a5c: Update version for v2.5.0-rc1 release (2015-11-20 17:43:46 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to d08e42a1

[Qemu-devel] [PATCH RFC] i2c-tiny-usb

2015-11-26 Thread Tim Sander
Hi Below is a patch implementing the i2c-tiny-usb device. I am currently not sure about the i2c semantics. I think incrementing the address on longer reads is wrong? But at least i can read the high byte(?) of the temperature via "i2cget -y 0 0x50". With this device it should be possible to defi

[Qemu-devel] [PATCH v1 4/5] lib/x86: Make free_page() available to call

2015-11-26 Thread Andrey Smetanin
This will be used to release allocated pages by Hyper-V SynIC timers test. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzini CC: Marcelo Tosatti CC: Roman Kagan CC: Denis V. Lunev CC: qemu-devel@nongnu.org --- lib/x86/vm.h | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PATCH v1 5/5] x86: Hyper-V SynIC timers test

2015-11-26 Thread Andrey Smetanin
The test checks Hyper-V SynIC timers functionality. The test runs on every vCPU and performs start/stop of periodic/one-shot timers (with period=1ms) and checks validity of received expiration messages in appropriate ISR's. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzin

[Qemu-devel] [PATCH v1 2/5] lib/x86: Added HV_X64_MSR_TIME_REF_COUNT value into msr.h

2015-11-26 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzini CC: Marcelo Tosatti CC: Roman Kagan CC: Denis V. Lunev CC: qemu-devel@nongnu.org --- lib/x86/msr.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/x86/msr.h b/lib/x86/msr.h index 89ed718..4ac9c71 100644 ---

[Qemu-devel] [PATCH v1 0/5] KVM-UNIT-TESTS: Hyper-V SynIC timers test

2015-11-26 Thread Andrey Smetanin
The test checks Hyper-V SynIC timers functionality. The test runs on every vCPU and performs start/stop of periodic/one-shot timers (with period=1ms) and checks validity of received expiration messages in appropriate ISR's. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzin

[Qemu-devel] [PATCH v1 1/5] lib/x86: Added Hyper-V MSR's availability bits into msr.h

2015-11-26 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzini CC: Marcelo Tosatti CC: Roman Kagan CC: Denis V. Lunev CC: qemu-devel@nongnu.org --- lib/x86/msr.h | 4 x86/hyperv_synic.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/x86/msr.h

[Qemu-devel] [PATCH v1 3/5] lib/x86: Added Hyper-V SynIC timers MSR's values

2015-11-26 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzini CC: Marcelo Tosatti CC: Roman Kagan CC: Denis V. Lunev CC: qemu-devel@nongnu.org --- lib/x86/msr.h | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/x86/msr.h b/lib/x86/msr.h index 4ac9c71..d3f419

Re: [Qemu-devel] [PATCH v13 10/14] qapi: Track enum values by QAPISchemaMember, not string

2015-11-26 Thread Markus Armbruster
Eric Blake writes: > Rather than using just an array of strings, make enum.values be > an array of the new QAPISchemaMember type. Creating an enum > requires wrapping strings, and visiting an enum requires getting > at the name of each value. But using this type means we can > share the existin

Re: [Qemu-devel] [PULL v2 0/9] Misc patches for QEMU 2.5-rc2

2015-11-26 Thread Peter Maydell
On 26 November 2015 at 15:52, Paolo Bonzini wrote: > The following changes since commit 4b6eda626fdb8bf90472c6868d502a2ac09abeeb: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20151124' into > staging (2015-11-24 17:05:06 +) > > are available in the git repository at: > > git

Re: [Qemu-devel] [PULL 00/15] vhost, pc: fixes for 2.5

2015-11-26 Thread Michael S. Tsirkin
On Thu, Nov 26, 2015 at 06:19:46PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 26, 2015 at 11:26:10AM +, Peter Maydell wrote: > > On 19 November 2015 at 13:35, Michael S. Tsirkin wrote: > > > The following changes since commit > > > 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > > > > > U

Re: [Qemu-devel] [PULL 00/15] vhost, pc: fixes for 2.5

2015-11-26 Thread Michael S. Tsirkin
On Thu, Nov 26, 2015 at 11:26:10AM +, Peter Maydell wrote: > On 19 November 2015 at 13:35, Michael S. Tsirkin wrote: > > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) > > > > are availabl

Re: [Qemu-devel] [RESEND RFC 5/6] hw/arm/sysbus-fdt: helpers for clock node generation

2015-11-26 Thread Alex Bennée
Eric Auger writes: > Some passthrough'ed devices depend on clock nodes. Those need to be > generated in the guest device tree. This patch introduces some helpers > to build a clock node from information retrieved from host device tree. > > - inherit_properties copies properties from a host devic

Re: [Qemu-devel] [PULL 0/9] Misc patches for QEMU 2.5-rc2 (2015-11-25)

2015-11-26 Thread Paolo Bonzini
On 26/11/2015 16:55, Peter Maydell wrote: > This is all talking about in-practice behaviour of the compiler. > What I'm interested in is what the documented guarantees are. They are these: >> Again, the _value_ is perfectly specified by the GCC documentation (and >> as of this morning, it's pro

  1   2   3   >