Eric Blake writes:
> On 11/18/2015 11:25 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> The name QType is more in line with our conventions for qapi
>>> types, and matches the fact that each enum member has a prefix
>>> of QTYPE_.
>>>
>>> Signed-off-by: Eric Blake
>>
>> At this poi
Tweaking subject to "qapi: Remove obsolete tests for MAX collision".
git-am complains about the trailing whitespace in expected test output.
Not this patch's fault. Would be nice to avoid, but not in this series.
Hi Max:
On 11/19/2015 12:52 AM, Max Reitz wrote:
On 04.11.2015 03:26, Bo Tu wrote:
The tests for device type "ide_cd" should only be tested for the pc
platform.
The default device id of hard disk on the s390 platform differs to that
of the x86 platform. A new variable device_id is defined and "
Hi Max:
On 11/19/2015 12:56 AM, Max Reitz wrote:
On 04.11.2015 03:26, Bo Tu wrote:
Ever since qemu-iotest 120 was introduced, its expected output didn't
include the output from the built-in VNC server:
QA output created by 120
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
QMP_
Hello!
The attached patch enables the sigaltstack syscall in qemu-sh4.
The following minimal test code verifies that sigaltstack works as
expected:
=
#include
#include
#include
#include
jmp_buf exit_jmp;
void handler(int x)
{
l
basically all bdrv_* operations must be called under aio_context_acquire
except ones with bdrv_all prefix.
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
CC: Juan Quintela
CC: Kevin Wolf
Tested-by: Greg Kurz
---
migration/savevm.c | 19 ++-
The patch also ensures proper locking for the operation.
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
CC: Kevin Wolf
Tested-by: Greg Kurz
---
block/snapshot.c | 15 +++
include/block/snapshot.h | 2 ++
migr
to create snapshot for all loaded block drivers.
The patch also ensures proper locking.
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
CC: Kevin Wolf
Tested-by: Greg Kurz
---
block/snapshot.c | 26 +++
to delete snapshots from all loaded block drivers.
The patch also ensures proper locking.
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
CC: Kevin Wolf
Tested-by: Greg Kurz
---
block/snapshot.c | 22
State deletion can be performed on running VM which reduces VM downtime
This approach looks a bit more natural.
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
Tested-by: Greg Kurz
---
migration/savevm.c | 18 +-
1
The patch enforces proper locking for this operation.
Signed-off-by: Denis V. Lunev
Reviewed-by: Greg Kurz
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
CC: Kevin Wolf
Tested-by: Greg Kurz
---
block/snapshot.c | 24
include/
to switch to snapshot on all loaded block drivers.
The patch also ensures proper locking.
Signed-off-by: Denis V. Lunev
Reviewed-by: Greg Kurz
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
CC: Kevin Wolf
Tested-by: Greg Kurz
---
block/snapshot.c |
There is no much sense to do the check and write warning.
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
Tested-by: Greg Kurz
---
migration/savevm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/migration/savevm.c b/migr
this will make code better in the next patch
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-by: Juan Quintela
CC: Kevin Wolf
Tested-by: Greg Kurz
---
block/snapshot.c | 7 ---
include/block/snapshot.h | 6 +++---
2 files changed, 7 ins
with test
while /bin/true ; do
virsh snapshot-create rhel7
sleep 10
virsh snapshot-delete rhel7 --current
done
with enabled iothreads on a running VM leads to a lot of troubles: hangs,
asserts, errors.
Anyway, I think that the construction like
assert(aio_contex
We should check that all inserted and not read-only images support
snapshotting. This could be made using already invented helper
bdrv_all_can_snapshot().
Signed-off-by: Denis V. Lunev
Reviewed-by: Juan Quintela
Reviewed-by: Fam Zheng
CC: Stefan Hajnoczi
CC: Kevin Wolf
Tested-by: Greg Kurz
-
to check that snapshot is available for all loaded block drivers.
The check bs != bs1 in hmp_info_snapshots is an optimization. The check
for availability of this snapshot will return always true as the list
of snapshots was collected from that image.
The patch also ensures proper locking.
Signed
On Wed, 2015-11-18 at 13:58 -0200, Eduardo Habkost wrote:
> On Wed, Nov 18, 2015 at 10:20:15AM +0800, Huaitong Han wrote:
> [...]
> > @@ -408,6 +420,13 @@ static FeatureWordInfo
> > feature_word_info[FEATURE_WORDS] = {
> > .cpuid_reg = R_EBX,
> > .tcg_features = TCG_7_0_EBX_FEATUR
Hi Max:
On 11/19/2015 12:45 AM, Max Reitz wrote:
On 04.11.2015 03:26, Bo Tu wrote:
Replacing sed with awk, then it's easier to read.
I think you meant "awk with sed".
It's my fault. thanks :-)
Replacing "[ ! -z "$default_alias_machine" ]" with
"[[ $default_alias_machine ]]", then it's s
vfio_container_ioctl() was a bad interface that bypassed abstraction
boundaries, had semantics that sat uneasily with its name, and was unsafe
in many realistic circumstances. Now that spapr-pci-vfio-host-bridge has
been folded into spapr-pci-host-bridge, there are no more users, so remove
it.
Si
Now that spapr-pci-vfio-host-bridge is reduced to just a stub, there is
only one implementation of the finish_realize hook in sPAPRPHBClass. So,
we can fold that implementation into its (single) caller, and remove the
hook. That's the last thing left in sPAPRPHBClass, so that can go away as
well.
Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_reset() into
rtas_ibm_set_slot_reset(). We move several functions of which it was
the only caller (spapr_phb_eeh_clear_dev_msix(),
spapr_phb_eeh_clear_bus_msix() and spapr_phb_eeh_pre_reset()) into
spapr_pci.c along with it.
Signed-off-by:
The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the
special groupid field in sPAPRPHBVFIOState. So we can simplify, removing
the class specific callbacks with direct calls based on a simple
spapr_phb_eeh_enabled() helper. For now we implement that in terms of
a boolean in t
Now that the EEH code is independent of the special
spapr-vfio-pci-host-bridge device, we can allow it on all spapr PCI
host bridges instead. We do this by changing spapr_phb_eeh_available()
to be based on the vfio_eeh_as_ok() call instead of the host bridge class.
Because the value of vfio_eeh_a
This switches all EEH on VFIO operations in spapr_pci_vfio.c from the
broken vfio_container_ioctl() interface to the new vfio_as_eeh_op()
interface.
Signed-off-by: David Gibson mak
---
hw/ppc/spapr_pci_vfio.c | 50 -
1 file changed, 16 insertions(+)
Simplify the sPAPR PCI code by folding spapr_phb_eeh_set_option() into
rtas_ibm_set_eeh_option().
Signed-off-by: David Gibson
---
hw/ppc/spapr_pci.c | 43 +++--
hw/ppc/spapr_pci_vfio.c | 47 -
include/hw
Simplify the sPAPR PCI code by folding spapr_phb_vfio_reset() into
spapr_phb_reset().
Signed-off-by: David Gibson
---
hw/ppc/spapr_pci.c | 13 -
hw/ppc/spapr_pci_vfio.c | 16
2 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/hw/ppc/spapr_pci.c b/h
Now that the regular spapr-pci-host-bridge can handle EEH, there are only
two things that spapr-pci-vfio-host-bridge does differently:
1. automatically sizes its DMA window to match the host IOMMU
2. checks if the attached VFIO container is backed by the
VFIO_SPAPR_TCE_IOMMU type on
Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_configure()
into rtas_ibm_configure_pe().
Signed-off-by: David Gibson
---
hw/ppc/spapr_pci.c | 11 +--
hw/ppc/spapr_pci_vfio.c | 12
include/hw/pci-host/spapr.h | 1 -
3 files changed, 9 insertions(+), 1
Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_get_state9)
into rtas_ibm_read_slot_reset_state2().
Signed-off-by: David Gibson
---
hw/ppc/spapr_pci.c | 12 ++--
hw/ppc/spapr_pci_vfio.c | 13 -
include/hw/pci-host/spapr.h | 1 -
3 files changed, 6 inse
This series of patches (2 to vfio, the remainder to the sPAPR specific
PCI code) improve the interfaces for passing through EEH (IBM's
Enhanced Error Handling facility) from guest PCI devices to host PCI
devices.
This allows EEH to be used on the normal spapr-pci-host-bridge device,
removing any r
At present the code handling IBM's Enhanced Error Handling (EEH) interface
on VFIO devices operates by bypassing the usual VFIO logic with
vfio_container_ioctl(). That's a poorly designed interface with unclear
semantics about exactly what can be operated on.
In particular it operates on a single
> From: Alex Williamson [mailto:alex.william...@redhat.com]
> Sent: Thursday, November 19, 2015 2:12 AM
>
> [cc +qemu-devel, +paolo, +gerd]
>
> On Tue, 2015-10-27 at 17:25 +0800, Jike Song wrote:
> > Hi all,
> >
> > We are pleased to announce another update of Intel GVT-g for Xen.
> >
> > Intel G
Hello,
I read in the thread
"
Applied to kvm/queue. Thanks Marcelo, and thanks David for the review.
Paolo
"
But I cannot find where the patch enters the qemu git repo:
http://git.qemu.org/?p=qemu.git&a=search&h=HEAD&st=author&s=Tosatti
Is it not there yet?
Thanks!
C.
--
You received this b
On 11/19/2015 04:44 AM, Michael S. Tsirkin wrote:
On Wed, Nov 18, 2015 at 05:18:17PM -0200, Eduardo Habkost wrote:
On Wed, Nov 18, 2015 at 09:59:34AM +0800, Xiao Guangrong wrote:
Ping...
Do you have any comment on this patchset? Could it be applied to somewhere
if it is okay for you?
I ha
I have no idea why the lines didn't wrap in my last post... Sorry about
that.
On 11/13/2015 05:23 AM, Aravinda Prasad wrote:
+
+/*
+ * Currently KVM only passes on the uncorrected machine
+ * check memory error to guest. Other machine check errors
+ * such as SLB multi-hit and TLB multi-hit are recovered
+ * in KVM and are not passed on to guest.
+ *
+ * DSISR Bit for unc
Dear Kevin,
Sorry for delayed replying. This patch works for me well. Thanks a lot!
Recently, I found another odd thing. A qemu-kvm VM is stuck at the SeaBIOS
after self-rebooting many times. Analyzing the SeaBIOS log attached below, I
think there maybe someting wrong from this block of code:
/
Hello!
I'm the current maintainer for the Debian sh4 port. I maintain several
buildds as well as port packages for the sh4 architecture.
Recently I discovered qemu for building packages in an emulated chroot
environment with qemu-sh4-static. While setting up python, qemu issued
an error message a
---
linux-user/syscall.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 6c64ba6..4d864b2 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8294,7 +8294,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
On 11/18/2015 12:19 PM, Markus Armbruster wrote:
> Feels close. The only issues in need of discussion are in PATCH 27.
>
> I expect the fixup to PATCH 21 to be straightforward. I'd do PATCH 28 a
> bit different, but it works as is. PATCH 30 could perhaps be simplified
> slightly. The rest are
[keep the original commit body, but change the title:]
qapi: Convert QType into QAPI built-in enum type
Signed-off-by: Eric Blake
---
include/qemu/typedefs.h | 1 +
scripts/qapi-types.py | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qemu/typedefs.h b/include/
[If we squash, replace the old commit message with this; you'll
also have some merge conflicts in 29/36 and 30/36. Note that
while this mail is net lines added, squashing would still result
in a net reduction:
16 files changed, 67 insertions(+), 83 deletions(-)
]
qapi: Simplify QObject
The QObj
Am 06.11.2015 um 10:32 schrieb Daniel P. Berrange:
> On Thu, Nov 05, 2015 at 07:12:39PM +0100, Andreas Färber wrote:
>> Am 13.10.2015 um 15:18 schrieb Pavel Fedin:
diff --git a/include/qom/object.h b/include/qom/object.h
index 2a54515..38f41d3 100644
--- a/include/qom/object.h
+
On 11/18/2015 11:25 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> The name QType is more in line with our conventions for qapi
>> types, and matches the fact that each enum member has a prefix
>> of QTYPE_.
>>
>> Signed-off-by: Eric Blake
>
> At this point, the connection to QAPI is un
[Replace the old commit message with this:]
qapi: Forbid case-insensitive clashes
In general, designing user interfaces that rely on case
distinction is poor practice. Another benefit of enforcing
a restriction against case-insensitive clashes is that we
no longer have to worry about the situati
On 11/18/2015 01:53 AM, Eric Blake wrote:
> In general, designing user interfaces that rely on case
> distinction is poor practice. Another benefit of enforcing
> a restriction against case-insensitive clashes is that we
> no longer have to worry about the situation of enum values
> that could be
On 11/18/2015 03:09 PM, Eric Blake wrote:
> On 11/18/2015 10:08 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> In general, designing user interfaces that rely on case
>>> distinction is poor practice. Another benefit of enforcing
>>> a restriction against case-insensitive clashes is th
This patch addresses BZ 1281413.
Adapt the sysfs TPM command cancel path for the TPM driver that
does not use a miscdevice anymore since Linux 4.0. Support old
and new paths.
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_passthrough.c | 23 +++
1 file changed, 15 insertions(+)
I could not reproduce the original issue, but the new qemu packages
appear to be regression-free, so marked this verification-done on that
grounds. If the SRU team prefers to kick this package I'm ok with that
as well.
** Tags removed: verification-needed
** Tags added: verification-done
--
You
On 11/18/2015 10:08 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> In general, designing user interfaces that rely on case
>> distinction is poor practice. Another benefit of enforcing
>> a restriction against case-insensitive clashes is that we
>> no longer have to worry about the situa
On Tue, 2015-11-17 at 10:46 +0300, Pavel Fedin wrote:
> On some architectures TARGET_PAGE_ALIGN() is not enough to get the right
> alignment. For example on ARM TARGET_PAGE_BITS is 10 because some old CPUs
> support 1K page size, while minimum SMMU page size is 4K.
>
> This fixes problems like:
>
On Wed, 18 Nov 2015 22:48:06 +0200
"Michael S. Tsirkin" wrote:
> On Wed, Nov 18, 2015 at 05:23:00PM +0100, Greg Kurz wrote:
> > Since QEMU 2.4.0, vhost-net uses the cross-endian support of TAP devices to
> > fix vnet headers. In fact, virtio-net can do the same instead of hackily
> > patching hea
[Replace the old commit message with this:]
qapi: Tighten the regex on valid names
We already documented that qapi names should match specific
patterns (such as starting with a letter unless it was an enum
value or a downstream extension). Tighten that from a suggestion
into a hard requirement,
On 11/18/2015 02:41 PM, Peter Maydell wrote:
> For a big patchset like this the easiest thing is to just ask
> Michael if he has a public git repo with the patches in (I've
> cc'd him).
https://github.com/mdavidsaver/qemu/tree/fixirq
The posted patches were
https://github.com/qemu/qemu/compare/c
On Wed, 2015-11-18 at 13:50 -0500, Martin Hicks wrote:
> Hi,
>
> I've been looking at PCI passthrough using vfio-pci and hoping that it can
> use the Intel IOMMU emulation in the guest to pin-pages in an on-demand
> nature, rather than pinning the entire guest memory as vfio-pci does now.
> Unfort
On 18/11/2015 18:51, Eduardo Habkost wrote:
> Is every CPU supporting PKU guaranteed to have
> CPUID.(EAX=0DH,ECX=9):EBX = 0xa80?
We asked Intel a while ago when reorganizing XSAVE support in KVM and
QEMU. Unfortunately, Intel is not listing the offsets anymore in the
documentation, but they co
On Tue, Nov 17, 2015 at 10:17:37AM +0300, Pavel Fedin wrote:
> If you happen to have a stock kernel of old version, like 3.x,
On ARM
> and you
> attempt to enable vhost by setting vhost=on, qemu aborts with error:
> kvm_mem_ioeventfd_add: error adding ioeventfd: Function not implemented
>
> This
Am 18.11.2015 um 21:51 schrieb Eric Blake:
> On 11/18/2015 01:46 PM, Andreas Färber wrote:
>>> +++ b/MAINTAINERS
>>> @@ -486,7 +486,8 @@ F: hw/ppc/prep.c
>>> F: hw/pci-host/prep.[hc]
>>> F: hw/isa/pc87312.[hc]
>>>
>>> -sPAPR
>>> +sPAPR (pseries)
>>
>> This change leads to get_maintainer.pl usin
On Wed, Nov 18, 2015 at 02:04:24PM +0100, François Revol wrote:
> On 17/11/2015 23:14, Rob Herring wrote:
> > On Mon, Nov 16, 2015 at 2:38 AM, Paolo Bonzini wrote:
> >>
> >>
> >> On 15/11/2015 03:07, Rob Herring wrote:
> >>> We generally don't want DT docs to depend on other kernel documentation.
On 11/18/2015 01:46 PM, Andreas Färber wrote:
>> +++ b/MAINTAINERS
>> @@ -486,7 +486,8 @@ F: hw/ppc/prep.c
>> F: hw/pci-host/prep.[hc]
>> F: hw/isa/pc87312.[hc]
>>
>> -sPAPR
>> +sPAPR (pseries)
>
> This change leads to get_maintainer.pl using "qemu-...@nongnu.org (open
> list:sPAPR (pseries))
On Wed, Nov 18, 2015 at 10:02:58AM +0100, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> vhost-user-test prints a warning. A test should not need to run on
> hugetlbfs, let's silence the warning under qtest. The
> condition can't check on qtest_enabled() since vhost-user-test ac
On Wed, Nov 18, 2015 at 05:23:00PM +0100, Greg Kurz wrote:
> Since QEMU 2.4.0, vhost-net uses the cross-endian support of TAP devices to
> fix vnet headers. In fact, virtio-net can do the same instead of hackily
> patching headers in virtio_net_hdr_swap().
>
> This series moves the enablement of c
Add the QOM unit tests to the QOM maintenance area so that maintainers
get CC'ed on changes and to document QOM test coverage.
Cc: Daniel P. Berrange
Cc: Igor Mammedov
Signed-off-by: Andreas Färber
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
On Wed, Nov 18, 2015 at 05:18:17PM -0200, Eduardo Habkost wrote:
> On Wed, Nov 18, 2015 at 09:59:34AM +0800, Xiao Guangrong wrote:
> >
> > Ping...
> >
> > Do you have any comment on this patchset? Could it be applied to somewhere
> > if it is okay for you?
>
> I have no additional comments, as t
Am 03.06.2015 um 23:45 schrieb Alexander Graf:
> From: David Gibson
>
> At Alex Graf's request I'm now acting as sub-maintainer for the sPAPR
> (-machine pseries) code. This updates MAINTAINERS accordingly.
>
> While we're at it, change the label to mention pseries since that's the
> actual nam
Instead of using g_assert() for integer comparisons, use
g_assert_cmpint() so that we can see the respective values.
While at it, fix one stray indentation.
Reviewed-by: Daniel P. Berrange
Signed-off-by: Andreas Färber
---
qom/object.c | 12 ++--
1 file changed, 6 insertions(+), 6 dele
From: "Daniel P. Berrange"
Devices have some quite complex object child/link relationships
which place some requirements on the object_property_del_all()
function to consider that properties can be modified while
being iterated over.
This extends the QOM property test case to replicate the
devic
On 18 November 2015 at 20:30, Francois Baldassari wrote:
[regarding Michael's M profile NVIC patchset]
> I must be missing something obvious, but I do not have the original
> email thread (I was not subscribed at the time) and thus am finding it
> exceedingly difficult to apply the patches using g
Please submit after 2.5 is out.
It's clearly a new feature so can't be merged now, after freeze.
On Wed, Nov 18, 2015 at 12:41:20PM -0600, Corey Minyard wrote:
> I haven't heard any more comments on this series, should I resubmit with the
> one shutdown change?
>
> -corey
>
> On Nov 12, 2015 1:0
From: "Daniel P. Berrange"
Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.
Signed-off-by: Daniel P. Berrange
Tested-by: Pavel Fedin
Sig
From: Pavel Fedin
ARM GICv3 systems with large number of CPUs create lots of IRQ pins. Since
every pin is represented as a property, number of these properties becomes
very large. Every property add first makes sure there's no duplicates.
Traversing the list becomes very slow, therefore QEMU init
From: "Daniel P. Berrange"
Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.
Signed-off-by: Daniel P. Berrange
Tested-by: Pavel Fedin
Sig
From: "Daniel P. Berrange"
Some users of QOM need to be able to iterate over properties
defined against an object instance. Currently they are just
directly using the QTAIL macros against the object properties
data structure.
This is bad because it exposes them to changes in the data
structure u
From: "Daniel P. Berrange"
Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.
Signed-off-by: Daniel P. Berrange
Tested-by: Pavel Fedin
Sig
From: Ildar Isaev
Property::offset field is calculated as a diff between two pointers:
arrayprop->prop.offset = eltptr - (void *)dev;
If offset is declared as int, this subtraction can cause type overflow,
thus leading to failure of the subsequent assertion:
assert(qdev_get_prop_ptr(dev, &
Hello Peter,
This is my late QOM (devices) patch queue. Please pull.
Regards,
Andreas
Cc: Peter Maydell
Cc: Daniel P. Berrange
Cc: Pavel Fedin
The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f:
hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-
From: "Daniel P. Berrange"
Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.
Signed-off-by: Daniel P. Berrange
Tested-by: Pavel Fedin
Sig
On 18 November 2015 at 16:08, Kevin Wolf wrote:
> The following changes since commit ab9b872ab3147faf3c04e91d525815b9139dd996:
>
> Merge remote-tracking branch
> 'remotes/mdroth/tags/qga-pull-2015-11-13-v2-tag' into staging (2015-11-18
> 12:47:29 +)
>
> are available in the git repository
Hm, a second run did not reproduce the error. If I can't get it to
happen again in a few hours of re-trying, I'll assume it was a fluke or
related to the host.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.ne
Hi Peter,
I must be missing something obvious, but I do not have the original
email thread (I was not subscribed at the time) and thus am finding it
exceedingly difficult to apply the patches using git-am.
I would happily test the patches otherwise.
Any guidance here?
François
On Wed, Nov 18,
From: "Daniel P. Berrange"
Some users of QOM need to be able to iterate over properties
defined against an object instance. Currently they are just
directly using the QTAIL macros against the object properties
data structure.
This is bad because it exposes them to changes in the data
structure u
From: "Daniel P. Berrange"
Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.
Signed-off-by: Daniel P. Berrange
Tested-by: Pavel Fedin
Sig
Hello Peter,
This is my late QOM (devices) patch queue. Please pull.
Regards,
Andreas
Cc: Peter Maydell
Cc: Daniel P. Berrange
Cc: Pavel Fedin
The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f:
hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-
From: Ildar Isaev
Property::offset field is calculated as a diff between two pointers:
arrayprop->prop.offset = eltptr - (void *)dev;
If offset is declared as int, this subtraction can cause type overflow,
thus leading to failure of the subsequent assertion:
assert(qdev_get_prop_ptr(dev, &
From: "Daniel P. Berrange"
Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.
Signed-off-by: Daniel P. Berrange
Tested-by: Pavel Fedin
Sig
No time to debug, invaliding...
** Changed in: qemu (Ubuntu)
Status: Incomplete => Invalid
** Information type changed from Public to Private
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/151
This package is causing a regression in lp:qa-regression-testing's
scripts/test-qemu.py.
I'm running the testcase one more time (after having verified that the
current package did not suffer the same failure), then I'm going to mark this
verification-failed.
--
You received this bug notification
On 11/18/2015 11:54 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> None of the visitor callbacks would set an error when testing
>> if an optional field was present; make this part of the interface
>> contract by eliminating the errp argument.
>>
>> The resulting generated code has a nice
Hi,
I've been looking at PCI passthrough using vfio-pci and hoping that it can
use the Intel IOMMU emulation in the guest to pin-pages in an on-demand
nature, rather than pinning the entire guest memory as vfio-pci does now.
Unfortunately vfio-pci and the intel iommu virtualization don't seem to
p
On 11/18/2015 11:46 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Previously, working with alternates required two lookup arrays
>> and some indirection: for type Foo, we created Foo_qtypes[]
>> which maps each qtype to a value of the generated FooKind enum,
>> then look up that value in
On Wed, 2015-11-18 at 13:34 +0100, Paolo Bonzini wrote:
../..
> Tabs for indentation. There are other occurrences in the patch.
Ooops. sorry, missed those. Do you need a respin ?
> Apart from this,
>
> Reviewed-by: Paolo Bonzini
> Acked-by: Paolo Bonzini
>
> > if (ret && !qbu
On 11/18/2015 11:48 AM, Daniel P. Berrange wrote:
> This integrates support for QIOChannelTLS object in the TCP
> chardev backend. If the 'tls-creds=NAME' option is passed with
> the '-chardev tcp' argument, then it will setup the chardev
> such that the client is required to establish a TLS handsh
Do other iso's, like http://archive.ubuntu.com/ubuntu/dists/wily/main
/installer-amd64/current/images/netboot/mini.iso also cause this for
you?
(I ran with upstream qemu GIT HEAD using that iso and was unable to
reproduce)
--
You received this bug notification because you are a member of qemu-
d
The code under the TUN_ASYNCHRONOUS_WRITES path makes two incorrect
assumptions about the behaviour of the WriteFile API for overlapped
file handles. First, WriteFile does not update the
lpNumberOfBytesWritten parameter when the write completes
asynchronously (the number of bytes written is known o
In order to find a named tap device, get_device_guid() enumerates children of
HKLM\SYSTEM\CCS\Control\Network\{4D36E972-E325-11CE-BFC1-08002BE10318}
(aka NETWORK_CONNECTIONS_KEY). For each child, it then looks for a
"Connection" subkey, but if this key doesn't exist, it aborts the
entire search. Th
Minor revisions to the second patch in the series.
Cheers,
Andrew
Andrew Baumann (2):
tap-win32: skip unexpected nodes during registry enumeration
tap-win32: disable broken async write path
net/tap-win32.c | 49 ++---
1 file changed, 38 insertions
On Wed, Nov 18, 2015 at 10:16 AM, Andrew Baumann
wrote:
> Hi Peter,
>
> Thanks for your feedback!
>
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Tuesday, 17 November 2015 23:51
>> I haven't looked beyond the diffstat yet, but a top level
>> architectural comment, I only se
Meh, this was still missing the uncommited changes for the nsid
off by one vs the array index:
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 360be71..4f768d5 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -499,10 +499,10 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n,
NvmeIdent
1 - 100 of 317 matches
Mail list logo
