On Wed, 2015-11-18 at 13:34 +0100, Paolo Bonzini wrote: ../..
> Tabs for indentation. There are other occurrences in the patch. Ooops. sorry, missed those. Do you need a respin ? > Apart from this, > > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > Acked-by: Paolo Bonzini <pbonz...@redhat.com> > > > if (ret && !qbus_is_full(ret)) { > > return ret; /* a descendant matches and isn't > > full */ > > } > > @@ -436,7 +439,7 @@ static BusState *qbus_find(const char *path, > > Error **errp) > > assert(!path[0]); > > elem[0] = len = 0; > > } > > - bus = qbus_find_recursive(sysbus_get_default(), elem, > > NULL); > > + bus = qbus_find_recursive(sysbus_get_default(), elem, > > NULL, NULL); > > if (!bus) { > > error_setg(errp, "Bus '%s' not found", elem); > > return NULL; > > @@ -542,7 +545,7 @@ DeviceState *qdev_device_add(QemuOpts *opts, > > Error **errp) > > return NULL; > > } > > } else if (dc->bus_type != NULL) { > > - bus = qbus_find_recursive(sysbus_get_default(), NULL, dc- > > >bus_type); > > + bus = qbus_find_recursive(sysbus_get_default(), NULL, > > dc->bus_type, opts); > > if (!bus || qbus_is_full(bus)) { > > error_setg(errp, "No '%s' bus found for device '%s'", > > dc->bus_type, driver); > >