Re: [Qemu-devel] RFC: raspberry pi / pi2 / Windows-on-ARM support

2015-11-17 Thread Peter Crosthwaite
On Mon, Nov 16, 2015 at 2:22 PM, Andrew Baumann wrote: > Hi all, > > I have been working on Raspberry Pi 2 emulation, building on the previous > work of Gregory Estrade, Stefan Weil and others on the original Raspberry Pi > target. My current working tree (based off a recent master) is here: >

Re: [Qemu-devel] [PATCH qemu] spapr: Add /system-id

2015-11-17 Thread Alexey Kardashevskiy
On 11/09/2015 07:47 PM, David Gibson wrote: On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote: Section B.6.2.1 Root Node Properties of PAPR specification defines a set of properties which shall be present in the device tree root, one of these properties is "system-id" which "s

Re: [Qemu-devel] [PATCH 2/2] tap-win32: disable broken async write path

2015-11-17 Thread Stefan Weil
Am 17.11.2015 um 20:09 schrieb Andrew Baumann: > The code under the TUN_ASYNCHRONOUS_WRITES path makes two incorrect > assumptions about the behaviour of the WriteFile API for overlapped > file handles. First, WriteFile does not update the > lpNumberOfBytesWritten parameter when the overlapped para

Re: [Qemu-devel] [PATCH 1/2] tap-win32: skip unexpected nodes during registry enumeration

2015-11-17 Thread Stefan Weil
Am 17.11.2015 um 20:09 schrieb Andrew Baumann: > In order to find a named tap device, get_device_guid() enumerates children of > HKLM\SYSTEM\CCS\Control\Network\{4D36E972-E325-11CE-BFC1-08002BE10318} > (aka NETWORK_CONNECTIONS_KEY). For each child, it then looks for a > "Connection" subkey, but if

Re: [Qemu-devel] [PATCH 1/1] parallels: add format spec

2015-11-17 Thread Vladimir Sementsov-Ogievskiy
On 18.11.2015 09:39, Eric Blake wrote: On 11/17/2015 11:15 PM, Vladimir Sementsov-Ogievskiy wrote: You may want to compare to the qcow2 spec, which also lists expected byte offsets for each field (rather than having to count how many earlier fields of which widths were specified). I've compare

Re: [Qemu-devel] [PATCH v3 3/4] usb-mtp: Add support for inotify based file monitoring

2015-11-17 Thread Gerd Hoffmann
Hi, > >> -QLIST_FOREACH(iter, &o->children, list) { > >> +QLIST_FOREACH_SAFE(iter, &o->children, list, next) { > >> handles[i++] = iter->handle; > >> } > > > > No need for SAFE here, you don't change the list. > > Isn't the SAFE variant better for the case where a inotify

Re: [Qemu-devel] [PATCH v11 27/28] qapi: Move duplicate enum value checks to schema check()

2015-11-17 Thread Eric Blake
On 11/12/2015 08:46 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Similar to the previous commit, move the detection of a collision >> in enum values from parse time to QAPISchemaEnumType.check(). >> This happens to also detect collisions in union branch names >> mapping to the same enum

Re: [Qemu-devel] [PATCH 1/1] parallels: add format spec

2015-11-17 Thread Eric Blake
On 11/17/2015 11:15 PM, Vladimir Sementsov-Ogievskiy wrote: >> You may want to compare to the qcow2 spec, which also lists expected >> byte offsets for each field (rather than having to count how many >> earlier fields of which widths were specified). > > I've compared qed spec with qcow2 spec an

Re: [Qemu-devel] [PATCH v11 21/28] qapi: Convert qtype_code into qapi enum type

2015-11-17 Thread Eric Blake
On 11/12/2015 06:16 AM, Markus Armbruster wrote: > We have one in visit_needed(), and we use its is_implicit() to skip > implicit object types. We could use entity.is_builtin() to skip (some) > builtins, and handle them elsewhere, but that doesn't feel like an > improvement over your code. > > L

Re: [Qemu-devel] [PATCH 1/1] parallels: add format spec

2015-11-17 Thread Vladimir Sementsov-Ogievskiy
On 17.11.2015 18:54, Eric Blake wrote: On 11/16/2015 04:52 AM, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy This specifies Parallels image format as implemented in Parallels Cloud Server 6.10 Are we the canonical location of the specification? If not, do we risk getting out of sy

Re: [Qemu-devel] [PATCH V5 0/8] Xilinx DisplayPort.

2015-11-17 Thread Alistair Francis
On Mon, Oct 19, 2015 at 1:13 PM, Frederic Konrad wrote: > On 16/10/2015 23:57, Alistair Francis wrote: >> On Fri, Oct 16, 2015 at 6:41 AM, wrote: >>> From: KONRAD Frederic >>> >>> This is the fifth version of this patch-set of the implementation of the >>> Xilinx >>> DisplayPort and DPDMA. >>>

Re: [Qemu-devel] [PATCH v7 22/24] block: Rewrite bdrv_close_all()

2015-11-17 Thread Fam Zheng
On Mon, 11/16 17:15, Max Reitz wrote: > >> @@ -1971,13 +1969,44 @@ static void bdrv_close(BlockDriverState *bs) > >> void bdrv_close_all(void) > >> { > >> BlockDriverState *bs; > >> +AioContext *aio_context; > >> +int original_refcount = 0; > >> > >> -QTAILQ_FOREACH(bs, &bdrv_s

Re: [Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close())

2015-11-17 Thread Fam Zheng
On Tue, 11/17 12:05, John Snow wrote: > Still the subject of debate on-list, but the thought is roughly this: Thanks for summerizing this! > > Bitmaps will be able to flush-to-file on close. (If they have no > persistence data, it's a no-op (maybe.)) This might mean being flushed > to their own

[Qemu-devel] [PATCH v3 3/3] target-i386: add pkeys support for vm migration

2015-11-17 Thread Huaitong Han
This patch adds pkeys support for vm migration. Signed-off-by: Huaitong Han diff --git a/target-i386/machine.c b/target-i386/machine.c index a0df64b..1b190c7 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -725,6 +725,26 @@ static const VMStateDescription vmstate_xss = {

[Qemu-devel] [PATCH v3 0/3] target-i386: add memory protection-key support

2015-11-17 Thread Huaitong Han
Changes in v3: *Fix cpuid_7_0_ecx_feature_name error. Changes in v2: *Fix memcpy error for xsave state. *Fix TCG_7_0_ECX_FEATURES to 0. *Make subjects more readable. The protection-key feature provides an additional mechanism by which IA-32e paging controls access to usermode addresses. Hardware

[Qemu-devel] [PATCH v3 2/3] target-i386: add pkeys support for xsave state handling

2015-11-17 Thread Huaitong Han
This patch adds pkeys support for xsave state handling. Signed-off-by: Huaitong Han diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 3c11e02..456cb3b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -487,6 +487,8 @@ static const ExtSaveArea ext_save_areas[] = { .off

[Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling

2015-11-17 Thread Huaitong Han
This patch adds pkeys support for cpuid handling. Signed-off-by: Huaitong Han diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 4d1b085..3c11e02 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -264,6 +264,17 @@ static const char *cpuid_7_0_ebx_feature_name[] = { NULL, NULL,

Re: [Qemu-devel] [PATCH v4 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-11-17 Thread Gabriel L. Somlo
On Tue, Nov 17, 2015 at 04:14:42PM -0600, Rob Herring wrote: > On Mon, Nov 16, 2015 at 2:38 AM, Paolo Bonzini wrote: > > > > > > On 15/11/2015 03:07, Rob Herring wrote: > >> We generally don't want DT docs to depend on other kernel documentation. > > > > DT docs do not contain a copy of the data s

Re: [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features

2015-11-17 Thread Jason Wang
On 11/18/2015 10:08 AM, Jason Wang wrote: > > On 11/17/2015 10:57 PM, Michael S. Tsirkin wrote: >> Some feratures (such as ctrl vq) are supported >> by qemu without need to communicate with the >> backend. >> >> Drop them from the feature mask so we set them >> unconditionally. >> >> Reported-by:

Re: [Qemu-devel] [PATCH] vhost-user: ignore qemu-only features

2015-11-17 Thread Jason Wang
On 11/17/2015 10:57 PM, Michael S. Tsirkin wrote: > Some feratures (such as ctrl vq) are supported > by qemu without need to communicate with the > backend. > > Drop them from the feature mask so we set them > unconditionally. > > Reported-by: Victor Kaplansky > Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 0/2] net/tap-win32 bugfixes

2015-11-17 Thread Jason Wang
On 11/18/2015 03:09 AM, Andrew Baumann wrote: > Since I just discovered that you're in feature freeze, I wanted to > submit two smallish bug fixes for the win32 tap device. The changes > are independent, but without both fixes the tap device is unusable > (for me, at least!). > > Cheers, > Andrew

Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM

2015-11-17 Thread Xiao Guangrong
Ping... Do you have any comment on this patchset? Could it be applied to somewhere if it is okay for you? Thanks! On 11/16/2015 06:50 PM, Xiao Guangrong wrote: This patchset can be found at: https://github.com/xiaogr/qemu.git nvdimm-v8 It is based on pci branch on Michael's tree and t

Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

2015-11-17 Thread Hollis Blanchard
On 11/13/2015 02:23 AM, Stefan Hajnoczi wrote: On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: Recording the MemoryRegion pointers isn't helpful, especially since no trace data allows us to correlate those pointers to devices. Instead, record the MemoryRegion name. Signed-off-

Re: [Qemu-devel] [PATCH v2 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off

2015-11-17 Thread Eric Blake
On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > The VNC code for interpreting QemuOpts does not currently > distinguish between ipv4/ipv6 being omitted, and being > set to 'off', because historically the 'ipv4' and 'ipv6' > options were just flags which did not accept a value. > > The upshot i

Re: [Qemu-devel] [PATCH v2 4/5] sockets: remove use of QemuOpts from socket_dgram

2015-11-17 Thread Eric Blake
On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > The socket_dgram method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_dgram_opts helper method. By converting the latter to > use QAPI SocketAddress directly, the QemuOpts conversion > step can b

Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/77] ppc: tlbie, tlbia and tlbisync are HV only

2015-11-17 Thread Benjamin Herrenschmidt
On Mon, 2015-11-16 at 21:21 +1100, Benjamin Herrenschmidt wrote: > > Ah you are right. I do have second thoughts about that previous patch > now that you mention it however. In the real MSR, HV and PR are > independant, I wonder if I'm better off making the check explicit... > > The reason I did

Re: [Qemu-devel] [PATCH v3 3/4] usb-mtp: Add support for inotify based file monitoring

2015-11-17 Thread Bandan Das
Gerd Hoffmann writes: > Hi, > >> +#ifndef __linux__ >> +return 1; >> +#endif > > Hmm? Shouldn't the stubs avoid these kinds of #ifdefs? > >> -QLIST_FOREACH(iter, &o->children, list) { >> +QLIST_FOREACH_SAFE(iter, &o->children, list, next) { >> handles[i++] = iter->handle;

[Qemu-devel] [PATCH] vfio/pci-quirks: Only quirk to size of PCI config space

2015-11-17 Thread Alex Williamson
For quirks that support the full PCIe extended config space, limit the quirk to only the size of config space available through vfio. This allows host systems with broken MMCONFIG regions to still make use of these quirks without generating bad address faults trying to access beyond the end of con

Re: [Qemu-devel] [PATCH v3 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-17 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > >> There's no indication of any sort that i440fx doesn't support >> "iommu=on" >> >> Reviewed-by: Eric Blake >> Signed-off-by: Bandan Das >> --- >> hw/pci-host/piix.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/hw/pci-host/

[Qemu-devel] [PULL for-2.5 3/3] makefile: fix w32 install target for qemu-ga

2015-11-17 Thread Michael Roth
fafcaf1 added a 'qemu-ga' install target on w32, which can be used in place of the existing qemu-ga.exe target to also handle dealing with other components such as DLLs for VSS/fsfreeze and generating an MSI package if appropriate configure options are present. As part of that, qemu-ga$(EXESUF) wa

[Qemu-devel] [PULL v2 for-2.5 0/3] qemu-ga patch queue for 2.5

2015-11-17 Thread Michael Roth
The following changes since commit c27e9014d56fa4880e7d741275d887c3a5949997: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20151116-1' into staging (2015-11-17 12:34:07 +) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2015-11-13-v2-

[Qemu-devel] [PULL for-2.5 1/3] qga: fix for default env processing for guest-exec

2015-11-17 Thread Michael Roth
From: Yuri Pudgorodskiy envp == NULL must be passed inside gspawn() if it was not passed with the command line. Original code inherits environment from the QGA, which is wrong. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth Signed-off-by: Michael Roth --- qg

[Qemu-devel] [PULL for-2.5 2/3] qga: allow to lookup in PATH from the passed envp for guest-exec

2015-11-17 Thread Michael Roth
From: Yuri Pudgorodskiy This was original behaviour before GLIB gspawn() rework and we rely on this behaviour. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth * add version check (2.33.2) for G_SPAWN_SEARCH_PATH_FROM_ENVP Signed-off-by: Michael Roth --- qga/c

Re: [Qemu-devel] [PATCH for-2.5] makefile: fix w32 install target for qemu-ga

2015-11-17 Thread Michael Roth
Quoting Stefan Weil (2015-11-16 16:03:49) > This mail arrived with one day delay (obviously caused by the > mailing list server). Please see my comments below. > > Am 15.11.2015 um 17:12 schrieb Michael Roth: > > fafcaf1 added a 'qemu-ga' install target on w32, which can be used > > in place of th

Re: [Qemu-devel] [PATCH v2 3/5] sockets: remove use of QemuOpts from socket_connect

2015-11-17 Thread Eric Blake
On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > The socket_connect method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_connect_opts/unix_connect_opts helper methods. By > converting the latter to use QAPI SocketAddress directly, > the QemuOpt

Re: [Qemu-devel] [PATCH v2 2/5] sockets: remove use of QemuOpts from socket_listen

2015-11-17 Thread Eric Blake
On 11/17/2015 10:00 AM, Daniel P. Berrange wrote: > The socket_listen method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_listen_opts/unix_listen_opts helper methods. By > converting the latter to use QAPI SocketAddress directly, > the QemuOpts c

Re: [Qemu-devel] [PATCH v4 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-11-17 Thread Rob Herring
On Mon, Nov 16, 2015 at 2:38 AM, Paolo Bonzini wrote: > > > On 15/11/2015 03:07, Rob Herring wrote: >> We generally don't want DT docs to depend on other kernel documentation. > > DT docs do not contain a copy of the data sheets, either. There is no > reason to say how to use the device (and even

Re: [Qemu-devel] [PATCH] target-arm: Priority masking with basepri on v7m

2015-11-17 Thread Francois Baldassari
Thanks for the swift reply. Michael's changes look very good indeed. Thank you for pointing them out. No need to consider this any further then. Cheers, François. On Tue, Nov 17, 2015 at 1:49 PM, Peter Maydell wrote: > On 17 November 2015 at 21:40, François Baldassari > wrote: > > On armv7m

Re: [Qemu-devel] [PATCH] target-arm: Priority masking with basepri on v7m

2015-11-17 Thread Peter Maydell
On 17 November 2015 at 21:40, François Baldassari wrote: > On armv7m mcus, the BASEPRI register can be set to mask interrupts > above a certain priority. > > This changeset implements that functionality by way of the NVIC which > ultimately sets the interrupt mask in the GIC. > > Signed-off-by: Fr

[Qemu-devel] [PATCH] target-arm: Priority masking with basepri on v7m

2015-11-17 Thread François Baldassari
On armv7m mcus, the BASEPRI register can be set to mask interrupts above a certain priority. This changeset implements that functionality by way of the NVIC which ultimately sets the interrupt mask in the GIC. Signed-off-by: François Baldassari --- hw/intc/arm_gic.c | 2 +- hw/intc/armv7m

Re: [Qemu-devel] [PATCH 3/3] exec: silence hugetlbfs warning under qtest

2015-11-17 Thread Marc-André Lureau
nack, this isn't enough to silence the warning, as vhost-user-test uses -machine accel=tcg On Mon, Nov 16, 2015 at 6:23 PM, wrote: > From: Marc-André Lureau > > vhost-user-test prints a warning. A test should not need to run on > hugetlbfs, let's silence the warning under qtest. Unfortunately,

[Qemu-devel] [PULL 4/6] ide: orphan all buffered requests on DMA cancel

2015-11-17 Thread John Snow
From: Peter Lieven If the guests canceles a DMA request we can prematurely invoke all callbacks of buffered requests and flag all them as orphaned. Ideally this avoids the need for draining all requests. For CDROM devices this works in 100% of all cases. Signed-off-by: Peter Lieven Reviewed-by:

[Qemu-devel] [PULL 5/6] ide: enable buffered requests for ATAPI devices

2015-11-17 Thread John Snow
From: Peter Lieven Signed-off-by: Peter Lieven Reviewed-by: Fam Zheng Message-id: 1447345846-15624-6-git-send-email...@kamp.de Signed-off-by: John Snow --- hw/ide/atapi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index eb0d9

[Qemu-devel] [PULL 3/6] ide: add support for IDEBufferedRequest

2015-11-17 Thread John Snow
From: Peter Lieven this patch adds a new aio readv compatible function which copies all data through a bounce buffer. These buffered requests can be flagged as orphaned which means that their original callback has already been invoked and the request has just not been completed by the backend sto

[Qemu-devel] [PULL 0/6] Ide patches

2015-11-17 Thread John Snow
The following changes since commit c27e9014d56fa4880e7d741275d887c3a5949997: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20151116-1' into staging (2015-11-17 12:34:07 +) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for

[Qemu-devel] [PULL 2/6] block: add blk_abort_aio_request

2015-11-17 Thread John Snow
From: Peter Lieven Signed-off-by: Peter Lieven Reviewed-by: Fam Zheng Message-id: 1447345846-15624-3-git-send-email...@kamp.de Signed-off-by: John Snow --- block/block-backend.c | 17 + include/sysemu/block-backend.h | 3 +++ 2 files changed, 12 insertions(+), 8 dele

[Qemu-devel] [PULL 6/6] ide: enable buffered requests for PIO read requests

2015-11-17 Thread John Snow
From: Peter Lieven Signed-off-by: Peter Lieven Reviewed-by: Fam Zheng Message-id: 1447345846-15624-7-git-send-email...@kamp.de Signed-off-by: John Snow --- hw/ide/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 1470737..da3baa

[Qemu-devel] [PULL 1/6] ide/atapi: make PIO read requests async

2015-11-17 Thread John Snow
From: Peter Lieven PIO read requests on the ATAPI interface used to be sync blk requests. This has two significant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not complete (e.g. due to an unresponsive storage) Qemu hangs completely.

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Paolo Bonzini
On 17/11/2015 19:41, Markus Armbruster wrote: > Peter Maydell writes: > >> On 17 November 2015 at 18:21, Paolo Bonzini wrote: >>> >>> >>> On 17/11/2015 19:19, Peter Maydell wrote: That doesn't seem like more than half-good news to me. In particular, if ubsan is still diagnosing these

[Qemu-devel] [PULL 2/2] target-i386: Disable rdtscp on Opteron_G* CPU models

2015-11-17 Thread Eduardo Habkost
KVM can't virtualize rdtscp on AMD CPUs yet, so there's no point in enabling it by default on AMD CPU models, as all we are getting are confused users because of the "host doesn't support requested feature" warnings. Disable rdtscp on Opteron_G* models, but keep compatibility on pc-*-2.4 and older

[Qemu-devel] [PULL 0/2] X86 fixes, 2015-11-17

2015-11-17 Thread Eduardo Habkost
The following changes since commit 9be060f5278dc0d732ebfcf2bf0a293f88b833eb: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2015-11-17 11:33:38 +) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request for

[Qemu-devel] [PULL 1/2] target-i386: Fix mulx for identical target regs

2015-11-17 Thread Eduardo Habkost
From: Richard Henderson The Intel specification clearly indicates that the low part of the result is written first and the high part of the result is written second; thus if ModRM:reg and VEX. are identical, the final result should be the high part of the result. At present, TCG may either p

[Qemu-devel] [PATCH 1/2] tap-win32: skip unexpected nodes during registry enumeration

2015-11-17 Thread Andrew Baumann
In order to find a named tap device, get_device_guid() enumerates children of HKLM\SYSTEM\CCS\Control\Network\{4D36E972-E325-11CE-BFC1-08002BE10318} (aka NETWORK_CONNECTIONS_KEY). For each child, it then looks for a "Connection" subkey, but if this key doesn't exist, it aborts the entire search. Th

[Qemu-devel] [PATCH 2/2] tap-win32: disable broken async write path

2015-11-17 Thread Andrew Baumann
The code under the TUN_ASYNCHRONOUS_WRITES path makes two incorrect assumptions about the behaviour of the WriteFile API for overlapped file handles. First, WriteFile does not update the lpNumberOfBytesWritten parameter when the overlapped parameter is non-NULL (the number of bytes written is known

[Qemu-devel] [PATCH 0/2] net/tap-win32 bugfixes

2015-11-17 Thread Andrew Baumann
Since I just discovered that you're in feature freeze, I wanted to submit two smallish bug fixes for the win32 tap device. The changes are independent, but without both fixes the tap device is unusable (for me, at least!). Cheers, Andrew

Re: [Qemu-devel] [PATCH] configure: preserve various environment variables in config.status

2015-11-17 Thread Eric Blake
On 11/17/2015 10:59 AM, Daniel P. Berrange wrote: > Suggested in > > https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03298.html > > The config.status script is auto-generated by configure upon > completion. The intention is that config.status can be later > invoked by the developer to

Re: [Qemu-devel] block/vpc: Fix vhd extra sectors issue

2015-11-17 Thread Eric Blake
On 11/16/2015 01:58 PM, Max Reitz wrote: > PS: If possible, the "From: " header in an emailed patch should match > the Signed-off-by line. I think. It doesn't state that in > http://wiki.qemu.org/Contribute/SubmitAPatch, but the commit looks > strange otherwise. So I guess if it isn't reasonably p

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Markus Armbruster
Peter Maydell writes: > On 17 November 2015 at 18:21, Paolo Bonzini wrote: >> >> >> On 17/11/2015 19:19, Peter Maydell wrote: >>> That doesn't seem like more than half-good news to me. In particular, >>> if ubsan is still diagnosing these cases and they're still a >>> problem in some constant ex

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Peter Maydell
On 17 November 2015 at 18:36, Paolo Bonzini wrote: > On 17/11/2015 19:24, Peter Maydell wrote: >> But if "-fwrapv" means "this dialect of C makes shifts of >> negative numbers well defined and OK" then "-1 << 31" >> should be fine and should not provoke a warning (whether in >> a constant expressi

Re: [Qemu-devel] [PATCH] configure: preserve various environment variables in config.status

2015-11-17 Thread Stefan Weil
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Am 17.11.2015 um 18:59 schrieb Daniel P. Berrange: > Suggested in > > https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03298.html > > The config.status script is auto-generated by configure upon > completion. The intention is that config.s

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Paolo Bonzini
On 17/11/2015 19:24, Peter Maydell wrote: > On 17 November 2015 at 18:21, Paolo Bonzini wrote: >> >> >> On 17/11/2015 19:19, Peter Maydell wrote: >>> That doesn't seem like more than half-good news to me. In particular, >>> if ubsan is still diagnosing these cases and they're still a >>> problem

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Peter Maydell
On 17 November 2015 at 18:21, Paolo Bonzini wrote: > > > On 17/11/2015 19:19, Peter Maydell wrote: >> That doesn't seem like more than half-good news to me. In particular, >> if ubsan is still diagnosing these cases and they're still a >> problem in some constant expressions > > Constant expressio

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Markus Armbruster
Paolo Bonzini writes: > On 17/11/2015 18:39, Markus Armbruster wrote: >> The kernel switched from -fwrapv to -fno-strict-overflow in '09, because >> -fwrapv was buggy in gcc 4.1 (already old then, completely irrelevant >> now), and because it "seems to be much less disturbing to gcc too: the >> d

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/17/15 16:47, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> I accept this is a defensible, maybe even reasonable choice to make in >>> the QEMU project. On the other hand, I personally cannot stop hating >>> shifting negative values (any direction) -- indee

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Paolo Bonzini
On 17/11/2015 19:19, Peter Maydell wrote: > That doesn't seem like more than half-good news to me. In particular, > if ubsan is still diagnosing these cases and they're still a > problem in some constant expressions Constant expressions are standardese for e.g. static int x = 1 << 31; It doesn

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Peter Maydell
On 17 November 2015 at 17:45, Paolo Bonzini wrote: > In the meanwhile I got some good news from the GCC folks: > >>> I think we should remove the ", but this is subject to change" in >>> implement-c.texi (while replacing it with noting that ubsan will still >>> diagnose such cases, and they will a

Re: [Qemu-devel] Possible bug when executing an instruction.

2015-11-17 Thread Eric Blake
On 11/17/2015 10:14 AM, John Snow wrote: > > > On 11/16/2015 08:44 PM, Toni Nedialkov wrote: >> There is some evidence to suggest that the instruction mulx rsp,rsp,rdx >> causes a segfault in QEMU. >> >> Was wondering if anyone would be kind enough to verify. And since I am >> not familiar with t

Re: [Qemu-devel] [PATCH 05/18] armv7m: expand NVIC state

2015-11-17 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > Expand the NVIC to fully support -M priorities and masking. > Doesn't use GIC code. > > Move some state to ARMCPU to allow calculation of exception masking. > > Add storage for PRIGROUP to configure group/sub-group split. > Track group and s

Re: [Qemu-devel] [PATCH 15/18] arm: gic: Remove references to NVIC

2015-11-17 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > armv7m_nvic.c no longer relies on the GIC. > Remove REV_NVIC and conditionals which use it. > > Signed-off-by: Michael Davidsaver > --- > hw/intc/arm_gic.c| 14 +++--- > hw/intc/arm_gic_common.c | 23 ---

[Qemu-devel] [PATCH] configure: preserve various environment variables in config.status

2015-11-17 Thread Daniel P. Berrange
Suggested in https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03298.html The config.status script is auto-generated by configure upon completion. The intention is that config.status can be later invoked by the developer to re-detect the same environment that configure originally used. T

Re: [Qemu-devel] [PATCH 09/18] armv7m: NVIC update vmstate

2015-11-17 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > Signed-off-by: Michael Davidsaver > --- > hw/intc/armv7m_nvic.c | 64 > +-- > 1 file changed, 62 insertions(+), 2 deletions(-) > > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c

Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Christoph Hellwig
On Tue, Nov 17, 2015 at 05:41:04PM +, Keith Busch wrote: > On Tue, Nov 17, 2015 at 09:33:11AM -0800, Busch, Keith wrote: > > I accidently deleted my comment. Here's what it said: > > > > +list = g_malloc(data_len); > > +for (i = 0; i < n->num_namespaces; i++) { > > +if (i <= mi

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Paolo Bonzini
On 17/11/2015 18:39, Markus Armbruster wrote: > The kernel switched from -fwrapv to -fno-strict-overflow in '09, because > -fwrapv was buggy in gcc 4.1 (already old then, completely irrelevant > now), and because it "seems to be much less disturbing to gcc too: the > difference in the generated c

Re: [Qemu-devel] [PATCH 00/14] target-i386: Implement MPX extension

2015-11-17 Thread Paolo Bonzini
On 09/07/2015 10:17, Richard Henderson wrote: > I'm still in the process of testing this, as there's no code > written for it yet and hardware to compare against doesn't > start shipping until (probably) August. > > But in the meantime there are a number of holes that I found > in XSAVE support

Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Keith Busch
On Tue, Nov 17, 2015 at 09:33:11AM -0800, Busch, Keith wrote: > I accidently deleted my comment. Here's what it said: > > +list = g_malloc(data_len); > +for (i = 0; i < n->num_namespaces; i++) { > +if (i <= min_nsid) { > +continue; > +} > +list[i] = i; >

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Markus Armbruster
Paolo Bonzini writes: > It seems like there's no good reason for the compiler to exploit the > undefinedness of left shifts. GCC explicitly documents that they do not > use at all this possibility and, while they also say this is subject > to change, they have been saying this for 10 years (sinc

Re: [Qemu-devel] [PATCH V2 1/3] target-i386: add pkeys support for cpuid handling

2015-11-17 Thread Paolo Bonzini
On 16/11/2015 08:52, Huaitong Han wrote: > This patch adds pkeys support for cpuid handling. > > Signed-off-by: Huaitong Han > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 4d1b085..2ff73ee 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -264,6 +264,17 @@ static

Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Busch, Keith
> Thanks for the fix! Minor comment below, no need to fix. > > Acked-by: Keith Busch I accidently deleted my comment. Here's what it said: +list = g_malloc(data_len); +for (i = 0; i < n->num_namespaces; i++) { +if (i <= min_nsid) { +continue; +} +list

Re: [Qemu-devel] [PATCH 04/18] armv7m: Explicit error for bad vector table

2015-11-17 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > Give an explicit error and abort when a load > from VECBASE fails. Otherwise would likely > jump to 0, which for v7-m holds the reset stack > pointer address. > > Signed-off-by: Michael Davidsaver > --- > target-arm/helper.c | 12

Re: [Qemu-devel] (no subject)

2015-11-17 Thread Paolo Bonzini
On 17/11/2015 14:08, Christoph Hellwig wrote: > below is a fix for a bug in the qemu NVMe identify implementation that's > causing us some trouble with an updated Linux driver. We'll have to > blacklist the existing Qemu device ID for it, so I wonder how we can > advertize a fixed controller. M

Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Keith Busch
On Tue, Nov 17, 2015 at 02:08:09PM +0100, Christoph Hellwig wrote: > NVMe 1.1 requires devices to implement a Namespace List subcommand of > the identify command. Qemu not only not implements this features, but > also misinterprets it as an Identify Controller request. Due to this > any OS trying

Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds

2015-11-17 Thread Daniel P. Berrange
On Fri, Nov 13, 2015 at 02:01:12PM +0100, Gerd Hoffmann wrote: > On Fr, 2015-11-13 at 11:31 +, Daniel P. Berrange wrote: > > Developers on 64-bit machines will often try to perform a > > 32-bit build of QEMU by running > > > > ./configure --extra-cflags="-m32" > > > > Unfortunately if PKG_C

[Qemu-devel] [PATCH ipxe] build: Enable IPv6 for qemu

2015-11-17 Thread Cole Robinson
--- I assume it's fine to enable... A fedora user requested it here: https://bugzilla.redhat.com/show_bug.cgi?id=1280318 src/config/qemu/general.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/config/qemu/general.h b/src/config/qemu/general.h index 30f60d3..61d0ad4 100644 --- a/src/

Re: [Qemu-devel] [PATCH 03/18] armv7m: Complain about incorrect exception table entries.

2015-11-17 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > For -M These should always be thumb mode. > Log a message if this is seen. > > Signed-off-by: Michael Davidsaver This one's not really correct, I'm afraid (though the spec-mandated behaviour is a bit subtle). > --- > target-arm/helper.c

Re: [Qemu-devel] i2c-tiny-usb noob question

2015-11-17 Thread Paolo Bonzini
On 17/11/2015 17:25, Tim Sander wrote: > I can instantiate my i2c-tiny-usb with the following command line option: > -device usb-i2c-tiny,id=i2c-0 > > Now i would like to add child devices to this device instance. Unfortunatly i > could not find out how to add e.g. the tmp105 sensor to this i2c

Re: [Qemu-devel] Possible bug when executing an instruction.

2015-11-17 Thread John Snow
On 11/16/2015 08:44 PM, Toni Nedialkov wrote: > There is some evidence to suggest that the instruction mulx rsp,rsp,rdx > causes a segfault in QEMU. > > Was wondering if anyone would be kind enough to verify. And since I am > not familiar with the bug reporting process, I am posting here. > > T

[Qemu-devel] [PATCH v2] target-mips: Fix exceptions while UX=0

2015-11-17 Thread James Hogan
Commit 01f728857941 ("target-mips: Status.UX/SX/KX enable 32-bit address wrapping") added a new hflag MIPS_HFLAG_AWRAP, which indicates that 64-bit addressing is disallowed in the current mode, so hflag users don't need to worry about the complexities of working that out, for example checking both

Re: [Qemu-devel] [PATCH 01/18] armv7m: MRS/MSR handle unprivileged access

2015-11-17 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > The MRS and MSR instruction handling isn't checking > the current permission level. > > Signed-off-by: Michael Davidsaver > --- > target-arm/helper.c | 79 > + > 1 file changed, 37 inser

Re: [Qemu-devel] [PATCH 00/18] Fix exception handling and msr/mrs access

2015-11-17 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > This series grew from a previous incorrect patch attempting to fix > some incorrect behavior. After spending some time going through the > arch. ref. manual for v7-M I think I understand better how this should > work and have made a number

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Paolo Bonzini
On 17/11/2015 17:54, Laszlo Ersek wrote: > I'm not worried. I hate it for the mental load it represents. > > For me, the fact that the negative sign is encoded (with *any* kind of > representation) within the bit pattern subject to shifting, makes the > negative sign *inherently* incompatible wi

[Qemu-devel] Closing Bitmaps (Was: Re: [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close())

2015-11-17 Thread John Snow
On 11/16/2015 11:22 PM, Fam Zheng wrote: > On Mon, 11/16 12:07, John Snow wrote: >> >> >> On 11/15/2015 08:27 PM, Fam Zheng wrote: >>> On Fri, 11/13 17:49, John Snow wrote: On 11/12/2015 01:23 AM, Fam Zheng wrote: > On Mon, 11/09 23:39, Max Reitz wrote: >> bdrv_delete() is

[Qemu-devel] [PATCH v2 4/5] sockets: remove use of QemuOpts from socket_dgram

2015-11-17 Thread Daniel P. Berrange
The socket_dgram method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_dgram_opts helper method. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be eliminated. This also fixes the problem where ipv4=off &&

[Qemu-devel] [PATCH for 2.5 1/1] parallels: dirty BAT properly for continuous allocations

2015-11-17 Thread Denis V. Lunev
From: Vladimir Sementsov-Ogievskiy This patch marks part of the BAT dirty properly. There is a possibility that multy-block allocation could have one block allocated on one BAT page and next block on the next page. The code without the patch could not save updated position to the file. Signed-of

[Qemu-devel] [PATCH v2 3/5] sockets: remove use of QemuOpts from socket_connect

2015-11-17 Thread Daniel P. Berrange
The socket_connect method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_connect_opts/unix_connect_opts helper methods. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be eliminated This also fixes the pro

[Qemu-devel] [PATCH v2 2/5] sockets: remove use of QemuOpts from socket_listen

2015-11-17 Thread Daniel P. Berrange
The socket_listen method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_listen_opts/unix_listen_opts helper methods. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be eliminated This also fixes the proble

[Qemu-devel] [PATCH v2 1/5] sockets: remove use of QemuOpts from header file

2015-11-17 Thread Daniel P. Berrange
There are no callers of the sockets methods which accept QemuOpts any more. Make all the QemuOpts related functions static to avoid new callers being added, in preparation for removal of all QemuOpts usage, in favour of QAPI SocketAddress. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v2 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off

2015-11-17 Thread Daniel P. Berrange
The VNC code for interpreting QemuOpts does not currently distinguish between ipv4/ipv6 being omitted, and being set to 'off', because historically the 'ipv4' and 'ipv6' options were just flags which did not accept a value. The upshot is that if someone runs $QEMU -vnc localhost:1,ipv6=off QEM

[Qemu-devel] [PATCH v2 0/5] Convert qemu-socket to use QAPI exclusively

2015-11-17 Thread Daniel P. Berrange
A second posting of v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04950.html All the callers of the qemu-sockets module now use the APIs which take a QAPI SocketAddress. Thus we now have the fun situation with VNC & Chardevs that they use QemuOpts to parse the CLI args, then conv

Re: [Qemu-devel] [PATCH] target-mips: Fix exceptions while UX=0

2015-11-17 Thread James Hogan
Hi Leon, On Tue, Nov 17, 2015 at 04:09:24PM +, Leon Alrae wrote: > On 16/11/15 16:18, James Hogan wrote: > > However when exceptions are taken outside of exception level, > > mips_cpu_do_interrupt() manipulates the env->hflags directly rather than > > using compute_hflags() to update them, and

Re: [Qemu-devel] [PATCH v2 for 2.5] QEMU does not care about left shifts of signed negative values

2015-11-17 Thread Laszlo Ersek
On 11/17/15 16:47, Markus Armbruster wrote: > Laszlo Ersek writes: > >> I accept this is a defensible, maybe even reasonable choice to make in >> the QEMU project. On the other hand, I personally cannot stop hating >> shifting negative values (any direction) -- indeed, the *original* code >> from

  1   2   3   >