Re: [Qemu-devel] [PATCH v2] vhost-user: print original request on error

2015-11-16 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > When we get an unexpected response, print out > the original request. > Helps debug protocol errors tremendously. > > Signed-off-by: Michael S. Tsirkin > --- > > Changes from v1: add missing . > > hw/virtio/vhost-user.c | 4 ++-- > 1 file changed, 2 insertions(+),

[Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

2015-11-16 Thread Pavel Fedin
On some architectures TARGET_PAGE_ALIGN() is not enough to get the right alignment. For example on ARM TARGET_PAGE_BITS is 10 because some old CPUs support 1K page size, while minimum SMMU page size is 4K. This fixes problems like: 2015-11-17T07:37:42.892265Z qemu-system-aarch64: VFIO_MAP_DMA: -2

Re: [Qemu-devel] [PATCH COLO-Frame v10 10/38] COLO: Add a new RunState RUN_STATE_COLO

2015-11-16 Thread zhanghailiang
On 2015/11/14 0:47, Eric Blake wrote: On 11/03/2015 04:56 AM, zhanghailiang wrote: Guest will enter this state when paused to save/restore VM state under colo checkpoint. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Revi

Re: [Qemu-devel] blkdebug event names [was: What to do about QAPI naming convention violations]

2015-11-16 Thread Markus Armbruster
Eric Blake writes: > On 11/10/2015 07:35 AM, Markus Armbruster wrote: > Oddballs not related to case: * enum BlkdebugEvent uses '.' in member names > >> I had a closer look at how the screwy names are used in QMP to see how >> much of the mess is fixable within reason. >> > >> Blk

Re: [Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Fam Zheng
On Tue, 11/17 14:58, Stefan Hajnoczi wrote: > On Mon, Nov 16, 2015 at 02:10:36PM +0800, Fam Zheng wrote: > > When a request R is absorbed by request M, it is appended to the > > "mr_next" queue led by M, and is completed together with the completion > > of M, in virtio_blk_rw_complete. > > > > Wit

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 06:24:36PM +0300, Denis V. Lunev wrote: > +int bdrv_all_find_snapshot(const char *name, bool skip_read_only, > + BlockDriverState **first_bad_bs) > +{ > +QEMUSnapshotInfo sn; > +int err = 0; > +BlockDriverState *bs = NULL; > + > +whi

Re: [Qemu-devel] [PATCH] target-i386: Fix mulx for identical target

2015-11-16 Thread Richard Henderson
On 11/17/2015 04:40 AM, Max Reitz wrote: -tcg_gen_mulu2_i64(cpu_regs[s->vex_v], cpu_regs[reg], - cpu_T[0], cpu_regs[R_EDX]); +tcg_gen_op3_i64(INDEX_op_mul_i64, cpu_regs[s->vex_v], +cpu

Re: [Qemu-devel] [PATCH COLO-Frame v10 09/38] COLO: Implement colo checkpoint protocol

2015-11-16 Thread zhanghailiang
On 2015/11/14 0:46, Eric Blake wrote: On 11/03/2015 04:56 AM, zhanghailiang wrote: We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is started by Primary VM, and the interactive process like below: Checkpoint synchronizing points,

[Qemu-devel] [PATCH v2] vhost: Fix aborting if KVM does not support eventfds

2015-11-16 Thread Pavel Fedin
If you happen to have a stock kernel of old version, like 3.x, and you attempt to enable vhost by setting vhost=on, qemu aborts with error: kvm_mem_ioeventfd_add: error adding ioeventfd: Function not implemented This patch adds capability check, so that vhost gets disabled instead. A warning is d

Re: [Qemu-devel] [PATCH v4] mirror: Rewrite mirror_iteration

2015-11-16 Thread Fam Zheng
On Mon, 11/16 20:32, Max Reitz wrote: > On 12.11.2015 04:44, Fam Zheng wrote: > > The "pnum < nb_sectors" condition in deciding whether to actually copy > > data is unnecessarily strict, and the qiov initialization is > > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > > > Rewrit

Re: [Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 02:10:36PM +0800, Fam Zheng wrote: > When a request R is absorbed by request M, it is appended to the > "mr_next" queue led by M, and is completed together with the completion > of M, in virtio_blk_rw_complete. > > With error policy equals stop, if M has an I/O error, now R

Re: [Qemu-devel] [PATCH for-2.5] default-configs/aarch64-linux-user.mak: Remove unused define

2015-11-16 Thread Laurent Desnogues
Hi, On Mon, Nov 16, 2015 at 5:09 PM, Peter Maydell wrote: > The uses of the CONFIG_GDBSTUB_XML define were removed in commit > b77abd95a9484c, but the define in aarch64-linux-user.mak somehow > escaped the cull (the patchset probably crossed in the mail with > the patches adding aarch64 support).

Re: [Qemu-devel] RFC: raspberry pi / pi2 / Windows-on-ARM support

2015-11-16 Thread Stefan Weil
Am 16.11.2015 um 23:22 schrieb Andrew Baumann: > Hi all, > > I have been working on Raspberry Pi 2 emulation, building on the previous > work of Gregory Estrade, Stefan Weil and others on the original Raspberry Pi > target. My current working tree (based off a recent master) is here: > https

Re: [Qemu-devel] [PATCH v4 2/2] target-i386: add support to migrate vcpu's TSC rate

2015-11-16 Thread Haozhong Zhang
On 11/16/15 13:35, Eduardo Habkost wrote: > On Mon, Nov 16, 2015 at 10:30:08PM +0800, Haozhong Zhang wrote: > > On 11/16/15 11:43, Eduardo Habkost wrote: > > > On Mon, Nov 16, 2015 at 04:04:08PM +0800, Haozhong Zhang wrote: > > > > This patch enables migrating vcpu's TSC rate. If KVM on the destina

[Qemu-devel] [PATCH v5 2/3] target-i386: reorganize TSC rate setting code

2015-11-16 Thread Haozhong Zhang
Following two changes are made to the TSC rate setting code in kvm_arch_init_vcpu(): * The code is moved to a new function kvm_arch_set_tsc_khz(). * If setting user-specified TSC rate fails and the host TSC rate is inconsistent with the user-specified one, print a warning message. Signed-off-

[Qemu-devel] [PATCH v5 1/3] target-i386: fallback vcpu's TSC rate to value returned by KVM

2015-11-16 Thread Haozhong Zhang
If no user-specified TSC rate is present, we will try to set env->tsc_khz to the value returned by KVM_GET_TSC_KHZ. Signed-off-by: Haozhong Zhang --- target-i386/kvm.c | 12 1 file changed, 12 insertions(+) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 2a9953b..9e4d27f 1

[Qemu-devel] [PATCH v5 0/3] target-i386: save/restore vcpu's TSC rate during migration

2015-11-16 Thread Haozhong Zhang
This patchset enables QEMU to save/restore vcpu's TSC rate during the migration on machine types pc-*-2.5 or newer. On the source machine: * If the vcpu's TSC rate is specified by the cpu option 'tsc-freq', then this user-specified TSC rate will be migrated. * Otherwise, the TSC rate returned

[Qemu-devel] [PATCH v5 3/3] target-i386: add support to migrate vcpu's TSC rate

2015-11-16 Thread Haozhong Zhang
This patch enables migrating vcpu's TSC rate. If KVM on the destination machine supports TSC scaling, guest programs will observe a consistent TSC rate across the migration. If TSC scaling is not supported on the destination machine, the migration will not be aborted and QEMU on the destination wi

Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()

2015-11-16 Thread Fam Zheng
On Mon, 11/16 12:07, John Snow wrote: > > > On 11/15/2015 08:27 PM, Fam Zheng wrote: > > On Fri, 11/13 17:49, John Snow wrote: > >> > >> > >> On 11/12/2015 01:23 AM, Fam Zheng wrote: > >>> On Mon, 11/09 23:39, Max Reitz wrote: > bdrv_delete() is not very happy about deleting BlockDriverState

Re: [Qemu-devel] [PATCH V4 0/6] ide: avoid main-loop hang on CDROM/NFS failure

2015-11-16 Thread Fam Zheng
On Mon, 11/16 14:24, John Snow wrote: > >> It looks sane to me: > >> > >> Reviewed-by: John Snow > >> > >> Fam, Stefan: Do you think this is still sane for 2.5? I am inclined to > >> get it in as a fix, especially since we've been bouncing it around for > >> so long. > > > > I have no objection h

Re: [Qemu-devel] [PATCH for-2.5 v2 0/1] block: make 'stats-interval' an array of ints instead of a string

2015-11-16 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 11:28:37AM +0200, Alberto Garcia wrote: > Second version of the patch, following all suggestions by Stefan. > > v2: > - The code that parses the intervals has been moved to a separate > function > - Due to the previous change, the loop has been modified a bit and the >

Re: [Qemu-devel] [PATCH] aio-epoll: Fix use-after-free of node

2015-11-16 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 02:32:14PM +0800, Fam Zheng wrote: > aio_epoll_update needs the fields in node, so delay the free. > > Reported-by: Paolo Bonzini > Signed-off-by: Fam Zheng > --- > aio-posix.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Thanks, applied to my block tree

Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning

2015-11-16 Thread Stefan Hajnoczi
On Tue, Nov 10, 2015 at 03:57:32PM +, Stefan Hajnoczi wrote: > LLVM's clang 3.7.0 compile warns about bit shifting negative numbers because > the result is undefined. This series includes 3 small fixes to appease clang. > > Stefan Hajnoczi (3): > monitor: avoid clang shifting negative signe

Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning

2015-11-16 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 03:20:12PM +, Peter Maydell wrote: > On 16 November 2015 at 14:23, Peter Maydell wrote: > > My clang-3.7 build (it's part of fbinfer) also complains about: > > > > /Users/pm215/src/qemu/hw/audio/fmopl.c:1085:39: warning: shifting a > > negative signed value is undefined

[Qemu-devel] [PATCH] target-i386: Fix mulx for identical target

2015-11-16 Thread Max Reitz
Apparently in contrast to similar instructions on other architectures, x86's mulx will store the lower half of the result first, and the upper half later. If the same register is to be used for both, it will contain the upper half of the result after the operation. tcg_gen_mulu2_i64()'s default ca

Re: [Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device

2015-11-16 Thread Chen Fan
On 11/17/2015 12:05 AM, Alex Williamson wrote: On Mon, 2015-11-16 at 18:18 +0800, Chen Fan wrote: Hi Alex, Thanks for your detailed explanation. during my test, I found that maybe there was another problem in vfio driver, I use a dual-port NIC which address are: 06:00.0 and 06:00.1 two

[Qemu-devel] [PATCH] tpm: adapt sysfs cancel path for new TPM driver

2015-11-16 Thread Stefan Berger
Adapt the sysfs TPM command cancel path for the TPM driver that does not use a miscdevice anymore since Linux 4.0. Support old and new paths. Signed-off-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/

[Qemu-devel] Possible bug when executing an instruction.

2015-11-16 Thread Toni Nedialkov
There is some evidence to suggest that the instruction mulx rsp,rsp,rdx causes a segfault in QEMU. Was wondering if anyone would be kind enough to verify. And since I am not familiar with the bug reporting process, I am posting here. Thank you.

Re: [Qemu-devel] [PATCH v3 0/8] Add system_powerdown support on ARM for ACPI and DT

2015-11-16 Thread Shannon Zhao
Hi, On 2015/11/16 21:23, shannon.z...@linaro.org wrote: > [1] > https://git.linaro.org/people/shannon.zhao/qemu.git/shortlog/refs/heads/PowerButton_v2 Sorry, this link should be https://git.linaro.org/people/shannon.zhao/qemu.git/shortlog/refs/heads/PowerButton_v3 > [2] https://lkml.org/lkml/201

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/77] target-ppc: Use sensible POWER8/POWER8E versions

2015-11-16 Thread Benjamin Herrenschmidt
On Tue, 2015-11-17 at 11:11 +1100, Alexey Kardashevskiy wrote: > > I have never heard of anyone testing migration of TCG guests. KVM guests > use host PVR anyway. > > I just wonder that we "never released anything older than" but we still > support them in the kernel - why do not we wipe these

[Qemu-devel] [Bug 1516203] Re: qemu-system-x86_64 crashed with SIGSEGV in SDL_BlitCopy()

2015-11-16 Thread Serge Hallyn
(Note I cannot reproduce this here) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1516203 Title: qemu-system-x86_64 crashed with SIGSEGV in SDL_BlitCopy() Status in QEMU: New Status in qemu pack

Re: [Qemu-devel] [PATCH 41/77] ppc/pnv: Add LPC controller and hook it up with a UART and RTC

2015-11-16 Thread Benjamin Herrenschmidt
On Tue, 2015-11-17 at 11:32 +1100, Alexey Kardashevskiy wrote: > On 11/11/2015 11:27 AM, Benjamin Herrenschmidt wrote: > > This adds a model of the POWER8 LPC controller. It is then used > > by the PowerNV code to attach a UART and RTC, which, with the right > > version of OPAL firmware, will provi

Re: [Qemu-devel] [PATCH 41/77] ppc/pnv: Add LPC controller and hook it up with a UART and RTC

2015-11-16 Thread Alexey Kardashevskiy
On 11/11/2015 11:27 AM, Benjamin Herrenschmidt wrote: This adds a model of the POWER8 LPC controller. It is then used by the PowerNV code to attach a UART and RTC, which, with the right version of OPAL firmware, will provide a working console. This version of the LPC controller model doesn't yet

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/77] target-ppc: Use sensible POWER8/POWER8E versions

2015-11-16 Thread Alexey Kardashevskiy
On 11/16/2015 09:17 PM, Benjamin Herrenschmidt wrote: On Mon, 2015-11-16 at 16:01 +1100, David Gibson wrote: On Wed, Nov 11, 2015 at 11:27:17AM +1100, Benjamin Herrenschmidt wrote: We never released anything older than POWER8 DD2.0 and POWER8E DD2.1, so let's use these versions, without that so

[Qemu-devel] [PATCH v3 4/4] usb-mtp: add support for basic mtp events

2015-11-16 Thread Bandan Das
When the host polls for events, we check our events qlist and send one event at a time. Also, note that the event packet needs to be sent in one go, so I increased the max packet size to 64. Tested with a linux guest. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 27 +

[Qemu-devel] [PATCH v3 0/4] usb-mtp events support

2015-11-16 Thread Bandan Das
This series adds support for mtp events that are piggybacked on top of the Linux provided inotify mechanism. It performs well with some light unit testing in a linux guest. The mtp share is still read only, but now the guest will notice updates to the share as long as the mtp client being used supp

[Qemu-devel] [PATCH v3 3/4] usb-mtp: Add support for inotify based file monitoring

2015-11-16 Thread Bandan Das
For now, we use inotify watches to track only a small number of events, namely, add, delete and modify. Note that for delete, the kernel already deactivates the watch for us and we just need to take care of modifying our internal state. inotify is a linux only mechanism. Provide empty stubs and er

[Qemu-devel] [PATCH v3 1/4] usb-mtp: use a list for keeping track of children

2015-11-16 Thread Bandan Das
To support adding/removal of objects, we will need to update the object cache hierarchy we have built internally. Convert to using a Qlist for easier management. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 55 +++ trace-events | 1 +

[Qemu-devel] [PATCH v3 2/4] usb-mtp: free objects on a mtp reset

2015-11-16 Thread Bandan Das
On a reset, call usb_mtp_object_free on all objects and their children Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index eea2dad..c39b81a 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -907,6 +907

[Qemu-devel] blkdebug event names [was: What to do about QAPI naming convention violations]

2015-11-16 Thread Eric Blake
On 11/10/2015 07:35 AM, Markus Armbruster wrote: >>> Oddballs not related to case: >>> >>> * enum BlkdebugEvent uses '.' in member names > I had a closer look at how the screwy names are used in QMP to see how > much of the mess is fixable within reason. > > BlkdebugEvent is related to the exte

Re: [Qemu-devel] [PATCH 3/3] exec: silence hugetlbfs warning under qtest

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 06:23:38PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > vhost-user-test prints a warning. A test should not need to run on > hugetlbfs, let's silence the warning under qtest. Unfortunately, the > condition can't check on qtest_enabled() or qtest_

Re: [Qemu-devel] block/vpc: Fix vhd extra sectors issue

2015-11-16 Thread Max Reitz
On 13.11.2015 16:32, Lucian Petrut wrote: > > At the moment, qemu-img extends new image virtual sizes based > on the CHS algorithm provided by the VHD specs in order to > ensure that the disk geometry (and payload as seen by some > guests which use the CHS value) can fit in the requested disk. >

Re: [Qemu-devel] [PATCH for-2.5] makefile: fix w32 install target for qemu-ga

2015-11-16 Thread Stefan Weil
This mail arrived with one day delay (obviously caused by the mailing list server). Please see my comments below. Am 15.11.2015 um 17:12 schrieb Michael Roth: > fafcaf1 added a 'qemu-ga' install target on w32, which can be used > in place of the existing qemu-ga.exe target to also handle dealing >

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Paul Mackerras
On Mon, Nov 16, 2015 at 10:01:25AM +0100, Thomas Huth wrote: > On 16/11/15 04:50, Paul Mackerras wrote: > > On Thu, Nov 12, 2015 at 09:09:59AM +0100, Thomas Huth wrote: > >> > >> Shouldn't you also check MSR_ME here first and enter checkstop when > >> machine checks are disabled? > > > > MSR_ME is

[Qemu-devel] [Bug 1516203] Re: qemu-system-x86_64 crashed with SIGSEGV in SDL_BlitCopy()

2015-11-16 Thread Serge Hallyn
Thanks. (I thought I had upgraded my test system to xenial, but I hadn't, so virtio-vga was not supported) How far into the boot do you see this happening? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

Re: [Qemu-devel] [PATCH 1/1] vhost-user: modify SET_LOG_BASE only if VHOST_USER_PROTOCOL_F_LOG_SHMFD is set

2015-11-16 Thread Thibaut Collet
On Mon, Nov 16, 2015 at 6:09 PM, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2015 at 05:53:10PM +0100, Thibaut Collet wrote: >> On Mon, Nov 16, 2015 at 5:21 PM, Michael S. Tsirkin wrote: >> > On Mon, Nov 16, 2015 at 05:14:37PM +0100, Thibaut Collet wrote: >> >> Fixes: 2b8819c6eee5 ("vhost-user: m

Re: [Qemu-devel] block/vpc: Fix vhd extra sectors issue

2015-11-16 Thread Max Reitz
On 16.11.2015 21:58, Max Reitz wrote: > On 13.11.2015 16:32, Lucian Petrut wrote: >> >> At the moment, qemu-img extends new image virtual sizes based >> on the CHS algorithm provided by the VHD specs in order to >> ensure that the disk geometry (and payload as seen by some >> guests which use the C

Re: [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot

2015-11-16 Thread Max Reitz
On 13.11.2015 14:00, Alberto Garcia wrote: > Otherwise the AioContext will never be released. > > Signed-off-by: Alberto Garcia > --- > blockdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/blockdev.c b/blockdev.c > index fc85128..4dcc510 100644 > --- a/blockdev.c > +++ b/blockdev

[Qemu-devel] [PATCH 0/2] target-arm: Missed gen_set_condexec() in AA32 translation

2015-11-16 Thread Sergey Fedorov
Sergey Fedorov (2): target-arm: Update condexec before CP access check in AA32 translation target-arm: Update condexec before arch BP check in AA32 translation target-arm/translate.c | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1

[Qemu-devel] [PATCH v2 4/4] target-tilegx: Integrate floating pointer implementation

2015-11-16 Thread Chen Gang
>From d0f0e0a78e81f9589d25b0a2b4ad826d6e55257d Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Tue, 17 Nov 2015 03:09:18 +0800 Subject: [PATCH v2 4/4] target-tilegx: Integrate floating pointer implementation It passes normal building, and gcc testsuite. Signed-off-by: Chen Gang ---  target-tileg

[Qemu-devel] [PULL 05/20] buffer: add buffer_shrink

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-6-git-send-email-kra...@redhat.com --- include/qemu/buffer.h | 10 ++ util/buffer.c | 20 +++- 2 files changed, 29 insertions(+), 1 deletion(-) dif

[Qemu-devel] [PULL 15/20] vnc: fix local state init

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-16-git-send-email-kra...@redhat.com --- ui/vnc-jobs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index fd9ed39..12389

[Qemu-devel] [PULL 12/20] vnc: factor out vnc_update_server_surface

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-13-git-send-email-kra...@redhat.com --- ui/vnc.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 9ffad16..58a

[Qemu-devel] [PULL 20/20] vnc: fix mismerge

2015-11-16 Thread Gerd Hoffmann
Commit "4d77b1f vnc: fix bug: vnc server can't start when 'to' is specified" was rebased incorrectly, fix it. Reported-by: Markus Armbruster Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster Reviewed-by: Yang Hongyang Message-id: 1446714738-22400-1-git-send-email-kra...@redhat.com --

[Qemu-devel] [PULL 14/20] vnc: only alloc server surface with clients connected

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-15-git-send-email-kra...@redhat.com --- ui/vnc.c | 12 1 file changed, 12 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index eb1fcb3..a8cce5a 100644 --- a/ui/vnc.c

[Qemu-devel] [PATCH 3/3] exec: silence hugetlbfs warning under qtest

2015-11-16 Thread marcandre . lureau
From: Marc-André Lureau vhost-user-test prints a warning. A test should not need to run on hugetlbfs, let's silence the warning under qtest. Unfortunately, the condition can't check on qtest_enabled() or qtest_driver() since they are initialized later. Moving configure_accelerator() earlier is pr

[Qemu-devel] [PULL 17/20] buffer: factor out buffer_req_size

2015-11-16 Thread Gerd Hoffmann
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-18-git-send-email-kra...@redhat.com --- util/buffer.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/util/buffer.c b/util/buf

[Qemu-devel] [PULL 07/20] vnc: attach names to buffers

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-8-git-send-email-kra...@redhat.com --- ui/vnc-jobs.c | 3 +++ ui/vnc.c | 20 2 files changed, 23 insertions(+) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.

[Qemu-devel] [PULL 03/20] buffer: add buffer_move_empty

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel Berrange Message-id: 1446203414-4013-4-git-send-email-kra...@redhat.com --- include/qemu/buffer.h | 10 ++ util/buffer.c | 14 ++ 2 files changed, 24 insertions(+) diff --git a/include/qemu/b

Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()

2015-11-16 Thread John Snow
On 11/15/2015 08:27 PM, Fam Zheng wrote: > On Fri, 11/13 17:49, John Snow wrote: >> >> >> On 11/12/2015 01:23 AM, Fam Zheng wrote: >>> On Mon, 11/09 23:39, Max Reitz wrote: bdrv_delete() is not very happy about deleting BlockDriverStates with dirty bitmaps still attached to them. In the

Re: [Qemu-devel] virtio-input questions

2015-11-16 Thread Gerd Hoffmann
Hi, > > Seems I'll try to start from the curses.c then, if that's better way > > (my knowledge of qemu codebase is zero and I'm not a good developer > > either, but I may try in my free time since I need this and I'd like I wouldn't bother with curses. Better grab input events directly at t

[Qemu-devel] [PATCH 2/3] tests: re-enable vhost-user-test

2015-11-16 Thread marcandre . lureau
From: Marc-André Lureau Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, since CONFIG_VHOST_NET is a per-target config variable. tests/vhost-user-test is already x86/x64 softmmu specific test, in order to enable it correctly, kvm & vhost-net are also conditions. To check that, se

Re: [Qemu-devel] [PATCH 1/1] vhost-user: modify SET_LOG_BASE only if VHOST_USER_PROTOCOL_F_LOG_SHMFD is set

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 05:53:10PM +0100, Thibaut Collet wrote: > On Mon, Nov 16, 2015 at 5:21 PM, Michael S. Tsirkin wrote: > > On Mon, Nov 16, 2015 at 05:14:37PM +0100, Thibaut Collet wrote: > >> Fixes: 2b8819c6eee5 ("vhost-user: modify SET_LOG_BASE to pass mmap size and > >> offset") > >> > >>

[Qemu-devel] [Bug 1516408] Re: sh4: Unsupported syscall: 186

2015-11-16 Thread John Paul Adrian Glaubitz
I have enabled this syscall in the source code now and performing a test build and run and will report back. Furthermore, looking at the kernel sources, both the 32-bit and 64-bit Linux SH-specific code defines "sigaltstack" as syscall 186: > https://github.com/torvalds/linux/blob/master/arch/sh/

Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing

2015-11-16 Thread Dr. David Alan Gilbert
* Bohdan Trach (bv.tr...@gmail.com) wrote: > From: Bohdan Trach > > dump-pc-mem command is added for checkpointing guest memory to > file. Only system RAM region is saved. This checkpoint is later used to > recover unchanged pages. Why not just use the 'dump_guest_memory' commands; they dump it

[Qemu-devel] [Bug 1516446] [NEW] Migration always causes guest freeze in one direction.

2015-11-16 Thread Magnus Boden
Public bug reported: Hello, I have three debian jessie machines standard installations except for homebuild qemu-2.4.0 package using the source package from testing. I had the same problem with the standard debian jessie qemu 2.1 too. I have host A, B and C. Migrations work between all combinat

[Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-11-16 Thread Grundmann, Christian
Hi, Dan sent me over to you, please let me know if i can provide additional informations Softwareversions: ovirt-node-iso-3.6-0.999.201510221942.el7.centos.iso qemu-img-ev-2.3.0-29.1.el7.x86_64 qemu-kvm-ev-2.3.0-29.1.el7.x86_64 qemu-kvm-common-ev-2.3.0-29.1.el7.x86_64 qemu-kvm-tools-ev-2.3.0-29.

[Qemu-devel] [Bug 1516408] [NEW] sh4: Unsupported syscall: 186

2015-11-16 Thread John Paul Adrian Glaubitz
Public bug reported: Hello! I'm currently testing qemu as a possibility to set up a buildd for the Debian sh4 port. I set up qemu and an sh4 chroot as described in the Debian Wiki [1]. This seems to be working mostly fine (besides the fact that qemu segfaults on an amd64 host while it runs fine

Re: [Qemu-devel] [PATCH v2 3/4] target-tilegx: Add double floating point implementation

2015-11-16 Thread Chen Gang
Excuse me, I copied/pasted the patch to the website, which may generate the incorrect coding styles. Please check the attachment in this reply mail for the correct coding styles (and sorry, the original mail's attachment which I chose is incorrect). On 11/17/15 03:41, Chen Gang wrote: > From db1

[Qemu-devel] [PATCH v2 1/4] target-tilegx: Add floating point shared functions

2015-11-16 Thread Chen Gang
>From 40c3e3f79b206b9506e0d6679e301885bb3ee277 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Tue, 17 Nov 2015 03:04:50 +0800 Subject: [PATCH v2 1/4] target-tilegx: Add floating point shared functions They are used by fsingle and fdouble helpers. Signed-off-by: Chen Gang ---  target-tilegx/help

Re: [Qemu-devel] [PATCH V4 0/6] ide: avoid main-loop hang on CDROM/NFS failure

2015-11-16 Thread John Snow
On 11/16/2015 01:17 AM, Fam Zheng wrote: > On Fri, 11/13 17:44, John Snow wrote: >> >> >> On 11/12/2015 11:30 AM, Peter Lieven wrote: >>> This series aims at avoiding a hanging main-loop if a vserver has a >>> CDROM image mounted from a NFS share and that NFS share goes down. >>> Typical situatio

Re: [Qemu-devel] [PATCH V2 3/4] hw/pc: query both q35 and i440fx bus

2015-11-16 Thread Eduardo Habkost
On Sun, Nov 15, 2015 at 05:39:05PM +0200, Marcel Apfelbaum wrote: > Look for pxb devices on both i386 machines. > > Signed-off-by: Marcel Apfelbaum [...] > diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c > index c81507d..2fbbcd3 100644 > --- a/hw/pci-host/q35.c > +++ b/hw/pci-host/q35.c > @@ -

[Qemu-devel] [PULL 09/20] vnc-jobs: move buffer reset, use new buffer move

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-10-git-send-email-kra...@redhat.com --- ui/vnc-jobs.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 329d13

[Qemu-devel] [PATCH v2 2/4] target-tilegx: Add single floating point implementation

2015-11-16 Thread Chen Gang
>From 1c4bb91e72995a1675d3aa0f911c534a3e8db749 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Tue, 17 Nov 2015 03:07:33 +0800 Subject: [PATCH v2 2/4] target-tilegx: Add single floating point implementation Signed-off-by: Chen Gang ---  target-tilegx/helper-fsingle.c | 212 +++

Re: [Qemu-devel] [PATCH v2 4/4] target-tilegx: Integrate floating pointer implementation

2015-11-16 Thread Chen Gang
Excuse me, I copied/pasted the patch to the website, which may generate the incorrect coding styles. Please check the attachment in this reply mail for the correct coding styles (and sorry, the original mail's attachment which I chose is incorrect). On 11/17/15 03:43, Chen Gang wrote: > From d0

[Qemu-devel] [PULL 16/20] vnc: recycle empty vs->output buffer

2015-11-16 Thread Gerd Hoffmann
From: Peter Lieven If the vs->output buffer is empty it will be dropped by the next qio_buffer_move_empty in vnc_jobs_consume_buffer anyway. So reuse the allocated buffer from this buffer in the worker thread where we otherwise would start with an empty (unallocated buffer). Signed-off-by: Peter

[Qemu-devel] [PATCH v2 0/4] target-tilegx: Implement floating point instructions

2015-11-16 Thread Chen Gang
>From d0f0e0a78e81f9589d25b0a2b4ad826d6e55257d Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Tue, 17 Nov 2015 03:13:54 +0800 Subject: [PATCH v2 0/4] target-tilegx: Implement floating point instructions These patches are the normal floating point implementation, instead of the original temporary

[Qemu-devel] [PATCH 1/2] target-arm: Update condexec before CP access check in AA32 translation

2015-11-16 Thread Sergey Fedorov
Coprocessor access instructions are allowed inside IT block. gen_helper_access_check_cp_reg() can raise an exceptions thus condexec bits should be updated before. Signed-off-by: Sergey Fedorov --- target-arm/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-arm/translate.c b

Re: [Qemu-devel] [PULL for-2.5 0/2] qemu-ga patch queue for 2.5

2015-11-16 Thread Michael Roth
Quoting Peter Maydell (2015-11-16 06:09:17) > On 13 November 2015 at 22:40, Michael Roth wrote: > > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) > > > > are available in the git repository a

[Qemu-devel] [PULL 10/20] vnc: zap dead code

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-11-git-send-email-kra...@redhat.com --- ui/vnc.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index cdafd09d..49de39d 100644 --- a/ui/vnc.c +++ b/ui/v

[Qemu-devel] [PULL for-2.5 00/20] vnc: buffer code improvements, bugfixes.

2015-11-16 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-vnc-20151116-1 for you to fetch changes up to 382e1737d3467b76e8ade34b96afaae91509002e: vnc: fix mismerge (2015-11-05 16:01:37 +0100) vnc: buffer co

[Qemu-devel] [PATCH] target-arm/translate-a64.c: Correct unallocated checks for ldst_excl

2015-11-16 Thread Peter Maydell
The checks for the unallocated encodings in the ldst_excl group (exclusives and load-acquire/store-release) were not correct. This error meant that in turn we ended up with code attempting to handle the non-existent case of "non-exclusive load-acquire/store-release pair". Delete that broken and now

[Qemu-devel] [PULL 06/20] buffer: add tracing

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-7-git-send-email-kra...@redhat.com --- trace-events | 6 ++ util/buffer.c | 18 ++ 2 files changed, 24 insertions(+) diff --git a/trace-events b/trace-events

[Qemu-devel] [PULL 04/20] buffer: add buffer_move

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-5-git-send-email-kra...@redhat.com --- include/qemu/buffer.h | 10 ++ util/buffer.c | 16 2 files changed, 26 insertions(+) diff --git a/include/q

Re: [Qemu-devel] [PATCH v2 1/2] add support for KVM_CAP_SPLIT_IRQCHIP

2015-11-16 Thread Matt Gingell
This patch adds the initial plumbing for split IRQ chip mode via KVM_CAP_SPLIT_IRQCHIP. In addition to option processing, a number of kvm_*_in_kernel macros are defined to help clarify which component is where. Signed-off-by: Matt Gingell --- hw/core/machine.c| 49 +++

Re: [Qemu-devel] [PATCH v2] vhost-user: start/stop all rings

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote: > We are currently only sending VRING_ENABLE message for the first ring, > that's wrong: we must start/stop them all. > > Reported-by: Victor Kaplansky > Signed-off-by: Michael S. Tsirkin Note: this is on top of my tree. > --

[Qemu-devel] [PULL 19/20] buffer: allow a buffer to shrink gracefully

2015-11-16 Thread Gerd Hoffmann
From: Peter Lieven the idea behind this patch is to allow the buffer to shrink, but make this a seldom operation. The buffers average size is measured exponentionally smoothed with am alpha of 1/128. Signed-off-by: Peter Lieven Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange Mess

[Qemu-devel] [PULL 13/20] vnc: use vnc_{width, height} in vnc_set_area_dirty

2015-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-14-git-send-email-kra...@redhat.com --- ui/vnc.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 58a66b5..eb1f

[Qemu-devel] [PATCH v2] vhost-user: start/stop all rings

2015-11-16 Thread Michael S. Tsirkin
We are currently only sending VRING_ENABLE message for the first ring, that's wrong: we must start/stop them all. Reported-by: Victor Kaplansky Signed-off-by: Michael S. Tsirkin --- Changes from v1: typo fix hw/virtio/vhost-user.c | 17 +++-- 1 file changed, 11 insertions(+),

Re: [Qemu-devel] [PATCH 1/1] vhost-user: modify SET_LOG_BASE only if VHOST_USER_PROTOCOL_F_LOG_SHMFD is set

2015-11-16 Thread Thibaut Collet
On Mon, Nov 16, 2015 at 5:21 PM, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2015 at 05:14:37PM +0100, Thibaut Collet wrote: >> Fixes: 2b8819c6eee5 ("vhost-user: modify SET_LOG_BASE to pass mmap size and >> offset") >> >> For compatibility with old vhost backend content of the SET_LOG_BASE message

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Daniel P. Berrange
On Mon, Nov 16, 2015 at 05:44:35PM +0100, Andreas Färber wrote: > Am 16.11.2015 um 10:38 schrieb Andreas Färber: > > Am 16.11.2015 um 09:16 schrieb Christian Borntraeger: > >> On 11/16/2015 08:13 AM, Pavel Fedin wrote: > >> (process:4102): GLib-CRITICAL **: g_hash_table_iter_next: assertion > >

[Qemu-devel] [PULL 01/20] buffer: make the Buffer capacity increase in powers of two

2015-11-16 Thread Gerd Hoffmann
From: Peter Lieven This makes sure the number of reallocs is in O(log N). Signed-off-by: Peter Lieven Reviewed-by: Daniel P. Berrange Signed-off-by: Gerd Hoffmann Message-id: 1446203414-4013-2-git-send-email-kra...@redhat.com [ rebased to util/buffer.c ] Signed-off-by: Gerd Hoffmann --- u

[Qemu-devel] [PATCH v2 3/4] target-tilegx: Add double floating point implementation

2015-11-16 Thread Chen Gang
>From db171c94e8c9df446c091d9f42004c80ed8c6ccc Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Tue, 17 Nov 2015 03:08:38 +0800 Subject: [PATCH v2 3/4] target-tilegx: Add double floating point implementation Signed-off-by: Chen Gang ---  target-tilegx/helper-fdouble.c | 400 +++

Re: [Qemu-devel] [PATCH v2 3/4] target-tilegx: Add double floating point implementation

2015-11-16 Thread Chen Gang
Oh, sorry again, the original attachment is incorrect, either. The attachment in this reply is the correct one. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed > From: xili_gchen_5...@hotmail.com > To: r...@twi

[Qemu-devel] [PATCH 2/2] target-arm: Update condexec before arch BP check in AA32 translation

2015-11-16 Thread Sergey Fedorov
Architectural breakpoint check could raise an exceptions, thus condexec bits should be updated before calling gen_helper_check_breakpoints(). Signed-off-by: Sergey Fedorov --- target-arm/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-arm/translate.c b/target-arm/translate

Re: [Qemu-devel] [PATCH v4] mirror: Rewrite mirror_iteration

2015-11-16 Thread Max Reitz
On 12.11.2015 04:44, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > Signed-

Re: [Qemu-devel] [PATCH 1/2] add support for KVM_CAP_SPLIT_IRQCHIP

2015-11-16 Thread Matt Gingell
Hi Eric, Thanks for your comments. I’m submitting a v2 based on your feedback. Matt > On Nov 13, 2015, at 4:11 PM, Eric Blake wrote: > > On 11/13/2015 04:25 PM, Matt Gingell wrote: > > [meta-comment:] This patch was sent without an In-Reply-To header tying > it back to the 0/2 cover letter,

[Qemu-devel] [PATCH] qom: Clean up assertions to display values on failure

2015-11-16 Thread Andreas Färber
Instead of using g_assert() for integer comparisons, use g_assert_cmpint() so that we can see the respective values. While at it, fix one stray indentation. Cc: Daniel P. Berrange Signed-off-by: Andreas Färber --- qom/object.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[Qemu-devel] [PULL 18/20] buffer: factor out buffer_adj_size

2015-11-16 Thread Gerd Hoffmann
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange Message-id: 1446203414-4013-19-git-send-email-kra...@redhat.com --- util/buffer.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/util/bu

Re: [Qemu-devel] [PATCH RFC 2/3] memory: implement checkpoint handling

2015-11-16 Thread Dr. David Alan Gilbert
* Bohdan Trach (bv.tr...@gmail.com) wrote: > From: Bohdan Trach > > This commit adds functions, which are used to work with checkpoint > files. A new command-line option `-checkpoint` is added, which is used > to specify the checkpoint file. Currently, MD5 function from OpenSSL is > used to check

  1   2   3   4   >