[Qemu-devel] [PULL v3 00/15] Tracing patches

2015-11-12 Thread Stefan Hajnoczi
v3: * Include "exec/log.h" from translate-a64.c [Peter] v2: * Add missing log.py file [Peter] The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +) are available in the git reposi

Re: [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos

2015-11-12 Thread Markus Armbruster
Michael Tokarev writes: > 12.11.2015 20:53, Andreas Färber wrote: >> Am 06.11.2015 um 13:43 schrieb Michael Tokarev: >>> From: Cao jin >>> >>> Also change the misleading definition of macro OBJECT_CLASS_CHECK >>> >>> Signed-off-by: Cao jin >>> Signed-off-by: Michael Tokarev >> >> Michael, ple

Re: [Qemu-devel] [PATCH v2 7/7] spice: Initialization stubs on qemu-spice.h

2015-11-12 Thread Gerd Hoffmann
On Do, 2015-11-12 at 17:02 -0200, Eduardo Habkost wrote: > This reduces the number of CONFIG_SPICE #ifdefs in vl.c. > > Cc: Gerd Hoffmann > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Move stubs to qemu-spice.h, as the header file already > had a separate section for !CONFIG_S

Re: [Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental

2015-11-12 Thread Gerd Hoffmann
On Do, 2015-11-12 at 11:50 -0700, Eric Blake wrote: > The x-input-send-event command was introduced in 2.2 with mention > that it is experimental, but now that several releases have elapsed > without any changes, it would be nice to document why that was done > and should still remain experimental

[Qemu-devel] [PATCH 1/2] vhost: let SET_VRING_ENABLE message depends on protocol feature

2015-11-12 Thread Yuanhan Liu
But not depend on PROTOCOL_F_MQ feature bit. So that we could use SET_VRING_ENABLE to sign the backend on stop, even if MQ is disabled. That's reasonable, since we will have one queue pair at least. Signed-off-by: Yuanhan Liu --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH 2/2] vhost: don't send RESET_OWNER at stop

2015-11-12 Thread Yuanhan Liu
First of all, RESET_OWNER message is sent incorrectly, as it's sent before GET_VRING_BASE. And the reset message would let the later call get nothing correct. And, sending SET_VRING_ENABLE at stop, which has already been done, makes more sense than RESET_OWNER. Signed-off-by: Yuanhan Liu --- hw

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Thomas Huth
On 13/11/15 02:57, David Gibson wrote: > On Thu, Nov 12, 2015 at 10:40:11AM +0100, Thomas Huth wrote: >> On 12/11/15 09:09, Thomas Huth wrote: >>> On 11/11/15 18:16, Aravinda Prasad wrote: [...] +qemu_mutex_lock(&spapr->mc_in_progress); >>> >>> Using a mutex here is definitely wrong. The k

Re: [Qemu-devel] [RFC PATCH 0/8] Towards an Heterogeneous QEMU

2015-11-12 Thread Peter Crosthwaite
Hi Christian, Sorry about the delayed response. On Tue, Oct 27, 2015 at 3:30 AM, Christian Pinto < c.pi...@virtualopensystems.com> wrote: > > > On 25/10/2015 22:38, Peter Crosthwaite wrote: > > On Thu, Oct 22, 2015 at 2:21 AM, Christian > Pinto wrote: > > Hello Peter, > > > On 07/10/2015 17:48

Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
Eric Blake writes: > On 11/12/2015 03:55 PM, Bandan Das wrote: >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das >> --- >> hw/pci-host/piix.c | 5 + >> 1 file changed, 5 insertions(+) >> > >> @@ -301,6 +302,10 @@ static void i4

[Qemu-devel] [PATCH v3 0/2] Minor cleanups when parsing the "iommu" option

2015-11-12 Thread Bandan Das
Small cleanup changes. The first removes the helper function by directly checking the property and the second adds a error message if user tries to use "-machine iommu=on" with i440fx. v3: error_report does not need a \n! v2: 2/2: use error_report for the warning message Bandan Das (2): q35: C

[Qemu-devel] [PATCH v3 1/2] q35: Check propery to determine if iommu is set

2015-11-12 Thread Bandan Das
The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das --- hw/core/machine.c | 5 - hw/pci-host/q35.c | 2 +- include/hw/boards.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/core/machine.c b/hw/cor

[Qemu-devel] [PATCH v3 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
There's no indication of any sort that i440fx doesn't support "iommu=on" Reviewed-by: Eric Blake Signed-off-by: Bandan Das --- hw/pci-host/piix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..715208b 100644 --- a/hw/pci-host/piix

Re: [Qemu-devel] [PATCH] i.MX: add support for lower and upper interrupt in GPIO.

2015-11-12 Thread Peter Crosthwaite
On Wed, Oct 28, 2015 at 12:10 AM, Jean-Christophe DUBOIS wrote: > Le 27/10/2015 23:41, Peter Crosthwaite a écrit : > > > > On Tue, Oct 27, 2015 at 3:32 PM, Jean-Christophe Dubois > wrote: >> >> The i.MX6 GPIO device supports 2 interrupts instead of one. >> >> * 1 for the lower 16 GPIOs. >> * 1 fo

Re: [Qemu-devel] [PATCH v2 1/2] i.MX: rework CCM driver.

2015-11-12 Thread Peter Crosthwaite
On Wed, Oct 28, 2015 at 4:02 PM, Jean-Christophe Dubois wrote: > The CCM drive is in fact specific to the i.MX31. We need to add an i.MX25 > CCM driver. > > As a first step, we split the CCM driver into 2 parts: > 1) A common/utility part that allow to compute an manipulate clock freq for >any

Re: [Qemu-devel] [PATCH v2 2/2] i.MX: Add i.MX25 CCM driver

2015-11-12 Thread Peter Crosthwaite
On Wed, Oct 28, 2015 at 4:02 PM, Jean-Christophe Dubois wrote: > The i.MX25 CCM device is different from the i.MX31 one. > > So for now the emulation was not correct even if linux was working OK > on top of the i.MX25 emulation. > > We add an i.MX25 specific CCM driver and use it in the i.MX25 SOC

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Aravinda Prasad
On Friday 13 November 2015 11:27 AM, David Gibson wrote: > On Fri, Nov 13, 2015 at 10:23:20AM +0530, Aravinda Prasad wrote: >> >> >> On Friday 13 November 2015 07:28 AM, David Gibson wrote: >>> On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: On Thursday 12 November

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread David Gibson
On Fri, Nov 13, 2015 at 10:23:20AM +0530, Aravinda Prasad wrote: > > > On Friday 13 November 2015 07:28 AM, David Gibson wrote: > > On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: > >> > >> > >> On Thursday 12 November 2015 01:39 PM, Thomas Huth wrote: > >>> On 11/11/15 18:16, Ar

Re: [Qemu-devel] [PATCH v11 20/28] qapi: Forbid case-insensitive clashes

2015-11-12 Thread Eric Blake
On 11/11/2015 07:53 AM, Markus Armbruster wrote: > Eric Blake writes: > >> In general, designing user interfaces that rely on case >> distinction is poor practice. Another benefit of enforcing >> a restriction against case-insensitive clashes is that we >> no longer have to worry about the situa

Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Jeff Cody
On Thu, Nov 12, 2015 at 11:23:35AM -0500, Jeff Cody wrote: > On Thu, Nov 12, 2015 at 05:04:02AM -0500, Prasanna Kumar Kalever wrote: > > On Tuesday, November 10, 2015 9:37:20 PM, Eric Blake wrote: > > > > > > On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to sp

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Aravinda Prasad
On Friday 13 November 2015 07:28 AM, David Gibson wrote: > On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 12 November 2015 01:39 PM, Thomas Huth wrote: >>> On 11/11/15 18:16, Aravinda Prasad wrote: Memory error such as bit flips that cannot be corrected

Re: [Qemu-devel] [PATCH] nand: fix address overflow

2015-11-12 Thread Peter Crosthwaite
On Tue, Nov 10, 2015 at 7:09 AM, Paolo Bonzini wrote: > > > On 10/11/2015 14:25, Rabin Vincent wrote: >> The shifts of the address mask and value shift beyond 32 bits when there >> are 5 address cycles. >> >> Signed-off-by: Rabin Vincent >> --- >> hw/block/nand.c |4 ++-- >> 1 file changed,

[Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-12 Thread Programmingkid
On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: > Message: 3 > Date: Thu, 12 Nov 2015 22:24:08 +0100 > From: Herv? Poussineau > To: qemu-devel@nongnu.org > Cc: "open list:Old World" , Herv? Poussineau > > Subject: [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize >

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread David Gibson
On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: > > > On Thursday 12 November 2015 01:39 PM, Thomas Huth wrote: > > On 11/11/15 18:16, Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected > >> by hardware are passed on to the kernel for handling. >

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread David Gibson
On Thu, Nov 12, 2015 at 10:40:11AM +0100, Thomas Huth wrote: > On 12/11/15 09:09, Thomas Huth wrote: > > On 11/11/15 18:16, Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected > >> by hardware are passed on to the kernel for handling. > >> If the memory address in er

Re: [Qemu-devel] [PULL v2 00/15] Tracing patches

2015-11-12 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 11:20:52AM +, Peter Maydell wrote: > On 11 November 2015 at 07:34, Stefan Hajnoczi wrote: > > v2: > > * Fixed missing log.py file when merging "trace: convert stderr backend to > > log" [Peter] > > > > The following changes since commit a77067f6ac9b17beefea506ce5f5140

[Qemu-devel] [PATCH for-2.5 v2] tests: Ignore recent test binaries

2015-11-12 Thread Eric Blake
Commits 6c6f312d and bd797fc1 added new tests (test-blockjob-txn and test-timed-average, respectively), but did not mark them for exclusion in .gitignore. Signed-off-by: Eric Blake --- v2: retitle; also ignore test-timed-average tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn

2015-11-12 Thread Eric Blake
On 11/12/2015 07:27 PM, Stefan Hajnoczi wrote: > On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote: >> Commit 6c6f312d added a new test, but did not mark it for >> exclusion in .gitignore. >> >> Signed-off-by: Eric Blake >> --- >> >> Yeah, I know this affects only non-VPATH builds, which

Re: [Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device

2015-11-12 Thread Cao jin
On 11/12/2015 07:51 PM, Michael S. Tsirkin wrote: On Wed, Nov 11, 2015 at 06:34:27PM +0800, Cao jin wrote: From: Chen Fan Since we support multi-function hotplug. the function 0 indicate the closure of the slot, so we have the chance to do the check. Signed-off-by: Chen Fan --- hw/pci/pc

Re: [Qemu-devel] [v2 1/2] cutils: add avx2 instruction optimization

2015-11-12 Thread Li, Liang Z
> > This patch use the ifunc mechanism to select the proper function when > > running, for platform supports AVX2, excute the AVX2 instructions, > > else, excute the original code. > > > > Signed-off-by: Liang Li > > --- > > include/qemu-common.h | 28 +++-- > > util/Makefile.objs

Re: [Qemu-devel] [Qemu-block] [PULL v3 00/43] Block layer patches (Stefan's tree)

2015-11-12 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 05:26:43PM +0100, Alberto Garcia wrote: > On Thu, Nov 12, 2015 at 04:37:08PM +0100, Kevin Wolf wrote: > > The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: > > > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' > > into s

Re: [Qemu-devel] [Qemu-block] [PULL v3 00/43] Block layer patches (Stefan's tree)

2015-11-12 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 04:37:08PM +0100, Kevin Wolf wrote: > The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2015-11-12 14:15:32 +) > > are available in the git repositor

Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn

2015-11-12 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote: > Commit 6c6f312d added a new test, but did not mark it for > exclusion in .gitignore. > > Signed-off-by: Eric Blake > --- > > Yeah, I know this affects only non-VPATH builds, which we don't > recommend, but we might as well be consiste

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate

2015-11-12 Thread Haozhong Zhang
On 11/11/15 22:27, Haozhong Zhang wrote: > On 11/11/15 12:16, Eduardo Habkost wrote: [...] > > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > > index 2f8f396..858ed69 100644 > > > --- a/hw/i386/pc_q35.c > > > +++ b/hw/i386/pc_q35.c > > > @@ -385,6 +385,7 @@ static void pc_q35_2_4_machine_op

Re: [Qemu-devel] [PATCH v4 0/5] handle vhost reset/start/stop correctly

2015-11-12 Thread Yuanhan Liu
On Thu, Nov 12, 2015 at 04:44:19PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 12, 2015 at 10:08:15PM +0800, Yuanhan Liu wrote: > > On Thu, Nov 12, 2015 at 03:33:41PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Nov 11, 2015 at 09:24:36PM +0800, Yuanhan Liu wrote: > > > > > > > > Patch 1 rena

Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Eric Blake
On 11/12/2015 03:55 PM, Bandan Das wrote: > There's no indication of any sort that i440fx doesn't support > "iommu=on"" > > Signed-off-by: Bandan Das > --- > hw/pci-host/piix.c | 5 + > 1 file changed, 5 insertions(+) > > @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState

[Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
There's no indication of any sort that i440fx doesn't support "iommu=on"" Signed-off-by: Bandan Das --- hw/pci-host/piix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..ffcb846 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/pii

[Qemu-devel] [PATCH v2 1/2] q35: Check propery to determine if iommu is set

2015-11-12 Thread Bandan Das
The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das --- hw/core/machine.c | 5 - hw/pci-host/q35.c | 2 +- include/hw/boards.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/core/machine.c b/hw/cor

[Qemu-devel] [PATCH v2 0/2] Minor cleanups when parsing the "iommu" option

2015-11-12 Thread Bandan Das
Small cleanup changes. The first removes the helper function by directly checking the property and the second adds a error message if user tries to use "-machine iommu=on" with i440fx. v2: 2/2: use error_report for the warning message Bandan Das (2): q35: Check propery to determine if iommu is

Re: [Qemu-devel] [PATCH 0/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Eric Blake
[adding qemu-block] On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > This release is rebased on qemu master branch. > In this series of patches 1/4 and 2/4 are unchanged. According to scripts/get-maintainer.pl, this series should have cc'd qemu-bl...@nongnu.org. I don't know if anyone on

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- > qapi/block-core.json | 60 ++

Re: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das >> --- >> hw/pci-host/piix.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

2015-11-12 Thread Bandan Das
Gerd Hoffmann writes: > On Mo, 2015-11-09 at 18:12 -0500, Bandan Das wrote: >> Gerd Hoffmann writes: >> >> > On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: >> >> +/* Add a new watch asap so as to not lose events >> >> */ >> > >> > This comment sounds like there is a rac

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > This patch gives a mechanism to provide all the server addresses, which are in > repli

Re: [Qemu-devel] [PATCH v2 0/7] vl: graphics stubs + #ifdef cleanup

2015-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2015 at 02:17:53PM -0700, Eric Blake wrote: > On 11/12/2015 12:02 PM, Eduardo Habkost wrote: > > Clean up the graphics initialization code to reduce the number of > > > > Lame of git for eating lines that start with #ifdef. But at least it > doesn't matter on the cover letter :)

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- > qapi/block-core.json | 60 ++

Re: [Qemu-devel] [PATCH for-2.5 v5 1/1] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-12 Thread Peter Maydell
On 12 November 2015 at 17:54, Peter Crosthwaite wrote: > From: Guenter Roeck > > Add support for the Xilinx XADC core used in Zynq 7000. > > References: > - Zynq-7000 All Programmable SoC Technical Reference Manual > - 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC > Dual 12-Bit 1 MSPS

[Qemu-devel] [PATCH] scsi: remove scsi_req_free prototype

2015-11-12 Thread Hervé Poussineau
Function has been deleted in ad2d30f79d3b0812f02c741be2189796b788d6d7. Signed-off-by: Hervé Poussineau --- include/hw/scsi/scsi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h index cdaf0f8..1915a73 100644 --- a/include/hw/scsi/scsi.h +++ b/in

[Qemu-devel] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-12 Thread Hervé Poussineau
dbdma_from_ch() uses channel field to return the right DBDMA object. Previous code was working if guest OS was only using registered DMA channels. However, it lead to QEMU crashes if guest OS was using unregistered DMA channels. Signed-off-by: Hervé Poussineau --- hw/misc/macio/mac_dbdma.c | 2

Re: [Qemu-devel] [PATCH v2 0/7] vl: graphics stubs + #ifdef cleanup

2015-11-12 Thread Eric Blake
On 11/12/2015 12:02 PM, Eduardo Habkost wrote: > Clean up the graphics initialization code to reduce the number of > Lame of git for eating lines that start with #ifdef. But at least it doesn't matter on the cover letter :) > Changes v1 -> v2: > * Patches 2-6: Move stub files to stubs/ui/ > * P

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json Missing a vNN in the subject line. I think we're up to v14? But it doesn't affect what 'git am' will do. > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 >

Re: [Qemu-devel] [PATCH] tests/.gitignore: ignore test-blockjob-txn

2015-11-12 Thread John Snow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11/12/2015 03:31 PM, Eric Blake wrote: > On 11/12/2015 01:21 PM, John Snow wrote: >> Reported-by: Eric Blake Signed-off-by: John >> Snow --- tests/.gitignore | 1 + 1 file >> changed, 1 insertion(+) > > My version of this same patch at least c

Re: [Qemu-devel] [PATCH] tests/.gitignore: ignore test-blockjob-txn

2015-11-12 Thread Eric Blake
On 11/12/2015 01:21 PM, John Snow wrote: > Reported-by: Eric Blake > Signed-off-by: John Snow > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) My version of this same patch at least called out the commit that introduced the problem :) https://lists.gnu.org/archive/html/qemu-deve

Re: [Qemu-devel] [PATCH 1/4] block/gluster: rename [server, volname, image] -> [host, volume, path]

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch is very much be meaningful after next patch which adds multiple > gluster servers support. After that, > > an example is, in 'servers' tuple values we use 'server' variable for key Awkward line break mid-sentence. The commit mes

[Qemu-devel] [PATCH] tests/.gitignore: ignore test-blockjob-txn

2015-11-12 Thread John Snow
Reported-by: Eric Blake Signed-off-by: John Snow --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index e96f569..de5e793 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -9,6 +9,7 @@ check-qom-proplist rcutorture test-aio test

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Eric Blake
On 11/12/2015 12:56 PM, Dr. David Alan Gilbert wrote: >> One thing I still can't understand, why the unit test in host environment >> shows >> 'memcmp()' have better performance? Have you tried running under a profiler, to see if there are hotspots or at least get an idea of where the time is be

[Qemu-devel] which machinetypes have an integrated/implied IDE controller?

2015-11-12 Thread Laine Stump
For a long time, libvirt assumed by default that all types of virtual machines had an integrated IDE controller named "ide" that wasn't specified on the qemu commandline. Since that caused problems specifically for the Q35 machine type (which has an *ahci* controller that it perplexingly calls

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Jeff Cody
On Thu, Nov 12, 2015 at 03:52:08PM +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currently VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Jeff Cody
On Thu, Nov 12, 2015 at 03:52:07PM +0530, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- > qapi/block-core.json | 60

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

2015-11-12 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > >> > > > >> > I use your new code: > > >> > - > > >> >unsigned long *p = ... > > >> >if (p[0] || p[1] || p[2] || p[3] > > >> >|| memcmp(p+4, p, size - 4 * sizeof(unsigned long

[Qemu-devel] [PATCH 3/3] qtest/ahci: use raw format when qemu-img is absent

2015-11-12 Thread John Snow
If we don't have the qemu-img tool, use the raw format for tests and skip the high-sector LBA48 tests. Signed-off-by: John Snow --- tests/ahci-test.c | 41 - 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test

[Qemu-devel] [PATCH 1/3] qtest/ahci: always specify image format

2015-11-12 Thread John Snow
Signed-off-by: John Snow --- tests/ahci-test.c | 51 +-- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 59d387c..6d9ac84 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -48,6 +48

[Qemu-devel] [PATCH 0/3] qtest/ahci: skip qcow2 tests

2015-11-12 Thread John Snow
Skip tests that need qcow2 to function when qemu-img isn't set or otherwise present. When running under raw mode, we no longer properly test LBA48 reads/writes beyond 137Gb. ahci-test will skip past any //io//lba48//high test. While we're at it, try to make failures due to missing qemu-img binari

[Qemu-devel] [PATCH 2/3] libqos: add qemu-img presence check

2015-11-12 Thread John Snow
To allow tests to optionally exercise additional tests that require the qemu-img tool that may not be present in all builds. Signed-off-by: John Snow --- tests/libqos/libqos.c | 28 +++- tests/libqos/libqos.h | 1 + 2 files changed, 24 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH 09/12] vl: Replace DT_NOGRAPHIC with MachineState field

2015-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2015 at 10:48:12AM +0100, Paolo Bonzini wrote: > > > On 11/11/2015 20:09, Eduardo Habkost wrote: > > All DisplayType values are just UI options that don't affect any > > hardware emulation code, except for DT_NOGRAPHIC. Replace > > DT_NOGRAPHIC with DT_NONE plus a new MachineState

[Qemu-devel] [PATCH for-2.5 v5 1/1] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-12 Thread Peter Crosthwaite
From: Guenter Roeck Add support for the Xilinx XADC core used in Zynq 7000. References: - Zynq-7000 All Programmable SoC Technical Reference Manual - 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC Dual 12-Bit 1 MSPS Analog-to-Digital Converter Tested with Linux using QEMU machine xili

Re: [Qemu-devel] [PATCH for-2.5 v5 1/1] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-12 Thread Guenter Roeck
On Thu, Nov 12, 2015 at 09:54:55AM -0800, Peter Crosthwaite wrote: > From: Guenter Roeck > > Add support for the Xilinx XADC core used in Zynq 7000. > > References: > - Zynq-7000 All Programmable SoC Technical Reference Manual > - 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC > Dual 1

[Qemu-devel] [PATCH v4 03/17] ipmi: Add a local BMC simulation

2015-11-12 Thread minyard
From: Corey Minyard This provides a minimal local BMC, basically enough to comply with the spec and provide a complete watchdog timer (including a sensor, SDR, and event). Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 +

[Qemu-devel] [PATCH v3] tests/vhost-user-bridge: implement logging of dirty pages

2015-11-12 Thread Victor Kaplansky
During migration devices continue writing to the guest's memory. The writes has to be reported to QEMU. This change implements minimal support in vhost-user-bridge required for successful migration of a guest with virtio-net device. Signed-off-by: Victor Kaplansky --- v3: - Get rid of vhost_l

[Qemu-devel] [PATCH v4 14/17] ipmi: Add SMBIOS table entry

2015-11-12 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/smbios/Makefile.objs| 2 + hw/smbios/ipmi.c | 75 +++

[Qemu-devel] [PATCH v4 17/17] ipmi: Add a force off function

2015-11-12 Thread minyard
From: Corey Minyard Allow the IPMI interface to request a forced power off. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 05b9121..7ae6294 100644 --- a/hw/ipmi/ipmi

[Qemu-devel] [PATCH v4 08/17] ipmi: Add documentation

2015-11-12 Thread minyard
From: Corey Minyard Add some basic documentation for the IPMI device. Signed-off-by: Corey Minyard --- qemu-options.hx | 52 1 file changed, 52 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 0eea4ee..985d2ab 100644 --- a

[Qemu-devel] [PATCH v4 05/17] ipmi: Add an ISA KCS low-level interface

2015-11-12 Thread minyard
From: Corey Minyard This provides the simulation of the KCS hardware interface. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/isa_ipmi_kcs.c | 452

[Qemu-devel] [PATCH v4 12/17] smbios: Move table build tools into an include file.

2015-11-12 Thread minyard
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77 2 files changed,

[Qemu-devel] [PATCH v4 06/17] ipmi: Add a BT low-level interface

2015-11-12 Thread minyard
From: Corey Minyard This provides the simulation of the BT hardware interface for IPMI. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/isa_ipmi_bt.c | 489

[Qemu-devel] [PATCH v4 15/17] acpi: Add IPMI table entries

2015-11-12 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_ssdt to add an SSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not compiled in. This conforms

[Qemu-devel] [PATCH v4 09/17] ipmi: Add migration capability to the IPMI devices.

2015-11-12 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 34 ++ hw/ipmi/ipmi_bmc_sim.c| 30 ++ hw/ipmi/isa_ipmi_bt.c | 24 hw/ipmi/isa_ipmi_kcs.c| 26

[Qemu-devel] [PATCH v4 07/17] ipmi: Add tests

2015-11-12 Thread minyard
From: Corey Minyard Test the KCS interface with a local BMC and a BT interface with an external BMC. Signed-off-by: Corey Minyard --- tests/Makefile| 4 + tests/ipmi-bt-test.c | 436 ++ tests/ipmi-kcs-test.c | 295 +

[Qemu-devel] [PATCH v4 13/17] pc: Postpone SMBIOS table installation to post machine init

2015-11-12 Thread minyard
From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c inde

[Qemu-devel] [PATCH v4 00/17] Add an IPMI device to QEMU

2015-11-12 Thread minyard
This is a long delayed patch set, but I think I have things reworked to make Igor happy with the way ACPI and SMBIOS work. This is more consistent with the way most other things work, anyway. It did require adding stubs for systems without IPMI. The first nine patches are unchanged. The IPMI fi

[Qemu-devel] [PATCH v2 6/7] stubs: gtk_display_init() stub

2015-11-12 Thread Eduardo Habkost
This reduces the number of CONFIG_GTK #ifdefs in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ --- stubs/ui/Makefile.objs | 1 + stubs/ui/gtk.c | 10 ++ vl.c | 4 3 files changed, 11 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v4 04/17] ipmi: Add an external connection simulation interface

2015-11-12 Thread minyard
From: Corey Minyard This adds an interface for IPMI that connects to a remote BMC over a chardev (generally a TCP socket). The OpenIPMI lanserv simulator describes this interface, see that for interface details. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + defa

[Qemu-devel] [PATCH v2 5/7] stubs: cocoa_display_init() stub

2015-11-12 Thread Eduardo Habkost
One less #ifdef in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ --- stubs/ui/Makefile.objs | 1 + stubs/ui/cocoa.c | 10 ++ vl.c | 2 -- 3 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 stubs/ui/co

[Qemu-devel] [PATCH v4 11/17] ipmi: Add firmware registration to the ISA interface

2015-11-12 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- hw/ipmi/isa_ipmi_bt.c | 15 +++ hw/ipmi/isa_ipmi_kcs.c | 15 +++ 2 files changed, 30 insertions(+) diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index 03eb9cc..21fa4a7 100644 --- a/hw/ipmi/isa_ipmi_bt.c

[Qemu-devel] [PATCH v2 7/7] spice: Initialization stubs on qemu-spice.h

2015-11-12 Thread Eduardo Habkost
This reduces the number of CONFIG_SPICE #ifdefs in vl.c. Cc: Gerd Hoffmann Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stubs to qemu-spice.h, as the header file already had a separate section for !CONFIG_SPICE --- include/ui/qemu-spice.h | 13 + vl.c

[Qemu-devel] [PATCH v4 02/17] Add a base IPMI interface

2015-11-12 Thread minyard
From: Corey Minyard Add the basic IPMI types and infrastructure to QEMU. Low-level interfaces and simulation interfaces will register with this; it's kind of the go-between to tie them together. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_6

[Qemu-devel] [PATCH v2 4/7] stubs: SDL initialization stubs

2015-11-12 Thread Eduardo Habkost
This reduces the number of CONFIG_SDL #ifdefs in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ --- stubs/ui/Makefile.objs | 1 + stubs/ui/sdl.c | 17 + vl.c | 6 ++ 3 files changed, 20 insertions(+), 4 del

[Qemu-devel] [PATCH v2 2/7] stubs: VNC initialization stubs

2015-11-12 Thread Eduardo Habkost
This reduces the number of CONFIG_VNC #ifdefs in the vl.c code. The only user-visible difference is that this will make QEMU complain about syntax when using "-display vnc" ("VNC requires a display argument vnc=") even if CONFIG_VNC is disabled. Signed-off-by: Eduardo Habkost --- Changes v1 -> v

[Qemu-devel] [PATCH v4 10/17] ipmi: Add a firmware configuration repository

2015-11-12 Thread minyard
From: Corey Minyard Add a way for IPMI devices to register their firmware information with the IPMI subsystem so that various firmware entities can pull that information later for adding to firmware tables. Signed-off-by: Corey Minyard --- hw/ipmi/ipmi.c | 27 ++

[Qemu-devel] [PATCH v2 0/7] vl: graphics stubs + #ifdef cleanup

2015-11-12 Thread Eduardo Habkost
Clean up the graphics initialization code to reduce the number of Changes v1 -> v2: * Patches 2-6: Move stub files to stubs/ui/ * Patch 7: Move stubs to qemu-spice.h, as the header file already had a separate section for !CONFIG_SPICE * Removed DT_NOGRAPHIC patches from the series (they will be

[Qemu-devel] [PATCH v2 3/7] stubs: curses_display_init() stub

2015-11-12 Thread Eduardo Habkost
One less #ifdef in vl.c. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Move stub file to stubs/ui/ --- stubs/ui/Makefile.objs | 1 + stubs/ui/curses.c | 10 ++ vl.c | 2 -- 3 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 stubs/ui/cu

[Qemu-devel] [PATCH v2 1/7] vl: Add DT_COCOA DisplayType value

2015-11-12 Thread Eduardo Habkost
Instead of reusing DT_SDL for Cocoa, use DT_COCOA to indicate that a Cocoa display was requested. configure already ensures CONFIG_COCOA and CONFIG_SDL are never set at the same time. The only case where DT_SDL is used outside a #ifdef CONFIG_SDL block is in the no_frame/alt_grab/ctrl_grab check.

Re: [Qemu-devel] [PATCH 1/4] spapr: Extend rtas-blob

2015-11-12 Thread Aravinda Prasad
On Thursday 12 November 2015 01:56 PM, Thomas Huth wrote: > On 11/11/15 18:15, Aravinda Prasad wrote: >> Extend rtas-blob to accommodate error log. Error log >> structure is saved in rtas space upon a machine check >> exception. >> >> Signed-off-by: Aravinda Prasad >> --- >> hw/ppc/spapr.c |

Re: [Qemu-devel] [PULL 0/6] Migration pull request

2015-11-12 Thread Peter Maydell
f11d9ac5fb4b4c89d455a4f1ae8083: > > target-arm: Update PC before calling gen_helper_check_breakpoints() > (2015-11-12 16:16:02 +) > > are available in the git repository at: > > git://github.com/juanquintela/qemu.git tags/migration/20151112 > > for you to fet

Re: [Qemu-devel] [PATCH 3/4] spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2015-11-12 Thread Aravinda Prasad
On Thursday 12 November 2015 02:53 PM, Thomas Huth wrote: > On 11/11/15 18:15, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The machine check notification address is saved when the >> OS issues "ibm,nmi-registe

[Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental

2015-11-12 Thread Eric Blake
The x-input-send-event command was introduced in 2.2 with mention that it is experimental, but now that several releases have elapsed without any changes, it would be nice to document why that was done and should still remain experimental in 2.5. Meanwhile, our documentation states that we prefer

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Aravinda Prasad
On Thursday 12 November 2015 03:10 PM, Thomas Huth wrote: > On 12/11/15 09:09, Thomas Huth wrote: >> On 11/11/15 18:16, Aravinda Prasad wrote: >>> Memory error such as bit flips that cannot be corrected >>> by hardware are passed on to the kernel for handling. >>> If the memory address in error b

Re: [Qemu-devel] [OpenBIOS] CUDA has problems with Mac OS 10.4

2015-11-12 Thread BALATON Zoltan
On Thu, 12 Nov 2015, Programmingkid wrote: On Nov 11, 2015, at 6:14 PM, BALATON Zoltan wrote: better but some OSes may depend on ADB for now. I've noticed Finnix had no keyboard in debug mode without ADB (which may be a bug in Finnix, I could not verify if it works on real hardware or has the s

[Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn

2015-11-12 Thread Eric Blake
Commit 6c6f312d added a new test, but did not mark it for exclusion in .gitignore. Signed-off-by: Eric Blake --- Yeah, I know this affects only non-VPATH builds, which we don't recommend, but we might as well be consistent. tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/t

Re: [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos

2015-11-12 Thread Michael Tokarev
12.11.2015 20:53, Andreas Färber wrote: > Am 06.11.2015 um 13:43 schrieb Michael Tokarev: >> From: Cao jin >> >> Also change the misleading definition of macro OBJECT_CLASS_CHECK >> >> Signed-off-by: Cao jin >> Signed-off-by: Michael Tokarev > > Michael, please *STOP* queuing QOM patches! You m

Re: [Qemu-devel] [PULL 23/44] tests: add BlockJobTxn unit test

2015-11-12 Thread Eric Blake
On 11/10/2015 07:14 AM, Stefan Hajnoczi wrote: > The BlockJobTxn unit test verifies that both single jobs and pairs of > jobs behave as a transaction group. Either all jobs complete > successfully or the group is cancelled. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Max Reitz > Reviewed-

  1   2   3   4   >